github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Show full screen option even when write controls are hidden (#13247) (#13385)

Browse source
This commit is contained in:
Stacey Gammon 2017-08-08 13:27:37 -04:00 • committed by GitHub
parent 0cbd62c2fe
commit fdfd477ccf
2 changed files with 15 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core_plugins/kibana/public/dashboard/dashboard.js
View file

@ -267,7 +267,7 @@ app.directive('dashboardApp', function ($injector) {
$scope.$listen(timefilter, 'fetch', $scope.refresh);
function updateViewMode(newMode) {
$scope.topNavMenu = dashboardConfig.getHideWriteControls() ? [] : getTopNavConfig(newMode, navActions); // eslint-disable-line no-use-before-define
$scope.topNavMenu = getTopNavConfig(newMode, navActions, dashboardConfig.getHideWriteControls()); // eslint-disable-line no-use-before-define
dashboardState.switchViewMode(newMode);
$scope.dashboardViewMode = newMode;
}

20
src/core_plugins/kibana/public/dashboard/top_nav/get_top_nav_config.js
View file

@ -5,17 +5,25 @@ import { TopNavIds } from './top_nav_ids';
* @param {DashboardMode} dashboardMode.
* @param actions {Object} - A mapping of TopNavIds to an action function that should run when the
* corresponding top nav is clicked.
* @param hideWriteControls {boolean} if true, does not include any controls that allow editing or creating objects.
* @return {Array<kbnTopNavConfig>} - Returns an array of objects for a top nav configuration, based on the
* mode.
*/
export function getTopNavConfig(dashboardMode, actions) {
export function getTopNavConfig(dashboardMode, actions, hideWriteControls) {
switch (dashboardMode) {
case DashboardViewMode.VIEW:
return [
getFullScreenConfig(actions[TopNavIds.FULL_SCREEN]),
getShareConfig(),
getCloneConfig(actions[TopNavIds.CLONE]),
getEditConfig(actions[TopNavIds.ENTER_EDIT_MODE])];
return (
hideWriteControls ?
[
getFullScreenConfig(actions[TopNavIds.FULL_SCREEN])
]
: [
getFullScreenConfig(actions[TopNavIds.FULL_SCREEN]),
getShareConfig(),
getCloneConfig(actions[TopNavIds.CLONE]),
getEditConfig(actions[TopNavIds.ENTER_EDIT_MODE])
]
);
case DashboardViewMode.EDIT:
return [
getSaveConfig(),