github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.14] Fixing flaky ml test (#183139) (#188986)

Browse source 
# Backport

This will backport the following commits from `main` to `8.14`:
- [Fixing flaky ml test
(#183139)](https://github.com/elastic/kibana/pull/183139)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ying
Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2024-05-10T20:55:01Z","message":"Fixing
flaky ml test (#183139)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/177215\r\n\r\nChanging ML rule
functional test to stop the transform first, then\r\ncreating the rule.
The rule runs when it is created and the test is\r\ntesting for
`event.action: \"open\"` which is written on a new alert, so\r\nwe only
want to rule to run once. Removed the unnecessary
`runSoon`\r\ncall.\r\n\r\nFlaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5929","sha":"57d5f935c1ec9c0c5e1320a4632d298fab66c37c","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Alerting/RuleTypes","v8.14.0","v8.15.0"],"number":183139,"url":"https://github.com/elastic/kibana/pull/183139","mergeCommit":{"message":"Fixing
flaky ml test (#183139)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/177215\r\n\r\nChanging ML rule
functional test to stop the transform first, then\r\ncreating the rule.
The rule runs when it is created and the test is\r\ntesting for
`event.action: \"open\"` which is written on a new alert, so\r\nwe only
want to rule to run once. Removed the unnecessary
`runSoon`\r\ncall.\r\n\r\nFlaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5929","sha":"57d5f935c1ec9c0c5e1320a4632d298fab66c37c"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/183139","number":183139,"mergeCommit":{"message":"Fixing
flaky ml test (#183139)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/177215\r\n\r\nChanging ML rule
functional test to stop the transform first, then\r\ncreating the rule.
The rule runs when it is created and the test is\r\ntesting for
`event.action: \"open\"` which is written on a new alert, so\r\nwe only
want to rule to run once. Removed the unnecessary
`runSoon`\r\ncall.\r\n\r\nFlaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5929","sha":"57d5f935c1ec9c0c5e1320a4632d298fab66c37c"}}]}]
BACKPORT-->
This commit is contained in:
Ying Mao 2024-07-23 17:41:34 -04:00 • committed by GitHub
parent 8a363ab4d5
commit fe27cb94c5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/transform_rule_types/transform_health/rule.ts
View file

@ -23,7 +23,6 @@ import { TRANSFORM_HEALTH_RESULTS } from '@kbn/transform-plugin/common/constants
import { FtrProviderContext } from '../../../../../../common/ftr_provider_context';
import { getUrlPrefix, ObjectRemover } from '../../../../../../common/lib';
import { Spaces } from '../../../../../scenarios';
import { runSoon } from '../../../group3/test_helpers';
const CONNECTOR_TYPE_ID = '.index';
const RULE_TYPE_ID = 'transform_health';
@ -31,8 +30,6 @@ const ES_TEST_INDEX_SOURCE = 'transform-alert:transform-health';
const ES_TEST_INDEX_REFERENCE = '-na-';
const ES_TEST_OUTPUT_INDEX_NAME = `${ES_TEST_INDEX_NAME}-ts-output`;
const RULE_INTERVAL_SECONDS = 10000;
interface CreateRuleParams {
name: string;
includeTransforms: string[];
@ -115,15 +112,13 @@ export default function ruleTests({ getService }: FtrProviderContext) {
});
it('runs correctly', async () => {
await stopTransform(transformId);
const ruleId = await createRule({
name: 'Test all transforms',
includeTransforms: ['*'],
});
await stopTransform(transformId);
await runSoon({ id: ruleId, supertest, retry });
log.debug('Checking created alerts...');
const docs = await waitForDocs(1);
@ -197,7 +192,7 @@ export default function ruleTests({ getService }: FtrProviderContext) {
consumer: 'alerts',
enabled: true,
rule_type_id: RULE_TYPE_ID,
schedule: { interval: `${RULE_INTERVAL_SECONDS}s` },
schedule: { interval: '1d' },
actions: [action],
notify_when: 'onActiveAlert',
params: {