github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Make onChange in CodeEditor optional (#107128)

Browse source 
* Make onChang in CodeEditor optional

* Update api docs
This commit is contained in:
Tim Roes 2021-07-29 15:37:43 +02:00 • committed by GitHub
parent c98ffa5339
commit ff3029f1b7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 5 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

39
api_docs/kibana_react.json
View file

@ -3719,48 +3719,15 @@
"label": "onChange",
"description": [],
"signature": [
"(value: string, event: ",
"((value: string, event: ",
"editor",
".IModelContentChangedEvent) => void"
".IModelContentChangedEvent) => void) | undefined"
],
"source": {
"path": "src/plugins/kibana_react/public/url_template_editor/url_template_editor.tsx",
"lineNumber": 27
},
"deprecated": false,
"returnComment": [],
"children": [
{
"parentPluginId": "kibanaReact",
"id": "def-public.value",
"type": "string",
"tags": [],
"label": "value",
"description": [],
"source": {
"path": "src/plugins/kibana_react/public/code_editor/code_editor.tsx",
"lineNumber": 37
},
"deprecated": false
},
{
"parentPluginId": "kibanaReact",
"id": "def-public.event",
"type": "Object",
"tags": [],
"label": "event",
"description": [],
"signature": [
"editor",
".IModelContentChangedEvent"
],
"source": {
"path": "src/plugins/kibana_react/public/code_editor/code_editor.tsx",
"lineNumber": 37
},
"deprecated": false
}
]
"deprecated": false
},
{
"parentPluginId": "kibanaReact",

2
api_docs/kibana_react.mdx
View file

@ -18,7 +18,7 @@ import kibanaReactObj from './kibana_react.json';
| Public API count | Any count | Items lacking comments | Missing exports |
|-------------------|-----------|------------------------|-----------------|
| 260 | 5 | 230 | 4 |
| 258 | 5 | 228 | 4 |
## Client

1
src/plugins/discover/public/application/components/json_code_editor/json_code_editor_common.tsx
View file

@ -56,7 +56,6 @@ export const JsonCodeEditorCommon = ({
languageId={XJsonLang.ID}
width={width}
value={jsonValue || ''}
onChange={() => {}}
editorDidMount={onEditorDidMount}
aria-label={codeEditorAriaLabel}
options={{

1
src/plugins/discover/public/application/components/source_viewer/__snapshots__/source_viewer.test.tsx.snap generated
View file

@ -546,7 +546,6 @@ exports[`Source Viewer component renders json code editor 1`] = `
aria-label="Read only JSON view of an elasticsearch document"
editorDidMount={[Function]}
languageId="xjson"
onChange={[Function]}
options={
Object {
"automaticLayout": true,

1
src/plugins/inspector/public/views/requests/components/details/req_code_viewer.tsx
View file

@ -54,7 +54,6 @@ export const RequestCodeViewer = ({ json }: RequestCodeViewerProps) => (
<CodeEditor
languageId={XJsonLang.ID}
value={json}
onChange={() => {}}
options={{
readOnly: true,
lineNumbers: 'off',

2
src/plugins/kibana_react/public/code_editor/code_editor.tsx
View file

@ -34,7 +34,7 @@ export interface Props {
value: string;
/** Function invoked when text in editor is changed */
onChange: (value: string, event: monaco.editor.IModelContentChangedEvent) => void;
onChange?: (value: string, event: monaco.editor.IModelContentChangedEvent) => void;
/**
* Options for the Monaco Code Editor

1
src/plugins/vis_type_vega/public/vega_inspector/components/spec_viewer.tsx
View file

@ -74,7 +74,6 @@ export const SpecViewer = ({ vegaAdapter, ...rest }: SpecViewerProps) => {
<CodeEditor
languageId={XJsonLang.ID}
value={spec}
onChange={() => {}}
options={{
readOnly: true,
lineNumbers: 'off',

1
x-pack/plugins/data_enhanced/public/search/sessions_mgmt/components/actions/inspect_button.tsx
View file

@ -35,7 +35,6 @@ const InspectFlyout = ({ uiSettings, searchSession }: InspectFlyoutProps) => {
<CodeEditor
languageId="json"
value={JSON.stringify(searchSession.initialState, null, 2)}
onChange={() => {}}
options={{
readOnly: true,
lineNumbers: 'off',

1
x-pack/plugins/file_upload/public/components/import_complete_view.tsx
View file

@ -75,7 +75,6 @@ export class ImportCompleteView extends Component<Props, {}> {
<CodeEditor
languageId="json"
value={jsonAsString}
onChange={() => {}}
options={{
readOnly: true,
lineNumbers: 'off',