* add useTimeFilter parameter to Controls visualization
* fix broken jest test
* add functional tests for useTimeFilter
* remove wrong comment
* use _.clone and _.isEqual for time comparision
* do not track time changes in vis_controller - use status.time instead
* Kibana Home page - phase two (#14749)
* add tutorial directory and home promo section
* tutorial components
* use KuiCodeEditor for displaying instruction code
* move spec files to server so joi can be used. Fetch via rest API
* Adding more tutorials (#4)
* More edits on the Apache logs tutorial
* Added nginx, mysql, and sytem modules for FB
* Moved apache to apacheLogs and added an apacheMetrics tutorial
* Added mysqlMetrics, nginxMetrics, systemMetrics tutorials
* Reduce duplication in the tutorials
This uses common objects for the install and start steps for Filebeat.
Same can be done for MB.
* fix windows path for config file
* add markdown parsing
* use mustache to replace config.kibana.version with kibana version
* add image preview to tutorial introduction
* fix css class name
* add param types constants
* add docs variables
* [WIP] Logstash Netflow module tutorial (#5)
* First draft of Logstash Netflow module tutorial
* Incorporated writing style suggestions
* pass params to template replace logic
* parameter inputs
* use isReadOnly flag from ui-framework for KuiCodeEditor
* dedemorton commits on netflow
* remove trailing slash from base links
* add config.docs.logstash and fix vertical spacing between Content component and commands
* Use logstash docs config variable
* Starting to add Deb instructions
* Fix Logstash documentation link
* Make commands optional
* Refactor: extract common LS instructions
* Edits for the existing tutorials
* change schema to support three instruction types
* [Netflow tutorial] Simplify OSX instructions
* replace axios with fetch
* pass credentials to tutorial fetch
* display cloud instructions when cloud set
* RadioButtonGroup component
* update copy
* add tutorial component jest tests
* content component test
* load isCloudEnabled in home_app
* add functional test ensuring add data tutorials are fetch and displayed
* rename card btns to 'Add data', fix type in tutorial directory tab, remove 'Set up index pattern from tutorial directory'
* move parameters form to right of instruction set title
* add copy snippet button, remove line numbers from command block
* add breadcrumb to tutorial view
* update tutorial jest snapshot
* use componentDidMount and ignore async results if componenent has been unmounted
* define shape of prop for instructionVariants and params. Create NumberParameter and StringParameter components
* add bread crumb to add data directory page
* Add cloud version of the apache_logs tutorial (#16)
* Add cloud version of the apache_logs tutorial
* Added onprem-cloud version as well
* fix styling broken by EUI rebase
* add artifacts to tutorial schema
* fix styling for code block
* [Tutorials] Netflow: instructions for onPremCloud (#18)
* Extract common on-prem cloud instructions so LS and Beats can share them
* Extracting common instructions; adding onPremCloud instructions
* fix copy bug where copy would only contain previously selected text
* make string parameter input type be text
* Implementing Elastic Cloud tutorial for Netflow module (#19)
* More tutorial edits (#20)
* More tutorial edits
This updates the on prem instructions with a step that installs the GeoIP and
UA plugins in ES. It also makes the on-prem steps more consistent with the cloud
instructions which results in less redundancy in the code.
* Show config step for all variants
* More DRY in the tutorial content
* Updated screenshot for apache_logs
* wrap markdown content in markdown-body class
* use EuiFlexGroup to remove wasted space with 'copy snippet' button and instruction text
* change OSX to macOS, use Computed property names for instruction_variant DISPLAY_MAP, replace /app/kibana with kbnBaseUrl, remove unneeded if check in copy_to_clippboard, put getTutorials mixin on server instead of request
* capitilize 'C' in Elastic Cloud
* remove try/catch from copy_to_clipboard
* Removing unrelated instructions
* Copy editing fixes
* Multiply edits to the Beats tutorials (#21)
* Updated Nginx module
* Updated MySQL logs module
* Updated system logs module
* Correct the on_prem_cloud enable steps
* Updated the Nginx metrics tutorial and added screenshot
* Updated the Apache metrics module + screenshot
* Updated the MySQL metrics module + screenshot
* Updated the system metrics module + screenshot
* prevent 'Copy snippet' button text from wrapping
* [Netflow tutorial] Windows instructions (#22)
* [Netflow tutorial] Adding onPrem instructions for Windows
* Removing unrelated/superfluous instructions
* Adding Windows instructions for onPremElasticCloud and elasticCloud
* use EuiImage so tutorial images are clickable to view in full screen
* fix jest tests
* set fullScreenIconColor and alt options for EuiImage, add space between command block and instruction text
* fix broken depenencies (#15960)
* update yarn.lock
* replace KuiConfirmModal with EuiConfirmModal
* add titles to confirm modals. Update modal text and button text
* updates for newest version of EUI
* use EUI class in overlay and EUI button constants
* remove logic about changed filters in cancel dashboard editing modal, clean up wording for import saved objects modal
* fix broken function test - management delete index pattern
* wrap names in single quotes
* Naively switching to Observables
* Dispatching native renderStart and renderComplete events
* Emitting actual event...
* Removing the visualize debounce
* Fixing unsubscribe
* Dispatching correct event for the metric visualization
* Moving the $scope.$apply to right after the call to render so it does
what it's supposed to
* Switching angularjs attribute name
* Removing the renderStart since it doesn't do anything
* Removing the renderComplete trigger from visualize, since no one listens
at this level
* Using vis.requestError to communicate when there's a request error
* Grabbing the container when creating the observable
* Dispatching renderStart as soon as we can
* Only emitting renderComplete after we wait for a new animation frame
* Can't ignore the first resize, sometimes it's actually a resize
* Use $timeout in visualiationEditor render, it can be in a digest already
* Calling renderComplete in componentDidUpdate as well
* Switching tests to use render-complete
* Fixing peer review corrections from @gammon
* Removing visDiv reference, we don't need it anymore
* Removing requestAnimationFrame
* Removing unused $timeout
* Removing test that was testing an implementation detail
* Adding $timeout.flush
* Moving the failures to the actual tests don't work.
* Deleting tests that weren't running before
* Removing import of removed test
* Consolidating the dispatchRenderComplete/dispatchRenderStart
* try to repro
* try 30 times
* some clean up and extra tests
Don’t see how this should help, but switch to using data-test-subj and
add a wait until loading line.
Still, I don’t see that it would actually help.
Also it took 50 test run to hit it once, so doubling the amount of
times the test suite runs to improve chances of hitting it.
* Throw the function in a retry
Unfortunately it’s probably not worth investigating why the click
sometimes fails, given how rare it is and that it’s only reproducible
in the test environment.
* Remove extra test loops
* remove skip and check multiple times again
* Fix issue with flaky field toggle selection
* forgot await
* More stabilizations
* Stabilize by disabling toast auto hides on all dashboard tests
* avoid all the retries to see if disabling toast auto hides was what was messing everything up
* remove comment that is no longer relevant
* Remove extra tests
* Add EUI v0.0.7 as a dependency.
- Add support for using dark theme EUI CSS in Dashboard.
- Set light theme as the default.
- Add comments to chrome.jade about role of theme node.
- Add (WTFPL OR MIT) to acceptable licenses.
* Remove old reset CSS.
- Remove naked element selectors from base.less.
- Remove Bootstrap resets.
- Remove UI Framework reset.
- Remove unused reset styles from UI Framework.
* Fix CSS regressions caused by removal of CSS reset.
- Replace usage of sr-only with euiScreenReaderOnly.
- Apply euiButtonEmpty classes to the 'Add a filter' button.
- Fix Notification padding and layout.
- Apply euiTabs styles to Timepicker mode tabs.
- Fix layout of Available Fields heading in Discover.
- Add padding to Popular Fields container in Discover.
- Push down Selected Fields heading in Discover sidebar.
- Fix appearance of links in Discover sidebar.
- Fix height of pills in Filter Bar.
* Fix timepicker tests.
- Remove kbn-accessible-click from timepicker buttons.
* Fix functional tests.
- Use byCssSelector inside of testSubjects.find.
- Delete flaky view_edit.js test: 'when time changed is stored with dashboard'.
- Delete flaky view_edit.js test: 'and preserves edits on cancel > when time changed is stored with dashboard'.
- Delete flake Gauge Chart tests. EUI changed the font size, and the text within the gauges doesn't render when the window is too small.
* Shift negative series before drawing, fix#15553
* Add tests fot TSVB markdown
* Use waitUntilLoadingHasFinished
* Remove forgotten skip
* Switch test order
* Use generic seriesOption
* Rename test from chart to metric
* Use test subj to find metric tabs
* Improve TSVB tests
* Tests were sometimes failing locally when waiting for a render counter of 6
Render counter value, as it turns out, is unstable and unreliable, and
is in the process of being replaced. For now, we have to use a lower
render counter (sometimes it’s 6, sometimes it’s 4) and add a sleep.
Very unfortunate, but hopefully will soon be able to be use the newer
logic.
* Remove extra test runs
* Add mechanism for dashboard snapshots
* Adjust wait for render function since it needs to be 2, not gt 0.
Should be obsolete when the new render stuff is complete.
* resize images using new library so comparisons work across different screen resolutions
* use jimp comparison and see if expanding to expanded panel mode helps when comparing across browser/os
* Try to ensure window size
* Experiment with a smaller window, see if screenshot dimensions change
Update screenshot for new window dimensions
* Try cover + quality, see what the diffs look like.
* Stop trying to get TSVB to pass, try area charts
There is a timezone bug with tsvb:
https://github.com/elastic/kibana/issues/15501
* gah, cover didn't work, check resize
* bump render counter to 6, as it should be.
As it turns out, the visualization was not done re-rendering to
maximized mode
* Bump threshold for comparison
* reduce down to a single test run
* Don't use an environment variable to detect updateBaselines cmd line flag
* Use render counter to fix timing issue with click events not being applied by the time a pie slice is clicked.
* use testSubjects.moveMouseTo function
It has built in safety checks for stale element refs
* remove sleep
* Remove extra test suite runs, passed enough times
* First, run the test suite in question 20s to see how flaky it is and if it can be semi reliably repro'ed
* Use testSubjects instead of click by link test.
* spaces in data-test-subj selectors messes this up
* Passed sufficient number of times, remove extra test runs
* add some retries, waiting for the loading indicator to be hidden once is not enough
* test to see if looping over the flaky test 25 times will trigger it on jenkins
* Try again to semi-reliably report on jenkins
* Attempt to fix invalid id coming out of getDashboardIdFromCurrentUrl
* Clean up to submit attempted flaky test failure fix
clean up
* [input controls] Horizontal layout (#14918)
* input controls horizontal layout
* fix controlWidth calculation
* add functional test to ensure panel resizing changes layout
* use all caps for consts, add more comments about where values came from
* replace sleeps in functional tests with retry
* use KuiFlexGroup with wrap option instead of manually calculating widths
* remove no longer used min width constants
* fix dashboard grid function test.
* Remove uiState from dashboard - communicate via the panelState instead
* migrate old app state from the url
* Add comment about migration and why the unused uiStateJSON field is kept around still
* get wiring done for timelion application functional tests
* add tests for expression type ahead functions, arguments, and argument values
* provide argument suggestions when argument name not provided
* updates from cjcenizal review
Also adds some stabilization by refactoring some retries and
expectations.
and fixes a bug that snuck in between two PRS where the pie slice css
changed.
