Commit graph

142 commits

Author SHA1 Message Date
liza-mae
c7eb1e2aa1
[6.3] Improve visualization tests (#20783)
* Improve test flakiness for histogram and tag cloud tests.
Skip titlemap test.

* Add visualize page object

* Update histogram tests

* Enable skipped tests

* fix lint errors

* Update shakespeare test navigation to visualize

* Revert selector for selectAggregation

* Unskip vega test

* increase sleep
2018-07-18 07:33:21 -06:00
liza-mae
6fa36227df
[6.3] Add telemetry false for dashboard tests (#20901) (#20907)
* resolve merge conflict

* Add comma
2018-07-17 20:48:42 -06:00
Lee Drengenberg
85c761b906
refactor login page check, turn off telemetry (#17435) (#20723)
* refactor login page check, turn off telemetry

* significant refactor of navigateTo

* replace slashes with _ in test failure output html files

* re-do out of date PR
2018-07-12 11:58:30 -05:00
Tim Roes
9369fccbcc
[6.3] fixing disabled aggs (#18796) (#20450)
* fixing disabled aggs (#18796)

* adding dissabled aggs functional tests (#20454)

* Add missing visualize page method in 6.3
2018-07-05 17:27:59 +02:00
liza-mae
b3287ff3d8
Add wait for page to load in methods (#20413) 2018-07-03 12:02:44 -06:00
liza-mae
3ef4a45806
Fix flaky context _size tests and bug in context page object file (#20254) (#20392)
* Update getSuccessorLoadMoreButton() to point to correct selector
Add a sleep in navigateTo() and remove refresh()
Add methods to click predecessor and successor load more buttons
Update waitUntilContextLoadingHasFinished to check buttons are enabled and displayed
Update tests to use click methods

* Fix lint issues
2018-07-02 17:55:14 -06:00
liza-mae
df4ae35e97
Fix flaky dashboard nested visualizations test (#20166)
* Fix flaky dashboard nested visualizations test

* Update dashboard_page.js

The wait for page to load did not work consistently in a loop.  I also tried a retry in setQuery method which failed also, but was only for one of the tests, the other test did not use that method.  

The only way I could get it to pass in a run 18 times in a loop was to put a sleep in clickEditVisualization.  This change is only for 6.3.
2018-06-27 12:02:00 -06:00
liza-mae
7f59b12886
Fix flaky visualize lab mode tests (#20165) (#20234)
* Update saveSearch method in discover and add wait page loading for advance settings

* Fix spaces
2018-06-26 11:45:18 -06:00
liza-mae
1d70939f6d
Make timelion tests less flaky (#19996) (#20011)
* Update sleeps in timelion tests

* Add comment
2018-06-18 14:06:49 -06:00
liza-mae
896334e540
Remove flaky selectors: .ng-scope, .ng-binding and .ng-isolate.scope (#19688) (#19739) 2018-06-11 15:29:02 -06:00
Tim Roes
6659b82b77
[6.3] Fix broken linked save searches (#19722) (#19725)
* Fix broken linked save searches (#19722)

* Fix bug

* Retry navigation

* skip 'linked saved searched' tests

These tests pass over and over locally but fair (every time?) on Jenkins :-(

Since this is a blocker PR for the release, and since these tests pass locally, I'm going to `skip` these new tests for now.
2018-06-08 08:54:46 +02:00
Spencer
a8676bd2b1 Fix loading indicator for uiSettingsClient (#18694)
* [ui/chrome/loadingIndicator] expose VanillaJS hooks for gloabl loading indicator

* [ui/uiSettingsClient] increment/decrement loading count while request in progress

* [ui/loadingIndicator] fix HeaderPage.isGlobalLoadingIndicatorHidden()

* [ui/loadingIndicator] remove rxjs, fix tests

* [ui/loadingIndicator] improve docs

* [ui/loadingIndicator] remove needless unmounts

* [ui/loadingCount] correct typo

* [functionalTests/headerPage] awaitGlobalLoadingIndicatorHidden

* [ui/loadingCount] send subscribers the loading count on subscription

* [ui/loadingIndicator] remove error throwing, cleanup render

(cherry picked from commit d35316642d)
2018-05-02 16:39:30 -07:00
Chris Cowan
84ad08e70d [TSVB] Math Aggregation (two point oh) (#16965)
* Revert "Remove MathJS Feature (#15652)"

This reverts commit 43bf1dbf4a.

* replacing math with tinymath

* pining version

* updating yarn.lock

* Fixing Prettier mis formatting

* fixing tests

* Adding unsupported agg back

* Adding functional test for math aggregation

- Fixing bad tests
- Resetting page for every test suite (why donesn't beforeEach work?)
- Adding test for Math agg

* Trying to fix values (due to inconsistencies in env)
2018-04-11 14:17:03 -07:00
Tim Roes
9b23529fc5
Fix flaky lab mode test (#17622) (#17652) 2018-04-11 10:24:40 +02:00
Bhavya RM
c4e71d733a
Test for ensuring that options *hide all panel titles" work on dashboards. (#17440) (#17459)
Test for making sure option hide all panel titles work
2018-03-29 19:13:49 -04:00
Bhavya RM
544c26b659
Functional tests to add index alias reference (#17343) (#17406)
* Functional tests to add index alias reference (#17343)
Test to make sure Kibana handles index alias reference.
2018-03-27 14:48:03 -04:00
Rashmi Kulkarni
54f3a803a8
Large fileds 6.x (#17404)
* adding large_string_test (#17312)

* adding large_string_test

* removed a failing test, modified the existing one

* new line at the end of mappings.json

* removed the data.json file and also removed the navigateTo() and clickKibanaIndices() as createIndexPattern() takes care of it

* more modifications

* Test for Large number of Fields in Kibana.  (#16237)

* test huge data

* new file for testing large number of fields
*  testing large fields
* large_fields_test
* add the unload of es_archiver
* incorporated the changes in kibana.yml
* Revert "incorporated the changes in kibana.yml"
This reverts commit 8682121678.
* cleanup
* code simplification
* removed commented code
2018-03-26 13:29:39 -07:00
Matt Bargar
4f2fbe7fb6
[6.x] Add query enhancements opt-in switch to query bar (#17232) (#17353)
* Add query enhancements opt-in switch to query bar (#17232)

Makes our language updates more visible to users and removes mentions of Kuery as a separate language. Users still get the old lucene experience by default, but have the option to opt-in to "experimental query features" directly in the query bar. Goal is to get more feedback by making these new features more prominent and less of a jump from lucene.

* fix test
2018-03-22 18:00:25 -04:00
Lee Drengenberg
9afc7511a9
Getting Started - Shakespeare (#16827) (#17164)
* WIP - add shakespeare data for getting started guide

* Refactor of getLineChartData, getBarChartData, getAreaChartData

* Added changing extents and test

* Fix opening axis options

* Change precision from 8 to 7

* lower precision to 6

* Fix index pattern creation

* update from review, remove comments, add others
2018-03-14 17:01:40 -05:00
Jen Huang
03d9c4218e
React/EUI-ify indexed fields table (#16695) (#17068)
* React/EUI-ifying indexed fields table
2018-03-09 09:17:55 -08:00
Stacey Gammon
6b6f9afac4
Fix embeddable config url updates (#15728) (#17021)
* add failing test that would have caught this situation

* Implement onEmbeddableConfigChanged to pick up url changes from soft refreshes

* Add tests for legend and pie slice color as well as removing uiState keys to ensure it resets the config values

* address removing state from url as well as setting it.

* Fix up tests and add a link to the legend issue

* only emit once

* use for in, use better mocked clearAllKeys function

* Remove switch to setSilent

* Adjust test so it fails because of bug found where two charts will both have their slice colors updated

* Embeddable should only listen for changes to their panel's config state

* Default embeddable config to an empty object when creating a new embeddable
2018-03-07 17:14:32 -05:00
Bhavya RM
496e94a88e
Sanity tests for table viz in TSVB (#16880) (#16897)
Sanity test for table viz in TSVB
2018-02-23 18:33:36 -05:00
Bhavya RM
9e885e88be
adding gauge and topN sanity tests for TSVB (#16583) (#16651)
adding two basic sanity test automation for gauge and Top N
2018-02-09 15:11:10 -05:00
Tim Sullivan
809c38b069
[FTR] Add pause/resume auto refresh to header page object (#16618) (#16628)
* [FTR] Add pause/resume auto refresh to header page object

* remove unecessary promise.resolve
2018-02-09 10:05:46 -07:00
Nathan Reese
d43677c451
Nested input controls (#16407) (#16612)
* add input to select parent control

* move lineage logic into seperate file for easier testing

* move parent candidate logic into seperate file

* decouple control factory and control initialization

* disable control if parent not set

* inherite search source from ancestors to have them filter values

* call fetch when query filter is updated for filter value changes

* delete filters when control has ancestor without value

* avoid fetching option list when ancestors have not changed

* add functional tests for nested controls

* remove unneeded file

* fix jest tests, add another test case to functional tests, update 'Parent' field copy

* add more jest test coverage

* fix useTimeFilter functionallity

* add better error message when fetch is not defined by subclass

* pass filters array instead of search source hierarchy

* only modify queryFilter when filters are submitted

* compare value array instead of concatinated string to determine if ancestors have changed

*  use ES2016 syntax for array concatination
2018-02-08 11:30:35 -07:00
Chris Roberson
e845247f13
[Management] Time field step in React! (#16129) (#16517)
* Time field step in React

* Tests start

* Modularizing the step and adding tests

* More tests

* More clean up

* Fix test

* Update tests

* Fix bug where use can't select 'No Time Field' option

* Fix test

* Disabled button state bug fix with test

* UX improvement: early warning of index pattern collision

* More composable StepTimeField component for more readability

* PR feedback

* Remove debug

* Ensure the node exists and add back tests

* Update time field loading state

* PR feedback

* Update tests
2018-02-05 10:35:18 -05:00
Chris Roberson
43ea098107
[Management] Fix importing objects connected to saved searches that contain conflicts (#16004) (#16492)
* Handle cases of importing objects that are connected to searches, but error out due to the searches index pattern not found

* Add tests and fix flaky ones
2018-02-02 16:17:35 -05:00
Tim Roes
eceb08d407
[6.x] Fix issue with disabled lab mode (#16351) | Properly wait for search list to load (#16388) (#16394)
* Fix issue with disabled lab mode (#16351)

* Fix saved object finder issue

* Add functional test

* Properly wait for search list to load (#16388)
2018-01-30 16:31:31 +01:00
Peter Pisljar
4903ab4653
visualize editor should not show if embed is set to true in url (#16310) (#16361) 2018-01-30 10:12:35 +01:00
CJ Cenizal
ff9caf9675
Fix assertions against toasts in Dashboard and Discover functional tests. (#16336) (#16344) 2018-01-28 17:53:26 -08:00
CJ Cenizal
7bd9876453
Extract fatal notification into fatalError service, add support for EuiToast notifications (#15749) (#16330)
* Reorganize notify/lib files. Extract fatal notification into a fatalError service.
* Convert notify/lib tests to use Jest.
* Add ToastNotifications, GlobalToastList, and documentation.
* Remove notify.info method.
* Add createFirstIndexPatternPrompt.
* Update testSubjects.exists to accept a timeout argument.
* Skip some flaky tests.
2018-01-27 18:00:51 -08:00
Yuri Astrakhan
e9ff24872f
Migrating vega_vis from plugin (#15014) (#16035)
Large PR to migrate Vega plugin into the core.
https://github.com/nyurik/kibana-vega-vis

The code underwent a large number of changes and
reviews discussed in the PR thread:
https://github.com/elastic/kibana/pull/15014
2018-01-13 16:26:07 -05:00
Nathan Reese
ff460a70cc
[6.x] Kibana Home page - phase two (#14749) (#15965)
* Kibana Home page - phase two (#14749)

* add tutorial directory and home promo section

* tutorial components

* use KuiCodeEditor for displaying instruction code

* move spec files to server so joi can be used. Fetch via rest API

* Adding more tutorials (#4)

* More edits on the Apache logs tutorial

* Added nginx, mysql, and sytem modules for FB

* Moved apache to apacheLogs and added an apacheMetrics tutorial

* Added mysqlMetrics, nginxMetrics, systemMetrics tutorials

* Reduce duplication in the tutorials

This uses common objects for the install and start steps for Filebeat.
Same can be done for MB.

* fix windows path for config file

* add markdown parsing

* use mustache to replace config.kibana.version with kibana version

* add image preview to tutorial introduction

* fix css class name

* add param types constants

* add docs variables

* [WIP] Logstash Netflow module tutorial (#5)

* First draft of Logstash Netflow module tutorial

* Incorporated writing style suggestions

* pass params to template replace logic

* parameter inputs

* use isReadOnly flag from ui-framework for KuiCodeEditor

* dedemorton commits on netflow

* remove trailing slash from base links

* add config.docs.logstash and fix vertical spacing between Content component and commands

* Use logstash docs config variable

* Starting to add Deb instructions

* Fix Logstash documentation link

* Make commands optional

* Refactor: extract common LS instructions

* Edits for the existing tutorials

* change schema to support three instruction types

* [Netflow tutorial] Simplify OSX instructions

* replace axios with fetch

* pass credentials to tutorial fetch

* display cloud instructions when cloud set

* RadioButtonGroup component

* update copy

* add tutorial component jest tests

* content component test

* load isCloudEnabled in home_app

* add functional test ensuring add data tutorials are fetch and displayed

* rename card btns to 'Add data', fix type in tutorial directory tab, remove 'Set up index pattern from tutorial directory'

* move parameters form to right of instruction set title

* add copy snippet button, remove line numbers from command block

* add breadcrumb to tutorial view

* update tutorial jest snapshot

* use componentDidMount and ignore async results if componenent has been unmounted

* define shape of prop for instructionVariants and params. Create NumberParameter and StringParameter components

* add bread crumb to add data directory page

* Add cloud version of the apache_logs tutorial (#16)

* Add cloud version of the apache_logs tutorial

* Added onprem-cloud version as well

* fix styling broken by EUI rebase

* add artifacts to tutorial schema

* fix styling for code block

* [Tutorials] Netflow: instructions for onPremCloud (#18)

* Extract common on-prem cloud instructions so LS and Beats can share them

* Extracting common instructions; adding onPremCloud instructions

* fix copy bug where copy would only contain previously selected text

* make string parameter input type be text

* Implementing Elastic Cloud tutorial for Netflow module (#19)

* More tutorial edits (#20)

* More tutorial edits

This updates the on prem instructions with a step that installs the GeoIP and
UA plugins in ES. It also makes the on-prem steps more consistent with the cloud
instructions which results in less redundancy in the code.

* Show config step for all variants

* More DRY in the tutorial content

* Updated screenshot for apache_logs

* wrap markdown content in markdown-body class

* use EuiFlexGroup to remove wasted space with 'copy snippet' button and instruction text

* change OSX to macOS, use Computed property names for instruction_variant DISPLAY_MAP, replace /app/kibana with kbnBaseUrl, remove unneeded if check in copy_to_clippboard, put getTutorials mixin on server instead of request

* capitilize 'C' in Elastic Cloud

* remove try/catch from copy_to_clipboard

* Removing unrelated instructions

* Copy editing fixes

* Multiply edits to the Beats tutorials (#21)

* Updated Nginx module

* Updated MySQL logs module

* Updated system logs module

* Correct the on_prem_cloud enable steps

* Updated the Nginx metrics tutorial and added screenshot

* Updated the Apache metrics module + screenshot

* Updated the MySQL metrics module + screenshot

* Updated the system metrics module + screenshot

* prevent 'Copy snippet' button text from wrapping

* [Netflow tutorial] Windows instructions (#22)

* [Netflow tutorial] Adding onPrem instructions for Windows

* Removing unrelated/superfluous instructions

* Adding Windows instructions for onPremElasticCloud and elasticCloud

* use EuiImage so tutorial images are clickable to view in full screen

* fix jest tests

* set fullScreenIconColor and alt options for EuiImage, add space between command block and instruction text

* fix broken depenencies (#15960)

* update yarn.lock
2018-01-10 11:40:06 -07:00
Bhavya RM
1dea44c592
Kibana home page tests (#15098) (#15964)
Couple of tests to make sure Kibana home page isn't breaking.
2018-01-10 11:27:20 -05:00
Nathan Reese
b4af0430d3
replace KuiConfirmModal with EuiConfirmModal in confirm-modal directive (#15693) (#15898)
* replace KuiConfirmModal with EuiConfirmModal

* add titles to confirm modals. Update modal text and button text

* updates for newest version of EUI

* use EUI class in overlay and EUI button constants

* remove logic about changed filters in cancel dashboard editing modal, clean up wording for import saved objects modal

* fix broken function test - management delete index pattern

* wrap names in single quotes
2018-01-08 12:16:54 -07:00
Peter Pisljar
acbdf48b6a
other and missing bucket support for terms agg (#15525) (#15864) 2018-01-08 07:59:47 +01:00
Brandon Kobel
56dc541bdd
Sharing render-complete (#15574) (#15853)
* Naively switching to Observables

* Dispatching native renderStart and renderComplete events

* Emitting actual event...

* Removing the visualize debounce

* Fixing unsubscribe

* Dispatching correct event for the metric visualization

* Moving the $scope.$apply to right after the call to render so it does
what it's supposed to

* Switching angularjs attribute name

* Removing the renderStart since it doesn't do anything

* Removing the renderComplete trigger from visualize, since no one listens
at this level

* Using vis.requestError to communicate when there's a request error

* Grabbing the container when creating the observable

* Dispatching renderStart as soon as we can

* Only emitting renderComplete after we wait for a new animation frame

* Can't ignore the first resize, sometimes it's actually a resize

* Use $timeout in visualiationEditor render, it can be in a digest already

* Calling renderComplete in componentDidUpdate as well

* Switching tests to use render-complete

* Fixing peer review corrections from @gammon

* Removing visDiv reference, we don't need it anymore

* Removing requestAnimationFrame

* Removing unused $timeout

* Removing test that was testing an implementation detail

* Adding $timeout.flush

* Moving the failures to the actual tests don't work.

* Deleting tests that weren't running before

* Removing import of removed test

* Consolidating the dispatchRenderComplete/dispatchRenderStart
2018-01-05 08:05:13 -05:00
Yuri Astrakhan
7fa21bf39d
Upgrade to jQuery 3.2.1 (#15674) (#15757)
* Upgrade to jQuery 3.2.1

The jquery-migrate showed a number of warnings,
but no errors, so it should be safe to use.

Warnings mostly related to bind, unbind, focus, ...
https://github.com/jquery/jquery-migrate/blob/master/warnings.md

To enable jquery-migrate, I added it to package.json, and added
a require('jquery-migrate') to the webpackShims/jquery.js right
after the require('jquery').

* Breaks in jQuery3: $(window).offset()

* await field.type(), update chromedriver
2017-12-22 16:42:53 -05:00
Tim Roes
008034c1aa
Refactor spy panels (#15682) (#15734)
* Fix design of debug spy panel

* Simplify the debug spy panel

* Fix height of spy content

* Use scope bindings for spy

* Allow modes to be enabled/disabled based on vis

* Make showSpyPanel docs for loader more detailed

* Only show default panels when using courier

* Fix styling of req/resp spies

* Fix title styling in spy panel

* Get rid of visData in spy panels

* Use tabs instead of select box

* Ensure uiState in spy

* Restyle code in default editor

* Remove unnecessary if protection

* Use local scope variable for rowsPerPage

Due to issues with primitive datatype bindings in Angular this anyway
didn't save it correctly back into the variable.

* Pull all logic into spy directive

* Fix bug when closing panel

* Check for minimum chart size

* Skip spy tests for now

* Fix functional tests

* Improve uiState mock

* Create unit tests

* Remove dead scope binding
2017-12-21 12:55:13 +01:00
Peter Pisljar
20c9e3bf30
few enhancements to default sidebar editor (#15619) (#15700) 2017-12-19 21:32:37 +01:00
Stacey Gammon
5ed5235eed
Investigate flaky add new visualization test (#15506) (#15667)
* try to repro

* try 30 times

* some clean up and extra tests

Don’t see how this should help, but switch to using data-test-subj and
add a wait until loading line.

Still, I don’t see that it would actually help.

Also it took 50 test run to hit it once, so doubling the amount of
times the test suite runs to improve chances of hitting it.

* Throw the function in a retry

Unfortunately it’s probably not worth investigating why the click
sometimes fails, given how rare it is and that it’s only reproducible
in the test environment.

* Remove extra test loops

* remove skip and check multiple times again

* Fix issue with flaky field toggle selection

* forgot await

* More stabilizations

* Stabilize by disabling toast auto hides on all dashboard tests

* avoid all the retries to see if disabling toast auto hides was what was messing everything up

* remove comment that is no longer relevant

* Remove extra tests
2017-12-19 09:48:33 -05:00
CJ Cenizal
d67d6206e6
EUI: Reset CSS #2 (#15657) (#15676)
* Add EUI v0.0.7 as a dependency.
- Add support for using dark theme EUI CSS in Dashboard.
- Set light theme as the default.
- Add comments to chrome.jade about role of theme node.
- Add (WTFPL OR MIT) to acceptable licenses.

* Remove old reset CSS.
- Remove naked element selectors from base.less.
- Remove Bootstrap resets.
- Remove UI Framework reset.
- Remove unused reset styles from UI Framework.

* Fix CSS regressions caused by removal of CSS reset.
- Replace usage of sr-only with euiScreenReaderOnly.
- Apply euiButtonEmpty classes to the 'Add a filter' button.
- Fix Notification padding and layout.
- Apply euiTabs styles to Timepicker mode tabs.
- Fix layout of Available Fields heading in Discover.
- Add padding to Popular Fields container in Discover.
- Push down Selected Fields heading in Discover sidebar.
- Fix appearance of links in Discover sidebar.
- Fix height of pills in Filter Bar.

* Fix timepicker tests.
- Remove kbn-accessible-click from timepicker buttons.

* Fix functional tests.
- Use byCssSelector inside of testSubjects.find.
- Delete flaky view_edit.js test: 'when time changed is stored with dashboard'.
- Delete flaky view_edit.js test: 'and preserves edits on cancel > when time changed is stored with dashboard'.
- Delete flake Gauge Chart tests. EUI changed the font size, and the text within the gauges doesn't render when the window is too small.
2017-12-18 17:39:06 -08:00
Tim Roes
e5eb9d0713
Fix bug where negative time offsets in visual builder will shift x-axis range (#15554) (#15650)
* Shift negative series before drawing, fix #15553

* Add tests fot TSVB markdown

* Use waitUntilLoadingHasFinished

* Remove forgotten skip

* Switch test order

* Use generic seriesOption

* Rename test from chart to metric

* Use test subj to find metric tabs

* Improve TSVB tests
2017-12-16 11:59:51 +01:00
Stacey Gammon
15fadeda2d
Use render counter to fix timing issue with click events on pie slices (#15494) (#15555)
* Use render counter to fix timing issue with click events not being applied by the time a pie slice is clicked.

* use testSubjects.moveMouseTo function

It has built in safety checks for stale element refs

* remove sleep

* Remove extra test suite runs, passed enough times
2017-12-12 12:47:10 -05:00
Stacey Gammon
7ef2bc3a79
Investigate fix for flaky clone test (#15503) (#15550)
* First, run the test suite in question 20s to see how flaky it is and if it can be semi reliably repro'ed

* Use testSubjects instead of click by link test.

* spaces in data-test-subj selectors messes this up

* Passed sufficient number of times, remove extra test runs
2017-12-12 12:21:28 -05:00
Stacey Gammon
5a24f58ea0
[6.x] improve preserve app cross state logic (#15464) (#15481)
* improve preserve app cross state logic (#15464)

* Eliminate flakiness the original PR introduced
2017-12-08 11:47:56 -05:00
Stacey Gammon
b489f469f9
Update getDashboardIdFromCurrentUrl to handle a url with no query params (#15323) (#15414)
* add some retries, waiting for the loading indicator to be hidden once is not enough

* test to see if looping over the flaky test 25 times will trigger it on jenkins

* Try again to semi-reliably report on jenkins

* Attempt to fix invalid id coming out of getDashboardIdFromCurrentUrl

* Clean up to submit attempted flaky test failure fix

clean up
2017-12-05 14:52:30 -05:00
Stacey Gammon
89554f1b04
Add more test stability and helpful debug output to try to catch issue with panel controls (#15392) (#15399) 2017-12-05 08:48:11 -05:00
Stacey Gammon
b0e5bd6d19
add extra test for more info (#15326) (#15381) 2017-12-04 15:54:55 -05:00
Stacey Gammon
c70760821c
Attempt to stabilize filterVizNames failures (#15316) (#15388)
* Attempt to stabilize filterVizNames failures

* Remove duplicate function name
2017-12-04 14:42:23 -05:00