Commit graph

1237 commits

Author SHA1 Message Date
Joe Fleming
a0bc0ea180
fix: don't sort in pie function (#27076) (#29445) 2019-01-28 11:48:19 -07:00
Joe Fleming
7581d7f8ac
fix: remove text selection on writeable change (#28887) (#29443) 2019-01-28 11:47:57 -07:00
Robert Monfera
6d3348c8b8
Feat: identify Canvas for metrics collection (#29078) (#29260) 2019-01-24 15:49:19 +01:00
Spencer
bbbacb03fe
[6.6] [es] when specifying path with vars always use encodeURIComponent (#29210) (#29237)
Backports the following commits to 6.6:
 - [es] when specifying path with vars always use encodeURIComponent  (#29210)
2019-01-23 20:02:14 -08:00
Søren Louv-Jansen
5de4f1c58f
Requires fields necessary for percent calculation (#29021) (#29068) 2019-01-21 19:31:39 +01:00
Tudor Golubenco
8d670d34f6 [BeatsCM] To prevent risk of startup errors, put template index before any ES write operation (#28955) (#28984)
* To prevent risk of startup errors, put template index before any write operation

* await the put template

* remove no-longer-needed promises

* remove CRUFT test
2019-01-18 11:34:48 +00:00
Søren Louv-Jansen
7d8b93771b
[APM] Fix Memory Chart Percentages (#28905) (#28911) 2019-01-17 13:25:12 +01:00
Peter Pisljar
7c89a6afb6
moving state out of kbn-interpreter (#27317) (#28898)
# Conflicts:
#	packages/kbn-interpreter/src/public/index.js
#	packages/kbn-interpreter/src/public/interpreter.js
#	packages/kbn-interpreter/src/server/server_registries.js
#	src/legacy/core_plugins/interpreter/public/functions_registry.js
#	src/ui/public/visualize/loader/pipeline_helpers/run_pipeline.ts
#	x-pack/plugins/canvas/public/components/app/index.js
2019-01-17 11:04:11 +01:00
Chandler Prall
3fe4fda21a Update EUI to 5.8.2 to include an EuiComboBox bugfix (#28883) 2019-01-16 15:40:45 -08:00
Søren Louv-Jansen
936e2ee27c [APM] Fix asPercent (#28826) (#28870) 2019-01-16 14:15:51 -08:00
Jason Rhodes
8ba27454f2
Filters transaction and error queries by processor.event (#28853) (#28861)
* Fixes incorrect data bug, adds tests

* Another TS fix for optional groupId
2019-01-16 13:56:01 -05:00
Jason Rhodes
3bafad617d
Finalize memory charts (#28625) (#28836)
* Adds available memory stats (in percent) to metrics server response

* Updates UI memory charts for new data

* Updates memory chart metrics to be usage (average and max), removes other unused metrics

* Review feedback addressed, small refactors

* Updates memory chart tests
2019-01-16 13:12:32 -05:00
John Dorlus
c5529feda4
Made change to cluster overview service to more reliably check if the page has loaded. (#28857) 2019-01-16 12:46:34 -05:00
Oliver Gupte
c5a31f65f1
[APM] fix line charts not rendering a single data point (#28231) (#28845)
* [APM] fixes #25650 by using react-vis LineMarkSeries rathern than LineSeries to render a single data point

* [APM] bumped mark size form 0.5 to 1 and removed commented code lines

* [APM] reduced mark size back down to 0.5 from 1 so they are not visible from within lines
2019-01-16 09:09:52 -08:00
Oliver Gupte
ea95c15d8a
[APM] fix action menu infra link for docker.container.id (#28140) (#28841)
* Fixes #27573 by targeting `docker.container.id` to populate the action menu

* [APM] replace lodash get with idx accessor to not lose type information

* [APM] fix type inconsistencies between v1 and v2 transaction types
2019-01-16 09:09:35 -08:00
Catherine Liu
af234e4c5c
defaults to empty object when no canvas clipboard data is stored in localstorage (#28781) (#28795) 2019-01-15 17:12:34 -07:00
Clint Andrew Hall
0385a1ce7c
[Canvas] Minify assets in prod, generate stats on demand (#28391) (#28772)
## Summary

### Asset Optimization in Prod
I noticed on a cloud instance that the Webpack-generated JS files were enormous, on the scale of 20+ MB each.  Looking into it, and chatting with @spalger, we found that the Webpack [`mode` flag](https://webpack.js.org/concepts/mode/) for production builds was not being set.

Before: *91 MB*

![screen shot 2019-01-08 at 2 06 47 pm](https://user-images.githubusercontent.com/297604/50917067-4b759d00-1402-11e9-9f68-150bf8226125.png)

After: *29 MB*

![screen shot 2019-01-08 at 2 05 46 pm](https://user-images.githubusercontent.com/297604/50917102-5d574000-1402-11e9-9185-cee14e706cb3.png)


### Webpack Analysis
In addition, this PR adds the ability to generate a stats file, usable with the [Webpack Analyzer](http://webpack.github.io/analyse/), to look at how our assets are being built.

To run, add an environment flag, e.g:

```
CANVAS_GENERATE_STATS=true node scripts/start
```

![screen shot 2019-01-08 at 2 10 41 pm](https://user-images.githubusercontent.com/297604/50917208-95f71980-1402-11e9-9d2d-7d827996ec8c.png)
![screen shot 2019-01-08 at 2 13 18 pm](https://user-images.githubusercontent.com/297604/50917210-95f71980-1402-11e9-8b23-c80ddd118e9b.png)


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [ ] ~~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
- [ ] ~~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
- [ ] ~~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
- [ ] ~~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

- [ ] ~~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
- [ ] ~~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-01-15 11:11:23 -08:00
Catherine Liu
3b1e971a72
Clears tags and changes template name when cloning template (#28708) (#28715) 2019-01-14 13:34:16 -07:00
Spencer
eaed53ccf2
[6.6] [uiExports/styleSheetPaths] avoid string concatenation for paths (#27471) (#27645)
Backports the following commits to 6.6:
 - [uiExports/styleSheetPaths] avoid string concatenation for paths  (#27471)
2019-01-14 11:46:50 -08:00
James Gowdy
072dda7b51
[ML] Fixing analyze file endpoint call when behind proxy (#28595) (#28680)
* [ML] Fixing analyze file endpoint call when behing proxy

* small refactor
2019-01-14 15:45:48 +00:00
Søren Louv-Jansen
1c3444354f
[APM] Fix linking between errors and transactions, and link from errors to Discover (#28477) (#28585)
* [APM] Fix linking between errors and transactions, and link from errors to Discover

* Add tests
2019-01-11 22:00:20 +01:00
Chris Cowan
9d830f6a1e
[InfraOps] Update docs with data source configuration (#26579) (#28596)
* Updating docs

- Configure data sources via config/kibana.yml
- Fix typo

* Adding timestamp override

* Documenting all settings

* Removing changes from a different PR

* Add settings docs

* Adding all the settings

* Updating docs based on feed back from PR

* Adding periods to lines; changing disabled to present tense

* Updates to docs per PR

* Updates per PR

* Fixes per PR
2019-01-11 11:14:09 -07:00
Matt Apperson
1e2a72a902
propigate errors on index creation fail (#28541) (#28546) 2019-01-10 20:07:41 -05:00
Søren Louv-Jansen
a79a065cbd
[APM] Fix agent status check (#28254) (#28494) 2019-01-10 18:03:53 +01:00
Jason Rhodes
814de870e8
Updates error message when creating ML job (#28085) (#28481)
* Updates error message when creating ML job

* Updated error message based on feedback
2019-01-10 10:04:06 -05:00
James Gowdy
8c60f1d28d
[ML] Fix for groups input population when cloning job (#28449) (#28454) 2019-01-10 11:51:58 +00:00
Catherine Liu
8c94fa579d
fix: reject instead of resolving (#28129) (#28440) 2019-01-09 23:38:38 -07:00
Jason Rhodes
d78521f782
Switched tabs to render to avoid unnecessary mount cycles (#28389) (#28420)
* Switched tabs to render to avoid unnecessary mount cycles

We were previously using the 'component' prop for React Router routes inside of our history tabs component, which causes lots of extra mount cycles. Using the 'render' prop avoids that.

We also decided to *only* allow the render prop, which means using a component is a little more verbose b/c you have to pass down props from the render method, but it's worth it to avoid accidentally using 'component'.

For more, see: https://reacttraining.com/react-router/web/api/Route

Specifically:

"When you use component (instead of render or children, below) the router uses React.createElement to create a new React element from the given component. That means if you provide an inline function to the component prop, you would create a new component every render. This results in the existing component unmounting and the new component mounting instead of just updating the existing component. When using an inline function for inline rendering, use the render or the children prop (below)."

* Prevents trace list from flickering on data load, while still preventing inaccurate no items message while loading

* Updates tests
2019-01-09 21:55:47 -05:00
Catherine Liu
fc2f48c42b
[Canvas] Fixes error handling of NetworkErrors (#28282) (#28425)
* Fixes error handling with NetworkErrors

* Removed lodash get
2019-01-09 16:20:32 -07:00
Jen Huang
a82a19d550
Fix incorrect variable (#28404) (#28414) 2019-01-09 13:07:12 -08:00
Catherine Liu
3fc24850e4
Chore: cleans up Canvas function error messages (#28194) (#28406)
* Added op value to compare error message. Removed duplicate unit test

* Added single quotes to ply error message to help distinguish incorrect value

* Added value of context to progress error message

* Added percent value to reveal image error message

* Added single quotes to alterColumn error message to help distinguish incorrect value

* Added single quotes to timefilter error message to help distinguish incorrect value

* Added single quotes to axisConfg error message to help distinguish incorrect value

* Cleaned up error message in compare

* Added single quotes to font error messages

* Added single quotes to getCell error messages

* Added single quotes to progress error messages

* Added single quotes to revealImage error messages

* Cleaned up timefilter error message

* Added single quotes to demodata error messages

* Added unit test back

* Updated error message in ply
2019-01-09 12:55:22 -07:00
Catherine Liu
d7c2a9823d
[6.6] Upgrades style-it to 2.1.2 (#27824) (#28137)
* Upgrades style-it to 2.1.2 (#27824)

* Updated yarn.lock
2019-01-09 12:54:59 -07:00
James Gowdy
9ea0f07945
fixing conflicts (#28396) 2019-01-09 18:40:03 +00:00
James Gowdy
6ef996322d
fixing conflicts (#28359) 2019-01-09 17:30:13 +00:00
Walter Rafelsberger
aafab73465
[ML] Fix missing $applyAsync() in AnomalyExplorer and Time Series Viewer (#28237) (#28339)
Part of #28189. Removes custom Promise code and fixes missing $applyAsync()s in AnomalyExplorer and Time Series Viewer.
2019-01-09 14:32:04 +01:00
James Gowdy
d41aa4858a
[ML] Fixes alignment of dedicated index checkbox (#28270) (#28330)
* [ML] Aligning dedicated index checkbox

* fixing-overflowing-input
2019-01-09 13:05:43 +00:00
Pete Harverson
88b6fa87dd
[ML] Adds applyAsync to updates in the Data Visualizer (#28241) (#28328) 2019-01-09 12:01:04 +00:00
Bill McConaghy
8ee968cb56
fixing watcher threshold alerts by reverting to kui styles (#28266) (#28269) 2019-01-08 14:32:50 -05:00
Jen Huang
832354d167
[ILM] Fix Index Management not loading when ILM enricher errors out (#28108) (#28192)
* Only load ILM data enricher if UI is enabled

* Silently swallow errors from data enrichers

* Only add index management ILM extensions if ILM UI is enabled
2019-01-07 16:15:01 -08:00
Catherine Liu
0319d3087b
Fixes time filter component (#27532) (#28203)
* set reuseDomNode to false in time_filter renderer

* Added minDate to start datepicker and maxDate to end datepicker in time filter component
2019-01-07 13:09:05 -07:00
Chris Roberson
4a3395a1ed
Ensure all monitoring charts respond to onBrush (#28098) (#28171) 2019-01-07 09:13:37 -05:00
Matt Apperson
9999e8f373
[BeatsCM] Correct new user redirect, enroll command extra space, and KQL bar EUI theme breaking change (#27891) (#27984) 2019-01-03 18:45:45 -05:00
Matt Apperson
6a9c6d063c
[BeatsCM] use static map of pages vs dynamic from FS (#27998) (#28031)
* [BeatsCM] use static map of pages vs dynamic from FS

* remove snapshot

* Apply suggestions from code review

* Update x-pack/plugins/beats_management/public/pages/index.ts
2019-01-03 16:28:40 -05:00
Joe Fleming
50de92e45c
fix: trick build into including dependencies (#27858) (#28013)
import server and common functions so the build correctly includes their
dependencies
2019-01-03 13:42:27 -07:00
Joe Fleming
b3b99c3ae9
Fix: Make timelion a browser function (#27944) (#28015)
* chore: revert #26809

it was a temp fix meant to be removed anyway

* chore: convert timelion to private browser function

allows access to ui/chrome, required for determining the server basepath
2019-01-03 12:26:40 -07:00
James Gowdy
2c4b0ed177
[ML] Fixing missing new ML job link in file datavisualizer (#27889) (#27901) 2019-01-03 14:34:50 +00:00
James Gowdy
f471231118
[ML] Fix for audit message search size being 0 when jobs size is 0 (#27955) (#27964) 2019-01-03 14:28:55 +00:00
Søren Louv-Jansen
6d9c0188d5
[APM] Add icons to timeline (#27840) (#27942) 2019-01-03 10:21:40 +01:00
Catherine Liu
9e654977f2
Added checks to mousemove handler to not commit all mouse movements (#27818) (#27854) 2018-12-28 15:48:43 -07:00
Joe Fleming
ffe58f47b5
[interpreter/loadPlugins] avoid deleting globals added by plugins (#27171) (#27852)
Plugins loaded by the `@kbn/interpreter` can sometimes setup global values while loading, like the regeneratorRuntime for instance, but the current plugin loading code is deleting every global that was added during plugin load. This changes the logic to only cleanup the `canvas` global after loading the canvas plugins.

resolves https://github.com/elastic/kibana/issues/27162
2018-12-28 14:41:39 -07:00