Commit graph

162 commits

Author SHA1 Message Date
Nathan Reese
4795c82d3e
[Maps] add saved objects for all sample data sets (#28797) (#30033)
* [Maps] add saved objects for all sample data sets

* add functional tests that compare sample data maps to baseline images

* add check for layer loading in functional tests

* try something out in CI

* try map without EMS regions

* add weblogs test but hide region layer

* skip tests with EMS vector layers

* gis-map to map and ES_GEOHASH_GRID to ES_GEO_GRID

* add resolution property to ES_GEO_GRID source descriptor

* move alphaValue from style descriptor to layer descriptor and rename to alpha

* terms join label change 'group by' to 'of'

* ensure sample data sets work with no internet access

* get functional tests working with updated full screen snapshots

* delete gis folder left overs

* give time for visibility to toggle to fire

* make web logs screen comparision more forgiving

* wait for layers to load on full screen
2019-02-05 08:45:39 -07:00
Stacey Gammon
d6f4def03a
[6.x] Refactor, clean up, new inspector, pie chart services (#28509) (#28786)
* Merge

* Replacing missing new inspector code
2019-01-16 11:34:16 -05:00
Stacey Gammon
a3ed2a3a08
Stabilize flaky visualize test (#27470) (#27709)
* Stabilize flaky visualize test

- don’t wait for header unnecessarily.  - use clickWhenNotDisabled instead of click. - use an outer retry to account for stale elements from pie chart likely not editing render complete correctly

* More fixes

- fix interval selection so it doesn’t accidentally click Go.  - fix legit bug with non existent _source field being used in a test. - Don’t “click Go” when not needed.

* Clean up

- can’t run pie chart tests multiple times in a row.  - remove more unnecessary clickGos
2018-12-21 14:22:03 -05:00
spalger
fb3aa83de9 skip failing tests, see #27498
(cherry picked from commit 14bf38e697)
2018-12-19 07:37:16 -08:00
Stacey Gammon
c650e35e98
Fix dashboard to refresh visualizations when the refresh button is clicked (#27353) (#27458)
* Fix dashboard to refresh visualizations when the refresh button is clicked

* Suggestions

* Fix tests

* Catch bug with a new test to ensure saved searches update when query in url is modified

* Add a test that would have caught the initial problem

* Final fixes that should get ci passing and the bug fixed

* Move requestReload out of _pushFiltersToState

* Fix comparison
2018-12-18 20:25:51 -05:00
Aleh Zasypkin
5ef8871edc [core_plugins/kibana] fix paths. 2018-12-03 21:57:24 +01:00
Spencer
3abe125f57
[6.x] [ftr] wrap remote in browser service (#26394) (#26444)
Backports the following commits to 6.x:
 - [ftr] wrap remote in browser service  (#26394)
2018-11-29 16:11:36 -08:00
Spencer
c64fab0fe3
[6.x] [ci][ftr][kbn/test] split up CI jobs (#25838) (#25977)
* [ci][ftr][kbn/test] split up CI jobs (#25838)

* [ci][ftr][kbn/test] split up CI jobs

* [ci] run --assert-none-excluded in ci groups, before builds

* [ftr] improve error message when excluded tests found

* [ci] document other places the ciGroups live

* [grunt] fix --kibana-install-dir value
2018-11-20 15:36:26 -08:00
Caroline Horn
2c4fd9b475
TSVB less to sass - and some UI work (#24250) (#25653)
Fixes #16483, Fixes #20115, Fixes #17852, Fixes #16768, Fixes #14348, Fixes #17842, closes #15580, closes #14938
2018-11-14 13:26:19 -05:00
Stacey Gammon
4d4c159bf1
[Flaky test fix] Turn back on data_shared_attributes test (#25156) (#25554)
* Turn back on data_shared_attributes test and run 20x

* Add some clean up

* Be more determinism, less refactoring.

* Go back to a single test run
2018-11-12 20:20:40 -05:00
Stacey Gammon
eda918a61e
Check for toast before waiting for page to finish loading to avoid mi… (#24424) (#24857)
* Check for toast before waiting for page to finish loading to avoid missing the toast by the time the page finishes

* turn test back on
2018-10-31 08:30:24 -04:00
spalger
935bffcf61 [6.x] disable flaky test - #24287 2018-10-29 15:56:40 -07:00
Matt Bargar
ccfb4482f6
[6.x] Euify and Reactify Query Bar Component (#23704) (#24420)
Implements query bar portion of https://elastic.github.io/eui/#/layout/header. Filter bar will come in another PR.

Fixes #14086

Re-implements our query bar component in React using some EUI components. Existing typeahead and suggestion styles were copied over 1:1 for now after talking with Dave about it. In this PR I focused on reaching feature parity with the existing query bar. Some additional work would be needed before we could move this into EUI as a generic component that could be consumed by other plugins.

Still needs some new tests and I suspect some old tests will need to be updated, but other than that this PR is functionally complete and ready for reviews.
2018-10-23 17:26:34 -04:00
Stacey Gammon
5cbc278614
Use concrete assertions, not exists (#23271) (#23392) 2018-09-24 07:36:58 -04:00
Tim Roes
c3e516e952
add support for 'format:number:defaultLocale' setting in TSVB (#21444) (#23354) 2018-09-20 16:10:07 +02:00
Stacey Gammon
3983f30d38
Bring back most of the filtering tests, only bypass the known current issues (#22787) (#22996)
* Bring back most of the filtering tests, only bypass the known current issues.

* Clean up after the test suite run so it can be run multiple times in a row.

* goal and guage issues were because of a bad cache
2018-09-13 12:37:29 -04:00
Stacey Gammon
5a65d1e8ea
Capture browser logs on test failure (#22670) (#22983)
* Capture browser logs

* spit out in logs, simulate failure to test

* remove leftover code

* simulate failure

* Remove forced failure
2018-09-13 07:28:02 -04:00
Marco Vettorello
6b504ed8af
Fix possible flakiness of saveVisualization action (#22356) (#22546)
* Updated saveVisualization to wait for toast instead of global indicator

* Fix RBAC tests.

The saveVisualization now fails directly if the visualization is not correctly saved.

* Change editor to use toast for errors

* Change saveVisualization method to new saveVisualizationExpectSuccess

For RBAC tests used also saveVisualizationExpectFail

* Fix wrong exists method call

* Fix missing exist function
2018-09-03 14:14:31 +02:00
Spencer
138f45698c
[accessibility] implement no-animation mode, auto enable for functional tests (#21629) (#22203) 2018-08-22 14:53:58 -07:00
Stacey Gammon
fd40428a18
skip filtering flaky tests (#22193) (#22201) 2018-08-21 08:45:58 -04:00
Stacey Gammon
eb2797f611
unskip filtering tests (#21804) (#22172)
* unskip filtering tests

* always navigate to landing page when trying to load a dashboard up

* more post test clean up - unpin the filter or it'll stick around for other tests.
2018-08-18 10:41:14 -04:00
Nathan Reese
ddc5b554a6
ReactVisType VisFactory - pass appState to Component (#21974) (#22058)
* pass appState to Component

* get appState from vis.API within TSVB component

* add functional test for Visual Builder in dark mode
2018-08-16 07:35:43 -06:00
Spencer
05cba5ada4
[6.x] [pageObjects/dashboard] check that save is complete before resolving (#21892) (#21945)
Backports the following commits to 6.x:
 - [pageObjects/dashboard] check that save is complete before resolving  (#21892)
2018-08-13 17:22:26 -07:00
Nathan Reese
aff2c9bde4
fix 'Add' button in empty dashboard (#21816) (#21890)
* fix 'Add' button in empty dashboard

* goto dashboard landing page after empty dashboard test

* add comment about event being undefined
2018-08-10 15:23:55 -06:00
Stacey Gammon
19546cb54e
Make visualization.waitForRender more generic and put in an embeddable class (#21688) (#21749)
* Make visualization.waitForRender more generic and put in an embeddable class.

* embeddable -> renderable

* missed a reference
2018-08-07 22:23:47 -04:00
Peter Pisljar
edc48a636d
fixes pinned filters in visualize and dashboard (#21463) (#21632) 2018-08-03 11:45:20 +02:00
Nathan Reese
0b45b125cb
Global time range in URL overwritten in certain situations. (#21440) (#21568)
* move global state update from kbn_global_timepicker to timefilter

* add functional test

* update time and refreshInterval when either update

* use same function name from kbn_global_timepicker

* call globalState.save in context of a digest cycle

* ensure callers of registerTimefilterWithGlobalState pass in
2018-08-02 15:56:34 -06:00
Stacey Gammon
ee2a283cc4
Skip flaky tests (#21439) (#21553) 2018-08-01 15:04:11 -04:00
Nathan Reese
dc34879948
set pause to 'true' when refresh interval is zero (#21498) (#21549)
* set pause to 'true' when refresh interval is zero

* keep original assertion

* fix expect message in functional tests now that pause is set to true

* fix executorProvider mocha test
2018-08-01 13:03:34 -06:00
CJ Cenizal
fa9575e69f
Re-enable Dashboard time changes functional test. (#21323) (#21373) 2018-07-27 15:56:55 -07:00
Tim Roes
053a8e0a27
Wait for visualizations to render in tests (#21258) (#21357)
* Wait for visualizations to render

* Use Visualize.waitForRender on dashboard

* Enable previously flaky dashboard tests again

* Add data-loading for initial render

* Remove unnecessary timeout
2018-07-27 21:56:52 +02:00
Stacey Gammon
1e803e7fe5
Fix refreshed dashboard losing time range (#20858) (#21264)
* Add test that would have caught the bug

* Initialize global state with current time range

* Fix issue with failing tests - need to remove added "t" parameter to the url in the new tests

* remove unneccessary extra call

* Fix tests that failed due to globally added time in new tests

* Update home page test to not care about any state.
2018-07-26 10:29:13 -04:00
Peter Pisljar
53d38799ac
Split editor state from saved state (#20323) (#20451) 2018-07-04 18:53:53 +02:00
Nathan Reese
62deaa896b
Remove display from timefilter refreshInterval state (#20348) (#20445)
* Remove display from refresh state

* fix spelling error, ensure garbage cannot be added to timefilter state
2018-07-03 19:09:12 -06:00
Nathan Reese
51c43ed385
disable flaky dashboard filtering test (#20425) (#20440) 2018-07-03 16:29:58 -06:00
CJ Cenizal
c6be289f21
Fix misspellings (#19981) (#20284) 2018-06-27 20:50:06 -07:00
Tim Roes
9ba0689dcd
[6.x] Replace spy panels by Inspector (#16387) | Fix one inspector test (#20072) (#20076)
* Replace spy panels by Inspector (#16387)

* Add Inspector feature

* So long, and thanks for all the fish, spy panel

* Fix several functional tests

* Fix unit tests

* Fix spy panel button tests

* Replace old spy panel documentation

* Disable test temporarily until we have dashboard triggers

* Enter edit mode for dark theme test

* Fix some more functional tests

* Fix more functional tests

* More test fixing

* Fix more functional tests

* Allow opening the inspector via loader handler

* Refactor InspectorViewChooser, remove unused CSS

* Remove dead code

* Fix data download button style

* Remove redundant code

* Load inspectorViews for dashboard_viewer

* Extract inspector views to custom core_plugin

* Switch API to TypeScript 🎉

* Design changes

* Remove icons from views

* Design changes

* Improve typings of API

* Add typing to all adapters

* Show loading spinner in request selector

* Rewrite InspectorView to TypeScript

* Fix help text for data view

* Remove deprecated React lifecycle methods

* Embed inspector into dashboard panel actions

* Remove temporary inspector trigger

* Remove old CSS

* Fix dashboard trigger for new panel action

* Add tests for InspectorPanel and DataAdapter

* Produce a hierarchical table if the vis is hierarchical

* Remove allowJs option again

* Add missing Apache license headers

* Close inspector on dashboard when navigating away

* Use proper title for dashboard panels

* Fix functional tests

* Skip broken test for now

* Flush view chooser button

* Add request adapter tests

* Skip more tests, broken due to typescript

* Add Request Time description

* Add description for courier request

* Fix tests

* Replace icon by new (not yet released) icon

* Finalize design of inspector

* Remove discover test, that relied on spy panels

* Change API to be properly mockable in tests

* Add aria-live region for request status

* Replace old method in functional tests

* Replace abitrary magic number

* Use object destructuring in vis

* Fix issue with crashing requests view

* Add request time tooltip

* Get request body of correct search source

* Make filter buttons properly keyboard accessible

* Follow Dave's design suggestions

* Remove redundant request from name

* Remove unneeded comments

* WIP raw-formatted values

* Fix filtering issue

* Fix tests and more license headers

* Add data view tests

* Remove search from table

* Fix typos

* Implement review suggestion

* Remove artificial delays for testing

* Fix new panel action structure

* Minor design adjustments

* Fix failing functional test

* Update failing snapshot test

* Implement final wording

* Apply new EUI styling

* Fix closing inspector in tests

* Fix sorting of table

* Align punctuation between tooltips

* Fix test that doesn't exist on master

* Fix one inspector test (#20072)

* Remove file that came accidentally back due to merging

* Fix accidental merge paste

* Fix 6.4 test failures
2018-06-21 11:45:13 +02:00
Stacey Gammon
72dc8b31f7
Fix flaky test where modal dialog isn't loaded when enter key is pressed (#20035) (#20051) 2018-06-19 19:22:16 -04:00
Spencer
20a932e03e
[6.x] [ftr/confirmModal] assert expected state rather than just reading (#20019) (#20022)
Backports the following commits to 6.x:
 - [ftr/confirmModal] assert expected state rather than just reading  (#20019)
2018-06-19 13:11:38 -07:00
Tim Roes
593296b5e4
Skip flaky test for now (#20033) (#20034) 2018-06-19 14:07:54 +02:00
Stacey Gammon
a7845e5d0f
Unskip 'and preserves edits on cancel' test (#19412) (#19606)
* unskip 'and preserves edits on cancel' test

* Clean up view edit test before unskipping

* don't use old vis list to determine counts

* Fix bad merge

* get rid of extra view edits, they won't work because of the extra panel... should add a better cleanup... but for the sake of staying focused, running these old school

* Fix bad merge, snapshot tests belong in new data section
2018-05-31 19:48:10 -04:00
Nathan Reese
79d36b0ce1
Convert Dashboard save dialog to react/EUI (#19531) (#19592)
* eui save panel

* add title and description inputs

* copy on save

* add jest tests

* fix functional and jest tests

* another functional test fix

* updates from Stacey-Gammon review

* remove debounce because it broke functional tests

* update jest snapshot
2018-05-31 09:45:57 -06:00
Stacey Gammon
40e24f0bbb
Update dashboard snapshot tests (#19420) (#19562)
* update snapshot tests

* Update time ranges

* Add sleeps, adjust time, update snapshots

* Skip TSVB until the issue with vertical line placement and x-axis timestamps is fixed

* fix expectations of time range with saved search creation

* remove debug line
2018-05-30 16:47:55 -04:00
Stacey Gammon
f57315b115
Instead of adding a margin of error, just wait for render complete. (#19406) (#19496)
* Instead of adding a margin of error, just wait for render complete. Hopefully should fix

* actually because of page margins, we still nee a margin of error.

* go back to a single run
2018-05-29 10:17:10 -04:00
Spencer
4f29b323bf
Backport/19383/6.x (#19487)
* [eslint][tslint] require Apache 2.0 license headers

(cherry picked from commit 337fea30b9)

* [kbn-eslint-plugin-license-header] don't try to fix files with hashbangs

(cherry picked from commit db79f1501e)

* [eslint][tslint] autofix license headers
2018-05-28 20:24:23 -07:00
Stacey Gammon
225f541abb
Pluggable panel actions (#18877) (#19415)
* Allow pluggable panel actions

* Need to register it as being used in kibana

* Some cleanup

* update snapshots to match new EUI versions, set time range

* Use newer panelActions service

* add missing await

* More clean up and fixes

* bring back window reload

* Show actions in view mode too

* delete now unused files

* Use toggle action to determin if context menu is open

* Fix tests that assume the toggle is hidden in view mode.

* Add some debug logs

* Fix up assumptions

* Previous failing test was legit - we don't want to show remove option when panel is expanded

* Embeddable can be empty before the panel is loaded

* Should look for either visualize or discover page

* Address code comments

* address code review comments

* whoops, get rid of childPanelToOpenOnClick entirely
2018-05-24 16:41:05 -04:00
Nathan Reese
4a2ba0efc6
EUI dashboard add panel (#17374) (#19404)
* EUI add panel

* implement add functionallity

* style flyout so top nav is not covered

* add noItemsMessage

* add new visualization button

* remove angular add_panel template

* seperate search bar and table into its own component

* fix functional tests

* make slide out panel own focus to avoid weirdness of letting other buttons in nav from getting clicked and leaving slide out open

* remove deprecated method componentWillMount

* add jest test for DashboardAddPanel

* fix paging and replace EuiSearcBar with EuiFieldSearch

* fix functional tests

* fix dashboard filter bar functional test

* another functional test fix

* add more context to functional test failure message

* give search input a default value

* remove call to waitForRenderComplete to see if tests will pass

* fix dashboard filtering test

* updates from Stacey-Gammon review

* support filtering out lab visualizations

* add functional test for testing visualize:enableLabs with add panel

* add sorting by title to SavedObjectFinder componenet

* move add panel tabs to state

* clean up labs test differently
2018-05-24 12:53:49 -06:00
Nathan Reese
470004d66b
remove double modal when cloning dashboard with duplicate title (#19049) (#19313)
* remove double modal when cloning dashboard with duplicate title

* reset duplicate state when input is updated

* update functional test for new clone workflow

* change warning message to EuiCallout

* updates from Stacey-Gammon review
2018-05-22 11:43:12 -06:00
Tim Roes
4f0e1ab65b
Add missing test for #19221 (#19253) (#19307)
* Add tests

* Merge the two addFilter methods
2018-05-22 18:09:18 +02:00
Stacey Gammon
165644ac32
Dont need to confirm a modal anymore, there is none (#19243) (#19244) 2018-05-19 10:41:38 -04:00