Commit graph

2065 commits

Author SHA1 Message Date
Alison Goryachev
1d6b3cf66d
fix Platinum features link in license management (#31945) (#32016)
* fix Platinum features link in license management

* move external license links to constants file
2019-02-26 10:19:40 -05:00
Thomas Neirynck
60b0cb8f5d
[7.0] [Maps] Show joined term metrics in tooltip (#31826) (#32000)
* [Maps] Show joined term metrics in tooltip (#31826)

* fix merge
2019-02-26 08:54:18 -05:00
Thomas Neirynck
d83b64087f
Ensure any existing layers get cleared when previewing a new one (#31973) (#31981) 2019-02-26 03:31:20 -05:00
Catherine Liu
a38a2e3e55
[Canvas] Fixes filter clearing on undo/redo (#31859) (#31976)
* Added check to reset filters in 'setExpression'

* Removed filter reset from filter renderers' onDestroy handler

* Cleaned up setExpression

* Added TODO
2019-02-25 21:18:18 -07:00
Clint Andrew Hall
51888ddf6b
Kill unnecessary re-renders in ElementWrapper (#31734) (#31967)
## Summary (fixes #29700)

This is a small change that creates a huge impact on UI performance in Canvas.

As the mouse moves over a workpad, several parts of the state of the workpad, (the element hovered, the element moved if one is being held, etc) change.  These changes in state were causing every active Element to re-render in React.

In short, you may hover Element 10, but Elements 1-9 re-render because the state of the entire workpad changes.  This would happen even if the mouse were moved a single pixel.

By short-circuiting that re-render with a fast comparison, we prevent any Elements that are not affected from re-rendering... freeing up the main thread.  This performance impact intensifies as one adds Elements to the workpad.

Here is a performance shapshot before this change was made.  Notice the React tree reconciliation encompasses the entire 280ms.  This reflects a single state change flowing through all of the Elements on the workpad, (each orange "stalactite" descending downwards is an Element):

![screen shot 2019-02-21 at 11 49 48 am](https://user-images.githubusercontent.com/297604/53197762-76960380-35e0-11e9-9069-a30df5fd4b2f.png)

Here is a snapshot after.  That reconciliation now completes in 50ms or less:

![screen shot 2019-02-21 at 11 49 30 am](https://user-images.githubusercontent.com/297604/53197845-afce7380-35e0-11e9-8991-572462b441eb.png)

*This is not the end of this problem.*  There are many other opportunities to prevent re-rendering, and we need to focus on killing the need for the comparison in the first place.  @monfera and @w33ble will be instrumental in making these changes in the future... for now, though, this gets the job done.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [ ] ~~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
- [ ] ~~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
- [ ] ~~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
- [ ] ~~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [ ] ~~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-02-25 21:59:00 -06:00
Aaron Caldwell
765b24f368
[7.0] [Maps] Remove unneeded and breaking layer condition that prevents cancel from add layer panel (#31634) (#31930)
* [Maps] Remove unneeded and breaking layer condition that prevents cancel from add layer panel (#31634)

* Remove unneeded and breaking layer condition that prevents cancelling unless a layer's selected

* Add layer tests. Review feedback

* .....and the test file

* Review feedback. Factor out reusable maps test functions. Clean up

* Picky picky

* Review feedback. Remove sleeps

# Conflicts:
#	x-pack/plugins/maps/public/components/widget_overlay/layer_control/__snapshots__/view.test.js.snap
#	x-pack/plugins/maps/public/components/widget_overlay/layer_control/layer_toc/toc_entry/__snapshots__/view.test.js.snap
#	x-pack/plugins/maps/public/components/widget_overlay/layer_control/layer_toc/toc_entry/view.js
#	x-pack/plugins/maps/public/components/widget_overlay/layer_control/view.js
#	x-pack/test/functional/apps/maps/index.js

* Remove trailing space
2019-02-25 16:04:43 -07:00
Josh Dover
c19b159493
Show interstitial prompt when ES is upgrading (#31309) (#31738)
* Show interstitial prompt when ES is upgrading

* Update copy
2019-02-25 16:37:22 -06:00
Jonathan Budzenski
6105cc6b2c
[es] scripts.inline -> scripts.source (#30457) 2019-02-25 16:36:41 -06:00
Catherine Liu
33022ddf36
Refactor time_filter (#31641) (#31848)
Fixes time_filter state

Removed console logs

Cleaned up changes

Removed unused prop in time_filter

Moved propTypes

Fixed bug with changing columns

Added comment
2019-02-25 09:53:33 -07:00
Joe Fleming
75093eace7
fix: hours label container size (#31838) (#31863) 2019-02-25 09:49:06 -07:00
Nathan Reese
97338a1052
[Maps] render attribution with no url as text instead of EuiLink (#31873) (#31899)
* [Maps] render attribution with no url as text instead of EuiLink

* remove check for length
2019-02-25 08:39:52 -07:00
Bill McConaghy
255647b2cc
fix clearing number of replicas from existing policy (#31905) (#31911) 2019-02-25 09:55:30 -05:00
Nathan Reese
0de800241e
[Maps] fix app crash where layer details panel calls getId on undefined (#31816) (#31844)
* [Maps] fix app crash where details panel calls getId on undefined

* add jest test ensuring no errors when selectedLayer is undefined
2019-02-22 22:06:55 -07:00
Tyler Smalley
f561ff17c1
[UA] Support previously re-indexed ML/Watcher indices (#31046) (#31858)
Previously we were comparing the start of the indices to determine if ML/Watcher
should be stopped before re-indexing. Since we are now pre-pending the index
name we should compare the index names without the re-indexed portion.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2019-02-22 16:40:07 -08:00
Søren Louv-Jansen
3c15f0e994
[APM] Avoid crashing transaction details page if trace duration is 0 (#31799) (#31850)
* [APM] Avoid crashing transaction details page if trace duration is 0

* Remove snapshot
2019-02-23 00:16:33 +01:00
Joe Fleming
f4eb5e3beb
chore: unify the workpad update handler (#31218) (#31818)
* test: assets and structures routes

* chore: unify the workpad update handler

the 3 functions were pretty much the same already
2019-02-22 15:59:35 -07:00
Tyler Smalley
a47ff711dd
[UA] Protects against Cloud plugin being disabled (#31637) (#31833)
Currently, if the Cloud plugin is disabled the server will fail to start

Fixes #31612

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2019-02-22 12:54:36 -08:00
Casper Hübertz
18213c4ea5
[APM] Fix migrate assistant label and copy (#31750) (#31781)
* Change link copy in help menu and services list empty state
2019-02-22 14:59:59 +01:00
Nathan Reese
0bdc5d1a94
fix merge conflicts (#31777) 2019-02-22 06:18:37 -07:00
Robert Monfera
703d02f208
Fix Shortcut EventEmitter Leak/Re-render leaks (#31779) (#31790)
# Conflicts:
#	yarn.lock
2019-02-22 11:26:51 +01:00
CJ Cenizal
0a2f7d13a5
Fix bug where rollup job search would display an empty prompt if no jobs matched the search. (#31642) (#31771)
* Internationalize and refine message.
2019-02-21 20:30:51 -08:00
Thomas Neirynck
654a11af1e
[Maps] display metric tooltips for grid source the same as for joins (#31621) (#31752) 2019-02-21 22:17:38 -05:00
Chandler Prall
bd1d746350
Upgrade eui to 6.10.3 (#31696) 2019-02-21 15:32:02 -07:00
Joel Griffith
f0acbe40cf
[backport] Using content-disposition pkg for non-US font titles in reporting (… (#31718) 2019-02-21 13:30:50 -08:00
Catherine Liu
8b53f3478b
[Canvas] Adds doc links and keyboard shortcut cheatsheat to help menu (#31335) (#31728)
* Added docs link and keyboard shortcuts to global help menu

* Fixed tooltip

* Removed aeroelastic keyboard event handlers

* typography and copy changes

* Removed doc links from workpad manager

* Added input target check to workpad page keyhandler

* Fixed ungrouping

* Displays arrow symbols instead of arrow key word

* Removed tabIndex

* Fix: reintroduce additional call on keyboard event
2019-02-21 12:55:47 -07:00
Felix Stürmer
a3ba76cd36
[Logs UI] Fix some filebeat ECS message formats (#31120) (#31715) 2019-02-21 20:04:50 +01:00
Catherine Liu
896d86d6d4
Update prop types on RangeArgInput (#31654) (#31721)
* Added string as value prop type in range arg input

* Added string as value prop type in range arg input
2019-02-21 11:56:54 -07:00
Jonathan Budzenski
ae40bc154f
[monitoring] only start bulk uploader once (#31307) 2019-02-21 11:29:45 -06:00
Nathan Reese
f25d526887
[Maps] disable fit to data for geo_shape fields until elasticsearch supports a way to get the bounds (#31638) (#31700)
* [Maps] disable fit to data for geo_shape fields until elasticsearch supports a way to get the bounds

* add function test for fit to bounds

* add jest test for layer_toc_actions component

* review feedback
2019-02-21 10:28:53 -07:00
Ahmad Bamieh
5556a6e189
[Telemetry] collect xpack.cloud details (#31180) (#31701)
* collect xpack.cloud details

* add elasticsearch cluster uuid

* remove cloud ID from telemetry stats

* remove esUUID from telemtry stats
2019-02-21 19:15:01 +02:00
Matt Apperson
fc9649a716
[BeatsCM] fix API for tokens to support any number (#30335) (#31659)
* add basic script for standing up a fake env

* tweaks

* API needs to support any number of tokens not us

* [BeatsCM] Add testing script used to create test deployments

* Move to JWT for enrollment

* wrap dont scroll command

* Dont use token as token ID

* fix tests

* not sure why this file is enabled in this branch/PR…
2019-02-21 07:21:54 -05:00
James Gowdy
d5d0626b47
[ML] File data visualizer - setting default number of shards (#31567) (#31669) 2019-02-21 09:56:06 +00:00
Oliver Gupte
9a3ff7ea50
[APM] Move APM feedback link to global Help popover (#30918) (#31627)
* [APM] Closes #29687 by removing the old APM feedback link from the datepicker
section and adding the link as custom content in the global help popover.

* remove noreferrer property for the feedback link

* [APM] updated feedback link text and added help link to migration assistant

* [APM] remove unused translations related to the old feedback link
2019-02-20 15:05:09 -08:00
Aaron Caldwell
777a166c2b
Add back dispatch (#31602) (#31613) 2019-02-20 14:41:39 -07:00
Aaron Caldwell
06a8f9c47b
[Maps] Update layer add workflow and revise temp layer handling (#30542) (#31584)
* Move layer add flow to the add layer panel

* Remove layer add toast. It's pretty annoying in this new workflow and is planned to be removed/revised anyway

* Add/remove layers without setting temp status

* Dispatch save function on ws save and clear/remove transient layer

* Lot of cleanup of temp refs. Add __ to transient layer ref

* Activate layer property save button on style prop change

* Review feedback

* Await setting selected layer before opening flyout panel to prevent occasional undefined error

* Review feedback

* Review feedback

* Review feedback

* Remove style temp settings

* Return null as fallback

* Review feedback

# Conflicts:
#	x-pack/plugins/maps/public/angular/get_initial_layers.test.js
#	x-pack/plugins/maps/public/angular/map_controller.js
#	x-pack/plugins/maps/public/components/layer_addpanel/index.js
#	x-pack/plugins/maps/public/components/layer_addpanel/view.js
2019-02-20 13:45:36 -07:00
nicknak
4e30272e6a
[Saved Objects] Add hidden types to savedobjects (#28722) (#31592)
* Saved Objects routes and service should be able to hide objects.

* Remove context providers as a feature.

* Respository should be creatable to include hidden types.

* Fixes failing unit tests.

* Fixes issues with filter method.

* Adds check to get method for allowed types.

* Adds tests for get,delete,bulkGet,find

* Remove need for schema in saved objects api.

* Remove more traces of schema validation added to rest api.

* Remove inclusion of hidden types in route specific client.

* Removes getAvailableTypes as it is no longer used.

* Fixing up initialization of components.

* Moves default setting for includeHiddenTypes

* Allows for single value or array in assertAllowedTypes.

* Adds type assertion to bulkCreate, and incrementCounter with tests.

* Conversion to boolean should be more explicit.

* Repository should restrict types allowed to be manipulated.

* Saved objects should use the right root type.

Privileges should have unit test.

* All saved objects APIs should validate types.

* No need for test to be typescript if under test not ts.

* Handle extraTypes being undefined.

* Routes should verify that they do not allow invalid types.

* Bulk create should be tested.

* Saved objects mixin does not need extra blank lines.

* Saved objects integration tests should test unknown types.

* Integration tests should test for bad request with unknown type.

* Adds missing privileges to global all.

* Tests should use valid types.

Tests should have accurate expectations.

* Fix bulkCreate to assert allowed types.

* Fix unknown search field tests.

* Adjust expectations for unknown type in saved object api.

* Saved object integration should return proper responses.

* Fix expect to use a separated matcher.

* Should expect forbidden responses for unauthorized users.

* Should expect 400 when trying to use unknown types.

* Removes unwanted .only call.

* Adjust repository to throw error unless it has allowed types.

* Unknown types should return 403s and empty results where applicable

* Removes type validation from saved object API.

* Captures and returns appropriate exceptions for type assertion.

* Properly filtter c'tor params to repository.

* Checking allowed type should be bool check function.

* Cleanup test situation descriptions.

* Updating snapshot file for jest tests.

* Changes expected results for find from saved object service.

* Expect an empty response when attempting to access an unsupported type.

* Adds test coverage for new error methods added.

Adds create test to repository.

* Adds bulkGet, bulkCreate unsupported type errors.

* First step in refactoring saved object service.

Adding missing test coverage of saved object service creation.

* Move extra saved objects test to legacy folder.

* Adds references filtering by allowed type.

* Adds more coverage for mixin repository creation.

* Removes unnecessary decorate on server object for unused method.

* Revert reworking how kibana migrator uses mappings.

* Revert "Adds references filtering by allowed type."

This reverts commit 92b07d4b92.

* Adds check for unexpected callCluster type.

* Should cover as many parts of the mixin as possible.

* More expectations to tests.

* Keeps ordering of created items but does not pass unsupported types.

* Fix a failing before hook test.

* Should not use escaped single quotes inside template literals.

Co-Authored-By: njd5475 <njd5475@gmail.com>

* Changed how check is done in repository.

* Remove unused mappings file.

* Cleans up a couple of nits.

* Adds test for overwrite option being passed if it is in the url.

* Missed semicolon.
2019-02-20 13:58:25 -05:00
Brandon Kobel
bcc85e44f8
Add create_snapshot privilege (#31086) (#31597)
A new cluster privilege type has been added to ES in [elastic/elasticsearch#35820](https://github.com/elastic/elasticsearch/pull/35820) .
2019-02-20 10:51:15 -08:00
Joe Fleming
cdde3cf352
Feat: Add support for time_zone in essql (#31291) (#31546)
As noted in [the SQL docs](https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-rest.html), you can pass in a `time_zone` property to control what timezone is used for date operations. This adds a new arg, `timezone` (`tz` for short) to the `essql` function so that users can control what timezone is used.

Below, I have a query that groups results by the hour of the day. You can see the values change when I shift the timezone 12 hours (from `UTC` to `UTC-12`).

![feb-15-2019 10-38-49](https://user-images.githubusercontent.com/404731/52874173-0b46c000-310e-11e9-84b7-9074dfd09b59.gif)
2019-02-20 09:59:59 -07:00
Oliver Gupte
cb9c919a47
[7.0] [APM] Move Http and DB context elements up in Span flyout (#31057) (#31350)
* [APM] Move Http and DB context elements up in Span flyout (#31057)

* [APM] Closes #29697 by moving the Http and DB context elements up above the tabbed content/stacktrace. Also fixed some bugs:
	- was expecting pre-ecs context data in HttpContext and DatabaseContext
	- style issue with missing spacer between stackframes

* [APM] set font-size for Http url and Db statement preview above stacktrace & replaced SpanContext type definitions with their ECS equivalents

* [APM] update es fieldname SPAN_SQL to ecs object path
2019-02-20 08:17:00 -08:00
Nathan Reese
55ac88ecac
[Maps] add beta label to listing page (#31544) (#31557) 2019-02-20 06:51:21 -07:00
James Gowdy
a08e169ff9
[ML] Moving legacy kibana wizard classes to ML (#31425) (#31571)
* [ML] Moving legacy kibana wizard classes to ML

* removing wizard import
2019-02-20 13:43:20 +00:00
dave.snider@gmail.com
a9c46f44e4
Make map gradients more subtle (#30345) (#31529)
Cleanup in the maps app.
2019-02-19 16:54:19 -08:00
Joe Fleming
a2bae1ce62
chore: remove duplicate include path (#31499) (#31542)
in x-pack tsconfig
2019-02-19 17:50:07 -07:00
Felix Stürmer
bd2ae8864a
[Logs UI] Fix pre-ECS filebeat module message reconstruction rules (#30398) (#31502)
This fixes the message reconstruction for the pre-ECS formats of several filebeat modules by adding appropriate rules.
2019-02-19 21:54:20 +01:00
Joe Fleming
f4738c4ab6
feat: updated demodata (#31202) (#31516)
use current time range and add @timestamp field
2019-02-19 13:45:07 -07:00
Melissa Alvarez
9e2a2dad59
[ML] Job selector text take group selection into account (#31333) (#31490)
* job selector text: take group selection into account

* fix localization error
2019-02-19 13:16:44 -05:00
Josh Dover
48ab13153e
[upgrade] Localize reindexing flyout in Upgrade Assistant (#30432) (#31478) 2019-02-19 11:37:02 -06:00
Maryia Lapata
ca217c8882 New visualization search selection (#30196) (#31479)
* EUIfication of Wizard Step 2

* Update snapshot

* Remove unnecessarily function bind

* Ignor ts untill file is converted to ts

* Apply styles

* Make button filled

* Update labels

* Update types

* Unfilled button

* Update styles

* Remove unused translations

* Add "manage index patterns" button

* Remove buttons and hide per page options; get rid of injectI18n

* Add back button

* Update header

* Remove back button

* Update data test subject

* Add data-test-subj for tabs

* Fix test

* Make test subj consistent with initial data test subj

* Move SavedObject initializing to render function

* Update propTypes
2019-02-19 18:33:56 +01:00
Chris Roberson
6da397bd7b
[Monitoring] Add mappings for standalone archives and fix tests (#31315) (#31469)
* Add mappings for standalone and fix tests

* We are apparently mutating this and need to return a copy each time
2019-02-19 10:06:38 -05:00
Felix Stürmer
960ced0884
[Infra UI] Fix server-side retrieval of the kibana version (#31440) (#31465)
Backports the following commits to 7.0:
 - [Infra UI] Fix server-side retrieval of the kibana version (#31440)
2019-02-19 15:29:32 +01:00