Commit graph

35 commits

Author SHA1 Message Date
Brandon Kobel
57af8462e4
[7.x] Elastic License 2.0 (#90192)
* Updating everything except the license headers themselves

* Applying ESLint rules

* Manually replacing the stragglers
2021-02-03 18:39:13 -08:00
Tyler Smalley
baf56d80c4
[7.x] Updating the License (#88343) (#88745)
* Updating the Licenses, except for applying eslint, building

* Applying ESLint rules,building @kbn/pm, regenerating api docs

Co-authored-by: kobelb <brandon.kobel@elastic.co>
2021-01-19 17:54:11 -08:00
Mikhail Shustov
5bb0186c15
Remove dynamic mapped types from UiActions (#87075) (#87274)
* Remove dynamic mapped types from UiActions

* Remove import between data <-> embeddables

* remove outdated comments, export action types from discover_enhanced

* fix notice.txt

Co-authored-by: restrry <restrry@gmail.com>

Co-authored-by: Josh Dover <me@joshdover.com>
2021-01-05 13:27:11 +01:00
Mikhail Shustov
de6090c87b
[7.x] [DX] Prettier v2.2 (#83899) (#84114)
* [DX] Prettier v2.2 (#83899)

* update prettier with ts version support

* mute type-error

* run prettier on codebase

* fix examples

* fix errors after master merged
# Conflicts:
#	x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx
#	x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts

* fix add removed property
2020-11-23 21:24:39 +01:00
Luke Elmers
3153eb6afe
[docs] Add missing App Arch READMEs. (#82080) (#82385) 2020-11-02 20:36:59 -07:00
Devon Thomson
fc4a04bf61
[Time to Visualize] Small Attribute Service Fixes (#82072) (#82316)
* Removed some dashboard-centric wording from the Attribute Service & removed type argument from save method
2020-11-02 13:28:50 -05:00
Maja Grubic
cc3b7b2bae
[Refactor] Move AttributeService from Dashboard to Embeddable plugin (#79830) (#80177)
* [Refactor] Move AttributeService from Dashboard to Embeddable plugin

* Fix wrong import

* Fixing typescript errors

* Make Dashboard a required dependency

* Fixing circular dependency

* Fix label namespace

* Updating docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	docs/development/plugins/embeddable/public/kibana-plugin-plugins-embeddable-public.embeddablestart.md
#	docs/development/plugins/embeddable/public/kibana-plugin-plugins-embeddable-public.md
#	docs/development/plugins/embeddable/server/kibana-plugin-plugins-embeddable-server.embeddablesetup.md
#	src/plugins/embeddable/public/public.api.md
#	src/plugins/embeddable/server/server.api.md
2020-10-13 15:24:03 +01:00
Maja Grubic
5d33f62aae
Refactor attribute service (#78414) (#79621)
* Making saveMethod mandatory in attribute service

* Making unwrap method mandatory

* Making book embeddable respect new attribute service

* Remove savedObjectsClient from attribute service

* Add checkForDuplicateTitle method to book embeddable

* Make options mandatory on attribute service

* Changing Lens attribute service

* Somw more typescript fixes

* Fixing attribute service typescript and tests

* Fixing typescript errors

* Unsetting feature flag

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 14:53:09 +01:00
Mikhail Shustov
e8a05ae57b
Add TS projects for src/plugins & x-pack/plugins (#78440) (#78946)
* bump query-string version to remove manual type definitions

* remove manual type declaration

* add kibana_utils tsconfig

* add refs to kibana_utils tsconfig

* add kibana_utils to the project list

* add kibana_react project

* add support for x-pack/tsconfig.refs.json

* add ts project for x-pack licensing plugins

* add glob for ts projects in src/plugins & x-pack/plugins

* add refs to projects in examples

* fix ref paths in x-pack/test

* address mistic comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/kibana_utils/kibana.json
2020-09-30 17:10:04 +02:00
Devon Thomson
2bb44a6d05
[Time to Visualize] Panel Title Fixes (#78365) (#78847)
* [Dashboard][Embeddable] Add placeholder title to embeddable panel, stored 'show panel title' prop in embeddable input.
Co-authored-by: Maja Grubic <maja.grubic@elastic.co>
2020-09-29 17:14:25 -04:00
Mikhail Shustov
ee8bc62637
Extract src/core in a separate TS project (#76785) (#77509)
* break dependency on data plugin TS code

* move global typings to @kbn/utility-types

* import types from @kbn/utility-types

* remove type dependency on plugins

* add intermediate js files to break dependency on outter TS code

* temp type declaration for query-string

* declare src/core project

* export types to reference in the built d.ts files

* reference core project

* move jest types out of kbn/utility-types due to a clash with mocha types

* fix wrong es_kuery path and ts project paths

* reference core from packages consuming it

* x-pack & oss should use the same lodash version

* Revert "x-pack & oss should use the same lodash version"

This reverts commit 79cec5781e.

* use the same lodash version

* fix @types/lodash TS2300: Duplicate identifier error

* fix wrong imports

* update docs

* update docs

* add a comment why file is needed
# Conflicts:
#	packages/kbn-utility-types/index.ts
#	src/core/public/application/capabilities/capabilities_service.mock.ts
#	src/core/public/chrome/chrome_service.mock.ts
2020-09-16 07:51:42 +02:00
Devon Thomson
338a679c69
[Dashboard First] Genericize Attribute Service (#76057) (#76806)
Genericized attribute service, with custom save and unwrap methods and added unit tests.
2020-09-04 15:18:57 -04:00
Mikhail Shustov
bd66fab861
Introduce TS incremental builds & move src/test_utils to TS project (#76082) (#76632)
* move test_helpers to the core

* create base tsconfig

* all tsconfigs use the base one

* use test_helpers exposed from the src/core

* move getFieldFormatsRegistry to data plugin

* add test_utils project

* compile types after checkout

* add a stub for platform tsconfig.json

* fix broken import

* fix broken path to the base config

* set tsBuildInfoFile for project without outDir

* do not commit tsbuildinfo file

* do not check output d.ts files

* fix type error

* use separate config to build types

* rollback changes to include paths

* mute import zone error

* rename files to avoid references to tsd

* do not use tsd for type tests

* include all ts files in project

* run buildRefs before type check to ensure the latest version

* store tsbuildinfo locally

* update paths to base config

* comment out core/tsconfig.json

* remove ui path

* fix wrong tsbuildinfo path
2020-09-03 23:02:05 +02:00
Mikhail Shustov
1c1dbe5c95
Update to TS v4 (#73924) (#76069)
* bump ts to v4

* MOAR RAM

* fix type errors for OSS

* first pass on x-pack errors

* second pass on x-pack type errors

* 3rd pass on x-pack type-errors

* mute errors if complex cases

* don't delete if spread suffices

* mute other complex cases

* make User fields optional

* fix optional types

* fix tests

* fix typings for time_range

* fix type errors in x-pack/tests

* rebuild kbn-pm

* remove leftovers from master update

* fix alert tests

* [Telemetry Checker] TS4 Fixes

* bump to 4.0.1-rc

* fix new errors in master

* bump typescript-eslint to version supporting TS v4 syntax

* fix merge commit errors

* update to the stable TS version 4.0.2

* bump ts-eslint to version supporting ts v4

* fix typo

* fix type errors after merge

* update ts in another new package.json

* TEMP: remove me

* Revert "TEMP: remove me"

This reverts commit dc0fc3bae6.

* [Telemetry] Update snapshot for new TS4 SyntaxKind

* bump prettier to support TS v4 syntax

* fix prettier rules

* last style change

* fix new type errors

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
# Conflicts:
#	packages/kbn-i18n/package.json
#	x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx
#	x-pack/plugins/uptime/public/components/settings/alert_defaults_form.tsx
2020-08-27 12:21:43 +02:00
Peter Pisljar
20cad14c74
cleaning up embeddable types (#75560) (#75847) 2020-08-25 17:12:35 +02:00
Devon Thomson
a618464de4
[Dashboard First] Add to Library Action (#75098) (#75562)
* created an add to library action that turns 'by value' embeddables into 'by reference' embeddables
2020-08-20 12:21:11 -04:00
Devon Thomson
a20de8eed2
[Dashboard First] Unlink from Library Action With ReferenceOrValueEmbeddable (#74905) (#75305)
* Added an unlink from library action which works with the ReferenceOrValue interface. Once
2020-08-18 13:07:53 -04:00
Devon Thomson
3d38bab525
[Dashboard First] Decouple Attribute Service and By Value Embeddables (#74302) (#74895)
* Added an interface that determines if an embeddable can be treated as either by reference or by value
2020-08-12 17:28:26 -04:00
spalger
e535aa6446 Revert "Revert "[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins (#70911) (#71355)" (#71382)"
This reverts commit c45fa3dd58.
2020-07-10 20:13:28 -07:00
Brian Seeders
c45fa3dd58
Revert "[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins (#70911) (#71355)" (#71382)
This reverts commit 243a864359.
2020-07-10 23:07:01 -04:00
Spencer
243a864359
[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins (#70911) (#71355)
Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap
#	src/plugins/embeddable/kibana.json
#	src/plugins/telemetry/kibana.json
#	src/plugins/ui_actions/kibana.json
#	x-pack/plugins/apm/kibana.json
#	x-pack/plugins/upgrade_assistant/kibana.json
2020-07-10 09:37:22 -07:00
Devon Thomson
370cb47b2c
[Example] Embeddable by Reference and Value (#68719) (#71272)
Added an attribute service to embeddable start contract which provides a higher level abstraction for embeddables that can be by reference OR by value. Added an example that uses this service.
2020-07-09 14:17:27 -04:00
Spencer
a0e2e976f0
[7.x] [kbn/optimizer] share all plugin bundles (#68986) (#69234)
* [kbn/optimizer] share all plugin bundles (#68986)

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [BundleRefPlugin] resolve imports to files too

(cherry picked from commit 2bb6ac1a796c6b8661d9ca6c33bef9e23d7a0764)

* [kbn/optimizer] fix windows compatibility (#69304)

Co-authored-by: spalger <spalger@users.noreply.github.com>
(cherry picked from commit db1df7bed0)

* [BundleRefPlugin] resolve imports to files too (#69241)

Co-authored-by: spalger <spalger@users.noreply.github.com>
(cherry picked from commit e03f2428b1)

* update extraPublicDirs to include latest changes

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-16 17:41:32 -07:00
Anton Dosov
32331f21f9
Embed dashboard by value example & some embeddable clean up (#67783) (#69163)
Added example for using dashboard container by value
1.1 Refactored embeddable explorer e2e test to use new example, removed not needed kbn_tp_embeddable_explorer plugin.
For embeddable explorer examples went away from using getFactoryById() to improve type checks
There is new component a replacement for EmbeddableFactoryRenderer with slightly more flexible api: EmbeddableRenderer.
3.1 We can improve it going forward to support more use case
2020-06-16 10:43:29 +02:00
restrry
2fefd60e90 update code style 2020-05-22 10:35:02 +02:00
Stacey Gammon
edd9af0b16
more propagated bad examples (#66920) (#67012) 2020-05-19 13:32:53 -04:00
Stacey Gammon
2901b93157
KP plugins shouldn't need package.json (#66654) (#66745)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-15 14:24:33 -04:00
Joe Portner
f6cb14ad1a
[7.x] Refactor SO types to use namespaceType (#63217) (#63745)
Remove `namespaceAgnostic` field that was deprecated in #54605,
use `namespaceType` instead.
2020-04-16 19:11:43 -04:00
Stacey Gammon
79cff4aacd
Add embeddable via saved object example (#61692) (#63613)
* Add embeddable via saved object example

* give todoRefEmbed a different name from the by value one

* fix types

* fix order of unmounting

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
2020-04-15 14:12:42 -04:00
Stacey Gammon
34028fd0d2
Prep for embed saved object refactor + helper (#62486) (#62664) 2020-04-06 15:31:48 -04:00
Stacey Gammon
cbd30bb19d Switch to embeddable factory interface with optional override (#61165) (#62360)
* wip

* typescript map embeddable

* More updates

* Address code review comments and update some usages in SIEM and uptime to the new types

* More clean up - carry over some of the SIEM types to maps for render tool tip

* fixes

* fixes

* Address more review comments

* fixes

* fixes

* fix jest test

* Fix visualize embeddable

* fixes after master merge

* Fixes

* Prefix variable with name "custom" to make it more obvious

* Remove layerList from input state

* fixes

* Update src/plugins/dashboard/public/embeddable/dashboard_container_factory.tsx

Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com>

* review updates

* fixes

* update maps readme

Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>

Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>
2020-04-02 16:15:46 -04:00
Pierre Gayvallet
5d5c306002
Add plugin start contract to getStartServices return value (#61216) (#61415)
* add plugin own contract as third element of getStartServices result

* adapt plugins code

* update tests

* revert unknown to use void again

* update generated doc

* fix UT

* update mock to allow non-object `pluginStartContract`

* add @typeParam documentation
2020-03-26 12:40:56 +01:00
Stacey Gammon
9975e5e2a3
Embeddable API cleanup (#60207) (#60305)
* wip

* Remove test in legacy functional plugin
2020-03-17 08:46:18 -04:00
Stacey Gammon
68357d605f
Embeddable add panel examples (#57319) (#58048)
* Embeddable add panel examples

* add tests

* Fix type error after merge

* address code review comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-19 18:06:01 -05:00
Stacey Gammon
cf21b2dd15
Embeddable examples on the platform and included with --run-examples flag (#52111) (#53190)
* Add a new platform embeddable example plugin

* Remove extra hello world test impl.

* cleanup

* code review updates

* Change example to highlight and have parent filter out children

* Fix deep comparison of embeddable prop

* adjust help text
2019-12-16 17:45:26 -05:00