Commit graph

39570 commits

Author SHA1 Message Date
Rudolf Meijering
92e7cf6b1a
[7.12] Speed up spaces tests by letting v2 migrations do less work (#91829) (#94801)
* Speed up spaces tests by letting v2 migrations do less work (#91829)

* Don't mess with v2 migration's index

* Speed up spaces tests by letting v2 migrations do less work

* Add disabled mapping for spaces so that plugin can be disabled

* Add security as codeowners of xpack saved object api integration suite
# Conflicts:
#	.github/CODEOWNERS
#	x-pack/test/functional/es_archives/saved_objects_management/spaces_integration/mappings.json
#	x-pack/test/saved_object_api_integration/common/fixtures/es_archiver/saved_objects/spaces/mappings.json

* Fix backport for ES _types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-19 18:08:07 -04:00
Pierre Gayvallet
cb8e30bf0a
add banners settings doc (#94672) (#95006)
* add banners settings doc

* address review comments

* add link to the correct file

* use singular for banner
2021-03-19 03:24:34 -04:00
Kibana Machine
c88460bdff
Re-Enabling Grok Debugger Functional UI Tests (#91274) (#94996)
* Adding .only clause for testing purposes.

* Removing .only and reenabling test. Also changing back to group 13.

* Removing .only and reenabling test. Also changing back to group 13.

* Removed comment mentioning github issue.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: John Dorlus <silne.dorlus@elastic.co>
2021-03-18 21:38:06 -04:00
Devon Thomson
15bd4b1889
[7.12] [Time to Visualize] Add Discrete Library Option to Save Modal (#94589) (#94962)
* [Time to Visualize] Add Discrete Library Option to Save Modal (#94589)

* save modal UI and Redirect and save to library

Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com>
# Conflicts:
#	.github/CODEOWNERS
#	x-pack/test/functional/apps/lens/add_to_dashboard.ts

* Update x-pack/test/functional/apps/lens/add_to_dashboard.ts

* Delete CODEOWNERS
2021-03-18 18:34:31 -04:00
Kibana Machine
a1fdc06bd0
[Fleet] Fix version on agent details screen (#94867) (#94978)
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
2021-03-18 22:23:52 +00:00
Kaarina Tungseth
403f8b720a
[DOCS] Fixes Timelion link from UI to docs (#94985) (#94989) 2021-03-18 16:30:08 -05:00
Kaarina Tungseth
129bc68033
[DOCS] Reformats Dashboard and adds Lens reference (#89615) (#94987)
* [DOCS] Reformats Dashboard and adds Lens reference

* ⚗️ First trial of Lens FAQ

* Fixes broken title levels

* Link fix

* Fixes tsvb link

* Fixes tsvb link

* [DOCS] Reformats Dashboard and adds Lens reference

* ⚗️ First trial of Lens FAQ

* Fixes broken title levels

* Link fix

* Fixes tsvb link

* Fixes tsvb link

* [Lens] Add drag and drop keyboard navigation docs

* remove unlinked files

* [Lens] tutorial advanced first version

* corrections

* Kaarinas changes

* corrections after CR

* Update docs/user/dashboard/lens-advanced.asciidoc

* 📝 Add more Lens related FAQ

* Updates Lens page

* Update docs/user/dashboard/lens.asciidoc

* drag and drop copy and gif

* some corrections after Wylie's second review

* Review comments

* Final changes

* Update lens-advanced.asciidoc

ordering fixed

* Comment organization

* Final clean up

Co-authored-by: dej611 <dej611@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>

Co-authored-by: dej611 <dej611@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
2021-03-18 16:19:59 -05:00
Michael Dokolin
37dfe5f746
Fix links to the numeral formatting (#94858) (#94954)
* Fix links to the numeral formatting in the advanced settings (#84167)
* Fix a link to the numeral formatting in the index pattern field settings (#84167)
# Conflicts:
#	docs/development/core/public/kibana-plugin-core-public.doclinksstart.md
#	src/core/public/doc_links/doc_links_service.ts
#	src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/bytes/__snapshots__/bytes.test.tsx.snap
#	src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/number/__snapshots__/number.test.tsx.snap
#	src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/number/number.tsx
#	src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/percent/__snapshots__/percent.test.tsx.snap
#	src/plugins/index_pattern_field_editor/public/components/field_format_editor/editors/percent/percent.test.tsx
2021-03-18 15:26:25 -04:00
EamonnTP
91a6bff9bd
[DOCS] Update APM filter and query content (#94446) (#94911)
* Update filter and query content

* Edits following review

* Minor edit
2021-03-18 09:06:42 -04:00
Jean-Louis Leysens
1e7935e257
[Ingest Pipelines] Fix serialization and deserialization of user input for "patterns" fields (#94689) (#94897)
* updated serialization and deserialization behavior of dissect and gsub processors, also addded a test

* also fix grok processor

* pivot input checking to use JSON.stringify and JSON.parse

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-18 07:19:04 -04:00
Christos Nasikas
68e8ba4024
[Cases] Add SIR connector in case connector schema (#94786) (#94838)
# Conflicts:
#	x-pack/plugins/cases/server/connectors/case/index.test.ts
#	x-pack/plugins/cases/server/connectors/case/schema.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-18 06:24:19 -04:00
Xavier Mouligneau
b7f9a41f48
[7.12][SECURITY SOLUTIONS][Alerts Actions] Fix migration from 7.11.0/7.11.1 to 7.12 (#94881)
* do not modify connector with the right structure

* review trying to bring back incident to live when we can

* manage custom action
2021-03-18 00:27:20 -04:00
Matthew Kime
a576e2a0dd
Fix index pattern create with cross cluster search _and_ partial results (#94664) (#94818)
* fix index pattern create with cross cluster  and partial results and update tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-17 23:27:06 -04:00
Liza Katz
b714b332fe
Fix 89878 (#94793) (#94825)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-17 20:47:49 -04:00
James Rodewig
9ae52d01e0
[DOCS] Migrate ingest pipeline docs to ES reference (#94625) (#94865) 2021-03-17 17:19:16 -04:00
Brandon Morelli
931120e921
[APM] docs: correlations feedback (#94750) (#94853) 2021-03-17 16:11:25 -04:00
Liza Katz
338916c3e4
[7.12] [Bug] missing timepicker:quickRanges migration (#93409) (#94424)
* [Bug] missing timepicker:quickRanges migration (#93409)

* timepicker:quickRanges

* code review

* Change into a 7.12 migration
# Conflicts:
#	src/core/server/ui_settings/saved_objects/migrations.ts

* Delete migration

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-17 14:43:26 -04:00
Joe Portner
4fa13de239
[7.12] Fix invalid integration test data (#94616) (#94796)
* Extract Reporting integration test data.json.gz into data.json

* Fix invalid integration test data (#94616)
2021-03-17 11:15:44 -04:00
Kibana Machine
9b1a579afd
Remove string as a valid registry var type value (#94174) (#94751)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
2021-03-16 17:42:31 -04:00
Brandon Morelli
d52faa3509
docs: [APM] Correlations (#94620) (#94734) 2021-03-16 15:29:28 -04:00
Devon Thomson
b695ea1d0c
[Save Modal] Quick Fix for Scrollbar (#94640) (#94719)
* quick fixes for no scroll bar on save modals
2021-03-16 14:08:31 -04:00
Devon Thomson
07e329d44e
tiny fix for loading state in dashboard top nav (#94643) (#94713) 2021-03-16 13:34:09 -04:00
Dario Gieselaar
b7b4eed426
[7.12] [APM] Use top_hits instead of top_metrics (#94694) (#94709) 2021-03-16 13:24:57 -04:00
Kaarina Tungseth
9b0fd8fa9c
[DOCS] Canvas updates for 7.12.0 (#94325) (#94725)
* [DOCS] Canvas updates for 7.12.0

* Fixes Visualize Library title
2021-03-16 12:32:20 -04:00
Gabriel Landau
36829e4130
Add bytes_compressed_present to Endpoint Security Telemetry (#94594) (#94701) 2021-03-16 12:22:06 -04:00
Marco Vettorello
10605acad5
[7.12] Fixes chromium bug on rendering charts (#94698) 2021-03-16 17:16:23 +01:00
Kibana Machine
4355b1fe8c
[Logs UI] Style improvements for log stream search strategy (#94560) (#94685)
Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
2021-03-16 10:42:06 -04:00
Oliver Gupte
e5b68217e3
[APM] Hide correlations tabs with license message (#94494) (#94660)
* [APM] Hide correlations tabs with license message (#94228)

* removes unused CorrelationsMetricsLicenseCheck component

* Code readability improvements

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-15 20:48:35 -07:00
Kibana Machine
508fe2f1df
[Security Solution][Detections] Display callout if users have new ML jobs installed (#94393) (#94657)
* WIP: Add basic structure of our ML Job callout

* Tests are not implemented
* logic is questionable
* Detections now makes redundant ML API calls

* Fix JSDoc reference

* Move ML Jobs callout to Rules page

As opposed to the more general Detections page.

* Extends callout logic to include installation of any affected jobs

* If old jobs are used with new ECS data, you'll be missing
  anomalies/alerts
* If new jobs are used with old ECS data, you'll be missing
  anomalies/alerts

* Flesh out our link to ML Job compatibility docs

This page doesn't exist yet; the URI/copy is subject to change.

* ML Job Upgrade -> ML Job Compatibility

This is a more accurate name for the concept since the problem is more
general than presence/absence of an upgrade.

* Add some placeholder copy to get the ball rolling

* Test callout behavior with different API responses

* Prevent fetching ML data when ML popover is opened/closed

We already fetch this data when the component is initially rendered. In
the normal workflow of page load -> open popover, we perform six (6) ML
API calls, 3 of which are redundant.

The one downside of this is that opening/closing the popover will not
refresh data; however, this workflow would previously have resulted in 6
API calls as well.

* Revert "Prevent fetching ML data when ML popover is opened/closed"

This reverts commit 810b78d2b9.

* Update link to relevant documentation

We're going to add a new section to this existing page, and link
directly to that heading. We should be able to generate whatever anchor
we need here, so choosing one arbitrarily on the assumption that docs
can make it work.

* Update copy from product

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
2021-03-15 23:06:30 -04:00
Devon Thomson
2dca142c90
[Dashboard] Clear Add Panel On App Leave (#94530) (#94634)
* cleared add panel in useEffect cleanup function
2021-03-15 18:40:07 -04:00
Frank Hassanabad
ddf265f57f
[7.12] Updated to allow chunked queries and to increase the timeouts of the REST backend (#94531) (#94607)
* Updated to allow chunked queries and to increase the timeouts of the REST backend (#94531)

Increases the pre-packaged socket timeout and chunks the requests. Existing e2e tests should cover the changes. Interesting enough, when the server sends back a 408, Chrome will re-send the same request again which can cause socket/network saturations. By increasing the timeout, Chrome will not resend the same request again on timeout.

Right now, there is not a way to increase the timeouts for the alerting framework/saved objects as far as I know for connections. That would be an additional safety measure in additional to doing chunked requests. Chunked requests will ensure that the pre-packaged rule does not exhaust ephemeral ports and limit the concurrent requests.

See this issue talked about below:
https://github.com/sindresorhus/ky/issues/233
https://groups.google.com/a/chromium.org/g/chromium-dev/c/urswDsm6Pe0
https://medium.com/@lighthopper/connection-retry-schedule-in-chrome-browser-a9c814b7dc20

**Manual testing**
You can bump up the rule version numbers manually through a search and replace and then install them. You can add a `console.trace()` to the backend and slow down the requests to ensure they are not happening more than once.

```
Trace:
    at updatePrepackagedRules (/Users/frankhassanabad/projects/kibana/x-pack/plugins/security_solution/server/lib/detection_engine/rules/update_prepacked_rules.ts:34:11)
    at createPrepackagedRules (/Users/frankhassanabad/projects/kibana/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/add_prepackaged_rules_route.ts:140:9)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at /Users/frankhassanabad/projects/kibana/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/add_prepackaged_rules_route.ts:66:27
    at Router.handle (/Users/frankhassanabad/projects/kibana/src/core/server/http/router/router.ts:272:30)
    at handler (/Users/frankhassanabad/projects/kibana/src/core/server/http/router/router.ts:227:11)
    at exports.Manager.execute (/Users/frankhassanabad/projects/kibana/node_modules/@hapi/hapi/lib/toolkit.js:60:28)
    at Object.internals.handler (/Users/frankhassanabad/projects/kibana/node_modules/@hapi/hapi/lib/handler.js:46:20)
    at exports.execute (/Users/frankhassanabad/projects/kibana/node_modules/@hapi/hapi/lib/handler.js:31:20)
    at Request._lifecycle (/Users/frankhassanabad/projects/kibana/node_modules/@hapi/hapi/lib/request.js:371:32)
    at Request._execute (/Users/frankhassanabad/projects/kibana/node_modules/@hapi/hapi/lib/request.js:279:9)
```

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

* Wrong import as alerting is now called alerts. bad merge
2021-03-15 16:25:15 -04:00
Devon Thomson
d252005038
[Time to Visualize] Fix Unsaved Changes Badge Appearing After Save & Return (#94529) (#94601)
* fixed unsaved changes out of sync after save and return
2021-03-15 15:02:13 -04:00
Anton Dosov
c0586e5a34
Fix importing dashboards created before ~6.1.0 (#94332) (#94566) 2021-03-15 11:10:20 -04:00
Kaarina Tungseth
24eee32df6
[DOCS] TSVB updates for 7.12 (#93317) (#94579)
* [DOCS] TSVB updates for 7.12

* Fixes formatting

* Clean up

* Review comments

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Review comments

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
2021-03-15 10:59:28 -04:00
Nick Partridge
77fd4a1c9e
fix sm brushing issue (#94510) 2021-03-15 09:07:29 -05:00
Mario Castro
c922677497
Rename googlecloud to gcp in Add Data UI (#93725) (#94547)
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
2021-03-15 07:56:33 -04:00
Kibana Machine
fcab4fd040
[Logs UI] Fixes missing fields in the log entries search strategy (#94443) (#94522)
Co-authored-by: Kerry Gallagher <471693+Kerry350@users.noreply.github.com>
2021-03-12 09:12:55 -05:00
liza-mae
5d1707a101
Upgrade smoke tests (#92893) (#94477)
* Upgrade smoke tests

* Fix lint issues

* Remove duplicate line

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-11 19:39:29 -07:00
Yara Tercero
e3c3c7c3f2
[Security Solution][Detections] - Fix threshold preview (#94224) (#94497)
### Summary

Addresses #92732

7.11+ versions of threshold preview histogram were aggregating by "event.category". This PR updates the preview histogram to take into account threshold field groups and cardinality.

It may need to be called out in documentation or updated to remind users that preview is not an exact guarantee of what signals will be produced as it does not take into account interval and any timestamp_override. Threshold gets a tad bit more confusing because of the multiple aggregations occurring (threshold --> group by field --> histogram).
2021-03-11 18:55:30 -05:00
Liza Katz
312238160e
Add a link to the reporting management dashboard in the started job toast (#81583) (#93961) (#94487)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Michael Dokolin <mikhail.dokolin@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-11 17:56:33 -05:00
Kaarina Tungseth
f7c25fecf0
[DOCS] Changes Visualize to Visualize Library (#93055) (#94214)
* [DOCS] Changes Visualize to Visualize Library

* Review comments

* Review comment

* Removes background in embed-kibana.png
2021-03-11 17:46:06 -05:00
Kaarina Tungseth
9a51198efe
[DOCS] Adds the 7.12.0 dashboard features (#93687) (#94504)
* [DOCS] Adds the features for 7.12

* Feature changes

* Review comments

* Adds Switch to view mode
2021-03-11 17:38:05 -05:00
Matthew Kime
f3f9fd9ab4
fix median agg with scripted field (#93731) (#94475)
* fix median agg with scripted field and update test
2021-03-11 16:10:06 -05:00
Lukas Olson
7831473918
Fix search telemetry to only update SO periodically (#93130) (#94455)
* Fix search telemetry to only update SO periodically

* Handle case when searches completed mid flight

* Fix error in resetting counters

* Update docs

* update docs

* Don't track restored searches

* Update docs

* Update docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
# Conflicts:
#	api_docs/cases.json
#	api_docs/data_search.json
#	api_docs/lists.json
#	api_docs/security_solution.json
2021-03-11 13:34:24 -05:00
Oliver Gupte
d7ba901c50
[APM] Handle correlations view with missing field names (#93443) (#94015) (#94197)
* [APM] Handle correlations view with missing field names (#93443)

* fixes spelling

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-11 09:55:12 -08:00
Gidi Meir Morris
11f4ea8ae4
[Task Manager][Docs] fixes the formatting of an "Important" box (#94276) (#94417)
Fixes the rendering of the Important callout on: Task Manager Production Considerations
2021-03-11 07:22:14 -05:00
Jean-Louis Leysens
be49344385
[Console] Update copy when showing warnings in response headers (#94270) (#94402)
* remove "deprecated: " from console warning

* refactor "deprecation" to "warning"

* complete name refactor in test files
2021-03-11 06:39:17 -05:00
Alexey Antonov
088525c003
Fix cannot brush on bars of vertical bar chart to zoom into data (#94290) (#94302)
Closes: #94248
2021-03-11 01:56:09 -05:00
Andrew Goldstein
623f43cb8c
[Security Solution] Eliminates a redundant external link icon (#94194) (#94388)
## [Security Solution] Eliminates a redundant external link icon

- Fixes an issue where [a redundant external link icon](https://github.com/elastic/kibana/issues/89084) was rendered next to port numbers

Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link.

- Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions

### Before

<img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png">

### After

<img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png">

### Desk testing

Desk tested in:

- Chrome `89.0.4389.82`
- Firefox `86.0`
- Safari `14.0.3`
2021-03-10 21:31:29 -05:00
gchaps
3e3b61b148
Adds doc for API changes (#93544) (#94386)
* [DOCS] Adds doc for plugin API changes

* [DOCS] Edits doc

* [DOCS] Removes links to older docs

* [DOCS] Adds links to previous versions
2021-03-10 16:37:01 -08:00