Commit graph

215 commits

Author SHA1 Message Date
Dmitry Lemeshko
6672cf3054
Improve recently failed tests (#48389) (#48574)
* [apps/management] improve import objects tests

* [page_objects/dashboard_page] replace link navigation with direct url

* [dashboard/time_zones] reset date format via API

* update jest snapshot

* [management/_kibana_settings] reset date format via API

* revert changees to dashboard tests

* run ciGroup 7 & 8 15x times

* Revert "run ciGroup 7 & 8 15x times"

This reverts commit 8be64d52dc.
2019-10-17 22:12:50 +02:00
spalger
cebb9f4fca skip flaky suite (#46305)
(cherry picked from commit 5b67cd5e4f)
2019-09-21 11:35:57 -07:00
Lee Drengenberg
1136d5eac2
use correct id in setting default index pattern in dashboard tests (#45601) (#46012)
* replace guid with logstash-* in data for default index pattern

* revert change to data archive, instead fix index pattern id
2019-09-18 18:30:11 -05:00
Dmitry Lemeshko
c2aea564b7
FTR: fix WebDriver Actions calls (#44605) (#45000)
* [services/web_element_wrapper] add actions API methods

* fixes

* [services/browser] fix dragAnDrop to work in both w3c/non-w3c modes

* small review changes

* dragAndDrop: add default values for offset
2019-09-06 17:39:49 +02:00
Vadim Dalecky
a332eaa703
fix: 🐛 pass whole action context to isCompatible() method (#43457) (#43524)
* fix: 🐛 pass whole action context to isCompatible() method

* test: 💍 add function test for saved search filtering in pie

* test: 💍 move save search functional test in its own test suite
2019-08-19 15:43:30 +02:00
Vadim Dalecky
17663b28d5
[7.x] Embeddables 👉 NP-ready (#41272) (#43093)
* refactor: 💡 create registries file

* docs: ✏️ add testing command to docs

* chore: 🤖 create state folder

* chore: 🤖 WIP

* refactor: 💡 remove static imports of stateful things

Make Embeddables ./triggers tests pass

* test: 💍 add await-of for testing

* refactor: 💡 move stateless code into shim's lib/ folder

* test: 💍 add registry tests

* feat: 🎸 add Embeddable plugin public "setup" API

* feat: 🎸 create Embeddable plugin shim

* refactor: 💡 minor improvements for new plugin structure

* refactor: 💡 move test helpers into shim

* feat: 🎸 add Embeddable setup.getTrigger() method

* feat: 🎸 inject setup API into pure setup functions

* refactor: 💡 generate Embeddable setup API in a loop

* feat: 🎸 add getTriggerActions() Embeddable setup function

* feat: 🎸 add getTriggerCompatibleActions() to Embeddable shim

* chore: 🤖 uninstall await-of package

* chore: 🤖 simplify imports/exports

* test: 💍 improve testing utilities

* feat: 🎸 add executeTriggerActions() Embeddables setup method

* fix: 🐛 remove non-existing import

* chore: 🤖 cleanup actions

* refactor: 💡 move errors into dedicated errors.ts file, add test

* test: 💍 add unit test for ApplyFilterAction class

* test: 💍 import helpers correctly after refactoring

* test: 💍 fix actions tests

* feat: 🎸 clean up /lib/embeddables

* test: 💍 fix /lib/containers tests

* test: 💍 make embeddable_panel.test.tsx tests pass

* refactor: 💡 work on briging EditPanelAction action to /actions

* test: 💍 make /containers tests pass

* test: 💍 make /actions and /embeddables tests pass

* test: 💍 clean up tests from legacy platform static imports

* feat: 🎸 add getEmbeddableFactories API method

* test: 💍 add tests for factory list method

* feat: 🎸 add start life-cycle API

* feat: 🎸 unify Embeddables API

* refactor: 💡 create /css folder, move all CSS there

* feat: 🎸 improve dashboard container shim

* feat: 🎸 progress on dashboard container shim

* feat: 🎸 implement getEmbeddableFactory Embeddable API method

* feat: 🎸 improve embeddable container shim

* test: 💍 fix dashboard container expand panel tests

* test: 💍 fix dashboard grid tests

* test: 💍 fix createPanel tests

* test: 💍 fix dashboard viewport tests

* test: 💍 fix dashboard container tests

* test: 💍 add Embeddable plugin mock

* test: 💍 improve tests after merge

* refactor: 💡 move new platform code into np_ready folders

* chore: 🤖 fix some TS errors after merge

* chore: 🤖 fix more TS errors after merge

* fix: 🐛 fix TypeScript errors in kbn_tp_sample_panel_action

* fix: 🐛 fix more TypeScript errors

* fix: 🐛 fix TypeScript in functional tests

* fix: 🐛 fix more TypeScript errors

* fix: 🐛 fix more TS errors

* refactor: 💡 pass deps through constructors

* refactor: 💡 improve dependency injection and fix tests

* test: 💍 fix container integration tests

* test: 💍 fix customize_panel_modal tests after refactor

* test: 💍 fix all tests in embeddable_api

* chore: 🤖 fix linter error

* test: 💍 fix dashboard_embeddable_container tests after merge

* test: 💍 fix /src TypeScript errors

* fix: 🐛 fix Jest tests and add global typings in demo plugin

* fix: 🐛 fix build errors

* fix: 🐛 make build start without errors

* fix: 🐛 in dashboard container don't import types from ui/*

* chore: 🤖 fix linter errors

* refactor: 💡 remove getUserData, remove another ui/new_platform

* chore: 🤖 fix linter errors

* refactor: 💡 remove ui/new_platform from HelloWorldAction

* refactor: 💡 remove ui/new_platform from SendMessageAction

* refactor: 💡 remove ui/new_platform from ContactCardEmbeddableF*

* chore: 🤖 fix ESLint errors

* feat: 🎸 throw if action or trigger with given ID already exists

* feat: 🎸 throw if embeddable factory already registered

* docs: ✏️ fix tsdoc

* chore: 🤖 remove unused @ts-ignore

* refactor: 💡 remove createEmbeddables() function

* refactor: 💡 use new NP inspector plugin

* fix: 🐛 fix TypeScript errors

* chore: 🤖 improve plugin manifests

* feat: 🎸 cherry pick exported API from Embeddable plugin

* refactor: 💡 do not import constants from Kibana App

* fix: 🐛 remove unnecessary any

* chore: 🤖 uncomment SASS files

* refactor: 💡 remove IndexPattern logic out of dashboard panel

* refactor: 💡 move RefreshInterval and TimeRange to New Platform

* fix: 🐛 revert back notifications usage

* chore: 🤖 export test samples from index.ts files

* test: 💍 re-enable ApplyFilterAction integration tests

* chore: 🤖 remove unused translation

* refactor: 💡 rename variable to something less React specific

* fix: 🐛 improve CSS imports, remove unused hack, remove any type

* fix: 🐛 fix Embeddables demo plugin

* fix: 🐛 fix missing SASS variable

* fix: 🐛 re-enable translation

* fix: 🐛 uncomment saved object flyout panel logic

* refactor: 💡 pass in <SavedObjectFinder> from top level

* test: 💍 re-enable add_panel_flyout tests

* refactor: 💡 pass in <ExitFullScreenButton> through args

* fix: 🐛 import specific constants to fix functional tests

* fix: 🐛 fix CI type_check error

* test: 💍 change import paths to fix functional tests on CI

* test: 💍 fix exit button test after refactoring

* refactor: 💡 make do not change page on grid error

* test: 💍 fix functional test

* refactor: 💡 move CSS next to components

* fix: 🐛 remove missing props

* test: 💍 try fixing functional test on CI

These tests pass locally, but fail on CI. This is a stab to fix it on
CI.

* refactor: 💡 move variables.scss one folder up

* test: 💍 disable Embeddable Explorer functional tests

* chore: 🤖 remove onCoreReady in functional tests

* test: 💍 disable maps functional test for embeddables

* chore: 🤖 remove comment, export types explicitly

* refactor: 💡 remove unused `firstName`, add link to issue

* refactor: 💡 remove double underscore __ in test registry names

* refactor: 💡 remove utils folder, move bootstrap() fn to top lvl

* test: 💍 uncomment edit_panel_action tests

* test: 💍 uncomment inspect_panel_action tests
2019-08-12 13:46:06 +02:00
Dmitry Lemeshko
ffb539bdce
[apps/dashboard] skip part of filtering tests on FF (#43047) (#43052) 2019-08-09 22:47:35 +02:00
Luke Elmers
40c8f1bbc2
Ensure visualizations in percentage mode respect the advanced settings percent format (#39044) (#41855) 2019-07-24 08:19:56 -06:00
Stacey Gammon
4ea28cce3a
turn on filtering tests (#41202) (#41792)
* turn on filtering tests

* run x-pack-firefoxSmoke ciGroup 40 times, run dashboard tests 20 times per job

* Revert "run x-pack-firefoxSmoke ciGroup 40 times, run dashboard tests 20 times per job"

This reverts commit 5ef02cc53ba5085c3f74431cb6ef20be2d876cde.
2019-07-23 13:57:15 -04:00
Liza Katz
8804085a9c
hide top nav menu in full screen mode of maps and dashboard (#41672) (#41731)
* hide top nav menu in full screen mode of maps and dashboard

* Fixed dashboard full screen mode and added full screen mode test to maps
2019-07-23 11:25:42 +03:00
Spencer
68f14413a7
[7.x] [jest] disallow invalid describe calls (#41378) (#41483)
* [jest] disallow invalid describe calls

* correct other describe calls

* remove unnecessary glob

* cast decribe names to strings

* remove new async describe function

# Conflicts:
#	x-pack/legacy/plugins/index_management/__jest__/client_integration/home.test.ts
#	x-pack/test/functional/apps/uptime/monitor.ts
2019-07-18 15:25:50 -07:00
Stacey Gammon
e526e0404f
Stabilize createNewDashboard testfunction (#41008) (#41199)
* This function will be flaky if the page is still loading and newItemButton does not exist but will soon.

* Skip only the other flaky test, this PR should fix the one
2019-07-16 10:04:51 -04:00
spalger
3b59476194 skip flaky suite (#41088) (#41087)
(cherry picked from commit f0e7b9e5b9)
2019-07-15 08:35:38 -07:00
Stacey Gammon
458de86dd8
Use embeddable v2 (#39126) (#41042)
* Final Embeddable API V2 PR

* fix: import discover embeddable scss file

* address code review comments

* Add a functional test that would have caught the bug... will look to add a unit version once I discover the error.

* Fix bug cause by async loading calls and changes to parent input while child is being created. added jest test

* remove outdated readme in dashboard folder

* need to always refresh dashboard container, not just when "dirty"

* add a wait, this issue started appearing right when I added this to the test

* Remove test that kills kibana ci so it's not a blocker. jest test was added for this scenario

* fix issues when panel is added then removed before it completes loading

* fix logic error with maps embeddable and isLayerTOCOpen
2019-07-12 16:28:29 -04:00
spalger
1288e82208 disable fully skipped suite (#40173)
(cherry picked from commit 0f5bfc0fce)
2019-07-02 12:23:00 -07:00
spalger
2ceab54e36 disable flaky test (#40173)
(cherry picked from commit 8a6ac547a8)
2019-07-02 09:08:05 -07:00
Stacey Gammon
4422fb1f57
Migrate old style queries stored in filters array (#38945) (#39293)
* Migrate old query filters

* Null check instead of undefined for more completeness

* remove unnecessary undefined check

* Use good defaults, not undefined, for brand new dashboards.

* fix: typescript errors

* be explicit instead of matchinline snapshot.

* default to Kuery when there is no query given
2019-06-19 15:49:58 -04:00
Dmitry Lemeshko
bc1234a9be
[firefox] Run functional tests in dedicated CI groups (#38416) (#39089)
* 2 jobs for Firefox tests

* review fixes

* make sh files executable

* add check reporter
2019-06-17 21:30:29 +03:00
Matthias Wilhelm
06d1567c32
Undo setting of $scope.refreshInterval at dashboard (#37175) (#38299)
* Add test for passing on dashboard url params to timepicker values

* Revert unnecessary setting of $scope.refreshInterval

refreshInterval is set at $scope.model, no need to set it directly at $scope like in discover and vis
2019-06-12 09:43:44 +02:00
Dmitry Lemeshko
d898d77e6d
functional tests/firefox wait for loading after page refresh (#38082) (#38118) 2019-06-06 07:58:51 +02:00
Josh Dover
5c4e18778f
[7.x] Add addError function to toastNotifications (#32187) (#37739) 2019-06-03 17:06:47 -05:00
Spencer
7aea62aa61
[7.x] FTR: add support for Firefox browser (#32509) (#37750)
* skip and adjust functional tests for Firefox

* downgrade geckodriver to 0.22.0

* [ftr] add firefox specific config file

* remove hard coded firefox adjustments

* remove firefox specific screenshot directory

* run functional tests in firefox in x-pack

* pass the logger to readConfigFile()

* rename local var

* skip xpack firefox config

* run xpack firefox functional tests in separate command

* update report name for XPack firefox results

* adjust viz shared item test

* skip shared item test

* [test/feature_controls] increase timeout to 20 sec & use forceLogout

* FF timeout on TSVB, refresh page on failure for url navigation

* [feature_controls/visualize_security] increase timeout to 20 sec

* skip dev_tools_spaces tests on FF

* run all groups 3 times

* skip more func tests

* skip more tests

* skip all feature controls tests for Firefox

* revert back changes in feature controls tests

* rename xpack report for chrome

* skip tile map for FF, wait for render before saving

* Revert "run all groups 3 times"

This reverts commit 12b4f69627.

* revert refresh on login

* apply feedback
2019-05-31 17:18:31 -07:00
Matt Bargar
d6100f4f36
Extract QueryBarInput component from QueryBar (#35827) (#36383)
Solution for use cases that need a query bar without a submit button or date picker that still want KQL and autocomplete. Necessary for the KQL in TSVB and KQL in filters aggregation efforts.
2019-05-09 17:49:16 -05:00
Dmitry Lemeshko
12aa67edb2
adjust tests to pass on Firefox (#35597) (#36069)
* adjust tests to pass on Firefox

* update feature controls tests to pass on Firefox

* use xpath to search for index pattern
2019-05-04 09:31:26 +02:00
Aaron Caldwell
94c4c86d0b
Fix map embeddable test (#34648) (#35609)
* Remove skip for testing on server. Unable to repro locally

* run kibana-ciGroup2 40 times per build

* Temporarily skip 'geo map' check

* Left out 'Rendering Test: ' in filter string

* Revert "run kibana-ciGroup2 40 times per build"

This reverts commit 103a5c9c6e.

* Review feedback. Remove 'Flaky' test ref
2019-04-25 12:51:31 -06:00
Dmitry Lemeshko
6a9b9d41e2
update functional tests to support Firefox (#34635) (#35205) 2019-04-17 15:25:20 +02:00
Matthias Wilhelm
d90e6cebbb
Use enter to submit save modals (#34417) (#34611)
Now you can use the Enter key to submit the form used e.g. when saving a new dashboard
Good for a11y + a time saver

Adds Form element, migration of Button onClick to Form's onSubmit 
Adds functional test for Enter key submission

Fix #30831
2019-04-05 12:43:19 +02:00
Spencer
883ea31bd2
[@kbn/expect] "fork" expect.js into repo (#33761) (#33794)
* [@kbn/expect] "fork" expect.js into repo

* [eslint] autofix references to expect.js

* [tslint] autofix all expect.js imports

* now that expect.js is in strict mode, avoid reassigning fn.length
2019-03-25 13:13:21 -07:00
spalger
e299444465 skip flaky test suite (#33504)
(cherry picked from commit 33083c80eb)
2019-03-22 09:26:12 -07:00
Dmitry Lemeshko
a4ed1c442c
Dashboard embeddable rendering tests: return names of failed visualisations (#32646) (#33488) 2019-03-19 11:52:01 +01:00
Caroline Horn
5f8e0fc800
Updates to K7 nav drawer and EUI to 9.4.0 (#32864) (#33260) 2019-03-14 14:53:06 -04:00
dave.snider@gmail.com
452c319d8e
Eui/9.2.1 + better dark mode (#32728) (#32919)
Updates EUI and makes some dark mode adjustments.
2019-03-11 13:44:43 -07:00
Tim Roes
358ab0da83
Use embeddable registry in add panel (#31400) (#32885)
* Prepare control flow to use embeddable factories in add panel

* Rewrite saved object finder and add tests

* Fix usages of new saved object finder

* fix test failures

* fix some functional tests and re-introduce makeUrl

* fix tests

* remove direct hrefs in saved_object_lists

* PR review fixes

* update snapshot

* overwrite width of viz dialog

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* fix tests

* review fixes #1

* review fixes #2

* dont use classname in functional test

* remove call to action button prop

* align buttons correctly

* fix tests

* remove debugging statement

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* review fixes #3

* improve filter behavior and enable it for search wizard

* adjust functional tests for new filter behavior

* Change translation id due to string change

* Update Jest snapshot
2019-03-11 14:29:49 +01:00
Spencer
497134f646
[dashboard/ftr] remove _-prefix from file names (#32585) (#32590) 2019-03-06 20:50:31 -08:00
Spencer
5e81271d3e
[7.x] [dashboard/ftr] disable panelCount assertions (#32579) (#32584)
Backports the following commits to 7.x:
 - [dashboard/ftr] disable panelCount assertions  (#32579)
2019-03-06 13:11:23 -08:00
Dmitry Lemeshko
34123b08fa
Restore webdriver-based functional test runner driver (#31446) (#32554) 2019-03-06 16:37:19 +01:00
Stacey Gammon
fa7dbe0372 [7.x] Stabilize dashboard render and filtering tests (#30419) (#30900)
Backports the following commits to 7.x:
 - Stabilize dashboard render and filtering tests   (#30419)
2019-02-12 16:52:53 -08:00
Stacey Gammon
c8ec384280
skip flaky filtering test (#30840) (#30851) 2019-02-12 17:00:45 -05:00
Matt Bargar
2f7e46e569
skip flaky dashboard test 2019-02-11 12:26:51 -05:00
Matt Bargar
8fbaf54149
Enable query bar datepicker in core apps where appropriate (#30171) (#30589)
Updates discover, visualize, and dashboard to use the date picker added to the query bar in #29130. There are still some areas where we use the top nav date picker, like Timelion and TSVB which don't have a query bar.
2019-02-08 19:10:41 -05:00
Matt Bargar
1d25e6d052
Makes KQL the default query language for new searches (#27092) (#30328)
Changes the default query language to KQL in all apps that respect the `search:queryLanguage` advanced setting.
2019-02-07 13:38:12 -05:00
Nathan Reese
6ad036b187
Replace angular timepicker with EuiSuperDatePicker (#29204)
* replace kbnTimepicker directive with EuiSuperDatePicker

* remove kbnTimepicker directive

* remove bootstrap datepicker

* Embed timepicker in query bar (#29130)

* replace kbnTimepicker directive with EuiSuperDatePicker

* remove kbnTimepicker directive

* remove bootstrap datepicker

* embed timepicker in query bar

* flesh out date picker in query bar for maps app

* wire up refresh config

* fix bug with way update function called by watcher

* get maps application functional tests working with new timepicker

* update setAbsoluteRange for EuiSuperDatePicker

* replace setQuickTime with calls to setAbsoluteTime

* remove open time picker button in discover empty results view

* pass config values to super-date-picker directive

* remove getPrettyDuration

* clean up typescript lint problems

* some functional test fixes

* try something else to fix I18n problems

* fix some more functional tests

* update query_bar jest test

* remove unused method in kbn_global_timepicker

* do not import removed timepicker styles

* remove mode from time state

* remove mode from time_history interface

* fix problem with ui_settings_defaults

* fix failing TSVB functional test

* another round to test fixes

* more functional test changes

* fixes for failing tests

* add retry block to flaky tsvb test

* styles/bootstrap_dark.less

* fix functional tests

* call fetch event even when times are the same

* add retry around flaky tsvb test

* fix timefilter jest test, attempt to fix another flaky functional test

* revert emitting fetch outside of areTimePickerValsDifferent check

* clean up time mode code that is no longer needed in dashboard

* fix timefilter tests changed by timefilter emit revert
2019-02-05 20:45:31 -07:00
Nathan Reese
908b387236
[Maps] add saved objects for all sample data sets (#28797)
* [Maps] add saved objects for all sample data sets

* add functional tests that compare sample data maps to baseline images

* add check for layer loading in functional tests

* try something out in CI

* try map without EMS regions

* add weblogs test but hide region layer

* skip tests with EMS vector layers

* gis-map to map and ES_GEOHASH_GRID to ES_GEO_GRID

* add resolution property to ES_GEO_GRID source descriptor

* move alphaValue from style descriptor to layer descriptor and rename to alpha

* terms join label change 'group by' to 'of'

* ensure sample data sets work with no internet access

* get functional tests working with updated full screen snapshots

* delete gis folder left overs

* give time for visibility to toggle to fire

* make web logs screen comparision more forgiving

* wait for layers to load on full screen
2019-02-04 20:18:11 -07:00
Matt Bargar
8a83955650
Re-introduce new filter bar (#29752)
Fixes the build issues introduced in #25563 and re-introduces the new react/eui/typescript filter bar, essentially reverting the revert in #29662. I did have to resolve one merge conflict in query_bar.tsx, and re-deleted all of the old filter bar code where translation code had been added.
2019-01-31 18:36:26 -05:00
Matt Bargar
45b24afe83
Revert "Migrate filter bar to React, EUI, and Typescript (#25563)" (#29662)
This reverts commit 410c094547.
2019-01-30 17:00:42 -05:00
Matt Bargar
410c094547
Migrate filter bar to React, EUI, and Typescript (#25563)
Rewrites the filter bar in React, EUI, and Typescript. Updates the look and feel of the filter bar and makes it consistent with the rest of K7.
2019-01-30 15:48:31 -05:00
Mike Côté
9eef63f783
Allow passing a default operator to use on saved object client find operations (#29339)
* Allow passing a default operator to use on find operations

* Default operator to OR like elasticsearch to avoid passing null

* Add dashboard search tests

* Make search_operator optional

* Fix query_params.test.js

* Include searchOperator in saved_object_finder

* Apply PR feedback

* Rename searchOperator to defaultSearchOperator
2019-01-30 11:33:44 -05:00
Marco Vettorello
b3eacc04d2
Fix timelion data-render-complete attribute on resize (#29320)
* Fix timelion missing renderer on resize

Adding a watch to the renderComplete promise to fix missing rendering of chart
when the resize observer detect a change in size.
Removed the existing resize observer.

* Revert removing observe resize

It's need on the timelion app to resize since that app doesn't use
visualize loader

* Change double watch to watchgroup

* Reenable skipped dashboard test
2019-01-25 15:50:04 +01:00
Spencer
65c80048fd
[ftr/dashboard] disable flaky suite (#29299) 2019-01-24 15:42:05 -08:00
Spencer
c052613962
[dashboard+gis] remove dark mode options (#29017)
* [dashboard+gis] remove dark mode options

* [reporting/extract] restore fixtures

* remove mentions of old `.theme-dark` class

* import panel styles from panel/_index.scss
2019-01-23 14:29:35 -08:00