Commit graph

3163 commits

Author SHA1 Message Date
Matt Bargar
ba7ceae114
Attempts to make saving of the current query more robust (#44797) (#44837) 2019-09-05 13:55:44 -04:00
Spencer
0850e521f5
Revert "[ci] compress jobs for CI stability" (#44584) (#44674)
This reverts commit debf8c62b4.
2019-09-03 12:25:45 -07:00
Rashmi Kulkarni
ea7d55f013
Rollup unskip test - test 30 times on CI (#44304) (#44535)
fixes https://github.com/elastic/kibana/issues/43559
2019-08-30 15:57:52 -07:00
Caroline Horn
5ea3a0dba3 Saved queries design cleanup (#44191) (#44380) 2019-08-29 16:58:26 +02:00
Spencer
408bf82284
[ci] compress jobs for CI stability (#44353)
# Conflicts:
#	x-pack/test/functional/apps/dashboard_mode/index.js
#	x-pack/test/upgrade_assistant_integration/upgrade_assistant/index.js
2019-08-29 05:10:13 -07:00
Dmitry Lemeshko
145945ebbf esArchiver: retry kibana config update (#43987) (#44169)
* [services/es_archiver] retry uiSettings update

* run x-pack-ciGroup7 30x times

* Revert "run x-pack-ciGroup7 30x times"

This reverts commit 80e199c3aa.

* [saved_object_api_integration/common/services] add retry service to the set

* add retry service for x-pack api tests
2019-08-27 18:00:39 -07:00
Greg Thompson
c6f6ddfd47
eui to 13.6.1 (#44149) (#44183) 2019-08-27 19:41:54 -05:00
Greg Thompson
9194883c0d
Upgrade EUI to 13.6.0 (#43916) (#44146)
* eui to 13.6.0

* euirange updates

* euipage snapshot updates

* add classname toggle for nav locking

* new header wrapper component; removed observable

* Add styles for locked nav

And updated BEM naming of `header-global-wrapper`

* move headerwrapper

* isLocked localStorage

* remove useEffect
2019-08-27 17:25:09 -05:00
Christiane (Tina) Heiligers
23bf0d5cca
Reset dirty saved query on reload (#43927) (#44142)
* Clears changes a loaded saved query before loading another one

* Adds general functional test to ensure changes to a saved query are discarded on reloading it

* Moves resetting a dirty saved query to the app controllers in Discover, Visualize and Dashboard
2019-08-27 13:55:15 -07:00
spalger
b77201c67e skip flaky test (#44132)
(cherry picked from commit 9d8f808063)
2019-08-27 13:40:59 -07:00
Matthias Wilhelm
5148944916
De-angularize DocViewer (#42116) (#44059)
* Migrate doc-viewer directive to use React/TypeScript

* Refactor DocViewsRegistryProvider

* Add compatibility for 3rd party plugins still using angular

* Add tests

Angular rendering for usage in React component:

Co-authored-by: spalger <email@spalger.com>
2019-08-27 10:46:03 +02:00
Matt Bargar
9d5e1ed5c1
Save query form validation on blur (#43726) (#43827)
This PR changes the save query form to only validate its inputs on blur. Previously we validated on every change. This could lead to the errors flashing in the user's face before they're done typing a valid input. For example, we allow spaces in the name field, but not at the beginning or end of the name. So if a user typed this is a long name with spaces they would see the error pop up every time they type a space, only to have it disappear when they type the next letter.
2019-08-23 16:48:45 -04:00
Rudolf Meijering
1d7c0d4cad Response factory parameters as named arguments (#43248) (#43883) 2019-08-23 14:49:36 -05:00
Spencer
e1f5a7c483
[indexPatterns/bytesFormat] switch default decimal places to 1 (#43785) (#43860)
* [indexPatterns/bytesFormat] switch default decimal places to 1

* set format:bytes:defaultPattern in some functional test suites
2019-08-23 08:23:08 -07:00
Daniil Suleiman
731ef1bd29
[Vis: Default editor] EUIficate gauge/goal options tab (#43265) (#43768)
* Euificate gauge options

* Changes params places

* Add ranges validation

* Get rid of legacy translates

* Fix functional tests

* Split gauge to panel components

* Disable alignment option
2019-08-23 13:59:44 +03:00
Matt Bargar
b97a95b109
Implement saved queries and filters (#39140) (#43720)
Introduces "saved queries". Saved queries are a new saved object type similar to saved searches but more limited in scope. They allow users to store the the query string in the query bar and optionally the set of filters and timefilter in order to reload them anywhere a query is expected: Discover, Visualize, Dashboard, anywhere that uses our full SearchBar component.
2019-08-21 18:44:09 -04:00
Josh Dover
1331456fd8
Replace CSP 'nonce-<base64>' directive with 'self' directive (#43553) 2019-08-21 16:13:26 -05:00
Dmitry Lemeshko
b31d1e1e29
functional tests for input control range (#42483) (#43685)
* [apps/visualize] functional tests for input control range

* update jest test to have 100% combined coverage with functional
2019-08-21 19:06:24 +02:00
dave.snider@gmail.com
905ab26de3
Upgrade EUI@13.3.0 (#42858) (#43613)
Upgrades 13.3.0
2019-08-20 16:28:58 -07:00
Josh Dover
8af89eddb6
Extend request handler with request scoped core capabilities (#43103) (#43541) 2019-08-19 15:17:37 -05:00
Vadim Dalecky
a332eaa703
fix: 🐛 pass whole action context to isCompatible() method (#43457) (#43524)
* fix: 🐛 pass whole action context to isCompatible() method

* test: 💍 add function test for saved search filtering in pie

* test: 💍 move save search functional test in its own test suite
2019-08-19 15:43:30 +02:00
Daniil Suleiman
39ca6bdb90
[Vis: Default editor] EUIficate region map options tab (#42944) (#43393)
* EUIficate region_map_options

* Reuse types

* Remove wms_options directive

* Remove style import

* Fix issue with join field default value

# Conflicts:
#	src/legacy/core_plugins/region_map/public/region_map_vis_params.html
2019-08-16 10:45:35 +03:00
Maryia Lapata
f5adc2c1eb
[Vis: Default editor] EUIficate Panel Setting tab (#42828) (#43277)
* EUIficate pointe-series and grid

* Apply TS

* Show grid on a panel

* Remove extra space

* Add TS

* Use BasicOptions

* Adjust func test

* Add dataTestSubj prop to SelectOption

* Use id instead of data-sest-subj

* Disable show x-axis lines when there is histogram agg

* Add tooltip for disabled 'Show x-axis lines' config

* Remove extra space
2019-08-15 07:45:00 +03:00
Matthias Wilhelm
99141c009e
Restore discover histogram selection triggering fetch (#43097) (#43286)
* Listen to timefilter fetch event to start fetching

* Improve functional test to catch error
2019-08-14 22:09:33 +02:00
Spencer
244145381a
[7.x] [ftr] enable visualRegression jobs (#42989) (#43124)
* enable visualRegression jobs

* skip the console and login visual tests
2019-08-12 15:29:44 -07:00
Brandon Kobel
c53e75d963
Adding "style-src 'unsafe-inline' 'self'" to default CSP rules (#41305) (#43065)
* Adding "style-src 'unsafe-inline' 'self'" to default CSP rules

* Updating jest snapshot

* Fixing api integration smoke test

* Verifying all CSP responses

* Fixing OIDC implicit flow test
2019-08-12 09:31:49 -07:00
Vadim Dalecky
17663b28d5
[7.x] Embeddables 👉 NP-ready (#41272) (#43093)
* refactor: 💡 create registries file

* docs: ✏️ add testing command to docs

* chore: 🤖 create state folder

* chore: 🤖 WIP

* refactor: 💡 remove static imports of stateful things

Make Embeddables ./triggers tests pass

* test: 💍 add await-of for testing

* refactor: 💡 move stateless code into shim's lib/ folder

* test: 💍 add registry tests

* feat: 🎸 add Embeddable plugin public "setup" API

* feat: 🎸 create Embeddable plugin shim

* refactor: 💡 minor improvements for new plugin structure

* refactor: 💡 move test helpers into shim

* feat: 🎸 add Embeddable setup.getTrigger() method

* feat: 🎸 inject setup API into pure setup functions

* refactor: 💡 generate Embeddable setup API in a loop

* feat: 🎸 add getTriggerActions() Embeddable setup function

* feat: 🎸 add getTriggerCompatibleActions() to Embeddable shim

* chore: 🤖 uninstall await-of package

* chore: 🤖 simplify imports/exports

* test: 💍 improve testing utilities

* feat: 🎸 add executeTriggerActions() Embeddables setup method

* fix: 🐛 remove non-existing import

* chore: 🤖 cleanup actions

* refactor: 💡 move errors into dedicated errors.ts file, add test

* test: 💍 add unit test for ApplyFilterAction class

* test: 💍 import helpers correctly after refactoring

* test: 💍 fix actions tests

* feat: 🎸 clean up /lib/embeddables

* test: 💍 fix /lib/containers tests

* test: 💍 make embeddable_panel.test.tsx tests pass

* refactor: 💡 work on briging EditPanelAction action to /actions

* test: 💍 make /containers tests pass

* test: 💍 make /actions and /embeddables tests pass

* test: 💍 clean up tests from legacy platform static imports

* feat: 🎸 add getEmbeddableFactories API method

* test: 💍 add tests for factory list method

* feat: 🎸 add start life-cycle API

* feat: 🎸 unify Embeddables API

* refactor: 💡 create /css folder, move all CSS there

* feat: 🎸 improve dashboard container shim

* feat: 🎸 progress on dashboard container shim

* feat: 🎸 implement getEmbeddableFactory Embeddable API method

* feat: 🎸 improve embeddable container shim

* test: 💍 fix dashboard container expand panel tests

* test: 💍 fix dashboard grid tests

* test: 💍 fix createPanel tests

* test: 💍 fix dashboard viewport tests

* test: 💍 fix dashboard container tests

* test: 💍 add Embeddable plugin mock

* test: 💍 improve tests after merge

* refactor: 💡 move new platform code into np_ready folders

* chore: 🤖 fix some TS errors after merge

* chore: 🤖 fix more TS errors after merge

* fix: 🐛 fix TypeScript errors in kbn_tp_sample_panel_action

* fix: 🐛 fix more TypeScript errors

* fix: 🐛 fix TypeScript in functional tests

* fix: 🐛 fix more TypeScript errors

* fix: 🐛 fix more TS errors

* refactor: 💡 pass deps through constructors

* refactor: 💡 improve dependency injection and fix tests

* test: 💍 fix container integration tests

* test: 💍 fix customize_panel_modal tests after refactor

* test: 💍 fix all tests in embeddable_api

* chore: 🤖 fix linter error

* test: 💍 fix dashboard_embeddable_container tests after merge

* test: 💍 fix /src TypeScript errors

* fix: 🐛 fix Jest tests and add global typings in demo plugin

* fix: 🐛 fix build errors

* fix: 🐛 make build start without errors

* fix: 🐛 in dashboard container don't import types from ui/*

* chore: 🤖 fix linter errors

* refactor: 💡 remove getUserData, remove another ui/new_platform

* chore: 🤖 fix linter errors

* refactor: 💡 remove ui/new_platform from HelloWorldAction

* refactor: 💡 remove ui/new_platform from SendMessageAction

* refactor: 💡 remove ui/new_platform from ContactCardEmbeddableF*

* chore: 🤖 fix ESLint errors

* feat: 🎸 throw if action or trigger with given ID already exists

* feat: 🎸 throw if embeddable factory already registered

* docs: ✏️ fix tsdoc

* chore: 🤖 remove unused @ts-ignore

* refactor: 💡 remove createEmbeddables() function

* refactor: 💡 use new NP inspector plugin

* fix: 🐛 fix TypeScript errors

* chore: 🤖 improve plugin manifests

* feat: 🎸 cherry pick exported API from Embeddable plugin

* refactor: 💡 do not import constants from Kibana App

* fix: 🐛 remove unnecessary any

* chore: 🤖 uncomment SASS files

* refactor: 💡 remove IndexPattern logic out of dashboard panel

* refactor: 💡 move RefreshInterval and TimeRange to New Platform

* fix: 🐛 revert back notifications usage

* chore: 🤖 export test samples from index.ts files

* test: 💍 re-enable ApplyFilterAction integration tests

* chore: 🤖 remove unused translation

* refactor: 💡 rename variable to something less React specific

* fix: 🐛 improve CSS imports, remove unused hack, remove any type

* fix: 🐛 fix Embeddables demo plugin

* fix: 🐛 fix missing SASS variable

* fix: 🐛 re-enable translation

* fix: 🐛 uncomment saved object flyout panel logic

* refactor: 💡 pass in <SavedObjectFinder> from top level

* test: 💍 re-enable add_panel_flyout tests

* refactor: 💡 pass in <ExitFullScreenButton> through args

* fix: 🐛 import specific constants to fix functional tests

* fix: 🐛 fix CI type_check error

* test: 💍 change import paths to fix functional tests on CI

* test: 💍 fix exit button test after refactoring

* refactor: 💡 make do not change page on grid error

* test: 💍 fix functional test

* refactor: 💡 move CSS next to components

* fix: 🐛 remove missing props

* test: 💍 try fixing functional test on CI

These tests pass locally, but fail on CI. This is a stab to fix it on
CI.

* refactor: 💡 move variables.scss one folder up

* test: 💍 disable Embeddable Explorer functional tests

* chore: 🤖 remove onCoreReady in functional tests

* test: 💍 disable maps functional test for embeddables

* chore: 🤖 remove comment, export types explicitly

* refactor: 💡 remove unused `firstName`, add link to issue

* refactor: 💡 remove double underscore __ in test registry names

* refactor: 💡 remove utils folder, move bootstrap() fn to top lvl

* test: 💍 uncomment edit_panel_action tests

* test: 💍 uncomment inspect_panel_action tests
2019-08-12 13:46:06 +02:00
Dmitry Lemeshko
50f9e2b7f1
run chained_controls on Firefox to catch regression (#43044) (#43057) 2019-08-09 23:27:02 +02:00
Dmitry Lemeshko
ffb539bdce
[apps/dashboard] skip part of filtering tests on FF (#43047) (#43052) 2019-08-09 22:47:35 +02:00
Tim Roes
5f7b5940ef
fixes scaling logic to check agg type instead schema (#42574) (#42950)
* fixes scaling logic to check agg type instead schema

* adding selenium test

* updating jest snapshot

* fixing test

* Change test order

* Fix test order
2019-08-09 09:41:28 +02:00
Dmitry Lemeshko
feb070df6a
bump chromedriver version to 76 (#42468) (#42874)
* bump chromedriver version to 76

* [test/interpreter_functional] update snapshots

* [test/interpreter_functional] skip failing tests

* Revert "[test/interpreter_functional] update snapshots"

This reverts commit 6401554882.

* [test/interpreter_functional] skip snapshot tests
2019-08-08 07:40:37 +02:00
Josh Dover
6e6c01815d Add ContextService to server (#42395) (#42750) 2019-08-06 21:07:52 +02:00
Matt Bargar
f2d96dfa2e
Allow sorting on multiple columns in Discover (#41918) (#42551)
This commit enables sorting on multiple columns in Discover and in saved search panels on dashboards. The UI is simple and should be familiar based on the way multi-sort works in other common applications like file explorers. Each sortable column has a sort icon indicating which way it is sorted (or unsorted, in the case of two arrows pointing both up and down). Sort priority is determined by which column was clicked most recently, with the most recent being the lowest priority.
2019-08-05 19:30:44 -04:00
Nicolas Chaulet
badf663aa9
[Tests] Setup contract tests in x-pack (#42345) (#42613) 2019-08-05 13:28:03 -04:00
Spencer
ffe8d77302
[7.x] [x-pack/ftr] refactor types to be more accurate/consiste… (#42552) 2019-08-05 08:45:34 -07:00
Chandler Prall
4295fe2d3c
Upgraded EUI 13.0.0 -> 13.1.1 (#42298) (#42604)
* Upgraded EUI 13.0.0 -> 13.1.0

* Bump to 13.1.1

* Reset MutationObserver polyfill to original operation

* Reset x-pack's MutationObserver polyfill to original operation
2019-08-05 09:26:43 -06:00
Spencer
91b40d2559
[7.x] [ftr/cheerio] improve cheerio types to include test subj… (#42541) 2019-08-02 15:50:17 -07:00
dave.snider@gmail.com
27f1696f4e
EUI 13.0.0 (#41723) (#42540) 2019-08-02 13:45:20 -07:00
Vadim Dalecky
9cefd7e9ce
[7.x] Inspector 👉 New Platform (#42164) (#42530)
* refactor: 💡 remove SASS and clean up InspectorView component

* refactor: 💡 clean up inspector, convert .js -> .ts

* feat: 🎸 add Inspector NP plugin boilerplate

* feat: 🎸 move view registry to NP, move types, add registerView

* docs: ✏️ move inspector README to NP plugin

* refactor: 💡 move ui/inspector/ui to NP

* refactor: 💡 move Inspector adapters to NP

* refactor: 💡 move Inspector.isAvailable to New Platform

* refactor: 💡 move Inspector.open to New Platform plugin

* test: 💍 move Inspector tests to NP plugin

* chore: 🤖 fix imports

* feat: 🎸 update translations

* test: 💍 fix failing translation snapshot

* test: 💍 fix yarn test:browser tests

* Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts

Co-Authored-By: Stacey Gammon <gammon@elastic.co>

* [ML] [Job wizards] switching to new kibana context provider

* fix: 🐛 specify translation path directly to the plugin

* docs: ✏️ add comment about Webpack config fix

* Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts

Co-Authored-By: Stacey Gammon <gammon@elastic.co>

* Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts

Co-Authored-By: Stacey Gammon <gammon@elastic.co>

* feat: 🎸 improve types as per review

* fix: 🐛 remove <InspectorView> comp and fix view layouts

* test: 💍 improve mocks
2019-08-02 18:36:18 +02:00
Brandon Kobel
4c51584cf9
Saved Objects export API stable type order (#42310) (#42313)
* Sorting export's valid types

* Updating the saved object api integration export test

* Fixing OSS also
2019-07-31 06:39:08 -07:00
Dmitry Lemeshko
0e315ab053
FTR: fix testSubjects.missingOrFail (#42290) (#42321)
* [services/test_subject] fix missingOrFail

* [services/test_subjects] allowHidden option for missingOrFail

* [page_objects/dashboard_page] wait for euiTable loaded, increase timeout for loading page check
2019-07-31 11:16:51 +02:00
Vitali Haradkou
5e0dae4c3c
[TSVB] [Functional] unskip flaky test (#41766) (#42137)
* unskip flaky test
2019-07-29 16:53:37 +03:00
Maryia Lapata
1fb0b65c7f
[Vis Editor] EUIfication of agg and agg-group directives (#40866) (#42126)
* Create default_editor_agg.tsx

* Create default_editor_agg_group

* Apply drag and drop

* Remove unused dragula dependency

* Remove old mocha tests

* Add ts for state

* Update functional tests

* Update touched condition

* Apply styles for accordion button content

* Apply truncate for agg description

* Remove unused styles

* Separate common props

* Move aggGroupNamesMap to agg_group.js

* Update _sidebar.scss

* Pass schemas prop

* Prevent scroll bar and add space

* Remove unused min from stats

* Add OnAggParamsChange type

* Show error as an icon

* Update background color

* Update title size

* Remove Schema.deprecate since it's not used
2019-07-29 16:46:55 +03:00
Tim Roes
92d1e5f5df
GoodBye Notifier (#41663) (#42122)
* Begin notifier removal

* Remove remaining notifier traces

* Remove dead translations

* Remove Angular from config listener

* Import angular-sanitize explicitly in map
2019-07-29 14:32:36 +02:00
Daniil Suleiman
73ab20ed80
[Vis: Default editor] EUIficate pie chart options tab (#41901) (#42125)
* EUIficate pie chart options tab

* Fix tests

* Size titles down to xs

* Use FormattedMessage
2019-07-29 14:56:39 +03:00
Dmitry Lemeshko
b5a389ac1f
Functional tests: make sure clicked dashboard is opened (#42006) (#42058)
* [page_objects/dashboard_page] make sure selected dashboard is opened
2019-07-26 16:20:58 +02:00
Dmitry Lemeshko
2b4d037c06
Ftr/tsfy doc table (#41710) (#41952)
* [services/doc_table] tsfy service and use parse dom to get rows

* [services/doc_table] do not pass table element as argument

* [services/doc_table] update service to minimize StaleElementReference cases

* [services/doc_table] add missing access modifier

* [services/doc_table] change getHeaderFields and fix return types
2019-07-25 09:51:33 +02:00
Dmitry Lemeshko
b237a661a4
[service/remote] check env variable value (#41909) (#41950) 2019-07-25 09:29:29 +02:00
Daniil Suleiman
1172d5039b
[Vis: Default editor] Create vis_options_react_wrapper (#41746) (#41890)
* Add vis_options_react_wrapper

* Update jest tests

* Fix plugin functional test
2019-07-24 17:33:16 +03:00
Luke Elmers
40c8f1bbc2
Ensure visualizations in percentage mode respect the advanced settings percent format (#39044) (#41855) 2019-07-24 08:19:56 -06:00