Commit graph

6059 commits

Author SHA1 Message Date
Catherine Liu
88894e11d9
[Canvas] Fixes bring to front shortcut label (#67374) (#67565)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-28 10:41:44 -07:00
Corey Robertson
34b56ca7e6
[Canvas] Force embeddables to refresh when renderable reevaluated (#67419)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-27 08:54:46 -04:00
Catherine Liu
626f2e2710
[Canvas] Fix flaky custom element functional tests (#65908) (#67195)
* Enable clearWithKeyboard option when filling out custom elements form

* Added canvas functional tests path to CODEOWNERS

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-21 18:23:59 -07:00
spalger
dbbd39c512 skip flaky suite (#62927)
(cherry picked from commit bc3f382883)
2020-04-22 13:33:39 -07:00
Brian Seeders
e195697e47
Skip failing canvas custom elements test 2020-04-21 11:21:38 -04:00
patrykkopycinski
1e52d53f67
[SIEM] Fix AlertsTable id (#63368) (#63385) 2020-04-13 21:23:48 +02:00
Tyler Smalley
0150b0d347 bump version to 7.6.3 2020-03-31 09:27:45 -07:00
James Gowdy
6676f06698
[7.6] [ML] Disabling datafeed editing when job is running (#60751) (#60939)
* [ML] Disabling datafeed editing when job is running (#60751)

* [ML] Disabling datafeed editing when job is running

* changing variable

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* moving help text

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 22:09:10 +00:00
Jean-Louis Leysens
bc82d6d0b1
[7.6] Fix ace a11y listener (#60639) (#60726)
* Fix ace a11y listener (#60639)

Also move the hook use_ui_ace_keyboard_mode.tsx into es_ui_shared

This was defined (and used) in both Console and SearchProfiler.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/legacy/core_plugins/console/public/np_ready/application/containers/editor/legacy/use_ui_ace_keyboard_mode.tsx
#	src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx
#	src/plugins/console/public/application/containers/editor/legacy/use_ui_ace_keyboard_mode.tsx
#	src/plugins/es_ui_shared/public/index.ts
#	src/plugins/es_ui_shared/public/use_ui_ace_keyboard_mode.tsx
#	x-pack/legacy/plugins/searchprofiler/public/np_ready/application/editor/use_ui_ace_keyboard_mode.tsx
#	x-pack/plugins/searchprofiler/public/application/editor/editor.tsx

* Remove unused translations
2020-03-22 00:57:19 +01:00
CJ Cenizal
afae0da83a
[IM] Use EuiCodeBlock to render index mapping (#60420) (#60460)
Co-authored-by: Alison Goryachev <alison.goryachev@elastic.co>
2020-03-17 18:04:56 -07:00
Jean-Louis Leysens
d06af4d93c
[Searchprofiler] Spacing between rendered shards (#60238) (#60259)
* Added unique key and some spacing to rendered shards

* Give key to React.Fragment
2020-03-16 16:16:37 +01:00
CJ Cenizal
1cf7368761
Handle improperly defined Watcher Logging Action text parameter. (#60169) (#60188) 2020-03-13 20:20:48 -07:00
Nathan Reese
f0fdebdcb0
[7.6] [Maps] Fix custom color ramp on save (#59953) (#59974)
* merge with master

* fix jest test for 7.6
2020-03-12 07:50:45 -06:00
Robert Oskamp
b5d4ca6ae4
[ML] Functional API tests - bucket span estimation with custom search.max_buckets (#59665) (#59772)
This PR adds functional API tests for the bucket span estimation endpoint with a transient or persistent `search.max_buckets` setting.
2020-03-10 18:11:06 +01:00
James Gowdy
918cdd47ce
[7.6] [ML] Fixes bucket span estimators loading of max_buckets setting (#59639) (#59662)
* [ML] Fixes bucket span estimators loading of max_buckets setting (#59639)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* fixing test

* reverting test fix

* disabling test

* disabling tests for error text

* removing tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-10 15:23:26 +00:00
Brian Seeders
78508b856d
Ensure logged out starting state for tests that need it (#59322) (#59573) 2020-03-10 10:45:20 -04:00
Brian Seeders
c8a5b63556
Check for alert dialog when doing a force logout (#59329) (#59594)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-10 10:44:54 -04:00
Spencer
d9ade949f0
ensure fs deletes are not cwd dependent (#59570) (#59584)
Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-03-07 13:40:15 -07:00
Dima Arnautov
061dc37fbf
[ML] Show view series link in anomalies table for machine_learning_user role (#59549) (#59559) 2020-03-06 20:44:23 +01:00
Andrew Goldstein
7f75006b98
[SIEM] Fixes dragging entries to the Timeline while data is loading may trigger a partial page reload (#59476) (#59523)
The `react-beautiful-dnd` library, upgraded during the `7.6` stack release from
`10.0.1` to `12.2.0`, includes a breaking change to the way [errors are handled](https://github.com/atlassian/react-beautiful-dnd/blob/v12.0.0/docs/guides/setup-problem-detection-and-error-recovery.md)
and recovered. As a result of this change, an uncaught error may trigger a
an effect that feels (from the perspective of a user) like a partial page
reload.

The most common condition where this can occur is when dragging entries to the
Timeline while data is loading, per the animated gif below:

![refresh-error](https://user-images.githubusercontent.com/4459398/76016029-59755f80-5ed9-11ea-858d-cb1189d22ea9.gif)

## Reproduction steps

1. Navigate to the Hosts page
2. Open the Timeline
3. Drag a host to the Timeline
4. While data is still loading, drag a different host to the Timeline to create an `or` query

**Expected Result**
* The page does not appear to reload
* In development mode, a single error is logged to the JS console

**Actual Resluts**
* The page appears to reload
* In development mode, two errors are logged to the JS console

**Error 1**
```
react-beautiful-dnd
Invariant failed: Cannot find droppable entry with id [droppableId.content.event-details-value-default-draggable-plain-column-renderer-formatted-field-value-timeline-1-kLGooXABOOUskGlPiQw5-@timestamp-1583260131000]👷<200d> This is a development only message. It will be removed in production builds.
    in Draggable (created by ConnectFunction)
    in ConnectFunction (created by PrivateDraggable)
    in PrivateDraggable (created by PublicDraggable)
    in PublicDraggable (created by Droppable)
    in Droppable (created by ConnectFunction)
    in ConnectFunction
```

**Error 2**
```
react-beautiful-dnd
Invariant failed: Cannot find droppable entry with id [droppableId.content.event-details-value-default-draggable-plain-column-renderer-formatted-field-value-timeline-1-kLGooXABOOUskGlPiQw5-@timestamp-1583260131000]👷<200d> This is a development only message. It will be removed in production builds.
    in ErrorBoundary (created by DragDropContext)
    in DragDropContext (created by Anonymous)
    in Anonymous
```

### Desk testing

Tested locally in:
* Chrome `80.0.3987.122`
* Firefox `73.0.1`
* Safari `13.0.5`

Fixes https://github.com/elastic/kibana/issues/59466
2020-03-06 01:01:47 -07:00
Spencer
692e2a5693
[7.6] Fix visual baseline job (#59348) (#59471)
* Establish Percy baselines

* move Jenkinsfile changed back to `.ci` directory

* rename xpack workers

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-05 18:13:04 -07:00
igoristic
542a0d62f4
Resolved conflicts (#59467) 2020-03-05 16:39:01 -05:00
patrykkopycinski
47094cdd00
[SIEM] Fix rule delete/duplicate actions (#59306) (#59369) 2020-03-05 22:01:18 +01:00
Aaron Caldwell
a967cbc86c
[7.6] [Maps] Add missing license to requests in maps embeddables (#59207) (#59336)
* [Maps] Add missing license to requests in maps embeddables (#59207)

* Pull core service init out into separate function

* Call bind function from embeddable factory constructor

* Move inspector init back to start method. Remove old license check file

* Add TS types

* Fix remaining merge issues
2020-03-04 15:26:59 -07:00
Chris Roberson
4f672d5d4f
[Monitoring] Ensure we use the monitoring cluster for retrieving xpack info (#59075) (#59309)
* Ensure we use the monitoring cluster for retrieving xpack info

* Remove unnecessary code
2020-03-04 11:13:28 -05:00
spalger
3dc29793d5 bump version to 7.6.2 2020-03-04 08:44:40 -07:00
Yara Tercero
76480dadc0
[SIEM][Detections Engine] Fixed minor UI bug on all rules table pagination (#59094) (#59206)
* Fixed minor UI bug on all rules table pagination
2020-03-03 15:48:46 -05:00
Andrew Goldstein
e29a53f5ba
[7.6] [SIEM] Default the Timeline events filter to show All events (#58953) (#59059)
* [SIEM] Default the Timeline events filter to show All events (#58953)

## [SIEM] Default the Timeline events filter to show All events

The Timeline events filter introduced in `7.6` to support the [detection engine](https://www.elastic.co/guide/en/siem/guide/current/detection-engine-overview.html) defaulted to filtering by `Raw events`, and thus required manually selecting `All events` or `Signal events` from the dropdown to view signals.

The new default is `All events`, per the screenshots below:

### Before
![event-filter-before](https://user-images.githubusercontent.com/4459398/75593223-ecc61500-5a41-11ea-8d7d-8db5eccb1eb4.png)

### After
![event-filter-after](https://user-images.githubusercontent.com/4459398/75593238-f5b6e680-5a41-11ea-9e12-2fc1232f58d1.png)

* * Added `eventType`, which is a required prop in `7.6.x` to pass the type check, along with this note:

```
CAUTION: `eventType` is an optional prop in post-`7.6.x` branches. In later branches, `eventType`
is omitted from this test, to truly verify the new default from redux. In this branch, we must
specify `eventType` to pass the type check, but this is not the true intent of this test.
```
2020-03-03 13:41:54 -07:00
Chris Cowan
c7f840b1c8
[7.6] [Metrics UI] Ensure inventory view buckets never drop below 60 seconds (#58503) (#58912)
* [Metrics UI] Ensure inventory view buckets never drop below 60 seconds (#58503)

* [Metrics UI] Ensure inventory view buckets never drop below 60 seconds

* Fixing tests

* Fixing tests... again

* Fixing tests... rounding issue?

* Trying to fix the tests... again

* updating test for custom metric

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Fixing tests due to rounding issue

* Removing test that shouldn't have been backported.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-02 14:17:44 -07:00
Chris Cowan
bf89b9dc2e
[Metrics UI] Use CPU Usage limits for Kubernetes pods when available (#58424) (#58907)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-02 09:19:46 -07:00
Frank Hassanabad
1cf8078496
[SIEM] Detection Fix typo in Adobe Hijack Persistence rule (#58804) (#58993)
Fixes https://github.com/elastic/kibana/issues/58803

Co-authored-by: Nic <nicpenning@hotmail.com>
2020-03-02 08:17:21 -07:00
Ahmad Bamieh
2d9187fced
[i18n] latest translation (#59012)
* 7.6 translations

* latest translations
2020-03-02 15:11:22 +02:00
Lisa Cawley
b14a700162
[DOCS] Fixes outdated monitoring links (#58556) (#58739) 2020-02-28 12:24:39 -08:00
Søren Louv-Jansen
50f15a2357
[APM] Fix timeout in APM setup (#58727) (#58782)
* [APM] Fix timeout in APM setup

* Update plugin.ts

# Conflicts:
#	x-pack/plugins/apm/server/lib/index_pattern/get_dynamic_index_pattern.ts
#	x-pack/plugins/apm/server/lib/settings/agent_configuration/create_agent_config_index.ts
#	x-pack/plugins/apm/server/plugin.ts
2020-02-27 16:10:57 -08:00
John Dorlus
bc41f88f6c
Fix Snapshots Policies Alignment Issue in IE11 (#54866) (#58065)
* Removed flex group because it's causing alignment issues on IE. Verified and tested on all 3 browsers.

* Restored <EuiFlexItem> but added grow=false to properly align icons.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-26 20:44:13 -05:00
Chris Cowan
e873e7d91c
[Metrics UI / Logs UI] Remove field filtering in Source API call (#58553) (#58616)
* [Metrics UI / Logs UI] Remove field filtering in Source API call.

* Fixing type_check issues
2020-02-26 15:48:37 -07:00
Xavier Mouligneau
109cb27599
[SIEM] [Detections] Refactor the all rules page (#58428) (#58571)
* Refactor the all rules page to be easier to test

* review with Garrett

* bring back utility bar under condition

* fix bugs tags and allow switch to show loading when enable/disable rule

* fix rules selection when trigerring new rules

* fix imports/exports can only use rule_id as learned today

* review I
2020-02-26 11:28:39 -05:00
Felix Stürmer
4bb6c08e26
[Logs + Metrics UI] Fix incomplete config schema and async usa… (#58576)
This fixes the configuration file schema of the infra plugin in the new platform shim.
2020-02-26 12:47:18 +01:00
Ryland Herrick
a3ca2d200e
Remove support of HEAD request in signals index route (#58489) (#58540)
Until these are officially supported in new platform, it's best to not
rely on this behavior. We can achieve roughly the same functionality
with a GET request. Modifies the existing script accordingly, in case
anyone's still using it.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-25 21:30:37 -06:00
Devin W. Hurley
4e61c134a6
small bug fixes that are already in master but that PR had too many conflicts to resolve so just adding bug fixes here (#58544) 2020-02-25 21:41:53 -05:00
Dario Gieselaar
a0f212d441
[7.6] [APM] Add xpack.apm.enabled key to config schema (#575… (#57680)
Closes #57418.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-25 21:30:08 +01:00
Søren Louv-Jansen
b36a553b1c
[APM] Avoid accessing a non-existing index when bucket is empty (#58481)
* [APM] Avoid accessing a non-existing index when bucket is empty

* Avoid invalid index access in get_service_node_metadata
2020-02-25 17:20:37 +01:00
Joe Reuter
f68147aada
hide welcome screen for cloud (#58371) (#58449) 2020-02-25 14:44:43 +01:00
Xavier Mouligneau
5d333d5de0
[7.6] [SIEM] Detections container/rules unit tests (#58055) (#58138)
* [SIEM] Detections container/rules unit tests (#58055)

* add unit test for rules api

* add unit test for useFetchIndexPatterns

* fix useFetchIndexPatterns and add unit test for usePersistRule

* add more unit test for container/rules

* review

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* fix types + adapt test to the old fetch way

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-24 17:53:17 -07:00
Andrew Cholakian
c11e866811
[Uptime] Use scripted metric for snapshot calculation (#58247)
Fixes #58079

This is an improved version of #58078

Note, this is a bugfix targeting 7.6.1 . I've decided to open this PR directly against 7.6 in the interest of time. We can forward-port this to 7.x / master later.

This patch improves the handling of timespans with snapshot counts. This feature originally worked, but suffered a regression when we increased the default timespan in the query context to 5m. This means that without this patch the counts you get are the maximum total number of monitors that were down over the past 5m, which is not really that useful.

We now use a scripted metric to always count precisely the number of up/down monitors. On my box this could process 400k summary docs in ~600ms. This should scale as shards are added.

I attempted to keep memory usage relatively slow by using simple maps of strings.
2020-02-24 11:45:23 -06:00
Sébastien Loix
189909a195
[Mappings editor] Allow support for nested multi-fields (#58203) (#58328) 2020-02-24 14:50:24 +01:00
Aaron Caldwell
df4f90633e
Make sure index pattern has fields before parsing (#58242) (#58267) 2020-02-21 14:40:45 -07:00
Corey Robertson
5ccc0b62c4
Sanitize workpad before sending to API (#57704) (#58241)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-21 15:51:34 -05:00
Brandon Kobel
952589d7f0
Updating to @elastic/lodash@3.10.1-kibana4 (#54662) (#58232)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-21 09:39:42 -08:00
Frank Hassanabad
5646412c53
[SIEM][Detection Engine] Fixes return codes where some were rule_id instead of id (#58192)
## Summary

Fixes some return error codes where they were `rule_id` when they should have been `id`

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-02-20 18:03:05 -07:00