Commit graph

3499 commits

Author SHA1 Message Date
Matthias Wilhelm
cd53b3e5c4
[Discover] Unskip context navigation test (#68490) (#68985) 2020-06-12 14:57:26 +02:00
Matthias Wilhelm
5d86c714b4
[Discover] Unskip context size tests (#68213) (#68369) 2020-06-05 17:44:52 +02:00
Matthias Wilhelm
3610e9ea4c
[Discover] Fix missing histogram time range update when query is refreshed (#67582) (#68102) 2020-06-04 11:11:45 +02:00
Matthias Wilhelm
ae69f51446
[7.7] Improve indexpattern without timefield functional test (#67031) (#67267) 2020-06-04 10:59:02 +02:00
Joe Reuter
54419a2ca4
[7.7] move role reset into the top level after clause (#66971) (#68054) 2020-06-03 16:30:15 +02:00
Brian Seeders
de65f199ad
[CI] Remove --detectOpenHandles to parallelize Jest tests again (#67413) (#67517) 2020-05-27 14:42:27 -04:00
restrry
846ff4ace1 update styles 2020-05-22 11:46:32 +02:00
Daniil Suleiman
7a7c9f97c4
[Visualize] Bar chart: Show missing values on chart setting (#66375) (#67025)
* Show missing switch button

* Add functional tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/vis_type_vislib/public/components/options/point_series/point_series.tsx
#	test/functional/page_objects/visualize_chart_page.ts
#	test/functional/page_objects/visualize_editor_page.ts
2020-05-19 21:43:19 +03:00
Pierre Gayvallet
3cb39b3f42
[SOM] Preserve saved object references when saving the object (#66584) (#66845)
* create field for references and add comments

* add FTR test

* remove comments

* address comments

* use real reference in dataset and assert against it.
# Conflicts:
#	src/plugins/saved_objects_management/public/lib/create_field_list.test.ts
#	src/plugins/saved_objects_management/public/lib/create_field_list.ts
#	src/plugins/saved_objects_management/public/management_section/object_view/components/field.tsx
#	src/plugins/saved_objects_management/public/management_section/object_view/components/form.tsx
2020-05-17 08:01:57 +02:00
Dmitry Lemeshko
8ceed24821
[services/remote] set download folder with auto-saving (#65476) (#65564)
* [services/remote] set download folder with auto-saving

* Update test/functional/services/remote/webdriver.ts

* use REPO_ROOT per review suggestion
2020-05-07 00:30:14 +03:00
Dmitry Lemeshko
11e950f12e
[FTR]: add chromium-based Edge browser support (#63566) (#63734) 2020-04-16 22:27:43 +03:00
Anton Dosov
e8fcb4920e
Bugfix clear saved query crashes kibana on Discover in some cases (#63554) (#63628)
* actual hotfix
* add functional test
2020-04-15 15:11:41 -05:00
Matthias Wilhelm
103ef928bd
[Discover] Fix broken setting of bucketInterval (#62939) (#63547)
* Fix broken setting of bucketInterval, remove $watch

* Fix and adapt functional tests
2020-04-15 13:03:18 +02:00
Dmitry Lemeshko
f081cedf2c
[7.7] Revert FTR: add chromium-based Edge browser support (#61684) (#63063) (#63485)
* Revert "FTR: add chromium-based Edge browser support (#61684) (#63068)"

This reverts commit e8caa06f19.

* update lock file
2020-04-15 10:21:50 +03:00
Anton Dosov
9b0f80b1ac
Bugfix dashboard unpins filters (#62301) (#63322)
Fixes following cases:

Saving dashboard with pinned filter unpins it. Do not save pinned filters with dashboard see #62301 (comment)
When navigating with global filter to dashboard with same saved filter, filter becomes unpinned
When navigating from listing to dashboard with saved filter, back button didn't work

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-12 20:00:30 +02:00
Matthias Wilhelm
211d28aa3e
[Discover] Hide time picker when an indexpattern without timefield is selected (#62134) (#63107)
* Assign valid value whether the timepicker should be displayed

* Add functional tests
2020-04-09 17:27:28 +02:00
Daniil Suleiman
f699bd1e75
Wrap with retry (#63101) 2020-04-09 16:59:48 +03:00
Dmitry Lemeshko
e8caa06f19
FTR: add chromium-based Edge browser support (#61684) (#63068)
* bump dependency, add edge support in ftr services

* add config files

* fix browser version for msedge

* use npm ms-chromium-edge-driver

* download edge driver aside from session creation

* move dependency to dev

* update dist/index file

* bump edge-driver version

* change type to msedge to match w3c spec

* fix discover tests for Edge

* Revert "fix discover tests for Edge"

This reverts commit 87e7fdd256.

* bump driver version up

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-09 12:34:29 +03:00
Daniil Suleiman
cee064b5e4
Fix flaky FT in field visualize for 7.7 (#62823) 2020-04-09 00:07:15 +03:00
Dmitry Lemeshko
12f91e37d6
FTR: Enable w3c for chromedriver (#62542) (#62808)
* enable w3c for chrome

* update maps tests

* update maps tests

* update common_page

* Revert "update maps tests"

This reverts commit 31f43fd678.

* revert changes to maps tests

* undo after removal

* update expect range to pass on Windows, unskip tests for Firefox

* print out value for discover brushing test

* log first timestamp

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-07 20:10:29 +03:00
liza-mae
ac2d1a6560
Fix visual tests (#62660) (#62719) 2020-04-06 18:53:04 -06:00
Joe Reuter
c1e5e220a4
Vislib: Fix position calculation of ticks in non-horizontal axes (#62309) (#62605) 2020-04-06 16:58:29 +02:00
Liza Katz
b8a1c15e40
[BUG] Back navigation from surrounding documents doesn't work properly (#62350) (#62568)
* replace state for load more documents

* simpler solution

* simpler solution + functional test

* fix test

* disable flaky test
2020-04-06 13:40:50 +03:00
Anton Dosov
233e309343
[Drilldowns] Dashboard state fixes for drilldowns (#61457) (#62421)
1. Change logic around deciding wether to use time from url or from saved object. Previously code looked only into if _g is present in the url at all. And didn't consider edge case if time or refreshInterval is missing in _g

2. Fix initial syncing of time from savedobject causing redundant history record. _This changed caused order of _a and g params in url change. One test was affected by it because it relied on the order. I don't think it should be considered breaking as order app puts it's query params shouldn't matter.

3. Fix another race condition between state syncing with url and angular controller $destroy. Similar fix was done before in #57795, but this on covers case when we stay within dashboard app, but change dashboard

4. Fix initial panel state migration causing redundant browser history records

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 14:52:16 +02:00
Joe Reuter
a651b23d61
Make d3 place nicely with object values (#62004) (#62340) 2020-04-03 11:08:31 +02:00
Spencer
5262e34b7c
[7.7] [ci/es] always pull snapshots, break early when they're… (#62067)
* [ci/es] always pull snapshots, break early when they're not available

* move to setup.sh after deps are installed

Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-31 17:52:00 -07:00
Daniil Suleiman
e9855afdea
[Discover] Fix filters passing down to visualize (#61392) (#61574)
* Fix passing filters to visualize

* Add functional tests
2020-03-27 13:05:54 +03:00
Matthias Wilhelm
1381864f8d
[Discover] Fix ignoring uiSetting discover:searchOnPageLoad (#61393) (#61570)
* Add checks for changed query and update in $scope.updateQuery

* Add functional test by counting fetches
2020-03-27 10:31:16 +01:00
Daniil Suleiman
7f3e5e6afa
[Discover][Visualize] Fix visualizing a selected field in discover search (#61226) (#61407)
* Fix visualize a discover search

* Move deep clone into vis.ts

* Add functional tests

* Fix passing filters to visualize

* Revert fixing filters
2020-03-26 13:23:41 +03:00
Tyler Smalley
620b088f57 Temporarily disable tests caused by possible ES regression
https://github.com/elastic/kibana/issues/61366

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-03-25 15:38:01 -07:00
Lee Drengenberg
46ac1e6630
streamline indexPatternTitle usage (#60999) (#61158)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-24 22:51:46 +00:00
Lee Drengenberg
5a26a1b804
add relationship test on Saved Objects (#59968) (#60976)
* just a demo of function to return saved object table elements

* fix esArchive data, extend import objects test case for relationships

* improved data-test-subjs

* update snapshot for jest test

* unskip other half of the tests

* removed commented-out code

* use new findByTestSubject methods

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-24 09:07:28 -05:00
Devon Thomson
1faabde190
Dashboard/add panel flow (#59918) (#60995)
Added an emphasize prop to the top nav menu item and used it for a new 'Create new' button which redirects to the 'new visualization' modal.

Co-authored-by: Ryan Keairns <rkeairns@chef.io>

Co-authored-by: Ryan Keairns <rkeairns@chef.io>
2020-03-24 10:01:28 -04:00
Joe Reuter
7d32617fd9
Migrate doc view part of discover (#58094) (#61033) 2020-03-24 11:23:06 +01:00
Dmitry Lemeshko
4c7a447ffb
WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (#60568) (#60756)
* [web_element_wrapper] add find/findAll to search with data-test-subj

* fixes

* fix wrong function call

* review fixes

* simplify test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 18:09:55 -05:00
Alejandro Fernández Haro
be35050243
[Telemetry] Server-side Migration to NP (#60485) (#60965)
* [Telemetry] Migration to NP

* Telemetry management advanced settings section + fix import paths + dropped support for injectVars

* Fix i18nrc paths for telemetry

* Move ui_metric mappings to NP registerType

* Fixed minor test tweaks

* Add README docs (#60443)

* Add missing translation

* Update the telemetryService config only when authenticated

* start method is not a promise anymore

* Fix mocha tests

* No need to JSON.stringify the API responses

* Catch handleOldSettings as we used to do

* Deal with the forbidden use case in the optIn API

* No need to provide the plugin name in the logger.get(). It is automatically scoped + one missing CallCluster vs. APICaller type replacement

* Add empty start method in README.md to show differences with the other approach

* Telemetry collection with X-Pack README

* Docs update

* Allow monitoring collector to send its own ES client

* All collections should provide their own ES client

* PR feedback

* i18n NITs from kibana-platform feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 20:53:38 +00:00
Wylie Conlon
fbe3637e84
Fix formatter on range aggregation (#58651) (#60920)
* Fix formatter on range aggregation

* Fix test that was using unformatted byte ranges

* Fix test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 13:22:37 -04:00
Chandler Prall
fa0c700c92
[7.x] Upgrade EUI to 21.0.1 (#60282) (#60809)
* Upgrade EUI to 21.0.1 (#60282)

* update to eui 21.0.1

* most changes needed for search bar ts changes

* Passing types

* snapshots

* jest tests

* Removed IQuery placeholder types

* Updated functional test to only look at table headers with content

* Moved 'filters' definition around in api docs

* Update types

* update snapshot

* typo

* Move DATA_FRAME_TASK_STATE enum to its own file to fix x-pack functional test config imports

* merge public api 'changes'

Co-authored-by: patrykkopycinski <patryk.kopycinski@elastic.co>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>

* unit test update

Co-authored-by: patrykkopycinski <patryk.kopycinski@elastic.co>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
2020-03-20 23:09:36 -06:00
Marco Vettorello
c96faa6bea
Update dependency @elastic/charts to v18.1.0 (#60578) (#60775) 2020-03-20 22:58:01 +01:00
Pierre Gayvallet
6bfb623b33
[7.x] migrate saved objects management edition view to react/typescript/eui (#59490) (#60621)
* migrate saved objects management edition view to react/typescript/eui (#59490)

* migrate so management edition view to react

* fix bundle name + add forgotten data-test-subj

* add FTR tests for edition page

* EUIfy react components

* wrap form with EuiPanel + caps btns labels

* Wrapping whole view in page content panel and removing legacy classes

* improve delete confirmation modal

* update translations

* improve delete popin

* add unit test on view components

* remove kui classes & address comments

* extract createFieldList and add tests

* disable form submit during submition

Co-authored-by: cchaos <caroline.horn@elastic.co>

* update dataset and fix test description

Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-03-20 07:16:44 +01:00
Gidi Meir Morris
08384027cb
[Alerting] Adds navigation by consumer and alert type to alerting (#58997) (#60605)
Adds Navigation APIs to Alerting.

Parts to this PR:

Adds a client side (Public) plugin to Alerting, including two APIs: registerNavigation & registerDefaultNavigation. These allow a plugin to register navigation handlers for any alerts which it is the consumer of- one for specific AlertTypes and one for a default handler for all AlertTypes created by the plugin.
The Alert Details page now uses these navigation handlers for the View In App button. If there's an AlertType specific handler it uses that, otherwise it uses a default one and if the consumer has not registered a handler - it remains disabled.
A generic Alerting Example plugin that demonstrates usage of these APIs including two AlertTypes - one that always fires, and another that checks how many people are in Outer Space and allows you to trigger based on that. 😉 To enable the plugin run yarn start --ssl --run-examples
2020-03-19 13:05:44 +00:00
Robert Oskamp
32edf74101
[ML] Add functional tests for file data visualizer (#60413) (#60600)
This PR adds basic functional tests for the file data visualizer, covering a file import and error messages for non-log files. It also moves the file input path handling to a common location in order to avoid code duplication.
2020-03-19 10:53:32 +01:00
Dave Snider
6768356e15
Branding fixes for dashboard, loader and space selector (#60073) (#60539) 2020-03-18 19:03:02 -07:00
Rashmi Kulkarni
d7bb13a311
[7.x] FTR configurable test users (#52431) (#60428)
* FTR configurable test users (#52431)

* initial implementation of configurable test users

* user superuser by default to match master

* referenced the configs in reporting and api integration

* setting the minimum number of default roles

* looking for x-pack tests with users and roles

* add testUserService in dashboard mode tests

* running only ciGroup7

* uncommenting - addign visualization

* re-enabling all CI groups to run on CI

* reinstating Jenkinsfile

* disable Test user for OIDC config

* improved logging and added Roles for OSS tests to get better info on the runs.

* disable test_user for auth tests

* don't fetch enabledPlugins when testuser disabled

* fix es-lint

* running oss tests with x-pack enabled

* [revertme] build default dist for oss tests

* updating NOTICE.txt file as it complained in the kibana intake tests

* changed to pick OSS builds

* trying a license change to trial

* switch back to xpack builds

* created a new sample data role and used it in homepage tests

* revert test/scripts/jenkins_ci_group.sh

* only refresh browser and wait for chrome if we are already on Kibana page

* fix large_string test to use minimum set of roles and privileges

* fix for date nanos custom timestamp with a configured role

* changes to the files with addition of new roles for the test_user

* reverting to OSS changes and few additions to the time_zone test to run as a test_user

* changes to security

* changes to the x-pack test to use elastic superuser

* fix for chart_types test

* fixes to area chart , input control test

* fix for dashboard filtering test and a new config role

* changes to handle the x-pack tests

* additional role for date nanos mixed

* added the logstash role to the accessibility tests

* removed telemetry setting

* docs+few changes to the tests

* removed Page navigation

* removed pageNavigation which was unused

* test/accessibility/apps/management.ts

* update management.ts

* aria label, and other changes

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* accidentally checked in a piped file with results.

* reverted

* unloading of logstash data, fixing aria label

* aria-label

* added the required role

* fix for tsvb chart

* fix for sample data test reverted home_page pageobject file

* changes to sample data test and visualize index file to incorporate OSS changes

* changes to describe() and some more changes to incorporate in settings_page

* re-adding the after()

* removed unwanted roles

* replaced kibana_user with kibana_admin

* added the check of deprecated kibana_user

* testing with kibana_admin  role

* fix for discover test

* incorporated the review comments

* incorporated the review comments

* incorporate review comments and added restoreDefaults()

* removed describe.only

* reverted the OSS logic change I had here- pulled into seperate PR

* incorporated the review comments

* incorporated review changes

* adding hidden=true to find hidden kibanaChrome

* change field.test.tsx to be same as that of master branch

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* removed the accidentally added file

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 18:21:48 -07:00
Larry Gregory
489d112f77
[7.x] Allow kbn-config-schema to ignore unknown keys (#59560) (#60407)
* allow kbn-config-schema to ignore unknown keys

* Consolidate unknown key configuration

* updates following merge

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-17 14:23:25 -04:00
Stacey Gammon
9975e5e2a3
Embeddable API cleanup (#60207) (#60305)
* wip

* Remove test in legacy functional plugin
2020-03-17 08:46:18 -04:00
Bhavya RM
2b93e74523
More a11y tests on index pattern page (#59575) (#60117)
more a11y tests on index pattern page!
2020-03-16 17:42:20 -04:00
Mikhail Shustov
80b58a589d
Add UiSettings validation & Kibana default route redirection (#59694) (#60257)
* add schema to ui settings params

* add validation for defaults and overrides

* validate in ui settings client

* ui settings routes validation

* clean up tests

* use schema for defaultRoutes

* move URL redirection to NP

* fix spaces test

* update docs

* update kbn pm

* fix karma test

* fix tests

* address comments

* get rid of getDEfaultRoute

* regen docs

* fix tests

* fix enter-spaces test

* validate on relative url format

* update i18n

* fix enter-spoace test

* move relative url validation to utils

* add CoreApp containing application logic

* extract public uiSettings params in a separate type

* make schema required

* update docs
2020-03-16 18:09:51 +01:00
Rashmi Kulkarni
776c9e6a34
OSS logic added to test environment (#60134) (#60178)
* OSS logic added

* reverting the logic of isOSS()

TileMap and RegionMap are on OSS but not on x-pack because it has Maps.
2020-03-13 23:04:01 -07:00
Stacey Gammon
942ac82c6a
remove CODEOWNERS (#60125) 2020-03-13 17:02:20 -04:00