* Ported options list to use Redux. added selection management and selection clear buttons to options list. Options list clears selections when field or index pattern change. Design cleanups and updates
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
* add chart creation context
* add chart creation tooltip, remove outer panel, and change default chart type for synthetics data
* adjust types
* remove extra translations
* add panel back
* update chart creation time date format
* update time format
* adjust tests
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This is a short-term solution to reduce our hit count in Buildkite due to the increase in bootstraps so we can move forward with enabling Buildkite across all PRs.
* Remove condition for index string mode when we reset field
* Fix lint
* Fix types
* Update field_select.tsx
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Upversion to EUI 39.1.0
* Update i18n_eui_mapping tokens
@see https://github.com/elastic/eui/blob/master/i18ntokens_changelog.json
* Merge refractor in yarn.lock
* Fix functional table filter selector
- Popover ID was removed in recent EUI a11y fix, so we're using child-position selection to target the Tags filter now
* Update snaphots
* Upgrade to 39.1.1 for extra bugfixes
* Update i18n mappings
* Fix i18n snapshot
* Attempt to harden flaky Security Cypress test
* More combobox entry hardening
- Got a flake on clicking the combobox dropdown on run 17/20 locally
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Update UI links to Fleet and Agent docs
* Update link service
* Fix merge problem
* Update link service
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* WIP replacing indexPattern.flattenHit by tabify
* Fix jest tests
* Read metaFields from index pattern
* Remove old test code
* remove unnecessary changes
* Remove flattenHitWrapper APIs
* Fix imports
* Fix missing metaFields
* Add all meta fields to allowlist
* Improve inline comments
* Move flattenHit test to new implementation
* Add deprecation comment to implementation
* WIP - Show ignored field values
* Disable filters in doc_table
* remove redundant comments
* No, it wasn't
* start warning message
* Enable ignored values in CSV reports
* Add help tooltip
* Better styling with warning plus collapsible button
* Disable filtering within table for ignored values
* Fix jest tests
* Fix types in tests
* Add more tests and documentation
* Remove comment
* Move dangerouslySetInnerHTML into helper method
* Extract document formatting into common utility
* Remove HTML source field formatter
* Move formatHit to Discover
* Change wording of ignored warning
* Add cache for formatted hits
* Remove dead type
* Fix row_formatter for objects
* Improve mobile layout
* Fix jest tests
* Fix typo
* Remove additional span again
* Change mock to revert test
* Improve tests
* More jest tests
* Fix typo
* Change wording
* Remove dead comment
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Upgraded the version of EUI to 38.2.0 from 38.0.1
* Updated the i18n mappings required for EUI v.38.2.0
* Update i18n snapshots and resolve linting error
* Removed html_id_generator mocks.
Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains an mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts
* Resolve linting error in i18n mapping file
* Removed html_id_generator mocks.
Current mock was failing due to missing useGeneratedHtmlId export. This is safe to remove because EUI contains a .testenv that contains a mock for html_id_generator. More info at https://github.com/elastic/eui/blob/master/src/services/accessibility/html_id_generator.testenv.ts
* Update plugin snapshots
* Resolve merge conflict in license_checker config.ts file
* Upgrade EUI to version 39.0.0 from the original target (38.2.0) to handle an issue found with a functional test during the original upgrade
* Updated the i18n mapping for EUI v.39.0.0
* Update various snapshots to account for the an i18n translation token addition in EUI v. 39.0.0
* Updated test cases marked as obsolete by CI
* Update src/dev/license_checker/config.ts
Removing TODO comments from src/dev/license_checker/config.ts as they are no longer needed.
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Add option auto fit row to content
* Fix tests
* Fix tests
* Add temp fix for correct rendering grid with auto-height when changing data or setting
* Fix lint
* Fix lint and tests
* Adds new dependency for temp fix
Co-authored-by: Brianna Hall <briannajdhall@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Bree Hall <40739624+breehall@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Replacing EuiPopover with EuiComboBox
* The combobox will help alleviate issues when the list of options is very long
* Refactoring the Combobox to listen for change events
* Added an onChange handler
* Renamed the method to render the combobox
* Commented out additional blocks of code before final refactor
* Finished refactoring the Request Selector to use EUI Combobox
* Removed three helper methods for the EUIPopover.
* `togglePopover()`
* `closePopover()`
* `renderRequestDropdownItem()`
* Removed the local state object and interface (no longer needed)
* Renamed the const `options` to `selectedOptions` in `handleSelectd()`
method to better reflect where the options array was coming from.
* Updating tests and translations
* Fixed the inspector functional test to use comboBox service
* Removed two unused translations
* Updating Combobox options to pass data-test-sub string
* Updated two tests for Combobox single option
* Updated the test expectations to the default string
* Both tests were looking for a named string instead of a default
message
* Adding error handling to Inspector combobox
* Checking for the item status code
* Adding a " (failed)" message if the status code returns `2`
* Updating test to look for "Chart_data" instead of "Chartdata"
* Updating two tests to validate single combobox options
* Added helper method to check default text against combobox options
* Added helper method to get the selected combobox option
* Checking two inspector instances using helpers
* Adding a defensive check to helper method.
* Correct a type error in test return
* Adding back translated failLabel
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>
* POC
* Before and after saving connector callbacks
* Draft callbacks on SN
* Migrate legacy connectors
* Add deprecated connector
* Fix callbacks types
* Pass isEdit to connector forms
* Get application info hook
* Validate instance on save
* Support both legacy and new app
* Seperate SIR
* Log application version & and throw otherwise
* Deprecated tooltip cases
* Deprecated tooltip alerts
* Improve message
* Improve translation
* Change to elastic table & fix types
* Add callbacks to add modal
* Pass new props to tests
* Change health api url to production
* Better installation message
* Migrate connectors functionality
* Change migration version to 7.16
* Fix bug
* Improve message
* Use feature flag
* Create credentials component
* Add form to migration modal
* Improve installation callout
* Improve deprecated callout
* Improve modal
* Improve application required modal
* Improve SN form
* Support both connectors
* Support correlation attributes
* Use same component for SIR
* Prevent using legacy connectors when creating a case
* Add observables
* Unique observables
* Push only if there are observables
* Change labels to plural
* Pass correlation ID and value
* Show errors on the callout
* Improve alerts tooltip
* Improve cases tooltip
* Warning callout on cases configuration page
* Fix tooltip content
* Add help text
* Change from string to array
* Fix i18n
* Fix spelling
* Update incidents for ITSM
* Update incidents for SIR
* Fix types
* Fix backend tests
* Fix frontend tests
* Add service tests
* Fix i18n
* Fix cypress test
* Improve ServiceNow intergration tests
* Fix cases integration tests
* Fix triggers actions ui end to end test
* Fix tests
* Rename modal
* Show error message on modal
* Create useOldConnector helper
* Show the update incident toggle only on new connectors
* Add observables for old connectors
* Fix error when obs are empty
* Enable SIR for alerts
* Fix types
* Improve combineObservables
* Add test for the sir api
* Add test for the sir service
* Add documentation
* PR feedback
* Improve cases deprecated callouts
* Improve observables format
* Add integration tests for SIR
* Fix doc error
* Add config tests
* Add getIncident tests
* Add util tests
* Add migration tests
* Add tests for connectors and improve callouts
* Add more tests
* Add more UI tests
* update connector modal to flyout
* PR feedback
* Test CI
* restore auth callout
* edit connector form spacing
* Improve integration tests
* Add 8 pixels to the left of the connector icon
* update switch to checkboxes
* case detail ui
* Seperate ServiceNow integration tests
* Remove observables fields
* Add correlation values
* Fix merge
* add deprecated text in the dropdown
* update card icon to the right
* new update connetor test and other tests fixes
* PR feedback
* Remove observables from docs
* Remove unused translations
* Using eui theme for styling
* Content feeback
* Add more unit tests
* Fix i18n
* Fix types
* Fixes
* Fixes
* test properly
* fix duplicated translation
* Simplify tooltip
* Writing feedback
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jonathan Buttner <jonathan.buttner@elastic.co>
## Summary
Resolves (a portion of) https://github.com/elastic/kibana/issues/107068 for the `siem-detection-engine-rule-status` type by migrating the `alertId` to be within the `SO references[]`. Based on: https://github.com/elastic/kibana/pull/113577
* Migrates the legacy `siem-detection-engine-rule-status` `alertId` to saved object references array
* Adds an e2e test for `siem-detection-engine-rule-status`
* Breaks out `siem-detection-engine-rule-status` & `security-rule` SO's to their own dedicated files/directories, and cleaned up typings/imports
Before migration you can observe the existing data structure of `siem-detection-engine-rule-status` via Dev tools as follows:
```
GET .kibana/_search
{
"size": 10000,
"query": {
"term": {
"type": {
"value": "siem-detection-engine-rule-status"
}
}
}
}
```
``` JSON
{
"_index" : ".kibana-spong_8.0.0_001",
"_id" : "siem-detection-engine-rule-status:d580f1a0-2afe-11ec-8621-8d6bfcdfd75e",
"_score" : 2.150102,
"_source" : {
"siem-detection-engine-rule-status" : {
"alertId" : "d62d2980-27c4-11ec-92b0-f7b47106bb35", <-- alertId which we want in the references array and removed
"statusDate" : "2021-10-12T01:50:52.898Z",
"status" : "failed",
"lastFailureAt" : "2021-10-12T01:50:52.898Z",
"lastSuccessAt" : "2021-10-12T01:18:29.195Z",
"lastFailureMessage" : "6 minutes (385585ms) were not queried between this rule execution and the last execution, so signals may have been missed. Consider increasing your look behind time or adding more Kibana instances. name: \"I am the Host who Names!\" id: \"d62d2980-27c4-11ec-92b0-f7b47106bb35\" rule id: \"214ccef6-e98e-493a-98c5-5bcc2d497b79\" signals index: \".siem-signals-spong-default\"",
"lastSuccessMessage" : "succeeded",
"gap" : "6 minutes",
"lastLookBackDate" : "2021-10-07T23:43:27.961Z"
},
"type" : "siem-detection-engine-rule-status",
"references" : [ ],
"coreMigrationVersion" : "7.14.0",
"updated_at" : "2021-10-12T01:50:53.404Z"
}
}
```
Post migration the data structure should be updated as follows:
``` JSON
{
"_index": ".kibana-spong_8.0.0_001",
"_id": "siem-detection-engine-rule-status:d580f1a0-2afe-11ec-8621-8d6bfcdfd75e",
"_score": 2.1865466,
"_source": {
"siem-detection-engine-rule-status": {
"statusDate": "2021-10-12T01:50:52.898Z", <-- alertId is no more!
"status": "failed",
"lastFailureAt": "2021-10-12T01:50:52.898Z",
"lastSuccessAt": "2021-10-12T01:18:29.195Z",
"lastFailureMessage": "6 minutes (385585ms) were not queried between this rule execution and the last execution, so signals may have been missed. Consider increasing your look behind time or adding more Kibana instances. name: \"I am the Host who Names!\" id: \"d62d2980-27c4-11ec-92b0-f7b47106bb35\" rule id: \"214ccef6-e98e-493a-98c5-5bcc2d497b79\" signals index: \".siem-signals-spong-default\"",
"lastSuccessMessage": "succeeded",
"gap": "6 minutes",
"lastLookBackDate": "2021-10-07T23:43:27.961Z"
},
"type": "siem-detection-engine-rule-status",
"references": [
{
"id": "d62d2980-27c4-11ec-92b0-f7b47106bb35", <-- previous alertId has been converted to references[]
"type": "alert",
"name": "alert_0"
}
],
"migrationVersion": {
"siem-detection-engine-rule-status": "7.16.0"
},
"coreMigrationVersion": "8.0.0",
"updated_at": "2021-10-12T01:50:53.406Z"
}
},
```
#### Manual testing
---
There are e2e tests but for any manual testing or verification you can do the following:
##### Manual upgrade test
If you have a 7.15.0 system and can migrate it forward that is the most straight forward way to ensure this does migrate correctly. You should see that the `Rule Monitoring` table and Rule Details `Failure History` table continue to function without error.
##### Downgrade via script and test migration on kibana reboot
If you have a migrated `Rule Status SO` and want to test the migration, you can run the below script to downgrade the status SO then restart Kibana and observe the migration on startup.
Note: Since this PR removes the mapping, you would need to [update the SO mapping](https://github.com/elastic/kibana/pull/114585/files#r729386126) to include `alertId` again else you will receive a strict/dynamic mapping error.
```json
# Replace id w/ correct Rule Status SO id of existing migrated object
POST .kibana/_update/siem-detection-engine-rule-status:d580ca91-2afe-11ec-8621-8d6bfcdfd75e
{
"script" : {
"source": """
ctx._source.migrationVersion['siem-detection-engine-rule-status'] = "7.15.0";
ctx._source['siem-detection-engine-rule-status'].alertId = ctx._source.references[0].id;
ctx._source.references.remove(0);
""",
"lang": "painless"
}
}
```
Restart Kibana and now it should be migrated correctly and you shouldn't see any errors in your console. You should also see that the `Rule Monitoring` table and Rule Details `Failure History` table continue to function without error.
### Checklist
Delete any items that are not applicable to this PR.
- [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
### For maintainers
- [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
