Commit graph

447 commits

Author SHA1 Message Date
Dmitry Lemeshko
7df1f41857
Ftr/tsfy doc table (#41710)
* [services/doc_table] tsfy service and use parse dom to get rows

* [services/doc_table] do not pass table element as argument

* [services/doc_table] update service to minimize StaleElementReference cases

* [services/doc_table] add missing access modifier

* [services/doc_table] change getHeaderFields and fix return types
2019-07-25 08:42:04 +02:00
Dmitry Lemeshko
58f2a263d0
[service/remote] check env variable value (#41909) 2019-07-25 08:29:17 +02:00
Zacqary Adam Xeper
47d9756652
[Logs UI] Make column configurations reorderable (#41035)
* [Logs UI] Make column configurations reorderable

* Improve typing aand memoize callback

* Guard against index bounds and rename reorderLogColumns

* Fix useCallback memoization

* Add functional test for reordering log columns

* Use browser.keys instead of Key in functional test
2019-07-22 13:47:47 -05:00
Greg Thompson
dd63e73fb0
Upgrade EUI to 12.4.0 (#41577)
* eui 12.4.0

* styled-components ts conflict

* update combobox test service to always open on open call

* Revert "update combobox test service to always open on open call"

This reverts commit 43074e6006.

* scroll combobox into view

* scroll before filter
2019-07-22 13:01:25 -05:00
Liza Katz
b22a28844a
Reactify Top Nav Menu (kbn_top_nav) (#40262)
* kbn top nav in discover

* New top nav in dashboard and vis editor

* Stop using template feature of kbn top nav

* Changed console menu to new directive

* Use search bar in top nav in discover and maps
Support search bar with no filter bar (TS)

* Moved storage instantiation to angular directive

* Make index patterns optional (for timepicker only setup)

* Moved discover result count away from top nav

* Removed unused name attribute in top nav. Use app-name instead.
2019-07-21 14:15:45 +03:00
Dmitry Lemeshko
e9194d75ef
[services/web_element_wrapper] update clearValue function to fix Firefox tests (#41117)
* [services/web_element_wrapper] update clearValue function

* fix flaky test #40670
2019-07-15 22:50:13 +02:00
Dmitry Lemeshko
df9d8e6f5d
FTR: upgrade chromedriver to 75 (#40791)
* ftr: update services to support chromedriver 75

* [services/webdriver] add browser logging

* update comment for W3C scrolling bug
2019-07-12 19:49:51 +02:00
Stacey Gammon
66b99ecbed
Use embeddable v2 (#39126)
* Final Embeddable API V2 PR

* fix: import discover embeddable scss file

* address code review comments

* Add a functional test that would have caught the bug... will look to add a unit version once I discover the error.

* Fix bug cause by async loading calls and changes to parent input while child is being created. added jest test

* remove outdated readme in dashboard folder

* need to always refresh dashboard container, not just when "dirty"

* add a wait, this issue started appearing right when I added this to the test

* Remove test that kills kibana ci so it's not a blocker. jest test was added for this scenario

* fix issues when panel is added then removed before it completes loading

* fix logic error with maps embeddable and isLayerTOCOpen
2019-07-12 13:31:43 -04:00
Dmitry Lemeshko
9f9d0dcbb8
WebElementWrapper: Retry WebDriver atomic calls (#40423)
* [services/lib/web_element_wrapper] use Generics in replyCall

* [services/lib/web_element_wrapper] remove redundant return types

* [services/lib/web_element_wrapper/] set retryCall timeout to 200 ms

* [services/find] explcitly pass element to have locator===null by default

* use static method to create WebElementWrapper

* missed a couple uses

* move some values to constants

* remove some unnecessary type info
2019-07-12 13:47:26 +02:00
Thomas Neirynck
6ae5b56df6
[Maps] show dialog to save map when leaving app (#40215) 2019-07-11 08:28:49 -04:00
Spencer
415e3bca27
[ts] upgrade to 3.5.3 (#40228)
* [ts] upgrade to 3.5.2

* [ts] run from cwd so that relative paths are correct

* move eslint-disable-line comment into jsx attribute

* autofix eslint violations

* avoid generic type, it's not necessary and problematic

* make elasticsearch.cluster optional, many instances don't have them

* remove invalid prop

* expand AllowUnknownProperties to cleanly handle arrays

* esfilter values can sometimes be an array of strings

* allow exception objects to have unknown properties

* define accumulator as a boolean

* fix return type

* return a 404 if beat isn't found after update

* use Object.values for better types

* define return type of get() call

* define value type for Set

* define return value of get()

* define State property type

* use less get(), so ts can infer types

* define Set item type

* map state type

* make default_operator optional, since it's not always defined

* remove seemingly unused prop

* define return type of get() fn

* define inner type for state

* don't define base types are objects with index signatues

* regenerate public api docs

* make indices privileges optional too

* remove unnecessary index-signature from Exception interface

* use variadic _arg instead

* [core/plugin] use Record<string, any> rather than {}

* replace a couple more instances of {}

* revert some unnecessary changes

* remove unused types

* [reporting] output, payload, and meta are required properties

* bump to latest patch version
2019-07-10 12:26:23 -07:00
Dmitry Lemeshko
e9f84ae83d
[ftr] replace getProperty with getAttribute (#40358)
* [ftr] replace getProperty with getAttribute

* fix failing tests

* [services/pipeline_editor] revert change
2019-07-04 21:18:14 +02:00
Spencer
a95ae8c037
[prettier] upgrade to 1.18.2 (#40229)
* [prettier] upgrade to 1.18.2

* autofix prettier violations
2019-07-03 12:36:44 -07:00
Spencer
a8fc3619ca
[ftr/browser] poll for logs and stream them (#40098) 2019-07-02 07:47:20 -07:00
Peter Pisljar
444bafbe0e
updating metricvis interpreter func arguments (#34532) 2019-06-28 05:44:43 +02:00
Dmitry Lemeshko
3ded411527
Update functional tests to run faster and pass locally (#39557)
* [shakespeare] adjust verification to pass in both headless/head runs

* [services/visualizations/pie_chart] speedup tests with timeout decrease

* [services/dashboard/expectations] speedup tests with timeout decrease
2019-06-26 07:41:35 +03:00
liza-mae
0003a32f56
[WIP] FTR Percy changes (#36897)
* [ftr/percy] integrate percy with functional test runner

* execute ftr within `percy exec`

* share PERCY_BIN and GRUNT_BIN vars in setup

* [license] whitelist `(Unlicense OR Apache-2.0)`

* [percy] include pr/parallel info in env

* echo the actual variable value

* destructure required modules

* [ci] calculate percy env in a script

* remove outdated eslint overrides

* oops, nonce should be the same for each build

* take snapshots in context tests

* add percy snapshots to some dashboard tests

* account for extra execution of PERCY_BIN

* remove usage of percy service

* rename service to `visualTesting`

* write a simple test

* switch left-over percy test to visualTesting

* set log level for percy agent

* trigger ci

* try using the system chrome install instead of downloading one

* fix export definition

* Don't skip chromium download

* Add Spencer's fix to point to chrome installation

* Attempting to split tests into own ci job and test files

* Renumber job

* Add tag to decorations file

* Try new files with existing CI job

* Try again to create a new CI job

* Fix eslint problem with space

* eslint updates

* fix console test

* make test names unique

* Update ci group names

* Try old name again

* save

* add separate visual_regression ci job

* add visual regression ci job

* add new job to jobs.yml

* update path to take_percy_snapshot script

* use fixed percy job total

* fix common services import

* move visual_create_and_add_embeddables to visual_regression project

* finish moving create_and_add_embeddables

* add x-pack visual regression job

* migrate dashboard_snapshots tests to visual_regression

* remove references to removed test files

* restore some unnecessary changes

* reimplement the login page tests

* yarn.lock update

* fix test

* remove old CI_GROUP 100 block

* update failed_tests trap

* reduce yarn.lock changes

* disable debug logging

* disable visual-regression tests for now, we can enable them in specific prs
2019-06-14 10:35:23 -06:00
Dmitry Lemeshko
f82e92a077 FTR: add support for Firefox browser (#32509)
* skip and adjust functional tests for Firefox

* downgrade geckodriver to 0.22.0

* [ftr] add firefox specific config file

* remove hard coded firefox adjustments

* remove firefox specific screenshot directory

* run functional tests in firefox in x-pack

* pass the logger to readConfigFile()

* rename local var

* skip xpack firefox config

* run xpack firefox functional tests in separate command

* update report name for XPack firefox results

* adjust viz shared item test

* skip shared item test

* [test/feature_controls] increase timeout to 20 sec & use forceLogout

* FF timeout on TSVB, refresh page on failure for url navigation

* [feature_controls/visualize_security] increase timeout to 20 sec

* skip dev_tools_spaces tests on FF

* run all groups 3 times

* skip more func tests

* skip more tests

* skip all feature controls tests for Firefox

* revert back changes in feature controls tests

* rename xpack report for chrome

* skip tile map for FF, wait for render before saving

* Revert "run all groups 3 times"

This reverts commit 12b4f69627.

* revert refresh on login

* apply feedback
2019-05-31 15:49:18 -07:00
Tim Roes
58ef3a3c49 Add addError function to toastNotifications (#32187) 2019-05-29 13:24:35 -05:00
Daniil Suleiman
38b95b1cc1 [Vis: Default editor] EUIficate top_sort param editor (#36629)
* EUIficate top_sort param editor

* Set field if only one available

* Remove unused translations

* Fix functional tests

* Fix browser tests

* Rewrite functional test for combo_box field select

* Remove unused translations

* Update label
2019-05-29 11:43:47 +03:00
Vitali Haradkou
ed29276c5f
[TSVB] markdown variables(revert fix) (#34067)
* add markdown tests
2019-05-28 00:26:28 +03:00
Vitali Haradkou
3c0bc3086a
Tsfy screenshot service and comparepng internal lib (#37177) 2019-05-28 00:09:18 +03:00
Vitali Haradkou
e9411f4a0c
FTR tsfy combobox service (#35493)
* migrate combobox to typescript
2019-05-21 10:54:47 +03:00
Matt Bargar
3070d25e46
Extract QueryBarInput component from QueryBar (#35827)
Solution for use cases that need a query bar without a submit button or date picker that still want KQL and autocomplete. Necessary for the KQL in TSVB and KQL in filters aggregation efforts.
2019-05-09 11:15:50 -05:00
Dmitry Lemeshko
f5bbe82023
adjust tests to pass on Firefox (#35597)
* adjust tests to pass on Firefox

* update feature controls tests to pass on Firefox

* use xpath to search for index pattern
2019-05-03 20:12:15 +02:00
Maryia Lapata
9c8894c705 [Vis: Default editor] EUIficate time interval control (#34991)
* EUIficate time interval control

* Update tests

* Remove empty option, update fix tests

* Bind vis to scope for react component only

* Combine two interval inputs into one EuiCombobox

* Add error message

* Add migration script; remove unused translations

* Update fuctional tests

* Update unit test

* Update tests; refactoring

* Use flow to invoke several functions

* Update test

* Refactoring

* Reset options when timeBase

* Add type for editorConfig prop

* Add placeholder

* Fix lint errors

* Call write after interval changing

* Fix code review comments

* Make replace for model name global

* Revert error catch

* Remove old dependency

* Add unit test for migration test

* Fix message

* Fix code review comments

* Update functional test
2019-05-03 10:44:14 +03:00
Dmitry Lemeshko
609297bac4
Update services to support functional tests in Firefox (#35648)
* add Browsers enum & changes to support FF

* revert moveTo signature to Promise<void>
2019-05-02 15:02:59 +02:00
Brandon Kobel
5ae5e3d8c6
Feature Controls - Read only badges (#35252)
* Adding readonly badge to the discover application

* Dashboard get a badge

* Visualize gets a badge

* Timelion gets a badge

* Canvas gets a badge

* Maps gets a badge

* Infra gets a badge

* Graph gets a badge

* Dev Tools gets a badge

* Index Patterns get badges

* Advanced Settings get badges

* Infra and i18n are super chill friends

* Using proper i18n prefix for xpack

* Adding badges to the uptime application

* APM gets a badge!

* Adding functional tests for the discover read-only badge

* Functional tests for everyone!

* Removing unused import

* Fixing chrome service mock

* Switching from ChromeBadge | null to ChromeBadge | undefined

* Fixing canvas badge assertst

* Fixing Logs ui capabilities

* More ChromeBrand | null to ChromeBrand | undefined related changes

* Using named badges

* Revert "Using named badges"

This reverts commit c0e341bee1.

* i18n'ing the uptime read-only badges

* Adding ChromeService tests for badges

* Starting to add tests for the legacy badge API

* Changing capitalization of "Read Only" to "Read only"

* Adjusting styles

* Adding $setupBadgeAutoClear tests

* Changing the badge tooltip

* Fixing timelion i18n prefix

* Changing where Canvas sets the breadcrumbs

* Using a read-only badge with an icon

* Update x-pack/plugins/canvas/public/angular/controllers/canvas.js

Co-Authored-By: kobelb <brandon.kobel@gmail.com>

* Update src/legacy/core_plugins/timelion/public/app.js

Co-Authored-By: kobelb <brandon.kobel@gmail.com>

* Changing discover's read-only verbiage

* Removing tests for code that moved to an untested part of Kibana

* Fixing issues introduced with the rebase

* Fixing priv ileges snapshot

* Adding back dropped docs

* Fixing plugin plugin doc

* Ensuring iconType is set as well

* Updating badge api, angular components moved

* graph to Graph

* Fixing linter

* Switching from aria-label to data-test-badge-label for testing

The tabIndex allows screenreaders to work properly

* Fixing eslint error

* Fixing more issues introduced by the merge from master

* APM updates badge in React hook

* Applying changes suggested by Aleh
2019-04-29 12:48:43 -07:00
Aaron Caldwell
6daaff1021
Fix map embeddable test (#34648)
* Remove skip for testing on server. Unable to repro locally

* run kibana-ciGroup2 40 times per build

* Temporarily skip 'geo map' check

* Left out 'Rendering Test: ' in filter string

* Revert "run kibana-ciGroup2 40 times per build"

This reverts commit 103a5c9c6e.

* Review feedback. Remove 'Flaky' test ref
2019-04-25 11:42:26 -06:00
Vitali Haradkou
9947045f69
Ftr tsfy webelement wrapper (#35355)
* tsfy webelement wrapper
2019-04-23 19:05:46 +03:00
Vitali Haradkou
9398cb4847
[FTR] tsfy TestSubject (#35412)
* migrate test_subjects service to typescript
2019-04-23 12:53:52 +03:00
Vitali Haradkou
25f825951f
[FTR] tsfy find & webdriver (#33494)
* migrated find and browser services to typescript
2019-04-18 10:19:11 +03:00
Dmitry Lemeshko
d37bbcfd78
update functional tests to support Firefox (#34635) 2019-04-17 09:42:54 +02:00
Dmitry Lemeshko
7a910632c0
bump chromedriver to 2.46.0 (#27302)
* bump chromedriver up to 2.46.0

* print chromedriver version

* [services/web_element_wrapper] use js to clear input field

* add clearValueWithKeyboard

* fix clearing datePattern input

* fix scripted fileds preview tests
2019-04-12 19:33:45 +02:00
Dmitry Lemeshko
f39339d9d3
Functional tests: improve waiting in combobox service (#34707)
* [services/lib/web_element_wrapper] set custom wait for findAll

* [services/remote] print browser name and version on init

* [services/combo_box] fix return statement

* fix lint error
2019-04-08 18:48:55 +02:00
Greg Thompson
865e6739fd
Upgrade EUI to 9.8.0 (#34486)
* upgrade eui to 9.8.0

* test selector updates
2019-04-03 17:25:10 -05:00
Nathan Reese
7ab080a97c
[Maps] store mapCenter in embeddable config (#33902)
* embeddable config

* set embeddableConfig when map center changes

* remove console statement

* add functional test for embeddable state
2019-03-28 06:39:36 -06:00
Maryia Lapata
b03f6c3eae
[Vis: Default editor] EUIficate agg-select (#31892)
* EUIficate agg-select

* Improve validation; update TS

* Apply styles for helpLink

* Fix unit test

* Update functional tests

* Adjust comboBox service to chose the item where the text mates exactly

* Update vis page object

* Add default value for agg

* Move aggs grouping function to a separate file

* Use labelAppend prop for help link node

* Add watcher for aggType to manage to discard changes

* Add default value for agg type title

* Fix defining selected option when aggType is defined

* Fix validation issues

* Remove a bootstrap specific class

* Change css selector in test

* Update according to SASS guidelines

* Update functinal comboBox service

* Added check for undefined

* Add jsdoc for groupAggregationsBy function

* Add unit tests for groupAggregationsBy

* Move setValidity invocation to DefaultEditorAggSelect component

* Wrap setValidity into useEffect due to react warning when select is cleaned at the first time

* Move help link definition to select component
2019-03-28 13:02:34 +03:00
Joe Reuter
06a71e8676
Functional tests: prevent waiting longer than necessary for loading spinner to disappear (#33922) 2019-03-28 10:27:42 +01:00
spalger
4fac5fc899 Revert "[TSVB] markdown variables (#33324)"
This reverts commit 412c9d843e.
2019-03-27 11:12:52 -07:00
Vitali Haradkou
412c9d843e
[TSVB] markdown variables (#33324)
* improve test coverage for TSVB markdown
* add new tests for change label, variable and rendering markdown table
2019-03-27 13:35:10 +03:00
Dmitry Lemeshko
8b0d1206a8
FTR: fix 10 sec timeout in waitForDeleted (#33313)
* use css selector instead of className, set implicit wait to 0

* set implicitWait to 2 sec

* set default implicitWait to WAIT_FOR_EXISTS_TIME

* set timeout to 1 sec, retry for query bar test

* sleep 5 sec waiting zoom is finished

* sleep is the only way to wait

* run x-pack-ciGroup3 20x times

* Revert "run x-pack-ciGroup3 20x times"

This reverts commit 55482de330.
2019-03-26 22:15:16 +01:00
Spencer
2e232c2e31
[@kbn/expect] "fork" expect.js into repo (#33761)
* [@kbn/expect] "fork" expect.js into repo

* [eslint] autofix references to expect.js

* [tslint] autofix all expect.js imports

* now that expect.js is in strict mode, avoid reassigning fn.length
2019-03-25 09:56:48 -07:00
Spencer
96206bd092
[eslint] merge custom rules into a single plugin (#33733)
I'd like to add another custom eslint rule, but there isn't a very good place to do that right now. We have the `eslint-plugin-kibana-custom` package, which is super simple but isn't in the `@kbn` namespace and isn't included in the root eslint config, and `@kbn/eslint-plugin-license-header` is too specific, so I've merged those two packages into `@kbn/eslint-plugin-eslint`, which is a little redundant but allows is to refer to the rules within it as `@kbn/eslint/{rule}`, which feels nice.

Thoughts?

_**NOTE:**_ merging the eslint rules from the two packages means enabling prettier for the code from `@kbn/eslint-plugin-license-header`, all those changes are made in 42c7da6fe2. [View the changes without the prettier updates](b647f2b...74e07a0)
2019-03-22 17:12:14 -07:00
Peter Pisljar
fec0f6c40a
adding runPipeline tests (#27015) 2019-03-21 07:12:25 +01:00
Dmitry Lemeshko
5707690494
Dashboard embeddable rendering tests: return names of failed visualisations (#32646) 2019-03-18 19:05:26 +01:00
Ryan Keairns
e9885e200a Updates to K7 nav drawer and EUI to 9.4.0 (#32864)
* update for new eui nav drawer

* remove extraAction on flyout

* fix mobile menu toggle

* add i18n for recently reviewed nav link

* progress on updating tests

* replace EuiListGroup with EuiNavDrawerGroup

* Quick label fixes

- Removing aria-label if the same as label since the `EuiNavDrawerGroup` takes care of that
- Truncating any recent items to just 64 characters and applying the `title` attribute to display the whole label.

* Adding a truncation buffer

* fix navDrawerRef

* Update to EUI 9.3.0

Also comments out some logos that don’t exist that were throwing console errors

* remove unused import

* typo fix

* One DTS too many in test

* …all the small things…

* Upgrade plugin dependencies and fix nav drawer test

* update for new eui nav drawer

* remove extraAction on flyout

* fix mobile menu toggle

* add i18n for recently reviewed nav link

* progress on updating tests

* replace EuiListGroup with EuiNavDrawerGroup

* Quick label fixes

- Removing aria-label if the same as label since the `EuiNavDrawerGroup` takes care of that
- Truncating any recent items to just 64 characters and applying the `title` attribute to display the whole label.

* Adding a truncation buffer

* fix navDrawerRef

* Update to EUI 9.3.0

Also comments out some logos that don’t exist that were throwing console errors

* remove unused import

* typo fix

* One DTS too many in test

* …all the small things…

* Upgrade plugin dependencies and fix nav drawer test

* Add support for normal image paths

Updated to EUI 9.4.0

* update testing appMenu.clickLink selector

* leave appsMenu closed while reading and clicking links

* use saveVisualizationExpectSuccess to ensure modal is closed before continuing
2019-03-14 13:35:21 -04:00
Joe Reuter
f935c14dc8 Use embeddable registry in add panel (#31400)
* Prepare control flow to use embeddable factories in add panel

* Rewrite saved object finder and add tests

* Fix usages of new saved object finder

* fix test failures

* fix some functional tests and re-introduce makeUrl

* fix tests

* remove direct hrefs in saved_object_lists

* PR review fixes

* update snapshot

* overwrite width of viz dialog

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* fix tests

* review fixes #1

* review fixes #2

* dont use classname in functional test

* remove call to action button prop

* align buttons correctly

* fix tests

* remove debugging statement

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* review fixes #3

* improve filter behavior and enable it for search wizard

* adjust functional tests for new filter behavior

* Change translation id due to string change

* Update Jest snapshot
2019-03-11 12:27:13 +01:00
Jason Rhodes
ae754ac607
Upgrades EUI to 9.x (#32009)
* Fixed a simple argument bug and removed infra date picker EUI types

* Fixes for EUI date picker types

* eui_8.0.0

* fix type errors in query_bar

* Small changes for EUI types

* Updates EUI to 9.0.0 and removes @types/react-datepicker as it now ships with EUI

* Updates to EUI 9.0.1 and removes duplicate types in infra eui.d.ts

* ts-ignore applied to ongoing type error with styled components and EUI

* Changes EuiProgress props to avoid TS errors

* Updates EUI 9.0 snapshots

* Updates kibana root snapshots for EUI 9.0 upgrade

* Update detail_panel.test.js for EUI changes

* Updated functioanl and unit tests to properly inspect EuiTableRowCell rendered values

* Fix docs_level_security_roles.js func tests

* Update EUI to 9.0.2

* Fixed failing snapshot for EUI icon default prop
2019-03-07 07:03:11 -05:00
Spencer
a7e1061bad
Typescript-ify FTR Remote (#32447)
* [ftr] flatten GenericProviderTypes to fix "log" types

* [ftr/remote] typscript-ify

* remove webdriver types, since they're version 3 and we're using version 4

* simplify initWebDriver() function

* keep jest tests in the functional tests as js, mixing jest and mocha types doesn't work
2019-03-06 07:25:59 -08:00