Spencer
7d3d79e6a1
[8.0] [eslint] enable type-specific lint rules ( #114184 ) ( #117444 )
...
* [eslint] enable type-specific lint rules (#114184 )
* [eslint] enable type-specific lint rules
* autofix violations
* duplicate eslint-disable to new export statement
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# src/plugins/share/common/index.ts
* autofix more types
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-11-04 03:02:56 +00:00
Anton Dosov
ac0fd7ced6
[uiActionsEnhanced] reduce bundle size ( #112956 )
2021-09-27 14:00:48 +02:00
Tyler Smalley
4681a80317
[DX] Upgrade prettier to v2.4.0 ( #112359 )
...
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-09-19 22:34:30 -07:00
Dzmitry Lemechko
b324ca3115
[jest] update config files to get coverage per plugin ( #111299 )
...
* [jest] update config files to get coverage per plugin
* [docs] add details about plugin coverage collection
* fix path for newsfeed jest config
* fix lint error
* update documentation
* fix lint errors again
* update doc
* fix another lint error
* Update src/plugins/telemetry_management_section/jest.config.js
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
* Update src/plugins/telemetry_management_section/jest.config.js
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
* [kibana_legacy] fix path
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-09-09 08:14:56 +02:00
Vadim Kibana
95b88cc2fe
add descriptions to plugin manifests ( #111306 )
2021-09-07 17:24:02 +02:00
Vadim Kibana
5e5dd07470
remove anys in drilldowns plugin ( #111305 )
2021-09-07 17:23:47 +02:00
Stacey Gammon
9258ba5147
Adding owners to kibana plugins ( #108407 )
...
* Adding owners to kibana plugins
* Fix ui actions enhanced owner
* Account for virtual RAC team owning a plugin
* Fix empty githubTeam for ui actions
2021-08-17 10:21:06 -04:00
Spencer
c0395c9ef6
[build_ts_refs] improve caches, allow building a subset of projects ( #107981 )
...
* [build_ts_refs] improve caches, allow building a subset of projects
* cleanup project def script and update refs in type check script
* rename browser_bazel config to avoid kebab-case
* remove execInProjects() helper
* list references for tsconfig.types.json for api-extractor workload
* disable composite features of tsconfig.types.json for api-extractor
* set declaration: true to avoid weird debug error
* fix jest tests
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-08-10 22:12:45 -07:00
Mikhail Shustov
e457f212c4
Revert "TS Incremental build exclude test files ( #95610 )" ( #96223 )
...
This reverts commit b6e582c53e
2021-04-05 11:59:26 -07:00
Mikhail Shustov
b6e582c53e
TS Incremental build exclude test files ( #95610 )
...
* add base config for all the TS projects
* all the project use new tsconfig.project.json
* compile test files in the high-level tsconfig.json
* fix TS error in maps plugin
* fix TS error in infra plugin
* exclude mote test and test until folders
* uptime. do not import test code within prod code
* expressions. do not import test code within prod code
* data: export mocks from high level folder
* task_manager: comply with es client typings
* infra: remove unused enzyme_helpers
* check_ts_project requires "include" key
* ts_check should handle parent configs
* all ts configs should extend base one
* exclude test folders from plugins
* update patterns to fix ts_check errors
* Apply suggestions from code review
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* uptime: MountWithReduxProvider to test helpers
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-01 14:40:47 +02:00
Vadim Dalecky
99929433a4
Remove "beta" label from URL Drilldown as it is now GA ( #92859 )
...
* fix: 🐛 remove "beta" label from URL Drilldown as it is now GA
2021-03-01 12:54:07 +01:00
Mikhail Shustov
e972f5124b
Migrate logstash, monitoring, url_drilldowns, xpack_legacy to ts projects ( #91194 )
...
* migrate drilldowns to ts project
* monitoring to ts project
* xpack legacy to ts project
* logstash to ts projects
* missing comma
* list deep project
* export type to refer in d.ts
2021-02-17 04:50:56 -05:00
Vadim Dalecky
8ed1c3ca3e
Url template editor ( #88577 )
...
* feat: 🎸 set up Storybook for URL template editor
* feat: 🎸 add basic syntax highlighting
* feat: 🎸 add autocompletion example
* feat: 🎸 add Handlebars language
* fix: 🐛 first register language
* feat: 🎸 add url and handlebars language parsing
* feat: 🎸 use simple Handlebars language
* refactor: 💡 move <VariablePopover> to a separate file
* feat: 🎸 add Monaco editor to URL drilldown
* feat: 🎸 remove editor line numbers
* feat: 🎸 allow user to provide Handlebars variables
* feat: 🎸 wire in URL drilldown variables into Monaco editor
* feat: 🎸 add metadata to event level variables
* feat: 🎸 allow to specify Handlebars variable kind
* feat: 🎸 add global variables to autocompletion
* refactor: 💡 restructure event and context variable code
* feat: 🎸 sort variables by scope group
* feat: 🎸 add meta information to context variables
* docs: ✏️ use correct variable labels
* feat: 🎸 fix component demo props
* feat: 🎸 improve highlighting of URL parts
* feat: 🎸 improve syntax highlighting colors
* feat: 🎸 improve highlighting colors
* feat: 🎸 add color to url query parameter key
* feat: 🎸 improve visual layout url editor
* feat: 🎸 highlight URL slashes with light color
* feat: 🎸 connect URL editor to state
* feat: 🎸 tweak URL parameter colors
* feat: 🎸 improve URL schema color
* feat: 🎸 insert variables on click in variable dropdown
* fix: 🐛 fix unit tests and translation
* test: 💍 fix drilldown tests after refactor
* feat: 🎸 add dark mode support to URL template editor
* test: 💍 fix URL drilldown test after adding dark mode support
* fix: 🐛 use text color which can be converted to dark mode
* test: 💍 fill in URL template in monaco editor
* fix: 🐛 fix translation key
* chore: 🤖 update license headers
* chore: 🤖 update license headers
* feat: 🎸 preview values of global variables
* feat: 🎸 preview values of context variables
* chore: 🤖 fix url editor Storybook config
* fix: 🐛 make translation key unique
* feat: 🎸 stop Esc key propagation in URL editor
* feat: 🎸 reduce editor height
* feat: 🎸 set example URL once URL drilldown is created
* feat: 🎸 add word wrapping to URL editor
* feat: 🎸 use EUI variable in SCSS
* feat: 🎸 add "Example: " prefix to default template
* feat: 🎸 do not insert extra brackets
* feat: 🎸 make URL param values same color as text
* perf: ⚡ ️ make URL drilldown config component lazy loaded
* test: 💍 remove default URL drilldown template
* fix: 🐛 disable autocompletion popup while typing
* style: 💄 don't use "Example: " prefix in default URL
2021-02-15 18:24:58 +01:00
Brandon Kobel
4584a8b570
Elastic License 2.0 ( #90099 )
...
* Updating everything except the license headers themselves
* Applying ESLint rules
* Manually replacing the stragglers
2021-02-03 18:12:39 -08:00
Josh Dover
0af81310b6
Remove dynamic mapped types from UiActions ( #87075 )
...
* Remove dynamic mapped types from UiActions
* Remove import between data <-> embeddables
* remove outdated comments, export action types from discover_enhanced
* fix notice.txt
Co-authored-by: restrry <restrry@gmail.com>
2021-01-05 10:11:05 +01:00
Vadim Dalecky
5591e00717
URL encoding for URL drilldown ( #86902 )
...
* feat: 🎸 use EuiSwitch for "Open in new window" toggle
* feat: 🎸 add "URL encoding" option and "Additional options"
* feat: 🎸 make "Open in new window" true by default
* feat: 🎸 respect encoding config setting
* test: 💍 add encoding tests
* feat: 🎸 add URI encoding Handlebars helpers
* docs: ✏️ add URL encoding methods to URL Drilldown docs
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-04 13:56:21 +01:00
Luke Elmers
9a3e2910a3
App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. ( #82791 )
...
* Move applyFilter, selectRange, valueClick triggers to data/embeddables.
* Update imports.
* Remove embeddable references to non-existent data plugin dependency.
* remove data mocks from embeddable
* Remove query, filters, timeRange from EmbeddableInput and move to apps.
* Remove data plugin imports from embeddable test samples.
* Remove circular dependencies caused by expressions renderer handlers.
* Update circular deps allowList.
* Remove data dependency on embeddable.
* Revert accidental data plugin change.
* Fix new circular deps issues.
* Update generated docs.
* Fix type errors in vis_type_xy
* Fix inspector data table.
2020-12-18 18:34:07 -07:00
Vadim Dalecky
a57cba4978
Drilldown allow list ( #85779 )
...
* feat: 🎸 add ROW_CLICK_TRIGGER
* feat: 🎸 wire row click event to UI Actions trigger in Lens
* feat: 🎸 add row click trigger to url drilldown
* feat: 🎸 add datatable to row click context
* feat: 🎸 pass in row index in row click trigger context
* feat: 🎸 add columns to row click trigger context
* feat: 🎸 fill values and keys event scope array
* feat: 🎸 generate correct row scope variables
* fix: 🐛 report triggers from lens embeddable
* feat: 🎸 add sample preview for row click trigger
* feat: 🎸 remove url drilldown preview box
* chore: 🤖 remove mock variable generation functions
* feat: 🎸 generate context and global variable lists
* feat: 🎸 preview event variable list
* feat: 🎸 show empty url error on blur
* feat: 🎸 add ability to always show popup for executed actions
* refactor: 💡 rename multiple action execution method
* fix: 🐛 don't add separator befor group on no main items
* feat: 🎸 wire in uiActions service into datatable renderer
* feat: 🎸 check each row if it has compatible row click actions
* feat: 🎸 allow passing data to expression renderer
* feat: 🎸 add isEmbeddable helper
* feat: 🎸 pass embeddable to lens table renderer
* feat: 🎸 hide lens table row actions which are empty
* feat: 🎸 re-render lens embeddable when dynamic actions chagne
* feat: 🎸 hide actions column if there are no row actions
* feat: 🎸 re-render lens embeddable on view mode chagne
* fix: 🐛 fix TypeScript errors
* chore: 🤖 fix TypeScript errors
* docs: ✏️ update auto-generated docs
* feat: 🎸 add hasCompatibleActions to expression layer
* feat: 🎸 remove "data" from expression renderer handlers
* fix: 🐛 fix TypeScript errors
* test: 💍 fix Jest tests
* docs: ✏️ update autogenerated docs
* fix: 🐛 wrap event payload into data
* test: 💍 add "alwaysShowPopup" test
* chore: 🤖 add comment requested in review
https://github.com/elastic/kibana/pull/83167#discussion_r537340216
* test: 💍 add hasCompatibleActions test
* test: 💍 add datatable renderer test
* test: 💍 add Lens embeddable input change tests
* test: 💍 add embeddable row click test
* fix: 🐛 add url validation
* test: 💍 add url drilldown tests
* docs: ✏️ remove url drilldown preview from docs
* docs: ✏️ remove preview from url templating
* docs: ✏️ add row click description
* chore: 🤖 move 36.5 KB bundle balance to url_drilldown
* test: 💍 simplify test case
* feat: 🎸 check if external URL is valid before redirecting user
* test: 💍 check for external URL validity
* feat: 🎸 check if external URL is allowed in exec and getHref
* test: 💍 fix test import
2020-12-15 12:17:19 +01:00
Vadim Dalecky
b01a327076
Row trigger 2 ( #83167 )
...
* feat: 🎸 add ROW_CLICK_TRIGGER
* feat: 🎸 wire row click event to UI Actions trigger in Lens
* feat: 🎸 add row click trigger to url drilldown
* feat: 🎸 add datatable to row click context
* feat: 🎸 pass in row index in row click trigger context
* feat: 🎸 add columns to row click trigger context
* feat: 🎸 fill values and keys event scope array
* feat: 🎸 generate correct row scope variables
* fix: 🐛 report triggers from lens embeddable
* feat: 🎸 add sample preview for row click trigger
* feat: 🎸 remove url drilldown preview box
* chore: 🤖 remove mock variable generation functions
* feat: 🎸 generate context and global variable lists
* feat: 🎸 preview event variable list
* feat: 🎸 show empty url error on blur
* feat: 🎸 add ability to always show popup for executed actions
* refactor: 💡 rename multiple action execution method
* fix: 🐛 don't add separator befor group on no main items
* feat: 🎸 wire in uiActions service into datatable renderer
* feat: 🎸 check each row if it has compatible row click actions
* feat: 🎸 allow passing data to expression renderer
* feat: 🎸 add isEmbeddable helper
* feat: 🎸 pass embeddable to lens table renderer
* feat: 🎸 hide lens table row actions which are empty
* feat: 🎸 re-render lens embeddable when dynamic actions chagne
* feat: 🎸 hide actions column if there are no row actions
* feat: 🎸 re-render lens embeddable on view mode chagne
* fix: 🐛 fix TypeScript errors
* chore: 🤖 fix TypeScript errors
* docs: ✏️ update auto-generated docs
* feat: 🎸 add hasCompatibleActions to expression layer
* feat: 🎸 remove "data" from expression renderer handlers
* fix: 🐛 fix TypeScript errors
* test: 💍 fix Jest tests
* docs: ✏️ update autogenerated docs
* fix: 🐛 wrap event payload into data
* test: 💍 add "alwaysShowPopup" test
* chore: 🤖 add comment requested in review
https://github.com/elastic/kibana/pull/83167#discussion_r537340216
* test: 💍 add hasCompatibleActions test
* test: 💍 add datatable renderer test
* test: 💍 add Lens embeddable input change tests
* test: 💍 add embeddable row click test
* fix: 🐛 add url validation
* test: 💍 add url drilldown tests
* docs: ✏️ remove url drilldown preview from docs
* docs: ✏️ remove preview from url templating
* docs: ✏️ add row click description
* chore: 🤖 move 36.5 KB bundle balance to url_drilldown
* test: 💍 simplify test case
* style: 💄 change types places
* refactor: 💡 clean up panel variable generation
* test: 💍 add getPanelVariables() tests
* fix: 🐛 generate runtime variables correctly
* fix: 🐛 improve getVariableList() and add tests for it
* feat: 🎸 add translation, improve types
2020-12-14 13:28:23 +01:00
Tyler Smalley
b593781009
Jest multi-project configuration ( #77894 )
...
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-12-02 11:42:23 -08:00
Vadim Dalecky
aaadbe88c5
Context menu trigger for URL Drilldown ( #81158 )
...
* feat: 🎸 add context menu trigger to URL drilldown
* fix: 🐛 translate "Drilldowns" grouping title
* feat: 🎸 add dynamic action grouping to dynamic actions
* fix: 🐛 add translations to trigger texts
* feat: 🎸 enambe ctx menu trigger in both flyouts, move to end
* fix: 🐛 show context menu event scope variable sfor ctx menu
* test: 💍 add tests
* fix: 🐛 use correct namespace for translation keys
* docs: ✏️ update autogenerated docs
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-30 13:04:48 +01:00
Peter Pisljar
c90dabaeba
removing kibana_datatable in favor of datatable ( #80548 )
2020-10-16 18:46:51 +02:00
spalger
6eeab00944
Revert "removing kibana_datatable in favor of datatable` ( #75184 )"
...
This reverts commit 255b865be8
2020-10-13 08:53:14 -07:00
Peter Pisljar
255b865be8
removing kibana_datatable in favor of datatable` ( #75184 )
2020-10-13 17:00:38 +02:00
Anton Dosov
4b6d77fa5d
[Drilldowns] Config to disable URL Drilldown ( #77887 )
...
This pr makes sure there is way to disable URL drilldown feature.
I decided to extract Url drilldown definition into a separate plugin to benefit from regular disabling a plugin feature.
Having it as a separate plugin also makes sense because we will start adding registries specific to URL drilldown implementation
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-23 11:12:12 +02:00
Anton Dosov
f33192d35f
[refactor] remove drilldown plugin, move components to uiActionsEnhanced ( #69403 )
...
* refactor: remove drilldown plugin by moving components to uiActionsEnhanced
* fix
* fix mistake in test
* fix i18n
2020-06-18 15:35:22 +02:00
Vadim Dalecky
b8e6b54428
Drilldown docs 2 ( #69375 )
...
* docs: ✏️ add drilldown user docs link to REAMDE
* feat: 🎸 wire drilldown docs link into <HelloBar> component
* feat: 🎸 set new page attributes on drilldown docs link
* feat: 🎸 add external prop to link to show icon
* fix: 🐛 remove rel= attribute
* fix: 🐛 add TypeScript type for drilldown docLink
2020-06-17 17:00:22 +02:00
Vadim Dalecky
99a6435daf
advanced_ui_actions 👉 ui_actions_enhanced ( #68258 )
...
* chore: 🤖 rename advanced_ui_actions to ui_actions_enhanced
* chore: 🤖 rename exported interface to "enhanced"
2020-06-05 13:14:01 +02:00
restrry
bf04235dae
apply prettier styles
2020-05-22 09:08:58 +02:00
Anton Dosov
0f5c1ed95a
[Drilldowns][chore] Remove some any's from components. Remove PlaceContext from components ( #65854 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-12 10:57:49 +02:00
Anton Dosov
724f282059
[Drilldowns][IE] fix welcome bar layout in IE ( #65676 )
...
* fix drilldown hello bar in IE
* fix comment
* use children instead of title for EuiCallOut content
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-12 10:30:19 +02:00
Anton Dosov
ae38c6ba4c
[Drilldowns] Copy improvements ( #65838 )
...
* update toast messages
* update HelloBar text
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-11 12:38:39 +02:00
Anton Dosov
3604f5d21a
[Drilldowns] Preserve state when selecting different action factory ( #65074 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-07 13:18:56 +02:00
Michail Yasonik
35e10273d3
New nav ( #64018 )
...
Notably, also removes aria-hidden from many visualizations
2020-05-05 23:14:14 -05:00
Vadim Dalecky
360b9c1200
Drilldowns ( #61219 )
...
* Add drilldown wizard components
* Dynamic actions (#58216 )
* feat: 🎸 add DynamicAction and FactoryAction types
* feat: 🎸 add Mutable<T> type to @kbn/utility-types
* feat: 🎸 add ActionInternal and ActionContract
* chore: 🤖 remove unused file
* feat: 🎸 improve action interfaces
* docs: ✏️ add JSDocs
* feat: 🎸 simplify ui_actions interfaces
* fix: 🐛 fix TypeScript types
* feat: 🎸 add AbstractPresentable interface
* feat: 🎸 add AbstractConfigurable interface
* feat: 🎸 use AbstractPresentable in ActionInternal
* test: 💍 fix ui_actions Jest tests
* feat: 🎸 add state container to action
* perf: ⚡ ️ convert MenuItem to React component on Action instance
* refactor: 💡 rename AbsractPresentable -> Presentable
* refactor: 💡 rename AbstractConfigurable -> Configurable
* feat: 🎸 add Storybook to ui_actions
* feat: 🎸 add <ErrorConfigureAction> component
* feat: 🎸 improve <ConfigureAction> component
* chore: 🤖 use .story file extension prefix for Storybook
* feat: 🎸 improve <ErrorConfigureAction> component
* feat: 🎸 show error if dynamic action has CollectConfig missing
* feat: 🎸 render sample action configuration component
* feat: 🎸 connect action config to <ConfigureAction>
* feat: 🎸 improve <ConfigureAction> stories
* test: 💍 add ActionInternal serialize/deserialize tests
* feat: 🎸 add ActionContract
* feat: 🎸 split action Context into Execution and Presentation
* fix: 🐛 fix TypeScript error
* refactor: 💡 extract state container hooks to module scope
* docs: ✏️ fix typos
* chore: 🤖 remove Mutable<t> type
* test: 💍 don't cast to any getActions() function
* style: 💄 avoid using unnecessary types
* chore: 🤖 address PR review comments
* chore: 🤖 rename ActionContext generic
* chore: 🤖 remove order from state container
* chore: 🤖 remove deprecation notice on getHref
* test: 💍 fix tests after order field change
* remove comments
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Drilldown context menu (#59638 )
* fix: 🐛 fix TypeScript error
* feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger
* fix: 🐛 correctly order context menu items
* fix: 🐛 set correct order on drilldown flyout actions
* fix: 🐛 clean up context menu building functions
* feat: 🎸 add context menu separator action
* Add basic ActionFactoryService. Pass data from it into components instead of mocks
* Dashboard x pack (#59653 )
* feat: 🎸 add dashboard_enhanced plugin to x-pack
* feat: 🎸 improve context menu separator
* feat: 🎸 move drilldown flyout actions to dashboard_enhanced
* fix: 🐛 fix exports from ui_actions plugin
* feat: 🎸 "implement" registerDrilldown() method
* fix ConfigurableBaseConfig type
* Implement connected flyout_manage_drilldowns component
* Simplify connected flyout manage drilldowns component. Remove intermediate component
* clean up data-testid workaround in new components
* Connect welcome message to storage
Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.
* require `context` in Presentable. drill context down through wizard components
* Drilldown factory (#59823 )
* refactor: 💡 import storage interface from ui_actions plugin
* refactor: 💡 make actions not-dynamic
* feat: 🎸 fix TypeScript errors, reshuffle types and code
* fix: 🐛 fix more TypeScript errors
* fix: 🐛 fix TypeScript import error
* Drilldown registration (#59834 )
* feat: 🎸 improve drilldown registration method
* fix: 🐛 set up translations for dashboard_enhanced plugin
* Drilldown events 3 (#59854 )
* feat: 🎸 add serialize/unserialize to action
* feat: 🎸 pass in uiActions service into Embeddable
* feat: 🎸 merge ui_actions oss and basic plugins
* refactor: 💡 move action factory registry to OSS
* fix: 🐛 fix TypeScript errors
* Drilldown events 4 (#59876 )
* feat: 🎸 mock sample drilldown execute methods
* feat: 🎸 add .dynamicActions manager to Embeddable
* feat: 🎸 add first version of dynamic action manager
* Drilldown events 5 (#59885 )
* feat: 🎸 display drilldowns in context menu only on one embed
* feat: 🎸 clear dynamic actions from registry when embed unloads
* fix: 🐛 fix OSS TypeScript errors
* basic integration of components with dynamicActionManager
* fix: 🐛 don't overwrite explicitInput with combined input (#59938 )
* display drilldown count in embeddable edit mode
* display drilldown count in embeddable edit mode
* improve wizard components. more tests.
* partial progress, dashboard drilldowns (#59977 )
* partial progress, dashboard drilldowns
* partial progress, dashboard drilldowns
* feat: 🎸 improve dashboard drilldown setup
* feat: 🎸 wire in services into dashboard drilldown
* chore: 🤖 add Storybook to dashboard_enhanced
* feat: 🎸 create presentational <DashboardDrilldownConfig>
* test: 💍 add <DashboardDrilldownConfig> stories
* test: 💍 use presentation dashboar config component
* feat: 🎸 wire in services into React component
* docs: ✏️ add README to /components folder
* feat: 🎸 increase importance of Dashboard drilldown
* feat: 🎸 improve icon definition in drilldowns
* chore: 🤖 remove unnecessary comment
* chore: 🤖 add todos
Co-authored-by: streamich <streamich@gmail.com>
* Manage drilldowns toasts. Add basic error handling.
* support order in action factory selector
* fix column order in manage drilldowns list
* remove accidental debug info
* bunch of nit ui fixes
* Drilldowns reactive action manager (#60099 )
* feat: 🎸 improve isConfigValid return type
* feat: 🎸 make DynamicActionManager reactive
* docs: ✏️ add JSDocs to public mehtods of DynamicActionManager
* feat: 🎸 make panel top-right corner number badge reactive
* fix: 🐛 correctly await for .deleteEvents()
* Drilldowns various 2 (#60103 )
* chore: 🤖 address review comments
* test: 💍 fix embeddable_panel.test.tsx tests
* chore: 🤖 clean up ActionInternal
* chore: 🤖 make isConfigValid a simple predicate
* chore: 🤖 fix TypeScript type errors
* test: 💍 stub DynamicActionManager tests (#60104 )
* Drilldowns review 1 (#60139 )
* refactor: 💡 improve generic types
* fix: 🐛 don't overwrite icon
* fix: 🐛 fix x-pack TypeScript errors
* fix: 🐛 fix TypeScript error
* fix: 🐛 correct merge
* Drilldowns various 4 (#60264 )
* feat: 🎸 hide "Create drilldown" from context menu when needed
* style: 💄 remove AnyDrilldown type
* feat: 🎸 add drilldown factory context
* chore: 🤖 remove sample drilldown
* fix: 🐛 increase spacing between action factory picker
* workaround issue with closing flyout when navigating away
Adds overlay just like other flyouts which makes this defect harder to bump in
* fix react key issue in action_wizard
* don’t open 2 flyouts
* fix action order
https://github.com/elastic/kibana/issues/60138
* Drilldowns reload stored (#60336 )
* style: 💄 don't use double equals __
* feat: 🎸 add reload$ to ActionStorage interface
* feat: 🎸 add reload$ to embeddable event storage
* feat: 🎸 add storage syncing to DynamicActionManager
* refactor: 💡 use state from DynamicActionManager in React
* fix: 🐛 add check for manager being stopped
* Drilldowns triggers (#60339 )
* feat: 🎸 make use of supportedTriggers()
* feat: 🎸 pass in context to configuration component
* feat: 🎸 augment factory context
* fix: 🐛 stop infinite re-rendering
* Drilldowns multitrigger (#60357 )
* feat: 🎸 add support for multiple triggers
* feat: 🎸 enable Drilldowns for TSVB
Although TSVB brushing event is now broken on master, KibanaApp plans to
fix it in 7.7
* "Create drilldown" flyout - design cleanup (#60309 )
* create drilldown flyout cleanup
* remove border from selectedActionFactoryContainer
* adjust callout in DrilldownHello
* update form labels
* remove unused file
* fix type error
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
* basic unit tests for flyout_create_drildown action
* Drilldowns finalize (#60371 )
* fix: 🐛 align flyout content to left side
* fix: 🐛 move context menu item number 1px lower
* fix: 🐛 move flyout back nav chevron up
* fix: 🐛 fix type check after refactor
* basic unit tests for drilldown actions
* Drilldowns finalize 2 (#60510 )
* test: 💍 fix test mock
* chore: 🤖 remove unused UiActionsService methods
* refactor: 💡 cleanup UiActionsService action registration
* fix: 🐛 add missing functionality after refactor
* test: 💍 add action factory tests
* test: 💍 add DynamicActionManager tests
* feat: 🎸 capture error if it happens during initial load
* fix: 🐛 register correctly CSV action
* feat: 🎸 don't show "OPTIONS" title on drilldown context menus
* feat: 🎸 add server-side for x-pack dashboard plugin
* feat: 🎸 disable Drilldowns for TSVB
* feat: 🎸 enable drilldowns on kibana.yml feature flag
* feat: 🎸 add feature flag comment to kibana.yml
* feat: 🎸 remove places from drilldown interface
* refactor: 💡 remove place in factory context
* chore: 🤖 remove doExecute
* remove not needed now error_configure_action component
* remove workaround for storybook
* feat: 🎸 improve DrilldownDefinition interface
* style: 💄 replace any by unknown
* chore: 🤖 remove any
* chore: 🤖 make isConfigValid return type a boolean
* refactor: 💡 move getDisplayName to factory, remove deprecated
* style: 💄 remove any
* feat: 🎸 improve ActionFactoryDefinition
* refactor: 💡 change visualize_embeddable params
* feat: 🎸 add dashboard dependency to dashboard_enhanced
* style: 💄 rename drilldown plugin life-cycle contracts
* refactor: 💡 do naming adjustments for dashboard drilldown
* fix: 🐛 fix Type error
* fix: 🐛 fix TypeScript type errors
* test: 💍 fix test after refactor
* refactor: 💡 rename context -> placeContext in React component
* chore: 🤖 remove setting from kibana.yml
* refactor: 💡 change return type of getAction as per review
* remove custom css per review
* refactor: 💡 rename drilldownCount to eventCount
* style: 💄 remove any
* refactor: 💡 change how uiActions are passed to vis embeddable
* style: 💄 remove unused import
* fix: 🐛 pass in uiActions to visualize_embeddable
* fix: 🐛 correctly register action
* fix: 🐛 fix type error
* chore: 🤖 remove unused translations
* Dynamic actions to xpack (#62647 )
* feat: 🎸 set up sample action factory provider
* feat: 🎸 create dashboard_enhanced plugin
* feat: 🎸 add EnhancedEmbeddable interface
* refactor: 💡 move DynamicActionManager to x-pack
* feat: 🎸 connect dynamic action manager to embeddable life-cycle
* test: 💍 fix Jest tests after refactor
* fix: 🐛 fix type error
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* refactor: 💡 move action factories to x-pack (#63190 )
* refactor: 💡 move action factories to x-pack
* fix: 🐛 use correct plugin embeddable deps
* test: 💍 fix Jest test after refactor
* chore: 🤖 remove kibana.yml flag (#62441 )
* Panel top right (#63466 )
* feat: 🎸 add PANEL_NOTIFICATION_TRIGGER
* feat: 🎸 add PanelNotificationsAction action
* test: 💍 add PanelNotificationsAction unit tests
* refactor: 💡 revert addTriggerAction() change
* style: 💄 remove unused import
* fix: 🐛 fix typecheck errors after merge
* support getHref in drilldowns (#63727 )
* chore: 🤖 remove ui_actions storybook config
* update docs
* fix ts
* fix: 🐛 fix broken merge
* [Drilldowns] Dashboard to dashboard drilldown (#63108 )
* partial progress on async loading / searching of dashboard titles
* feat: 🎸 make combobox full width
* filtering combobox polish
* storybook fix
* implement navigating to dashboard, seems like a type problem
* try navToApp
* filter out current dashboard
* rough draft linking to a dashboard
* remove note
* typefix
* fix navigation from dashboard to dashboard
except for back button - that would be addressed separatly
* partial progress getting filters from action data
* fix issue with getIndexPatterns undefined
we can’t import those functions as static functions, instead we have to expose them on plugin contract because they are statefull
* fix filter / time passing into url
* typefix
* dashboard to dashboard drilldown functional test and back button fix
* documentation update
* chore clean-ups
fix type
* basic unit test for dashboard drilldown
* remove test todos
decided to skip those tests because not clear how to test due to EuiCombobox is using react-virtualized and options list is not rendered in jsdom env
* remove config
* improve back button with filter comparison tweak
* dashboard filters/date option off by default
* revert change to config/kibana.yml
* remove unneeded comments
* use default time range as appropriate
* fix type, add filter icon, add text
* fix test
* change how time range is restored and improve back button for drilldowns
* resolve conflicts
* fix async compile issue
* remove redundant test
* wip
* wip
* fix
* temp skip tests
* fix
* handle missing dashboard edge case
* fix api
* refactor action filter creation utils
* updating
* updating docs
* improve
* fix storybook
* post merge fixes
* fix payload emitted in brush event
* properly export createRange action
* improve tests
* add test
* post merge fixes
* improve
* fix
* improve
* fix build
* wip getHref support
* implement getHref()
* give proper name to a story
* use sync start services
* update text
* fix types
* fix ts
* fix docs
* move clone below drilldowns (near replace)
* remove redundant comments
* refactor action filter creation utils
* updating
* updating docs
* fix payload emitted in brush event
* properly export createRange action
* some more updates
* fixing types
* ...
* inline EventData
* fix typescript in lens and update docs
* improve filters types
* docs
* merge
* @mdefazio review
* adjust actions order
* docs
* @stacey-gammon review
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: streamich <streamich@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>
* fix docs
* nit fixes
* chore: 🤖 remove uiActions from Embeddable dependencies
* chore: 🤖 don't export ActionInternal from ui_actions
* test: 💍 remove uiActions deps in x-pack test mocks
* chore: 🤖 cleanup ui_actions types
* docs: ✏️ add JSDoc comment to addTriggerAction()
* docs: ✏️ regenerate docs
* Drilldown demo 2 (#64300 )
* chore: 🤖 add example of Discover drilldown to sample plugin
* fix: 🐛 show drilldowns with higher "order" first
* feat: 🎸 add createStartServicesGetter() to /public kibana_util
* feat: 🎸 load index patterns in Discover drilldown
* feat: 🎸 add toggle for index pattern selection
* feat: 🎸 add spacer to separate unrelated config fields
* fix: 🐛 correctly configre setup core
* feat: 🎸 navigate to correct index pattern
* chore: 🤖 fix type check errors
* fix: 🐛 make index pattern select full width
* fix: 🐛 add getHref support
* feat: 🎸 add example plugin ability to X-Pack
* refactor: 💡 move Discover drilldown example to X-Pack
* feat: 🎸 add dashboard-to-url drilldown example
* feat: 🎸 add new tab support for URL drilldown
* feat: 🎸 add "hello world" drilldown example
* docs: ✏️ add README
* feat: 🎸 add getHref support
* chore: 🤖 cleanup after moving examples to X-Pack
* docs: ✏️ add to README.md info on how to find drilldowns
* feat: 🎸 store events in .enhancements field
* docs: ✏️ add comment to range trigger title
* refactor: 💡 move Configurable interface into kibana_utils
* chore: 🤖 simplify internal component types
* refactor: 💡 move registerDrilldwon() to advanced_ui_actions
* test: 💍 update functional test data
* merge
* docs: ✏️ make drilldown enhancement comment more general
* fix: 🐛 return public type from registerAction() call
* docs: ✏️ add comment to value click trigger title field
* docs: ✏️ improve comment
* fix: 🐛 use second argument of CollectConfigProps interface
* fix: 🐛 add workaround for Firefox rendering issue
See:
https://github.com/elastic/kibana/pull/61219/#pullrequestreview-402903330
* chore: 🤖 delete unused file
* fix: 🐛 import type from new location
* style: 💄 make generic type variable name sconsistent
* fix: 🐛 show "Create drilldown" only on dashboard
* test: 💍 add extra unit test for root embeddable type
* docs: ✏️ update generated docs
* chore: 🤖 add example warnings to sample drilldowns
* docs: ✏️ add links to example warnings
* feat: 🎸 add URL drilldown validation and https:// prefixing
* fix: 🐛 disable drilldowns for lens
* refactor: 💡 remove PlaceContext from DrilldownDefinition
* fix: 🐛 fix type check error
* feat: 🎸 show warning message if embeddable not provided
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>
2020-05-04 16:11:20 +02:00
Josh Dover
37c92ca476
Fix plugin enabled config options ( #60998 )
2020-03-25 15:09:04 -06:00
Matthew Kime
498abb4152
Revert "Drilldowns ( #59632 )" ( #61136 )
...
This reverts commit 5abb2c8c7d
2020-03-24 16:22:11 -05:00
Vadim Dalecky
5abb2c8c7d
Drilldowns ( #59632 )
...
* Add drilldown wizard components
* Dynamic actions (#58216 )
* feat: 🎸 add DynamicAction and FactoryAction types
* feat: 🎸 add Mutable<T> type to @kbn/utility-types
* feat: 🎸 add ActionInternal and ActionContract
* chore: 🤖 remove unused file
* feat: 🎸 improve action interfaces
* docs: ✏️ add JSDocs
* feat: 🎸 simplify ui_actions interfaces
* fix: 🐛 fix TypeScript types
* feat: 🎸 add AbstractPresentable interface
* feat: 🎸 add AbstractConfigurable interface
* feat: 🎸 use AbstractPresentable in ActionInternal
* test: 💍 fix ui_actions Jest tests
* feat: 🎸 add state container to action
* perf: ⚡ ️ convert MenuItem to React component on Action instance
* refactor: 💡 rename AbsractPresentable -> Presentable
* refactor: 💡 rename AbstractConfigurable -> Configurable
* feat: 🎸 add Storybook to ui_actions
* feat: 🎸 add <ErrorConfigureAction> component
* feat: 🎸 improve <ConfigureAction> component
* chore: 🤖 use .story file extension prefix for Storybook
* feat: 🎸 improve <ErrorConfigureAction> component
* feat: 🎸 show error if dynamic action has CollectConfig missing
* feat: 🎸 render sample action configuration component
* feat: 🎸 connect action config to <ConfigureAction>
* feat: 🎸 improve <ConfigureAction> stories
* test: 💍 add ActionInternal serialize/deserialize tests
* feat: 🎸 add ActionContract
* feat: 🎸 split action Context into Execution and Presentation
* fix: 🐛 fix TypeScript error
* refactor: 💡 extract state container hooks to module scope
* docs: ✏️ fix typos
* chore: 🤖 remove Mutable<t> type
* test: 💍 don't cast to any getActions() function
* style: 💄 avoid using unnecessary types
* chore: 🤖 address PR review comments
* chore: 🤖 rename ActionContext generic
* chore: 🤖 remove order from state container
* chore: 🤖 remove deprecation notice on getHref
* test: 💍 fix tests after order field change
* remove comments
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Drilldown context menu (#59638 )
* fix: 🐛 fix TypeScript error
* feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger
* fix: 🐛 correctly order context menu items
* fix: 🐛 set correct order on drilldown flyout actions
* fix: 🐛 clean up context menu building functions
* feat: 🎸 add context menu separator action
* Add basic ActionFactoryService. Pass data from it into components instead of mocks
* Dashboard x pack (#59653 )
* feat: 🎸 add dashboard_enhanced plugin to x-pack
* feat: 🎸 improve context menu separator
* feat: 🎸 move drilldown flyout actions to dashboard_enhanced
* fix: 🐛 fix exports from ui_actions plugin
* feat: 🎸 "implement" registerDrilldown() method
* fix ConfigurableBaseConfig type
* Implement connected flyout_manage_drilldowns component
* Simplify connected flyout manage drilldowns component. Remove intermediate component
* clean up data-testid workaround in new components
* Connect welcome message to storage
Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.
* require `context` in Presentable. drill context down through wizard components
* Drilldown factory (#59823 )
* refactor: 💡 import storage interface from ui_actions plugin
* refactor: 💡 make actions not-dynamic
* feat: 🎸 fix TypeScript errors, reshuffle types and code
* fix: 🐛 fix more TypeScript errors
* fix: 🐛 fix TypeScript import error
* Drilldown registration (#59834 )
* feat: 🎸 improve drilldown registration method
* fix: 🐛 set up translations for dashboard_enhanced plugin
* Drilldown events 3 (#59854 )
* feat: 🎸 add serialize/unserialize to action
* feat: 🎸 pass in uiActions service into Embeddable
* feat: 🎸 merge ui_actions oss and basic plugins
* refactor: 💡 move action factory registry to OSS
* fix: 🐛 fix TypeScript errors
* Drilldown events 4 (#59876 )
* feat: 🎸 mock sample drilldown execute methods
* feat: 🎸 add .dynamicActions manager to Embeddable
* feat: 🎸 add first version of dynamic action manager
* Drilldown events 5 (#59885 )
* feat: 🎸 display drilldowns in context menu only on one embed
* feat: 🎸 clear dynamic actions from registry when embed unloads
* fix: 🐛 fix OSS TypeScript errors
* basic integration of components with dynamicActionManager
* fix: 🐛 don't overwrite explicitInput with combined input (#59938 )
* display drilldown count in embeddable edit mode
* display drilldown count in embeddable edit mode
* improve wizard components. more tests.
* partial progress, dashboard drilldowns (#59977 )
* partial progress, dashboard drilldowns
* partial progress, dashboard drilldowns
* feat: 🎸 improve dashboard drilldown setup
* feat: 🎸 wire in services into dashboard drilldown
* chore: 🤖 add Storybook to dashboard_enhanced
* feat: 🎸 create presentational <DashboardDrilldownConfig>
* test: 💍 add <DashboardDrilldownConfig> stories
* test: 💍 use presentation dashboar config component
* feat: 🎸 wire in services into React component
* docs: ✏️ add README to /components folder
* feat: 🎸 increase importance of Dashboard drilldown
* feat: 🎸 improve icon definition in drilldowns
* chore: 🤖 remove unnecessary comment
* chore: 🤖 add todos
Co-authored-by: streamich <streamich@gmail.com>
* Manage drilldowns toasts. Add basic error handling.
* support order in action factory selector
* fix column order in manage drilldowns list
* remove accidental debug info
* bunch of nit ui fixes
* Drilldowns reactive action manager (#60099 )
* feat: 🎸 improve isConfigValid return type
* feat: 🎸 make DynamicActionManager reactive
* docs: ✏️ add JSDocs to public mehtods of DynamicActionManager
* feat: 🎸 make panel top-right corner number badge reactive
* fix: 🐛 correctly await for .deleteEvents()
* Drilldowns various 2 (#60103 )
* chore: 🤖 address review comments
* test: 💍 fix embeddable_panel.test.tsx tests
* chore: 🤖 clean up ActionInternal
* chore: 🤖 make isConfigValid a simple predicate
* chore: 🤖 fix TypeScript type errors
* test: 💍 stub DynamicActionManager tests (#60104 )
* Drilldowns review 1 (#60139 )
* refactor: 💡 improve generic types
* fix: 🐛 don't overwrite icon
* fix: 🐛 fix x-pack TypeScript errors
* fix: 🐛 fix TypeScript error
* fix: 🐛 correct merge
* Drilldowns various 4 (#60264 )
* feat: 🎸 hide "Create drilldown" from context menu when needed
* style: 💄 remove AnyDrilldown type
* feat: 🎸 add drilldown factory context
* chore: 🤖 remove sample drilldown
* fix: 🐛 increase spacing between action factory picker
* workaround issue with closing flyout when navigating away
Adds overlay just like other flyouts which makes this defect harder to bump in
* fix react key issue in action_wizard
* don’t open 2 flyouts
* fix action order
https://github.com/elastic/kibana/issues/60138
* Drilldowns reload stored (#60336 )
* style: 💄 don't use double equals __
* feat: 🎸 add reload$ to ActionStorage interface
* feat: 🎸 add reload$ to embeddable event storage
* feat: 🎸 add storage syncing to DynamicActionManager
* refactor: 💡 use state from DynamicActionManager in React
* fix: 🐛 add check for manager being stopped
* Drilldowns triggers (#60339 )
* feat: 🎸 make use of supportedTriggers()
* feat: 🎸 pass in context to configuration component
* feat: 🎸 augment factory context
* fix: 🐛 stop infinite re-rendering
* Drilldowns multitrigger (#60357 )
* feat: 🎸 add support for multiple triggers
* feat: 🎸 enable Drilldowns for TSVB
Although TSVB brushing event is now broken on master, KibanaApp plans to
fix it in 7.7
* "Create drilldown" flyout - design cleanup (#60309 )
* create drilldown flyout cleanup
* remove border from selectedActionFactoryContainer
* adjust callout in DrilldownHello
* update form labels
* remove unused file
* fix type error
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
* basic unit tests for flyout_create_drildown action
* Drilldowns finalize (#60371 )
* fix: 🐛 align flyout content to left side
* fix: 🐛 move context menu item number 1px lower
* fix: 🐛 move flyout back nav chevron up
* fix: 🐛 fix type check after refactor
* basic unit tests for drilldown actions
* Drilldowns finalize 2 (#60510 )
* test: 💍 fix test mock
* chore: 🤖 remove unused UiActionsService methods
* refactor: 💡 cleanup UiActionsService action registration
* fix: 🐛 add missing functionality after refactor
* test: 💍 add action factory tests
* test: 💍 add DynamicActionManager tests
* feat: 🎸 capture error if it happens during initial load
* fix: 🐛 register correctly CSV action
* feat: 🎸 don't show "OPTIONS" title on drilldown context menus
* feat: 🎸 add server-side for x-pack dashboard plugin
* feat: 🎸 disable Drilldowns for TSVB
* feat: 🎸 enable drilldowns on kibana.yml feature flag
* feat: 🎸 add feature flag comment to kibana.yml
* feat: 🎸 remove places from drilldown interface
* refactor: 💡 remove place in factory context
* chore: 🤖 remove doExecute
* remove not needed now error_configure_action component
* remove workaround for storybook
* feat: 🎸 improve DrilldownDefinition interface
* style: 💄 replace any by unknown
* chore: 🤖 remove any
* chore: 🤖 make isConfigValid return type a boolean
* refactor: 💡 move getDisplayName to factory, remove deprecated
* style: 💄 remove any
* feat: 🎸 improve ActionFactoryDefinition
* refactor: 💡 change visualize_embeddable params
* feat: 🎸 add dashboard dependency to dashboard_enhanced
* style: 💄 rename drilldown plugin life-cycle contracts
* refactor: 💡 do naming adjustments for dashboard drilldown
* fix: 🐛 fix Type error
* fix: 🐛 fix TypeScript type errors
* test: 💍 fix test after refactor
* refactor: 💡 rename context -> placeContext in React component
* chore: 🤖 remove setting from kibana.yml
* refactor: 💡 change return type of getAction as per review
* remove custom css per review
* refactor: 💡 rename drilldownCount to eventCount
* style: 💄 remove any
* refactor: 💡 change how uiActions are passed to vis embeddable
* style: 💄 remove unused import
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
2020-03-24 08:31:29 +01:00
Vadim Dalecky
405b0fa30c
chore: 🤖 hide Drilldowns in master ( #59698 )
2020-03-09 22:10:46 +01:00
Matthew Kime
74f9b448f7
Implement embeddable drilldown menu options ( #59232 )
...
* Implement embeddable drilldown menu options
2020-03-06 20:58:24 -06:00
Stacey Gammon
d2cbc59ad4
Further improve type checking for actions and triggers ( #58765 )
...
* wip
* review follow up
* make ACTION a prefix, not SUFFIX
* fix path
* add warnings about casting to ActionType
* Make context an object in examples, not a string
* require object context, which seems to fix the partial requirement in type and thus the type issue
* mistake
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-04 10:27:14 -05:00
Vadim Dalecky
120f03dc06
Add <FormCreateDrilldown> component ( #58335 )
...
* refactor: 💡 use .story for Storybook and standartize dir struct
* feat: 🎸 add <FlyoutFrame> component
* feat: 🎸 add <FlyoutCreateDrilldown> component
* refactor: 💡 improve FlyoutCreateDrilldownAction
* test: 💍 add <FlyoutFrame> tests
* docs: ✏️ add @todo for <DrilldownHelloBar>
* feat: 🎸 make name editable in <FormCreateDrilldown>
* test: 💍 add <FormCreateDrilldown> name field tests
* chore: 🤖 change drilldown translation keys
2020-02-25 18:02:25 +01:00
Vadim Dalecky
4cd809aa7d
Drilldown plugin ( #58097 )
...
* feat: 🎸 add <PanelOptionsMenu> component
* feat: 🎸 use presentational <PanelOptionsMenu> component
* feat: 🎸 create stubs for Drilldown components
* feat: 🎸 open new drilldown flyout from panel's context menu
* feat: 🎸 setup Drilldowns plugin in X-Pack
* feat: 🎸 add Storybook to drilldowns plugin
* refactor: 💡 move drilldown components to x-pack
* feat: 🎸 add stub action to open drilldown flyout
* feat: 🎸 add drilldowns plugin to translation index
* fix: 🐛 correct TypeScript type check
* fix: 🐛 use correct i18n namespace
* ci: 🎡 add drilldowns plugin to CODEOWNERS file
* fix: 🐛 revert back <PanelOptionsMenu> change
* fix: 🐛 type must not be empty
2020-02-20 21:59:29 +01:00
