* 🐛 Fix metric rescale
* 📸 Restored old snapshots
* 🐛 Extend the fix to all scenarios
* 📸 Refresh snapshots for new fix
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* 🐛 Add padding to the tick label to fit threshold markers
* 🐛 Better icon detection
* 🐛 Fix edge cases with no title or labels
* 📸 Update snapshots
* ✨ Add icon placement flag
* ✨ Sync padding computation with marker positioning
* 👌 Make disabled when no icon is selected
* ✨ First text on marker implementation
* 🐛 Fix some edge cases with auto positioning
* Update x-pack/plugins/lens/public/xy_visualization/xy_config_panel/threshold_panel.tsx
Co-authored-by: Michael Marcialis <michael@marcial.is>
* 🐛 Fix minor details
* 💄 Small tweak
* ✨ Reduce the padding if no icon is shown on the axis
* ✅ Fix broken unit tests
* 💄 Fix vertical text centering
* 🚨 Fix linting issue
* 🐛 Fix issue
* 💄 Reorder panel inputs
* 💄 Move styling to sass
* 👌 Address feedback
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Michael Marcialis <michael@marcial.is>
* ✨ Make threshold fit into view automatically
* 🐛 do not compute axis threshold extends if no threshold is present
* ✅ One more fix for 0-based extends and tests
* 📝 fix typo
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Update ESLint config to disallow usage of the any type
* Remove the any type usages from the expressions plugin
* Update plugins using expressions according to the updated public API
* structure changes
* tests & fix for sessionId
* share mocks in time_range_middleware
* make switchVisualization and selectSuggestion one reducer as it's very similar
* CR
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* 🐛 Add padding to the tick label to fit threshold markers
* 🐛 Better icon detection
* 🐛 Fix edge cases with no title or labels
* 📸 Update snapshots
* ✨ Add icon placement flag
* ✨ Sync padding computation with marker positioning
* 👌 Make disabled when no icon is selected
* 🐛 Fix some edge cases with auto positioning
* Update x-pack/plugins/lens/public/xy_visualization/xy_config_panel/threshold_panel.tsx
Co-authored-by: Michael Marcialis <michael@marcial.is>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Michael Marcialis <michael@marcial.is>
* 🐛 When dragging a threshold to another group carry also its styling
* ✅ Add functional test
* ✨ Make duplicate carry style too
* ✅ Add functional test for duplicate use case
* 🐛 Fix table duplication issue
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* 🐛 Cap threshold width to 1px in suggestions
* 🐛 Remove icons from previews
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Pie] Loads the no results screen if all slices have zero value
* Add a functional test
* Apply PR changes
* Display no results component if the chart metric has negative values
* Nits
* Apply some of the PR comments
* Change the negative values text
* Update src/plugins/vis_types/pie/public/pie_component.test.tsx
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
* Update src/plugins/vis_types/pie/public/pie_component.test.tsx
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
* Step 2: Update client code to use resolve() method instead of get()
Following sharing Saved Objects developer guide: Step 2
This step demonstrates the changes to update client code to use the new
SavedObjectsClient `resolve()` method instead of `get()`.
* Step 3 Lens
* [eslint] add rule to prevent export* in plugin index files
* deduplicate export names for types/instances with the same name
* attempt to auto-fix duplicate exports too
* capture exported enums too
* enforce no_export_all for core too
* disable rule by default, allow opting-in for help fixing
* update tests
* reduce yarn.lock duplication
* add rule but no fixes
* disable all existing violations
* update api docs with new line numbers
* revert unnecessary changes to yarn.lock which only had drawbacks
* remove unnecessary eslint-disable
* rework codegen to split type exports and use babel to generate valid code
* check for "export types" deeply
* improve test by using fixtures
* add comments to some helper functions
* disable fix for namespace exports including types
* label all eslint-disable comments with related team-specific issue
* ensure that child exports of `export type` are always tracked as types
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
