This PR updates the URL to the Elastic Support Portal registered by the
Cloud plugin, to include the configured deployment ID as a querystring
parameter.
1. On serverless deployments, we set the projects unique identifier with
`?serverless_project_id=123ABC`
2. On stateful cloud deployments, we set the deployment's unique
identifier with `?cloud_deployment_id=123ABC`
3. On on-prem deployments functionality shall remain unchanged.
Where this link can be found in the UI:
## Summary
Fix https://github.com/elastic/kibana/issues/161652
Add the `serverless.projectId` config setting to the `cloud` plugin, and
expose the `isCloudServerless` and `serverless.projectId` info from the
cloud plugin's API.
## Summary
Fix https://github.com/elastic/kibana/issues/138813
- decode the cloudId and expose the id components from the `cloud`
plugin's browser and server-side contracts
- remove the existing `decodeCloudId` helpers from the other plugins
- adapt the usages accordingly
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Fixes https://github.com/elastic/kibana/issues/149344
This PR migrates all plugins to packages automatically. It does this
using `node scripts/lint_packages` to automatically migrate
`kibana.json` files to `kibana.jsonc` files. By doing this automatically
we can simplify many build and testing procedures to only support
packages, and not both "packages" and "synthetic packages" (basically
pointers to plugins).
The majority of changes are in operations related code, so we'll be
having operations review this before marking it ready for review. The
vast majority of the code owners are simply pinged because we deleted
all `kibana.json` files and replaced them with `kibana.jsonc` files, so
we plan on leaving the PR ready-for-review for about 24 hours before
merging (after feature freeze), assuming we don't have any blockers
(especially from @elastic/kibana-core since there are a few core
specific changes, though the majority were handled in #149370).
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Dearest Reviewers 👋
I've been working on this branch with @mistic and @tylersmalley and
we're really confident in these changes. Additionally, this changes code
in nearly every package in the repo so we don't plan to wait for reviews
to get in before merging this. If you'd like to have a concern
addressed, please feel free to leave a review, but assuming that nobody
raises a blocker in the next 24 hours we plan to merge this EOD pacific
tomorrow, 12/22.
We'll be paying close attention to any issues this causes after merging
and work on getting those fixed ASAP. 🚀
---
The operations team is not confident that we'll have the time to achieve
what we originally set out to accomplish by moving to Bazel with the
time and resources we have available. We have also bought ourselves some
headroom with improvements to babel-register, optimizer caching, and
typescript project structure.
In order to make sure we deliver packages as quickly as possible (many
teams really want them), with a usable and familiar developer
experience, this PR removes Bazel for building packages in favor of
using the same JIT transpilation we use for plugins.
Additionally, packages now use `kbn_references` (again, just copying the
dx from plugins to packages).
Because of the complex relationships between packages/plugins and in
order to prepare ourselves for automatic dependency detection tools we
plan to use in the future, this PR also introduces a "TS Project Linter"
which will validate that every tsconfig.json file meets a few
requirements:
1. the chain of base config files extended by each config includes
`tsconfig.base.json` and not `tsconfig.json`
1. the `include` config is used, and not `files`
2. the `exclude` config includes `target/**/*`
3. the `outDir` compiler option is specified as `target/types`
1. none of these compiler options are specified: `declaration`,
`declarationMap`, `emitDeclarationOnly`, `skipLibCheck`, `target`,
`paths`
4. all references to other packages/plugins use their pkg id, ie:
```js
// valid
{
"kbn_references": ["@kbn/core"]
}
// not valid
{
"kbn_references": [{ "path": "../../../src/core/tsconfig.json" }]
}
```
5. only packages/plugins which are imported somewhere in the ts code are
listed in `kbn_references`
This linter is not only validating all of the tsconfig.json files, but
it also will fix these config files to deal with just about any
violation that can be produced. Just run `node scripts/ts_project_linter
--fix` locally to apply these fixes, or let CI take care of
automatically fixing things and pushing the changes to your PR.
> **Example:** [`64e93e5`
(#146212)](64e93e5806)
When I merged main into my PR it included a change which removed the
`@kbn/core-injected-metadata-browser` package. After resolving the
conflicts I missed a few tsconfig files which included references to the
now removed package. The TS Project Linter identified that these
references were removed from the code and pushed a change to the PR to
remove them from the tsconfig.json files.
## No bazel? Does that mean no packages??
Nope! We're still doing packages but we're pretty sure now that we won't
be using Bazel to accomplish the 'distributed caching' and 'change-based
tasks' portions of the packages project.
This PR actually makes packages much easier to work with and will be
followed up with the bundling benefits described by the original
packages RFC. Then we'll work on documentation and advocacy for using
packages for any and all new code.
We're pretty confident that implementing distributed caching and
change-based tasks will be necessary in the future, but because of
recent improvements in the repo we think we can live without them for
**at least** a year.
## Wait, there are still BUILD.bazel files in the repo
Yes, there are still three webpack bundles which are built by Bazel: the
`@kbn/ui-shared-deps-npm` DLL, `@kbn/ui-shared-deps-src` externals, and
the `@kbn/monaco` workers. These three webpack bundles are still created
during bootstrap and remotely cached using bazel. The next phase of this
project is to figure out how to get the package bundling features
described in the RFC with the current optimizer, and we expect these
bundles to go away then. Until then any package that is used in those
three bundles still needs to have a BUILD.bazel file so that they can be
referenced by the remaining webpack builds.
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
* Adding check to show/hide Avatar form based on whether the user is a cloud user or not
* Adding tests to verify the avatar doesnt show up in the UserProfile if the AuthorizedUser is a cloud user
* Changing the name of the link to 'Edit Profile' and making it available only for non-cloud users
* Adding/Updating unit tests and fixing translation files
* Removing unused values from FormattedText and related tests
* Updating unit test to work with merge from main
* Updating link to read Edit Profile to match wireframes per PR review
* Reverting changes to translation files and changing the cloud Edit Profile link and unit tests
* Changing capitalization of 'profile' so it follows the naming convention
* Changing nav menu logic to only render the default Edit Profile link if there is no custom Edit Profile link passed in by another plugin
* Updating logic to display custom nav links if user is a cloud user and related unit tests
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* chore(NA): eslint rule for disallowing naked eslint-disable
* chore(NA): export new rule and update docs
* chore(NA): creation of rule in ts
* chore(NA): new corrected rule in ts
* refact(NA): remove old logic from older plugin
* docs(NA): update documentation
* docs(NA): update documentation
* docs(NA): update documentation
* refact(NA): include edge cases for better locating errors
* chore(NA): changed regex name
* docs(NA): correct name rule on docs
* refact(NA): use dedent in the template literals
* refact(NA): check for undefined
* fix(NA): introduces support for eslint-disable-line
* chore(NA): fix extra space
* test(NA): created more test cases
* chore(NA): rename plugin to eslint-plugin-disable
* docs(NA): update nav and operations landing page ids for eslint rule
* test(NA): use messageIds on test
* chore(NA): complete naked eslint disables with specific rules
* chore(NA): specific rules for a few naked eslint disable
* chore(NA): add focused eslint disable on big reindex_operation_with_large_error_message.ts file
* chore(NA): changes according PR feedback
* chore(NA): include specific eslint rules on latest naked eslint disable
* chore(NA): missing eslint disable specific rule
* fix(NA): remove comment for js annotator
* chore(NA): re add eslint focused disable rule to x-pack/plugins/osquery/cypress/support/coverage.ts
* chore(NA): re add eslint focused disable rule to x-pack/plugins/osquery/cypress/support/coverage.ts
* chore(NA): re add eslint focused disable rule to x-pack/plugins/osquery/cypress/support/coverage.ts
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* added callout about reporting on cloud
* slight rewording
* added functionality to disbale screenshotting on <2GB cloud instances
* added test and fixed public facing API to throw an observable error instead of sync
* update reporting integration with new screenshotting error
* fix typo
* added specific error code to telemetry
* added positive test case
* updated mappings
* update jest test snapshots
* update snapshot
* fix use of deprecated RxJS
* [revert this] added some logs for cloud
* also check for deploymentId
* remove logs
* removed logger being passed to system check function
* remove unused import
* slight update to test
* added cloud min requirements link
* add link to UI
* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
* added todo comment
* read mem limit from cgroup files
* update jest
* tidy up and simplify some of the logic
* [revert this] test with 1024
* [revert this] added some logging again
* actually pass the cloud plugin to Screenshots 🤦
* [revert this] try and read instance data file instead
* Revert "[revert this] try and read instance data file instead"
This reverts commit ebdea2115d.
* Revert "[revert this] test with 1024"
This reverts commit 7ae3e3978e.
* Revert "[revert this] added some logging again"
This reverts commit d21e8080e1.
* use injected environment variable to read instance size
* implement copy feedback
* fix variable rename
* fix test
* fixed some copy
* fix test code
* remove unused i18n
* update snapshots
* minor tidying up
* tighten up the copy
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* fix a couple bugs in context management
add execution context to fullstory
* Update execution_context_service.ts
* stop and app name tests
* Use execution context in fullstory
* Fix user hash
Report org id to FS
* Use setUserVars for esorgid
* pass orgid into identify
* fix
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Global Nav] Moved Overview page/link to the accordion/Solution title
* Using Cloud logo for deployment link and fixing isActive state
* Change Deployment section to dark background
* Completely remove locking ability
* Change buttonElement if overview page exists
* Snaps from button/div
* PR Feedback:
- Puts `Overview` links back for Observability and Security
- Increases hit area and scopes underline of anchor tag within the accordion header
- Uses `id`’s to find Overview pages instead of `title` text
