mirror of
https://github.com/elastic/kibana.git
synced 2025-04-21 16:29:04 -04:00
9542 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Zacqary Adam Xeper
|
d5201bd757
|
[8.12] [RAM] Fix bug where select all rules bypasses filters (#176962) (#177096)
# Backport This will backport the following commits from `main` to `8.12`: - [[RAM] Fix bug where select all rules bypasses filters (#176962)](https://github.com/elastic/kibana/pull/176962) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Zacqary Adam Xeper","email":"Zacqary@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-02-15T18:30:08Z","message":"[RAM] Fix bug where select all rules bypasses filters (#176962)\n\n## Summary\r\n\r\nFixes #176867 \r\n\r\nA bug introduced in https://github.com/elastic/kibana/pull/174954\r\nbypassed most filters when using Select All on the Rules List. This was\r\nbecause the names of the filter properties changed, and no longer\r\nmatched what the `useBulkEditSelect` hook was expecting.\r\n\r\nBecause all of these types were optional, it didn't trigger any type\r\nerrors.\r\n\r\nThis syncs up the type definitions with the new filter store hook, and\r\nadds a functional test to make sure filters are working on bulk actions\r\nwhen clicking the select all button.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e136a9318215d5913a5e957aec5d9ad0b8132506","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.13.0","v8.12.2","v8.14.0"],"number":176962,"url":"https://github.com/elastic/kibana/pull/176962","mergeCommit":{"message":"[RAM] Fix bug where select all rules bypasses filters (#176962)\n\n## Summary\r\n\r\nFixes #176867 \r\n\r\nA bug introduced in https://github.com/elastic/kibana/pull/174954\r\nbypassed most filters when using Select All on the Rules List. This was\r\nbecause the names of the filter properties changed, and no longer\r\nmatched what the `useBulkEditSelect` hook was expecting.\r\n\r\nBecause all of these types were optional, it didn't trigger any type\r\nerrors.\r\n\r\nThis syncs up the type definitions with the new filter store hook, and\r\nadds a functional test to make sure filters are working on bulk actions\r\nwhen clicking the select all button.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e136a9318215d5913a5e957aec5d9ad0b8132506"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/177063","number":177063,"state":"MERGED","mergeCommit":{"sha":"4e45baaef0134a39c624b0bf770eb7b51a7725c9","message":"[8.13] [RAM] Fix bug where select all rules bypasses filters (#176962) (#177063)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.13`:\n- [[RAM] Fix bug where select all rules bypasses filters\n(#176962)](https://github.com/elastic/kibana/pull/176962)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Zacqary Adam\nXeper\",\"email\":\"Zacqary@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2024-02-15T18:30:08Z\",\"message\":\"[RAM]\nFix bug where select all rules bypasses filters (#176962)\\n\\n##\nSummary\\r\\n\\r\\nFixes #176867 \\r\\n\\r\\nA bug introduced in\nhttps://github.com/elastic/kibana/pull/174954\\r\\nbypassed most filters\nwhen using Select All on the Rules List. This was\\r\\nbecause the names\nof the filter properties changed, and no longer\\r\\nmatched what the\n`useBulkEditSelect` hook was expecting.\\r\\n\\r\\nBecause all of these\ntypes were optional, it didn't trigger any type\\r\\nerrors.\\r\\n\\r\\nThis\nsyncs up the type definitions with the new filter store hook,\nand\\r\\nadds a functional test to make sure filters are working on bulk\nactions\\r\\nwhen clicking the select all button.\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"e136a9318215d5913a5e957aec5d9ad0b8132506\",\"branchLabelMapping\":{\"^v8.14.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"Team:ResponseOps\",\"Feature:Alerting/RulesManagement\",\"v8.13.0\",\"v8.12.2\",\"v8.14.0\"],\"title\":\"[RAM]\nFix bug where select all rules bypasses\nfilters\",\"number\":176962,\"url\":\"https://github.com/elastic/kibana/pull/176962\",\"mergeCommit\":{\"message\":\"[RAM]\nFix bug where select all rules bypasses filters (#176962)\\n\\n##\nSummary\\r\\n\\r\\nFixes #176867 \\r\\n\\r\\nA bug introduced in\nhttps://github.com/elastic/kibana/pull/174954\\r\\nbypassed most filters\nwhen using Select All on the Rules List. This was\\r\\nbecause the names\nof the filter properties changed, and no longer\\r\\nmatched what the\n`useBulkEditSelect` hook was expecting.\\r\\n\\r\\nBecause all of these\ntypes were optional, it didn't trigger any type\\r\\nerrors.\\r\\n\\r\\nThis\nsyncs up the type definitions with the new filter store hook,\nand\\r\\nadds a functional test to make sure filters are working on bulk\nactions\\r\\nwhen clicking the select all button.\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"e136a9318215d5913a5e957aec5d9ad0b8132506\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.13\",\"8.12\"],\"targetPullRequestStates\":[{\"branch\":\"8.13\",\"label\":\"v8.13.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.12\",\"label\":\"v8.12.2\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.14.0\",\"branchLabelMappingKey\":\"^v8.14.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/176962\",\"number\":176962,\"mergeCommit\":{\"message\":\"[RAM]\nFix bug where select all rules bypasses filters (#176962)\\n\\n##\nSummary\\r\\n\\r\\nFixes #176867 \\r\\n\\r\\nA bug introduced in\nhttps://github.com/elastic/kibana/pull/174954\\r\\nbypassed most filters\nwhen using Select All on the Rules List. This was\\r\\nbecause the names\nof the filter properties changed, and no longer\\r\\nmatched what the\n`useBulkEditSelect` hook was expecting.\\r\\n\\r\\nBecause all of these\ntypes were optional, it didn't trigger any type\\r\\nerrors.\\r\\n\\r\\nThis\nsyncs up the type definitions with the new filter store hook,\nand\\r\\nadds a functional test to make sure filters are working on bulk\nactions\\r\\nwhen clicking the select all button.\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"e136a9318215d5913a5e957aec5d9ad0b8132506\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>"}},{"branch":"8.12","label":"v8.12.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176962","number":176962,"mergeCommit":{"message":"[RAM] Fix bug where select all rules bypasses filters (#176962)\n\n## Summary\r\n\r\nFixes #176867 \r\n\r\nA bug introduced in https://github.com/elastic/kibana/pull/174954\r\nbypassed most filters when using Select All on the Rules List. This was\r\nbecause the names of the filter properties changed, and no longer\r\nmatched what the `useBulkEditSelect` hook was expecting.\r\n\r\nBecause all of these types were optional, it didn't trigger any type\r\nerrors.\r\n\r\nThis syncs up the type definitions with the new filter store hook, and\r\nadds a functional test to make sure filters are working on bulk actions\r\nwhen clicking the select all button.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"e136a9318215d5913a5e957aec5d9ad0b8132506"}}]}] BACKPORT--> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> |
||
Kibana Machine
|
cecc6c884c | skip failing test suite (#178895) | ||
Jon
|
5fca02ae6f
|
[8.12] Skip tests failing on Chrome 121+ (#175740) (#178536)
#175740 --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> |
||
|
Kibana Machine
|
4f3971aa7e
|
[8.12] [Security Solution][Endpoint] Remove responder FTR test (#175454) (#177739)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution][Endpoint] Remove responder FTR test (#175454)](https://github.com/elastic/kibana/pull/175454) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-02-23T17:02:47Z","message":"[Security Solution][Endpoint] Remove responder FTR test (#175454)\n\n## Summary\r\n\r\nDelete responder test skipped in elastic/kibana/pull/170489.\r\nWe've cypress tests that cover the test cases here.\r\n\r\n### Flaky runner\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4937\r\nx 50 (...)\r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"db8440dc5b0d56bb147b6c629d9ea229ccf96fcf","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","OLM Sprint","v8.12.1","v8.13.0","v8.14.0"],"title":"[Security Solution][Endpoint] Remove responder FTR test","number":175454,"url":"https://github.com/elastic/kibana/pull/175454","mergeCommit":{"message":"[Security Solution][Endpoint] Remove responder FTR test (#175454)\n\n## Summary\r\n\r\nDelete responder test skipped in elastic/kibana/pull/170489.\r\nWe've cypress tests that cover the test cases here.\r\n\r\n### Flaky runner\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4937\r\nx 50 (...)\r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"db8440dc5b0d56bb147b6c629d9ea229ccf96fcf"}},"sourceBranch":"main","suggestedTargetBranches":["8.12","8.13"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175454","number":175454,"mergeCommit":{"message":"[Security Solution][Endpoint] Remove responder FTR test (#175454)\n\n## Summary\r\n\r\nDelete responder test skipped in elastic/kibana/pull/170489.\r\nWe've cypress tests that cover the test cases here.\r\n\r\n### Flaky runner\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4937\r\nx 50 (...)\r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"db8440dc5b0d56bb147b6c629d9ea229ccf96fcf"}}]}] BACKPORT--> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com> |
||
|
Jon
|
9c2b28eee9
|
[8.12] Upgrade Node.js to 18.19.1 (#177079)
#177042 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co> |
||
|
Kibana Machine
|
3d70becbe0
|
[8.12] [Infra] Fixing Derivative aggregation on kubernetes pods (#177295) (#177366)
# Backport This will backport the following commits from `main` to `8.12`: - [[Infra] Fixing Derivative aggregation on kubernetes pods (#177295)](https://github.com/elastic/kibana/pull/177295) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cauê Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-02-20T19:05:23Z","message":"[Infra] Fixing Derivative aggregation on kubernetes pods (#177295)\n\ncloses https://github.com/elastic/kibana/issues/177294\r\n\r\n<img width=\"398\" alt=\"Screenshot 2024-02-20 at 14 00 41\"\r\nsrc=\" |
||
Maxim Palenov
|
a687b96184
|
[8.12] [Security Solution] Fix not complete existing rule overwrite when importing rules (#176166) (#177270)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Fix not complete existing rule overwrite when importing rules (#176166)](https://github.com/elastic/kibana/pull/176166) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) |
||
|
Maxim Palenov
|
78cb16c595
|
[8.12] [Security Solution] Fix importing rules referencing preconfigured connectors (#176284) (#176887)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Fix importing rules referencing preconfigured connectors (#176284)](https://github.com/elastic/kibana/pull/176284) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2024-02-13T15:30:25Z","message":"[Security Solution] Fix importing rules referencing preconfigured connectors (#176284)\n\n**Fixes:** https://github.com/elastic/kibana/issues/157253\r\n\r\n## Summary\r\n\r\nThis PR fixes rules import with `overwrite_action_connectors` set to true when ndjson contains rules with actions referencing preconfigured action connectors.\r\n\r\n## Details\r\n\r\nA user can preconfigure action connectors as described [here](https://www.elastic.co/guide/en/kibana/current/pre-configured-connectors.html). At the same time Elastic Could instances have Elastic-cloud-SMTP connector preconfigured. In particular import doesn't work as expected in Elastic Cloud for rules having actions referencing the preconfigured Elastic-cloud-SMTP connector.\r\n\r\nThis is fixed by filtering out preconfigured connector ids so importing logic only handles custom action connectors.\r\n\r\nOn top of this functional tests have been added to make sure the problem won't come back.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios\r\n- [x] [Ran](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5139) in Flaky test runner for ESS and Serverless and no flakiness has been revealed","sha":"934a06ccf7c599685e04469ff0801e461ee9c2d5","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","impact:medium","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Actions","Team:Detection Rule Management","Feature:Rule Import/Export","v8.13.0","v8.12.2"],"number":176284,"url":"https://github.com/elastic/kibana/pull/176284","mergeCommit":{"message":"[Security Solution] Fix importing rules referencing preconfigured connectors (#176284)\n\n**Fixes:** https://github.com/elastic/kibana/issues/157253\r\n\r\n## Summary\r\n\r\nThis PR fixes rules import with `overwrite_action_connectors` set to true when ndjson contains rules with actions referencing preconfigured action connectors.\r\n\r\n## Details\r\n\r\nA user can preconfigure action connectors as described [here](https://www.elastic.co/guide/en/kibana/current/pre-configured-connectors.html). At the same time Elastic Could instances have Elastic-cloud-SMTP connector preconfigured. In particular import doesn't work as expected in Elastic Cloud for rules having actions referencing the preconfigured Elastic-cloud-SMTP connector.\r\n\r\nThis is fixed by filtering out preconfigured connector ids so importing logic only handles custom action connectors.\r\n\r\nOn top of this functional tests have been added to make sure the problem won't come back.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios\r\n- [x] [Ran](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5139) in Flaky test runner for ESS and Serverless and no flakiness has been revealed","sha":"934a06ccf7c599685e04469ff0801e461ee9c2d5"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176284","number":176284,"mergeCommit":{"message":"[Security Solution] Fix importing rules referencing preconfigured connectors (#176284)\n\n**Fixes:** https://github.com/elastic/kibana/issues/157253\r\n\r\n## Summary\r\n\r\nThis PR fixes rules import with `overwrite_action_connectors` set to true when ndjson contains rules with actions referencing preconfigured action connectors.\r\n\r\n## Details\r\n\r\nA user can preconfigure action connectors as described [here](https://www.elastic.co/guide/en/kibana/current/pre-configured-connectors.html). At the same time Elastic Could instances have Elastic-cloud-SMTP connector preconfigured. In particular import doesn't work as expected in Elastic Cloud for rules having actions referencing the preconfigured Elastic-cloud-SMTP connector.\r\n\r\nThis is fixed by filtering out preconfigured connector ids so importing logic only handles custom action connectors.\r\n\r\nOn top of this functional tests have been added to make sure the problem won't come back.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios\r\n- [x] [Ran](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5139) in Flaky test runner for ESS and Serverless and no flakiness has been revealed","sha":"934a06ccf7c599685e04469ff0801e461ee9c2d5"}},{"branch":"8.12","label":"v8.12.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
|
Maxim Palenov
|
fd2f4ee908
|
[8.12] [Security Solution] Fix losing data upon prebuilt rule upgrade to a new version in which the rule's type is different (#176421) (#176811)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Fix losing data upon prebuilt rule upgrade to a new version in which the rule's type is different (#176421)](https://github.com/elastic/kibana/pull/176421) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2024-02-12T13:09:23Z","message":"[Security Solution] Fix losing data upon prebuilt rule upgrade to a new version in which the rule's type is different (#176421)\n\n**Fixes:** https://github.com/elastic/kibana/issues/169480\r\n\r\n## Summary\r\n\r\nThis PR fixes losing the following rule data upon prebuilt rule upgrade to a new version in which the rule's type is different\r\n\r\n- Saved Object id\r\n- exceptions list (default and shared)\r\n- Timeline id\r\n- Timeline title\r\n\r\n## Details\r\n\r\nThe problem occurs when user upgrades a prebuilt rule to a newer version which has a different rule type.\r\n\r\nChecking the code it's not so hard to find [`upgradeRule()`](https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/rule_objects/upgrade_prebuilt_rules.ts#L49) function which performs prebuilt rule upgrade. It has the following comment\r\n\r\n> If we're trying to change the type of a prepackaged rule, we need to delete the old one and replace it with the new rule, keeping the enabled setting, actions, throttle, id, and exception lists from the old rule.\r\n\r\nLooking below in the code it's clear that only enabled state and actions get restored upon rule upgrade. Missing to restore `exceptions lists` leads to disappearing exceptions upon rule upgrade.\r\n\r\nOn top of this `execution results` and `execution events` also get lost due to missing to restore saved object `id`. Execution log isn't gone anywhere but can't be bound to a new id. Direct links to rule details page won't work neither after upgrade.\r\n\r\nThis PR fixes the problem by restoring rule bound data after upgrade.\r\n\r\nFTR tests were restructured to accommodate extra tests to cover this bug fix. \r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios","sha":"ffdcc34d0d4f05aad8ad979775e8b0f503af313d","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","impact:high","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","v8.13.0","v8.12.2"],"number":176421,"url":"https://github.com/elastic/kibana/pull/176421","mergeCommit":{"message":"[Security Solution] Fix losing data upon prebuilt rule upgrade to a new version in which the rule's type is different (#176421)\n\n**Fixes:** https://github.com/elastic/kibana/issues/169480\r\n\r\n## Summary\r\n\r\nThis PR fixes losing the following rule data upon prebuilt rule upgrade to a new version in which the rule's type is different\r\n\r\n- Saved Object id\r\n- exceptions list (default and shared)\r\n- Timeline id\r\n- Timeline title\r\n\r\n## Details\r\n\r\nThe problem occurs when user upgrades a prebuilt rule to a newer version which has a different rule type.\r\n\r\nChecking the code it's not so hard to find [`upgradeRule()`](https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/rule_objects/upgrade_prebuilt_rules.ts#L49) function which performs prebuilt rule upgrade. It has the following comment\r\n\r\n> If we're trying to change the type of a prepackaged rule, we need to delete the old one and replace it with the new rule, keeping the enabled setting, actions, throttle, id, and exception lists from the old rule.\r\n\r\nLooking below in the code it's clear that only enabled state and actions get restored upon rule upgrade. Missing to restore `exceptions lists` leads to disappearing exceptions upon rule upgrade.\r\n\r\nOn top of this `execution results` and `execution events` also get lost due to missing to restore saved object `id`. Execution log isn't gone anywhere but can't be bound to a new id. Direct links to rule details page won't work neither after upgrade.\r\n\r\nThis PR fixes the problem by restoring rule bound data after upgrade.\r\n\r\nFTR tests were restructured to accommodate extra tests to cover this bug fix. \r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios","sha":"ffdcc34d0d4f05aad8ad979775e8b0f503af313d"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176421","number":176421,"mergeCommit":{"message":"[Security Solution] Fix losing data upon prebuilt rule upgrade to a new version in which the rule's type is different (#176421)\n\n**Fixes:** https://github.com/elastic/kibana/issues/169480\r\n\r\n## Summary\r\n\r\nThis PR fixes losing the following rule data upon prebuilt rule upgrade to a new version in which the rule's type is different\r\n\r\n- Saved Object id\r\n- exceptions list (default and shared)\r\n- Timeline id\r\n- Timeline title\r\n\r\n## Details\r\n\r\nThe problem occurs when user upgrades a prebuilt rule to a newer version which has a different rule type.\r\n\r\nChecking the code it's not so hard to find [`upgradeRule()`](https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/logic/rule_objects/upgrade_prebuilt_rules.ts#L49) function which performs prebuilt rule upgrade. It has the following comment\r\n\r\n> If we're trying to change the type of a prepackaged rule, we need to delete the old one and replace it with the new rule, keeping the enabled setting, actions, throttle, id, and exception lists from the old rule.\r\n\r\nLooking below in the code it's clear that only enabled state and actions get restored upon rule upgrade. Missing to restore `exceptions lists` leads to disappearing exceptions upon rule upgrade.\r\n\r\nOn top of this `execution results` and `execution events` also get lost due to missing to restore saved object `id`. Execution log isn't gone anywhere but can't be bound to a new id. Direct links to rule details page won't work neither after upgrade.\r\n\r\nThis PR fixes the problem by restoring rule bound data after upgrade.\r\n\r\nFTR tests were restructured to accommodate extra tests to cover this bug fix. \r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios","sha":"ffdcc34d0d4f05aad8ad979775e8b0f503af313d"}},{"branch":"8.12","label":"v8.12.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
|
Kibana Machine
|
c5a102b02b
|
[8.12] [Security Solution] Improve logging for FTR test `retry` function (#176316) (#176497)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Improve logging for FTR test `retry` function (#176316)](https://github.com/elastic/kibana/pull/176316) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"jpdjeredjian@gmail.com"},"sourceCommit":{"committedDate":"2024-02-08T12:35:54Z","message":"[Security Solution] Improve logging for FTR test `retry` function (#176316)\n\n## Summary\r\n\r\n**Fixes:** \r\n- https://github.com/elastic/kibana/issues/175481\r\n- https://github.com/elastic/kibana/issues/175250\r\n\r\n\r\n### Description\r\n\r\nImproves logging for the `retry` FTR integration testing utility that is\r\nused to wrap helpers that make endpoint calls or direct Elasticsearch\r\noperations.\r\n\r\nThe previous logging would only explain that the maximum amount of\r\nretries had been reached, with the actual error caused in the test being\r\nlost, which proved hard to debug.\r\n\r\nThese changes catches the error and log it, allowing us to understand\r\nwhy a retried test failed.\r\n\r\nError now reported as:\r\n\r\n```\r\n[00:00:19] │ERROR Retrying installPrebuiltRulesPackageByVersion: Error: expected 500 \"Internal Server Error\", got 200 \"OK\"\r\n[00:00:19] │ debg --- retry.tryForTime failed again with the same message...\r\n[00:00:19] │ERROR Reached maximum number of retries for test: 2/2\r\n[00:00:19] └- ✖ fail: Rules Management - Prebuilt Rules - Update Prebuilt Rules Package @ess @serverless @skipInQA update_prebuilt_rules_package should allow user to install prebuilt rules from scratch, then install new rules and upgrade existing rules from the new package\r\n[00:00:19] │ Error: \"Reached maximum number of retries for test: 2/2\"\r\n[00:00:19] │ at block (retry.ts:72:16)\r\n[00:00:19] │ at runAttempt (retry_for_success.ts:29:21)\r\n[00:00:19] │ at retryForSuccess (retry_for_success.ts:79:27)\r\n[00:00:19] │ at RetryService.tryForTime (retry.ts:23:12)\r\n[00:00:19] │ at retry (retry.ts:62:20)\r\n[00:00:19] │ at installPrebuiltRulesPackageByVersion (install_fleet_package_by_url.ts:77:25)\r\n[00:00:19] │ at Context.<anonymous> (update_prebuilt_rules_package.ts:106:46)\r\n[00:00:19] │ at Object.apply (wrap_function.js:73:16)\r\n```\r\nMain error is still `\"Reached maximum number of retries for test: 2/2\"`,\r\nbut now additional logging of exactly **what failed in the test** is\r\nerror-logged as seen above: `ERROR Retrying\r\ninstallPrebuiltRulesPackageByVersion: Error: expected 500 \"Internal\r\nServer Error\", got 200 \"OK\"`\r\n\r\n**Flaky test run:** \r\n- Shared 50 and 50:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5068\r\n- Ess 100 runs:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5091\r\n- Serverless 100 runs:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5092\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"479a022bd3a8ae79ca9af1eb12a90a26cb53efdf","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","v8.13.0","v8.12.2"],"title":"[Security Solution] Improve logging for FTR test `retry` function","number":176316,"url":"https://github.com/elastic/kibana/pull/176316","mergeCommit":{"message":"[Security Solution] Improve logging for FTR test `retry` function (#176316)\n\n## Summary\r\n\r\n**Fixes:** \r\n- https://github.com/elastic/kibana/issues/175481\r\n- https://github.com/elastic/kibana/issues/175250\r\n\r\n\r\n### Description\r\n\r\nImproves logging for the `retry` FTR integration testing utility that is\r\nused to wrap helpers that make endpoint calls or direct Elasticsearch\r\noperations.\r\n\r\nThe previous logging would only explain that the maximum amount of\r\nretries had been reached, with the actual error caused in the test being\r\nlost, which proved hard to debug.\r\n\r\nThese changes catches the error and log it, allowing us to understand\r\nwhy a retried test failed.\r\n\r\nError now reported as:\r\n\r\n```\r\n[00:00:19] │ERROR Retrying installPrebuiltRulesPackageByVersion: Error: expected 500 \"Internal Server Error\", got 200 \"OK\"\r\n[00:00:19] │ debg --- retry.tryForTime failed again with the same message...\r\n[00:00:19] │ERROR Reached maximum number of retries for test: 2/2\r\n[00:00:19] └- ✖ fail: Rules Management - Prebuilt Rules - Update Prebuilt Rules Package @ess @serverless @skipInQA update_prebuilt_rules_package should allow user to install prebuilt rules from scratch, then install new rules and upgrade existing rules from the new package\r\n[00:00:19] │ Error: \"Reached maximum number of retries for test: 2/2\"\r\n[00:00:19] │ at block (retry.ts:72:16)\r\n[00:00:19] │ at runAttempt (retry_for_success.ts:29:21)\r\n[00:00:19] │ at retryForSuccess (retry_for_success.ts:79:27)\r\n[00:00:19] │ at RetryService.tryForTime (retry.ts:23:12)\r\n[00:00:19] │ at retry (retry.ts:62:20)\r\n[00:00:19] │ at installPrebuiltRulesPackageByVersion (install_fleet_package_by_url.ts:77:25)\r\n[00:00:19] │ at Context.<anonymous> (update_prebuilt_rules_package.ts:106:46)\r\n[00:00:19] │ at Object.apply (wrap_function.js:73:16)\r\n```\r\nMain error is still `\"Reached maximum number of retries for test: 2/2\"`,\r\nbut now additional logging of exactly **what failed in the test** is\r\nerror-logged as seen above: `ERROR Retrying\r\ninstallPrebuiltRulesPackageByVersion: Error: expected 500 \"Internal\r\nServer Error\", got 200 \"OK\"`\r\n\r\n**Flaky test run:** \r\n- Shared 50 and 50:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5068\r\n- Ess 100 runs:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5091\r\n- Serverless 100 runs:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5092\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"479a022bd3a8ae79ca9af1eb12a90a26cb53efdf"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176316","number":176316,"mergeCommit":{"message":"[Security Solution] Improve logging for FTR test `retry` function (#176316)\n\n## Summary\r\n\r\n**Fixes:** \r\n- https://github.com/elastic/kibana/issues/175481\r\n- https://github.com/elastic/kibana/issues/175250\r\n\r\n\r\n### Description\r\n\r\nImproves logging for the `retry` FTR integration testing utility that is\r\nused to wrap helpers that make endpoint calls or direct Elasticsearch\r\noperations.\r\n\r\nThe previous logging would only explain that the maximum amount of\r\nretries had been reached, with the actual error caused in the test being\r\nlost, which proved hard to debug.\r\n\r\nThese changes catches the error and log it, allowing us to understand\r\nwhy a retried test failed.\r\n\r\nError now reported as:\r\n\r\n```\r\n[00:00:19] │ERROR Retrying installPrebuiltRulesPackageByVersion: Error: expected 500 \"Internal Server Error\", got 200 \"OK\"\r\n[00:00:19] │ debg --- retry.tryForTime failed again with the same message...\r\n[00:00:19] │ERROR Reached maximum number of retries for test: 2/2\r\n[00:00:19] └- ✖ fail: Rules Management - Prebuilt Rules - Update Prebuilt Rules Package @ess @serverless @skipInQA update_prebuilt_rules_package should allow user to install prebuilt rules from scratch, then install new rules and upgrade existing rules from the new package\r\n[00:00:19] │ Error: \"Reached maximum number of retries for test: 2/2\"\r\n[00:00:19] │ at block (retry.ts:72:16)\r\n[00:00:19] │ at runAttempt (retry_for_success.ts:29:21)\r\n[00:00:19] │ at retryForSuccess (retry_for_success.ts:79:27)\r\n[00:00:19] │ at RetryService.tryForTime (retry.ts:23:12)\r\n[00:00:19] │ at retry (retry.ts:62:20)\r\n[00:00:19] │ at installPrebuiltRulesPackageByVersion (install_fleet_package_by_url.ts:77:25)\r\n[00:00:19] │ at Context.<anonymous> (update_prebuilt_rules_package.ts:106:46)\r\n[00:00:19] │ at Object.apply (wrap_function.js:73:16)\r\n```\r\nMain error is still `\"Reached maximum number of retries for test: 2/2\"`,\r\nbut now additional logging of exactly **what failed in the test** is\r\nerror-logged as seen above: `ERROR Retrying\r\ninstallPrebuiltRulesPackageByVersion: Error: expected 500 \"Internal\r\nServer Error\", got 200 \"OK\"`\r\n\r\n**Flaky test run:** \r\n- Shared 50 and 50:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5068\r\n- Ess 100 runs:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5091\r\n- Serverless 100 runs:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5092\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"479a022bd3a8ae79ca9af1eb12a90a26cb53efdf"}},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Juan Pablo Djeredjian <jpdjeredjian@gmail.com> |
||
|
Kibana Machine
|
7e6bb7d9e6
|
[8.12] [RAM][BUG] Fix bug where bulk untrack wasn't removing alerts from task runner (#176268) (#176438)
# Backport This will backport the following commits from `main` to `8.12`: - [[RAM][BUG] Fix bug where bulk untrack wasn't removing alerts from task runner (#176268)](https://github.com/elastic/kibana/pull/176268) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jiawei Wu","email":"74562234+JiaweiWu@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-02-07T18:59:35Z","message":"[RAM][BUG] Fix bug where bulk untrack wasn't removing alerts from task runner (#176268)\n\n## Summary\r\n\r\nResolves: https://github.com/elastic/kibana/issues/176267\r\n\r\nFixes a bug where we were not removing untracked alerts from the task\r\nrunner. This is because the `es.client.search` query we used was not\r\ncorrect.\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fb30f37afca46b4abbd8ce12174c1e46c0272500","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.12.0","v8.13.0"],"title":"[RAM][BUG] Fix bug where bulk untrack wasn't removing alerts from task runner","number":176268,"url":"https://github.com/elastic/kibana/pull/176268","mergeCommit":{"message":"[RAM][BUG] Fix bug where bulk untrack wasn't removing alerts from task runner (#176268)\n\n## Summary\r\n\r\nResolves: https://github.com/elastic/kibana/issues/176267\r\n\r\nFixes a bug where we were not removing untracked alerts from the task\r\nrunner. This is because the `es.client.search` query we used was not\r\ncorrect.\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fb30f37afca46b4abbd8ce12174c1e46c0272500"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176268","number":176268,"mergeCommit":{"message":"[RAM][BUG] Fix bug where bulk untrack wasn't removing alerts from task runner (#176268)\n\n## Summary\r\n\r\nResolves: https://github.com/elastic/kibana/issues/176267\r\n\r\nFixes a bug where we were not removing untracked alerts from the task\r\nrunner. This is because the `es.client.search` query we used was not\r\ncorrect.\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fb30f37afca46b4abbd8ce12174c1e46c0272500"}}]}] BACKPORT--> Co-authored-by: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com> |
||
Mykola Harmash
|
aa102263c2
|
[8.12] [Profiling,Infra,APM] Disable Profiling integration by default (#175201) (#176406)
# Backport This will backport the following commits from `main` to `8.12`: - [[Profiling,Infra,APM] Disable Profiling integration by default (#175201)](https://github.com/elastic/kibana/pull/175201) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2024-01-24T11:44:26Z","message":"[Profiling,Infra,APM] Disable Profiling integration by default (#175201)\n\nCloses https://github.com/elastic/kibana/issues/175016\r\n\r\n## Summary\r\n\r\nThis PR disables the Profiling integration in Infra and APM by default\r\non the plugin configuration level because this integration require users\r\nto first configure the main `profiling` plugin. On-prem users will have\r\nto manually enable both integrations once they enabled the Universal\r\nProfiling for their hosts. Cloud users will have Infra and APM\r\nintegrations enabled by default because on Cloud instances Universal\r\nProfiling is already configured. A PR for the default Cloud settings\r\nwill follow after this one is merged.\r\n\r\nChanges I've made:\r\n* Disabled the Infra integration be default\r\n* Introduced a new APM feature flag for the Profiling integration\r\n* Made sure all the places in APM that rely on Profiling integration\r\nrespect the new feature flag\r\n* Fixed a bug in APM when Universal Profiling was shown even though the\r\nintegration was disabled in UI settings\r\n\r\n\r\n |
||
|
Kibana Machine
|
0be4e96091
|
[8.12] [Exceptions][Value Lists] Add file type and size constraints to value list uploads (#8507) (#176074) (#176375)
# Backport This will backport the following commits from `main` to `8.12`: - [[Exceptions][Value Lists] Add file type and size constraints to value list uploads (#8507) (#176074)](https://github.com/elastic/kibana/pull/176074) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2024-02-07T09:22:19Z","message":"[Exceptions][Value Lists] Add file type and size constraints to value list uploads (#8507) (#176074)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/security-team/issues/8507\r\n\r\nWith these changes we address the issue where users can upload any file\r\nto be imported as a value list.\r\n\r\nThe restrictions are:\r\n* Users should be limited to uploading .txt or .csv. All other file\r\ntypes should return a 415.\r\n* Users should be limited to uploading files of 9K bytes size. Files\r\nlarger than that should return a 413.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ESS 97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5019)\r\n- [Serverless 97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5020)","sha":"c38410affe0bccd61884b58a41b7bda48c78d86f","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team: SecuritySolution","Team:Detection Engine","8.13 candidate","v8.13.0","v8.12.2","v7.17.19"],"title":"[Exceptions][Value Lists] Add file type and size constraints to value list uploads (#8507)","number":176074,"url":"https://github.com/elastic/kibana/pull/176074","mergeCommit":{"message":"[Exceptions][Value Lists] Add file type and size constraints to value list uploads (#8507) (#176074)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/security-team/issues/8507\r\n\r\nWith these changes we address the issue where users can upload any file\r\nto be imported as a value list.\r\n\r\nThe restrictions are:\r\n* Users should be limited to uploading .txt or .csv. All other file\r\ntypes should return a 415.\r\n* Users should be limited to uploading files of 9K bytes size. Files\r\nlarger than that should return a 413.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ESS 97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5019)\r\n- [Serverless 97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5020)","sha":"c38410affe0bccd61884b58a41b7bda48c78d86f"}},"sourceBranch":"main","suggestedTargetBranches":["8.12","7.17"],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176074","number":176074,"mergeCommit":{"message":"[Exceptions][Value Lists] Add file type and size constraints to value list uploads (#8507) (#176074)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/security-team/issues/8507\r\n\r\nWith these changes we address the issue where users can upload any file\r\nto be imported as a value list.\r\n\r\nThe restrictions are:\r\n* Users should be limited to uploading .txt or .csv. All other file\r\ntypes should return a 415.\r\n* Users should be limited to uploading files of 9K bytes size. Files\r\nlarger than that should return a 413.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ESS 97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5019)\r\n- [Serverless 97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5020)","sha":"c38410affe0bccd61884b58a41b7bda48c78d86f"}},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.19","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co> |
||
|
Kibana Machine
|
a94310fc91
|
[8.12] [Fleet] Fix assets being unintentionally moved to the default space during Fleet setup (#176173) (#176250)
# Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Fix assets being unintentionally moved to the default space during Fleet setup (#176173)](https://github.com/elastic/kibana/pull/176173) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyle Pollich","email":"kyle.pollich@elastic.co"},"sourceCommit":{"committedDate":"2024-02-05T18:55:49Z","message":"[Fleet] Fix assets being unintentionally moved to the default space during Fleet setup (#176173)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/175173\r\n\r\nUse a scoped SO client when importing assets to prevent always importing\r\nassets into the default space during Fleet setup.\r\n\r\n## To do\r\n\r\nAdd tests?\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"c07ee4ad0f9ca0912d88d4cccf85474f1811e8dc","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.13.0"],"title":"[Fleet] Fix assets being unintentionally moved to the default space during Fleet setup","number":176173,"url":"https://github.com/elastic/kibana/pull/176173","mergeCommit":{"message":"[Fleet] Fix assets being unintentionally moved to the default space during Fleet setup (#176173)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/175173\r\n\r\nUse a scoped SO client when importing assets to prevent always importing\r\nassets into the default space during Fleet setup.\r\n\r\n## To do\r\n\r\nAdd tests?\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"c07ee4ad0f9ca0912d88d4cccf85474f1811e8dc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176173","number":176173,"mergeCommit":{"message":"[Fleet] Fix assets being unintentionally moved to the default space during Fleet setup (#176173)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/175173\r\n\r\nUse a scoped SO client when importing assets to prevent always importing\r\nassets into the default space during Fleet setup.\r\n\r\n## To do\r\n\r\nAdd tests?\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"c07ee4ad0f9ca0912d88d4cccf85474f1811e8dc"}}]}] BACKPORT--> Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co> |
||
|
Kibana Machine
|
0e7f0277d8
|
[8.12] Updates test file wrapper to deterministically detect file write completion (#176115) (#176161)
# Backport This will backport the following commits from `main` to `8.12`: - [Updates test file wrapper to deterministically detect file write completion (#176115)](https://github.com/elastic/kibana/pull/176115) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2024-02-02T14:57:37Z","message":"Updates test file wrapper to deterministically detect file write completion (#176115)\n\nCloses #119267\r\n\r\n## Summary\r\n\r\nAttempts to deterministically detect when a file is written in entirety\r\nin order to resolve flaky test issues where parsed JSON is incomplete.\r\n\r\nFlaky Test Runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5015","sha":"f9125ba079aeaa31fcd07e442cf6789c344452ec","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport:all-open","v8.13.0"],"title":"Updates test file wrapper to deterministically detect file write completion","number":176115,"url":"https://github.com/elastic/kibana/pull/176115","mergeCommit":{"message":"Updates test file wrapper to deterministically detect file write completion (#176115)\n\nCloses #119267\r\n\r\n## Summary\r\n\r\nAttempts to deterministically detect when a file is written in entirety\r\nin order to resolve flaky test issues where parsed JSON is incomplete.\r\n\r\nFlaky Test Runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5015","sha":"f9125ba079aeaa31fcd07e442cf6789c344452ec"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176115","number":176115,"mergeCommit":{"message":"Updates test file wrapper to deterministically detect file write completion (#176115)\n\nCloses #119267\r\n\r\n## Summary\r\n\r\nAttempts to deterministically detect when a file is written in entirety\r\nin order to resolve flaky test issues where parsed JSON is incomplete.\r\n\r\nFlaky Test Runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5015","sha":"f9125ba079aeaa31fcd07e442cf6789c344452ec"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co> |
||
Cristina Amico
|
ad6180df31
|
[8.12] [Fleet] Prevent deletion of agent policies with inactive agents from UI (#175815) (#176131)
# Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Prevent deletion of agent policies with inactive agents from UI (#175815)](https://github.com/elastic/kibana/pull/175815) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cristina Amico","email":"criamico@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-02-01T20:25:45Z","message":"[Fleet] Prevent deletion of agent policies with inactive agents from UI (#175815)\n\nFixes https://github.com/elastic/kibana/issues/155925\r\n\r\n## Summary\r\nPrevent deleting an agent policy that has inactive agents assigned. The\r\nworkaround to fix existing \"orphaned\" agents is outlined\r\n[here](https://github.com/elastic/kibana/issues/155925#issuecomment-1919250162).\r\n\r\n### API\r\nAdding check for inactive agents to the agent policy \"delete\" endpoint -\r\nIt will now fail if the policy has either active or inactive agents:\r\n\r\n```\r\n POST /api/fleet/agent_policies/delete\r\n {\r\n agentPolicyId: 1234534,\r\n }\r\n```\r\n\r\n### UI \r\nWarning added to the \"delete\" action in the UI when trying to delete a\r\npolicy that has active or inactive agents.\r\n\r\n## Testing\r\n- Have a policy with many inactive agents assigned to it\r\n- Try to delete it from the agent policy list or settings\r\n- The deletion is prevented and a warning is raised:\r\n\r\n (#176083)
# Backport This will backport the following commits from `main` to `8.12`: - [Add docs for SentinelOne connector (#174696)](https://github.com/elastic/kibana/pull/174696) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"contact@patrykkopycinski.com"},"sourceCommit":{"committedDate":"2024-02-01T17:15:26Z","message":"Add docs for SentinelOne connector (#174696)\n\n## Summary\r\n\r\nAdd docs for SentinelOne connector\r\n\r\n---------\r\n\r\nCo-authored-by: Joe Peeples <joe.peeples@elastic.co>\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: lcawl <lcawley@elastic.co>","sha":"04004ddaaccb672ae446bcf2ac4e43958f5f5194","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","Feature:Actions/ConnectorTypes","v8.12.0","v8.13.0"],"title":"Add docs for SentinelOne connector","number":174696,"url":"https://github.com/elastic/kibana/pull/174696","mergeCommit":{"message":"Add docs for SentinelOne connector (#174696)\n\n## Summary\r\n\r\nAdd docs for SentinelOne connector\r\n\r\n---------\r\n\r\nCo-authored-by: Joe Peeples <joe.peeples@elastic.co>\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: lcawl <lcawley@elastic.co>","sha":"04004ddaaccb672ae446bcf2ac4e43958f5f5194"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174696","number":174696,"mergeCommit":{"message":"Add docs for SentinelOne connector (#174696)\n\n## Summary\r\n\r\nAdd docs for SentinelOne connector\r\n\r\n---------\r\n\r\nCo-authored-by: Joe Peeples <joe.peeples@elastic.co>\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: lcawl <lcawley@elastic.co>","sha":"04004ddaaccb672ae446bcf2ac4e43958f5f5194"}}]}] BACKPORT--> Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com> |
||
|
Kibana Machine
|
fad58a5c11 | skip failing test suite (#168105) | ||
Tiago Costa
|
b9d678c7b3
|
skip flaky suite (#164224) | ||
Julia Bardi
|
92960c4694
|
[8.12][Fleet] fix API not allowing to upgrade to a newer version when version differs only in patch (#175765)
Fixes https://github.com/elastic/kibana/issues/175766 [8.12][Fleet] Partial backport of https://github.com/elastic/kibana/pull/175198 To verify: - add a fleet-server version 8.12.0 - enroll an agent version 8.12.0-SNAPSHOT - take the agent id and in console run this API request ``` POST kbn:/api/fleet/agents/6a56f865-a611-4921-9f24-87757259223e/upgrade { "version": "8.12.1-SNAPSHOT" } ``` - verify that the API returns 200 Relates https://github.com/elastic/kibana/issues/168502 |
||
Nikita Indik
|
fb72093bdd
|
[8.12] [Security Solution] Unskip bulk actions integration tests (#174757) (#175732)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Unskip bulk actions integration tests (#174757)](https://github.com/elastic/kibana/pull/174757) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2024-01-26T17:33:09Z","message":"[Security Solution] Unskip bulk actions integration tests (#174757)\n\n**Resolves: #173804** \r\n\r\n500 runs of the flaky test file in ESS env: [Buildkite\r\n4833](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4833)\r\n\r\n## Summary\r\nEven though I couldn't reproduce flakiness (1.5K runs), I've updated the\r\ntest to fix a suspected race condition.\r\n\r\nWhat seems to be happening:\r\nIn the `beforeEach`\r\n[here]( |
||
|
Kibana Machine
|
0217287eaf
|
[8.12] [Security Solution] "Data view" selector is shown in "Edit filter" view on the Rule Editing page (#174026) (#174922) (#175433)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] "Data view" selector is shown in "Edit filter" view on the Rule Editing page (#174026) (#174922)](https://github.com/elastic/kibana/pull/174922) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2024-01-24T13:34:54Z","message":"[Security Solution] \"Data view\" selector is shown in \"Edit filter\" view on the Rule Editing page (#174026) (#174922)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/174026\r\n\r\nThese changes fix the issue with filter editing on the rule's editing\r\npage when using index patterns instead of data view.\r\n\r\n**Steps to reproduce**:\r\n1. Create a custom query rule and add a filter\r\n2. Save the rule\r\n3. Edit the rule\r\n4. Edit the filter\r\n\r\n**Current behaviour**:\r\nRight now when user tries to edit the filter the data view picking UI\r\nappears even though index patterns were not modified.\r\n\r\n<img width=\"1261\" alt=\"Screenshot 2024-01-16 at 15 14 23\"\r\nsrc=\" |
||
|
Kibana Machine
|
5d4d35607b
|
[8.12] [Fleet] Update Fleet's custom ingest pipeline names to avoid collisions + add descriptions to each pipeline (#175448) (#175547)
# Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Update Fleet's custom ingest pipeline names to avoid collisions + add descriptions to each pipeline (#175448)](https://github.com/elastic/kibana/pull/175448) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyle Pollich","email":"kyle.pollich@elastic.co"},"sourceCommit":{"committedDate":"2024-01-25T14:07:43Z","message":"[Fleet] Update Fleet's custom ingest pipeline names to avoid collisions + add descriptions to each pipeline (#175448)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/175254\r\nRef https://github.com/elastic/kibana/issues/168019\r\nRef https://github.com/elastic/kibana/pull/170270\r\n\r\nIn 8.12.0, Fleet unintentionally shipped a breaking change in\r\nhttps://github.com/elastic/kibana/pull/170270 for APM users who make use\r\nof a custom `traces-apm` data stream. If a user had previously defined\r\nthis ingest pipeline to customize documents ingested for the\r\n`traces-apm` data stream (defined\r\n[here]( |
||
|
Kibana Machine
|
5c7f3729fd
|
[8.12] [RAM] Stack Management::Rules loses user selections when navigating back (#174954) (#175494)
# Backport This will backport the following commits from `main` to `8.12`: - [[RAM] Stack Management::Rules loses user selections when navigating back (#174954)](https://github.com/elastic/kibana/pull/174954) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2024-01-24T23:01:53Z","message":"[RAM] Stack Management::Rules loses user selections when navigating back (#174954)\n\n## Summary\r\n\r\nFIX => |
||
|
Kibana Machine
|
519fbb8011
|
[8.12] [Fleet] make deprecated paths public (#175038) (#175121)
# Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] make deprecated paths public (#175038)](https://github.com/elastic/kibana/pull/175038) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-18T14:35:56Z","message":"[Fleet] make deprecated paths public (#175038)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/175031\r\n\r\nMade deprecated APIs public instead of internal, to fix the accidental\r\nbreaking change for customers who called these APIs before (internal\r\nAPIs don't have a default version resolution yet, so require a version\r\nheader)\r\n\r\nOne caveat of this change is if someone already changed their deprecated\r\nAPI call to use 'elastic-api-version: 1' in 8.11, as it would have to be\r\nchanged again to use the public version or remove the header. Though I\r\ndon't think we have many usages like that, since the version usage is\r\nnot very well documented and we only got one support question about it.","sha":"e31118abf9d3e312951f9184066242690c6a2ef5","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.12.1","v8.13.0"],"title":"[Fleet] make deprecated paths public","number":175038,"url":"https://github.com/elastic/kibana/pull/175038","mergeCommit":{"message":"[Fleet] make deprecated paths public (#175038)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/175031\r\n\r\nMade deprecated APIs public instead of internal, to fix the accidental\r\nbreaking change for customers who called these APIs before (internal\r\nAPIs don't have a default version resolution yet, so require a version\r\nheader)\r\n\r\nOne caveat of this change is if someone already changed their deprecated\r\nAPI call to use 'elastic-api-version: 1' in 8.11, as it would have to be\r\nchanged again to use the public version or remove the header. Though I\r\ndon't think we have many usages like that, since the version usage is\r\nnot very well documented and we only got one support question about it.","sha":"e31118abf9d3e312951f9184066242690c6a2ef5"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175038","number":175038,"mergeCommit":{"message":"[Fleet] make deprecated paths public (#175038)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/175031\r\n\r\nMade deprecated APIs public instead of internal, to fix the accidental\r\nbreaking change for customers who called these APIs before (internal\r\nAPIs don't have a default version resolution yet, so require a version\r\nheader)\r\n\r\nOne caveat of this change is if someone already changed their deprecated\r\nAPI call to use 'elastic-api-version: 1' in 8.11, as it would have to be\r\nchanged again to use the public version or remove the header. Though I\r\ndon't think we have many usages like that, since the version usage is\r\nnot very well documented and we only got one support question about it.","sha":"e31118abf9d3e312951f9184066242690c6a2ef5"}}]}] BACKPORT--> --------- Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com> Co-authored-by: Julia Bardi <julia.bardi@elastic.co> |
||
|
Kibana Machine
|
4ec94ee708
|
[8.12] [Detections Response] Rule action filters missing in UI (#175043) (#175050) (#175142)
# Backport This will backport the following commits from `main` to `8.12`: - [[Detections Response] Rule action filters missing in UI (#175043) (#175050)](https://github.com/elastic/kibana/pull/175050) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2024-01-18T17:44:08Z","message":"[Detections Response] Rule action filters missing in UI (#175043) (#175050)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/175043\r\n\r\nThese changes fix the issue where the alerts filter options are not\r\nvisible on the actions page while creating/editing SIEM rules.\r\n\r\n<img width=\"960\" alt=\"Screenshot 2024-01-17 at 18 43 17\"\r\nsrc=\" |
||
|
Kibana Machine
|
f98d9d3c55
|
[8.12] [Security Solution][Endpoint] Re-enable execute api integration tests (#175082) (#175123)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution][Endpoint] Re-enable execute api integration tests (#175082)](https://github.com/elastic/kibana/pull/175082) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-18T14:52:30Z","message":"[Security Solution][Endpoint] Re-enable execute api integration tests (#175082)\n\n## Summary\r\n\r\nRe-enable `execute` api integration tests\r\n\r\ncloses elastic/kibana/issues/171666\r\ncloses elastic/kibana/issues/171667\r\n\r\n### Flaky runner\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4904\r\nx 100 ( all pass )\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"05a6ba5dd6348a04b518e6327c6c88897b71757e","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","OLM Sprint","v8.12.1","v8.13.0"],"title":"[Security Solution][Endpoint] Re-enable execute api integration tests","number":175082,"url":"https://github.com/elastic/kibana/pull/175082","mergeCommit":{"message":"[Security Solution][Endpoint] Re-enable execute api integration tests (#175082)\n\n## Summary\r\n\r\nRe-enable `execute` api integration tests\r\n\r\ncloses elastic/kibana/issues/171666\r\ncloses elastic/kibana/issues/171667\r\n\r\n### Flaky runner\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4904\r\nx 100 ( all pass )\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"05a6ba5dd6348a04b518e6327c6c88897b71757e"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175082","number":175082,"mergeCommit":{"message":"[Security Solution][Endpoint] Re-enable execute api integration tests (#175082)\n\n## Summary\r\n\r\nRe-enable `execute` api integration tests\r\n\r\ncloses elastic/kibana/issues/171666\r\ncloses elastic/kibana/issues/171667\r\n\r\n### Flaky runner\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4904\r\nx 100 ( all pass )\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"05a6ba5dd6348a04b518e6327c6c88897b71757e"}}]}] BACKPORT--> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com> |
||
|
Kibana Machine
|
def8bb1f9f
|
[8.12] [Security Solution][Endpoint] Re enable endpoint permissions tests (#172540) (#175046)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution][Endpoint] Re enable endpoint permissions tests (#172540)](https://github.com/elastic/kibana/pull/172540) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-17T16:24:43Z","message":"[Security Solution][Endpoint] Re enable endpoint permissions tests (#172540)\n\n## Summary\r\n\r\nRe-enable tests\r\n\r\ncloses elastic/kibana/issues/171649\r\ncloses elastic/kibana/issues/171650\r\n\r\n\r\n## Flaky runner\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4876\r\nx 100 ( all pass )\r\n### with all the FTR tests in the suite\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4889\r\nx 50 ( 25 fails due to timeout loading http://localhost:5620/app/home, 1\r\nfail due to indexed data not being available for delete, rest are\r\nskipped )\r\n### with conditional delete of loaded data and start with login screen\r\n(reorder)\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4894\r\nx 50 (all pass)\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"267e62791449232b280b047a9f34b7d7cd0c4f8a","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","OLM Sprint","v8.12.0","v8.13.0"],"title":"[Security Solution][Endpoint] Re enable endpoint permissions tests","number":172540,"url":"https://github.com/elastic/kibana/pull/172540","mergeCommit":{"message":"[Security Solution][Endpoint] Re enable endpoint permissions tests (#172540)\n\n## Summary\r\n\r\nRe-enable tests\r\n\r\ncloses elastic/kibana/issues/171649\r\ncloses elastic/kibana/issues/171650\r\n\r\n\r\n## Flaky runner\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4876\r\nx 100 ( all pass )\r\n### with all the FTR tests in the suite\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4889\r\nx 50 ( 25 fails due to timeout loading http://localhost:5620/app/home, 1\r\nfail due to indexed data not being available for delete, rest are\r\nskipped )\r\n### with conditional delete of loaded data and start with login screen\r\n(reorder)\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4894\r\nx 50 (all pass)\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"267e62791449232b280b047a9f34b7d7cd0c4f8a"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172540","number":172540,"mergeCommit":{"message":"[Security Solution][Endpoint] Re enable endpoint permissions tests (#172540)\n\n## Summary\r\n\r\nRe-enable tests\r\n\r\ncloses elastic/kibana/issues/171649\r\ncloses elastic/kibana/issues/171650\r\n\r\n\r\n## Flaky runner\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4876\r\nx 100 ( all pass )\r\n### with all the FTR tests in the suite\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4889\r\nx 50 ( 25 fails due to timeout loading http://localhost:5620/app/home, 1\r\nfail due to indexed data not being available for delete, rest are\r\nskipped )\r\n### with conditional delete of loaded data and start with login screen\r\n(reorder)\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4894\r\nx 50 (all pass)\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"267e62791449232b280b047a9f34b7d7cd0c4f8a"}}]}] BACKPORT--> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com> |
||
Jan Monschke
|
818b9bbc35
|
[8.12] [Investigations] - Unskip and refactor discover state tests (#173308) (#174914)
# Backport This will backport the following commits from `main` to `8.12`: - [[Investigations] - Unskip and refactor discover state tests (#173308)](https://github.com/elastic/kibana/pull/173308) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Michael Olorunnisola","email":"michael.olorunnisola@elastic.co"},"sourceCommit":{"committedDate":"2024-01-16T12:18:26Z","message":"[Investigations] - Unskip and refactor discover state tests (#173308)\n\nDependent on: https://github.com/elastic/kibana/pull/173015\r\n\r\n- fixes https://github.com/elastic/kibana/issues/165663\r\n- fixes https://github.com/elastic/kibana/issues/165747\r\n\r\n[Flaky Tests\r\n(100/100)](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4870)\r\n\r\n---------\r\n\r\nCo-authored-by: Jan Monschke <jan.monschke@elastic.co>","sha":"1172c0ec09eb72f478b7c0cb7afc6016fabdc400","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","v8.12.1","v8.13.0"],"number":173308,"url":"https://github.com/elastic/kibana/pull/173308","mergeCommit":{"message":"[Investigations] - Unskip and refactor discover state tests (#173308)\n\nDependent on: https://github.com/elastic/kibana/pull/173015\r\n\r\n- fixes https://github.com/elastic/kibana/issues/165663\r\n- fixes https://github.com/elastic/kibana/issues/165747\r\n\r\n[Flaky Tests\r\n(100/100)](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4870)\r\n\r\n---------\r\n\r\nCo-authored-by: Jan Monschke <jan.monschke@elastic.co>","sha":"1172c0ec09eb72f478b7c0cb7afc6016fabdc400"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173308","number":173308,"mergeCommit":{"message":"[Investigations] - Unskip and refactor discover state tests (#173308)\n\nDependent on: https://github.com/elastic/kibana/pull/173015\r\n\r\n- fixes https://github.com/elastic/kibana/issues/165663\r\n- fixes https://github.com/elastic/kibana/issues/165747\r\n\r\n[Flaky Tests\r\n(100/100)](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4870)\r\n\r\n---------\r\n\r\nCo-authored-by: Jan Monschke <jan.monschke@elastic.co>","sha":"1172c0ec09eb72f478b7c0cb7afc6016fabdc400"}}]}] BACKPORT--> --------- Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co> |
||
|
Kibana Machine
|
f8ce81c4ea
|
[8.12] [Fleet] validate all agent policies before updating them on output delete (#174921) (#174993)
# Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] validate all agent policies before updating them on output delete (#174921)](https://github.com/elastic/kibana/pull/174921) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-17T10:08:31Z","message":"[Fleet] validate all agent policies before updating them on output delete (#174921)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/165817\r\n\r\nMoved the logic of validating agent policies before updating any agent\r\npolicies on output delete. This fixes the scenario where the output\r\ndelete fails on an agent policy with fleet-server integration, but some\r\nagent policies were already updated by then.\r\n\r\nTo verify:\r\n- create a logstash output and make it default for data and monitoring\r\noutput\r\n- create a fleet server policy (with fleet server integration) with data\r\nand monitoring output set to elasticsearch output\r\n- create another agent policy with data and monitoring output set to\r\nelasticsearch output\r\n- attempt to delete the elasticsearch output, expect a UI error\r\n- check that the agent policies are still referencing the elasticsearch\r\noutput, not the logstash one\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"36fbfed45f210ec97b06eb6f46043aa8d2e14e05","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.12.1","v8.13.0"],"title":"[Fleet] validate all agent policies before updating them on output delete","number":174921,"url":"https://github.com/elastic/kibana/pull/174921","mergeCommit":{"message":"[Fleet] validate all agent policies before updating them on output delete (#174921)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/165817\r\n\r\nMoved the logic of validating agent policies before updating any agent\r\npolicies on output delete. This fixes the scenario where the output\r\ndelete fails on an agent policy with fleet-server integration, but some\r\nagent policies were already updated by then.\r\n\r\nTo verify:\r\n- create a logstash output and make it default for data and monitoring\r\noutput\r\n- create a fleet server policy (with fleet server integration) with data\r\nand monitoring output set to elasticsearch output\r\n- create another agent policy with data and monitoring output set to\r\nelasticsearch output\r\n- attempt to delete the elasticsearch output, expect a UI error\r\n- check that the agent policies are still referencing the elasticsearch\r\noutput, not the logstash one\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"36fbfed45f210ec97b06eb6f46043aa8d2e14e05"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174921","number":174921,"mergeCommit":{"message":"[Fleet] validate all agent policies before updating them on output delete (#174921)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/165817\r\n\r\nMoved the logic of validating agent policies before updating any agent\r\npolicies on output delete. This fixes the scenario where the output\r\ndelete fails on an agent policy with fleet-server integration, but some\r\nagent policies were already updated by then.\r\n\r\nTo verify:\r\n- create a logstash output and make it default for data and monitoring\r\noutput\r\n- create a fleet server policy (with fleet server integration) with data\r\nand monitoring output set to elasticsearch output\r\n- create another agent policy with data and monitoring output set to\r\nelasticsearch output\r\n- attempt to delete the elasticsearch output, expect a UI error\r\n- check that the agent policies are still referencing the elasticsearch\r\noutput, not the logstash one\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"36fbfed45f210ec97b06eb6f46043aa8d2e14e05"}}]}] BACKPORT--> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com> |
||
|
Kibana Machine
|
5ffc3311e1
|
[8.12] [DOCS] Refresh cases table screenshot (#174871) (#174935)
# Backport This will backport the following commits from `main` to `8.12`: - [[DOCS] Refresh cases table screenshot (#174871)](https://github.com/elastic/kibana/pull/174871) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2024-01-16T15:18:33Z","message":"[DOCS] Refresh cases table screenshot (#174871)","sha":"5d55ab930c820e26142c56602f8a4f9f73ffda79","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Cases","v8.12.1","v8.13.0"],"title":"[DOCS] Refresh cases table screenshot","number":174871,"url":"https://github.com/elastic/kibana/pull/174871","mergeCommit":{"message":"[DOCS] Refresh cases table screenshot (#174871)","sha":"5d55ab930c820e26142c56602f8a4f9f73ffda79"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174871","number":174871,"mergeCommit":{"message":"[DOCS] Refresh cases table screenshot (#174871)","sha":"5d55ab930c820e26142c56602f8a4f9f73ffda79"}}]}] BACKPORT--> Co-authored-by: Lisa Cawley <lcawley@elastic.co> |
||
Gergő Ábrahám
|
eb6a5d9dfe
|
[EDR Workflows][8.12] Reenable endpoint exceptions FTR (#174843)
## Summary manual backport in order to be able to use flaky test runner: - https://github.com/elastic/kibana/ flaky runner jobs: - 10x: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4866 10/10 ✅ - 100: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4868 100/100 ✅ > [!note] > don't forget to revert the `temp` commit ✅ --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> |
||
Lisa Cawley
|
7dc77912e6
|
[8.12] [RAM][[Maintenance Window][DOCS] Maintenance window scoped query automated screenshots (#174315) (#174872)
# Backport This will backport the following commits from `main` to `8.12`: - [[RAM][[Maintenance Window][DOCS] Maintenance window scoped query automated screenshots (#174315)](https://github.com/elastic/kibana/pull/174315) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2024-01-15T21:22:33Z","message":"[RAM][[Maintenance Window][DOCS] Maintenance window scoped query automated screenshots (#174315)","sha":"02ea9192f7181e7054266462be1273ab1431abaf","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Alerting/RulesManagement","v8.12.1","v8.13.0"],"number":174315,"url":"https://github.com/elastic/kibana/pull/174315","mergeCommit":{"message":"[RAM][[Maintenance Window][DOCS] Maintenance window scoped query automated screenshots (#174315)","sha":"02ea9192f7181e7054266462be1273ab1431abaf"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174315","number":174315,"mergeCommit":{"message":"[RAM][[Maintenance Window][DOCS] Maintenance window scoped query automated screenshots (#174315)","sha":"02ea9192f7181e7054266462be1273ab1431abaf"}}]}] BACKPORT--> |
||
|
Kibana Machine
|
ba30fb7b18
|
[8.12] [ObsUX] Add UI Setting for controling Profiling visibility in Infra (#173294) (#173661)
# Backport This will backport the following commits from `main` to `8.12`: - [[ObsUX] Add UI Setting for controling Profiling visibility in Infra (#173294)](https://github.com/elastic/kibana/pull/173294) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"mykola.harmash@gmail.com"},"sourceCommit":{"committedDate":"2023-12-19T15:48:35Z","message":"[ObsUX] Add UI Setting for controling Profiling visibility in Infra (#173294)\n\nCloses https://github.com/elastic/kibana/issues/173154\r\n\r\nAdds a UI setting to control Infra+Profiling integration from Kibana's\r\nAdvanced Settings as well as from the Infra Settings screen.\r\n\r\nNote that the plugin config feature flag is still there because I\r\nrealized we need it to disable Profiling integration in serverless.\r\n\r\n\r\n\r\n |
||
Juan Pablo Djeredjian
|
24733e59d2
|
[8.12] [Security Solution] Add retryIfConflict util for 409 conflicts in Integration tests (#174185) (#174762)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Add `retryIfConflict` util for `409` conflicts in Integration tests (#174185)](https://github.com/elastic/kibana/pull/174185) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"jpdjeredjian@gmail.com"},"sourceCommit":{"committedDate":"2024-01-11T12:39:45Z","message":"[Security Solution] Add `retryIfConflict` util for `409` conflicts in Integration tests (#174185)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/171428\r\n\r\n**NOTE: the test where this was reported wasn't skipped, so this PR does\r\nnot unskip any tests.** However, the Flaky Test Runs help us determine\r\nthat the issue is no longer reproducible.\r\n\r\nThe `deleteAllPrebuiltRuleAssets` utility reported a `409 Conflict`,\r\npresumably from `security-rule` assets that were attempted to be deleted\r\nwhile they were being updated by a parallel process.\r\n\r\nThis PR wraps the `es.deleteByQuery` calls in the utils\r\n`deleteAllPrebuiltRuleAssets` and `deleteAllTimelines` with a new\r\n`retryIfConflict` helper, that will retry the operation if the ES\r\nrequest fails with a `409`.\r\n\r\n## Flaky test run\r\n\r\n`bundled_prebuilt_rules_package` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4790\r\n\r\n`large_prebuilt_rules_package` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4791\r\n\r\n`update_prebuilt_rules_package` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4792\r\n\r\n`management` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4793\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b8c7306d241807b68bedbd477dcec232e203f6ad","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","v8.12.0","v8.12.1","v8.13.0"],"number":174185,"url":"https://github.com/elastic/kibana/pull/174185","mergeCommit":{"message":"[Security Solution] Add `retryIfConflict` util for `409` conflicts in Integration tests (#174185)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/171428\r\n\r\n**NOTE: the test where this was reported wasn't skipped, so this PR does\r\nnot unskip any tests.** However, the Flaky Test Runs help us determine\r\nthat the issue is no longer reproducible.\r\n\r\nThe `deleteAllPrebuiltRuleAssets` utility reported a `409 Conflict`,\r\npresumably from `security-rule` assets that were attempted to be deleted\r\nwhile they were being updated by a parallel process.\r\n\r\nThis PR wraps the `es.deleteByQuery` calls in the utils\r\n`deleteAllPrebuiltRuleAssets` and `deleteAllTimelines` with a new\r\n`retryIfConflict` helper, that will retry the operation if the ES\r\nrequest fails with a `409`.\r\n\r\n## Flaky test run\r\n\r\n`bundled_prebuilt_rules_package` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4790\r\n\r\n`large_prebuilt_rules_package` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4791\r\n\r\n`update_prebuilt_rules_package` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4792\r\n\r\n`management` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4793\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b8c7306d241807b68bedbd477dcec232e203f6ad"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174185","number":174185,"mergeCommit":{"message":"[Security Solution] Add `retryIfConflict` util for `409` conflicts in Integration tests (#174185)\n\n## Summary\r\n\r\nFixes: https://github.com/elastic/kibana/issues/171428\r\n\r\n**NOTE: the test where this was reported wasn't skipped, so this PR does\r\nnot unskip any tests.** However, the Flaky Test Runs help us determine\r\nthat the issue is no longer reproducible.\r\n\r\nThe `deleteAllPrebuiltRuleAssets` utility reported a `409 Conflict`,\r\npresumably from `security-rule` assets that were attempted to be deleted\r\nwhile they were being updated by a parallel process.\r\n\r\nThis PR wraps the `es.deleteByQuery` calls in the utils\r\n`deleteAllPrebuiltRuleAssets` and `deleteAllTimelines` with a new\r\n`retryIfConflict` helper, that will retry the operation if the ES\r\nrequest fails with a `409`.\r\n\r\n## Flaky test run\r\n\r\n`bundled_prebuilt_rules_package` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4790\r\n\r\n`large_prebuilt_rules_package` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4791\r\n\r\n`update_prebuilt_rules_package` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4792\r\n\r\n`management` - **ESS** and **Serverless**:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4793\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b8c7306d241807b68bedbd477dcec232e203f6ad"}}]}] BACKPORT--> |
||
|
Juan Pablo Djeredjian
|
79fe2295cd
|
[8.12] [Security Solution] Unskip flaky tests in Prebuilt Rules FTR Integration tests (#173998) (#174761)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Unskip flaky tests in Prebuilt Rules FTR Integration tests (#173998)](https://github.com/elastic/kibana/pull/173998) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"jpdjeredjian@gmail.com"},"sourceCommit":{"committedDate":"2024-01-11T12:35:55Z","message":"[Security Solution] Unskip flaky tests in Prebuilt Rules FTR Integration tests (#173998)\n\n**Addresses:**\r\nhttps://github.com/elastic/kibana/issues/172107\r\nhttps://github.com/elastic/kibana/issues/171380\r\n\r\n## Summary\r\n\r\nUnskip skipped tests in:\r\n\r\n1.\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/prebuilt_rules/bundled_prebuilt_rules_package/install_latest_bundled_prebuilt_rules.ts`\r\n2.\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/prebuilt_rules/management/fleet_integration.ts`\r\n\r\n- Makes the `retryDelay` in the **RetryService** in\r\n`packages/kbn-ftr-common-functional-services/services/retry/retry.ts` a\r\nconfigurable parameter - used in our `retry` util to shorten the wait\r\nperiod to 200ms.\r\n- Creates `retry` wrapper util for our FTR Integration tests, that wraps\r\n`retry.try` from the **RetryService**, to implement maximum attempts.\r\n- Uses this `retry` wrapper in test utils that install the\r\n`security_detection_engine` Fleet package, and asserts that rules have\r\nbeen succesfully installed - and retries if they haven't.\r\n- Creates `refreshSavedObjectIndices` reusable util that cleans cache\r\nand refreshes indices. Centralizes comment spread around file into this\r\nsingle file.\r\n- Use this new util to clean the cache in util that install the Fleet\r\npackage, and utils that read the prebuilt rule status.\r\n\r\n## Flaky test runner\r\n\r\n**Before changes:** \r\n- For both `bundled_prebuilt_rules_package` and `management`:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4688\r\n🟢 (250 and 250 runs)\r\n- `bundled_prebuilt_rules_package`:\r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4805\r\n(500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4807\r\n(500 runs)\r\n- `management` \r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4806\r\n(500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4808\r\n(500 runs)\r\n \r\n**After changes:** \r\n- `bundled_prebuilt_rules_package`:\r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4825\r\n🟢 (500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4826\r\n🟢 (500 runs)\r\n- `management` \r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4827\r\n🟢 (500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4828\r\n🟢 (500 runs)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"81d6478beedeceedd4ae193c7a5ba0ee874cbf12","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","v8.12.0","v8.12.1","v8.13.0"],"number":173998,"url":"https://github.com/elastic/kibana/pull/173998","mergeCommit":{"message":"[Security Solution] Unskip flaky tests in Prebuilt Rules FTR Integration tests (#173998)\n\n**Addresses:**\r\nhttps://github.com/elastic/kibana/issues/172107\r\nhttps://github.com/elastic/kibana/issues/171380\r\n\r\n## Summary\r\n\r\nUnskip skipped tests in:\r\n\r\n1.\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/prebuilt_rules/bundled_prebuilt_rules_package/install_latest_bundled_prebuilt_rules.ts`\r\n2.\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/prebuilt_rules/management/fleet_integration.ts`\r\n\r\n- Makes the `retryDelay` in the **RetryService** in\r\n`packages/kbn-ftr-common-functional-services/services/retry/retry.ts` a\r\nconfigurable parameter - used in our `retry` util to shorten the wait\r\nperiod to 200ms.\r\n- Creates `retry` wrapper util for our FTR Integration tests, that wraps\r\n`retry.try` from the **RetryService**, to implement maximum attempts.\r\n- Uses this `retry` wrapper in test utils that install the\r\n`security_detection_engine` Fleet package, and asserts that rules have\r\nbeen succesfully installed - and retries if they haven't.\r\n- Creates `refreshSavedObjectIndices` reusable util that cleans cache\r\nand refreshes indices. Centralizes comment spread around file into this\r\nsingle file.\r\n- Use this new util to clean the cache in util that install the Fleet\r\npackage, and utils that read the prebuilt rule status.\r\n\r\n## Flaky test runner\r\n\r\n**Before changes:** \r\n- For both `bundled_prebuilt_rules_package` and `management`:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4688\r\n🟢 (250 and 250 runs)\r\n- `bundled_prebuilt_rules_package`:\r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4805\r\n(500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4807\r\n(500 runs)\r\n- `management` \r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4806\r\n(500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4808\r\n(500 runs)\r\n \r\n**After changes:** \r\n- `bundled_prebuilt_rules_package`:\r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4825\r\n🟢 (500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4826\r\n🟢 (500 runs)\r\n- `management` \r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4827\r\n🟢 (500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4828\r\n🟢 (500 runs)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"81d6478beedeceedd4ae193c7a5ba0ee874cbf12"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173998","number":173998,"mergeCommit":{"message":"[Security Solution] Unskip flaky tests in Prebuilt Rules FTR Integration tests (#173998)\n\n**Addresses:**\r\nhttps://github.com/elastic/kibana/issues/172107\r\nhttps://github.com/elastic/kibana/issues/171380\r\n\r\n## Summary\r\n\r\nUnskip skipped tests in:\r\n\r\n1.\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/prebuilt_rules/bundled_prebuilt_rules_package/install_latest_bundled_prebuilt_rules.ts`\r\n2.\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/prebuilt_rules/management/fleet_integration.ts`\r\n\r\n- Makes the `retryDelay` in the **RetryService** in\r\n`packages/kbn-ftr-common-functional-services/services/retry/retry.ts` a\r\nconfigurable parameter - used in our `retry` util to shorten the wait\r\nperiod to 200ms.\r\n- Creates `retry` wrapper util for our FTR Integration tests, that wraps\r\n`retry.try` from the **RetryService**, to implement maximum attempts.\r\n- Uses this `retry` wrapper in test utils that install the\r\n`security_detection_engine` Fleet package, and asserts that rules have\r\nbeen succesfully installed - and retries if they haven't.\r\n- Creates `refreshSavedObjectIndices` reusable util that cleans cache\r\nand refreshes indices. Centralizes comment spread around file into this\r\nsingle file.\r\n- Use this new util to clean the cache in util that install the Fleet\r\npackage, and utils that read the prebuilt rule status.\r\n\r\n## Flaky test runner\r\n\r\n**Before changes:** \r\n- For both `bundled_prebuilt_rules_package` and `management`:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4688\r\n🟢 (250 and 250 runs)\r\n- `bundled_prebuilt_rules_package`:\r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4805\r\n(500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4807\r\n(500 runs)\r\n- `management` \r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4806\r\n(500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4808\r\n(500 runs)\r\n \r\n**After changes:** \r\n- `bundled_prebuilt_rules_package`:\r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4825\r\n🟢 (500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4826\r\n🟢 (500 runs)\r\n- `management` \r\n- ESS:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4827\r\n🟢 (500 runs)\r\n- Serverless:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4828\r\n🟢 (500 runs)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"81d6478beedeceedd4ae193c7a5ba0ee874cbf12"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
Lisa Cawley
|
955479341c
|
[8.12] [Connectors][ServiceNow ITSM, SecOps] Automate screenshots, add cross-scope privileges (#172533, #173941) (#174560) | ||
|
Kibana Machine
|
e40d00cf45
|
[8.12] [Security Solution] Unskip bulk actions Cypress tests (#174365) (#174599)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Unskip bulk actions Cypress tests (#174365)](https://github.com/elastic/kibana/pull/174365) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2024-01-10T13:23:31Z","message":"[Security Solution] Unskip bulk actions Cypress tests (#174365)\n\n## Summary\r\n\r\n**Resolves: https://github.com/elastic/kibana/issues/171101**\r\n\r\n200 runs of bulk_edit_rules_actions.cy.ts in ESS env: [*Buildkite\r\n4776*](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4776)\r\n200 runs of bulk_edit_rules_actions.cy.ts in Serverless env: [*Buildkite\r\n4777*](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4777)\r\n\r\nAll tests were green except a couple tests that stopped abruptly mid-way\r\nbecause of CI runner timeouts. So there weren't failed tests.\r\n\r\nTwo issues were causing fails:\r\n1. `\"hunter_no_actions\"` role that was used in \"User with no privileges\r\ncan't add rule actions\" test doesn't exist in Serverless env. Changed it\r\nto `\"t1_analyst\"` – it exists in both ESS and Serverless and doesn't\r\ngive permission to edit rules.\r\n2. Race condition caused by disabled auto-refresh\r\n- In the `beforeAll` hook the auto-refresh is disabled for the Rule\r\nManagement page.\r\n- Then `excessivelyInstallAllPrebuiltRules` is called, which installs\r\nall 1000+ prebuilt rules (only in Serverless, because ESS has 0 prebuilt\r\nrules available to install).\r\n- While the installation is in progress the Rule Management page loads\r\nand displays 9 rules.\r\n- Then the test selects all rules (9) and executes a bulk update on\r\nthem.\r\n- Once the bulk action succeeds, the user sees a toast with \"1000+\r\nactions have been updated\" while the test expects \"9 actions have been\r\nupdated\" because of disabled auto-refresh.\r\n- I decided to skip installing all the Elastic prebuilt rules because\r\nthe operation is very heavy and we check that bulk actions work for\r\nprebuilt rules anyways since two test prebuilt rules are created and\r\ninstalled in beforeAll.","sha":"53ffb143ed1e105f448632c27c1d7b858e13386e","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-coverage","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","v8.12.1","v8.13.0"],"title":"[Security Solution] Unskip bulk actions Cypress tests","number":174365,"url":"https://github.com/elastic/kibana/pull/174365","mergeCommit":{"message":"[Security Solution] Unskip bulk actions Cypress tests (#174365)\n\n## Summary\r\n\r\n**Resolves: https://github.com/elastic/kibana/issues/171101**\r\n\r\n200 runs of bulk_edit_rules_actions.cy.ts in ESS env: [*Buildkite\r\n4776*](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4776)\r\n200 runs of bulk_edit_rules_actions.cy.ts in Serverless env: [*Buildkite\r\n4777*](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4777)\r\n\r\nAll tests were green except a couple tests that stopped abruptly mid-way\r\nbecause of CI runner timeouts. So there weren't failed tests.\r\n\r\nTwo issues were causing fails:\r\n1. `\"hunter_no_actions\"` role that was used in \"User with no privileges\r\ncan't add rule actions\" test doesn't exist in Serverless env. Changed it\r\nto `\"t1_analyst\"` – it exists in both ESS and Serverless and doesn't\r\ngive permission to edit rules.\r\n2. Race condition caused by disabled auto-refresh\r\n- In the `beforeAll` hook the auto-refresh is disabled for the Rule\r\nManagement page.\r\n- Then `excessivelyInstallAllPrebuiltRules` is called, which installs\r\nall 1000+ prebuilt rules (only in Serverless, because ESS has 0 prebuilt\r\nrules available to install).\r\n- While the installation is in progress the Rule Management page loads\r\nand displays 9 rules.\r\n- Then the test selects all rules (9) and executes a bulk update on\r\nthem.\r\n- Once the bulk action succeeds, the user sees a toast with \"1000+\r\nactions have been updated\" while the test expects \"9 actions have been\r\nupdated\" because of disabled auto-refresh.\r\n- I decided to skip installing all the Elastic prebuilt rules because\r\nthe operation is very heavy and we check that bulk actions work for\r\nprebuilt rules anyways since two test prebuilt rules are created and\r\ninstalled in beforeAll.","sha":"53ffb143ed1e105f448632c27c1d7b858e13386e"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174365","number":174365,"mergeCommit":{"message":"[Security Solution] Unskip bulk actions Cypress tests (#174365)\n\n## Summary\r\n\r\n**Resolves: https://github.com/elastic/kibana/issues/171101**\r\n\r\n200 runs of bulk_edit_rules_actions.cy.ts in ESS env: [*Buildkite\r\n4776*](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4776)\r\n200 runs of bulk_edit_rules_actions.cy.ts in Serverless env: [*Buildkite\r\n4777*](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4777)\r\n\r\nAll tests were green except a couple tests that stopped abruptly mid-way\r\nbecause of CI runner timeouts. So there weren't failed tests.\r\n\r\nTwo issues were causing fails:\r\n1. `\"hunter_no_actions\"` role that was used in \"User with no privileges\r\ncan't add rule actions\" test doesn't exist in Serverless env. Changed it\r\nto `\"t1_analyst\"` – it exists in both ESS and Serverless and doesn't\r\ngive permission to edit rules.\r\n2. Race condition caused by disabled auto-refresh\r\n- In the `beforeAll` hook the auto-refresh is disabled for the Rule\r\nManagement page.\r\n- Then `excessivelyInstallAllPrebuiltRules` is called, which installs\r\nall 1000+ prebuilt rules (only in Serverless, because ESS has 0 prebuilt\r\nrules available to install).\r\n- While the installation is in progress the Rule Management page loads\r\nand displays 9 rules.\r\n- Then the test selects all rules (9) and executes a bulk update on\r\nthem.\r\n- Once the bulk action succeeds, the user sees a toast with \"1000+\r\nactions have been updated\" while the test expects \"9 actions have been\r\nupdated\" because of disabled auto-refresh.\r\n- I decided to skip installing all the Elastic prebuilt rules because\r\nthe operation is very heavy and we check that bulk actions work for\r\nprebuilt rules anyways since two test prebuilt rules are created and\r\ninstalled in beforeAll.","sha":"53ffb143ed1e105f448632c27c1d7b858e13386e"}}]}] BACKPORT--> Co-authored-by: Nikita Indik <nikita.indik@elastic.co> |
||
Davis Plumlee
|
8233fd009d
|
[8.12] [Security Solution] Adds tests for coverage overview page (#168058) (#174549)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Adds tests for coverage overview page (#168058)](https://github.com/elastic/kibana/pull/168058) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-09T19:09:40Z","message":"[Security Solution] Adds tests for coverage overview page (#168058)\n\n**Resolves: https://github.com/elastic/kibana/issues/162250**\r\n\r\n## Summary\r\n\r\nAdds remaining unit, api integration, and e2e cypress tests for the\r\ncoverage overview page in accordance to the [existing test\r\nplan](https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/rule_management/coverage_overview_dashboard.md)\r\n\r\n- [Flaky test runner\r\nbuild](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4756)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"315cf9d399c62a69dd02a1aed5ce7118ffa9885a","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["technical debt","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","v8.12.0","v8.13.0"],"number":168058,"url":"https://github.com/elastic/kibana/pull/168058","mergeCommit":{"message":"[Security Solution] Adds tests for coverage overview page (#168058)\n\n**Resolves: https://github.com/elastic/kibana/issues/162250**\r\n\r\n## Summary\r\n\r\nAdds remaining unit, api integration, and e2e cypress tests for the\r\ncoverage overview page in accordance to the [existing test\r\nplan](https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/rule_management/coverage_overview_dashboard.md)\r\n\r\n- [Flaky test runner\r\nbuild](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4756)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"315cf9d399c62a69dd02a1aed5ce7118ffa9885a"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168058","number":168058,"mergeCommit":{"message":"[Security Solution] Adds tests for coverage overview page (#168058)\n\n**Resolves: https://github.com/elastic/kibana/issues/162250**\r\n\r\n## Summary\r\n\r\nAdds remaining unit, api integration, and e2e cypress tests for the\r\ncoverage overview page in accordance to the [existing test\r\nplan](https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/rule_management/coverage_overview_dashboard.md)\r\n\r\n- [Flaky test runner\r\nbuild](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4756)\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"315cf9d399c62a69dd02a1aed5ce7118ffa9885a"}}]}] BACKPORT--> |
||
|
Kibana Machine
|
9019ff6e15
|
[8.12] [DOCS] Add new sub feature privilege to prevent access to the cases settings (#174223) (#174467)
# Backport This will backport the following commits from `main` to `8.12`: - [[DOCS] Add new sub feature privilege to prevent access to the cases settings (#174223)](https://github.com/elastic/kibana/pull/174223) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2024-01-08T15:58:38Z","message":"[DOCS] Add new sub feature privilege to prevent access to the cases settings (#174223)","sha":"ee0cb0b5418ce83ccc7c8681e2da6d0d24534ec6","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Cases","Team:obs-ux-management","v8.12.1","v8.13.0"],"title":"[DOCS] Add new sub feature privilege to prevent access to the cases settings","number":174223,"url":"https://github.com/elastic/kibana/pull/174223","mergeCommit":{"message":"[DOCS] Add new sub feature privilege to prevent access to the cases settings (#174223)","sha":"ee0cb0b5418ce83ccc7c8681e2da6d0d24534ec6"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174223","number":174223,"mergeCommit":{"message":"[DOCS] Add new sub feature privilege to prevent access to the cases settings (#174223)","sha":"ee0cb0b5418ce83ccc7c8681e2da6d0d24534ec6"}}]}] BACKPORT--> Co-authored-by: Lisa Cawley <lcawley@elastic.co> |
||
|
Kibana Machine
|
edab182c40
|
[8.12] [Fleet] Only enable output secrets if all Fleet servers are compatible (#173398) (#174433)
# Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Only enable output secrets if all Fleet servers are compatible (#173398)](https://github.com/elastic/kibana/pull/173398) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jill Guyonnet","email":"jill.guyonnet@elastic.co"},"sourceCommit":{"committedDate":"2024-01-08T09:20:20Z","message":"[Fleet] Only enable output secrets if all Fleet servers are compatible (#173398)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/173041\r\n\r\nOutput secret storage requires that all Fleet servers are on version\r\n8.12.0 or above.\r\n\r\nThe implementation is similar to package policy secrets:\r\nhttps://github.com/elastic/kibana/pull/163627: this PR adds the new\r\n`output_secret_storage_requirements_met` flag on the\r\n`ingest_manager_settings` saved object.\r\n\r\n### Testing\r\n\r\n1. Define a preconfigured output wit a secret value in your\r\n`kibana.dev.yml` file, e.g.:\r\n ```yml\r\n xpack.fleet.outputs:\r\n - id: my-logstash-output-with-a-secret\r\n name: preconfigured logstash output with a secret\r\n type: logstash\r\n hosts: ['localhost:9999']\r\n ssl:\r\n certificate: xxxxxxxxxx\r\n secrets:\r\n ssl:\r\n key: secretLogstashKey\r\n ```\r\n3. Start ES and Kibana. Do not start a Fleet server.\r\n4. Go to Fleet settings and inspect the preconfigured output: it should\r\nhave been created and the secret value should not have been set\r\n(optionally, you can check in the Console with `GET\r\n.fleet-secrets/_search` that the secret was not created). However, a\r\nplain text equivalent should have been created (in the example above,\r\n`ssl.key` should be set to `secretLogstashKey`).\r\n5. Start a Fleet server on version less than 8.12.0. Kibana should\r\nupdate the output. Again, check that the secret value was not set and\r\nthat the plain text equivalent is set.\r\n6. Stop the Fleet server and start another one on version 8.12.0 or\r\nhigher. Kibana should update the output. This time, the secret value\r\nshould have been set.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>","sha":"70508b957a4860b12fd3a2bb9612cfb8a95092e9","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.12.0","v8.13.0"],"title":"[Fleet] Only enable output secrets if all Fleet servers are compatible","number":173398,"url":"https://github.com/elastic/kibana/pull/173398","mergeCommit":{"message":"[Fleet] Only enable output secrets if all Fleet servers are compatible (#173398)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/173041\r\n\r\nOutput secret storage requires that all Fleet servers are on version\r\n8.12.0 or above.\r\n\r\nThe implementation is similar to package policy secrets:\r\nhttps://github.com/elastic/kibana/pull/163627: this PR adds the new\r\n`output_secret_storage_requirements_met` flag on the\r\n`ingest_manager_settings` saved object.\r\n\r\n### Testing\r\n\r\n1. Define a preconfigured output wit a secret value in your\r\n`kibana.dev.yml` file, e.g.:\r\n ```yml\r\n xpack.fleet.outputs:\r\n - id: my-logstash-output-with-a-secret\r\n name: preconfigured logstash output with a secret\r\n type: logstash\r\n hosts: ['localhost:9999']\r\n ssl:\r\n certificate: xxxxxxxxxx\r\n secrets:\r\n ssl:\r\n key: secretLogstashKey\r\n ```\r\n3. Start ES and Kibana. Do not start a Fleet server.\r\n4. Go to Fleet settings and inspect the preconfigured output: it should\r\nhave been created and the secret value should not have been set\r\n(optionally, you can check in the Console with `GET\r\n.fleet-secrets/_search` that the secret was not created). However, a\r\nplain text equivalent should have been created (in the example above,\r\n`ssl.key` should be set to `secretLogstashKey`).\r\n5. Start a Fleet server on version less than 8.12.0. Kibana should\r\nupdate the output. Again, check that the secret value was not set and\r\nthat the plain text equivalent is set.\r\n6. Stop the Fleet server and start another one on version 8.12.0 or\r\nhigher. Kibana should update the output. This time, the secret value\r\nshould have been set.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>","sha":"70508b957a4860b12fd3a2bb9612cfb8a95092e9"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173398","number":173398,"mergeCommit":{"message":"[Fleet] Only enable output secrets if all Fleet servers are compatible (#173398)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/173041\r\n\r\nOutput secret storage requires that all Fleet servers are on version\r\n8.12.0 or above.\r\n\r\nThe implementation is similar to package policy secrets:\r\nhttps://github.com/elastic/kibana/pull/163627: this PR adds the new\r\n`output_secret_storage_requirements_met` flag on the\r\n`ingest_manager_settings` saved object.\r\n\r\n### Testing\r\n\r\n1. Define a preconfigured output wit a secret value in your\r\n`kibana.dev.yml` file, e.g.:\r\n ```yml\r\n xpack.fleet.outputs:\r\n - id: my-logstash-output-with-a-secret\r\n name: preconfigured logstash output with a secret\r\n type: logstash\r\n hosts: ['localhost:9999']\r\n ssl:\r\n certificate: xxxxxxxxxx\r\n secrets:\r\n ssl:\r\n key: secretLogstashKey\r\n ```\r\n3. Start ES and Kibana. Do not start a Fleet server.\r\n4. Go to Fleet settings and inspect the preconfigured output: it should\r\nhave been created and the secret value should not have been set\r\n(optionally, you can check in the Console with `GET\r\n.fleet-secrets/_search` that the secret was not created). However, a\r\nplain text equivalent should have been created (in the example above,\r\n`ssl.key` should be set to `secretLogstashKey`).\r\n5. Start a Fleet server on version less than 8.12.0. Kibana should\r\nupdate the output. Again, check that the secret value was not set and\r\nthat the plain text equivalent is set.\r\n6. Stop the Fleet server and start another one on version 8.12.0 or\r\nhigher. Kibana should update the output. This time, the secret value\r\nshould have been set.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>","sha":"70508b957a4860b12fd3a2bb9612cfb8a95092e9"}}]}] BACKPORT--> Co-authored-by: Jill Guyonnet <jill.guyonnet@elastic.co> |
||
Kevin Qualters
|
81bbb7a8e8
|
[8.12] [Timeline] [ES|QL] Make default esql query empty (#174393) (#174417)
# Backport This will backport the following commits from `main` to `8.12`: - [[Timeline] [ES|QL] Make default esql query empty (#174393)](https://github.com/elastic/kibana/pull/174393) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Qualters","email":"56408403+kqualters-elastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-06T17:13:48Z","message":"[Timeline] [ES|QL] Make default esql query empty (#174393)\n\nBecause default queries can be prohibitively expensive, decision was\r\nmade to make the default query when users open the ES|QL tab of timeline\r\nbe an empty string, this prevents expensive queries from being run\r\nunless a user tries to do so, however there is an error state shown\r\nbefore any interaction, which will be changed in an upcoming pr, but not\r\nin 8.11.x.","sha":"ecfa61ad3480fd88254841bfa5e5d5539773f4cb","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","v8.12.0","v8.13.0","v8.11.4"],"number":174393,"url":"https://github.com/elastic/kibana/pull/174393","mergeCommit":{"message":"[Timeline] [ES|QL] Make default esql query empty (#174393)\n\nBecause default queries can be prohibitively expensive, decision was\r\nmade to make the default query when users open the ES|QL tab of timeline\r\nbe an empty string, this prevents expensive queries from being run\r\nunless a user tries to do so, however there is an error state shown\r\nbefore any interaction, which will be changed in an upcoming pr, but not\r\nin 8.11.x.","sha":"ecfa61ad3480fd88254841bfa5e5d5539773f4cb"}},"sourceBranch":"main","suggestedTargetBranches":["8.12","8.11"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174393","number":174393,"mergeCommit":{"message":"[Timeline] [ES|QL] Make default esql query empty (#174393)\n\nBecause default queries can be prohibitively expensive, decision was\r\nmade to make the default query when users open the ES|QL tab of timeline\r\nbe an empty string, this prevents expensive queries from being run\r\nunless a user tries to do so, however there is an error state shown\r\nbefore any interaction, which will be changed in an upcoming pr, but not\r\nin 8.11.x.","sha":"ecfa61ad3480fd88254841bfa5e5d5539773f4cb"}},{"branch":"8.11","label":"v8.11.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
|
Gergő Ábrahám
|
17b2e4c725
|
[EDR Workflows][8.12] Reenable artifact entries list FTR (#174294)
## Summary Locally the tests passed both for serverless and ESS, but on CI, serverless tests are [disabled anyway](https://github.com/gergoabraham/kibana/blob/8-12-defend-workflows-reenable-artifact-entries-list-ftr/.buildkite/ftr_configs.yml#L97) on this branch, so I just enabled the tests for both envs. - 10x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4753 10/10 ✅ - 100x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4759 100/100 ✅ A separate PR will try to enable it on `main` since there is an underlying issue there. failing test issues: - #173681 - #173682 |
||
|
Gergő Ábrahám
|
1592d9a48f
|
[Defend Workflows][FTR][8.12] Reenable trusted apps list FTR (#174325)
## Summary Manual backport of the PR below, in order to be able to run the flaky test runner on 8.12, too: - #174186 flaky runner: - 100x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4760 100/100 ✅ |
||
|
Kevin Qualters
|
7c51ef4c19
|
[8.12] [Security Solution] [Timelines] Fix FilterManager being undefined when opening timeline from url (#171443) (#174305)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] [Timelines] Fix FilterManager being undefined when opening timeline from url (#171443)](https://github.com/elastic/kibana/pull/171443) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Qualters","email":"56408403+kqualters-elastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-04T22:26:32Z","message":"[Security Solution] [Timelines] Fix FilterManager being undefined when opening timeline from url (#171443)\n\n## Summary\r\n\r\nFilter manager is not populated within redux if a user navigates to a\r\nurl with timeline opened as the first step of entering the app.\r\nInitializeTimeline action is called, but the reducer just ignores any\r\nparams at all if the initialize flag is set to true. Since this is only\r\nused in 2 places, and only 1 of which has an argument other than\r\ntimelineId, I think this solution is fine. Should only ever result in\r\nfixing this bug it seems, as filterManager is either created anew or\r\ncomes directly from the model.\r\n\r\nIssue: https://github.com/elastic/kibana/issues/171437\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"94bdc0d5212412e41e8281a5235654546e2102cb","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:Threat Hunting:Investigations","8.12 candidate","v8.13.0"],"number":171443,"url":"https://github.com/elastic/kibana/pull/171443","mergeCommit":{"message":"[Security Solution] [Timelines] Fix FilterManager being undefined when opening timeline from url (#171443)\n\n## Summary\r\n\r\nFilter manager is not populated within redux if a user navigates to a\r\nurl with timeline opened as the first step of entering the app.\r\nInitializeTimeline action is called, but the reducer just ignores any\r\nparams at all if the initialize flag is set to true. Since this is only\r\nused in 2 places, and only 1 of which has an argument other than\r\ntimelineId, I think this solution is fine. Should only ever result in\r\nfixing this bug it seems, as filterManager is either created anew or\r\ncomes directly from the model.\r\n\r\nIssue: https://github.com/elastic/kibana/issues/171437\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"94bdc0d5212412e41e8281a5235654546e2102cb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171443","number":171443,"mergeCommit":{"message":"[Security Solution] [Timelines] Fix FilterManager being undefined when opening timeline from url (#171443)\n\n## Summary\r\n\r\nFilter manager is not populated within redux if a user navigates to a\r\nurl with timeline opened as the first step of entering the app.\r\nInitializeTimeline action is called, but the reducer just ignores any\r\nparams at all if the initialize flag is set to true. Since this is only\r\nused in 2 places, and only 1 of which has an argument other than\r\ntimelineId, I think this solution is fine. Should only ever result in\r\nfixing this bug it seems, as filterManager is either created anew or\r\ncomes directly from the model.\r\n\r\nIssue: https://github.com/elastic/kibana/issues/171437\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"94bdc0d5212412e41e8281a5235654546e2102cb"}}]}] BACKPORT--> |
||
|
Kibana Machine
|
23b6f02a34
|
[8.12] [SECURITY_SOLUTIONS] Only query security alerts with current user (#174216) (#174304)
# Backport This will backport the following commits from `main` to `8.12`: - [[SECURITY_SOLUTIONS] Only query security alerts with current user (#174216)](https://github.com/elastic/kibana/pull/174216) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"xavier.mouligneau@elastic.co"},"sourceCommit":{"committedDate":"2024-01-04T21:41:30Z","message":"[SECURITY_SOLUTIONS] Only query security alerts with current user (#174216)\n\n## Summary\r\n\r\nWe just got an\r\n[SDH#814](https://github.com/elastic/sdh-security-team/issues/814) that\r\ntell us that some feature like `KPIs` and `grouping` are not acting as\r\nthey should be.\r\n\r\n@PhilippeOberti is doing an investigation to check which feature has\r\nbeen impacted by this bug. This bug has been introduced in this\r\nhttps://github.com/elastic/kibana/pull/112113 since 8.0.0\r\n\r\nI think this simple solution should not impact any features.","sha":"4af36fece290263c4fd86f0e06d3e12bdb05f81b","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","blocker","release_note:fix","impact:critical","Team:ResponseOps","Team:Detection Alerts","v8.12.0","v8.13.0","v8.11.4"],"title":"[SECURITY_SOLUTIONS] Only query security alerts with current user","number":174216,"url":"https://github.com/elastic/kibana/pull/174216","mergeCommit":{"message":"[SECURITY_SOLUTIONS] Only query security alerts with current user (#174216)\n\n## Summary\r\n\r\nWe just got an\r\n[SDH#814](https://github.com/elastic/sdh-security-team/issues/814) that\r\ntell us that some feature like `KPIs` and `grouping` are not acting as\r\nthey should be.\r\n\r\n@PhilippeOberti is doing an investigation to check which feature has\r\nbeen impacted by this bug. This bug has been introduced in this\r\nhttps://github.com/elastic/kibana/pull/112113 since 8.0.0\r\n\r\nI think this simple solution should not impact any features.","sha":"4af36fece290263c4fd86f0e06d3e12bdb05f81b"}},"sourceBranch":"main","suggestedTargetBranches":["8.12","8.11"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174216","number":174216,"mergeCommit":{"message":"[SECURITY_SOLUTIONS] Only query security alerts with current user (#174216)\n\n## Summary\r\n\r\nWe just got an\r\n[SDH#814](https://github.com/elastic/sdh-security-team/issues/814) that\r\ntell us that some feature like `KPIs` and `grouping` are not acting as\r\nthey should be.\r\n\r\n@PhilippeOberti is doing an investigation to check which feature has\r\nbeen impacted by this bug. This bug has been introduced in this\r\nhttps://github.com/elastic/kibana/pull/112113 since 8.0.0\r\n\r\nI think this simple solution should not impact any features.","sha":"4af36fece290263c4fd86f0e06d3e12bdb05f81b"}},{"branch":"8.11","label":"v8.11.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co> |
||
|
Kibana Machine
|
a8ae9fc2bf
|
[8.12] Upgrade openai to 4.24.1 (#173934) (#174128)
# Backport This will backport the following commits from `main` to `8.12`: - [Upgrade openai to 4.24.1 (#173934)](https://github.com/elastic/kibana/pull/173934) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2024-01-02T20:57:17Z","message":"Upgrade openai to 4.24.1 (#173934)\n\nhttps://github.com/openai/openai-node/releases/tag/v4.0.0\r\n\r\nFor reviewers: I made a first pass, but I'm unsure on a few of the\r\nchecks. If there's a ts-expect-error help would be appreciated. Feel\r\nfree to push directly or whichever workflow is best for you.\r\n\r\n---------\r\n\r\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>","sha":"5f5f22224cb13ce18397e2b2603c18538ed78947","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.13.0"],"title":"Upgrade openai to 4.24.1","number":173934,"url":"https://github.com/elastic/kibana/pull/173934","mergeCommit":{"message":"Upgrade openai to 4.24.1 (#173934)\n\nhttps://github.com/openai/openai-node/releases/tag/v4.0.0\r\n\r\nFor reviewers: I made a first pass, but I'm unsure on a few of the\r\nchecks. If there's a ts-expect-error help would be appreciated. Feel\r\nfree to push directly or whichever workflow is best for you.\r\n\r\n---------\r\n\r\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>","sha":"5f5f22224cb13ce18397e2b2603c18538ed78947"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173934","number":173934,"mergeCommit":{"message":"Upgrade openai to 4.24.1 (#173934)\n\nhttps://github.com/openai/openai-node/releases/tag/v4.0.0\r\n\r\nFor reviewers: I made a first pass, but I'm unsure on a few of the\r\nchecks. If there's a ts-expect-error help would be appreciated. Feel\r\nfree to push directly or whichever workflow is best for you.\r\n\r\n---------\r\n\r\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>","sha":"5f5f22224cb13ce18397e2b2603c18538ed78947"}}]}] BACKPORT--> Co-authored-by: Jon <jon@elastic.co> |
||
|
Kibana Machine
|
7b18537c60
|
[8.12] [Security Solution][Detection Engine] fixes flaky ES|QL tests (#173251) (#174099)
# Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution][Detection Engine] fixes flaky ES|QL tests (#173251)](https://github.com/elastic/kibana/pull/173251) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Vitalii Dmyterko","email":"92328789+vitaliidm@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-01-02T16:00:08Z","message":"[Security Solution][Detection Engine] fixes flaky ES|QL tests (#173251)\n\n## Summary\r\n\r\n- fixes flaky ES|QL tests\r\nhttps://github.com/elastic/kibana/issues/173006\r\n- the reason is an issue in cypress itself\r\nhttps://github.com/cypress-io/cypress/issues/22113. It doesn't have a\r\nfix yet, but I tried some suggested workaround, as calling\r\n`uncaught:exception` handler after page is opened, so it is registered\r\nin the same origin. Which seemed to help, since there was no failures in\r\n300 runs. Usual rate of flakiness before the fix was 3-7 failures per\r\n100 runs. Hopefully, it will work and we won't see any errors in future.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- 100 runs for all Detection tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4625\r\n- 2 x 100 for just failing ones:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4620,\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4605\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b365051dc24156d810004917efa64dbcbaa64a59","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","backport:prev-minor","Team:Detection Engine","v8.12.0","v8.13.0"],"title":"[Security Solution][Detection Engine] fixes flaky ES|QL tests","number":173251,"url":"https://github.com/elastic/kibana/pull/173251","mergeCommit":{"message":"[Security Solution][Detection Engine] fixes flaky ES|QL tests (#173251)\n\n## Summary\r\n\r\n- fixes flaky ES|QL tests\r\nhttps://github.com/elastic/kibana/issues/173006\r\n- the reason is an issue in cypress itself\r\nhttps://github.com/cypress-io/cypress/issues/22113. It doesn't have a\r\nfix yet, but I tried some suggested workaround, as calling\r\n`uncaught:exception` handler after page is opened, so it is registered\r\nin the same origin. Which seemed to help, since there was no failures in\r\n300 runs. Usual rate of flakiness before the fix was 3-7 failures per\r\n100 runs. Hopefully, it will work and we won't see any errors in future.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- 100 runs for all Detection tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4625\r\n- 2 x 100 for just failing ones:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4620,\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4605\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b365051dc24156d810004917efa64dbcbaa64a59"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173251","number":173251,"mergeCommit":{"message":"[Security Solution][Detection Engine] fixes flaky ES|QL tests (#173251)\n\n## Summary\r\n\r\n- fixes flaky ES|QL tests\r\nhttps://github.com/elastic/kibana/issues/173006\r\n- the reason is an issue in cypress itself\r\nhttps://github.com/cypress-io/cypress/issues/22113. It doesn't have a\r\nfix yet, but I tried some suggested workaround, as calling\r\n`uncaught:exception` handler after page is opened, so it is registered\r\nin the same origin. Which seemed to help, since there was no failures in\r\n300 runs. Usual rate of flakiness before the fix was 3-7 failures per\r\n100 runs. Hopefully, it will work and we won't see any errors in future.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- 100 runs for all Detection tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4625\r\n- 2 x 100 for just failing ones:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4620,\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4605\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b365051dc24156d810004917efa64dbcbaa64a59"}}]}] BACKPORT--> Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com> |
||
Paul Tavares
|
90021e1b05
|
Enable SentinelOne feature flags for v8.12 (#173859)
## Summary - Enable the experimental feature flag for SentinelOne for v8.12. Feature enabled: ``` xpack.securitySolution.enableExperimental: - sentinelOneManualHostActionsEnabled xpack.stack_connectors.enableExperimental: - sentinelOneConnectorOn ``` > [!NOTE] > This enables the features only in the v8.12 branch. A subsequent PR will be opened against `main` once we GA v8.12 in order to ensure this feature is not accidentally enabled for serverless. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
Kibana Machine
|
193a858a6f
|
[8.12] [ML] Enable Trained models functional tests (#173517) (#173914)
# Backport This will backport the following commits from `main` to `8.12`: - [[ML] Enable Trained models functional tests (#173517)](https://github.com/elastic/kibana/pull/173517) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-12-22T11:23:50Z","message":"[ML] Enable Trained models functional tests (#173517)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/168899\r\nCloses https://github.com/elastic/kibana/issues/168492\r\nCloses https://github.com/elastic/kibana/issues/156243\r\n\r\nEnables Trained models functional tests \r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4664)","sha":"b5cd85c21fa60c121c30219666a89135c9a95124","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","test_ui_functional","release_note:skip","Team:ML","v8.12.0","v8.13.0"],"number":173517,"url":"https://github.com/elastic/kibana/pull/173517","mergeCommit":{"message":"[ML] Enable Trained models functional tests (#173517)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/168899\r\nCloses https://github.com/elastic/kibana/issues/168492\r\nCloses https://github.com/elastic/kibana/issues/156243\r\n\r\nEnables Trained models functional tests \r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4664)","sha":"b5cd85c21fa60c121c30219666a89135c9a95124"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173517","number":173517,"mergeCommit":{"message":"[ML] Enable Trained models functional tests (#173517)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/168899\r\nCloses https://github.com/elastic/kibana/issues/168492\r\nCloses https://github.com/elastic/kibana/issues/156243\r\n\r\nEnables Trained models functional tests \r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n(https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4664)","sha":"b5cd85c21fa60c121c30219666a89135c9a95124"}}]}] BACKPORT--> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co> |