## Summary
Pulls constants from lists plugin into its own kbn package.
Phase 1: Lift and shift small shared constants into kbn package called `kbn-securitysolution-constants`
Phase 2: Deprecate existing code now in packages
Phase 3+: Strangle/remove existing code and use the code from the kbn package
## Summary
Good place for one off utils to use and reduce/remove the circular deps we have between security_solutions, lists, and anywhere else we have them for different utils.
Phase 1: Adds kbn package of `kbn-securitysolution-utils` through lift and shift
Phase 2: Deprecated the functions
Phase 3: Removes the functions in favor of using the `kbn-securitysolution-utils`
Phase 4+: Adds more and removes dependencies/copies across plugins within the security solution. Maybe we break things out by domain later as this grows in size.
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary
We are removing duplicated code in sections of plugins into the kibana/packages folder. This is phase 1 of 4+ where:
Phase 1: Lift and shift the io-ts code into `kibana/packages/kbn-securitysolution-io-ts-utils`
Phase 2: Deprecate the utils across plugins any copied code
Phase 3: Replace the deprecated types with the ones in here where we can. [Strangle pattern](https://martinfowler.com/bliki/StranglerFigApplication.html)
Phase 4+: (potentially) consolidating any duplication or everything altogether with the `kbn-io-ts-utils` project
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
* chore(NA): moving @kbn/analytics into bazel
* chore(NA): fix type check for package migration
* chore(NA): fix type check for package migration
* chore(NA): fix type check for package migration
* chore(NA): separate type generating from server code
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* docs(NA): add requirements for windows development into the getting started developer docs
* chore(NA): change docs id for the new introduced section
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* chore(NA): moving @kbn/config-schema into bazel
* chore(NA): correctly format packages for the new bazel standards
* chore(NA): correctly maps srcs into source_files
* chore(NA): remove config-schema dep from legacy built packages package.jsons
* chore(NA): include kbn/config-schema in the list of bazel packages to be built
* chore(NA): change import to fix typechecking
* chore(NA): remove dependency on new package built by bazel
* chore(NA): be more explicit about incremental setting
* chore(NA): include pretty in the args for ts_project rule
* docs(NA): include package migration completion in the developer getting started
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* chore(NA): moving @kbn/apm-utils into bazel
* chore(NA): add kbn/apm-utils into package.json
* chore(NA): missing standard on build file globs
* chore(NA): be more explicit about incremental setting
* chore(NA): include pretty in the args for ts_project rule
* docs(NA): include package migration completion in the developer getting started
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* chore(NA): add warnings both to run and watch commands about Bazel built packages
* chore(NA): add new commands to build and watch bazel packages
* docs(NA): add documentation about how to deal with bazel packages
* chore(NA): addressed majority of the feedback received except for improved error logging
* chore(NA): disable ibazel info notification.
* chore(NA): remove iBazel notification
* chore(NA): remove iBazel notification - kbn pm dist
* chore(NA): move show_results option to kbn-pm only
* chore(NA): patch build bazel command to include packages target list
* chore(NA): add pretty logging for elastic-datemath
* chore(NA): remove double error output from commands ran with Bazel
* fix(NA): include simple error message to preserve subprocess failure state
* docs(NA): missing docs about how to independentely watch non bazel packages
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Document how Node.js should be upgraded
* Apply suggestions from code review
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Don't show version numbers as code snippets
* Add information about .ci/Dockerfile edge-case
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* chore(NA): remove kibana pre-commit hook installation from bootstrap
* chore(NA): add support for git ref flag on run precommit hook script
* chore(NA): integrate quick commit checks within the CI
* chore(NA): introduce logging trap to warn about quick commit checks failure and how to reproduce it
* chore(NA): update quick commit checks message
* fix(NA): quick commit checks function def
* chore(NA): fix quick commit checks message quotes
* chore(NA): fix functional call
* chore(NA): fix script to run
* chore(NA): add unexpected debugger statement to test quick commit checks
* chore(NA): update message to log before quick commit checks
* chore(NA): remove extra debugger statement
* chore(NA): add echo message inline with script execution
* chore(NA): add unexpected debugger statement to test quick commit checks
* chore(NA): remove extra usage of debug statement
* chore(NA): wrapping quick commit checks in a func
* chore(NA): export function to use later
* chore(NA): export function to use later
* chore(NA): use child bash script on github checks reporter
* chore(NA): define dir context for commit_check_runner.sh
* fix(NA): permissions for commit_check_runner.sh
* fix(NA): permissions for commit.sh
* chore(NA): format message to log
* chore(NA): add unexpected debugger statement to test quick commit checks
* chore(NA): remove extra usage of debug statement
* chore(NA): format runner message
* chore(NA): replace log.info by log.warning
* docs(NA): include docs for removing the pre-commit hook auto installation
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* add asciidoc support for generated plugin list
Try level offset "=+2" instead of "=+1" to stop the inlining of the includes.
remove +2 back to +1
* Remove asciidoc, switch to regex. Rearrange dev guide to avoid nesting limit.
* Add tests for regex
* add a description to not throw off the table. Remove the heading from the paragraph snippet.
* Fix more READMEs so table renders correctly
* Update plugin list
* Remove code-exploration file, moved to plugin-list
* fix typo
* Add link to developer examples
* Update plugin list
* fix typo
* rename float to discrete
* use same section title level on all source files
* Elasticsearch => {es}
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Fix dimension popover layout and color picker “Auto”
* Created ToolbarButton
* Move disabled help text to tooltip for missing values
* Darker side panel backgrounds
* Adding to .asciidoc about where to put the SASS import
* Moving `SASS` guidelines to STYLEGUIDE.md
* Fix keyboard focus of XY settings popover
* Fix dark mode