mirror of
https://github.com/elastic/kibana.git
synced 2025-04-21 16:29:04 -04:00
2909 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Eyo O. Eyo
|
7a1f69190d
|
[8.13] revert change to shared UX markdown component for dashboard vis (#180906) (#181517)
# Backport This will backport the following commits from `main` to `8.13`: - [revert change to shared UX markdown component for dashboard vis (#180906)](https://github.com/elastic/kibana/pull/180906) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Eyo O. Eyo","email":"7893459+eokoneyo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-18T12:01:18Z","message":"revert change to shared UX markdown component for dashboard vis (#180906)\n\n## Summary\r\n\r\nThis PR reverts the change to the shared UX markdown component that\r\nhappened here https://github.com/elastic/kibana/pull/176478. The\r\naforementioned PR introduced couple of visual issues that were uncaught\r\nduring the migration.\r\n\r\nThe known issues that have been brought up that informed the decision to\r\nrevert this change, are itemised below;\r\n\r\n- https://github.com/elastic/kibana/issues/180576\r\n- https://github.com/elastic/kibana/issues/180452\r\n- https://github.com/elastic/sdh-kibana/issues/4608\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4127163bd913dccfbd17badbb9ce1a7a5b2afadc","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:all-open","v8.14.0","v8.15.0"],"number":180906,"url":"https://github.com/elastic/kibana/pull/180906","mergeCommit":{"message":"revert change to shared UX markdown component for dashboard vis (#180906)\n\n## Summary\r\n\r\nThis PR reverts the change to the shared UX markdown component that\r\nhappened here https://github.com/elastic/kibana/pull/176478. The\r\naforementioned PR introduced couple of visual issues that were uncaught\r\nduring the migration.\r\n\r\nThe known issues that have been brought up that informed the decision to\r\nrevert this change, are itemised below;\r\n\r\n- https://github.com/elastic/kibana/issues/180576\r\n- https://github.com/elastic/kibana/issues/180452\r\n- https://github.com/elastic/sdh-kibana/issues/4608\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4127163bd913dccfbd17badbb9ce1a7a5b2afadc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/181140","number":181140,"state":"MERGED","mergeCommit":{"sha":"f799e4fc253831332008fa7b06dc7c8d9c0d8c2a","message":"[8.14] revert change to shared UX markdown component for dashboard vis (#180906) (#181140)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.14`:\n- [revert change to shared UX markdown component for dashboard vis\n(#180906)](https://github.com/elastic/kibana/pull/180906)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Eyo O.\nEyo\",\"email\":\"7893459+eokoneyo@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2024-04-18T12:01:18Z\",\"message\":\"revert\nchange to shared UX markdown component for dashboard vis (#180906)\\n\\n##\nSummary\\r\\n\\r\\nThis PR reverts the change to the shared UX markdown\ncomponent that\\r\\nhappened here\nhttps://github.com/elastic/kibana/pull/176478. The\\r\\naforementioned PR\nintroduced couple of visual issues that were uncaught\\r\\nduring the\nmigration.\\r\\n\\r\\nThe known issues that have been brought up that\ninformed the decision to\\r\\nrevert this change, are itemised\nbelow;\\r\\n\\r\\n- https://github.com/elastic/kibana/issues/180576\\r\\n-\nhttps://github.com/elastic/kibana/issues/180452\\r\\n-\nhttps://github.com/elastic/sdh-kibana/issues/4608\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common scenarios\\r\\n\\r\\n\\r\\n### For\nmaintainers\\r\\n\\r\\n- [x] This was checked for breaking API changes and\nwas\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"4127163bd913dccfbd17badbb9ce1a7a5b2afadc\",\"branchLabelMapping\":{\"^v8.15.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"Team:SharedUX\",\"backport:all-open\",\"v8.14.0\",\"v8.15.0\"],\"title\":\"revert\nchange to shared UX markdown component for dashboard\nvis\",\"number\":180906,\"url\":\"https://github.com/elastic/kibana/pull/180906\",\"mergeCommit\":{\"message\":\"revert\nchange to shared UX markdown component for dashboard vis (#180906)\\n\\n##\nSummary\\r\\n\\r\\nThis PR reverts the change to the shared UX markdown\ncomponent that\\r\\nhappened here\nhttps://github.com/elastic/kibana/pull/176478. The\\r\\naforementioned PR\nintroduced couple of visual issues that were uncaught\\r\\nduring the\nmigration.\\r\\n\\r\\nThe known issues that have been brought up that\ninformed the decision to\\r\\nrevert this change, are itemised\nbelow;\\r\\n\\r\\n- https://github.com/elastic/kibana/issues/180576\\r\\n-\nhttps://github.com/elastic/kibana/issues/180452\\r\\n-\nhttps://github.com/elastic/sdh-kibana/issues/4608\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common scenarios\\r\\n\\r\\n\\r\\n### For\nmaintainers\\r\\n\\r\\n- [x] This was checked for breaking API changes and\nwas\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"4127163bd913dccfbd17badbb9ce1a7a5b2afadc\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.14\"],\"targetPullRequestStates\":[{\"branch\":\"8.14\",\"label\":\"v8.14.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.15.0\",\"branchLabelMappingKey\":\"^v8.15.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/180906\",\"number\":180906,\"mergeCommit\":{\"message\":\"revert\nchange to shared UX markdown component for dashboard vis (#180906)\\n\\n##\nSummary\\r\\n\\r\\nThis PR reverts the change to the shared UX markdown\ncomponent that\\r\\nhappened here\nhttps://github.com/elastic/kibana/pull/176478. The\\r\\naforementioned PR\nintroduced couple of visual issues that were uncaught\\r\\nduring the\nmigration.\\r\\n\\r\\nThe known issues that have been brought up that\ninformed the decision to\\r\\nrevert this change, are itemised\nbelow;\\r\\n\\r\\n- https://github.com/elastic/kibana/issues/180576\\r\\n-\nhttps://github.com/elastic/kibana/issues/180452\\r\\n-\nhttps://github.com/elastic/sdh-kibana/issues/4608\\r\\n\\r\\n\\r\\n###\nChecklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common scenarios\\r\\n\\r\\n\\r\\n### For\nmaintainers\\r\\n\\r\\n- [x] This was checked for breaking API changes and\nwas\n[labeled\\r\\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"4127163bd913dccfbd17badbb9ce1a7a5b2afadc\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Eyo O. Eyo <7893459+eokoneyo@users.noreply.github.com>"}},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/180906","number":180906,"mergeCommit":{"message":"revert change to shared UX markdown component for dashboard vis (#180906)\n\n## Summary\r\n\r\nThis PR reverts the change to the shared UX markdown component that\r\nhappened here https://github.com/elastic/kibana/pull/176478. The\r\naforementioned PR introduced couple of visual issues that were uncaught\r\nduring the migration.\r\n\r\nThe known issues that have been brought up that informed the decision to\r\nrevert this change, are itemised below;\r\n\r\n- https://github.com/elastic/kibana/issues/180576\r\n- https://github.com/elastic/kibana/issues/180452\r\n- https://github.com/elastic/sdh-kibana/issues/4608\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4127163bd913dccfbd17badbb9ce1a7a5b2afadc"}}]}] BACKPORT--> |
||
Kibana Machine
|
7f5d3b3c9a
|
[8.13] [Discover] Unskip field token flaky tests (#180721) (#180775)
# Backport This will backport the following commits from `main` to `8.13`: - [[Discover] Unskip field token flaky tests (#180721)](https://github.com/elastic/kibana/pull/180721) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-04-15T08:56:02Z","message":"[Discover] Unskip field token flaky tests (#180721)\n\n- Closes https://github.com/elastic/kibana/issues/180622\r\n\r\n75x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5668","sha":"9cf478b4a38b8c9774d36b65695f42dc96932484","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.14.0"],"title":"[Discover] Unskip field token flaky tests","number":180721,"url":"https://github.com/elastic/kibana/pull/180721","mergeCommit":{"message":"[Discover] Unskip field token flaky tests (#180721)\n\n- Closes https://github.com/elastic/kibana/issues/180622\r\n\r\n75x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5668","sha":"9cf478b4a38b8c9774d36b65695f42dc96932484"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/180721","number":180721,"mergeCommit":{"message":"[Discover] Unskip field token flaky tests (#180721)\n\n- Closes https://github.com/elastic/kibana/issues/180622\r\n\r\n75x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5668","sha":"9cf478b4a38b8c9774d36b65695f42dc96932484"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co> |
||
|
Kibana Machine
|
f679df65c0
|
[8.13] revert to legacy markdown for TSVB Visualizations (#180053) (#180075)
# Backport This will backport the following commits from `main` to `8.13`: - [revert to legacy markdown for TSVB Visualizations (#180053)](https://github.com/elastic/kibana/pull/180053) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Eyo O. Eyo","email":"7893459+eokoneyo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-04T17:38:05Z","message":"revert to legacy markdown for TSVB Visualizations (#180053)\n\n## Summary\r\n\r\nThis PR reverts the previous migration from the legacy markdown\r\ncomponent for the Markdown renderer in TSVB visualizations. The\r\nMigration to the new component resulted in a regression where custom CSS\r\nstyles don't get applied, because of the change in the document\r\nstructure for the new markdown component, the fix proposed\r\n[here](https://github.com/elastic/kibana/pull/179894) would not be\r\nsufficient in the event that the provided user styles are specifically\r\ntargeting elements based on the document structure from the legacy\r\nmarkdown component.\r\n\r\n\r\n<!-- ### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n-->","sha":"ee67c2089949b871aae06a4fd076978f77528b08","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:prev-minor","ci:cloud-deploy","v8.14.0","v8.13.2"],"title":"revert to legacy markdown for TSVB Visualizations ","number":180053,"url":"https://github.com/elastic/kibana/pull/180053","mergeCommit":{"message":"revert to legacy markdown for TSVB Visualizations (#180053)\n\n## Summary\r\n\r\nThis PR reverts the previous migration from the legacy markdown\r\ncomponent for the Markdown renderer in TSVB visualizations. The\r\nMigration to the new component resulted in a regression where custom CSS\r\nstyles don't get applied, because of the change in the document\r\nstructure for the new markdown component, the fix proposed\r\n[here](https://github.com/elastic/kibana/pull/179894) would not be\r\nsufficient in the event that the provided user styles are specifically\r\ntargeting elements based on the document structure from the legacy\r\nmarkdown component.\r\n\r\n\r\n<!-- ### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n-->","sha":"ee67c2089949b871aae06a4fd076978f77528b08"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/180053","number":180053,"mergeCommit":{"message":"revert to legacy markdown for TSVB Visualizations (#180053)\n\n## Summary\r\n\r\nThis PR reverts the previous migration from the legacy markdown\r\ncomponent for the Markdown renderer in TSVB visualizations. The\r\nMigration to the new component resulted in a regression where custom CSS\r\nstyles don't get applied, because of the change in the document\r\nstructure for the new markdown component, the fix proposed\r\n[here](https://github.com/elastic/kibana/pull/179894) would not be\r\nsufficient in the event that the provided user styles are specifically\r\ntargeting elements based on the document structure from the legacy\r\nmarkdown component.\r\n\r\n\r\n<!-- ### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n-->","sha":"ee67c2089949b871aae06a4fd076978f77528b08"}},{"branch":"8.13","label":"v8.13.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Eyo O. Eyo <7893459+eokoneyo@users.noreply.github.com> |
||
|
Kibana Machine
|
4c7370de62
|
[8.13] [Data Discovery] Unskip tests skipped in #175740 (#178592) (#179878)
# Backport This will backport the following commits from `main` to `8.13`: - [[Data Discovery] Unskip tests skipped in #175740 (#178592)](https://github.com/elastic/kibana/pull/178592) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Davis McPhee","email":"davis.mcphee@elastic.co"},"sourceCommit":{"committedDate":"2024-04-02T22:51:36Z","message":"[Data Discovery] Unskip tests skipped in #175740 (#178592)\n\n## Summary\r\n\r\nThis PR fixes and unskips the Data Discovery tests skipped in #176882.\r\n\r\nFlaky test runner x50:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5594.\r\n\r\nPartially resolves #176882.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>","sha":"a16be392efb1fc0a75aa3e04788bcf85a1074f71","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.14.0"],"title":"[Data Discovery] Unskip tests skipped in #175740","number":178592,"url":"https://github.com/elastic/kibana/pull/178592","mergeCommit":{"message":"[Data Discovery] Unskip tests skipped in #175740 (#178592)\n\n## Summary\r\n\r\nThis PR fixes and unskips the Data Discovery tests skipped in #176882.\r\n\r\nFlaky test runner x50:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5594.\r\n\r\nPartially resolves #176882.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>","sha":"a16be392efb1fc0a75aa3e04788bcf85a1074f71"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178592","number":178592,"mergeCommit":{"message":"[Data Discovery] Unskip tests skipped in #175740 (#178592)\n\n## Summary\r\n\r\nThis PR fixes and unskips the Data Discovery tests skipped in #176882.\r\n\r\nFlaky test runner x50:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5594.\r\n\r\nPartially resolves #176882.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>","sha":"a16be392efb1fc0a75aa3e04788bcf85a1074f71"}}]}] BACKPORT--> Co-authored-by: Davis McPhee <davis.mcphee@elastic.co> |
||
Julia Rechkunova
|
597ea09c3a
|
[8.13] [Discover] Unskip runtime field tests (#179627) (#179812)
# Backport This will backport the following commits from `main` to `8.13`: - [[Discover] Unskip runtime field tests (#179627)](https://github.com/elastic/kibana/pull/179627) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-03-31T18:22:32Z","message":"[Discover] Unskip runtime field tests (#179627)\n\n- Closes https://github.com/elastic/kibana/issues/179297\r\n- Closes https://github.com/elastic/kibana/issues/179310\r\n\r\n90x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5582","sha":"cd9a0c294d34052df3659882d33fd6dd480788d0","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","Team:DataDiscovery","backport:prev-minor","v8.14.0"],"number":179627,"url":"https://github.com/elastic/kibana/pull/179627","mergeCommit":{"message":"[Discover] Unskip runtime field tests (#179627)\n\n- Closes https://github.com/elastic/kibana/issues/179297\r\n- Closes https://github.com/elastic/kibana/issues/179310\r\n\r\n90x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5582","sha":"cd9a0c294d34052df3659882d33fd6dd480788d0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/179627","number":179627,"mergeCommit":{"message":"[Discover] Unskip runtime field tests (#179627)\n\n- Closes https://github.com/elastic/kibana/issues/179297\r\n- Closes https://github.com/elastic/kibana/issues/179310\r\n\r\n90x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5582","sha":"cd9a0c294d34052df3659882d33fd6dd480788d0"}}]}] BACKPORT--> |
||
|
Kibana Machine
|
053db7fc01
|
[8.13] [Discover] Unskip discover data grid row height functional test (#179453) (#179690)
# Backport This will backport the following commits from `main` to `8.13`: - [[Discover] Unskip discover data grid row height functional test (#179453)](https://github.com/elastic/kibana/pull/179453) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"matthias.wilhelm@elastic.co"},"sourceCommit":{"committedDate":"2024-03-29T13:23:58Z","message":"[Discover] Unskip discover data grid row height functional test (#179453)","sha":"a464a6636aab0f32f54b12690ddc77cdf4c7a36f","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","documentation","Team:DataDiscovery","backport:prev-minor","v8.14.0"],"title":"[Discover] Unskip discover data grid row height functional test","number":179453,"url":"https://github.com/elastic/kibana/pull/179453","mergeCommit":{"message":"[Discover] Unskip discover data grid row height functional test (#179453)","sha":"a464a6636aab0f32f54b12690ddc77cdf4c7a36f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/179453","number":179453,"mergeCommit":{"message":"[Discover] Unskip discover data grid row height functional test (#179453)","sha":"a464a6636aab0f32f54b12690ddc77cdf4c7a36f"}}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> |
||
|
Eyo O. Eyo
|
daffde5992
|
[8.13] Fix how sample data test install state is determined in test (#178529) (#178601)
# Backport This will backport the following commits from `main` to `8.13`: - [Fix how sample data test install state is determined in test (#178529)](https://github.com/elastic/kibana/pull/178529) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Eyo O. Eyo","email":"7893459+eokoneyo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-03-12T19:16:13Z","message":"Fix how sample data test install state is determined in test (#178529)\n\n## Summary\r\nCloses https://github.com/elastic/kibana/issues/112103\r\n\r\nMake sample data install status available to be read by test util, as\r\ndocumented by @gsoldevila in the issue referenced above. The issue\r\nhappens because there's a slight delay that really can't be walked\r\naround where the install status in this particular instance is still\r\n'installed' but the call to mark the sample data completes so there's\r\nthat flicker where the `remove` element is displayed momentarily because\r\nthe component doesn't quite received the update to the sample data's\r\ninstall status immediately.\r\n\r\nThe proposed fix opts to complement the current way of determining if\r\nany sample data is installed using the newly introduced `data-status`\r\nattribute, here we wait till the result of clicking the remove button\r\nactually triggers a change in the value of the install state of said\r\nsample data, which in turn is reflected in the value of `data-status`\r\nalongside checking that the remove button exists.\r\n\r\n### Checklist\r\n<!--\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials -->\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n<!--\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n-->","sha":"910188e4e0baf6b2dbfbab88f4f4466a077f87c2","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:skip","Team:SharedUX","v8.13.0","v8.14.0"],"number":178529,"url":"https://github.com/elastic/kibana/pull/178529","mergeCommit":{"message":"Fix how sample data test install state is determined in test (#178529)\n\n## Summary\r\nCloses https://github.com/elastic/kibana/issues/112103\r\n\r\nMake sample data install status available to be read by test util, as\r\ndocumented by @gsoldevila in the issue referenced above. The issue\r\nhappens because there's a slight delay that really can't be walked\r\naround where the install status in this particular instance is still\r\n'installed' but the call to mark the sample data completes so there's\r\nthat flicker where the `remove` element is displayed momentarily because\r\nthe component doesn't quite received the update to the sample data's\r\ninstall status immediately.\r\n\r\nThe proposed fix opts to complement the current way of determining if\r\nany sample data is installed using the newly introduced `data-status`\r\nattribute, here we wait till the result of clicking the remove button\r\nactually triggers a change in the value of the install state of said\r\nsample data, which in turn is reflected in the value of `data-status`\r\nalongside checking that the remove button exists.\r\n\r\n### Checklist\r\n<!--\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials -->\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n<!--\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n-->","sha":"910188e4e0baf6b2dbfbab88f4f4466a077f87c2"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178529","number":178529,"mergeCommit":{"message":"Fix how sample data test install state is determined in test (#178529)\n\n## Summary\r\nCloses https://github.com/elastic/kibana/issues/112103\r\n\r\nMake sample data install status available to be read by test util, as\r\ndocumented by @gsoldevila in the issue referenced above. The issue\r\nhappens because there's a slight delay that really can't be walked\r\naround where the install status in this particular instance is still\r\n'installed' but the call to mark the sample data completes so there's\r\nthat flicker where the `remove` element is displayed momentarily because\r\nthe component doesn't quite received the update to the sample data's\r\ninstall status immediately.\r\n\r\nThe proposed fix opts to complement the current way of determining if\r\nany sample data is installed using the newly introduced `data-status`\r\nattribute, here we wait till the result of clicking the remove button\r\nactually triggers a change in the value of the install state of said\r\nsample data, which in turn is reflected in the value of `data-status`\r\nalongside checking that the remove button exists.\r\n\r\n### Checklist\r\n<!--\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials -->\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n<!--\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n-->","sha":"910188e4e0baf6b2dbfbab88f4f4466a077f87c2"}}]}] BACKPORT--> |
||
|
Kibana Machine
|
4f2cdce4a4
|
[8.13] Skip tests failing on Chrome 121+ (#175740) (#178510)
# Backport This will backport the following commits from `main` to `8.13`: - [Skip tests failing on Chrome 121+ (#175740)](https://github.com/elastic/kibana/pull/175740) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2024-03-12T14:36:02Z","message":"Skip tests failing on Chrome 121+ (#175740)\n\nSkipped tests have been forwarded to their corresponding teams for\r\ntriage. See\r\nhttps://github.com/elastic/kibana/issues/176882#issuecomment-1991647927\r\nfor more information.\r\n\r\n---------\r\n\r\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"62da8be6f635896625d7702a5ed264bcf8c83f38","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","auto-backport","v8.13.0","v7.17.19","v8.12.3"],"number":175740,"url":"https://github.com/elastic/kibana/pull/175740","mergeCommit":{"message":"Skip tests failing on Chrome 121+ (#175740)\n\nSkipped tests have been forwarded to their corresponding teams for\r\ntriage. See\r\nhttps://github.com/elastic/kibana/issues/176882#issuecomment-1991647927\r\nfor more information.\r\n\r\n---------\r\n\r\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"62da8be6f635896625d7702a5ed264bcf8c83f38"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","7.17","8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.19","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.12","label":"v8.12.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jon <jon@elastic.co> |
||
|
Kibana Machine
|
4aebd25d33
|
[8.13] [Dashboard Navigation] Unskip links panel test (#178051) (#178153)
# Backport This will backport the following commits from `main` to `8.13`: - [[Dashboard Navigation] Unskip links panel test (#178051)](https://github.com/elastic/kibana/pull/178051) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-03-06T18:08:17Z","message":"[Dashboard Navigation] Unskip links panel test (#178051)\n\nCloses https://github.com/elastic/kibana/issues/177675\r\nCloses https://github.com/elastic/kibana/issues/177676\r\n\r\n## Summary\r\n\r\nWhen I originally ran the FTR on this test, it [passed 100\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5389),\r\nso I thought we could maybe just unskip the test without further effort.\r\nHowever, when looking at the failure screenshot, it looks like the link\r\ncreation/editor flyout didn't open for some reason - so, I decided to\r\nadd some extra logging statements (to make debugging easier if this test\r\nfails again) + add a few extra retry's to **ensure** that the flyout is\r\nopen before progressing to (hopefully) prevent this from happening in\r\nthe future.\r\n\r\nRerunning the FTR after these changes also [passed 100\r\ntimes]( |
||
|
Julia Rechkunova
|
c28a129f1b
|
[8.13] [DataView] Show previously selected no time field setting (#177221) (#177683)
# Backport This will backport the following commits from `main` to `8.13`: - [[DataView] Show previously selected no time field setting (#177221)](https://github.com/elastic/kibana/pull/177221) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-02-23T09:45:55Z","message":"[DataView] Show previously selected no time field setting (#177221)\n\n- Closes https://github.com/elastic/kibana/issues/177001\r\n\r\n## Summary\r\n\r\nWhen editing a data view, previously selected time field value will be\r\nchosen in the form.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd593149dbd37771a0e88381ee00f73055c73c3e","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Data Views","Team:DataDiscovery","backport:prev-minor","v8.14.0"],"number":177221,"url":"https://github.com/elastic/kibana/pull/177221","mergeCommit":{"message":"[DataView] Show previously selected no time field setting (#177221)\n\n- Closes https://github.com/elastic/kibana/issues/177001\r\n\r\n## Summary\r\n\r\nWhen editing a data view, previously selected time field value will be\r\nchosen in the form.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd593149dbd37771a0e88381ee00f73055c73c3e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177221","number":177221,"mergeCommit":{"message":"[DataView] Show previously selected no time field setting (#177221)\n\n- Closes https://github.com/elastic/kibana/issues/177001\r\n\r\n## Summary\r\n\r\nWhen editing a data view, previously selected time field value will be\r\nchosen in the form.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd593149dbd37771a0e88381ee00f73055c73c3e"}}]}] BACKPORT--> |
||
|
Julia Rechkunova
|
cfcd681457
|
[8.13] [DataViews] Improve management functional tests for serverless (#177146) (#177723)
# Backport This will backport the following commits from `main` to `8.13`: - [[DataViews] Improve management functional tests for serverless (#177146)](https://github.com/elastic/kibana/pull/177146) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"matthias.wilhelm@elastic.co"},"sourceCommit":{"committedDate":"2024-02-20T09:52:48Z","message":"[DataViews] Improve management functional tests for serverless (#177146)\n\n* improving code to prevent occasional flakiness in serverless","sha":"a2268131b34f59ecdf1683d855755da0bd845517","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Data Views","release_note:skip","backport:skip","Team:DataDiscovery","v8.14.0"],"number":177146,"url":"https://github.com/elastic/kibana/pull/177146","mergeCommit":{"message":"[DataViews] Improve management functional tests for serverless (#177146)\n\n* improving code to prevent occasional flakiness in serverless","sha":"a2268131b34f59ecdf1683d855755da0bd845517"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177146","number":177146,"mergeCommit":{"message":"[DataViews] Improve management functional tests for serverless (#177146)\n\n* improving code to prevent occasional flakiness in serverless","sha":"a2268131b34f59ecdf1683d855755da0bd845517"}}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> |
||
|
Julia Rechkunova
|
9bcca4780c
|
[8.13] [Discover] Fix "New" link in ES|QL mode (#177038) (#177894)
# Backport This will backport the following commits from `main` to `8.13`: - [[Discover] Fix "New" link in ES|QL mode (#177038)](https://github.com/elastic/kibana/pull/177038) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-02-23T11:10:29Z","message":"[Discover] Fix \"New\" link in ES|QL mode (#177038)\n\n- Closes https://github.com/elastic/kibana/issues/176873\r\n\r\n## Summary\r\n\r\nThis PR makes sure that when user presses \"New\" top nav link in\r\nDiscover, they will stay in ES|QL mode if the previous mode was ES|QL\r\ntoo. The ES|QL query will be reset to the initial one `from <index\r\npattern> | limit 10`. For this query I created a new util\r\n`getInitialESQLQuery()`.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a78661217702684133417ca926bc411bf1f1beae","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport missing","Team:DataDiscovery","backport:prev-minor","Feature:ES|QL","v8.14.0"],"number":177038,"url":"https://github.com/elastic/kibana/pull/177038","mergeCommit":{"message":"[Discover] Fix \"New\" link in ES|QL mode (#177038)\n\n- Closes https://github.com/elastic/kibana/issues/176873\r\n\r\n## Summary\r\n\r\nThis PR makes sure that when user presses \"New\" top nav link in\r\nDiscover, they will stay in ES|QL mode if the previous mode was ES|QL\r\ntoo. The ES|QL query will be reset to the initial one `from <index\r\npattern> | limit 10`. For this query I created a new util\r\n`getInitialESQLQuery()`.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a78661217702684133417ca926bc411bf1f1beae"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177038","number":177038,"mergeCommit":{"message":"[Discover] Fix \"New\" link in ES|QL mode (#177038)\n\n- Closes https://github.com/elastic/kibana/issues/176873\r\n\r\n## Summary\r\n\r\nThis PR makes sure that when user presses \"New\" top nav link in\r\nDiscover, they will stay in ES|QL mode if the previous mode was ES|QL\r\ntoo. The ES|QL query will be reset to the initial one `from <index\r\npattern> | limit 10`. For this query I created a new util\r\n`getInitialESQLQuery()`.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"a78661217702684133417ca926bc411bf1f1beae"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
Tre
|
986116133f
|
[FTR] Refactor toasts svc (#174222)
### Summary Refactoring general ui service (test helpers), to a kbn package. - Optimize methods and drop some code duplication. ### Why - Makes the service easily available from multiple code areas. - This is a preparation to potentially moving tests to plugins / packages, where they would no longer be able to import thing from test or x-pack/test but only from a package. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
Eyo O. Eyo
|
0481436d0e
|
migrate to new shared ux markdown (#176478)
## Summary Closes https://github.com/elastic/kibana/issues/174290 *Breaking Changes* - Markdown document will only render valid markdown markup, this implies that previous behaviour where html tags would render as text is no longer supported and such html tag will be stripped out. <!-- ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --> |
||
Matthias Wilhelm
|
fde955da03
|
[UnifiedFieldList] Categorize fields as empty that never had a value in matching indices (#174063)
With this commit the UnifiedFieldList used in Discover and Lens will categorize fields that never had any value in matching indices as "Empty fields". This was built by using the new `include_fields_with_no_value` parameter of Elasticsearch field_caps API. Co-authored-by: Matt Kime <matt@mattki.me> |
||
Stratoula Kalafateli
|
c984b0e05f
|
[Functional tests] Stabilize the gauge filter on chart click test (#176787)
## Summary Closes https://github.com/elastic/kibana/issues/164358 Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5148 |
||
Peter Pisljar
|
721f48cad3
|
discover query cancellation (#176202) | ||
Davis McPhee
|
39559b74a2
|
[Unified Data Table] Add header row height configuration (#175501)
## Summary This PR adds header row height configuration to Discover, and aligns the row height configuration UI in Discover and Lens. The header row height configuration should behave the same way as the cell row height configuration, including persisting to saved searches and displaying in the saved search embeddable. Expanded: <img width="464" alt="expanded" src=" |
||
|
Julia Rechkunova
|
0f31c0bff3
|
[Discover] Unskip update data view test (#176508)
- Closes https://github.com/elastic/kibana/issues/174066 95x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5099 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed |
||
|
Davis McPhee
|
509248b0c6
|
[Saved Queries] Improve saved query management (#170599)
## Summary
This PR introduces a number of changes and improvements to saved query
management:
- Add server side pagination (5 queries per page) and search
functionality to the "Load query" list, which improves UX and
performance by no longer requesting all queries at once.
- Redesign the "Load query" list to improve the UX and a11y, making it
possible for keyboard users to effectively navigate the list and
load/delete queries.
- Add an "Active" badge to the "Load query" list to indicate which list
entry represents the currently loaded query, and hoist the entry to the
top of the first page for better visibility when no search term exists.
- Deprecate the saved query `/_all` endpoint and update it to return
only the first 100 queries instead of loading them all into memory at
once.
- Add a new `titleKeyword` field to the saved query SO, which allows
sorting queries alphabetically by title when displaying them in the
"Load query" list.
- Improve the performance of the "has saved queries" check when Unified
Search is mounted to no longer request actual queries, and instead just
request the count.
- Update the saved query duplicate title check to no longer rely on
fetching all queries at once, and instead asynchronously check for
duplicates by title on save.
- Add server side duplicate title validation to the create and update
saved query endpoints.
- Various small fixes and cleanups throughout saved query management.
|
||
|
Stratoula Kalafateli
|
8a651ea5be
|
[ES|QL] Fixes the mapping of ES fields (#176665)
## Summary When we created the ESQL strategy we used the same logic with SQL. But this is not 100% correct. For example it converts the ip type fields to strings, same as geo_points. This PR is fixing it. So now if you run for example ``` from kibana_sample_data_logs | WHERE CIDR_MATCH(ip, "153.189.234.161/32", "127.0.0.3/32") | stats count(*) ``` the client side validation won't fail. |
||
Achyut Jhunjhunwala
|
fd8a9f07fd
|
[Logs Explorer] Add actions column (#175872)
## Summary
Closes - https://github.com/elastic/kibana/issues/171728
## What this PR does ?
1. Add customisation point for handling Leading and Trailing columns via
a single customisation point.
Currently the `Data Grid` exposes 2 separate customisation point for
handling this -
- `externalControlColumns` to add extension to `LeadingControlColumn`
- `trailingControlColumns` to add extension to `TrailingControlColumns`
But both of these extension point creates certain problems(Discover team
can help in here) which this new extension point solves.
1. There exists a React Bug (may be because the way we bundle Kibana,
not 100% sure) due to which when customControlColumns when passed to the
above props like `externalControlColumns` or `trailingControlColumns`,
even though they render inside the `<UnifiedDataTableContext.Provider
value={unifiedDataTableContextValue}>` provider, they actually cannot
access the context. For example when i tried to import the
`ExpandButton` from the table directly and pass as it is to
`trailingControlColumn` somehow 2 different context were getting created
and the ExpandButton present in the LeadingColumn was getting access to
context with data in it, where as the ExpandButton present in the
Trailing Column which was passed via prop was ending up in different
context and hence not receiving data.
2. Access to the `rows` data is very important. If context cannot be
accessed, then accessing the row data becomes trickier.
Hence this new Customisation Point solves the above problem by passing
in both the control columns with reference and data and the consumer can
then modify it accordingly.
2. Using the Customisation point described in point 1, 3 additional
columns were added to the newly added Marker Control column
- Expand Action. (Moved from 1st to last)
- Malformed Document (In future this will be linked to a Fix IT flow)
- Stacktraces available (In future this will be linked to the Flyout
Tab, 4th Tab which will be Stacktrace)
## Demo
<img width="2178" alt="image"
src="
|
||
Robert Oskamp
|
736af7b0e0
|
[FTR] Fix URL checks in navigateToApp (#176546)
## Summary This PR fixes the URL check for successful navigation in the `common` PageObject `navigateToApp` method. |
||
Drew Tate
|
16787801f8
|
[Managed content] readonly in library views (#176263)
## Summary Close https://github.com/elastic/kibana/issues/172387 This PR stops users from doing two things in the library views 1. deleting managed content 2. editing metadata of managed content It also includes a refactor to the `TableListView` interface to replace the `isItemEditable` callback with a row-level action. <img width="1596" alt="Screenshot 2024-02-06 at 3 03 06 PM" src=" |
||
|
Julia Rechkunova
|
d8f44220c0
|
[Discover] Include global filters when opening a saved search (#175814)
- Closes https://github.com/elastic/kibana/issues/171212 ## Summary Discover ignored global filters when loading a saved search, because it loads a saved search before it starts syncing with global URL state. This PR does not change the order of events but it adds a manual sync for global filters so they are included in search request anyway. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios |
||
Tiago Costa
|
1a4d1cdc43
|
skip flaky suite (#174066) | ||
|
Julia Rechkunova
|
9999f3674b
|
[Discover] Unskip custom time range test (#176132)
- Closes https://github.com/elastic/kibana/issues/104578 ## Summary 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5021 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5062 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5076 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios |
||
|
Drew Tate
|
f136782fd4
|
[Dashboard] Keep managed panels out of unmanaged dashboards (#176006)
## Summary Close https://github.com/elastic/kibana/issues/172383 Close https://github.com/elastic/kibana/issues/172384 This PR introduces a [new embeddable-related registry](https://github.com/elastic/kibana/pull/176006/files#diff-1401b355377c76ab6458756aa0e3177beef5ec56796c58b7a52b5e003f85b5cf) which clients can use to define a custom transformation from saved object to embeddable input during the add-panel-from-library sequence. Then, each content type uses this to communicate whether a particular object should be added by-ref or by-val based on the presence of `managed: true` on the saved object ([example](https://github.com/elastic/kibana/pull/176006/files#diff-3baaeaeef5893a5a4db6379a1ed888406a8584cb9d0c7440f273040e4aa28166R157-R167)). ### Managed panels are added by-value to dashboards <img width="400" alt="Screenshot 2024-02-01 at 12 24 06 PM" src=" |
||
Jean-Louis Leysens
|
e90c2098f2
|
[Http] Replace buildNr with buildSha in static asset paths (#175898)
## Summary Follow up of [first CDN PR](https://github.com/elastic/kibana/pull/169408). Primary focus is replacing our build nr with SHA that allows cache busting and maintains anti-collision properties. ## How to test Start Kibana as usual navigating around the app with the network tab open in your browser of choice. Keep an eye out for any asset loading errors. It's tricky to test every possible asset since there are many permutations, but generally navigating around Kibana should work exactly as it did before regarding loading bundles and assets. ## Notes * did a high-level audit of usages of `buildNum` in `packages`, `src` and `x-pack` adding comments where appropriate. * In non-distributable builds (like dev) static asset paths will be prefixed with `XXXXXXXXXXXX` instead of Node's `Number.MAX_SAFE_INTEGER` * Added some validation to ensure the CDN url is of the expected form: nothing trailing the pathname ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Risk Matrix | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | We break some first or third party dependencies on existing asset routes | Med | High | Attempting to mitgate by serving static assets from both old and new paths where paths have updated to include the build SHA. Additioanlly: it is very bad practice to rely on the values of the static paths, but someone might be | | Cache-busting is more aggressive | High | Low | Unlikely to be a big problem, but we are not scoping more static assets to a SHA and so every new Kibana release will require clients to, for example, download fonts again. | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
Matthew Kime
|
cde8f2be67
|
[data views] Default field formatters based on field meta values (#174973)
## Summary Default field formatters based on field meta units data. Note: the smallest unit our formatter will show is milliseconds which means micro and nanoseconds may round down to zero for smaller values. https://github.com/elastic/kibana/issues/176112 Closes: https://github.com/elastic/kibana/issues/82318 Mapping and doc setup for testing - ``` PUT my-index-000001 PUT my-index-000001/_mapping { "properties": { "nanos": { "type": "long", "meta": { "unit": "nanos" } }, "micros": { "type": "long", "meta": { "unit": "micros" } }, "ms": { "type": "long", "meta": { "unit": "ms" } }, "second": { "type": "long", "meta": { "unit": "s" } }, "minute": { "type": "long", "meta": { "unit": "m" } }, "hour": { "type": "long", "meta": { "unit": "h" } }, "day": { "type": "long", "meta": { "unit": "d" } }, "percent": { "type": "long", "meta": { "unit": "percent" } }, "bytes": { "type": "long", "meta": { "unit": "byte" } } } } POST my-index-000001/_doc { "nanos" : 1234.5, "micros" : 1234.5, "ms" : 1234.5, "second" : 1234.5, "minute" : 1234.5, "hour" : 1234.5, "day" : 1234.5, "percent" : 1234.5, "bytes" : 1234.5 } ``` |
||
|
Julia Rechkunova
|
f019b531a0
|
[Discover] Unskip edit data view test (#176134)
- Closes https://github.com/elastic/kibana/issues/174066 ## Summary 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5022 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed |
||
Clint Andrew Hall
|
450f9f62e2
|
[ES|QL] Bypass no data views screen (#174316)
> Derived from https://github.com/elastic/kibana/pull/173068 > Further addresses https://github.com/elastic/kibana/issues/169873 ## Summary - We're adding a link to the No Data Prompt to send a person to explore their data using ES|QL if there exists any ingested data but no data view. - This PR populates the query bar with the first available index (some special handling for logs index. |
||
|
Davis McPhee
|
fcde1444fb
|
Fix broken tests as a result of tsid hashing (#176120)
## Summary This RP updates two `data.json.gz` files to remove all doc IDs (which is unsupported according to https://github.com/elastic/kibana/issues/176109#issuecomment-1923646627), which started causing failings after tsid hashing was implemented by ES in https://github.com/elastic/elasticsearch/pull/98023. Resolves #176103. Resolves #176102. Resolves #176100. Resolves #176107. Resolves #176108. Resolves #176109. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) |
||
|
Stratoula Kalafateli
|
5104183911
|
[ES|QL] Distinguish among empty and available fields (#174585) | ||
Catherine Liu
|
80d01ecca4
|
[Controls] Adds step setting for range slider control (#174717)
## Summary Closes #174542. |
||
|
Tiago Costa
|
7c45bfdc30
|
skip failing es promotion suite (#176109) | ||
|
Tiago Costa
|
a8566d23b0
|
skip failing es promotion suite (#176100) | ||
|
Tiago Costa
|
8bc9b28669
|
skip flaky suite (#152825) | ||
|
Drew Tate
|
29d1a0ac46
|
[Visualize] Prevent overwriting managed content (#175274)
## Summary
Close https://github.com/elastic/kibana/issues/172380
I marked this a breaking change since it is preventing users from doing
something they have been able to do before. They can no longer save
changes to managed visualizations. Instead, they have to save changes to
a new visualization.
This is how the UI should look for the managed visualization.
<img width="970" alt="Screenshot 2024-01-24 at 12 57 53 PM"
src="
|
||
|
Drew Tate
|
1aea4ba38e
|
[Maps] Prevent overwriting managed content from the editor (#175329)
## Summary
Close https://github.com/elastic/kibana/issues/172381
I marked this a breaking change since it is preventing users from doing
something they have been able to do before. They can no longer save
changes to managed map. Instead, they have to save changes to a new map.
To test, import this `ndjson` file which includes a managed map:
<details>
```
{"attributes":{"allowHidden":false,"fieldAttrs":"{}","fieldFormatMap":"{}","fields":"[]","name":"school_neighborhood_poverty_estimates_-_current","runtimeFieldMap":"{}","sourceFilters":"[]","title":"school_neighborhood_poverty_estimates_-_current"},"coreMigrationVersion":"8.8.0","created_at":"2024-01-23T16:29:10.798Z","id":"5162dd45-e7b8-41a4-816d-b427f0be7194","managed":false,"references":[],"type":"index-pattern","typeMigrationVersion":"8.0.0","updated_at":"2024-01-23T16:29:10.798Z","version":"WzYsMV0="}
{"attributes":{"description":"","layerListJSON":"[{\"locale\":\"autoselect\",\"sourceDescriptor\":{\"type\":\"EMS_TMS\",\"isAutoSelect\":true,\"lightModeDefault\":\"road_map_desaturated\"},\"id\":\"b093ef75-9c58-4fad-a029-a10f09bafc3e\",\"label\":null,\"minZoom\":0,\"maxZoom\":24,\"alpha\":1,\"visible\":true,\"style\":{\"type\":\"EMS_VECTOR_TILE\",\"color\":\"\"},\"includeInFitToBounds\":true,\"type\":\"EMS_VECTOR_TILE\"},{\"sourceDescriptor\":{\"geoField\":\"geometry\",\"scalingType\":\"MVT\",\"id\":\"47944ba6-77b4-419e-bc90-8443bd86d529\",\"type\":\"ES_SEARCH\",\"applyGlobalQuery\":true,\"applyGlobalTime\":true,\"applyForceRefresh\":true,\"filterByMapBounds\":true,\"tooltipProperties\":[],\"sortField\":\"\",\"sortOrder\":\"desc\",\"topHitsGroupByTimeseries\":false,\"topHitsSplitField\":\"\",\"topHitsSize\":1,\"indexPatternRefName\":\"layer_1_source_index_pattern\"},\"id\":\"807664cf-ae19-4b64-8f2e-3d917e35f3ab\",\"label\":null,\"minZoom\":0,\"maxZoom\":24,\"alpha\":0.75,\"visible\":true,\"style\":{\"type\":\"VECTOR\",\"properties\":{\"icon\":{\"type\":\"STATIC\",\"options\":{\"value\":\"marker\"}},\"fillColor\":{\"type\":\"STATIC\",\"options\":{\"color\":\"#54B399\"}},\"lineColor\":{\"type\":\"STATIC\",\"options\":{\"color\":\"#41937c\"}},\"lineWidth\":{\"type\":\"STATIC\",\"options\":{\"size\":0}},\"iconSize\":{\"type\":\"STATIC\",\"options\":{\"size\":6}},\"iconOrientation\":{\"type\":\"STATIC\",\"options\":{\"orientation\":0}},\"labelText\":{\"type\":\"STATIC\",\"options\":{\"value\":\"\"}},\"labelColor\":{\"type\":\"STATIC\",\"options\":{\"color\":\"#000000\"}},\"labelSize\":{\"type\":\"STATIC\",\"options\":{\"size\":14}},\"labelZoomRange\":{\"options\":{\"useLayerZoomRange\":true,\"minZoom\":0,\"maxZoom\":24}},\"labelBorderColor\":{\"type\":\"STATIC\",\"options\":{\"color\":\"#FFFFFF\"}},\"symbolizeAs\":{\"options\":{\"value\":\"circle\"}},\"labelBorderSize\":{\"options\":{\"size\":\"SMALL\"}},\"labelPosition\":{\"options\":{\"position\":\"CENTER\"}}},\"isTimeAware\":true},\"includeInFitToBounds\":true,\"type\":\"MVT_VECTOR\",\"joins\":[],\"disableTooltips\":false}]","mapStateJSON":"{\"adHocDataViews\":[],\"zoom\":9.06,\"center\":{\"lon\":-112.43427,\"lat\":33.76472},\"timeFilters\":{\"from\":\"now-15m\",\"to\":\"now\"},\"refreshConfig\":{\"isPaused\":true,\"interval\":60000},\"query\":{\"language\":\"kuery\",\"query\":\"\"},\"filters\":[],\"settings\":{\"autoFitToDataBounds\":false,\"backgroundColor\":\"#ffffff\",\"customIcons\":[],\"disableInteractive\":false,\"disableTooltipControl\":false,\"hideToolbarOverlay\":false,\"hideLayerControl\":false,\"hideViewControl\":false,\"initialLocation\":\"LAST_SAVED_LOCATION\",\"fixedLocation\":{\"lat\":0,\"lon\":0,\"zoom\":2},\"browserLocation\":{\"zoom\":2},\"keydownScrollZoom\":false,\"maxZoom\":24,\"minZoom\":0,\"showScaleControl\":false,\"showSpatialFilters\":true,\"showTimesliderToggleButton\":true,\"spatialFiltersAlpa\":0.3,\"spatialFiltersFillColor\":\"#DA8B45\",\"spatialFiltersLineColor\":\"#DA8B45\"}}","title":"My map","uiStateJSON":"{\"isLayerTOCOpen\":true,\"openTOCDetails\":[]}"},"coreMigrationVersion":"8.8.0","created_at":"2024-01-23T16:27:07.764Z","id":"8359b071-6da7-43dc-b375-3d0afa546763","managed":true,"references":[{"id":"5162dd45-e7b8-41a4-816d-b427f0be7194","name":"layer_1_source_index_pattern","type":"index-pattern"}],"type":"map","typeMigrationVersion":"8.4.0","updated_at":"2024-01-23T16:32:59.750Z","version":"WzcsMV0="}
{"excludedObjects":[],"excludedObjectsCount":0,"exportedCount":2,"missingRefCount":0,"missingReferences":[]}
```
</details>
This is how the UI should look:
<img width="1037" alt="Screenshot 2024-01-23 at 9 39 48 AM"
src="
|
||
Elena Stoeva
|
123e62517a
|
[Advanced Settings] Integrate new Settings application into stateful Kibana (#175255)
Closes https://github.com/elastic/kibana/issues/172922 ## Summary This PR: - Integrates the new Settings application (`packages/kbn-management/settings/application`) into stateful Kibana and removes the old `management_app` from the `src/plugins/advanced_settings` plugin. - Adds support for section registry in the new Settings application, so that other plugins can add their own sections to the Advanced settings app. - Adds functionality for disabling saving of settings based on the provided capabilities of the current user. <img width="1352" alt="Screenshot 2024-01-23 at 16 46 03" src=" |
||
|
Peter Pisljar
|
9908db47d3
|
async es|ql search strategy (#174246) | ||
|
Drew Tate
|
e7e34981e7
|
[Discover] Prevent overwriting managed content from editor (#175256)
## Summary Close https://github.com/elastic/kibana/issues/172382 I marked this a breaking change since it is preventing users from doing something they have been able to do before. They can no longer save changes to managed saved searches. Instead, they have to save changes to a new saved search. This is how the UI should look. <img width="970" alt="Screenshot 2024-01-22 at 11 33 31 AM" src=" |
||
|
Peter Pisljar
|
0e3513a913
|
[Lens] value based ES|QL data source (#171081)
## Summary Closes https://github.com/elastic/kibana/issues/167631 Enhances the ES|QL lens datasource to receive a DataTable as an input (so no datafetching happens in lens) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com> |
||
|
Eyo O. Eyo
|
b25407edba
|
Update Kibana code editor dependencies (#171720)
## Summary This PR started out as an attempt to resolve https://github.com/elastic/kibana/issues/166559; which it does, the appropriate colours for the message prompt displayed when an edit attempt on read only content is made in the code editor for both dark and light mode are now set; ### Light mode <img width="412" alt="Screenshot 2023-11-22 at 11 30 17" src=" |
||
|
Drew Tate
|
1d4b7df989
|
[Lens] Prevent overwriting managed content from editor (#175062)
## Summary Close https://github.com/elastic/kibana/issues/166720 I marked this a breaking change since it is preventing users from doing something they have been able to do before. They can no longer save changes to managed Lens visualizations. Instead, they have to save changes to a new visualization. To test, import this `ndjson` file which includes both a managed and an unmanaged visualization: --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> |
||
|
Robert Oskamp
|
bc9706577e
|
Fix serverless attachment framework tests for MKI (#175085)
## Summary This PR fixes the cases attachment framework tests for MKI runs with search projects. ### Details - Recently, a refresh of the default data view field list has been added (as part of field caps caching) - However, during test run time, this data view does not necessarily exist anymore (might have been cleaned up by an earlier test) - This was the case for our MKI test runs (where tests run in a different order / in different groups than in CI, which made the test fail - This introduced an optional parameter to ignore a missing data view when `refreshDataViewFieldList` is called, which allows us to just move on in that scenario |
||
|
Tiago Costa
|
d9d3452c66
|
skip flaky suite (#174066) | ||
|
Matthew Kime
|
acdaf0127e
|
[data views] cache field caps requests (#168910)
## Summary
Closes: https://github.com/elastic/kibana/issues/169622
Field caps request caching - implement `stale-while-revalidate` cache
headers and etags with 304 responses as appropriate.
This PR accomplishes
- Adds 304 Not Modified to http server
- Adds refresh button to data view management that force refreshes field
list
- Adds `/internal/data_views/fields` endpoint which supports caching.
- This is necessary since `fields_for_wildcard` doesn't support caching
due to POST requests
- Adds `stale-while-revalidate` header directive UNLESS field list is
empty.
- Uses Vary header with hash of user id to force requests when user has
changed.
- Unchanged field list responses won't recreate data view field list
### How to test
1. Pop open the dev tools to the network tab and make sure 'Disable
cache' is unchecked. filter for 'fields' requests
2. Load more than one data set (sample data is fine)
3. Go to discover
4. Switch selected data views. Notice status code on first load vs
subsequent loads
5. Open a new window, notice loading from cache
6. Push document that changes field list. You'll need to wait for cache
to expire for it to load. The default is 5s.
7. Notice that field list loads after cache is old properly result in
304 response.
8. Set `data_views:cache_max_age`, shift reload. No field requests will
be cached.
#### Note on Safari
Safari doesn't support the `stale-while-revalidate` directive.
Additionally, the Safari dev console shows 304 responses as 200's. I
figured this out by adding console statements to the fields endpoint. As
best I can tell, Safari won't be performant on slow clusters but its
also no slower than it was before this PR. Safari does respect the
disabling of cache headers.
## Release note
Data View field list requests are now cached with a
`stale-while-revalidate` strategy. This means that after the initial
field list request, all subsequent requests return the cached response
which is very fast. If the cache is determined to be stale then the
cache will update in the background and new data will be available on
the next request.
This behavior can be modified via the `data_views:cache_max_age` Kibana
advanced setting. Setting it to zero will disable the cache. All other
values (in seconds) will be used to determine whether the cache is
stale. The default value is 5 seconds.
The field list can be manually updated via the refresh button in data
view management or a hard refresh with your browser.
Note for Safari: The `stale-while-revalidate` cache directive is
unsupported, therefore it makes additional requests. If this is
impacting Kibana performance then try Chrome or Firefox.
Data View Management
<img width="1064" alt="Screenshot 2024-01-09 at 1 36 20 PM"
src="
|
||
|
Julia Rechkunova
|
900ab217a2
|
[Discover] Fix "Unsaved changes" badge for ES|QL (#174645)
## Summary This PR fixes a bug where "Unsaved changes" badge would appear after page refresh for an ES|QL saved search. To reproduce on main: - Create a new ES|QL saved search - Reload the page => Notice that the badge appeared With this PR the issue should be resolved. It was caused by the fact that adhoc data view id might change internally. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios |