Tim Sullivan
e4a32f8f3c
[SharedUX] Remove usage of deprecated React rendering utilities ( #180516 )
...
## Summary
Partially addresses https://github.com/elastic/kibana-team/issues/805
Follows https://github.com/elastic/kibana/pull/180003
These changes come up from searching in the code and finding where
certain kinds of deprecated AppEx-SharedUX modules are imported.
**Reviewers: Please interact with critical paths through the UI
components touched in this PR, ESPECIALLY in terms of testing dark mode
and i18n.**
This focuses on code within AppEx-SharedUX. [Reporting changes are
separate](https://github.com/elastic/kibana/pull/ ).
<img width="1107" alt="image"
src="c0d2ce08https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
2024-04-17 07:52:41 -07:00
Eyo O. Eyo
0481436d0e
migrate to new shared ux markdown ( #176478 )
...
## Summary
Closes https://github.com/elastic/kibana/issues/174290
*Breaking Changes*
- Markdown document will only render valid markdown markup, this implies
that previous behaviour where html tags would render as text is no
longer supported and such html tag will be stripped out.
<!-- ### Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1 ) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
### Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.
When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx ) |
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
-->
2024-02-13 20:05:33 +00:00
Pierre Gayvallet
b86cef59c0
Fix banner not being displayed on login page ( #140688 )
...
* Fix banner not being displayed on login page
* fix and re-enable banner FTR tests
* revert commit to config file
* add unit test
* don't use whitespace for cli config value
Co-authored-by: Tre <wayne.seymour@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-09-20 00:39:53 -07:00
spalger
3730dd0779
fix all violations
2022-04-16 01:37:30 -05:00
Jean-Louis Leysens
d9bbe9c9be
[Reporting] Remove banner from reports ( #116147 )
...
* remove banner from reports
* added types file
* updated types references and imports
* added screenshot mode public mock
* added jest tests for when screenshot mode is enabled
* Update x-pack/plugins/banners/public/plugin.test.tsx
Co-authored-by: Michael Dokolin <dokmic@gmail.com>
* Update x-pack/plugins/banners/public/plugin.test.tsx
Co-authored-by: Michael Dokolin <dokmic@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Michael Dokolin <dokmic@gmail.com>
2021-11-01 15:31:56 +00:00
Caroline Horn
f07ebc822f
Reducing wrapping divs from RenderingService ( #97017 )
...
* Reducing wrapping divs from RenderingService
* Applying more styles to .kbnAppWrapper
Some being temporary and will need a better solution when introducing the page layout component
* Almost fixing tests for rendering service
Can’t figure out how to have a optional Observable
`Received: "kbnAppWrapper class-name”`
* Adding some comments
* [Dashboard] Using the APP_WRAPPER_CLASS
* fix test & ts types
* Fixin a few more tests that were using `.app-wrapper`
* Creating docs for new var and cleaning up some selectors
* Fixing reporting
* Fixing banner position and truncation
* Fixed CSS error in loading screen and jump in animation
* Fixing selectors in Canvas
* Remove unused var
* Added `APP_WRAPPER_CLASS` export from `server` and updated reporting to use it
* Fix monitoring icon clicks
* move APP_WRAPPER_CLASS definition to src/core/common
* Fixing Monitoring snapshots and wrapper class
* Moved `APP_WRAPPER_CLASS` utils but exported from `public` and `server`
* Remove old folder
* Fix dashboard test by only showing HR in edit mode
Co-authored-by: pgayvallet
Co-authored-by: tsullivan
2021-04-26 16:06:06 -04:00
Pierre Gayvallet
ddac0e9501
add per space configuration to custom header banner ( #94449 )
...
* restore the banners ui settings
* fix banner init logic
* fix unit tests
* update telemetry schema
* add basic server-side plugin tests
* add FTR tests for banners plugin
* use keyword for sensitive setting
* update snapshots
* setting name consistency with configuration properties
* fix setting names in telemetry files
* open banner links in new tab
* add config.disableSpaceBanners property
* fix types
* add descriptions to banner settings
* change label and value header->top
* finishing header->top replacement
* doc nits
* add banners section to advanced options doc
* feedback on advanced options doc
* adapt deprecation to new format
2021-03-31 10:57:06 +02:00
Pierre Gayvallet
570dcc07b5
Implement custom global header banner ( #87438 )
...
* first draft
* update plugin list
* fix tsproject
* update bundle limits file
* remove unused start dep
* adapt imports
* POC of footer banner
* update styles, mostly
* plug banner to uiSettings
* adding some unit tests
* add tests on sort_fields
* cleanup sums in sass mixins
* some self review stuff
* update generated doc
* add tests for color field
* update chrome header test snapshots
* retrieve license info from the server
* switch from uiSettings to plugin config
* update plugin list description
* update default colors
* NIT
* add markdown support
* fix banner overlap in fullscreen mode
* change banner height to 32px
* change banner's font size to 14
* delete unused uiSettings
2021-02-11 10:12:24 +01:00
