# Backport
This will backport the following commits from `main` to `8.x`:
- [[Reporting] fix dashboard "Copy Post URL" action
(#192530)](https://github.com/elastic/kibana/pull/192530)
<!--- Backport version: 9.4.3 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Tim
Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-07T23:54:21Z","message":"[Reporting]
fix dashboard \"Copy Post URL\" action (#192530)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/191673\r\nCloseshttps://github.com/elastic/kibana/issues/183566\r\n\r\nFixes the ability
for the POST URL used to automate generation of\r\nreports by adding a
`generateExportUrl` function to the ShareMenuItemV2\r\ninterface. This
function returns a dynamic export URL for PDF generation\r\nby using the
selected layout option.\r\n\r\nOther changes: provides more strictness
in type definitions by:\r\n * splitting the types that define
`ShareMenuProvider`:\r\n * `ShareMenuProviderV2` provides the
`getShareMenuItems` function\r\n* `ShareMenuProviderLegacy` provides the
`getShareMenuItemsLegacy`\r\nfunction\r\n\r\n### Release note\r\nFixed
an issue with the export options for PNG/PDF reports in
a\r\ndashboard.\r\n\r\n### Checklist\r\n\r\nDelete any items that are
not applicable to this PR.\r\n\r\n- [x] Use the `generateExportUrl`
function inputs to return a POST URL\r\nthat is aware of the layout mode
(`print` or `preserve_layout`) and\r\nscreen dimensions\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Flaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6986","sha":"38407ae6b01e071757083fe358116b6dd75c4422","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","v8.16.0","backport:version","v8.15.2"],"title":"[Reporting]
fix dashboard \"Copy Post URL\"
action","number":192530,"url":"https://github.com/elastic/kibana/pull/192530","mergeCommit":{"message":"[Reporting]
fix dashboard \"Copy Post URL\" action (#192530)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/191673\r\nCloseshttps://github.com/elastic/kibana/issues/183566\r\n\r\nFixes the ability
for the POST URL used to automate generation of\r\nreports by adding a
`generateExportUrl` function to the ShareMenuItemV2\r\ninterface. This
function returns a dynamic export URL for PDF generation\r\nby using the
selected layout option.\r\n\r\nOther changes: provides more strictness
in type definitions by:\r\n * splitting the types that define
`ShareMenuProvider`:\r\n * `ShareMenuProviderV2` provides the
`getShareMenuItems` function\r\n* `ShareMenuProviderLegacy` provides the
`getShareMenuItemsLegacy`\r\nfunction\r\n\r\n### Release note\r\nFixed
an issue with the export options for PNG/PDF reports in
a\r\ndashboard.\r\n\r\n### Checklist\r\n\r\nDelete any items that are
not applicable to this PR.\r\n\r\n- [x] Use the `generateExportUrl`
function inputs to return a POST URL\r\nthat is aware of the layout mode
(`print` or `preserve_layout`) and\r\nscreen dimensions\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Flaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6986","sha":"38407ae6b01e071757083fe358116b6dd75c4422"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192530","number":192530,"mergeCommit":{"message":"[Reporting]
fix dashboard \"Copy Post URL\" action (#192530)\n\n##
Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/191673\r\nCloseshttps://github.com/elastic/kibana/issues/183566\r\n\r\nFixes the ability
for the POST URL used to automate generation of\r\nreports by adding a
`generateExportUrl` function to the ShareMenuItemV2\r\ninterface. This
function returns a dynamic export URL for PDF generation\r\nby using the
selected layout option.\r\n\r\nOther changes: provides more strictness
in type definitions by:\r\n * splitting the types that define
`ShareMenuProvider`:\r\n * `ShareMenuProviderV2` provides the
`getShareMenuItems` function\r\n* `ShareMenuProviderLegacy` provides the
`getShareMenuItemsLegacy`\r\nfunction\r\n\r\n### Release note\r\nFixed
an issue with the export options for PNG/PDF reports in
a\r\ndashboard.\r\n\r\n### Checklist\r\n\r\nDelete any items that are
not applicable to this PR.\r\n\r\n- [x] Use the `generateExportUrl`
function inputs to return a POST URL\r\nthat is aware of the layout mode
(`print` or `preserve_layout`) and\r\nscreen dimensions\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Flaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6986","sha":"38407ae6b01e071757083fe358116b6dd75c4422"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Fixes https://github.com/elastic/kibana/issues/149344
This PR migrates all plugins to packages automatically. It does this
using `node scripts/lint_packages` to automatically migrate
`kibana.json` files to `kibana.jsonc` files. By doing this automatically
we can simplify many build and testing procedures to only support
packages, and not both "packages" and "synthetic packages" (basically
pointers to plugins).
The majority of changes are in operations related code, so we'll be
having operations review this before marking it ready for review. The
vast majority of the code owners are simply pinged because we deleted
all `kibana.json` files and replaced them with `kibana.jsonc` files, so
we plan on leaving the PR ready-for-review for about 24 hours before
merging (after feature freeze), assuming we don't have any blockers
(especially from @elastic/kibana-core since there are a few core
specific changes, though the majority were handled in #149370).
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Dearest Reviewers 👋
I've been working on this branch with @mistic and @tylersmalley and
we're really confident in these changes. Additionally, this changes code
in nearly every package in the repo so we don't plan to wait for reviews
to get in before merging this. If you'd like to have a concern
addressed, please feel free to leave a review, but assuming that nobody
raises a blocker in the next 24 hours we plan to merge this EOD pacific
tomorrow, 12/22.
We'll be paying close attention to any issues this causes after merging
and work on getting those fixed ASAP. 🚀
---
The operations team is not confident that we'll have the time to achieve
what we originally set out to accomplish by moving to Bazel with the
time and resources we have available. We have also bought ourselves some
headroom with improvements to babel-register, optimizer caching, and
typescript project structure.
In order to make sure we deliver packages as quickly as possible (many
teams really want them), with a usable and familiar developer
experience, this PR removes Bazel for building packages in favor of
using the same JIT transpilation we use for plugins.
Additionally, packages now use `kbn_references` (again, just copying the
dx from plugins to packages).
Because of the complex relationships between packages/plugins and in
order to prepare ourselves for automatic dependency detection tools we
plan to use in the future, this PR also introduces a "TS Project Linter"
which will validate that every tsconfig.json file meets a few
requirements:
1. the chain of base config files extended by each config includes
`tsconfig.base.json` and not `tsconfig.json`
1. the `include` config is used, and not `files`
2. the `exclude` config includes `target/**/*`
3. the `outDir` compiler option is specified as `target/types`
1. none of these compiler options are specified: `declaration`,
`declarationMap`, `emitDeclarationOnly`, `skipLibCheck`, `target`,
`paths`
4. all references to other packages/plugins use their pkg id, ie:
```js
// valid
{
"kbn_references": ["@kbn/core"]
}
// not valid
{
"kbn_references": [{ "path": "../../../src/core/tsconfig.json" }]
}
```
5. only packages/plugins which are imported somewhere in the ts code are
listed in `kbn_references`
This linter is not only validating all of the tsconfig.json files, but
it also will fix these config files to deal with just about any
violation that can be produced. Just run `node scripts/ts_project_linter
--fix` locally to apply these fixes, or let CI take care of
automatically fixing things and pushing the changes to your PR.
> **Example:** [`64e93e5`
(#146212)](64e93e5806)
When I merged main into my PR it included a change which removed the
`@kbn/core-injected-metadata-browser` package. After resolving the
conflicts I missed a few tsconfig files which included references to the
now removed package. The TS Project Linter identified that these
references were removed from the code and pushed a change to the PR to
remove them from the tsconfig.json files.
## No bazel? Does that mean no packages??
Nope! We're still doing packages but we're pretty sure now that we won't
be using Bazel to accomplish the 'distributed caching' and 'change-based
tasks' portions of the packages project.
This PR actually makes packages much easier to work with and will be
followed up with the bundling benefits described by the original
packages RFC. Then we'll work on documentation and advocacy for using
packages for any and all new code.
We're pretty confident that implementing distributed caching and
change-based tasks will be necessary in the future, but because of
recent improvements in the repo we think we can live without them for
**at least** a year.
## Wait, there are still BUILD.bazel files in the repo
Yes, there are still three webpack bundles which are built by Bazel: the
`@kbn/ui-shared-deps-npm` DLL, `@kbn/ui-shared-deps-src` externals, and
the `@kbn/monaco` workers. These three webpack bundles are still created
during bootstrap and remotely cached using bazel. The next phase of this
project is to figure out how to get the package bundling features
described in the RFC with the current optimizer, and we expect these
bundles to go away then. Until then any package that is used in those
three bundles still needs to have a BUILD.bazel file so that they can be
referenced by the remaining webpack builds.
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
