mirror of
https://github.com/elastic/kibana.git
synced 2025-04-23 17:28:26 -04:00
12289 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Kibana Machine
|
7983a6ffdf
|
[8.18] Feature/saml multi tab (#212148) (#218375)
# Backport This will backport the following commits from `main` to `8.18`: - [Feature/saml multi tab (#212148)](https://github.com/elastic/kibana/pull/212148) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kurt","email":"kc13greiner@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-16T03:47:06Z","message":"Feature/saml multi tab (#212148)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/199188\n\nAllow multiple SAML authc calls to succeed.\n\n## Testing \n\nConfigure logging:\n```yaml\nlogging.loggers:\n - name: plugins.security\n level: debug\n```\n\n### See the failure\n\nPull `main` and copy the code from the following files in this PR into\ntheir respective files on that branch:\n\n- `packages/kbn-mock-idp-plugin/public/login_page.tsx`\n- `packages/kbn-mock-idp-plugin/server/plugin.ts`\n- `packages/kbn-mock-idp-utils/src/index.ts`\n- `packages/kbn-mock-idp-utils/src/utils.ts`\n\nStart KB/ES in serverless from this modified main branch\n\nOpen 2 tabs to the local serverless login screen\n\nAs the same user, click login and change tabs and click login again\n\nThe you will get an error.\n\nShut down KB/ES\n\n### See the success\n\nStart KB/ES in serverless from this PR\n\nOpen 2 tabs to the local serverless login screen\n\nAs the same user, click login and change tabs and click login again\n\nBoth should succeed\n\n## Release note\nRefreshing multiple tabs where the user has logged out will\nsimultaneously login successfully\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d7fd324356c72ca95d05e97eeaf796145806ca1b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Security","backport:all-open","ci:cloud-deploy","v9.1.0","v9.0.1"],"title":"Feature/saml multi tab","number":212148,"url":"https://github.com/elastic/kibana/pull/212148","mergeCommit":{"message":"Feature/saml multi tab (#212148)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/199188\n\nAllow multiple SAML authc calls to succeed.\n\n## Testing \n\nConfigure logging:\n```yaml\nlogging.loggers:\n - name: plugins.security\n level: debug\n```\n\n### See the failure\n\nPull `main` and copy the code from the following files in this PR into\ntheir respective files on that branch:\n\n- `packages/kbn-mock-idp-plugin/public/login_page.tsx`\n- `packages/kbn-mock-idp-plugin/server/plugin.ts`\n- `packages/kbn-mock-idp-utils/src/index.ts`\n- `packages/kbn-mock-idp-utils/src/utils.ts`\n\nStart KB/ES in serverless from this modified main branch\n\nOpen 2 tabs to the local serverless login screen\n\nAs the same user, click login and change tabs and click login again\n\nThe you will get an error.\n\nShut down KB/ES\n\n### See the success\n\nStart KB/ES in serverless from this PR\n\nOpen 2 tabs to the local serverless login screen\n\nAs the same user, click login and change tabs and click login again\n\nBoth should succeed\n\n## Release note\nRefreshing multiple tabs where the user has logged out will\nsimultaneously login successfully\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d7fd324356c72ca95d05e97eeaf796145806ca1b"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212148","number":212148,"mergeCommit":{"message":"Feature/saml multi tab (#212148)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/199188\n\nAllow multiple SAML authc calls to succeed.\n\n## Testing \n\nConfigure logging:\n```yaml\nlogging.loggers:\n - name: plugins.security\n level: debug\n```\n\n### See the failure\n\nPull `main` and copy the code from the following files in this PR into\ntheir respective files on that branch:\n\n- `packages/kbn-mock-idp-plugin/public/login_page.tsx`\n- `packages/kbn-mock-idp-plugin/server/plugin.ts`\n- `packages/kbn-mock-idp-utils/src/index.ts`\n- `packages/kbn-mock-idp-utils/src/utils.ts`\n\nStart KB/ES in serverless from this modified main branch\n\nOpen 2 tabs to the local serverless login screen\n\nAs the same user, click login and change tabs and click login again\n\nThe you will get an error.\n\nShut down KB/ES\n\n### See the success\n\nStart KB/ES in serverless from this PR\n\nOpen 2 tabs to the local serverless login screen\n\nAs the same user, click login and change tabs and click login again\n\nBoth should succeed\n\n## Release note\nRefreshing multiple tabs where the user has logged out will\nsimultaneously login successfully\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d7fd324356c72ca95d05e97eeaf796145806ca1b"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Kurt <kc13greiner@users.noreply.github.com> |
||
seanrathier
|
0d8e2fb3ae
|
[8.18] [Cloud Security] Add upgrade agentless deployment background task (#207143) (#218818)
# Backport This will backport the following commits from `main` to `8.18`: - [[Cloud Security] Add upgrade agentless deployment background task (#207143)](https://github.com/elastic/kibana/pull/207143) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Lola","email":"omolola.akinleye@elastic.co"},"sourceCommit":{"committedDate":"2025-02-27T01:56:23Z","message":"[Cloud Security] Add upgrade agentless deployment background task (#207143)\n\n## Summary\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\nThis PR add background task to upgrade Agentless Deployments after\nKibana Stack has been upgrade in ESS. Once the Kibana stack upgrades, the task will do following:\n1. Fetch agentless policies with package policies that have agents\n2. Check if agentless agents version is upgradeable by use `semverLT`\nwhich see if current agent version less than latest available upgrade\nversion and current kibana version\n3. If agent version is upgradedable, then task will calls Agentless\nUpgrade Endpoint to upgrade agentless deployment.\n4. Agent should be upgraded to latest available upgraded version\n\n\n\n\n\n**How to test PR:**\n\nPrerequisite:\nInstall [QAF\nTool](https://docs.elastic.dev/appex-qa/qaf/getting-started)\nCreate EC cloud api key [QAF Elastic\nCloud](https://docs.elastic.dev/appex-qa/qaf/features/ec-deployments)\n\n1. Go to Elastic Cloud and Create ESS Deployment in `8.17.0-SNAPSHOT`\n```qaf elastic-cloud deployments create --environment production --region gcp-us-west2 --stack-version 8.17.0-SNAPSHOT --version-validation --deployment-name <DEPLOYMENT_NAME> ```\n2. Create an Agentless Integration\n3. Upgrade stack to `8.18.0-SNAPSHOT` > `8.19.0-SNAPSHOT`\n4. Run the following QAF command \n```qaf elastic-cloud deployments upgrade <DEPLOYMENT_NAME>\n9.1.0-SNAPSHOT --kb-docker-image\ndocker.elastic.co/kibana-ci/kibana-cloud:9.1.0-SNAPSHOT-5e00106755e7084d1325e784eb27f91db9724c89```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"f8e31e5fcbb28f485e309fbacf9a2aca9f8d3a2c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Fleet","release_note:feature","Team:Cloud Security","backport:prev-minor","ci:cloud-deploy","v9.1.0","v8.19.0","v8.18.1"],"title":"[Cloud Security] Create upgrade agentless deployment background task","number":207143,"url":"https://github.com/elastic/kibana/pull/207143","mergeCommit":{"message":"[Cloud Security] Add upgrade agentless deployment background task (#207143)\n\n## Summary\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\nThis PR add background task to upgrade Agentless Deployments after\nKibana Stack has been upgrade in ESS. Once the Kibana stack upgrades, the task will do following:\n1. Fetch agentless policies with package policies that have agents\n2. Check if agentless agents version is upgradeable by use `semverLT`\nwhich see if current agent version less than latest available upgrade\nversion and current kibana version\n3. If agent version is upgradedable, then task will calls Agentless\nUpgrade Endpoint to upgrade agentless deployment.\n4. Agent should be upgraded to latest available upgraded version\n\n\n\n\n\n**How to test PR:**\n\nPrerequisite:\nInstall [QAF\nTool](https://docs.elastic.dev/appex-qa/qaf/getting-started)\nCreate EC cloud api key [QAF Elastic\nCloud](https://docs.elastic.dev/appex-qa/qaf/features/ec-deployments)\n\n1. Go to Elastic Cloud and Create ESS Deployment in `8.17.0-SNAPSHOT`\n```qaf elastic-cloud deployments create --environment production --region gcp-us-west2 --stack-version 8.17.0-SNAPSHOT --version-validation --deployment-name <DEPLOYMENT_NAME> ```\n2. Create an Agentless Integration\n3. Upgrade stack to `8.18.0-SNAPSHOT` > `8.19.0-SNAPSHOT`\n4. Run the following QAF command \n```qaf elastic-cloud deployments upgrade <DEPLOYMENT_NAME>\n9.1.0-SNAPSHOT --kb-docker-image\ndocker.elastic.co/kibana-ci/kibana-cloud:9.1.0-SNAPSHOT-5e00106755e7084d1325e784eb27f91db9724c89```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"f8e31e5fcbb28f485e309fbacf9a2aca9f8d3a2c"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207143","number":207143,"mergeCommit":{"message":"[Cloud Security] Add upgrade agentless deployment background task (#207143)\n\n## Summary\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\nThis PR add background task to upgrade Agentless Deployments after\nKibana Stack has been upgrade in ESS. Once the Kibana stack upgrades, the task will do following:\n1. Fetch agentless policies with package policies that have agents\n2. Check if agentless agents version is upgradeable by use `semverLT`\nwhich see if current agent version less than latest available upgrade\nversion and current kibana version\n3. If agent version is upgradedable, then task will calls Agentless\nUpgrade Endpoint to upgrade agentless deployment.\n4. Agent should be upgraded to latest available upgraded version\n\n\n\n\n\n**How to test PR:**\n\nPrerequisite:\nInstall [QAF\nTool](https://docs.elastic.dev/appex-qa/qaf/getting-started)\nCreate EC cloud api key [QAF Elastic\nCloud](https://docs.elastic.dev/appex-qa/qaf/features/ec-deployments)\n\n1. Go to Elastic Cloud and Create ESS Deployment in `8.17.0-SNAPSHOT`\n```qaf elastic-cloud deployments create --environment production --region gcp-us-west2 --stack-version 8.17.0-SNAPSHOT --version-validation --deployment-name <DEPLOYMENT_NAME> ```\n2. Create an Agentless Integration\n3. Upgrade stack to `8.18.0-SNAPSHOT` > `8.19.0-SNAPSHOT`\n4. Run the following QAF command \n```qaf elastic-cloud deployments upgrade <DEPLOYMENT_NAME>\n9.1.0-SNAPSHOT --kb-docker-image\ndocker.elastic.co/kibana-ci/kibana-cloud:9.1.0-SNAPSHOT-5e00106755e7084d1325e784eb27f91db9724c89```\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"f8e31e5fcbb28f485e309fbacf9a2aca9f8d3a2c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/213134","number":213134,"state":"MERGED","mergeCommit":{"sha":"5b98df8f790c2f9212790c1973b54f19c0d18799","message":"[8.x] [Cloud Security] Add upgrade agentless deployment background task (#207143) (#213134)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Cloud Security] Add upgrade agentless deployment background task\n(#207143)](https://github.com/elastic/kibana/pull/207143)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Lola <omolola.akinleye@elastic.co> |
||
|
Kibana Machine
|
f83f7de27e
|
[8.18] [Security Solution][Telemetry] Add index metadata EBT event (#218546) (#218600)
# Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution][Telemetry] Add index metadata EBT event (#218546)](https://github.com/elastic/kibana/pull/218546) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sebastián Zaffarano","email":"sebastian.zaffarano@elastic.co"},"sourceCommit":{"committedDate":"2025-04-17T18:00:26Z","message":"[Security Solution][Telemetry] Add index metadata EBT event (#218546)\n\n## Summary\n\n\n\n- Fix https://github.com/elastic/kibana/issues/216044\n- Add a new EBT event collecting index template info\n ```typescript\n export interface IndexTemplateInfo {\n template_name: string;\n index_mode: Nullable<string>;\n datastream: boolean;\n package_name: Nullable<string>;\n managed_by: Nullable<string>;\n beat: Nullable<string>;\n is_managed: Nullable<boolean>;\n composed_of: string[];\n source_enabled: Nullable<boolean>;\n source_includes: string[];\n source_excludes: string[];\n }\n ```\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"c9b3a3e27b27f977f0ce494fc1b52d6166b21511","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","ci:build-cloud-image","v9.1.0"],"title":"[Security Solution][Telemetry] Add index metadata EBT event","number":218546,"url":"https://github.com/elastic/kibana/pull/218546","mergeCommit":{"message":"[Security Solution][Telemetry] Add index metadata EBT event (#218546)\n\n## Summary\n\n\n\n- Fix https://github.com/elastic/kibana/issues/216044\n- Add a new EBT event collecting index template info\n ```typescript\n export interface IndexTemplateInfo {\n template_name: string;\n index_mode: Nullable<string>;\n datastream: boolean;\n package_name: Nullable<string>;\n managed_by: Nullable<string>;\n beat: Nullable<string>;\n is_managed: Nullable<boolean>;\n composed_of: string[];\n source_enabled: Nullable<boolean>;\n source_includes: string[];\n source_excludes: string[];\n }\n ```\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"c9b3a3e27b27f977f0ce494fc1b52d6166b21511"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218546","number":218546,"mergeCommit":{"message":"[Security Solution][Telemetry] Add index metadata EBT event (#218546)\n\n## Summary\n\n\n\n- Fix https://github.com/elastic/kibana/issues/216044\n- Add a new EBT event collecting index template info\n ```typescript\n export interface IndexTemplateInfo {\n template_name: string;\n index_mode: Nullable<string>;\n datastream: boolean;\n package_name: Nullable<string>;\n managed_by: Nullable<string>;\n beat: Nullable<string>;\n is_managed: Nullable<boolean>;\n composed_of: string[];\n source_enabled: Nullable<boolean>;\n source_includes: string[];\n source_excludes: string[];\n }\n ```\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"c9b3a3e27b27f977f0ce494fc1b52d6166b21511"}}]}] BACKPORT--> Co-authored-by: Sebastián Zaffarano <sebastian.zaffarano@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
Nicolas Chaulet
|
7734d99700
|
[8.18] [Fleet] Fix fleet server policy creation with non es default output (#214590) (#218656)
# Backport This will backport the following commits from `main` to `8.18`: - [[Fleet] Fix fleet server policy creation with non es default output (#214590)](https://github.com/elastic/kibana/pull/214590) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2025-03-17T19:14:25Z","message":"[Fleet] Fix fleet server policy creation with non es default output (#214590)","sha":"6ed6d02f37c67935cfb25aa9bb075096d4b6351a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","Team:Fleet","backport:prev-minor","backport:version","v9.1.0","v8.18.1"],"title":"[Fleet] Fix fleet server policy creation with non es default output","number":214590,"url":"https://github.com/elastic/kibana/pull/214590","mergeCommit":{"message":"[Fleet] Fix fleet server policy creation with non es default output (#214590)","sha":"6ed6d02f37c67935cfb25aa9bb075096d4b6351a"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214590","number":214590,"mergeCommit":{"message":"[Fleet] Fix fleet server policy creation with non es default output (#214590)","sha":"6ed6d02f37c67935cfb25aa9bb075096d4b6351a"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
Marshall Main
|
a2630eb4ab
|
[8.18] [Security Solution][Rules Management] Separate actions import logic from rules import (#216380) (#218484)
# Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution][Rules Management] Separate actions import logic from rules import (#216380)](https://github.com/elastic/kibana/pull/216380) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marshall Main","email":"55718608+marshallmain@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-16T15:47:26Z","message":"[Security Solution][Rules Management] Separate actions import logic from rules import (#216380)\n\n## Summary\n\nRedo of https://github.com/elastic/kibana/pull/193471\nCloses https://github.com/elastic/security-team/issues/8644\n\n> Fixes a bug where importing a rule fails with a connector into a space\nwhere (1) the connector already exists, and (2) the existing connector\nwas exported and re-imported from another space. The import logic in\nthis scenario effectively tries to convert the action ID on the rule\nimport twice. The second conversion attempt tries to use the old action\nID to look up the correct new action ID in a map, however, in this test\nscenario the action ID has already been updated by legacy SO ID\nmigration logic and there is no map entry with the new ID as a key. The\nresult is that the second attempt sets the action ID to undefined,\nresulting in an import failure.\n\nThe root cause of the bug is that we have two different places in the\nrule import logic where action IDs are migrated. The first ID migration\nwas done by `migrateLegacyActionsIds` prior to importing rule actions,\nand the second migration was done by `importRuleActionConnectors` after\nimporting the actions. `importRuleActionConnectors` used a lookup table\nto convert old IDs to new IDs, but if the connector already existed and\nhad an `originId` then the rule action would already be migrated by\n`migrateLegacyActionsIds`. The lookup table used by\n`importRuleActionConnectors` does not have entries for migrated IDs,\nonly the original IDs, so in that case the result of the lookup is\n`undefined` which we assign to the action ID.\n\nThis PR reworks the logic to create a clean separation between action\nand rule import. We now import the connectors first, ignoring the rules,\nthen migrate action IDs on the rules afterwards. This handles connectors\nchanging IDs in any way, either through the 7.x->8.0 migration long ago\nor IDs changing on import if there are ID conflicts. Only after the\nconnectors are imported and rule actions are migrated do we then verify\nif each rule action references a connector ID that actually exists with\nthe new `checkRuleActions` function, replacing\n`checkIfActionsHaveMissingConnectors` and related functions that were\nalso buggy.\n\nFinally, as a nice side effect this rework removes \"rule action\nconnector missing\" errors out of the `action_connector_errors` part of\nthe response. `action_connector_errors` is reserved for errors importing\nconnectors specifically. If a rule action is missing a connector and\ntherefore we don't import the rule, that's a rule error and it's\nrepresented in the `errors` part of the response. Since the shape of the\nresponse is not changing, I don't consider this a breaking change but\nrather a bug fix.\n\n## Repro Steps\n\nRepro Steps\n1. Download the export file below and change the extension back to\n.ndjson from .json (github does not allow .ndjson files\n\n[rules_export.json](https://github.com/user-attachments/files/17065272/rules_export.json)\n2. Import the rule and connector into a space (default is fine)\n3. Create a new space\n4. Import the rule and connector into the new space\n5. Import the rule and connector into the new space again, but check the\n`Overwrite existing connectors with conflicting action \"id\"` box.\nObserve the failure.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"52ecdd0ac76e6f56ff799399f453596c0cb3538c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detection Rule Management","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Security Solution][Rules Management] Separate actions import logic from rules import","number":216380,"url":"https://github.com/elastic/kibana/pull/216380","mergeCommit":{"message":"[Security Solution][Rules Management] Separate actions import logic from rules import (#216380)\n\n## Summary\n\nRedo of https://github.com/elastic/kibana/pull/193471\nCloses https://github.com/elastic/security-team/issues/8644\n\n> Fixes a bug where importing a rule fails with a connector into a space\nwhere (1) the connector already exists, and (2) the existing connector\nwas exported and re-imported from another space. The import logic in\nthis scenario effectively tries to convert the action ID on the rule\nimport twice. The second conversion attempt tries to use the old action\nID to look up the correct new action ID in a map, however, in this test\nscenario the action ID has already been updated by legacy SO ID\nmigration logic and there is no map entry with the new ID as a key. The\nresult is that the second attempt sets the action ID to undefined,\nresulting in an import failure.\n\nThe root cause of the bug is that we have two different places in the\nrule import logic where action IDs are migrated. The first ID migration\nwas done by `migrateLegacyActionsIds` prior to importing rule actions,\nand the second migration was done by `importRuleActionConnectors` after\nimporting the actions. `importRuleActionConnectors` used a lookup table\nto convert old IDs to new IDs, but if the connector already existed and\nhad an `originId` then the rule action would already be migrated by\n`migrateLegacyActionsIds`. The lookup table used by\n`importRuleActionConnectors` does not have entries for migrated IDs,\nonly the original IDs, so in that case the result of the lookup is\n`undefined` which we assign to the action ID.\n\nThis PR reworks the logic to create a clean separation between action\nand rule import. We now import the connectors first, ignoring the rules,\nthen migrate action IDs on the rules afterwards. This handles connectors\nchanging IDs in any way, either through the 7.x->8.0 migration long ago\nor IDs changing on import if there are ID conflicts. Only after the\nconnectors are imported and rule actions are migrated do we then verify\nif each rule action references a connector ID that actually exists with\nthe new `checkRuleActions` function, replacing\n`checkIfActionsHaveMissingConnectors` and related functions that were\nalso buggy.\n\nFinally, as a nice side effect this rework removes \"rule action\nconnector missing\" errors out of the `action_connector_errors` part of\nthe response. `action_connector_errors` is reserved for errors importing\nconnectors specifically. If a rule action is missing a connector and\ntherefore we don't import the rule, that's a rule error and it's\nrepresented in the `errors` part of the response. Since the shape of the\nresponse is not changing, I don't consider this a breaking change but\nrather a bug fix.\n\n## Repro Steps\n\nRepro Steps\n1. Download the export file below and change the extension back to\n.ndjson from .json (github does not allow .ndjson files\n\n[rules_export.json](https://github.com/user-attachments/files/17065272/rules_export.json)\n2. Import the rule and connector into a space (default is fine)\n3. Create a new space\n4. Import the rule and connector into the new space\n5. Import the rule and connector into the new space again, but check the\n`Overwrite existing connectors with conflicting action \"id\"` box.\nObserve the failure.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"52ecdd0ac76e6f56ff799399f453596c0cb3538c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216380","number":216380,"mergeCommit":{"message":"[Security Solution][Rules Management] Separate actions import logic from rules import (#216380)\n\n## Summary\n\nRedo of https://github.com/elastic/kibana/pull/193471\nCloses https://github.com/elastic/security-team/issues/8644\n\n> Fixes a bug where importing a rule fails with a connector into a space\nwhere (1) the connector already exists, and (2) the existing connector\nwas exported and re-imported from another space. The import logic in\nthis scenario effectively tries to convert the action ID on the rule\nimport twice. The second conversion attempt tries to use the old action\nID to look up the correct new action ID in a map, however, in this test\nscenario the action ID has already been updated by legacy SO ID\nmigration logic and there is no map entry with the new ID as a key. The\nresult is that the second attempt sets the action ID to undefined,\nresulting in an import failure.\n\nThe root cause of the bug is that we have two different places in the\nrule import logic where action IDs are migrated. The first ID migration\nwas done by `migrateLegacyActionsIds` prior to importing rule actions,\nand the second migration was done by `importRuleActionConnectors` after\nimporting the actions. `importRuleActionConnectors` used a lookup table\nto convert old IDs to new IDs, but if the connector already existed and\nhad an `originId` then the rule action would already be migrated by\n`migrateLegacyActionsIds`. The lookup table used by\n`importRuleActionConnectors` does not have entries for migrated IDs,\nonly the original IDs, so in that case the result of the lookup is\n`undefined` which we assign to the action ID.\n\nThis PR reworks the logic to create a clean separation between action\nand rule import. We now import the connectors first, ignoring the rules,\nthen migrate action IDs on the rules afterwards. This handles connectors\nchanging IDs in any way, either through the 7.x->8.0 migration long ago\nor IDs changing on import if there are ID conflicts. Only after the\nconnectors are imported and rule actions are migrated do we then verify\nif each rule action references a connector ID that actually exists with\nthe new `checkRuleActions` function, replacing\n`checkIfActionsHaveMissingConnectors` and related functions that were\nalso buggy.\n\nFinally, as a nice side effect this rework removes \"rule action\nconnector missing\" errors out of the `action_connector_errors` part of\nthe response. `action_connector_errors` is reserved for errors importing\nconnectors specifically. If a rule action is missing a connector and\ntherefore we don't import the rule, that's a rule error and it's\nrepresented in the `errors` part of the response. Since the shape of the\nresponse is not changing, I don't consider this a breaking change but\nrather a bug fix.\n\n## Repro Steps\n\nRepro Steps\n1. Download the export file below and change the extension back to\n.ndjson from .json (github does not allow .ndjson files\n\n[rules_export.json](https://github.com/user-attachments/files/17065272/rules_export.json)\n2. Import the rule and connector into a space (default is fine)\n3. Create a new space\n4. Import the rule and connector into the new space\n5. Import the rule and connector into the new space again, but check the\n`Overwrite existing connectors with conflicting action \"id\"` box.\nObserve the failure.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"52ecdd0ac76e6f56ff799399f453596c0cb3538c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/218466","number":218466,"state":"OPEN"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/218465","number":218465,"state":"OPEN"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/218467","number":218467,"state":"OPEN"}]}] BACKPORT--> |
||
elastic-vault-github-plugin-prod[bot]
|
1aeb2fc384
|
[8.18] Sync bundled packages with Package Storage (#217540)
Automated by https://buildkite.com/elastic/package-storage-infra-kibana-discover-release-branches/builds/2596 --------- Co-authored-by: elasticmachine <elasticmachine@elastic.co> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com> |
||
Milosz Marcinkowski
|
6d7097d6be
|
[8.18] [APM][UI] Sort environment dropdown alphabetically (#217710) (#217880)
# Backport This will backport the following commits from `main` to `8.18`: - [[APM][UI] Sort environment dropdown alphabetically (#217710)](https://github.com/elastic/kibana/pull/217710) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Milosz Marcinkowski","email":"38698566+miloszmarcinkowski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-10T15:38:20Z","message":"[APM][UI] Sort environment dropdown alphabetically (#217710)\n\nCloses #217814\n\n### Summary\n\nSort environment list alphabetically.\n\n|Before|After|\n|-|-|\n|<img width=\"1724\" alt=\"Screenshot 2025-04-10 at 12 01 15\"\nsrc=\"https://github.com/user-attachments/assets/53f0b66d-146a-45d9-b4e3-25bde350a263\"\n/>|<img width=\"1722\" alt=\"Screenshot 2025-04-10 at 11 58 27\"\nsrc=\"https://github.com/user-attachments/assets/91315d23-801c-4a16-8688-c43d60c389c8\"\n/>|","sha":"23cbaa6d55de4e331ce180f6857db94ca11c209a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-major","Team:obs-ux-infra_services","v9.1.0"],"title":"[APM][UI] Sort environment dropdown alphabetically","number":217710,"url":"https://github.com/elastic/kibana/pull/217710","mergeCommit":{"message":"[APM][UI] Sort environment dropdown alphabetically (#217710)\n\nCloses #217814\n\n### Summary\n\nSort environment list alphabetically.\n\n|Before|After|\n|-|-|\n|<img width=\"1724\" alt=\"Screenshot 2025-04-10 at 12 01 15\"\nsrc=\"https://github.com/user-attachments/assets/53f0b66d-146a-45d9-b4e3-25bde350a263\"\n/>|<img width=\"1722\" alt=\"Screenshot 2025-04-10 at 11 58 27\"\nsrc=\"https://github.com/user-attachments/assets/91315d23-801c-4a16-8688-c43d60c389c8\"\n/>|","sha":"23cbaa6d55de4e331ce180f6857db94ca11c209a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217710","number":217710,"mergeCommit":{"message":"[APM][UI] Sort environment dropdown alphabetically (#217710)\n\nCloses #217814\n\n### Summary\n\nSort environment list alphabetically.\n\n|Before|After|\n|-|-|\n|<img width=\"1724\" alt=\"Screenshot 2025-04-10 at 12 01 15\"\nsrc=\"https://github.com/user-attachments/assets/53f0b66d-146a-45d9-b4e3-25bde350a263\"\n/>|<img width=\"1722\" alt=\"Screenshot 2025-04-10 at 11 58 27\"\nsrc=\"https://github.com/user-attachments/assets/91315d23-801c-4a16-8688-c43d60c389c8\"\n/>|","sha":"23cbaa6d55de4e331ce180f6857db94ca11c209a"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
Julia Rechkunova
|
43fde917fb
|
[8.18] [Discover] Fix CSV for ES|QL embeddable (#216325) (#216868)
# Backport This will backport the following commits from `main` to `8.18`: - [[Discover] Fix CSV for ES|QL embeddable (#216325)](https://github.com/elastic/kibana/pull/216325) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-04-02T13:14:55Z","message":"[Discover] Fix CSV for ES|QL embeddable (#216325)\n\n- Closes https://github.com/elastic/kibana/issues/215893\n\n## Summary\n\nThis PR extract the logic from Share > Export > Generate CSV into new\nutils and uses it to fix CSV export for Dashboard panels.\n\n<img width=\"903\" alt=\"Screenshot 2025-04-01 at 12 05 58\"\nsrc=\"https://github.com/user-attachments/assets/20e611d7-b1da-4b50-a8fc-e18ac3db3a55\"\n/>\n\n\n## Testing\n\nPlease test for both data view mode and ES|QL mode. The steps are the\nfollowing:\n1. Save a discover session\n2. Add it to a new dashboard\n3. Save the Dashboard and switch to View mode\n4. Via panel actions, press \"Generate CSV report\"\n5. Compare the CSV results with what is shown in the grid\n6. Add a custom time range to the panel via panel actions \"Settings\"\n7. Generate a CSV report and compare results again\n\nAlso check that reporting still works when generated from Discover page.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"dc78614d29da8f64f77840d3fc02846fcacfe2e5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","v9.0.0","Team:DataDiscovery","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Discover] Fix CSV for ES|QL embeddable","number":216325,"url":"https://github.com/elastic/kibana/pull/216325","mergeCommit":{"message":"[Discover] Fix CSV for ES|QL embeddable (#216325)\n\n- Closes https://github.com/elastic/kibana/issues/215893\n\n## Summary\n\nThis PR extract the logic from Share > Export > Generate CSV into new\nutils and uses it to fix CSV export for Dashboard panels.\n\n<img width=\"903\" alt=\"Screenshot 2025-04-01 at 12 05 58\"\nsrc=\"https://github.com/user-attachments/assets/20e611d7-b1da-4b50-a8fc-e18ac3db3a55\"\n/>\n\n\n## Testing\n\nPlease test for both data view mode and ES|QL mode. The steps are the\nfollowing:\n1. Save a discover session\n2. Add it to a new dashboard\n3. Save the Dashboard and switch to View mode\n4. Via panel actions, press \"Generate CSV report\"\n5. Compare the CSV results with what is shown in the grid\n6. Add a custom time range to the panel via panel actions \"Settings\"\n7. Generate a CSV report and compare results again\n\nAlso check that reporting still works when generated from Discover page.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"dc78614d29da8f64f77840d3fc02846fcacfe2e5"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216325","number":216325,"mergeCommit":{"message":"[Discover] Fix CSV for ES|QL embeddable (#216325)\n\n- Closes https://github.com/elastic/kibana/issues/215893\n\n## Summary\n\nThis PR extract the logic from Share > Export > Generate CSV into new\nutils and uses it to fix CSV export for Dashboard panels.\n\n<img width=\"903\" alt=\"Screenshot 2025-04-01 at 12 05 58\"\nsrc=\"https://github.com/user-attachments/assets/20e611d7-b1da-4b50-a8fc-e18ac3db3a55\"\n/>\n\n\n## Testing\n\nPlease test for both data view mode and ES|QL mode. The steps are the\nfollowing:\n1. Save a discover session\n2. Add it to a new dashboard\n3. Save the Dashboard and switch to View mode\n4. Via panel actions, press \"Generate CSV report\"\n5. Compare the CSV results with what is shown in the grid\n6. Add a custom time range to the panel via panel actions \"Settings\"\n7. Generate a CSV report and compare results again\n\nAlso check that reporting still works when generated from Discover page.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"dc78614d29da8f64f77840d3fc02846fcacfe2e5"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216851","number":216851,"state":"OPEN"}]}] BACKPORT--> |
||
|
Kibana Machine
|
6ccf8447c6 | skip failing test suite (#207913) | ||
|
Kibana Machine
|
f1b0ff7404
|
[8.18] [Security Solution] Remove hardcoded ids of preconfigured connectors from Security Solution Cypress tests (#217847) (#217972)
# Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Remove hardcoded ids of preconfigured connectors from Security Solution Cypress tests (#217847)](https://github.com/elastic/kibana/pull/217847) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Georgii Gorbachev","email":"georgii.gorbachev@elastic.co"},"sourceCommit":{"committedDate":"2025-04-11T10:47:23Z","message":"[Security Solution] Remove hardcoded ids of preconfigured connectors from Security Solution Cypress tests (#217847)\n\n## Summary\n\n[Preconfigured\nconnectors](https://www.elastic.co/guide/en/kibana/current/pre-configured-connectors.html)\nare those that are specified via the `kibana.yml` config, and thus they\ncan't be deleted. In tests, we've hardcoded their ids to skip deleting\nthem when we need to clean up the tests' state.\n\nSometimes, the id of a preconfigured connector gets changed by somebody,\nwhich breaks tests of multiple teams in MKI pipelines, such as the\nperiodic pipeline or the release quality gates. The problem is that it\ndoesn't happen on CI where Kibana doesn't have any preconfigured\nconnectors, so this feedback loop is too long. When tests in an MKI\npipeline break, it's not immediately clear what happened and who should\nfix it. Eventually it gets fixed by someone [like\nthis](https://github.com/elastic/kibana/pull/217570/files).\n\nInstead of hardcoding the ids, we should dynamically determine if a\nconnector is preconfigured and if it should be deleted by a test or not.\nThis is possible to do as each connector has the corresponding\n`is_preconfigured` property.\n\n<img width=\"1073\" alt=\"Screenshot 2025-04-10 at 14 16 15\"\nsrc=\"https://github.com/user-attachments/assets/e330cd5f-c9f0-43da-b4b4-f2a0a2fd10a5\"\n/>\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b4d3a2a8f2b135436ea510c52aa82e4a77d6fca8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Team:Threat Hunting:Explore","Team:Detection Engine","Team:Security Generative AI","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Security Solution] Remove hardcoded ids of preconfigured connectors from Security Solution Cypress tests","number":217847,"url":"https://github.com/elastic/kibana/pull/217847","mergeCommit":{"message":"[Security Solution] Remove hardcoded ids of preconfigured connectors from Security Solution Cypress tests (#217847)\n\n## Summary\n\n[Preconfigured\nconnectors](https://www.elastic.co/guide/en/kibana/current/pre-configured-connectors.html)\nare those that are specified via the `kibana.yml` config, and thus they\ncan't be deleted. In tests, we've hardcoded their ids to skip deleting\nthem when we need to clean up the tests' state.\n\nSometimes, the id of a preconfigured connector gets changed by somebody,\nwhich breaks tests of multiple teams in MKI pipelines, such as the\nperiodic pipeline or the release quality gates. The problem is that it\ndoesn't happen on CI where Kibana doesn't have any preconfigured\nconnectors, so this feedback loop is too long. When tests in an MKI\npipeline break, it's not immediately clear what happened and who should\nfix it. Eventually it gets fixed by someone [like\nthis](https://github.com/elastic/kibana/pull/217570/files).\n\nInstead of hardcoding the ids, we should dynamically determine if a\nconnector is preconfigured and if it should be deleted by a test or not.\nThis is possible to do as each connector has the corresponding\n`is_preconfigured` property.\n\n<img width=\"1073\" alt=\"Screenshot 2025-04-10 at 14 16 15\"\nsrc=\"https://github.com/user-attachments/assets/e330cd5f-c9f0-43da-b4b4-f2a0a2fd10a5\"\n/>\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b4d3a2a8f2b135436ea510c52aa82e4a77d6fca8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217847","number":217847,"mergeCommit":{"message":"[Security Solution] Remove hardcoded ids of preconfigured connectors from Security Solution Cypress tests (#217847)\n\n## Summary\n\n[Preconfigured\nconnectors](https://www.elastic.co/guide/en/kibana/current/pre-configured-connectors.html)\nare those that are specified via the `kibana.yml` config, and thus they\ncan't be deleted. In tests, we've hardcoded their ids to skip deleting\nthem when we need to clean up the tests' state.\n\nSometimes, the id of a preconfigured connector gets changed by somebody,\nwhich breaks tests of multiple teams in MKI pipelines, such as the\nperiodic pipeline or the release quality gates. The problem is that it\ndoesn't happen on CI where Kibana doesn't have any preconfigured\nconnectors, so this feedback loop is too long. When tests in an MKI\npipeline break, it's not immediately clear what happened and who should\nfix it. Eventually it gets fixed by someone [like\nthis](https://github.com/elastic/kibana/pull/217570/files).\n\nInstead of hardcoding the ids, we should dynamically determine if a\nconnector is preconfigured and if it should be deleted by a test or not.\nThis is possible to do as each connector has the corresponding\n`is_preconfigured` property.\n\n<img width=\"1073\" alt=\"Screenshot 2025-04-10 at 14 16 15\"\nsrc=\"https://github.com/user-attachments/assets/e330cd5f-c9f0-43da-b4b4-f2a0a2fd10a5\"\n/>\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"b4d3a2a8f2b135436ea510c52aa82e4a77d6fca8"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co> |
||
Georgii Gorbachev
|
6bedafe4c0
|
[8.18] [Security Solution] Improving documentations for bulk_actions (#216852) (#217824)
# Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Improving documentations for bulk_actions (#216852)](https://github.com/elastic/kibana/pull/216852) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jacek Kolezynski","email":"jacek.kolezynski@elastic.co"},"sourceCommit":{"committedDate":"2025-04-09T16:03:19Z","message":"[Security Solution] Improving documentations for bulk_actions (#216852)\n\n**Resolves: https://github.com/elastic/security-docs/issues/3019**\n\n## Summary\nIn this PR I am improving documentation for the bulk_actions endpoint.\nThe focus is on improving descriptions of parameters and providing\nexamples for all important situations, especially setting / adding\nactions.\n\n# Testing\n1. cd x-pack/solutions/security/plugins/security_solution\n2. yarn openapi:bundle:detections \n3. Take the bundled file\n(docs/openapi/ess/security_solution_detections_api_2023_10_31.bundled.schema.yaml)\nand load it into bump.sh console to see the changes.\n4. Compare the changes with the [Legacy\ndocumentation](https://www.elastic.co/guide/en/security/current/rule-api-overview.html)\n\nYou can also use this [link](https://bump.sh/jkelas/doc/kibana_wip/)\nwhere I deployed the generated bundled doc.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"9d659b76dd31364ef5a4d4b5292f5988de1dca77","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","APIDocs","Team:Detection Rule Management","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Security Solution] Improving documentations for bulk_actions","number":216852,"url":"https://github.com/elastic/kibana/pull/216852","mergeCommit":{"message":"[Security Solution] Improving documentations for bulk_actions (#216852)\n\n**Resolves: https://github.com/elastic/security-docs/issues/3019**\n\n## Summary\nIn this PR I am improving documentation for the bulk_actions endpoint.\nThe focus is on improving descriptions of parameters and providing\nexamples for all important situations, especially setting / adding\nactions.\n\n# Testing\n1. cd x-pack/solutions/security/plugins/security_solution\n2. yarn openapi:bundle:detections \n3. Take the bundled file\n(docs/openapi/ess/security_solution_detections_api_2023_10_31.bundled.schema.yaml)\nand load it into bump.sh console to see the changes.\n4. Compare the changes with the [Legacy\ndocumentation](https://www.elastic.co/guide/en/security/current/rule-api-overview.html)\n\nYou can also use this [link](https://bump.sh/jkelas/doc/kibana_wip/)\nwhere I deployed the generated bundled doc.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"9d659b76dd31364ef5a4d4b5292f5988de1dca77"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/217717","number":217717,"state":"MERGED","mergeCommit":{"sha":"91cdba78ba8586974f5cb317fb33e8c0cbf32e60","message":"[9.0] [Security Solution] Improving documentations for bulk_actions (#216852) (#217717)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Improving documentations for bulk_actions\n(#216852)](https://github.com/elastic/kibana/pull/216852)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Jacek Kolezynski <jacek.kolezynski@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216852","number":216852,"mergeCommit":{"message":"[Security Solution] Improving documentations for bulk_actions (#216852)\n\n**Resolves: https://github.com/elastic/security-docs/issues/3019**\n\n## Summary\nIn this PR I am improving documentation for the bulk_actions endpoint.\nThe focus is on improving descriptions of parameters and providing\nexamples for all important situations, especially setting / adding\nactions.\n\n# Testing\n1. cd x-pack/solutions/security/plugins/security_solution\n2. yarn openapi:bundle:detections \n3. Take the bundled file\n(docs/openapi/ess/security_solution_detections_api_2023_10_31.bundled.schema.yaml)\nand load it into bump.sh console to see the changes.\n4. Compare the changes with the [Legacy\ndocumentation](https://www.elastic.co/guide/en/security/current/rule-api-overview.html)\n\nYou can also use this [link](https://bump.sh/jkelas/doc/kibana_wip/)\nwhere I deployed the generated bundled doc.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"9d659b76dd31364ef5a4d4b5292f5988de1dca77"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/217716","number":217716,"state":"MERGED","mergeCommit":{"sha":"3fa939ea4d4b7e3ec59009782c638ccb3dda95ac","message":"[8.x] [Security Solution] Improving documentations for bulk_actions (#216852) (#217716)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Security Solution] Improving documentations for bulk_actions\n(#216852)](https://github.com/elastic/kibana/pull/216852)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\n---------\n\nCo-authored-by: Jacek Kolezynski <jacek.kolezynski@elastic.co>"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jacek Kolezynski <jacek.kolezynski@elastic.co> |
||
|
Kibana Machine
|
c86177c561 | skip failing test suite (#144057) | ||
|
Kibana Machine
|
fd1ad53887 | skip failing test suite (#191707) | ||
|
Kibana Machine
|
b652d91bd4
|
[8.18] [index mgmt] Fix preview of index templates which are used by data streams (#217604) (#217737)
# Backport This will backport the following commits from `main` to `8.18`: - [[index mgmt] Fix preview of index templates which are used by data streams (#217604)](https://github.com/elastic/kibana/pull/217604) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2025-04-09T17:29:12Z","message":"[index mgmt] Fix preview of index templates which are used by data streams (#217604)\n\n## Summary\n\nFixes error message when attempting to preview an index template which\nis used by a data stream.\n\nWhen previewing a saved index template, a index template name and index\npattern were provided. If the index pattern didn't match data streams\nthat relied on the index template (and they never did) an error would be\nshown. As it turns out, supplying the index pattern was entirely\nunnecessary. This PR simply removes the index pattern from the api call\nand adds a test to make sure that preview functionality works when index\ntemplates match data streams.\n\nFollow up to https://github.com/elastic/kibana/pull/195174\n\nCloses https://github.com/elastic/kibana/issues/212781","sha":"b542a760cf5c87900c87b3f5424749eec52366c6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Index Management","Team:Kibana Management","backport:prev-major","v9.1.0"],"title":"[index mgmt] Fix preview of index templates which are used by data streams","number":217604,"url":"https://github.com/elastic/kibana/pull/217604","mergeCommit":{"message":"[index mgmt] Fix preview of index templates which are used by data streams (#217604)\n\n## Summary\n\nFixes error message when attempting to preview an index template which\nis used by a data stream.\n\nWhen previewing a saved index template, a index template name and index\npattern were provided. If the index pattern didn't match data streams\nthat relied on the index template (and they never did) an error would be\nshown. As it turns out, supplying the index pattern was entirely\nunnecessary. This PR simply removes the index pattern from the api call\nand adds a test to make sure that preview functionality works when index\ntemplates match data streams.\n\nFollow up to https://github.com/elastic/kibana/pull/195174\n\nCloses https://github.com/elastic/kibana/issues/212781","sha":"b542a760cf5c87900c87b3f5424749eec52366c6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217604","number":217604,"mergeCommit":{"message":"[index mgmt] Fix preview of index templates which are used by data streams (#217604)\n\n## Summary\n\nFixes error message when attempting to preview an index template which\nis used by a data stream.\n\nWhen previewing a saved index template, a index template name and index\npattern were provided. If the index pattern didn't match data streams\nthat relied on the index template (and they never did) an error would be\nshown. As it turns out, supplying the index pattern was entirely\nunnecessary. This PR simply removes the index pattern from the api call\nand adds a test to make sure that preview functionality works when index\ntemplates match data streams.\n\nFollow up to https://github.com/elastic/kibana/pull/195174\n\nCloses https://github.com/elastic/kibana/issues/212781","sha":"b542a760cf5c87900c87b3f5424749eec52366c6"}}]}] BACKPORT--> Co-authored-by: Matthew Kime <matt@mattki.me> |
||
Melissa Alvarez
|
9d35cfb9f8
|
[8.18] Update preconfigured connector name (#217570) (#217726)
## Summary Backports Update preconfigured connector name #217570 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... |
||
|
Kibana Machine
|
b8d97e35b1 | skip failing test suite (#207913) | ||
|
Kibana Machine
|
6d142b805e | skip failing test suite (#213821) | ||
|
Julia Rechkunova
|
f5554b642c
|
[8.18] [ES|QL] Fix CSV report time range when exporting from Discover (#216792) (#217181)
# Backport This will backport the following commits from `main` to `8.18`: - [[ES|QL] Fix CSV report time range when exporting from Discover (#216792)](https://github.com/elastic/kibana/pull/216792) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-04-04T10:54:45Z","message":"[ES|QL] Fix CSV report time range when exporting from Discover (#216792)\n\n- Closes https://github.com/elastic/kibana/issues/216605\n\n## Summary\n\nThis PR makes sure to use the absolute time range when generating a CSV\nreport in ES|QL mode.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"6a0c173b1ad6152ee75bc2e74dfd71e74fa6b54a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:DataDiscovery","Feature:ES|QL","Feature:Reporting:CSV","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[ES|QL] Fix CSV report time range when exporting from Discover","number":216792,"url":"https://github.com/elastic/kibana/pull/216792","mergeCommit":{"message":"[ES|QL] Fix CSV report time range when exporting from Discover (#216792)\n\n- Closes https://github.com/elastic/kibana/issues/216605\n\n## Summary\n\nThis PR makes sure to use the absolute time range when generating a CSV\nreport in ES|QL mode.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"6a0c173b1ad6152ee75bc2e74dfd71e74fa6b54a"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/217174","number":217174,"state":"OPEN"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216792","number":216792,"mergeCommit":{"message":"[ES|QL] Fix CSV report time range when exporting from Discover (#216792)\n\n- Closes https://github.com/elastic/kibana/issues/216605\n\n## Summary\n\nThis PR makes sure to use the absolute time range when generating a CSV\nreport in ES|QL mode.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"6a0c173b1ad6152ee75bc2e74dfd71e74fa6b54a"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
Robert Jaszczurek
|
a9a1667338
|
[8.18] [ML] AIOps: Change Point Detection in Dashboards embeddable fix (#217178) (#217316)
# Backport This will backport the following commits from `main` to `8.18`: - [[ML] AIOps: Change Point Detection in Dashboards embeddable fix (#217178)](https://github.com/elastic/kibana/pull/217178) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-07T10:06:30Z","message":"[ML] AIOps: Change Point Detection in Dashboards embeddable fix (#217178)\n\nIt fixes an issue where adding the `Change Point Detection` embeddable\ndidn't work properly.\nThe bug was introduced in https://github.com/elastic/kibana/pull/197943\nThe main cause was the use of `<ChangePointDetectionContextProvider>`\nwhich calls `timefilter.getActiveBounds()`. However, for\n`getActiveBounds` to work, `this.isTimeRangeSelectorEnabled()` must\nreturn true. By default, this is not the case within dashboards.\nHowever, we do not actually need the `ChangePointDetectionContext`\ninside the embeddable, so this PR removes its usage.\nA functional test has been added to cover adding the Change Point\nembeddable from the dashboards app. It's a very simple test that does\nnot verify the embeddable's functionality, but it could be improved in a\nfollow-up.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d35988152d9e95e26908046ea3540d34e47cf92f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:ML/AIOps","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1","v8.17.5"],"title":"[ML] AIOps: Change Point Detection in Dashboards embeddable fix","number":217178,"url":"https://github.com/elastic/kibana/pull/217178","mergeCommit":{"message":"[ML] AIOps: Change Point Detection in Dashboards embeddable fix (#217178)\n\nIt fixes an issue where adding the `Change Point Detection` embeddable\ndidn't work properly.\nThe bug was introduced in https://github.com/elastic/kibana/pull/197943\nThe main cause was the use of `<ChangePointDetectionContextProvider>`\nwhich calls `timefilter.getActiveBounds()`. However, for\n`getActiveBounds` to work, `this.isTimeRangeSelectorEnabled()` must\nreturn true. By default, this is not the case within dashboards.\nHowever, we do not actually need the `ChangePointDetectionContext`\ninside the embeddable, so this PR removes its usage.\nA functional test has been added to cover adding the Change Point\nembeddable from the dashboards app. It's a very simple test that does\nnot verify the embeddable's functionality, but it could be improved in a\nfollow-up.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d35988152d9e95e26908046ea3540d34e47cf92f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217178","number":217178,"mergeCommit":{"message":"[ML] AIOps: Change Point Detection in Dashboards embeddable fix (#217178)\n\nIt fixes an issue where adding the `Change Point Detection` embeddable\ndidn't work properly.\nThe bug was introduced in https://github.com/elastic/kibana/pull/197943\nThe main cause was the use of `<ChangePointDetectionContextProvider>`\nwhich calls `timefilter.getActiveBounds()`. However, for\n`getActiveBounds` to work, `this.isTimeRangeSelectorEnabled()` must\nreturn true. By default, this is not the case within dashboards.\nHowever, we do not actually need the `ChangePointDetectionContext`\ninside the embeddable, so this PR removes its usage.\nA functional test has been added to cover adding the Change Point\nembeddable from the dashboards app. It's a very simple test that does\nnot verify the embeddable's functionality, but it could be improved in a\nfollow-up.\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d35988152d9e95e26908046ea3540d34e47cf92f"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/217315","number":217315,"state":"OPEN"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
Georgii Gorbachev
|
0e90f2d2f2
|
[8.18] [Security Solution] Migrate legacy Detections API docs to OpenAPI specs (#212367) (#217305)
# Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Migrate legacy Detections API docs to OpenAPI specs (#212367)](https://github.com/elastic/kibana/pull/212367) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jacek Kolezynski","email":"jacek.kolezynski@elastic.co"},"sourceCommit":{"committedDate":"2025-04-01T13:43:02Z","message":"[Security Solution] Migrate legacy Detections API docs to OpenAPI specs (#212367)\n\n**Partially resolves: #211808**\n\n## Summary\n\nThis is the first part of the migration effort, containing changes for:\n- CRUD endpoints\n- BULK Actions\n- Export / Import Rule\n- Find Rule\n- List Tags\n- Get Status\n- Install Rule\n\nI migrated the examples and the description of the fields. Some of the\nfields contained description that was very similar to the legacy, then I\ndidn't change it. I only modified the descriptions where it was\nvaluable.\n\nI also discovered some problems. For example the value for the 'query'\nfield, always shows 'EQL query to execute'. I reported this to the docs\nteam, in the 'next-api-reference' channel.\n\nAnother issue was with 'related_integrations field', which also didn't\nshow the long description. I also wrote about it to the docs team\n[here](https://elastic.slack.com/archives/C05UL5YC06B/p1740137094701209).\nIn this PR I decided to try moving the description one level up, where\nit renders properly.\n\n\n# Testing\n1. cd x-pack/solutions/security/plugins/security_solution\n2. yarn openapi:bundle:detections \n3. Take the bundled file\n(docs/openapi/ess/security_solution_detections_api_2023_10_31.bundled.schema.yaml)\nand load it into bump.sh console to see the changes.\n4. Compare the changes with the [Legacy\ndocumentation](https://www.elastic.co/guide/en/security/current/rule-api-overview.html)\n\nYou can also use this [link](https://bump.sh/jkelas/doc/kibana_wip/)\nwhere I deployed the generated bundled doc.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"2b01257343335ad7ea5d40577c7e10deb94db19b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","APIDocs","Team:Detection Rule Management","backport:version","8.18 candidate","v9.1.0","v8.19.0"],"title":"[Security Solution] Migrate legacy Detections API docs to OpenAPI specs","number":212367,"url":"https://github.com/elastic/kibana/pull/212367","mergeCommit":{"message":"[Security Solution] Migrate legacy Detections API docs to OpenAPI specs (#212367)\n\n**Partially resolves: #211808**\n\n## Summary\n\nThis is the first part of the migration effort, containing changes for:\n- CRUD endpoints\n- BULK Actions\n- Export / Import Rule\n- Find Rule\n- List Tags\n- Get Status\n- Install Rule\n\nI migrated the examples and the description of the fields. Some of the\nfields contained description that was very similar to the legacy, then I\ndidn't change it. I only modified the descriptions where it was\nvaluable.\n\nI also discovered some problems. For example the value for the 'query'\nfield, always shows 'EQL query to execute'. I reported this to the docs\nteam, in the 'next-api-reference' channel.\n\nAnother issue was with 'related_integrations field', which also didn't\nshow the long description. I also wrote about it to the docs team\n[here](https://elastic.slack.com/archives/C05UL5YC06B/p1740137094701209).\nIn this PR I decided to try moving the description one level up, where\nit renders properly.\n\n\n# Testing\n1. cd x-pack/solutions/security/plugins/security_solution\n2. yarn openapi:bundle:detections \n3. Take the bundled file\n(docs/openapi/ess/security_solution_detections_api_2023_10_31.bundled.schema.yaml)\nand load it into bump.sh console to see the changes.\n4. Compare the changes with the [Legacy\ndocumentation](https://www.elastic.co/guide/en/security/current/rule-api-overview.html)\n\nYou can also use this [link](https://bump.sh/jkelas/doc/kibana_wip/)\nwhere I deployed the generated bundled doc.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"2b01257343335ad7ea5d40577c7e10deb94db19b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212367","number":212367,"mergeCommit":{"message":"[Security Solution] Migrate legacy Detections API docs to OpenAPI specs (#212367)\n\n**Partially resolves: #211808**\n\n## Summary\n\nThis is the first part of the migration effort, containing changes for:\n- CRUD endpoints\n- BULK Actions\n- Export / Import Rule\n- Find Rule\n- List Tags\n- Get Status\n- Install Rule\n\nI migrated the examples and the description of the fields. Some of the\nfields contained description that was very similar to the legacy, then I\ndidn't change it. I only modified the descriptions where it was\nvaluable.\n\nI also discovered some problems. For example the value for the 'query'\nfield, always shows 'EQL query to execute'. I reported this to the docs\nteam, in the 'next-api-reference' channel.\n\nAnother issue was with 'related_integrations field', which also didn't\nshow the long description. I also wrote about it to the docs team\n[here](https://elastic.slack.com/archives/C05UL5YC06B/p1740137094701209).\nIn this PR I decided to try moving the description one level up, where\nit renders properly.\n\n\n# Testing\n1. cd x-pack/solutions/security/plugins/security_solution\n2. yarn openapi:bundle:detections \n3. Take the bundled file\n(docs/openapi/ess/security_solution_detections_api_2023_10_31.bundled.schema.yaml)\nand load it into bump.sh console to see the changes.\n4. Compare the changes with the [Legacy\ndocumentation](https://www.elastic.co/guide/en/security/current/rule-api-overview.html)\n\nYou can also use this [link](https://bump.sh/jkelas/doc/kibana_wip/)\nwhere I deployed the generated bundled doc.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"2b01257343335ad7ea5d40577c7e10deb94db19b"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216734","number":216734,"state":"MERGED","mergeCommit":{"sha":"9c8b23ad7b5cf5025506e1d51fa22d7de7194305","message":"[8.x] [Security Solution] Migrate legacy Detections API docs to OpenAPI specs (#212367) (#216734)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Security Solution] Migrate legacy Detections API docs to OpenAPI\nspecs (#212367)](https://github.com/elastic/kibana/pull/212367)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Jacek Kolezynski <jacek.kolezynski@elastic.co>"}}]}] BACKPORT--> --------- Co-authored-by: Jacek Kolezynski <jacek.kolezynski@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
Kibana Machine
|
d67cb8cec8
|
[8.18] [Stack connectors] Fix bedrock modelId encoding (#216915) (#217060)
# Backport This will backport the following commits from `main` to `8.18`: - [[Stack connectors] Fix bedrock `modelId` encoding (#216915)](https://github.com/elastic/kibana/pull/216915) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2025-04-03T15:56:14Z","message":"[Stack connectors] Fix bedrock `modelId` encoding (#216915)","sha":"1edb366cb984dce3281ed4713f6f564a93bb1c2a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team: SecuritySolution","sdh-linked","Team:Security Generative AI","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1","v8.17.5"],"title":"[Stack connectors] Fix bedrock `modelId` encoding","number":216915,"url":"https://github.com/elastic/kibana/pull/216915","mergeCommit":{"message":"[Stack connectors] Fix bedrock `modelId` encoding (#216915)","sha":"1edb366cb984dce3281ed4713f6f564a93bb1c2a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","9.0","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216915","number":216915,"mergeCommit":{"message":"[Stack connectors] Fix bedrock `modelId` encoding (#216915)","sha":"1edb366cb984dce3281ed4713f6f564a93bb1c2a"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> |
||
Miriam
|
99662f5f87
|
[8.18] [ObsUX][A11y] Add announcement keyboard elements improvements (#216592) (#216987)
# Backport This will backport the following commits from `main` to `8.18`: - [[ObsUX][A11y] Add announcement keyboard elements improvements (#216592)](https://github.com/elastic/kibana/pull/216592) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Miriam","email":"31922082+MiriamAparicio@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-02T11:24:26Z","message":"[ObsUX][A11y] Add announcement keyboard elements improvements (#216592)\n\nCloses https://github.com/elastic/kibana/issues/216029\n\n## Summary\n\nSome elements on the Infrastructure Inventory were not accessible or\ntheir interaction with the keyboard was not properly announced to the\nusers, see issue for steps to reproduce, use a screen reader to test.\n\n### What was done\n\n#### Groupby buttons \n\n- Replace link element by button\n- Add announcement when interacting with the button, i.e., when\nclicking/selecting the `All` button nothing changes\n\n\nhttps://github.com/user-attachments/assets/da7a973d-26a4-4288-8aea-e1dd7a43ea6f\n\n#### Legend options\n\n- Replace `EuiColorPickerSwatch` button by and icon, the button didn't\nhave any action, it only shows the selected color for minimum and\nmaximum for the selected color palette\n- Fix ui alignment of checkbox elements\n\nBefore\n\n<img width=\"452\" alt=\"Screenshot 2025-04-01 at 08 58 40\"\nsrc=\"https://github.com/user-attachments/assets/66d7e733-8f95-4d76-9eb2-549b8421b888\"\n/>\n\nAfter\n\n<img width=\"585\" alt=\"Screenshot 2025-04-01 at 08 54 31\"\nsrc=\"https://github.com/user-attachments/assets/825a9f84-ddaf-43dc-b136-e268592818c1\"\n/>","sha":"ecd83ce211cdf2dd9bca43c8e6c15473dc8e1c44","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-infra_services","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[ObsUX][A11y] Add announcement keyboard elements improvements","number":216592,"url":"https://github.com/elastic/kibana/pull/216592","mergeCommit":{"message":"[ObsUX][A11y] Add announcement keyboard elements improvements (#216592)\n\nCloses https://github.com/elastic/kibana/issues/216029\n\n## Summary\n\nSome elements on the Infrastructure Inventory were not accessible or\ntheir interaction with the keyboard was not properly announced to the\nusers, see issue for steps to reproduce, use a screen reader to test.\n\n### What was done\n\n#### Groupby buttons \n\n- Replace link element by button\n- Add announcement when interacting with the button, i.e., when\nclicking/selecting the `All` button nothing changes\n\n\nhttps://github.com/user-attachments/assets/da7a973d-26a4-4288-8aea-e1dd7a43ea6f\n\n#### Legend options\n\n- Replace `EuiColorPickerSwatch` button by and icon, the button didn't\nhave any action, it only shows the selected color for minimum and\nmaximum for the selected color palette\n- Fix ui alignment of checkbox elements\n\nBefore\n\n<img width=\"452\" alt=\"Screenshot 2025-04-01 at 08 58 40\"\nsrc=\"https://github.com/user-attachments/assets/66d7e733-8f95-4d76-9eb2-549b8421b888\"\n/>\n\nAfter\n\n<img width=\"585\" alt=\"Screenshot 2025-04-01 at 08 54 31\"\nsrc=\"https://github.com/user-attachments/assets/825a9f84-ddaf-43dc-b136-e268592818c1\"\n/>","sha":"ecd83ce211cdf2dd9bca43c8e6c15473dc8e1c44"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216800","number":216800,"state":"MERGED","mergeCommit":{"sha":"ae0c91447de0f4cc021be66dbd66751d3d0ead48","message":"[9.0] [ObsUX][A11y] Add announcement keyboard elements improvements (#216592) (#216800)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[ObsUX][A11y] Add announcement keyboard elements improvements\n(#216592)](https://github.com/elastic/kibana/pull/216592)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Miriam <31922082+MiriamAparicio@users.noreply.github.com>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216592","number":216592,"mergeCommit":{"message":"[ObsUX][A11y] Add announcement keyboard elements improvements (#216592)\n\nCloses https://github.com/elastic/kibana/issues/216029\n\n## Summary\n\nSome elements on the Infrastructure Inventory were not accessible or\ntheir interaction with the keyboard was not properly announced to the\nusers, see issue for steps to reproduce, use a screen reader to test.\n\n### What was done\n\n#### Groupby buttons \n\n- Replace link element by button\n- Add announcement when interacting with the button, i.e., when\nclicking/selecting the `All` button nothing changes\n\n\nhttps://github.com/user-attachments/assets/da7a973d-26a4-4288-8aea-e1dd7a43ea6f\n\n#### Legend options\n\n- Replace `EuiColorPickerSwatch` button by and icon, the button didn't\nhave any action, it only shows the selected color for minimum and\nmaximum for the selected color palette\n- Fix ui alignment of checkbox elements\n\nBefore\n\n<img width=\"452\" alt=\"Screenshot 2025-04-01 at 08 58 40\"\nsrc=\"https://github.com/user-attachments/assets/66d7e733-8f95-4d76-9eb2-549b8421b888\"\n/>\n\nAfter\n\n<img width=\"585\" alt=\"Screenshot 2025-04-01 at 08 54 31\"\nsrc=\"https://github.com/user-attachments/assets/825a9f84-ddaf-43dc-b136-e268592818c1\"\n/>","sha":"ecd83ce211cdf2dd9bca43c8e6c15473dc8e1c44"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
|
Kibana Machine
|
b9e6f3d0e6
|
[8.18] [FIPS] Skips license check test for FIPS test suite (#216056) (#216728)
# Backport This will backport the following commits from `main` to `8.18`: - [[FIPS] Skips license check test for FIPS test suite (#216056)](https://github.com/elastic/kibana/pull/216056) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sid","email":"siddharthmantri1@gmail.com"},"sourceCommit":{"committedDate":"2025-04-01T21:23:35Z","message":"[FIPS] Skips license check test for FIPS test suite (#216056)\n\n## Summary\n\nSkips license checking test in FIPS mode. FIPS runs with the platinum\nlicense so having a test which asserts `basic` causes the CI to fail.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1fdf5d450f598e95e367140dbbac0abd24f96ba6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:Core","release_note:skip","v9.0.0","Feature:FIPS","v8.18.0","v9.1.0","v8.19.0","v8.17.4"],"title":"[FIPS] Skips license check test for FIPS test suite","number":216056,"url":"https://github.com/elastic/kibana/pull/216056","mergeCommit":{"message":"[FIPS] Skips license check test for FIPS test suite (#216056)\n\n## Summary\n\nSkips license checking test in FIPS mode. FIPS runs with the platinum\nlicense so having a test which asserts `basic` causes the CI to fail.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1fdf5d450f598e95e367140dbbac0abd24f96ba6"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216056","number":216056,"mergeCommit":{"message":"[FIPS] Skips license check test for FIPS test suite (#216056)\n\n## Summary\n\nSkips license checking test in FIPS mode. FIPS runs with the platinum\nlicense so having a test which asserts `basic` causes the CI to fail.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1fdf5d450f598e95e367140dbbac0abd24f96ba6"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sid <siddharthmantri1@gmail.com> |
||
Julia Bardi
|
0c716056b3
|
[8.18][Fleet] Update inputs_with_standalone_docker_agent.ts (#216622)
Related to https://github.com/elastic/kibana/pull/216589 Fix docker image |
||
|
Kibana Machine
|
8065eb640a
|
[8.18] [Fleet] enable flaky test (#216460) (#216589)
# Backport This will backport the following commits from `main` to `8.18`: - [[Fleet] enable flaky test (#216460)](https://github.com/elastic/kibana/pull/216460) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-01T08:29:23Z","message":"[Fleet] enable flaky test (#216460)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/184681\n\n\n### Checklist\n\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"69a7108313fab9520fb1f5f7281b5a17e76e3f92","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Fleet] enable flaky test","number":216460,"url":"https://github.com/elastic/kibana/pull/216460","mergeCommit":{"message":"[Fleet] enable flaky test (#216460)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/184681\n\n\n### Checklist\n\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"69a7108313fab9520fb1f5f7281b5a17e76e3f92"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216460","number":216460,"mergeCommit":{"message":"[Fleet] enable flaky test (#216460)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/184681\n\n\n### Checklist\n\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"69a7108313fab9520fb1f5f7281b5a17e76e3f92"}}]}] BACKPORT--> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com> |
||
|
Kibana Machine
|
15b5519963
|
[8.18] [Dataset Quality] Fix brittle test which was failing in the midnight job (#216260) (#216318)
# Backport This will backport the following commits from `main` to `8.18`: - [[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)](https://github.com/elastic/kibana/pull/216260) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Achyut Jhunjhunwala","email":"achyut.jhunjhunwala@elastic.co"},"sourceCommit":{"committedDate":"2025-03-28T15:13:05Z","message":"[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)\n\nThis PR fixes a bug where the test would run at midnight and due to the\nodd timing, the index which gets created is asserted for a different\ndate than expected.\n\nWith this fix, we don't check the complete index name now by replacing\nthe date assertion part with startWith and endsWith assertions.","sha":"0f0ee3a0b8be0182e136f4bb75765d469917ee3b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:prev-major","Feature:Dataset Health","v9.1.0","Team:Obs UX Logs"],"title":"[Dataset Quality] Fix brittle test which was failing in the midnight job","number":216260,"url":"https://github.com/elastic/kibana/pull/216260","mergeCommit":{"message":"[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)\n\nThis PR fixes a bug where the test would run at midnight and due to the\nodd timing, the index which gets created is asserted for a different\ndate than expected.\n\nWith this fix, we don't check the complete index name now by replacing\nthe date assertion part with startWith and endsWith assertions.","sha":"0f0ee3a0b8be0182e136f4bb75765d469917ee3b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216260","number":216260,"mergeCommit":{"message":"[Dataset Quality] Fix brittle test which was failing in the midnight job (#216260)\n\nThis PR fixes a bug where the test would run at midnight and due to the\nodd timing, the index which gets created is asserted for a different\ndate than expected.\n\nWith this fix, we don't check the complete index name now by replacing\nthe date assertion part with startWith and endsWith assertions.","sha":"0f0ee3a0b8be0182e136f4bb75765d469917ee3b"}}]}] BACKPORT--> Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@elastic.co> |
||
|
Kibana Machine
|
24c65a5dcc
|
[8.18] [Response Ops][Flaky Tests] Remove duplicated click creating connector (#216145) (#216280)
# Backport This will backport the following commits from `main` to `8.18`: - [[Response Ops][Flaky Tests] Remove duplicated click creating connector (#216145)](https://github.com/elastic/kibana/pull/216145) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julian Gernun","email":"17549662+jcger@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-28T11:43:25Z","message":"[Response Ops][Flaky Tests] Remove duplicated click creating connector (#216145)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202328\n\nThe test itself wasn't failing but the setup was. The test failing does\nso because it's the first one in the test suite. We are trying to click\non the flyout save button twice one right after the other. What I think\nis happening is that the first one manages to close the flyout before\nthe second click gets the chance to trigger.\n\nAlso the image in CI is this where we can see the flyout is closed\nalready but it's still trying to close it\n\n","sha":"e16ba346e39df1843b45017137d4c894c357bb13","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:version","v8.18.0","v9.1.0"],"title":"[Response Ops][Flaky Tests] Remove duplicated click creating connector","number":216145,"url":"https://github.com/elastic/kibana/pull/216145","mergeCommit":{"message":"[Response Ops][Flaky Tests] Remove duplicated click creating connector (#216145)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202328\n\nThe test itself wasn't failing but the setup was. The test failing does\nso because it's the first one in the test suite. We are trying to click\non the flyout save button twice one right after the other. What I think\nis happening is that the first one manages to close the flyout before\nthe second click gets the chance to trigger.\n\nAlso the image in CI is this where we can see the flyout is closed\nalready but it's still trying to close it\n\n","sha":"e16ba346e39df1843b45017137d4c894c357bb13"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216145","number":216145,"mergeCommit":{"message":"[Response Ops][Flaky Tests] Remove duplicated click creating connector (#216145)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202328\n\nThe test itself wasn't failing but the setup was. The test failing does\nso because it's the first one in the test suite. We are trying to click\non the flyout save button twice one right after the other. What I think\nis happening is that the first one manages to close the flyout before\nthe second click gets the chance to trigger.\n\nAlso the image in CI is this where we can see the flyout is closed\nalready but it's still trying to close it\n\n","sha":"e16ba346e39df1843b45017137d4c894c357bb13"}}]}] BACKPORT--> Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com> |
||
Efe Gürkan YALAMAN
|
3af1098ba3
|
[8.18] [Synonyms] Update Synonyms Text and Enable (#215618) (#215833)
# Backport This will backport the following commits from `main` to `8.18`: - [[Synonyms] Update Synonyms Text and Enable (#215618)](https://github.com/elastic/kibana/pull/215618) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Efe Gürkan YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2025-03-24T23:30:55Z","message":"[Synonyms] Update Synonyms Text and Enable (#215618)\n\n## Summary\n\nText in various places updated.\nAdded some telemetry that was decided.\nSmall visual changes on empty prompt page.\nAdded a new example in a collapsible accordion.\nAlso enables the synonyms plugin by default.\n\n<img width=\"1637\" alt=\"Screenshot 2025-03-24 at 10 36 26\"\nsrc=\"https://github.com/user-attachments/assets/b02ef4a7-a18f-44b5-a845-d2566102e8ea\"\n/>\n<img width=\"1627\" alt=\"Screenshot 2025-03-24 at 10 36 40\"\nsrc=\"https://github.com/user-attachments/assets/f7ea1c5e-d82e-497a-b215-5eab7190f041\"\n/>\n<img width=\"1634\" alt=\"Screenshot 2025-03-24 at 10 36 52\"\nsrc=\"https://github.com/user-attachments/assets/d410bcc1-c075-4b5a-bcb7-11f97c64ffb9\"\n/>\n<img width=\"825\" alt=\"Screenshot 2025-03-24 at 10 37 00\"\nsrc=\"https://github.com/user-attachments/assets/8a9e7567-5dbd-4238-8f8b-297b78a4dcac\"\n/>\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"01a4ff72e73c1d31b0aeed76f3a9ec4b5393deb8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Synonyms] Update Synonyms Text and Enable","number":215618,"url":"https://github.com/elastic/kibana/pull/215618","mergeCommit":{"message":"[Synonyms] Update Synonyms Text and Enable (#215618)\n\n## Summary\n\nText in various places updated.\nAdded some telemetry that was decided.\nSmall visual changes on empty prompt page.\nAdded a new example in a collapsible accordion.\nAlso enables the synonyms plugin by default.\n\n<img width=\"1637\" alt=\"Screenshot 2025-03-24 at 10 36 26\"\nsrc=\"https://github.com/user-attachments/assets/b02ef4a7-a18f-44b5-a845-d2566102e8ea\"\n/>\n<img width=\"1627\" alt=\"Screenshot 2025-03-24 at 10 36 40\"\nsrc=\"https://github.com/user-attachments/assets/f7ea1c5e-d82e-497a-b215-5eab7190f041\"\n/>\n<img width=\"1634\" alt=\"Screenshot 2025-03-24 at 10 36 52\"\nsrc=\"https://github.com/user-attachments/assets/d410bcc1-c075-4b5a-bcb7-11f97c64ffb9\"\n/>\n<img width=\"825\" alt=\"Screenshot 2025-03-24 at 10 37 00\"\nsrc=\"https://github.com/user-attachments/assets/8a9e7567-5dbd-4238-8f8b-297b78a4dcac\"\n/>\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"01a4ff72e73c1d31b0aeed76f3a9ec4b5393deb8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/215814","number":215814,"state":"MERGED","mergeCommit":{"sha":"5f3a62c004a3ea2a4879b9bc3f82e3ae5f02f4b0","message":"[9.0] [Synonyms] Update Synonyms Text and Enable (#215618) (#215814)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Synonyms] Update Synonyms Text and Enable\n(#215618)](https://github.com/elastic/kibana/pull/215618)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215618","number":215618,"mergeCommit":{"message":"[Synonyms] Update Synonyms Text and Enable (#215618)\n\n## Summary\n\nText in various places updated.\nAdded some telemetry that was decided.\nSmall visual changes on empty prompt page.\nAdded a new example in a collapsible accordion.\nAlso enables the synonyms plugin by default.\n\n<img width=\"1637\" alt=\"Screenshot 2025-03-24 at 10 36 26\"\nsrc=\"https://github.com/user-attachments/assets/b02ef4a7-a18f-44b5-a845-d2566102e8ea\"\n/>\n<img width=\"1627\" alt=\"Screenshot 2025-03-24 at 10 36 40\"\nsrc=\"https://github.com/user-attachments/assets/f7ea1c5e-d82e-497a-b215-5eab7190f041\"\n/>\n<img width=\"1634\" alt=\"Screenshot 2025-03-24 at 10 36 52\"\nsrc=\"https://github.com/user-attachments/assets/d410bcc1-c075-4b5a-bcb7-11f97c64ffb9\"\n/>\n<img width=\"825\" alt=\"Screenshot 2025-03-24 at 10 37 00\"\nsrc=\"https://github.com/user-attachments/assets/8a9e7567-5dbd-4238-8f8b-297b78a4dcac\"\n/>\n\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"01a4ff72e73c1d31b0aeed76f3a9ec4b5393deb8"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Kathleen DeRusso <kathleen.derusso@elastic.co> Co-authored-by: Samiul Monir <samiul.monir@elastic.co> |
||
|
Kibana Machine
|
7b963600ce
|
[8.18] [Visualize] Unskip smoke test (#214960) (#215837)
# Backport This will backport the following commits from `main` to `8.18`: - [[Visualize] Unskip smoke test (#214960)](https://github.com/elastic/kibana/pull/214960) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2025-03-25T09:30:07Z","message":"[Visualize] Unskip smoke test (#214960)\n\n## Summary\n\nUnskipping and fixing skipped test\n\nThe reported issue was referring to an issue with a TSVB chart that was\ntrying to load a missing data view.\nIf not explicitly configured in the configuration, TSVB can load the\ndefault data view configured in the Advanced Settings.\nThere is no mention of the missing dataview ID in the the dashboard nor\nin the TSVB panel configuration.\nThe TSVB configuration uses at this point the default index coming from\nthe Advanced Settings, so that ID seems to be configured as the default\nID but there is no loaded dataview with that name.\nThe data view ID appearing in the error was referencing the ecommerce\ndashboard, that was not used and not loaded in this test (all charts\nrefers to the logs* data view).\n\n\n\n\nI believe this issues was caused by other tests in the same suite/config\nthat configured the `defaultIndex` setting without unsetting it.","sha":"12aa3fc6ca8124db8cf5e940baec121482fd1a4b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","Team:Visualizations","skipped-test","release_note:skip","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Visualize] Unskip smoke test","number":214960,"url":"https://github.com/elastic/kibana/pull/214960","mergeCommit":{"message":"[Visualize] Unskip smoke test (#214960)\n\n## Summary\n\nUnskipping and fixing skipped test\n\nThe reported issue was referring to an issue with a TSVB chart that was\ntrying to load a missing data view.\nIf not explicitly configured in the configuration, TSVB can load the\ndefault data view configured in the Advanced Settings.\nThere is no mention of the missing dataview ID in the the dashboard nor\nin the TSVB panel configuration.\nThe TSVB configuration uses at this point the default index coming from\nthe Advanced Settings, so that ID seems to be configured as the default\nID but there is no loaded dataview with that name.\nThe data view ID appearing in the error was referencing the ecommerce\ndashboard, that was not used and not loaded in this test (all charts\nrefers to the logs* data view).\n\n\n\n\nI believe this issues was caused by other tests in the same suite/config\nthat configured the `defaultIndex` setting without unsetting it.","sha":"12aa3fc6ca8124db8cf5e940baec121482fd1a4b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214960","number":214960,"mergeCommit":{"message":"[Visualize] Unskip smoke test (#214960)\n\n## Summary\n\nUnskipping and fixing skipped test\n\nThe reported issue was referring to an issue with a TSVB chart that was\ntrying to load a missing data view.\nIf not explicitly configured in the configuration, TSVB can load the\ndefault data view configured in the Advanced Settings.\nThere is no mention of the missing dataview ID in the the dashboard nor\nin the TSVB panel configuration.\nThe TSVB configuration uses at this point the default index coming from\nthe Advanced Settings, so that ID seems to be configured as the default\nID but there is no loaded dataview with that name.\nThe data view ID appearing in the error was referencing the ecommerce\ndashboard, that was not used and not loaded in this test (all charts\nrefers to the logs* data view).\n\n\n\n\nI believe this issues was caused by other tests in the same suite/config\nthat configured the `defaultIndex` setting without unsetting it.","sha":"12aa3fc6ca8124db8cf5e940baec121482fd1a4b"}}]}] BACKPORT--> Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co> |
||
Pablo Machado
|
55b5c7b057
|
[8.18] [SecuritySolution] Fix Entity Store init API doesn't check for indices privileges (#215329) (#215866)
# Backport This will backport the following commits from `main` to `8.18`: - [[SecuritySolution] Fix Entity Store init API doesn't check for indices privileges (#215329)](https://github.com/elastic/kibana/pull/215329) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2025-03-25T10:48:20Z","message":"[SecuritySolution] Fix Entity Store init API doesn't check for indices privileges (#215329)\n\n## Summary\n\n* Add privileges check to the entity store init API\n* Refactor privileges check code to be reusable\n* Move privilege check code to the entity store API client\n\n### How to test it?\n* Create a new instance with security solution data\n* Create a new user with all cluster and kibana credentials but no index\nprivileges.\n* Login with the unprivileged and call the init API\n* It should return a long error msg with all required index patterns.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"ef7fe99f42c513c36001a254e6b8120e043a1d2e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","Team: SecuritySolution","Theme: entity_analytics","Feature:Entity Analytics","Team:Entity Analytics","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[SecuritySolution] Fix Entity Store init API doesn't check for indices privileges","number":215329,"url":"https://github.com/elastic/kibana/pull/215329","mergeCommit":{"message":"[SecuritySolution] Fix Entity Store init API doesn't check for indices privileges (#215329)\n\n## Summary\n\n* Add privileges check to the entity store init API\n* Refactor privileges check code to be reusable\n* Move privilege check code to the entity store API client\n\n### How to test it?\n* Create a new instance with security solution data\n* Create a new user with all cluster and kibana credentials but no index\nprivileges.\n* Login with the unprivileged and call the init API\n* It should return a long error msg with all required index patterns.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"ef7fe99f42c513c36001a254e6b8120e043a1d2e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215329","number":215329,"mergeCommit":{"message":"[SecuritySolution] Fix Entity Store init API doesn't check for indices privileges (#215329)\n\n## Summary\n\n* Add privileges check to the entity store init API\n* Refactor privileges check code to be reusable\n* Move privilege check code to the entity store API client\n\n### How to test it?\n* Create a new instance with security solution data\n* Create a new user with all cluster and kibana credentials but no index\nprivileges.\n* Login with the unprivileged and call the init API\n* It should return a long error msg with all required index patterns.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"ef7fe99f42c513c36001a254e6b8120e043a1d2e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
|
Kibana Machine
|
691dde541a
|
[8.18] Disable allowAbsoluteUrls for axios (#215138) (#215828)
# Backport This will backport the following commits from `main` to `8.18`: - [Disable `allowAbsoluteUrls` for axios (#215138)](https://github.com/elastic/kibana/pull/215138) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2025-03-25T08:52:36Z","message":"Disable `allowAbsoluteUrls` for axios (#215138)\n\n## Summary\nAfter https://github.com/elastic/kibana/pull/214843, `axios` client\nusages need to set a flag to prevent the vulnerable behavior.\n\nTo reviewers: if you think it's a mistake, and you created a client to\nrequest for absolute URLs, consider unsetting the `baseURL` to\ncommunicate intent.","sha":"e40b17aa22ec1a2fbc56ae8651e12f658099ec14","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Team:QA","Team:Security","release_note:skip","backport:all-open","Team:obs-ux-logs","Team:obs-ux-infra_services","v9.1.0"],"title":"Disable `allowAbsoluteUrls` for axios","number":215138,"url":"https://github.com/elastic/kibana/pull/215138","mergeCommit":{"message":"Disable `allowAbsoluteUrls` for axios (#215138)\n\n## Summary\nAfter https://github.com/elastic/kibana/pull/214843, `axios` client\nusages need to set a flag to prevent the vulnerable behavior.\n\nTo reviewers: if you think it's a mistake, and you created a client to\nrequest for absolute URLs, consider unsetting the `baseURL` to\ncommunicate intent.","sha":"e40b17aa22ec1a2fbc56ae8651e12f658099ec14"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215138","number":215138,"mergeCommit":{"message":"Disable `allowAbsoluteUrls` for axios (#215138)\n\n## Summary\nAfter https://github.com/elastic/kibana/pull/214843, `axios` client\nusages need to set a flag to prevent the vulnerable behavior.\n\nTo reviewers: if you think it's a mistake, and you created a client to\nrequest for absolute URLs, consider unsetting the `baseURL` to\ncommunicate intent.","sha":"e40b17aa22ec1a2fbc56ae8651e12f658099ec14"}}]}] BACKPORT--> --------- Co-authored-by: Alex Szabo <alex.szabo@elastic.co> |
||
|
Kibana Machine
|
6e0054ac6b
|
[8.18] Simplify and reduce flakiness of license.public (#215874) (#215915)
# Backport This will backport the following commits from `main` to `8.18`: - [Simplify and reduce flakiness of license.public (#215874)](https://github.com/elastic/kibana/pull/215874) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2025-03-25T16:09:30Z","message":"Simplify and reduce flakiness of license.public (#215874)\n\n## Summary\n\n* Factorise logic to fetch latest license.\n* Add an extra `manualRefresh` step, to ensure we get the latest\nemission.\n\nAims at tackling [latest\nfailures](https://github.com/elastic/kibana/issues/53575#issuecomment-2751034614)\non licensing tests.","sha":"359374e78f310ff91e6a13a52245f20fedc03d3c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:all-open","v9.1.0"],"title":"Simplify and reduce flakiness of license.public","number":215874,"url":"https://github.com/elastic/kibana/pull/215874","mergeCommit":{"message":"Simplify and reduce flakiness of license.public (#215874)\n\n## Summary\n\n* Factorise logic to fetch latest license.\n* Add an extra `manualRefresh` step, to ensure we get the latest\nemission.\n\nAims at tackling [latest\nfailures](https://github.com/elastic/kibana/issues/53575#issuecomment-2751034614)\non licensing tests.","sha":"359374e78f310ff91e6a13a52245f20fedc03d3c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215874","number":215874,"mergeCommit":{"message":"Simplify and reduce flakiness of license.public (#215874)\n\n## Summary\n\n* Factorise logic to fetch latest license.\n* Add an extra `manualRefresh` step, to ensure we get the latest\nemission.\n\nAims at tackling [latest\nfailures](https://github.com/elastic/kibana/issues/53575#issuecomment-2751034614)\non licensing tests.","sha":"359374e78f310ff91e6a13a52245f20fedc03d3c"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co> |
||
|
Kibana Machine
|
8028491ee2
|
[8.18] Add manage_ingest_pipeline privilege check to Risk Engine enablement (#215544) (#215894)
# Backport This will backport the following commits from `main` to `8.18`: - [Add manage_ingest_pipeline privilege check to Risk Engine enablement (#215544)](https://github.com/elastic/kibana/pull/215544) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Charlotte Alexandra Wilson","email":"CAWilson94@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-25T14:20:31Z","message":"Add manage_ingest_pipeline privilege check to Risk Engine enablement (#215544)\n\n## Summary\n\nThis PR adds the \"manage_ingest_pipeline\" cluster privilege to\nRISK_ENGINE_REQUIRED_ES_CLUSTER_PRIVILEGES.\n\nThe Entity Analytics Enablement modal now displays a warning when the\nuser lacks this privilege and prevents Risk Engine installation, as\nrequired.\n\n### Screenshots \n\n#### Enablement Modal (installing/enabling)\n\n\n\n#### Risk Management Page \n\n\n","sha":"a296d08990e62ab4d28cdcc382e8592826eb815e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","Team: SecuritySolution","Theme: entity_analytics","Team:Entity Analytics","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"Add manage_ingest_pipeline privilege check to Risk Engine enablement","number":215544,"url":"https://github.com/elastic/kibana/pull/215544","mergeCommit":{"message":"Add manage_ingest_pipeline privilege check to Risk Engine enablement (#215544)\n\n## Summary\n\nThis PR adds the \"manage_ingest_pipeline\" cluster privilege to\nRISK_ENGINE_REQUIRED_ES_CLUSTER_PRIVILEGES.\n\nThe Entity Analytics Enablement modal now displays a warning when the\nuser lacks this privilege and prevents Risk Engine installation, as\nrequired.\n\n### Screenshots \n\n#### Enablement Modal (installing/enabling)\n\n\n\n#### Risk Management Page \n\n\n","sha":"a296d08990e62ab4d28cdcc382e8592826eb815e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215544","number":215544,"mergeCommit":{"message":"Add manage_ingest_pipeline privilege check to Risk Engine enablement (#215544)\n\n## Summary\n\nThis PR adds the \"manage_ingest_pipeline\" cluster privilege to\nRISK_ENGINE_REQUIRED_ES_CLUSTER_PRIVILEGES.\n\nThe Entity Analytics Enablement modal now displays a warning when the\nuser lacks this privilege and prevents Risk Engine installation, as\nrequired.\n\n### Screenshots \n\n#### Enablement Modal (installing/enabling)\n\n\n\n#### Risk Management Page \n\n\n","sha":"a296d08990e62ab4d28cdcc382e8592826eb815e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Charlotte Alexandra Wilson <CAWilson94@users.noreply.github.com> |
||
|
Kibana Machine
|
3974859832
|
[8.18] [Security Solution][Telemetry] Collect additional index stats (#213822) (#215875)
# Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution][Telemetry] Collect additional index stats (#213822)](https://github.com/elastic/kibana/pull/213822) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sebastián Zaffarano","email":"sebastian.zaffarano@elastic.co"},"sourceCommit":{"committedDate":"2025-03-25T13:18:31Z","message":"[Security Solution][Telemetry] Collect additional index stats (#213822)\n\n## Summary\n\n- Collect information about index_failed stats: Adds two new fields,\n`index_failed_due_to_version_conflict` and `index_failed` to the\nexistent\n[TELEMETRY_INDEX_STATS_EVENT]( |
||
|
Kibana Machine
|
b044fa5fc4
|
[8.18] Update enterprise test license, unskip tests (#215448) (#215851)
# Backport This will backport the following commits from `main` to `8.18`: - [Update enterprise test license, unskip tests (#215448)](https://github.com/elastic/kibana/pull/215448) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2025-03-25T10:41:40Z","message":"Update enterprise test license, unskip tests (#215448)\n\n## Summary\n\nAddresses https://github.com/elastic/kibana/issues/53575","sha":"2556b13d347cfe796c39760808700a0a9e0d52d7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:all-open","v9.1.0"],"title":"Update enterprise test license, unskip tests","number":215448,"url":"https://github.com/elastic/kibana/pull/215448","mergeCommit":{"message":"Update enterprise test license, unskip tests (#215448)\n\n## Summary\n\nAddresses https://github.com/elastic/kibana/issues/53575","sha":"2556b13d347cfe796c39760808700a0a9e0d52d7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215448","number":215448,"mergeCommit":{"message":"Update enterprise test license, unskip tests (#215448)\n\n## Summary\n\nAddresses https://github.com/elastic/kibana/issues/53575","sha":"2556b13d347cfe796c39760808700a0a9e0d52d7"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co> |
||
|
Kibana Machine
|
4c972fddad
|
[8.18] [Lens] fix drag and drop ghost after Chrome update to 134 (#213928) (#214125)
# Backport This will backport the following commits from `main` to `8.18`: - https://github.com/elastic/kibana/pull/213928 - https://github.com/elastic/kibana/pull/215439 <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T11:30:51Z","message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","backport:prev-major","Feature:UnifiedFieldList","v9.1.0"],"title":"[Lens] fix drag and drop ghost after Chrome update to 134","number":213928,"url":"https://github.com/elastic/kibana/pull/213928","mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213928","number":213928,"mergeCommit":{"message":"[Lens] fix drag and drop ghost after Chrome update to 134 (#213928)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/213708\n\nFixes the ghost display. As @nickofthyme pointed out\n[here](https://github.com/elastic/kibana/issues/213708#issuecomment-2712076212),\nthe reason was using inset-inline-start: -10000px for the keyboard\nhandler that is one of the children of the draggable component. The\nquick fix is to just move it outside of the html element that is\ndragged. @markov00 please assesswhere it should be merged 🙏🏼\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"84ae9c98c208957b3efc02c6b00bed8d567d4209"}}]}] BACKPORT--> --------- Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co> |
||
|
Kibana Machine
|
43b6c3f17e
|
[8.18] [Security Solution][Telemetry] Add ingest pipelines stats task (#213435) (#215500)
# Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution][Telemetry] Add ingest pipelines stats task (#213435)](https://github.com/elastic/kibana/pull/213435) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sebastián Zaffarano","email":"sebastian.zaffarano@elastic.co"},"sourceCommit":{"committedDate":"2025-03-21T13:38:58Z","message":"[Security Solution][Telemetry] Add ingest pipelines stats task (#213435)\n\n## Summary\n\nAdd a new telemetry task to the security solution plugin to collect\ningest pipeline stats. The new task runs once a day, calls the\n`_nodes/stats/ingest` API, and sends an EBT event with the following\ninformation:\n\n```js\nexport interface NodeIngestPipelinesStats {\n name: string;\n totals: Totals;\n pipelines: Pipeline[];\n}\n\nexport interface Pipeline {\n name: string;\n totals: Totals;\n processors: Processor[];\n}\n\nexport interface Processor {\n name: string;\n totals: Totals;\n}\n\nexport interface Totals {\n count: number;\n time_in_millis: number;\n current: number;\n failed: number;\n}\n```\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Ryland Herrick <ryalnd@gmail.com>","sha":"9cf3bea759591738cec5847454d789d33ff1d859","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","backport:prev-minor","backport:prev-major","ci:build-cloud-image","ci:cloud-deploy","v9.1.0"],"title":"[Security Solution][Telemetry] Add ingest pipelines stats task","number":213435,"url":"https://github.com/elastic/kibana/pull/213435","mergeCommit":{"message":"[Security Solution][Telemetry] Add ingest pipelines stats task (#213435)\n\n## Summary\n\nAdd a new telemetry task to the security solution plugin to collect\ningest pipeline stats. The new task runs once a day, calls the\n`_nodes/stats/ingest` API, and sends an EBT event with the following\ninformation:\n\n```js\nexport interface NodeIngestPipelinesStats {\n name: string;\n totals: Totals;\n pipelines: Pipeline[];\n}\n\nexport interface Pipeline {\n name: string;\n totals: Totals;\n processors: Processor[];\n}\n\nexport interface Processor {\n name: string;\n totals: Totals;\n}\n\nexport interface Totals {\n count: number;\n time_in_millis: number;\n current: number;\n failed: number;\n}\n```\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Ryland Herrick <ryalnd@gmail.com>","sha":"9cf3bea759591738cec5847454d789d33ff1d859"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213435","number":213435,"mergeCommit":{"message":"[Security Solution][Telemetry] Add ingest pipelines stats task (#213435)\n\n## Summary\n\nAdd a new telemetry task to the security solution plugin to collect\ningest pipeline stats. The new task runs once a day, calls the\n`_nodes/stats/ingest` API, and sends an EBT event with the following\ninformation:\n\n```js\nexport interface NodeIngestPipelinesStats {\n name: string;\n totals: Totals;\n pipelines: Pipeline[];\n}\n\nexport interface Pipeline {\n name: string;\n totals: Totals;\n processors: Processor[];\n}\n\nexport interface Processor {\n name: string;\n totals: Totals;\n}\n\nexport interface Totals {\n count: number;\n time_in_millis: number;\n current: number;\n failed: number;\n}\n```\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: Ryland Herrick <ryalnd@gmail.com>","sha":"9cf3bea759591738cec5847454d789d33ff1d859"}}]}] BACKPORT--> Co-authored-by: Sebastián Zaffarano <sebastian.zaffarano@elastic.co> |
||
|
Kibana Machine
|
c606009c57
|
[8.18] [Security Solution][Defend Workflows] Enables endpoint integrations FTR tests (#214120) (#215288)
# Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution][Defend Workflows] Enables endpoint integrations FTR tests (#214120)](https://github.com/elastic/kibana/pull/214120) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"David Sánchez","email":"david.sanchezsoler@elastic.co"},"sourceCommit":{"committedDate":"2025-03-20T09:37:11Z","message":"[Security Solution][Defend Workflows] Enables endpoint integrations FTR tests (#214120)\n\n## Summary\n\nEnables endpoint integrations ftr test.\n\ncloses: https://github.com/elastic/kibana/issues/203916\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1119bf187dc04e130c3df610b5fdeb7301e40311","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution][Defend Workflows] Enables endpoint integrations FTR tests","number":214120,"url":"https://github.com/elastic/kibana/pull/214120","mergeCommit":{"message":"[Security Solution][Defend Workflows] Enables endpoint integrations FTR tests (#214120)\n\n## Summary\n\nEnables endpoint integrations ftr test.\n\ncloses: https://github.com/elastic/kibana/issues/203916\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1119bf187dc04e130c3df610b5fdeb7301e40311"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214120","number":214120,"mergeCommit":{"message":"[Security Solution][Defend Workflows] Enables endpoint integrations FTR tests (#214120)\n\n## Summary\n\nEnables endpoint integrations ftr test.\n\ncloses: https://github.com/elastic/kibana/issues/203916\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1119bf187dc04e130c3df610b5fdeb7301e40311"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: David Sánchez <david.sanchezsoler@elastic.co> |
||
|
Kibana Machine
|
856fb83a9e
|
[8.18] [ResponseOps] mustache lambdas for EncodeURI and EncodeURIComponent, take 2 (#213859) (#215233)
# Backport This will backport the following commits from `main` to `8.18`: - [[ResponseOps] mustache lambdas for EncodeURI and EncodeURIComponent, take 2 (#213859)](https://github.com/elastic/kibana/pull/213859) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Patrick Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2025-03-19T18:54:03Z","message":"[ResponseOps] mustache lambdas for EncodeURI and EncodeURIComponent, take 2 (#213859)\n\nresolves https://github.com/elastic/kibana/issues/168728\n\n## Release note\n\nAdds Mustache lambdas for alerting actions to encode URLs with\n`{{#EncodeURI}}` and `{{#EncodeURIComponent}}` using `encodeURI()` and\n`encodeURIComponent()`.\n\ndoc to update, in a separate PR:\nhttps://github.com/elastic/docs-content/issues/735","sha":"a3aaa04eba457e8d1696275c1bf6942b8e1544dd","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:ResponseOps","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[ResponseOps] mustache lambdas for EncodeURI and EncodeURIComponent, take 2","number":213859,"url":"https://github.com/elastic/kibana/pull/213859","mergeCommit":{"message":"[ResponseOps] mustache lambdas for EncodeURI and EncodeURIComponent, take 2 (#213859)\n\nresolves https://github.com/elastic/kibana/issues/168728\n\n## Release note\n\nAdds Mustache lambdas for alerting actions to encode URLs with\n`{{#EncodeURI}}` and `{{#EncodeURIComponent}}` using `encodeURI()` and\n`encodeURIComponent()`.\n\ndoc to update, in a separate PR:\nhttps://github.com/elastic/docs-content/issues/735","sha":"a3aaa04eba457e8d1696275c1bf6942b8e1544dd"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213859","number":213859,"mergeCommit":{"message":"[ResponseOps] mustache lambdas for EncodeURI and EncodeURIComponent, take 2 (#213859)\n\nresolves https://github.com/elastic/kibana/issues/168728\n\n## Release note\n\nAdds Mustache lambdas for alerting actions to encode URLs with\n`{{#EncodeURI}}` and `{{#EncodeURIComponent}}` using `encodeURI()` and\n`encodeURIComponent()`.\n\ndoc to update, in a separate PR:\nhttps://github.com/elastic/docs-content/issues/735","sha":"a3aaa04eba457e8d1696275c1bf6942b8e1544dd"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Patrick Mueller <patrick.mueller@elastic.co> |
||
Nick Peihl
|
c3ad108918
|
[8.18] [Dashboards] Add event-annotation-group to saved object privileges (#212926) (#214878)
# Backport This will backport the following commits from `main` to `8.18`: - [[Dashboards] Add event-annotation-group to saved object privileges (#212926)](https://github.com/elastic/kibana/pull/212926) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2025-03-12T19:46:06Z","message":"[Dashboards] Add event-annotation-group to saved object privileges (#212926)\n\nFixes #173320 \n\n## Summary\n\nAdds `event-annotation-group` to Dashboard saved object privileges.\n\nFixes a bug where annotation groups saved to the library can not be\nloaded by users who lack \"Saved Object Management\" privileges. Similar\nto https://github.com/elastic/kibana/pull/173332.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"1feeb6f6916f522776b3a060beae06551d8bc21b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:all-open","v9.1.0"],"title":"[Dashboards] Add event-annotation-group to saved object privileges","number":212926,"url":"https://github.com/elastic/kibana/pull/212926","mergeCommit":{"message":"[Dashboards] Add event-annotation-group to saved object privileges (#212926)\n\nFixes #173320 \n\n## Summary\n\nAdds `event-annotation-group` to Dashboard saved object privileges.\n\nFixes a bug where annotation groups saved to the library can not be\nloaded by users who lack \"Saved Object Management\" privileges. Similar\nto https://github.com/elastic/kibana/pull/173332.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"1feeb6f6916f522776b3a060beae06551d8bc21b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/214277","number":214277,"state":"MERGED","mergeCommit":{"sha":"d356e796c475ece6e9c38b4c5135f2c32de6f6be","message":"[9.0] [Dashboards] Add event-annotation-group to saved object privileges (#212926) (#214277)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Dashboards] Add event-annotation-group to saved object privileges\n(#212926)](https://github.com/elastic/kibana/pull/212926)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Nick Peihl <nick.peihl@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212926","number":212926,"mergeCommit":{"message":"[Dashboards] Add event-annotation-group to saved object privileges (#212926)\n\nFixes #173320 \n\n## Summary\n\nAdds `event-annotation-group` to Dashboard saved object privileges.\n\nFixes a bug where annotation groups saved to the library can not be\nloaded by users who lack \"Saved Object Management\" privileges. Similar\nto https://github.com/elastic/kibana/pull/173332.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"1feeb6f6916f522776b3a060beae06551d8bc21b"}}]}] BACKPORT--> |
||
Elena Stoeva
|
6eafb929e8
|
[8.18] Fix data streams API integration tests (#214731)
Fixes https://github.com/elastic/kibana/issues/209014 ## Summary This PR updates the 8.18 data stream API integration tests to fix the failures in the 8.x -> 9.0 forward compatibility tests. To run the forward-compatibility tests locally: ``` ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/9.0.0/manifest-latest-verified.json" node scripts/functional_tests_server.js --config ./x-pack/test/api_integration/apis/management/config.ts ``` and ``` ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/9.0.0/manifest-latest-verified.json" node scripts/functional_test_runner.js --config ./x-pack/test/api_integration/apis/management/config.ts --grep="Data streams" ``` |
||
Jacek Kolezynski
|
80909da78f
|
[8.18] [Security Solution] Add note about removing bulk crud API in v9.0 and migrate examples (#213260) (#214710)
# Backport This will backport the following commits from `8.x` to `8.18`: - [[Security Solution] Add note about removing bulk crud API in v9.0 and migrate examples (#213260)](https://github.com/elastic/kibana/pull/213260) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jacek Kolezynski","email":"jacek.kolezynski@elastic.co"},"sourceCommit":{"committedDate":"2025-03-14T19:55:22Z","message":"[Security Solution] Add note about removing bulk crud API in v9.0 and migrate examples (#213260)\n\n**Partially addresses:** #211808,\nhttps://github.com/elastic/security-docs/issues/5981 (internal)\n\n## Summary\n\nThis is the third part of the migration effort, containing changes for\nBULK CRUD:\n- adding a note informing of removing this API in v.9.0\n- migrating examples\n- adding infos in description\n\nThis PR will be backported only to versions for Kibana v8\n\n# Testing\n1. cd x-pack/solutions/security/plugins/security_solution\n2. yarn openapi:bundle:detections \n3. Take the bundled file\n(docs/openapi/ess/security_solution_detections_api_2023_10_31.bundled.schema.yaml)\nand load it into bump.sh console to see the changes.\n4. Compare the changes with the [Legacy\ndocumentation](https://www.elastic.co/guide/en/security/current/rule-api-overview.html)\n\nYou can also use this [link](https://bump.sh/jkelas2/doc/kibana_wip3/)\nwhere I deployed the generated bundled doc.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Georgii Gorbachev <banderror@gmail.com>","sha":"e334449b82da6fad82808091e860f4c2248fcb74","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","APIDocs","Team:Detection Rule Management","backport:version","8.18 candidate","v8.18.0","v8.19.0"],"title":"[Security Solution] Add note about removing bulk crud API in v9.0 and migrate examples","number":213260,"url":"https://github.com/elastic/kibana/pull/213260","mergeCommit":{"message":"[Security Solution] Add note about removing bulk crud API in v9.0 and migrate examples (#213260)\n\n**Partially addresses:** #211808,\nhttps://github.com/elastic/security-docs/issues/5981 (internal)\n\n## Summary\n\nThis is the third part of the migration effort, containing changes for\nBULK CRUD:\n- adding a note informing of removing this API in v.9.0\n- migrating examples\n- adding infos in description\n\nThis PR will be backported only to versions for Kibana v8\n\n# Testing\n1. cd x-pack/solutions/security/plugins/security_solution\n2. yarn openapi:bundle:detections \n3. Take the bundled file\n(docs/openapi/ess/security_solution_detections_api_2023_10_31.bundled.schema.yaml)\nand load it into bump.sh console to see the changes.\n4. Compare the changes with the [Legacy\ndocumentation](https://www.elastic.co/guide/en/security/current/rule-api-overview.html)\n\nYou can also use this [link](https://bump.sh/jkelas2/doc/kibana_wip3/)\nwhere I deployed the generated bundled doc.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Georgii Gorbachev <banderror@gmail.com>","sha":"e334449b82da6fad82808091e860f4c2248fcb74"}},"sourceBranch":"8.x","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
Jean-Louis Leysens
|
80ca1caf91
|
[8.18] [UA] Use reindex_required metadata to drive corrective actions (#214532) (#214643)
# Backport This will backport the following commits from `8.x` to `8.18`: - [[UA] Use `reindex_required` metadata to drive corrective actions (#214532)](https://github.com/elastic/kibana/pull/214532) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jean-Louis Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2025-03-14T18:50:43Z","message":"[UA] Use `reindex_required` metadata to drive corrective actions (#214532)\n\n## Summary\n\nTested locally and critical old data deprecations are still surfaced as\nexpected\n\n<img width=\"586\" alt=\"Screenshot 2025-03-14 at 10 12 50\"\nsrc=\"https://github.com/user-attachments/assets/25d87fbd-7c98-45e0-a86a-d513ea455571\"\n/>","sha":"26aba9287821f289deb11b27079a9a7d0945c714","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Upgrade Assistant","backport:version","v8.18.0","v8.19.0","v8.18.1"],"title":"[UA] Use `reindex_required` metadata to drive corrective actions","number":214532,"url":"https://github.com/elastic/kibana/pull/214532","mergeCommit":{"message":"[UA] Use `reindex_required` metadata to drive corrective actions (#214532)\n\n## Summary\n\nTested locally and critical old data deprecations are still surfaced as\nexpected\n\n<img width=\"586\" alt=\"Screenshot 2025-03-14 at 10 12 50\"\nsrc=\"https://github.com/user-attachments/assets/25d87fbd-7c98-45e0-a86a-d513ea455571\"\n/>","sha":"26aba9287821f289deb11b27079a9a7d0945c714"}},"sourceBranch":"8.x","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
Christos Nasikas
|
12996e20b2
|
[8.18] [Cases] Improve unit test flakiness (#212489) (#214676)
# Backport This will backport the following commits from `main` to `8.18`: - [[Cases] Improve unit test flakiness (#212489)](https://github.com/elastic/kibana/pull/212489) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Christos Nasikas","email":"christos.nasikas@elastic.co"},"sourceCommit":{"committedDate":"2025-03-14T17:17:13Z","message":"[Cases] Improve unit test flakiness (#212489)\n\n## Summary\n\nThis PR attempts (I have lost count of how many there have been so far)\nto stabilize the flakiness of cases tests.\n\n## Approach\n\nBased on our investigations, I believe a common factor that causes all\ntests to time out is how we wrap the tests with the needed providers.\nInstead of figuring out why they time out (which is very difficult), I\ntried a different approach. I rewrote how we initialize the testing\ndependencies, mocks, and providers on tests. To test my theory, I\ncreated a VM instance in GCloud with the same configuration as the one\nrunning in the CI, specifically the n2-standard-4 (4 vCPUs, 16 GB\nMemory) machine type. I ran the tests 100 times, which took almost two\ndays. In 10 of the runs, a random test was timeouted. I noticed that the\nmachine was stressed while running the tests, and the CPU frequently\nspiked to 100%, especially at the beginning of each test. Then, I\nincreased the timeout for all cases tests to 10 seconds and ran the\ntests again 100 times. No timeouts occurred. Lastly, I created a VM\ninstance in GCloud with the same configuration as the one running in the\nCI, specifically the n2-standard-8 (8 vCPUs, 32 GB Memory) machine type.\nI ran the tests again 100 times. In 1 of the runs, a random test was\ntimeouted. The machine on the CI cannot handle the cases tests. I\nbelieve the work in this PR is a step in the right direction either way,\nand we will benefit from it. I also believe increasing the timeout is a\ngood decision as we need it based on the experiments and the research we\nhave done in the last months.\n\nCPU usage on n2-standard-4\n\n\nhttps://github.com/user-attachments/assets/36b035df-310f-4906-98ba-688d57b97c7e\n\nCPU usage on n2-standard-8\n\n\nhttps://github.com/user-attachments/assets/3b1b6351-d48e-41da-a413-a56e52b54b82\n\n## RLT eslint rules\nI enabled the [RLT eslint\nrules](https://testing-library.com/docs/ecosystem-eslint-plugin-testing-library/)\nfor Cases and resolved any eslint errors. The process revealed small\nbugs in the tests, which I fixed them.\n\n## Testing utils\n\nI removed the `appMockRender` and any usage in favor of the new\n`renderWithTestingProviders` utility function and the improved\n`TestProviders` component. The `renderWithTestingProviders` follows the\nprincipals\n[suggested](https://github.com/testing-library/react-testing-library/issues/780#issuecomment-689053441)\nby the RLT team. Specifically:\n- The `renderWithTestingProviders` is a wrapper of the `render` function\nof the RTL library.\n- The `renderWithTestingProviders` does not create the services or any\ncomponent inside it.\n- The `renderWithTestingProviders` cannot be used in `beforeEach`\nfunctions. It should be called separately on each test.\n- The `renderWithTestingProviders` accepts props to override the default\nmocks.\n- The `renderWithTestingProviders` passes the `TestProviders` in the\n`wrapper` argument of the RLT `render` function.\n- The `TestProviders` component initializes and memoizes all services\nand dependencies. It accepts props to override the default mocks.\n- Mock overrides (like core services) should be created and passed to\n`renderWithTestingProviders` on each test, even if it means duplication.\nWe favor test isolation.\n\n### Checklist\n\nCheck the PR satisfies the following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n## Issues\n<details>\n<summary>List</summary>\n\nFixes: https://github.com/elastic/kibana/issues/207712\nFixes: https://github.com/elastic/kibana/issues/192739\nFixes: https://github.com/elastic/kibana/issues/174682\nFixes: https://github.com/elastic/kibana/issues/206366\nFixes: https://github.com/elastic/kibana/issues/207427\nFixes: https://github.com/elastic/kibana/issues/175239\nFixes: https://github.com/elastic/kibana/issues/177334\nFixes: https://github.com/elastic/kibana/issues/208443\nFixes: https://github.com/elastic/kibana/issues/187526\nFixes: https://github.com/elastic/kibana/issues/208310\nFixes: https://github.com/elastic/kibana/issues/192640\nFixes: https://github.com/elastic/kibana/issues/207077\nFixes: https://github.com/elastic/kibana/issues/197304\nFixes: https://github.com/elastic/kibana/issues/207249\nFixes: https://github.com/elastic/kibana/issues/202761\nFixes: https://github.com/elastic/kibana/issues/202115\nFixes: https://github.com/elastic/kibana/issues/193026\nFixes: https://github.com/elastic/kibana/issues/177304\nFixes: https://github.com/elastic/kibana/issues/208415\nFixes: https://github.com/elastic/kibana/issues/174661\nFixes: https://github.com/elastic/kibana/issues/201611\nFixes: https://github.com/elastic/kibana/issues/182364\nFixes: https://github.com/elastic/kibana/issues/175841\nFixes: https://github.com/elastic/kibana/issues/207907\nFixes: https://github.com/elastic/kibana/issues/171177\nFixes: https://github.com/elastic/kibana/issues/196628\nFixes: https://github.com/elastic/kibana/issues/194703\nFixes: https://github.com/elastic/kibana/issues/207241\nFixes: https://github.com/elastic/kibana/issues/206056\nFixes: https://github.com/elastic/kibana/issues/207328\nFixes: https://github.com/elastic/kibana/issues/205953\nFixes: https://github.com/elastic/kibana/issues/176524\nFixes: https://github.com/elastic/kibana/issues/176335\nFixes: https://github.com/elastic/kibana/issues/207404\nFixes: https://github.com/elastic/kibana/issues/207384\nFixes: https://github.com/elastic/kibana/issues/208380\nFixes: https://github.com/elastic/kibana/issues/207248\nFixes: https://github.com/elastic/kibana/issues/207444\nFixes: https://github.com/elastic/kibana/issues/175240\nFixes: https://github.com/elastic/kibana/issues/178001\n\n</details>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1054799f9c1139c52d74c9c588f60177182919c7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Cases] Improve unit test flakiness","number":212489,"url":"https://github.com/elastic/kibana/pull/212489","mergeCommit":{"message":"[Cases] Improve unit test flakiness (#212489)\n\n## Summary\n\nThis PR attempts (I have lost count of how many there have been so far)\nto stabilize the flakiness of cases tests.\n\n## Approach\n\nBased on our investigations, I believe a common factor that causes all\ntests to time out is how we wrap the tests with the needed providers.\nInstead of figuring out why they time out (which is very difficult), I\ntried a different approach. I rewrote how we initialize the testing\ndependencies, mocks, and providers on tests. To test my theory, I\ncreated a VM instance in GCloud with the same configuration as the one\nrunning in the CI, specifically the n2-standard-4 (4 vCPUs, 16 GB\nMemory) machine type. I ran the tests 100 times, which took almost two\ndays. In 10 of the runs, a random test was timeouted. I noticed that the\nmachine was stressed while running the tests, and the CPU frequently\nspiked to 100%, especially at the beginning of each test. Then, I\nincreased the timeout for all cases tests to 10 seconds and ran the\ntests again 100 times. No timeouts occurred. Lastly, I created a VM\ninstance in GCloud with the same configuration as the one running in the\nCI, specifically the n2-standard-8 (8 vCPUs, 32 GB Memory) machine type.\nI ran the tests again 100 times. In 1 of the runs, a random test was\ntimeouted. The machine on the CI cannot handle the cases tests. I\nbelieve the work in this PR is a step in the right direction either way,\nand we will benefit from it. I also believe increasing the timeout is a\ngood decision as we need it based on the experiments and the research we\nhave done in the last months.\n\nCPU usage on n2-standard-4\n\n\nhttps://github.com/user-attachments/assets/36b035df-310f-4906-98ba-688d57b97c7e\n\nCPU usage on n2-standard-8\n\n\nhttps://github.com/user-attachments/assets/3b1b6351-d48e-41da-a413-a56e52b54b82\n\n## RLT eslint rules\nI enabled the [RLT eslint\nrules](https://testing-library.com/docs/ecosystem-eslint-plugin-testing-library/)\nfor Cases and resolved any eslint errors. The process revealed small\nbugs in the tests, which I fixed them.\n\n## Testing utils\n\nI removed the `appMockRender` and any usage in favor of the new\n`renderWithTestingProviders` utility function and the improved\n`TestProviders` component. The `renderWithTestingProviders` follows the\nprincipals\n[suggested](https://github.com/testing-library/react-testing-library/issues/780#issuecomment-689053441)\nby the RLT team. Specifically:\n- The `renderWithTestingProviders` is a wrapper of the `render` function\nof the RTL library.\n- The `renderWithTestingProviders` does not create the services or any\ncomponent inside it.\n- The `renderWithTestingProviders` cannot be used in `beforeEach`\nfunctions. It should be called separately on each test.\n- The `renderWithTestingProviders` accepts props to override the default\nmocks.\n- The `renderWithTestingProviders` passes the `TestProviders` in the\n`wrapper` argument of the RLT `render` function.\n- The `TestProviders` component initializes and memoizes all services\nand dependencies. It accepts props to override the default mocks.\n- Mock overrides (like core services) should be created and passed to\n`renderWithTestingProviders` on each test, even if it means duplication.\nWe favor test isolation.\n\n### Checklist\n\nCheck the PR satisfies the following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n## Issues\n<details>\n<summary>List</summary>\n\nFixes: https://github.com/elastic/kibana/issues/207712\nFixes: https://github.com/elastic/kibana/issues/192739\nFixes: https://github.com/elastic/kibana/issues/174682\nFixes: https://github.com/elastic/kibana/issues/206366\nFixes: https://github.com/elastic/kibana/issues/207427\nFixes: https://github.com/elastic/kibana/issues/175239\nFixes: https://github.com/elastic/kibana/issues/177334\nFixes: https://github.com/elastic/kibana/issues/208443\nFixes: https://github.com/elastic/kibana/issues/187526\nFixes: https://github.com/elastic/kibana/issues/208310\nFixes: https://github.com/elastic/kibana/issues/192640\nFixes: https://github.com/elastic/kibana/issues/207077\nFixes: https://github.com/elastic/kibana/issues/197304\nFixes: https://github.com/elastic/kibana/issues/207249\nFixes: https://github.com/elastic/kibana/issues/202761\nFixes: https://github.com/elastic/kibana/issues/202115\nFixes: https://github.com/elastic/kibana/issues/193026\nFixes: https://github.com/elastic/kibana/issues/177304\nFixes: https://github.com/elastic/kibana/issues/208415\nFixes: https://github.com/elastic/kibana/issues/174661\nFixes: https://github.com/elastic/kibana/issues/201611\nFixes: https://github.com/elastic/kibana/issues/182364\nFixes: https://github.com/elastic/kibana/issues/175841\nFixes: https://github.com/elastic/kibana/issues/207907\nFixes: https://github.com/elastic/kibana/issues/171177\nFixes: https://github.com/elastic/kibana/issues/196628\nFixes: https://github.com/elastic/kibana/issues/194703\nFixes: https://github.com/elastic/kibana/issues/207241\nFixes: https://github.com/elastic/kibana/issues/206056\nFixes: https://github.com/elastic/kibana/issues/207328\nFixes: https://github.com/elastic/kibana/issues/205953\nFixes: https://github.com/elastic/kibana/issues/176524\nFixes: https://github.com/elastic/kibana/issues/176335\nFixes: https://github.com/elastic/kibana/issues/207404\nFixes: https://github.com/elastic/kibana/issues/207384\nFixes: https://github.com/elastic/kibana/issues/208380\nFixes: https://github.com/elastic/kibana/issues/207248\nFixes: https://github.com/elastic/kibana/issues/207444\nFixes: https://github.com/elastic/kibana/issues/175240\nFixes: https://github.com/elastic/kibana/issues/178001\n\n</details>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1054799f9c1139c52d74c9c588f60177182919c7"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212489","number":212489,"mergeCommit":{"message":"[Cases] Improve unit test flakiness (#212489)\n\n## Summary\n\nThis PR attempts (I have lost count of how many there have been so far)\nto stabilize the flakiness of cases tests.\n\n## Approach\n\nBased on our investigations, I believe a common factor that causes all\ntests to time out is how we wrap the tests with the needed providers.\nInstead of figuring out why they time out (which is very difficult), I\ntried a different approach. I rewrote how we initialize the testing\ndependencies, mocks, and providers on tests. To test my theory, I\ncreated a VM instance in GCloud with the same configuration as the one\nrunning in the CI, specifically the n2-standard-4 (4 vCPUs, 16 GB\nMemory) machine type. I ran the tests 100 times, which took almost two\ndays. In 10 of the runs, a random test was timeouted. I noticed that the\nmachine was stressed while running the tests, and the CPU frequently\nspiked to 100%, especially at the beginning of each test. Then, I\nincreased the timeout for all cases tests to 10 seconds and ran the\ntests again 100 times. No timeouts occurred. Lastly, I created a VM\ninstance in GCloud with the same configuration as the one running in the\nCI, specifically the n2-standard-8 (8 vCPUs, 32 GB Memory) machine type.\nI ran the tests again 100 times. In 1 of the runs, a random test was\ntimeouted. The machine on the CI cannot handle the cases tests. I\nbelieve the work in this PR is a step in the right direction either way,\nand we will benefit from it. I also believe increasing the timeout is a\ngood decision as we need it based on the experiments and the research we\nhave done in the last months.\n\nCPU usage on n2-standard-4\n\n\nhttps://github.com/user-attachments/assets/36b035df-310f-4906-98ba-688d57b97c7e\n\nCPU usage on n2-standard-8\n\n\nhttps://github.com/user-attachments/assets/3b1b6351-d48e-41da-a413-a56e52b54b82\n\n## RLT eslint rules\nI enabled the [RLT eslint\nrules](https://testing-library.com/docs/ecosystem-eslint-plugin-testing-library/)\nfor Cases and resolved any eslint errors. The process revealed small\nbugs in the tests, which I fixed them.\n\n## Testing utils\n\nI removed the `appMockRender` and any usage in favor of the new\n`renderWithTestingProviders` utility function and the improved\n`TestProviders` component. The `renderWithTestingProviders` follows the\nprincipals\n[suggested](https://github.com/testing-library/react-testing-library/issues/780#issuecomment-689053441)\nby the RLT team. Specifically:\n- The `renderWithTestingProviders` is a wrapper of the `render` function\nof the RTL library.\n- The `renderWithTestingProviders` does not create the services or any\ncomponent inside it.\n- The `renderWithTestingProviders` cannot be used in `beforeEach`\nfunctions. It should be called separately on each test.\n- The `renderWithTestingProviders` accepts props to override the default\nmocks.\n- The `renderWithTestingProviders` passes the `TestProviders` in the\n`wrapper` argument of the RLT `render` function.\n- The `TestProviders` component initializes and memoizes all services\nand dependencies. It accepts props to override the default mocks.\n- Mock overrides (like core services) should be created and passed to\n`renderWithTestingProviders` on each test, even if it means duplication.\nWe favor test isolation.\n\n### Checklist\n\nCheck the PR satisfies the following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n## Issues\n<details>\n<summary>List</summary>\n\nFixes: https://github.com/elastic/kibana/issues/207712\nFixes: https://github.com/elastic/kibana/issues/192739\nFixes: https://github.com/elastic/kibana/issues/174682\nFixes: https://github.com/elastic/kibana/issues/206366\nFixes: https://github.com/elastic/kibana/issues/207427\nFixes: https://github.com/elastic/kibana/issues/175239\nFixes: https://github.com/elastic/kibana/issues/177334\nFixes: https://github.com/elastic/kibana/issues/208443\nFixes: https://github.com/elastic/kibana/issues/187526\nFixes: https://github.com/elastic/kibana/issues/208310\nFixes: https://github.com/elastic/kibana/issues/192640\nFixes: https://github.com/elastic/kibana/issues/207077\nFixes: https://github.com/elastic/kibana/issues/197304\nFixes: https://github.com/elastic/kibana/issues/207249\nFixes: https://github.com/elastic/kibana/issues/202761\nFixes: https://github.com/elastic/kibana/issues/202115\nFixes: https://github.com/elastic/kibana/issues/193026\nFixes: https://github.com/elastic/kibana/issues/177304\nFixes: https://github.com/elastic/kibana/issues/208415\nFixes: https://github.com/elastic/kibana/issues/174661\nFixes: https://github.com/elastic/kibana/issues/201611\nFixes: https://github.com/elastic/kibana/issues/182364\nFixes: https://github.com/elastic/kibana/issues/175841\nFixes: https://github.com/elastic/kibana/issues/207907\nFixes: https://github.com/elastic/kibana/issues/171177\nFixes: https://github.com/elastic/kibana/issues/196628\nFixes: https://github.com/elastic/kibana/issues/194703\nFixes: https://github.com/elastic/kibana/issues/207241\nFixes: https://github.com/elastic/kibana/issues/206056\nFixes: https://github.com/elastic/kibana/issues/207328\nFixes: https://github.com/elastic/kibana/issues/205953\nFixes: https://github.com/elastic/kibana/issues/176524\nFixes: https://github.com/elastic/kibana/issues/176335\nFixes: https://github.com/elastic/kibana/issues/207404\nFixes: https://github.com/elastic/kibana/issues/207384\nFixes: https://github.com/elastic/kibana/issues/208380\nFixes: https://github.com/elastic/kibana/issues/207248\nFixes: https://github.com/elastic/kibana/issues/207444\nFixes: https://github.com/elastic/kibana/issues/175240\nFixes: https://github.com/elastic/kibana/issues/178001\n\n</details>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"1054799f9c1139c52d74c9c588f60177182919c7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
Dmitrii Shevchenko
|
f6e91fbdf5
|
[8.18] [Security Solution] Remove the customization check when importing rules (#214577) (#214651)
# Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Remove the customization check when importing rules (#214577)](https://github.com/elastic/kibana/pull/214577) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dmitrii Shevchenko","email":"dmitrii.shevchenko@elastic.co"},"sourceCommit":{"committedDate":"2025-03-14T19:14:32Z","message":"[Security Solution] Remove the customization check when importing rules (#214577)","sha":"67d6707715b5508d44666a068ffd5a00cfa92e08","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Remove the customization check when importing rules","number":214577,"url":"https://github.com/elastic/kibana/pull/214577","mergeCommit":{"message":"[Security Solution] Remove the customization check when importing rules (#214577)","sha":"67d6707715b5508d44666a068ffd5a00cfa92e08"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214577","number":214577,"mergeCommit":{"message":"[Security Solution] Remove the customization check when importing rules (#214577)","sha":"67d6707715b5508d44666a068ffd5a00cfa92e08"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> |
||
|
Kibana Machine
|
9ecdbde42d
|
[8.18] [Detection Engine] Cypress - Add more robust selection from our DataView dropdown component (#213510) (#214605)
# Backport This will backport the following commits from `main` to `8.18`: - [[Detection Engine] Cypress - Add more robust selection from our DataView dropdown component (#213510)](https://github.com/elastic/kibana/pull/213510) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ryland Herrick","email":"ryalnd@gmail.com"},"sourceCommit":{"committedDate":"2025-03-14T16:10:27Z","message":"[Detection Engine] Cypress - Add more robust selection from our DataView dropdown component (#213510)\n\nThis addresses some recent cypress failures: \n\n* https://github.com/elastic/kibana/issues/212743 (Rule Creation with a\nDataView)\n* https://github.com/elastic/kibana/issues/212742 (Rule Creation + Edit\nwith a DataView)\n* https://github.com/elastic/kibana/issues/213752 (Rule Creation +\nFilter with a DataView)\n\nThis appears (as much as a cypress failure can 😓) to be caused by an\nincorrect/false-positive assertion, leading to us (very occasionally)\ninteracting with the combobox before it's ready. We were calling\n`.should('not.be.disabled')` on an element that could never be disabled.\nBy calling that instead on the inner `input` that actually is\nenabled/disabled, we have the sanity check that was originally intended.\n\nThis PR also adds a post-action check (`.should('contains',\nthingThatWasTyped)`) so that if the action fails, the test doesn't fail\ninscrutably at a later step.\n\n### Evidence\n\n*\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8003\n(50x)\n*\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8004\n(200x)\n*\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8033\n(200x)\n\n### Significance\n\n**Note also** that some initial investigation found this pattern in\nseveral places in our test suite. I'm going to follow up on this focused\nPR with a more comprehensive one (once this is proven out in the flaky\nrunner).\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"02409dbd65c0262022cdee918e6651d8afc7b330","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-major","Team:Detection Engine","v9.1.0"],"title":"[Detection Engine] Cypress - Add more robust selection from our DataView dropdown component","number":213510,"url":"https://github.com/elastic/kibana/pull/213510","mergeCommit":{"message":"[Detection Engine] Cypress - Add more robust selection from our DataView dropdown component (#213510)\n\nThis addresses some recent cypress failures: \n\n* https://github.com/elastic/kibana/issues/212743 (Rule Creation with a\nDataView)\n* https://github.com/elastic/kibana/issues/212742 (Rule Creation + Edit\nwith a DataView)\n* https://github.com/elastic/kibana/issues/213752 (Rule Creation +\nFilter with a DataView)\n\nThis appears (as much as a cypress failure can 😓) to be caused by an\nincorrect/false-positive assertion, leading to us (very occasionally)\ninteracting with the combobox before it's ready. We were calling\n`.should('not.be.disabled')` on an element that could never be disabled.\nBy calling that instead on the inner `input` that actually is\nenabled/disabled, we have the sanity check that was originally intended.\n\nThis PR also adds a post-action check (`.should('contains',\nthingThatWasTyped)`) so that if the action fails, the test doesn't fail\ninscrutably at a later step.\n\n### Evidence\n\n*\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8003\n(50x)\n*\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8004\n(200x)\n*\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8033\n(200x)\n\n### Significance\n\n**Note also** that some initial investigation found this pattern in\nseveral places in our test suite. I'm going to follow up on this focused\nPR with a more comprehensive one (once this is proven out in the flaky\nrunner).\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"02409dbd65c0262022cdee918e6651d8afc7b330"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213510","number":213510,"mergeCommit":{"message":"[Detection Engine] Cypress - Add more robust selection from our DataView dropdown component (#213510)\n\nThis addresses some recent cypress failures: \n\n* https://github.com/elastic/kibana/issues/212743 (Rule Creation with a\nDataView)\n* https://github.com/elastic/kibana/issues/212742 (Rule Creation + Edit\nwith a DataView)\n* https://github.com/elastic/kibana/issues/213752 (Rule Creation +\nFilter with a DataView)\n\nThis appears (as much as a cypress failure can 😓) to be caused by an\nincorrect/false-positive assertion, leading to us (very occasionally)\ninteracting with the combobox before it's ready. We were calling\n`.should('not.be.disabled')` on an element that could never be disabled.\nBy calling that instead on the inner `input` that actually is\nenabled/disabled, we have the sanity check that was originally intended.\n\nThis PR also adds a post-action check (`.should('contains',\nthingThatWasTyped)`) so that if the action fails, the test doesn't fail\ninscrutably at a later step.\n\n### Evidence\n\n*\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8003\n(50x)\n*\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8004\n(200x)\n*\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8033\n(200x)\n\n### Significance\n\n**Note also** that some initial investigation found this pattern in\nseveral places in our test suite. I'm going to follow up on this focused\nPR with a more comprehensive one (once this is proven out in the flaky\nrunner).\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"02409dbd65c0262022cdee918e6651d8afc7b330"}}]}] BACKPORT--> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> |
||
Jan Monschke
|
0fef04ccc6
|
[8.18] [Threat Hunting Investigations] Improve API docs for notes/timeline (#213584) (#214528)
# Backport This will backport the following commits from `main` to `8.18`: - [[Threat Hunting Investigations] Improve API docs for notes/timeline (#213584)](https://github.com/elastic/kibana/pull/213584) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jan Monschke","email":"jan.monschke@elastic.co"},"sourceCommit":{"committedDate":"2025-03-12T17:55:54Z","message":"[Threat Hunting Investigations] Improve API docs for notes/timeline (#213584)\n\n## Summary\n\n[META\nissue](https://github.com/elastic/security-docs-internal/issues/57)\n\nThis PR improves the API documentation for timeline/notes/pinned events\nas per the definition in the meta issue.\n\n### Notes\n#### Timeline API\n- `eventType`:\n\t- is always set to `all`\n\t- looks like it's been superseded by dataView?\n\t- I marked it as `deperecated` \n- `eventIdToNoteIds`:\n- there's a type mismatch between what the frontend expects and what is\nreturned\n\t- also it does not seem to be used anymore?\n\t- it needs to be investigated further\n#### Notes API\n- `GlobalNote`:\n\t- looks like it's not used anymore\n\t- I removed it, nothing broke\n- `eventIngested`, `eventTimestamp`, `eventDataView` and `overrideOwner`\nare all not used on the patch note endpoint, I removed them. The\n`event*` ones I have never seen before to be honest.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"e3311c516b45999e875b92ff14140a3197babfc6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:all-open","v9.1.0"],"title":"[Threat Hunting Investigations] Improve API docs for notes/timeline","number":213584,"url":"https://github.com/elastic/kibana/pull/213584","mergeCommit":{"message":"[Threat Hunting Investigations] Improve API docs for notes/timeline (#213584)\n\n## Summary\n\n[META\nissue](https://github.com/elastic/security-docs-internal/issues/57)\n\nThis PR improves the API documentation for timeline/notes/pinned events\nas per the definition in the meta issue.\n\n### Notes\n#### Timeline API\n- `eventType`:\n\t- is always set to `all`\n\t- looks like it's been superseded by dataView?\n\t- I marked it as `deperecated` \n- `eventIdToNoteIds`:\n- there's a type mismatch between what the frontend expects and what is\nreturned\n\t- also it does not seem to be used anymore?\n\t- it needs to be investigated further\n#### Notes API\n- `GlobalNote`:\n\t- looks like it's not used anymore\n\t- I removed it, nothing broke\n- `eventIngested`, `eventTimestamp`, `eventDataView` and `overrideOwner`\nare all not used on the patch note endpoint, I removed them. The\n`event*` ones I have never seen before to be honest.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"e3311c516b45999e875b92ff14140a3197babfc6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/214261","number":214261,"state":"MERGED","mergeCommit":{"sha":"77caf7c24a7424c52e5b37107768ce3d4ff15bfb","message":"[9.0] [Threat Hunting Investigations] Improve API docs for notes/timeline (#213584) (#214261)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Threat Hunting Investigations] Improve API docs for notes/timeline\n(#213584)](https://github.com/elastic/kibana/pull/213584)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Jan Monschke <jan.monschke@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213584","number":213584,"mergeCommit":{"message":"[Threat Hunting Investigations] Improve API docs for notes/timeline (#213584)\n\n## Summary\n\n[META\nissue](https://github.com/elastic/security-docs-internal/issues/57)\n\nThis PR improves the API documentation for timeline/notes/pinned events\nas per the definition in the meta issue.\n\n### Notes\n#### Timeline API\n- `eventType`:\n\t- is always set to `all`\n\t- looks like it's been superseded by dataView?\n\t- I marked it as `deperecated` \n- `eventIdToNoteIds`:\n- there's a type mismatch between what the frontend expects and what is\nreturned\n\t- also it does not seem to be used anymore?\n\t- it needs to be investigated further\n#### Notes API\n- `GlobalNote`:\n\t- looks like it's not used anymore\n\t- I removed it, nothing broke\n- `eventIngested`, `eventTimestamp`, `eventDataView` and `overrideOwner`\nare all not used on the patch note endpoint, I removed them. The\n`event*` ones I have never seen before to be honest.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"e3311c516b45999e875b92ff14140a3197babfc6"}}]}] BACKPORT--> |
||
|
Kibana Machine
|
efed88be26
|
[8.18] [Security Solution] Reverts all remaining diff algorithm fields to return Target version when base version is missing (#214287) (#214515)
# Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Reverts all remaining diff algorithm fields to return Target version when base version is missing (#214287)](https://github.com/elastic/kibana/pull/214287) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"56367316+dplumlee@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-14T07:20:37Z","message":"[Security Solution] Reverts all remaining diff algorithm fields to return Target version when base version is missing (#214287)\n\n## Summary\n\nOriginally we had intended to have the prebuilt rule diff algorithms\nmerge non-functional fields when the field's base version was missing\nand a rule was marked as customized as described in\nhttps://github.com/elastic/kibana/issues/210358\n\n> - When the rule has a missing base version and is marked as\ncustomized:\n> - We should attempt to merge all non-functional mergeable fields (any\nfield that doesn't have consequences with how the rule runs e.g. tags)\nand return them as SOLVABLE_CONFLICT\n\nWe ended up changing this logic to return the `Target` version for every\nfield that fit that description\n(https://github.com/elastic/kibana/pull/214161 and\nhttps://github.com/elastic/kibana/pull/213757) besides `tags` and in\norder to support consistency rather than a very minor edge case, we now\njust return the target version for every field with a missing base\nversion and let users sort it out on their end\n\nThis PR reverts the changes made to accommodate this edge case and\nupdates related tests to account for the new logic\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>","sha":"a2d2054148b8cd7a062cfabd477338a3fd55428b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Reverts all remaining diff algorithm fields to return Target version when base version is missing","number":214287,"url":"https://github.com/elastic/kibana/pull/214287","mergeCommit":{"message":"[Security Solution] Reverts all remaining diff algorithm fields to return Target version when base version is missing (#214287)\n\n## Summary\n\nOriginally we had intended to have the prebuilt rule diff algorithms\nmerge non-functional fields when the field's base version was missing\nand a rule was marked as customized as described in\nhttps://github.com/elastic/kibana/issues/210358\n\n> - When the rule has a missing base version and is marked as\ncustomized:\n> - We should attempt to merge all non-functional mergeable fields (any\nfield that doesn't have consequences with how the rule runs e.g. tags)\nand return them as SOLVABLE_CONFLICT\n\nWe ended up changing this logic to return the `Target` version for every\nfield that fit that description\n(https://github.com/elastic/kibana/pull/214161 and\nhttps://github.com/elastic/kibana/pull/213757) besides `tags` and in\norder to support consistency rather than a very minor edge case, we now\njust return the target version for every field with a missing base\nversion and let users sort it out on their end\n\nThis PR reverts the changes made to accommodate this edge case and\nupdates related tests to account for the new logic\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>","sha":"a2d2054148b8cd7a062cfabd477338a3fd55428b"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214287","number":214287,"mergeCommit":{"message":"[Security Solution] Reverts all remaining diff algorithm fields to return Target version when base version is missing (#214287)\n\n## Summary\n\nOriginally we had intended to have the prebuilt rule diff algorithms\nmerge non-functional fields when the field's base version was missing\nand a rule was marked as customized as described in\nhttps://github.com/elastic/kibana/issues/210358\n\n> - When the rule has a missing base version and is marked as\ncustomized:\n> - We should attempt to merge all non-functional mergeable fields (any\nfield that doesn't have consequences with how the rule runs e.g. tags)\nand return them as SOLVABLE_CONFLICT\n\nWe ended up changing this logic to return the `Target` version for every\nfield that fit that description\n(https://github.com/elastic/kibana/pull/214161 and\nhttps://github.com/elastic/kibana/pull/213757) besides `tags` and in\norder to support consistency rather than a very minor edge case, we now\njust return the target version for every field with a missing base\nversion and let users sort it out on their end\n\nThis PR reverts the changes made to accommodate this edge case and\nupdates related tests to account for the new logic\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>","sha":"a2d2054148b8cd7a062cfabd477338a3fd55428b"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com> |
||
|
Kibana Machine
|
a98a4c31f7
|
[8.18] [Stack Monitoring] New FTR for "view logs" link (#208351) (#214296)
# Backport This will backport the following commits from `main` to `8.18`: - [[Stack Monitoring] New FTR for "view logs" link (#208351)](https://github.com/elastic/kibana/pull/208351) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Valentin Crettaz","email":"valentin.crettaz@elastic.co"},"sourceCommit":{"committedDate":"2025-03-12T22:35:28Z","message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](https://github.com/elastic/kibana/issues/199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:Monitoring","release_note:skip","Feature:Stack Monitoring","FTR","v8.18.0","v8.17.2","v9.1.0"],"title":"[Stack Monitoring] New FTR for \"view logs\" link","number":208351,"url":"https://github.com/elastic/kibana/pull/208351","mergeCommit":{"message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](https://github.com/elastic/kibana/issues/199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.17"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208351","number":208351,"mergeCommit":{"message":"[Stack Monitoring] New FTR for \"view logs\" link (#208351)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/202675\n\nA [recent bug](https://github.com/elastic/kibana/issues/199902) broke\nthe Stack Monitoring UI only if/when logs were present. Functional test\ncoverage was lacking to detect such a situation.\n\nThis PR adds some functional test coverage to make sure that the \"View\nlogs\" link in Stack Monitoring works whenever logs are available,\nwherever logs can be visible, i.e. in the cluster overview page, the\nnode details page and the index details page.\n\n### Checklist\n\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"c218f4239a10dd7b0cd4aa24e0a627f9d779d94c"}}]}] BACKPORT--> Co-authored-by: Valentin Crettaz <valentin.crettaz@elastic.co> |
||
|
Kibana Machine
|
aed3dfbcaf
|
[8.18] [Security Solution] Force upgrading to target version for "Reference URLs" when base version is missing (#214161) (#214252)
# Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Force upgrading to target version for "Reference URLs" when base version is missing (#214161)](https://github.com/elastic/kibana/pull/214161) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2025-03-12T17:41:32Z","message":"[Security Solution] Force upgrading to target version for \"Reference URLs\" when base version is missing (#214161)\n\n**Resolves: https://github.com/elastic/kibana/issues/214171**\n\n## Summary\n\nThis PR fixes an issue with \"references\" field in -AB situations. When\nthe base version is missing we try to merge current and target arrays\nwhich leads to old and potentially broken URLs from the current version\nending up in the result.\n\nNow the behaviour is changed to always force merged version to be equal\nto target (which always has correct URLs).","sha":"07012811b29b487a3b4a664469c7a198355e44bf","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","impact:medium","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Force upgrading to target version for \"Reference URLs\" when base version is missing","number":214161,"url":"https://github.com/elastic/kibana/pull/214161","mergeCommit":{"message":"[Security Solution] Force upgrading to target version for \"Reference URLs\" when base version is missing (#214161)\n\n**Resolves: https://github.com/elastic/kibana/issues/214171**\n\n## Summary\n\nThis PR fixes an issue with \"references\" field in -AB situations. When\nthe base version is missing we try to merge current and target arrays\nwhich leads to old and potentially broken URLs from the current version\nending up in the result.\n\nNow the behaviour is changed to always force merged version to be equal\nto target (which always has correct URLs).","sha":"07012811b29b487a3b4a664469c7a198355e44bf"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214161","number":214161,"mergeCommit":{"message":"[Security Solution] Force upgrading to target version for \"Reference URLs\" when base version is missing (#214161)\n\n**Resolves: https://github.com/elastic/kibana/issues/214171**\n\n## Summary\n\nThis PR fixes an issue with \"references\" field in -AB situations. When\nthe base version is missing we try to merge current and target arrays\nwhich leads to old and potentially broken URLs from the current version\nending up in the result.\n\nNow the behaviour is changed to always force merged version to be equal\nto target (which always has correct URLs).","sha":"07012811b29b487a3b4a664469c7a198355e44bf"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nikita Indik <nikita.indik@elastic.co> |