Commit graph

3 commits

Author SHA1 Message Date
Tim Sullivan
d90731a1a3
[8.x] [SharedUX] Replace Sass with Emotion, Round 1 (#199885) (#203314)
# Backport

This will backport the following commits from `main` to `8.x`:
- [[SharedUX] Replace Sass with Emotion, Round 1
(#199885)](https://github.com/elastic/kibana/pull/199885)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tim
Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-04T17:39:22Z","message":"[SharedUX]
Replace Sass with Emotion, Round 1 (#199885)\n\n## Summary\r\n\r\nPart
of https://github.com/elastic/kibana-team/issues/1082\r\n\r\nSelects
certain Sass files to replace with styles declared with Emotion.\r\nThis
PR does not include any changes that would be noticeable
by\r\nend-users. It changes the internals to use a different technology
for\r\nstyling components.\r\n\r\n~~Some `className` attributes have
been kept, because they are\r\nreferenced in JS and tests.~~ Update: all
classNames that are no longer\r\nneeded for styling purposes have been
removed.\r\n* If the className was needed for tests, it has been
replaced with a\r\ntest-subj.\r\n* If the className was used as a
selector in production code, it has\r\nbeen replaced with alternative
JS.\r\n\r\n## References\r\n1. https://emotion.sh/docs/globals\r\n2.
https://emotion.sh/docs/best-practices\r\n3.\r\nhttps://github.com/elastic/eui/discussions/6828#discussioncomment-10825360\r\n\r\n---------\r\n\r\nCo-authored-by:
Jatin Kathuria
<jatin.kathuria@elastic.co>","sha":"d86896bac0bbc5ed48b43e695e0a73c55b21450c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-minor"],"number":199885,"url":"https://github.com/elastic/kibana/pull/199885","mergeCommit":{"message":"[SharedUX]
Replace Sass with Emotion, Round 1 (#199885)\n\n## Summary\r\n\r\nPart
of https://github.com/elastic/kibana-team/issues/1082\r\n\r\nSelects
certain Sass files to replace with styles declared with Emotion.\r\nThis
PR does not include any changes that would be noticeable
by\r\nend-users. It changes the internals to use a different technology
for\r\nstyling components.\r\n\r\n~~Some `className` attributes have
been kept, because they are\r\nreferenced in JS and tests.~~ Update: all
classNames that are no longer\r\nneeded for styling purposes have been
removed.\r\n* If the className was needed for tests, it has been
replaced with a\r\ntest-subj.\r\n* If the className was used as a
selector in production code, it has\r\nbeen replaced with alternative
JS.\r\n\r\n## References\r\n1. https://emotion.sh/docs/globals\r\n2.
https://emotion.sh/docs/best-practices\r\n3.\r\nhttps://github.com/elastic/eui/discussions/6828#discussioncomment-10825360\r\n\r\n---------\r\n\r\nCo-authored-by:
Jatin Kathuria
<jatin.kathuria@elastic.co>","sha":"d86896bac0bbc5ed48b43e695e0a73c55b21450c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199885","number":199885,"mergeCommit":{"message":"[SharedUX]
Replace Sass with Emotion, Round 1 (#199885)\n\n## Summary\r\n\r\nPart
of https://github.com/elastic/kibana-team/issues/1082\r\n\r\nSelects
certain Sass files to replace with styles declared with Emotion.\r\nThis
PR does not include any changes that would be noticeable
by\r\nend-users. It changes the internals to use a different technology
for\r\nstyling components.\r\n\r\n~~Some `className` attributes have
been kept, because they are\r\nreferenced in JS and tests.~~ Update: all
classNames that are no longer\r\nneeded for styling purposes have been
removed.\r\n* If the className was needed for tests, it has been
replaced with a\r\ntest-subj.\r\n* If the className was used as a
selector in production code, it has\r\nbeen replaced with alternative
JS.\r\n\r\n## References\r\n1. https://emotion.sh/docs/globals\r\n2.
https://emotion.sh/docs/best-practices\r\n3.\r\nhttps://github.com/elastic/eui/discussions/6828#discussioncomment-10825360\r\n\r\n---------\r\n\r\nCo-authored-by:
Jatin Kathuria
<jatin.kathuria@elastic.co>","sha":"d86896bac0bbc5ed48b43e695e0a73c55b21450c"}}]}]
BACKPORT-->
2024-12-09 13:16:24 +01:00
Nick Partridge
2b344d2797
[FTR] Update getAttribute method return (#179715) 2024-04-10 10:28:03 -07:00
Maja Grubic
a7293f62b5
[Custom Branding] Add custom branding settings to Global settings (#150080)
## Summary

This PR registers custom branding settings from the `custom_branding`
plugin. Once registered, these settings can be viewed under "Global
settings".

UI changes:
<img width="1761" alt="Screenshot 2023-02-06 at 19 59 19"
src="https://user-images.githubusercontent.com/1937956/217060900-7e56c8e9-7d3d-4ac5-96b6-8a8a85d3c1c3.png">

I also removed the client-side version of the `custom_branding` plugin,
as it's not needed.

With this change, it became easier to test custom branding, so I made a
few changes where logo was not showing properly or image size was wrong
or test subjects were missing.

I am working with @gchaps on the exact wording, so that might change. 

### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [X] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
~- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
- [X] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [X] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>
2023-02-16 08:13:42 +01:00