- Errors on the application level were not correctly surfaced in the UI. This PR fixes it by combining "transport" stream errors and application errors in a callout above the analysis results table.
- This also fixes the problem where a partly populated results table would turn empty again when used with the error prop of EUI's table. We now keep the table on display an show the errors above it in the callout.
(cherry picked from commit 70efbf0ea3)
Co-authored-by: Walter Rafelsberger <walter@elastic.co>
* Fix Unable to open user detail pages when user names conflict with tabs
* Fix Unable to open host detail pages when host names conflict with tabs
* Preserve tab name on user and host compatibility redirect
(cherry picked from commit 4c690bb3a2)
Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
## Summary
Improves timeline removal functional test for bulk edit, by setting default timeline properties for rule, that being tested
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
(cherry picked from commit fc4a49532f)
Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
* Fix API integration tile copy
* DRY out new index steps
(cherry picked from commit 9c36b9ac20)
Co-authored-by: Byron Hulcher <byron.hulcher@elastic.co>
* Add new terms rule type ID for telemetry
* Add new_terms in more places, update tests
* Add new_terms to collector
(cherry picked from commit c4407569cd)
Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>
* Remove view rule details link in rule details page
* Renaming and bringing back eslint comment
* Rename id to pageId
* Add missing id in AlertsTableFlyoutBaseProps interface
* Fixing the types to match reality. Not everything is string[]
* Splitting ObservabilityActions from table t-grid; adding tests for AlertsFlyoutBody and ObservabilityActions
* Fixing more mappings
* removing unnecessary reduce
* Changing to unknown type instead of listing all the possible options to match the ES Typescript interface.
* reverting all the type changes
* reverting all the type changes
* Forcing the fixture data to be TimelineNonEcsData[]
* Aliasing id to pageId
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Chris Cowan <chris@elastic.co>
(cherry picked from commit 7f46fde188)
Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
* fix has data
* clean up remote cluster comment
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit e2b85258bf)
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
This fixes an issue with the CI stats plugin using `tapAsync` instead of
`tapPromise`. It appears that if callback() is not called in
`tapAsync`, the entrypoint is not written to disk.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit af58ee866d)
Co-authored-by: Jonathan Budzenski <jon@elastic.co>
* add valid signature test package
* add test signatures and readme for signature generation
* mount zip packages as part of tests
* amend README
* Verified package test working
* Rename valid to verified
* Add test for unverified content
* add test for package verified with wrong key
* Check error types in 400 response
* Check saved object keys as part of tests
* Remove wrong_ keys
* use release docker image
* update package path for v2 registry
* force install endpoint package
* fix package policy upgrade on setup test
* formatting
* move back to production registry
* Update all registry configs to use new package directory
* use specific docker image not tag
* fix agent policy tests
* Get latest experimental endpoint version
* skip impossible fleet test
* update synthetics to use same registry image as fleet
* fix telemetry tests
* remove experimental flag from test config
* add force install confirm to synthetics tests
* add origin to expected policy data
* add test subj to force install modal
* Install latest fleet_server package not fixed version
* install latest system pkg
* fix types
* fix deprecated API calls
(cherry picked from commit 9f8a2c603d)
# Conflicts:
# x-pack/test/fleet_api_integration/config.ts
# x-pack/test/functional_synthetics/config.js
* Adds base FE implementation for documents list
* Add backend for pagination.
* Add tests
* Use pagination instead of meta
* Use 0 indexed pagination
* Fix axe error
(cherry picked from commit e3760c580a)
Co-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co>
* Additional hooks for checking if content is being displayed in full screen mode
* Add css adjustments to PageOverlay for when it is displayed over full screen content
* new security solution top level stylesheet with overrides for full screen content
* PageOverlay: Ensure that flyouts are displayed correctly in full screen mode
* move css class
(cherry picked from commit 8231e0f47f)
Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
* fix query suggestions, add and comment in tests
* test commenting out failing test
* comment out the tooltip test for now
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 73702ee857)
Co-authored-by: Sandra G <neptunian@users.noreply.github.com>
Since the UI can get quite cluttered with some insight accordions greyed out and some not, we decided (with the design team) to remove the dedicated empty space for now.
(cherry picked from commit 041bd90826)
Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
- Fixes API messages and loading state to always finish with 100% except when a user cancels the request.
- Fix to never apply loading={true} to the analysis table because it disables hovering events. To indicate loading we have the overall progress bar anyway.
- When the analysis returns no results, instead of an empty table and just the "no data" message, this now hides the table and displays an EuiEmptyPrompt.
(cherry picked from commit cd7578a26e)
Co-authored-by: Walter Rafelsberger <walter@elastic.co>
This enables quick checks of malware signatures for the new vulnerable driver protection we're shipping in 8.4
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4e853e028d)
Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
* Use more correct ids from alerts for entity request, clean up some tests
* Fix cypress tests
* Remove cypress config change
* Update failing cypress tests, address pr comment
* Address pr comment in reality
* Update cypress data to work with analyzer api
* Update alert count in rule tests
* Delete commented code
(cherry picked from commit 2a4c473fdb)
Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
## Summary
`savedObjectClient.bulkUpdate` method uses ES _bulk API with `update` action, which doesn’t allow to delete fields from Saved Objects(SO), i.e. overwrite them with undefined
https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html
Instead, in this PR it replaced by `savedObjectClient.bulkCreate` with `overwrite=true`, that allows to remove existing fields by complete overwrite of SOs. It results in _bulk API query `index` action
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
(cherry picked from commit ff062cea07)
Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
* Add metricbeat erros to Health API response
* Fix unit test
* Add integration test scenario
* Small fix
* Small fixes and improving integration test data
* Small refactor of fetchMetricbeatErrors
* Add logging
* Unload metricbeat archive after test finishes up
* Fix data_stream setup function
* Remove manual metricbeat data stream deletion in test teardown in favor of archiver unload
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 62ce378b25)
Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
* [Security Solution] Fix issue where Endpoint list page crashes on missing Policy Id
* pr comments
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b8aaf561da)
Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com>
* Remove cases props and try to get it directly inside of the components by passing casesFeatureId instead
* add cases to apm
* fix unit test
* skip test until we are bringingt them back without adding dependency in trigger action UI
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit fb49ff39b1)
Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
