Commit graph

827 commits

Author SHA1 Message Date
Constance
fa3a62e5a5
Upgrade EUI to v67.1.9 (#145490)
## Summary
`eui@67.1.8`  `eui@67.1.9`

This backport fixes bugs affecting Maps that were found in the latest
EUI upgrade
(https://github.com/elastic/kibana/pull/144845#issuecomment-1317653081).
It is meant to go directly into 8.6

## [`67.1.9`](https://github.com/elastic/eui/tree/v67.1.9)

- `EuiButton` now accepts `minWidth={false}`
([#6373](https://github.com/elastic/eui/pull/6373))

**Bug fixes**

- Fixed the shadow sizes of `.eui-yScrollWithShadows` and
`.eui-xScrollWithShadows`
([#6374](https://github.com/elastic/eui/pull/6374))
- `EuiButton` no longer outputs unnecessary inline styles for
`minWidth={0}` or `minWidth={false}`
([#6373](https://github.com/elastic/eui/pull/6373))
- `EuiFacetButton` no longer reports type issues when passing props
accepted by `EuiButton`
([#6373](https://github.com/elastic/eui/pull/6373))

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-11-17 14:53:30 -08:00
Sébastien Loix
a67776b365
[TableListView] Enhance tag filtering (#142108) 2022-11-14 14:25:19 -07:00
Nathan Reese
49f3c24428
[Maps] enable allowJs (#144742)
Fixes https://github.com/elastic/kibana/issues/144287

PR resolves TS errors when setting allowJs to true in Maps plugin

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-11-09 09:50:46 -07:00
Bree Hall
4e9f1c0d04
Bumping EUI to version 67.1.8 (#141279)
* Updated EUI to version 67.1.2. Updated instaces of ButtonColor from EUI to EuiButtonColor.

* Updated to EuiCard instances that utilize the betaBadgeProps object to return an empty string instead of undefined when the label is unavailable

* Removed two instances of the deprecated internetExplorerOnly() mixin

* Updated two instances of the ButtonColor import to EuiButtonColor as is was renamed in PR #6150

* Updated snapshots in Jest Test Suite #1 to account for EuiButton and EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiToolTipAnchor component that replaced the tooltip anchor styles

* Updated snapshots in Jest Test Suite #2 to account forEuiButton, EuiDescriptionList, EuiButtonIcon, and EuiBadge Emotion conversions.

* Updated snapshots in Jest Test Suite #3 to account for EuiDescriptionList, EuiButton, and EuiBadge Emotion conversions. Updated snapshots for EuiTooltip as if now contains the new EuiTooltipAnchor component that replaced the tooltop anchor styles

* Updated snapshots in Jest Test Suite #4 to account for EuiButton Emotion conversion.

* Updated snapshots in Jest Test Suite #5 to account for EuiButton Emotion conversion.

* Updated snapshots in Jest Test Suite #8 to account for EuiButtonIcon and EuiButton Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.

* Updated snapshots in Jest Test Suite #9 to account for EuiFlyout and EuiButton Emotion conversions.

* Updated snapshots in Jest Test Suite #10 to account for EuiButton, EuiBadge, EuiButtonIcon, and EuiCard Emotion conversions. Updated snapshots for EuiToolTtip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles

* Updated instances of EuiButtonIconColor to use EuiButtonIconProps['color'] as it was removed in PR #6150

* Updated tests that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors

* Updated snapshots in Jest Test Suite #1 to account for EuiButton and EuiCard Emotion conversions

* Added the EuiFlyout mixins and variables to Lens Sass file as EuiFlyout has been converted to Emotion and the Sass styles are no longer available in EUI

* Added the EuiCallOutTypes variable to Step Progress Sass file as EuiCallOut has been converted to Emotion and the Sass styles are no longer available in EUI

* Updated snapshots in Jest Test Suite #2 to account for recent Emotion conversions.
Updated snapshots in server_status.test.tsx to render EuiBadge before checking the snapshots to reduce the snapshot churn caused by Emotion.
Updated tests that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Added imports for the added flyout mixin. Removed references to EuiCallOut mixin as the component has been converted to Emotion and is no longer available for use.

* Updated unit tests and snapshots in Jest Test Suite #10.
Updated snaphshots to account for EuiBadge, EuiDescriptionList, EuiFlyout, and EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.
Updated tests that target EuiButton to simulate click events to target a generic button element to prevent undefined click event errors

* Updated unit tests in Jest Test Suite #11 that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors

* Updated unit tests in Jest Test Suite #12 by updating tests that target EuiButton to simulate click events. Instead, these tests now target a generic button element to prevent undefined click event errors

* Updated unit tests in Jest Test Suite #1 by updating tests that target EuiButton to simulate click events. Instead, these tests now target a generic button element to prevent undefined click event errors

* Updated unit tests in Jest Test Suite #2 by updating tests that use EuiButton to simulate click events. Instead, these test have been updated to target a button element to prevent undefined click event errors.

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Updated reference to mixins Sass file.
Updated snapshots for Jest Test Suite #5 to account for EuiButton Emotion conversion. Updated unit tests that target EuiButton to simulate click events. These tests have been updated to target a button element to prevent undefined click event errors

* Updated unit tests in Jest Test Suites 3, 7, 8, 13, and 14.
Updated snapshot to account for EuiButton Emotion conversion.
Updated tests that target EuiButton to simulate click events. These tests now target a generic button element to prevent undefined click event errors.
Updated a few snapshots by adding .render() before checking the snapshot. This will prevent large snapshots coming from recent Emotion conversions

* Updated snapshots in Jest Test Suite #10 to account for the recent EuiButton Emotion conversion

* Updated unit tests in Jest Test Suite #2 by editing tests that target EuiButton to simulate click events. These tests now target a button element in order to prevent undefinde click event errors

* Updated snapshots in Jest Test Suite #10 to account for EuiButton and EuiDescriptionList Emotion conversions

* Updated test cases in Jest Test Suites 3, 7, and 8. Updated snapshots to account for EuiButton and EuiPagination Emotion conversions.
Updated tests that target EuiButton to simulate click events. These tests now target a button element to prevent undefined click errors

* Updated test cases in Jest Test Suite 14. Updated snapshots to account for EuiButton Emotion conversion. Opted to use .render() when updating a few snapshots to reduce the large length of snapshots caused by Emotion

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Revised a change to betaBadgeProps to ensure that the label is available. If not, the value for the badge with be set to undefined.

* Resolved two linting errors

* Resolved two linting errors

* Updated Jest unit tests in various suites.
Updated snapshots to account for EuiButton Emotion conversion. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.

* Updated EuiFlyout in query_flyout.tsx to remove the onClick function from maskProps as it is no longer available. Updated this flyout to use ownFocus and not to close when the overlay mask is clicked.

* Removed the use of EuiButtonIconColor in favor of EuiButtonIconProps['color']

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Updated Cypress test looking for strict equality on EuiPaginationButton class names to match a substring of the Emotion generated class name

* Removed unneeded debugging code. Updated snapshots for various test suites to account for the recent EuiButton Emotion conversion

* Updated a few EuiButton, EuiButtonEmpty, and EuiText components that set the color as ghost. The ghost color mode has been deprecated as of PR #6150. These components now are wrapped in EuiThemeProvider with a dark colorMode to create the previous ghost color.

* Resolved  TS error with EuiCard betaBadgeProps

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Remove references to now-removed EuiFlyout CSS classes/vars

* Remove now-removed euiBadge className references

- Convert directly to EuiBadge instead of using CSS

- Remove confusing and now-possibly-irrelevant CSS badge overrides - left/right icons are now set via JSX and not via flex-direction

* Pre-emptively fix various euiOverlayMask CSS overrides

- this data attr isn't technically in yet but will be once https://github.com/elastic/eui/pull/6289 merges

- at the very least this isn't breaking any more than it currently already is!

* Update to v67.1.3

* v67.1.4

* Resolved test failing test case in Security/Manage/Blocklist. The test did not remove focus from the last combo box in the form, which didn't allow the disbaled attribute to be removed from the flyout submit button. I've updated the mock file for Blocklist to return focus to the first form element in the flyout to allow the disabled attribute to be removed.

* Updated snapshots to account for the recent EuiText Emotion conversion

* Fix Log's custom tooltips relying on EuiTooltip classNames that no longer exist

* Fix Vega vis custom tooltips relying on EuiTooltip classNames that no longer exist

- this one is trickier than Log's as it's not using React, so we need to use Emotion's Global to set a static className

* Convert remaining vega_vis.scss to Emotion

- as an example of how other global + non global styles could be handled in the future

* Fix references to removed `euiPaginationButton-isActive` className

- use aria-current attribute instead

* Added missing EuiFlyoutAnimation keyframes for EuiFlyout. This resolved test that failed because they used onAnimationEnd because the FlyoutAnimation could not be found.

* Reolved Jest Tests in suites 1 and 5. Updated snapshots to account for the recent EuiButton Emotion conversion. Updated snapshots for EuiToolTip as it now contains the new EuiToolTipAnchor component that replaced the tooltip anchor styles.

* iterate on rules_list.test.tsx

* bump eui to v67.1.5

* Updatde snapshots for jest test suites to account for the recent EuiButton, EuiOverlayMask, EuiTooltip, and EuiBadge Emotion conversions

* Resolved failing security test by updating the target element for CONNECTOR_TITLE. EuiCard has recently been converted to Emotion and the card title is no longer wrapper in a span.

* Resolved failing test case in Runtime Fields. The modify runtime field test was failing because the combobox responsbible for adding and updating scripts was not appearing. The textbox did not appear because the shared setFieldScript function targets and toggles the script textbox when opening the flyout. When a runtime field is being modified, the toggle is already active and using the shared function will trigger the toggle again (losing access to the script textbox).
Also resolved an issue that prevented the warning EuiCallout to appear when changing the type of a runtime field from its original type. Resolved this by adding an enter keypress at the end of setFieldType function to confirm the type selection, thus triggering the EuiCallout

* Resolved two tests that were failing in Lens. These test were failing because they were checking for equality in class names that no longer exist within EuiButtonGroup as it was recently converted to Emotion. These tests were updated to check for a substring of the new and longer class name

* Quick fix in test case failing because of misspelling in data-test-sub

* Updated snapshot for Jest test case as EuiButton as recently been converted to Emotion

* Removed console.log statement. Oops!

* Resolved a failing test case in Lens. They were failing because they were checking for equality in class names that no longer exist within EuiButtonGroup as it was recently converted to Emotion. These tests were updated to check for a substring of the new and longer class name.
Updated a Security test case by giving a target button the data-test-subj attribute for easier querying

* Removed reference to EuiFlyout mixin as it has been converted to Emotion. Updated the reference to an interal copy of EuiFlyout styles

* Corrected spelling error in EuiFlyout animation in Lens app

* Update EUI with latest backport

* Update button snapshots

* fix another button snapshot

* More snapshot fixes

* [EuiButton][Security] Fix button relying on now-removed `euiButton__text` CSS

- replace removed CSS with `eui-textTruncate` util instead

- combine/DRY out unnecessary span - was affecting min-width of truncation util

+ increase screenshot diff limit - this was smaller than updating the actual baseline screenshots for whatever reason (likely render diff between local and CI)

* Fix remaining Jest tests affected by Emotion conversions

- because Emotion creates its own wrapper, `.first()` can no longer be used - prefer `.last()` instead

* Fix Jest test affected by EuiButton Emotion conversion + removed modifier class

- targeting the native DOM node + filtering by disabled true/false gets us back to the 'correct' lengths

* Fix + improve flyout test

- `.last()` changes to account for EuiButton Emotion conversion is needed, but the last onClose assertion still fails due to us having modified inputs, and the confirm modal being displayed

- split test into two separate tests - one testing the onClose call, and the other testing the confirm modal

* derpin

* Skip rules_list Jest suite

* Update new EuiButton snapshot

* Upgraded EUI version to 67.1.7

* [EuiCard] Update snapshots

* [EuiPopover] Update snapshots

* [QA] Fix missing Vega warn/error message colors

;_;

* [CI] Auto-commit changed files from 'node scripts/generate codeowners'

* Fix Lens kbnToolbarButton regressions

- Caused by flattening of EUI button CSS specificity

- background-color was previously relying on isDisabled CSS specificity to override its #fff color

- `text` color modifier & `!important` is no longer needed and overrides Emotion CSS flatly

- isDisabled class is no longer needed - euiButton no longer sets `pointer-events: none` on disabled buttons (fixes tooltip bug in webkit as well)

* Backport EUI 67.1.8 fixes

* Update EuiCard snapshots

* Fix EuiModal form wrapper causing overflow issues

- see https://elastic.github.io/eui/#/layout/modal#forms-in-a-modal

* Workaround for `.kbnOverlayMountWrapper` mount point causing overflow issues

- not sure what all is using this modal service to be honest, but the wrapper is causing issues with the modal layout, this fixes overflow issues but will not fix any mask-image issues as a result

* more snapshot updates

* EuiButton - added textProps to EuiButton to prevent very long button names from spilling over outside of the container

* EuiButton - Update EuiButton related snapshots. Updated tests that target EuiButton directly to use a data-telementary-id for more specific element querying required by Emotion

* QA - Removed unnecessary comment in code

* Temporary fix for EuiCard[selectable][layout=horizontal] instances on security solutions' rule page

* Temporary fix for EuiCard[selectable][layout=horizontal] instances on osquery live query and canvas's datasource selector

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Fix CSS specificity, where canvas's solutionToolbarButton's background-color now takes precedence over EuiButton's primary styles

* Removed update to search_marker_tooltip that removed the euiTooltip styles and replaced then with Emotion styling. Added EuiTooltip Sass styles for the component to rely on to test for a styling bug that is causing the tooltip and the tooltip arrow to be out of sync with each other.

* Lint Sass file

* Lint Sass file

* Removed overflow:hidden style from .vgaVis_view as it was causing euiScrollStyles not to present the scroll bars in Vega Vis

* Remove typo from EuiButton textProps object. 'className' should not have been included in the actual class name

* Revert tooltip Sass

This reverts commit 20e6ead571, a5cd2de901, and c605cbd7b9

* Fix Emotion tooltip arrows

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance Chen <constance.chen@elastic.co>
Co-authored-by: Chandler Prall <chandler.prall@elastic.co>
2022-11-07 21:45:50 +00:00
Nathan Reese
adfa8f7ddd
[Maps] add ungroup layers action (#144574)
* [Maps] add ungroup layers action

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* tslint

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-11-07 11:47:05 -07:00
Nathan Reese
8ea2f3b715
[Maps] add in product help for layer group drag and drop instructions (#144259)
* [Maps] add in product help for layer group drag and drop instructions

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* render callout above panel

* review feedback on copy

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Update x-pack/plugins/maps/public/connected_components/edit_layer_panel/layer_settings/layer_settings.tsx

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update x-pack/plugins/maps/public/connected_components/edit_layer_panel/layer_settings/layer_settings.tsx

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update x-pack/plugins/maps/public/connected_components/edit_layer_panel/layer_settings/layer_settings.tsx

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* update title

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2022-11-02 10:04:21 -06:00
Sean Sullivan
ed97fa3e9d
Add legends to custom map layers and convert wms_source to typescript (#143321)
* Add legends to custom map layers and convert wms_source to typescript

Co-authored-by: Sean Sullivan <ssullivan@spectric.com>
Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
2022-11-01 13:18:16 -07:00
Nathan Reese
55959f3531
[Maps] layer group wizard (#144129)
* [Maps] layer group wizard

* create editor

* open parent layer details on adding child

* show combining highlight instead of selected layer highlight

* do not delete layers added to preview layer group

* reuse settingsPanel.layerNameLabel tag so label is consistent in edit panel

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* checks fix

* layer group description copy update

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-10-31 13:20:20 -06:00
Nathan Reese
a21ed37a4c
[Maps] nest security layers in layer group (#144055)
* [Maps] nest security layers in layer group

* update security layers

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-10-27 09:19:01 -06:00
Nathan Reese
cf8e6a7eaa
[Maps] highlight combine layer background when creating layer group (#143909)
* [Maps] highlight combine layer background when creating layer group

* tslint fixes

* eslint fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-10-26 09:10:21 -06:00
Nick Peihl
80a49fea20
Report telemetry for WebGL support (#143989) 2022-10-26 09:52:05 -04:00
Nathan Reese
0c1ae8c1c2
[maps] fix layer group showAtZoomLevel issue (#143958)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-10-26 07:31:12 -06:00
Nathan Reese
ee326591a3
[Maps] Add ability to invert color ramp and size (#143307)
* convert color forms to TS

* switch for setting invert

* reverse colors

* convert size components to TS

* invert size switch

* invert mb size expression

* invert size legend

* invert ordinal legend

* invert colors in color picker

* update jest snapshot

* add unit tests for inverting color ramp creation

* review feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-10-24 15:10:42 -06:00
Nick Peihl
1dda579927
[Maps] Remove deprecated usage of indexPattern.title (#143444)
* Remove deprecated usage of indexPattern.title

* Fix mocks in unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-10-24 06:30:52 -07:00
Nathan Reese
e45170e50a
[Maps] layer groups (#142528)
* [Maps] layer groups

* createLayerGroup

* create layer group

* setChildren

* display layer group legend

* display nested layers in TOC

* setLayerVisibility

* set parent on layer re-order

* LayerGroup.getBounds

* clean-up LayerGroup

* edit layer panel

* LayerGroup.cloneDescriptor

* clean up

* remove layer

* fix reorder bug

* move children on layer move

* fix re-order bug when dragging layer group with collapsed details

* add check for dragging to same location

* add logic to prevent dragging layer group into its own family tree

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* add layer to layer group combine action with layer group

* clean up

* fix bug where unable to move layer to bottom

* mouse cursor styles

* clean up combine styling

* fix jest tests

* update toc_entry_actions_popover snapshots

* click confirm model on removeLayer in functional tests

* update cloneLayer to move clones beneath parent

* LayerGroup.getErrors

* Update x-pack/plugins/maps/common/descriptor_types/layer_descriptor_types.ts

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>

* fix show this layer only action when layer is nested

* recursive count children for remove layer warning

* Update x-pack/plugins/maps/public/components/remove_layer_confirm_modal.tsx

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* resolve error with show this layer only on layer group

* update remove statement to support plural

* perserve layer order when cloning layer group

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2022-10-13 10:23:43 -06:00
Nick Peihl
fc8407d222
Fix custom raster developer example (#142664) 2022-10-04 14:18:58 -07:00
Sean Sullivan
e50b5eb6da
Allow custom sources to have control over data sync (#141829) 2022-10-01 20:50:13 +09:30
Nathan Reese
cc9f1c6409
[Maps] fix Go To - lat/long values outside expected range cause blank Maps app (#141873)
* [Maps] fix Go To - lat/long values outside expected range cause blank Maps app

* UTM form

* wire UTM form

* add unit tests

* fix test names

* fix expects

* fix functional tests

* review feedback
2022-09-27 17:53:37 -06:00
Nathan Reese
fbf343a4e9
[Maps] hide/show all layers (#141495)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-09-26 12:17:59 -06:00
Nick Peihl
333548e8a5
[Maps] Track map embeddable usage with ui counters (#140994)
* Track map embeddable usage with ui counters

* Change subscription to pipe(first())

The rxjs .toPromise() method is deprecated and the lastValueFrom function is the suggested replacement.

* review feedback
2022-09-20 12:02:03 -07:00
Nathan Reese
3e73558f13
[Maps] adhoc data view support (#140858)
* [Maps] adhoc data view support

* enable adhoc data views from discover to maps

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* more discover cleanup

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* do not add adhoc data views to references

* migrated DataViewSpec persisted state

* add dataViewSpec to locator state

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-09-20 09:25:22 -06:00
Sébastien Loix
189196181c
[Table list view] Improve UX (phase 1) (#135892) 2022-09-19 12:29:23 +02:00
Nick Peihl
33ff3538b8
[Maps] Add UI counters for triggers that open a new map (#136991)
* Add UI counters for triggers that open a new map
2022-09-15 09:54:18 -07:00
Dmitry Tomashevich
52131666da
[Discover] Introduce adhoc Data Views (#138283)
* [Discover] add first steps for hoc data views

* [Discover] add confirm prompt when needed

* [Discover] fix types

* [Discover] fix tests

* [Discover] fix remaining tests

* [Discover] fix some comments

* [Discover] refactor, fix some bugs

* [Discover] add functional tests

* [Discover] improve tests

* [Discover] fix test

* [Discover] add saved data view toast

* [Discover] fix unit tests

* [Discover] fix remaining tests

* [Discover] resolve comments

* [Discover] generate new id on saving search copy, add functionals, fix data view picker

* [Discover] fix bug with top nav actions

* [Discover] enable stats for adhocs

* [Discover] fix lint

* [Discover] remove duplications

* [Discover] clean up changes

* [Discover] enable sql view, fix functional test

* [Discover] fix sql view for adHocDataViews, update savedSearch on data view save, apply suggestions

* Update src/plugins/discover/public/hooks/show_confirm_panel.tsx

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* [Discover] fix navigate to lens

* [Discover] add functional to test dashboard

* [Discover] fix types

* [Discover] fix maps visualization

* [Discover] fix checks

* [Discover] fix fields drag and drop

* [Discover] fix checks

* [Discover] remove logs

* [Lens] apply suggestions

* [Discover] add ignoreFetchState flag

* [Discover] improve nav link issue solution

* [Discover] fix type checks

* [Discover] allow multiple adhoc data views

* [Discover] use light spec for vis action payload

* [Discover] fix check types

* Improve URL tracking
- URL are no longer tracked for AdHoc data views

* Fix unit tests

* [Discover] apply suggestions

* [Discover] add unit test

* [Discover] add another test

* [Discover] fix bug with name

* [Discover] add remaining things

* [Discover] fix unit tests

* [Discover] fix error on refresh lens with adhoc created from discover

* [Discover] revert adhoc data views in sql mode

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
2022-09-14 16:06:09 +03:00
Nathan Reese
fecb6b30be
[Maps] fix percentile aggregation not working with vector tiles (#140318)
* [Maps] fix percentile aggregation not working with vector tiles

* better test names

* fix jest test

* review feedback

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-09-12 09:52:45 -06:00
Nathan Reese
705a21f259
[Maps] fix cluster layer disappears when switching from resolution 'high' to resolution 'low' (#140333) 2022-09-09 06:49:41 -06:00
Nathan Reese
ddcae9cfcf
[Controls] timeslider control (#139228)
* Timeslider plugin boilerplate

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* Spacetime timeslider dash (#138553)

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* push timeslice to Dashboard input

* Wire up timeslice (#138570)

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* push timeslice to Dashboard input

* cleanup

* Spacetime timeslider dash (#138573)

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* push timeslice to Dashboard input

* cleanup

* play button

* Notify control group when all panels loaded (#138674)

* get play button working

* play button (#138681)

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* push timeslice to Dashboard input

* cleanup

* play button

* get play button working

* cleanup

* clean up

* clean up wrap logic

* Spacetime timeslider dash -clean up wrap logic (#138822)

* wire redux store

* add time range bounds to store

* range control

* set value in store

* previous next buttons

* push timeslice to Dashboard input

* cleanup

* play button

* get play button working

* cleanup

* clean up wrap logic

* Add waitForPanelsToLoad$ observable (#138950)

* fix import

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* sync range slider width on popover panel resize

* fix styling

* update embeddables to support time slice

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* change file structure

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* disable add button when control group contains timeslider

* hide edit button for timeslider control

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* force timeslider width to be large

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* use timeslice to filter other controls

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* skip timeslider control in control chaining

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* cleanup

* fix initial timeRange

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* clear button

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* render prepend

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* remove unused code

* Container.getAnyChildOutputChange$

* play observable

* tslint

* tslint

* clean up

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* fix lint

* fix import

* fix plugin size and other clean up

* fix 'unsaved changes' issue

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* fix Dragging UI Nit

* fix Label position Above Nit

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* support relative time ranges

* fix issue where clear not propogated to panels

* time slider functional test

* clean up functional test

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* tslint

* fix time_slider functional test

* fix time slider not expanding after creating non-expanding control

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2022-09-07 11:21:53 -06:00
Nick Peihl
a0b506e2dc
[Maps] Add UI counters for custom icons (#139240)
* Add UI counters for custom icons

* Only report events when adding a new custom icon, not when editing an existing icon

* Fix jest test
2022-08-23 06:16:44 -07:00
Nick Peihl
c5de0a9ff9
[Maps] Add ability to disable tooltips for layer (#138275)
* Add ability to disable tooltips for layer

* Disable Show tooltips switch when no tooltip fields are available

* Typo

* Review feedback

* Fix loop termination
2022-08-23 06:08:59 -07:00
Nathan Reese
7be8ae67f9
[Maps] fix legacy tile_map and region_map visualizations do not display title in Map embeddable action modals (#139054)
* [Maps] fix legacy tile_map and region_map visualizations do not display title in Map embeddable action modals

* pass title to embeddable

* eslint

* tslint

* clean up
2022-08-18 15:54:39 -06:00
Nathan Reese
3de69b6b89
[Maps] fix scaling and term join in product help popover width (#139120) 2022-08-18 15:36:25 -06:00
Spencer
9003353729
rename @elastic/* packages to @kbn/* (#138957)
* rename @elastic/* packages to @kbn/*

* update yarn.lock

* [CI] Auto-commit changed files from 'node scripts/generate packages_build_manifest'

* update lint task

* review feedback

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-08-18 08:54:42 -07:00
Nathan Reese
477bba2d05
[Maps] support Vector tile runtime geo_point fields (#139047)
* [Maps] support Vector tile runtime geo_point fields

* i18n cleanup
2022-08-18 09:03:41 -06:00
Nathan Reese
f46a6309bd
[Maps] show data view name in UI (#138928)
* [Maps] show data view name in UI

* remove indexPatternTitle from join descriptor

* clean up

* i18n clean-up

* fix jest test

* jest test fix
2022-08-18 07:36:24 -06:00
Alexey Antonov
5f84d8e071
[Lens] Move custom chart icons into lens package (#138413)
* [Lens] Move custom chart icons into lens package (#138101)

* [Lens] Move custom chart icons into lens package

Closes #135230

* add storybook

* fix merge conflicts

* [CI] Auto-commit changed files from 'node scripts/generate packages_build_manifest'

* clenaup

* add region_map icon into package

* fix styles

* Update README.md

* fix ci

* try to fix CI

* fix PR comments

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* RegionMap -> LensIconRegionMap

* lensIcons -> lens_icons

* move to x-pack packages

* [CI] Auto-commit changed files from 'node scripts/generate packages_build_manifest'

* move to x-pack/packages/lens/icons

* fix jest

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

* fix CI

* use emotion lib

* remove lensAnnotationIconNoFill and lensAnnotationIconFill

* remove duplicated code

* cleanup

* [CI] Auto-commit changed files from 'node scripts/generate packages_build_manifest'

* cleanup

* renaming

* fix jest config

* remove extra icons

* move icons out of main chunk

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-08-17 13:24:18 +03:00
Nathan Reese
7303ef8991
[Maps] fix Filters applied to map visualization not preserved when added to dashboard (#138188)
* [Maps] fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed

* add min-width to mapFeatureTooltip__propertyLabel

* [Maps] fix Filters applied to map visualization not preserved when added to dashboard

* clean up

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* clean-up

* publish query and filter to container

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* fix checks

* tslint and add to bounds filter

* functional test

* review feedback

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-08-16 14:09:38 -06:00
Constance
7b11420ee9
Upgrade EUI to v62.0.3 (#138351)
* Upgrade to v62.0.3

* Update EUI i18n tokens

* Update html string snapshots

- Emotion CSS hash changed

* [EuiIcon] Update instances of `keyboardShortcut` icons to `keyboard`

* [EuiErrorBoundary] Update snapshots from Emotion conversion

* [EuiImage] Update snapshots, tests, and CSS to account for Emotion conversion

* [EuiImage][RTL] Fix test failures caused by EuiImage changes

* [EuiCommentList] Deprecate EuiCommentProps.type

* [EuiCommentList] Rename `timelineIcon` prop to `timelineAvatar`

- see https://github.com/elastic/eui/pull/6071

* [EuiCommentList] Fix selectors deprecated by Emotion conversion

* [EuiPopover][EuiCommentEvent][Enzyme] Fix mounted test failures caused by Emotion conversions

- Mounting displays the Emotion wrapper with the data-test-subj on them - we need to specify the output div renders in order for text assertions to be correct

* [EuiPopover] Deprecate `initialFocus={false}` as an option

see https://github.com/elastic/eui/pull/6044

* [EuiPopover] Rename `display=inlineBlock` to `inline-block`

- see https://github.com/elastic/eui/pull/5977

* [EuiPopover] Update snapshots from Emotion conversion

* [EuiPopover] Replace deprecated `.euiPopover__panel-isOpen` class with new `[data-popover-open]` attribute

* [EuiPopover][RTL] Fix test failures caused by not waiting for EuiPopover animation/transition

* Skip failing a11y tests

- test w/ similar error already skipped in another test above
- requires closing the popover for next test to pass
- not sure why delete action is no longer available

* Fix failing Security Cypress tests

* Attempt to squash flaky FTR tests around Add Filter popover

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jonathan Budzenski <jon@elastic.co>
2022-08-12 16:40:58 -07:00
Hannah Mudge
00c8cf9e56
[Dashboard] View panel-level filters and queries (#136655)
* Use panel action to show filters

* Switch over to a modal

* Fix how I'm getting data views

* Deserialize and clean filters for getFilters

* Read only filter items

* Fix render of filter pills

* Fix title for read only filter pills + clean up code

* Add i18n support + fix types

* Provide Kibana uiSettings to modal

* Fix how panel titles are grabbed for functional tests

* Add jest tests for badge

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Remove focus trap from modal

* Add edit button to modal that redirects to visualize app

* Add tooltip to filter pills

* Add jest tests for modal

* Clean up badge code and move to modal

* Make filter pills focusable

* Add tooltip to readOnly filter pills only

* Add `getFilters` to saved search embeddable

* Add query to filters modal

* Support by reference embeddables - specifically for visualize

* Fix jest tests for modal

* Add i18n support for new form in modal

* Clean up code

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Fix jest tests for badge

* Temporarily disable for maps and add TODO comment

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Fix styling of modal + i18n of aria label

* Fix bundle size

* Address first round of feedback

* Add comments to public APIs

* Export missing API

* Add comments to public dashboard API

* Fix imports, types, and add more comments

* Fix losing of context

* Add more public API comments

* Add comments to each embeddable/dashboard container

* Add more public API comments

* Fix losing of context for real this time

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Fix jest test

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Address feedback

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-08-10 11:36:49 -06:00
Nathan Reese
0f643045cf
[Maps] fix draw icons not displayed in buttons (#138433)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-08-09 13:59:38 -06:00
Jonathan Budzenski
b3a38c4137 Revert "[Lens] Move custom chart icons into lens package (#138101)"
This reverts commit d89b2cb903.
2022-08-09 09:30:44 -05:00
Alexey Antonov
d89b2cb903
[Lens] Move custom chart icons into lens package (#138101)
* [Lens] Move custom chart icons into lens package

Closes #135230

* add storybook

* fix merge conflicts

* [CI] Auto-commit changed files from 'node scripts/generate packages_build_manifest'

* clenaup

* add region_map icon into package

* fix styles

* Update README.md

* fix ci

* try to fix CI

* fix PR comments

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* RegionMap -> LensIconRegionMap

* lensIcons -> lens_icons

* move to x-pack packages

* [CI] Auto-commit changed files from 'node scripts/generate packages_build_manifest'

* move to x-pack/packages/lens/icons

* fix jest

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-08-09 17:15:12 +03:00
Nathan Reese
7cd4a860ef
[Maps] fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed (#138054)
* [Maps] fix Tool tip with large field list exceeds browser screen and cannot be accessed or dismissed

* add min-width to mapFeatureTooltip__propertyLabel
2022-08-05 08:19:13 -06:00
Nathan Reese
e21f41390e
[Maps] Cancel button when editing by value from dashboard (#137880) 2022-08-03 20:11:24 -06:00
Nathan Reese
71eac22b33
[Maps] set border width to zero for points only document layers (#137758)
* [Maps] set border width to zero for points only document layers

* top hits layer

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-08-03 09:47:57 -06:00
Liza Katz
af45ef831e
add flexible EBT Performance Metric Schema (#136395) 2022-08-03 15:21:24 +03:00
Nathan Reese
a4394a13c1
[maps] fix type in getMapsVisTypeAlias (#137014) 2022-08-01 12:43:11 -06:00
Nathan Reese
77fa5e7185
[Maps] fallback to GeoJSON with runtime geo_point field (#136675)
* [Maps] fallback to geojson with runtime geo_point field

* convert to TS

* update snapshots

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-08-01 10:47:48 -06:00
Stratoula Kalafateli
1d6312b15d
Check types (#137410)
* Check types

* Fix types in discover temporary
2022-07-28 19:52:13 +03:00
Nick Peihl
69dc7e2b77
[Maps] Custom raster source example plugin (#136761) 2022-07-26 14:41:45 -07:00
Nathan Reese
c9df45df56
[maps] fix "other" is always shown in legend for category styling rules (#137008)
* others

* other color picker

* custom color ramp other color

* ts lint

* always show others category with custom ramp

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* migration

* make custom color ramp value input larger

* fix failing tests

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* see mbExpression to other color when stops not available

* fix jest test

* fix bug where deleting row causes colors to not display in correct order

* prevent state continously changing

* fix with key instead of getDerivedStateFromProps

* add tooltip

* remove unused code

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-07-26 12:47:08 -06:00