## Summary
Fixes#145020
This PR adjusts typing for search source alert to handle no data views
state in flyout.
### Checklist
- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Updated EUI to version 67.1.2. Updated instaces of ButtonColor from EUI to EuiButtonColor.
* Updated to EuiCard instances that utilize the betaBadgeProps object to return an empty string instead of undefined when the label is unavailable
* Removed two instances of the deprecated internetExplorerOnly() mixin
* Updated two instances of the ButtonColor import to EuiButtonColor as is was renamed in PR #6150
* Updated snapshots in Jest Test Suite #1 to account for EuiButton and EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiToolTipAnchor component that replaced the tooltip anchor styles
* Updated snapshots in Jest Test Suite #2 to account forEuiButton, EuiDescriptionList, EuiButtonIcon, and EuiBadge Emotion conversions.
* Updated snapshots in Jest Test Suite #3 to account for EuiDescriptionList, EuiButton, and EuiBadge Emotion conversions. Updated snapshots for EuiTooltip as if now contains the new EuiTooltipAnchor component that replaced the tooltop anchor styles
* Updated snapshots in Jest Test Suite #4 to account for EuiButton Emotion conversion.
* Updated snapshots in Jest Test Suite #5 to account for EuiButton Emotion conversion.
* Updated snapshots in Jest Test Suite #8 to account for EuiButtonIcon and EuiButton Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.
* Updated snapshots in Jest Test Suite #9 to account for EuiFlyout and EuiButton Emotion conversions.
* Updated snapshots in Jest Test Suite #10 to account for EuiButton, EuiBadge, EuiButtonIcon, and EuiCard Emotion conversions. Updated snapshots for EuiToolTtip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles
* Updated instances of EuiButtonIconColor to use EuiButtonIconProps['color'] as it was removed in PR #6150
* Updated tests that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors
* Updated snapshots in Jest Test Suite #1 to account for EuiButton and EuiCard Emotion conversions
* Added the EuiFlyout mixins and variables to Lens Sass file as EuiFlyout has been converted to Emotion and the Sass styles are no longer available in EUI
* Added the EuiCallOutTypes variable to Step Progress Sass file as EuiCallOut has been converted to Emotion and the Sass styles are no longer available in EUI
* Updated snapshots in Jest Test Suite #2 to account for recent Emotion conversions.
Updated snapshots in server_status.test.tsx to render EuiBadge before checking the snapshots to reduce the snapshot churn caused by Emotion.
Updated tests that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors
* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
* Added imports for the added flyout mixin. Removed references to EuiCallOut mixin as the component has been converted to Emotion and is no longer available for use.
* Updated unit tests and snapshots in Jest Test Suite #10.
Updated snaphshots to account for EuiBadge, EuiDescriptionList, EuiFlyout, and EuiCard Emotion conversions. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.
Updated tests that target EuiButton to simulate click events to target a generic button element to prevent undefined click event errors
* Updated unit tests in Jest Test Suite #11 that target EuiButton to simulate click events to target a generic button to prevent undefined click event errors
* Updated unit tests in Jest Test Suite #12 by updating tests that target EuiButton to simulate click events. Instead, these tests now target a generic button element to prevent undefined click event errors
* Updated unit tests in Jest Test Suite #1 by updating tests that target EuiButton to simulate click events. Instead, these tests now target a generic button element to prevent undefined click event errors
* Updated unit tests in Jest Test Suite #2 by updating tests that use EuiButton to simulate click events. Instead, these test have been updated to target a button element to prevent undefined click event errors.
* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
* Updated reference to mixins Sass file.
Updated snapshots for Jest Test Suite #5 to account for EuiButton Emotion conversion. Updated unit tests that target EuiButton to simulate click events. These tests have been updated to target a button element to prevent undefined click event errors
* Updated unit tests in Jest Test Suites 3, 7, 8, 13, and 14.
Updated snapshot to account for EuiButton Emotion conversion.
Updated tests that target EuiButton to simulate click events. These tests now target a generic button element to prevent undefined click event errors.
Updated a few snapshots by adding .render() before checking the snapshot. This will prevent large snapshots coming from recent Emotion conversions
* Updated snapshots in Jest Test Suite #10 to account for the recent EuiButton Emotion conversion
* Updated unit tests in Jest Test Suite #2 by editing tests that target EuiButton to simulate click events. These tests now target a button element in order to prevent undefinde click event errors
* Updated snapshots in Jest Test Suite #10 to account for EuiButton and EuiDescriptionList Emotion conversions
* Updated test cases in Jest Test Suites 3, 7, and 8. Updated snapshots to account for EuiButton and EuiPagination Emotion conversions.
Updated tests that target EuiButton to simulate click events. These tests now target a button element to prevent undefined click errors
* Updated test cases in Jest Test Suite 14. Updated snapshots to account for EuiButton Emotion conversion. Opted to use .render() when updating a few snapshots to reduce the large length of snapshots caused by Emotion
* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
* Revised a change to betaBadgeProps to ensure that the label is available. If not, the value for the badge with be set to undefined.
* Resolved two linting errors
* Resolved two linting errors
* Updated Jest unit tests in various suites.
Updated snapshots to account for EuiButton Emotion conversion. Updated snapshots for EuiTooltip as it now contains the new EuiTooltipAnchor component that replaced the tooltip anchor styles.
* Updated EuiFlyout in query_flyout.tsx to remove the onClick function from maskProps as it is no longer available. Updated this flyout to use ownFocus and not to close when the overlay mask is clicked.
* Removed the use of EuiButtonIconColor in favor of EuiButtonIconProps['color']
* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
* Updated Cypress test looking for strict equality on EuiPaginationButton class names to match a substring of the Emotion generated class name
* Removed unneeded debugging code. Updated snapshots for various test suites to account for the recent EuiButton Emotion conversion
* Updated a few EuiButton, EuiButtonEmpty, and EuiText components that set the color as ghost. The ghost color mode has been deprecated as of PR #6150. These components now are wrapped in EuiThemeProvider with a dark colorMode to create the previous ghost color.
* Resolved TS error with EuiCard betaBadgeProps
* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
* Remove references to now-removed EuiFlyout CSS classes/vars
* Remove now-removed euiBadge className references
- Convert directly to EuiBadge instead of using CSS
- Remove confusing and now-possibly-irrelevant CSS badge overrides - left/right icons are now set via JSX and not via flex-direction
* Pre-emptively fix various euiOverlayMask CSS overrides
- this data attr isn't technically in yet but will be once https://github.com/elastic/eui/pull/6289 merges
- at the very least this isn't breaking any more than it currently already is!
* Update to v67.1.3
* v67.1.4
* Resolved test failing test case in Security/Manage/Blocklist. The test did not remove focus from the last combo box in the form, which didn't allow the disbaled attribute to be removed from the flyout submit button. I've updated the mock file for Blocklist to return focus to the first form element in the flyout to allow the disabled attribute to be removed.
* Updated snapshots to account for the recent EuiText Emotion conversion
* Fix Log's custom tooltips relying on EuiTooltip classNames that no longer exist
* Fix Vega vis custom tooltips relying on EuiTooltip classNames that no longer exist
- this one is trickier than Log's as it's not using React, so we need to use Emotion's Global to set a static className
* Convert remaining vega_vis.scss to Emotion
- as an example of how other global + non global styles could be handled in the future
* Fix references to removed `euiPaginationButton-isActive` className
- use aria-current attribute instead
* Added missing EuiFlyoutAnimation keyframes for EuiFlyout. This resolved test that failed because they used onAnimationEnd because the FlyoutAnimation could not be found.
* Reolved Jest Tests in suites 1 and 5. Updated snapshots to account for the recent EuiButton Emotion conversion. Updated snapshots for EuiToolTip as it now contains the new EuiToolTipAnchor component that replaced the tooltip anchor styles.
* iterate on rules_list.test.tsx
* bump eui to v67.1.5
* Updatde snapshots for jest test suites to account for the recent EuiButton, EuiOverlayMask, EuiTooltip, and EuiBadge Emotion conversions
* Resolved failing security test by updating the target element for CONNECTOR_TITLE. EuiCard has recently been converted to Emotion and the card title is no longer wrapper in a span.
* Resolved failing test case in Runtime Fields. The modify runtime field test was failing because the combobox responsbible for adding and updating scripts was not appearing. The textbox did not appear because the shared setFieldScript function targets and toggles the script textbox when opening the flyout. When a runtime field is being modified, the toggle is already active and using the shared function will trigger the toggle again (losing access to the script textbox).
Also resolved an issue that prevented the warning EuiCallout to appear when changing the type of a runtime field from its original type. Resolved this by adding an enter keypress at the end of setFieldType function to confirm the type selection, thus triggering the EuiCallout
* Resolved two tests that were failing in Lens. These test were failing because they were checking for equality in class names that no longer exist within EuiButtonGroup as it was recently converted to Emotion. These tests were updated to check for a substring of the new and longer class name
* Quick fix in test case failing because of misspelling in data-test-sub
* Updated snapshot for Jest test case as EuiButton as recently been converted to Emotion
* Removed console.log statement. Oops!
* Resolved a failing test case in Lens. They were failing because they were checking for equality in class names that no longer exist within EuiButtonGroup as it was recently converted to Emotion. These tests were updated to check for a substring of the new and longer class name.
Updated a Security test case by giving a target button the data-test-subj attribute for easier querying
* Removed reference to EuiFlyout mixin as it has been converted to Emotion. Updated the reference to an interal copy of EuiFlyout styles
* Corrected spelling error in EuiFlyout animation in Lens app
* Update EUI with latest backport
* Update button snapshots
* fix another button snapshot
* More snapshot fixes
* [EuiButton][Security] Fix button relying on now-removed `euiButton__text` CSS
- replace removed CSS with `eui-textTruncate` util instead
- combine/DRY out unnecessary span - was affecting min-width of truncation util
+ increase screenshot diff limit - this was smaller than updating the actual baseline screenshots for whatever reason (likely render diff between local and CI)
* Fix remaining Jest tests affected by Emotion conversions
- because Emotion creates its own wrapper, `.first()` can no longer be used - prefer `.last()` instead
* Fix Jest test affected by EuiButton Emotion conversion + removed modifier class
- targeting the native DOM node + filtering by disabled true/false gets us back to the 'correct' lengths
* Fix + improve flyout test
- `.last()` changes to account for EuiButton Emotion conversion is needed, but the last onClose assertion still fails due to us having modified inputs, and the confirm modal being displayed
- split test into two separate tests - one testing the onClose call, and the other testing the confirm modal
* derpin
* Skip rules_list Jest suite
* Update new EuiButton snapshot
* Upgraded EUI version to 67.1.7
* [EuiCard] Update snapshots
* [EuiPopover] Update snapshots
* [QA] Fix missing Vega warn/error message colors
;_;
* [CI] Auto-commit changed files from 'node scripts/generate codeowners'
* Fix Lens kbnToolbarButton regressions
- Caused by flattening of EUI button CSS specificity
- background-color was previously relying on isDisabled CSS specificity to override its #fff color
- `text` color modifier & `!important` is no longer needed and overrides Emotion CSS flatly
- isDisabled class is no longer needed - euiButton no longer sets `pointer-events: none` on disabled buttons (fixes tooltip bug in webkit as well)
* Backport EUI 67.1.8 fixes
* Update EuiCard snapshots
* Fix EuiModal form wrapper causing overflow issues
- see https://elastic.github.io/eui/#/layout/modal#forms-in-a-modal
* Workaround for `.kbnOverlayMountWrapper` mount point causing overflow issues
- not sure what all is using this modal service to be honest, but the wrapper is causing issues with the modal layout, this fixes overflow issues but will not fix any mask-image issues as a result
* more snapshot updates
* EuiButton - added textProps to EuiButton to prevent very long button names from spilling over outside of the container
* EuiButton - Update EuiButton related snapshots. Updated tests that target EuiButton directly to use a data-telementary-id for more specific element querying required by Emotion
* QA - Removed unnecessary comment in code
* Temporary fix for EuiCard[selectable][layout=horizontal] instances on security solutions' rule page
* Temporary fix for EuiCard[selectable][layout=horizontal] instances on osquery live query and canvas's datasource selector
* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
* Fix CSS specificity, where canvas's solutionToolbarButton's background-color now takes precedence over EuiButton's primary styles
* Removed update to search_marker_tooltip that removed the euiTooltip styles and replaced then with Emotion styling. Added EuiTooltip Sass styles for the component to rely on to test for a styling bug that is causing the tooltip and the tooltip arrow to be out of sync with each other.
* Lint Sass file
* Lint Sass file
* Removed overflow:hidden style from .vgaVis_view as it was causing euiScrollStyles not to present the scroll bars in Vega Vis
* Remove typo from EuiButton textProps object. 'className' should not have been included in the actual class name
* Revert tooltip Sass
This reverts commit 20e6ead571, a5cd2de901, and c605cbd7b9
* Fix Emotion tooltip arrows
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance Chen <constance.chen@elastic.co>
Co-authored-by: Chandler Prall <chandler.prall@elastic.co>
* use data views plugin
* remove unneeded dependency
* use data views plugin
* fix type
* type fix
* supply dataViews as depedency
* supply dataViews as depeden
* Allowing _source in ES query DSL
* Adding functional test
* Adding to doc
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Service abstraction for data service
* Remove unnecessary files
* Fix jest tests for new data service
* Service abstraction for HTTP service + fix Jest tests
* Services abstraction for visualizations service
* Services abstraction for data views editor service
* Services abstraction for spaces service
* Services abstraction for settings service
* Remove more unnecessary files + clean up imports
* Add theme to new settings service + fix imports
* Services abstraction for overlays service
* Services abstraction for navigation service
* Services abstraction for chrome service
* Services abstraction for embeddable service + fix Jest tests
* Services abstraction for notifications service
* Services abstraction for dashboard capabilities service
* Remove unecessary context provider
* Services abstraction for screenshot mode service
* Services abstraction for url forwarding service
* Services abstraction for share service
* Services abstraction for usage collection service
* Another round of code cleanup
* Services abstraction for initializer context service
* Clean up more unecessary files
* Services abstraction for application service
* Remove duplicated saved object client service
* Services abstraction for saved objects service
* Services abstraction for saved objects tagging service
* Services abstraction for dashboard session storage service
* Services abstraction for core context service
* Clean up initializer context code
* Refactor to create singular no data page context service
* Create and use dashboard mount context provider
* Clean up + abstraction for docs link service
* Remove dashboard container services
* Temporarily revert back to deprecated fullscreen button
* Remove PlaceholderEmbeddableServices + more code clean up
* More code clean up
* Clean up plugin code
* Investigated possibly flaky test - doesn't actually seem to be flaky
* Update snapshot for new services
* Clean up actions code
* Clean up dashboard container code
* Add to documentation links service to remove type casting
* Address feedback
* Undo move of services in dashboard container factory
* Adding config for max alerts. Throw error in alert factory when max alerts are reported. Process alerts differently when alert limit is reached
* Fixing types. Adding new config to docker and docs
* Setting flag to indicate limit reached. Update rule status to warning if limit reached
* Fixing task runner test
* Cleanup
* Fixing task runner test
* Actually using result of hasReachedAlertLimit
* Fixing types
* Copying over scheduled actions for active alerts. Only execute actions if they exist
* Setting lower limit in functional test config
* Adding functional test
* Update x-pack/plugins/alerting/server/constants/translations.ts
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
* PR feedback
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Upgrade to v62.0.3
* Update EUI i18n tokens
* Update html string snapshots
- Emotion CSS hash changed
* [EuiIcon] Update instances of `keyboardShortcut` icons to `keyboard`
* [EuiErrorBoundary] Update snapshots from Emotion conversion
* [EuiImage] Update snapshots, tests, and CSS to account for Emotion conversion
* [EuiImage][RTL] Fix test failures caused by EuiImage changes
* [EuiCommentList] Deprecate EuiCommentProps.type
* [EuiCommentList] Rename `timelineIcon` prop to `timelineAvatar`
- see https://github.com/elastic/eui/pull/6071
* [EuiCommentList] Fix selectors deprecated by Emotion conversion
* [EuiPopover][EuiCommentEvent][Enzyme] Fix mounted test failures caused by Emotion conversions
- Mounting displays the Emotion wrapper with the data-test-subj on them - we need to specify the output div renders in order for text assertions to be correct
* [EuiPopover] Deprecate `initialFocus={false}` as an option
see https://github.com/elastic/eui/pull/6044
* [EuiPopover] Rename `display=inlineBlock` to `inline-block`
- see https://github.com/elastic/eui/pull/5977
* [EuiPopover] Update snapshots from Emotion conversion
* [EuiPopover] Replace deprecated `.euiPopover__panel-isOpen` class with new `[data-popover-open]` attribute
* [EuiPopover][RTL] Fix test failures caused by not waiting for EuiPopover animation/transition
* Skip failing a11y tests
- test w/ similar error already skipped in another test above
- requires closing the popover for next test to pass
- not sure why delete action is no longer available
* Fix failing Security Cypress tests
* Attempt to squash flaky FTR tests around Add Filter popover
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jonathan Budzenski <jon@elastic.co>
* [Discover] Supports SQL query language (#134429)
* Move the add dataview action above the dataview selection panel
* Implements a new selectable on the dataview picker for the text based languages
* Implementation of the transition modal when on SQL mode and select a dataview
* Fix es lint
* Change switch modal button modal icon
* Lazy load components
* Small changes on the styling of the switch without saving button
* Initialization of mocaco editor
* Change to the type
* Fixes types checks
* New submit button for query mode
* Implememtation of the expanded mode of the editor
* Implement documentation
* Implementation of the oneliner mode with ellipsis
* Some fixes on the resizer
* Implementation of the errors layout, WIP
* Fetch SQL data in Discover
* Fix expression test
* Fix editor zIndex
* Fix types error
* Fix type check in Discover
* Fix more types
* some CI fixes
* Fixes
* Cleanup after merge
* Remove from state
* Connect search errors with the unified search editor
* Add error mrkers in unified search editor
* Save and open saved searches
* Filter out saved searches from text based languages
* Some fixes
* Fix unit tests
* Fix checks
* On save and exit modal implementation
* Add shortcut on the editor for submit query
* Fix wrong condition
* Initial types change
* Use regex to find the index pattern string
* Fix some types and cleanup
* Fix types
* Fix some types
* Further fixes
* More fixes
* More fixes
* Fix visualize types
* more
* More fixes
* Fixes more types
* Fix dashboard types
* Fix dashboard types
* Controls plugin types
* Fix Lens types
* Fix data plugin types
* Fix types in Lens 2
* buildEsConfig type fixes
* Fix observability types
* Fix maps types
* data visualizer types
* Fix ml types
* xpack rest types
* Fix jest test
* Fix
* Move helper functions to es config
* fix bug on breadcrumb click
* Fix time field bug
* Add enableSql advanced setting to discover for enabling the sql mode
* Make the documentation component more dynamic
* Add some comments, improvements
* Enhance storybook with the textbased languages
* Update storybook with the error state of the editor
* Adds a readme for the editor and fixes the modal mobile version
* [Discover] improve test and storybook for new data type
* [Discover] add functional tests
* Add aggregate functions to the documentation
* [Discover] fix tests
* Add some unit tests
* [Discover] fix linting
* [Discover] update linting
* More unti tests
* Dataview picker unit tests
* Fix a bug on the dataview picker
* Add unit tests for the editor
* Fix jest test
* [Discover] apply suggestions
* [Discover] adjust styles
* Fix some bugs and select columns in the sql mode
* [Discover] fix eslint and tests
* [Discover] update unit tests
* Fix bug on transitioning from sql mode to dataview mode
* [Discover] fix tests
* Design fixes on the errors messages
* [Discover] fix ci
* Update the columns only if the query changes
* [Discover] change isPlainRecord retrieval method
* Fix bug on cleanup
* Fix bug on opening a saved search
* [Discover] fix comments
* [Discover] fix bug with browser refresh
* [Discover] fix functional
* [Discover] fix another functional
* Fix ordering lost when the user refreshes the browser
* [Discover] revert use_discover_state
* [Discover] revert functional impl
* Fix security solution types
* Casting dashboard plugin
* Revert change
* type param
* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
* Revert types changes
* More reverts
* Types fixes
* Fix Discover jest test
* Fix context app jest test
* Final types changes
* Fixes unit test
Co-authored-by: Dzmitry Tamashevich <diaamnj@mail.ru>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
* Fix types
* Fix jest test
* More design fixes
* Update advanced setting description
* Further design changes
* [Discover] Remove document explorer header column edit data view field functionality (#136743)
* remove Edit data view field for SQL
* Fix the fix
* [Discover] Implement SQL data fetching for embeddable (#136793)
* remove Edit data view field for SQL
* Fix the fix
* Implement SQL for embeddable
* Fix non-saved-search embeddables
* Fix reporting bundle size
* Allow filters on dashboard level for sql searches
* Fix the radius on the editor
* Add vertical padding on the editor
* Change the theme
* Address PR comments
* Fix types
* Address some of the comments
* Fix bug on transitioning from SQL to dataview mode with the modal dismissed
* More types fixes
* Design review comments
* Discovery team review comments
* Fix jest tests
* Fix bug on navigating from the SQL mode to the dataview mode and back in sql mode by clicking the breadcrumb
* Update src/plugins/discover/public/application/main/hooks/use_discover_state.ts
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
* Add padding to the top of the editor without creating any bug
* Add some padding to the bottom without creating any bug
* Fixes undo bug
* Fix confusing naming of variable
* Fix nested selects
* Update texts for transition modal and warning
* Make it work with dashboard Query
* Address some of the comments
Co-authored-by: Dzmitry Tamashevich <diaamnj@mail.ru>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
* Upgrade EUI to v60.0.0
* reorganize style tag injection using EuiProvider.cache options
* Convert Jest snapshots for EUI Emotion classNames to a static `emotion-` prefix instead of a dynamic hash
- The goal of this is to reduce thrashing on downstream Kibana snapshots whenever EUI CSS changes
+ Add serializer to Canvas' storyshots tests as well
+ Switch several .html() snapshots to .render() - render uses the new serializer logic, but .html() does not and will still output CSS hashes, plus is more difficult to read
* Update downstream tests for EuiStat Emotion/className changes
* Fix WithEuiTheme(EuiAccordionClass) references
* Rename mounted snapshots of EuiButtonContent to EuiButtonContentDeprecated
* add emotion/cache to kbn-ui-shared-deps
* Fix non-rendering server-side Emotion CSS
* Fix failing Security Cypress test
- the Cypress query/command being used wasn't working correctly
Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Discover] Include current filters into "Test query" request
* [Discover] Reset query results when criteria is changed
* [Discover] Add a comment
* [Discover] Reset "Test query" when any rule configuration changes
* Renaming alert to rule for es query rule type
* adding recovery context
* Updating unit tests
* Fixing i18n
* Adding functional test
* Adding functional test
* Fixing functional test
* Adding space id to link
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Unified search] Moves dataview picker to the search bar (#126560)
* [Unified search] Moves dataview picker to the search bar
* alter texts
* Remove unused file
* [ChangeDataView] Design cleanup
* Fix services mock failure
* Show newly created datavuew on the list
* Keep dataview picker in discover in mobile view
* Cleanup
* Cleanup translations
* Fix some discover FTs
* Fix management FTs
* More test fixes
* Added a dismissible tour
* Pulled the selectabl list into a new component
… for reuse
Called `DataViewsList`. I then changed Lens’ config panel’s own EuiSelectableList to use this new component instead.
*Didn’t do any test updates*
* Fix broken jest test
* Use the same picker component on Discover mobile view
* Apply some CI fixes
* Fix more functional tests
* More FTs fixes
* Close the tour popover for lens tests
* More FTs fixes
* Fix lens FTs
* Using new `styles.ts` pattern for custom styles and allowing for `fullWidth` buttons
* Better tour text and i18n
* Update copy
* No exclamation point
* Cleanup
* Fixes on discover tests
* Fixes on Lens Fts - create runtime fields
* Fixes on edit permission of add field in discover and some FTs fixes
* Further Fts fixes
* More FTs fixes
* Made tour opt-in with `showNewMenuTour`
* Refactor the OSS FTs to change less files
* Further cleanup on the FTs
* Remove unecessary action
* Fix dataview creation bug
* Add a unit test to the new component
* More fixes
* Fix OSS a11y tests
* Adds another unit test for Lens permissions
* Make a change to stabilize the tests
* Clear flyout prop as it is not used anymore
* Deisgn fixes for mobile view
* Address PR comments WIP
* Update the layrpanl dataview list when a new dataview is created
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
* fix test
* Fix CI
* Fix i18n checks
* [Unified search] Redesign search bar (#126566)
* [Unified search] Redesign search bar
* Changes to the saved queries design
* Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper`
* [Security Solution] Removing overrides of `.globaQueryBar`
* Cleanup of `.globalQueryBar` styles and variants
* General layout fixes/adjustments
* More general layout fixes and better defaults
* Enable Clear all button if saved query is applied
* Clear should be enabled if searched query is applied but not the save as new
* fix some bugs on enabling and disabling the menu options
* [design] Working on Load Filter set menu
* Indicate selection even before the user clicks apply
* prettify the time text
* Add delete saved qquery confirmation modal
* Some cleaning up
* Fix the manage saved queries link
* Enable load filter set if saved query is created for the first time
* Some fixes on linting and on translations
* Clanup scss
* Make some fixes
* Fix navigatation unit test
* Fix translations check
* Fix rest jest tests
* Fix some functional tests
* Fix checks
* Fixes the appearance of the searchbar components depending on the flags
* Fix OSS tests
* Fixes on tests and query bar logic
* Fix the OSS ally tests
* Fix graph and lens KQL bar display problems, apply saveQuery flag correctly
* Fix more tests
* Fix security solution test
* Undo tweaks for graph
* Better fix for Graph
- Emulate new look, not old
- Uses same context menu panel as the new one
- Provides the same button type (filter button)
* Fix checks and jest test
* Further fixes
* Fix language switcher test
* Hopefully fixes the rest of the solution tests
* Cleanup
* Fixes on maps filtering
* Fix Discover padding
* [Discover] Added New Field button to bottom of fields list
* Simple responsive behavior
* Quick filter updates
* CI fixes
* area-label fix
* 18n translate the add filed btn in discover
* Fix lens functional test
* fix functional tests
* Refactor and add unit test for the add filter button
* Add unit test to the saved management list component
* Stabilize lens test
* Second try to solve the flakiness
* Fix panels depending on the flags
* Fix jest tests
* Fix double menu when only the queryInput is on
* Add storybook for the different layouts of the unified search bar
* Fix ci checks
* Removee hooks comment
* Fix flakiness
* Fix problem with lens dataview change
* Fix checks
* Ensure that the query is submitted
* Fixes oon CI
* Fixes flakiness
* Fix checks CI
* Update texts
* Cleanup
* Fix unskipped funtional test
* Fix FT
* Update src/plugins/unified_search/public/saved_query_form/save_query_form.tsx
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Fix eslint
* Fix checks
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* Fix jest
* Fix jest tests
* Stabilize discover security tests
* [Unified search] Further enhancements (#129877)
* [Unified search] Redesign search bar
* Changes to the saved queries design
* Remove `globalQueryBar` from nested under `.kbnTopNavMenu__wrapper`
* [Security Solution] Removing overrides of `.globaQueryBar`
* Cleanup of `.globalQueryBar` styles and variants
* General layout fixes/adjustments
* More general layout fixes and better defaults
* Enable Clear all button if saved query is applied
* Clear should be enabled if searched query is applied but not the save as new
* fix some bugs on enabling and disabling the menu options
* [design] Working on Load Filter set menu
* Indicate selection even before the user clicks apply
* prettify the time text
* Add delete saved qquery confirmation modal
* Some cleaning up
* Fix the manage saved queries link
* Enable load filter set if saved query is created for the first time
* Some fixes on linting and on translations
* Clanup scss
* Make some fixes
* Fix navigatation unit test
* Fix translations check
* Fix rest jest tests
* Fix some functional tests
* Fix checks
* Fixes the appearance of the searchbar components depending on the flags
* Fix OSS tests
* Fixes on tests and query bar logic
* Fix the OSS ally tests
* Fix graph and lens KQL bar display problems, apply saveQuery flag correctly
* Fix more tests
* Fix security solution test
* Undo tweaks for graph
* Better fix for Graph
- Emulate new look, not old
- Uses same context menu panel as the new one
- Provides the same button type (filter button)
* Fix checks and jest test
* Further fixes
* Fix language switcher test
* Hopefully fixes the rest of the solution tests
* Cleanup
* Fixes on maps filtering
* Fix Discover padding
* [Discover] Added New Field button to bottom of fields list
* Simple responsive behavior
* Quick filter updates
* CI fixes
* area-label fix
* 18n translate the add filed btn in discover
* Fix lens functional test
* fix functional tests
* Refactor and add unit test for the add filter button
* Add unit test to the saved management list component
* Stabilize lens test
* Second try to solve the flakiness
* Fix panels depending on the flags
* Fix jest tests
* Fix double menu when only the queryInput is on
* Add storybook for the different layouts of the unified search bar
* Fix ci checks
* Removee hooks comment
* Fix flakiness
* Fix problem with lens dataview change
* Fix checks
* Ensure that the query is submitted
* Fixes oon CI
* Fixes flakiness
* Fix checks CI
* Update texts
* Cleanup
* Fix unskipped funtional test
* Fix FT
* Fixes filter bar responsiveness
* Add filter button option to the main menu
* Filter form design pass
- Added tooltip around “Add filter” icon button
- Fixed padding
- Stubbed in “Add” vs “Edit” labels
* Query menu icon button tooltip
* ‘Update’ not ‘Edit’ button label
* Apply different strings for adding filter mode vs edit
* Hide Manage SO link if the user donesnt have the permissions
* Fix the wrapping of the badges and datepicker badge
* Minor props naming fix
* Fix checks
* Fix mobile
* Cleanup
* Fix checks
* Faux button group
* Changes on the search input placeholder
* Fix CI
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
* Fix translations
* Fix security solution add filter bug
* Filter bar / items: Reduce to only necessary wrappers and styles
- Switch to Emotion for styling
- Rename `FilterBadgesWrapper` to `FilterItems`
- Move `FilterItems` and `FilterItem` so own folder `filter_item/`
# Conflicts:
# src/plugins/unified_search/public/filter_bar/filter_bar.tsx
# src/plugins/unified_search/public/filter_bar/filter_editor/lib/filter_label.tsx
# src/plugins/unified_search/public/filter_bar/filter_item/filter_item.tsx
# src/plugins/unified_search/public/filter_bar/filter_item/filter_items.tsx
# src/plugins/unified_search/public/filter_bar/filter_view/index.tsx
# src/plugins/unified_search/public/query_string_input/filter_editor_wrapper.tsx
# src/plugins/unified_search/public/search_bar/search_bar.tsx
* Fix styles by removing styled-components
Also added prop `afterQueryBar` to signify that it needs the top margin
# Conflicts:
# packages/kbn-babel-preset/styled_components_files.js
* Refactor `SearchBar` and `QueryBarTopRow` a bit
- Added `showSubmitButton` to explicitely hide the submit button (defaults to true)
- SearchBar always renders the `QueryBarTopRow` which now fully controls visibility of the pieces
- Renamed class with new `uni` prefix
- Tried and failed to use Emotion
* Update usages
# Conflicts:
# x-pack/plugins/security_solution/public/common/components/query_bar/index.tsx
* Fix a test
* Fix jest test
* Attaches filter menu when no add button and better dropdown styles
* Fix lint errors
* Clearing the query and filters of a saved query should unload the saved query
* Do not allow to update the loaded saved query if no filters or no query
* Fix Graph by creating reusable `KibanaFilterButtonGroup`
* Use EuiTheme for SearchBar styles
Updated `displayStyle` for Lens & Discover
* Fix displayStyle prop problem
* Correct alignment of data visualizer
* Super nit comment
* Data visualizer improvements
* Apply useMemo in editPermission cont in Discover
* Fix translations checks
* Fix translations checks
* Fix filter badge popover bug
* [Submit button] Changed to EuiSuperUpdateButton
- Quickly adds tooltip content and filled state for more prominence when dirty
- Fixed 18n
* Fix tests
* Align the position with the other tolltips and check that functional tests succeed
* Give some time to the tooltip to disappear
* Fix tests
* Fix CI checks
* Address PR comments
* Move constants outside render
* Apply PR comments
* Fix dataview picker glich
* lovercase emotion function
* Fix a11y problem on dataview picker
* Lowercase rest of emotion style functions
* Clean up
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
