Commit graph

2986 commits

Author SHA1 Message Date
CJ Cenizal
e922f00445 Upgrade eslint config to 0.8.1. (#13128)
* Fix incorrect peerDependency and bump eslint config version to 0.8.1.
* Upgrade eslint config to 0.8.1. Fix JSX to adhere to new formatting rules.
2017-07-27 10:52:41 -07:00
CJ Cenizal
b3ffd99542 Add linting rules for formatting JSX. (#12810)
* Add linting rules for formatting JSX.
* Bump eslint config version to 0.8.0.
2017-07-26 08:51:15 -07:00
Kim Joar Bekkelund
bdaf8485b0 Move eslint-config-kibana into core (#12725)
* Initial commit

* added actual config

* version 0.0.1

* version 0.0.2

* [no-const-assign] Disallow assignment to const

http://eslint.org/docs/rules/no-const-assign

* [no-redeclare] Disallow redeclaring variables

http://eslint.org/docs/rules/no-redeclare

* version 0.0.3

* [no-unused-vars]: Disallow declaration of variables that are not used in the code.

* Bump to 0.1.0.

* upgrade deps in preperation for babel6 transition

* 0.2.0-alpha1

* use yaml for readability

* 0.2.0

* update/pin peed dependency versions

* 0.2.1

* [quotes] allow template literals

This allows eslint to validate this rule from the styleguide: https://github.com/elastic/kibana/blob/master/style_guides/js_style_guide.md#use-template-strings-to-avoid-escaping-single-quotes

* 0.2.2

* add object-curly-spacing and no-global-assign rules

* sort .eslintrc.yaml rules

* 0.3.0

* add basic react support

* 0.4.0

* Disallow using 'context' in tests

* 0.5.0

* move from .eslintrc.yaml to .eslintrc.js without .json generation (#6)

* Implement import plugin (#7)

* update deps

* include eslint-plugin-import

* Dereference import config (#8)

* reorganize existing rules into groups

* defreference eslint-plugin-import "recommended" config

Based on ea9c92c732/config/recommended.js

* 0.6.0

* set environment info for import rule

* 0.6.1

* update peerDependencies

* 0.7.0

* Move eslint-config-kibana into packages directory
2017-07-25 10:02:14 +02:00
spalger
ea8aa196b0 commit yarn.lock file
Original commit: elastic/kibana-plugin-helpers@22bc67e613
2017-05-09 10:17:45 -07:00
Joe Fleming
eb7e5a0630 7.0.0
Original commit: elastic/kibana-plugin-helpers@2ff10e0a45
2017-05-02 14:40:48 -07:00
Joe Fleming
9f37553324 Bump eslint rules, update code to match rules (elastic/kibana-plugin-helpers#43)
* bump @elastic/eslint-config-kibana and deps

* eslint --fix

* fix unused vars

some exceptions for tests

* move eslint-config-kibana to dev

* rename create_package function

* make .node-version looser, match internal checks

Original commit: elastic/kibana-plugin-helpers@6fac14bd51
2017-05-02 14:37:06 -07:00
Spencer
eb1e80f272 require node 6 (elastic/kibana-plugin-helpers#42)
* switch to .node-version file

* require and validate node version 6+

Original commit: elastic/kibana-plugin-helpers@85655f230e
2017-05-02 14:27:07 -07:00
spalger
42bc99108f [utils] use actual plugin config (with defaults)
Original commit: elastic/kibana-plugin-helpers@f3bfdb2689
2017-04-28 08:15:04 -07:00
spalger
31e731fd04 bump to version 7 snapshot
Original commit: elastic/kibana-plugin-helpers@0c1b2c1670
2017-04-28 07:53:16 -07:00
Spencer
7331033072 Added helpers, KIBANA_ROOT environment override (elastic/kibana-plugin-helpers#41)
* run is now a named export, added helpers for interacting with the kibana repo

* [config] override the kibana root config with KIBANA_ROOT envvar

Original commit: elastic/kibana-plugin-helpers@54a38cd9a2
2017-04-28 07:49:19 -07:00
Shaunak Kashyap
69c22889ab Kibana-related packages (#11308)
* Make sure package is published under @elastic org namespace

* Preparing packages/ for Kibana-related packages

* Folder structure mirrors package name

* Add note on naming consistency

* s/packages/node modules/ for removing potention confusion with Kibana system packages

* Prefixing the eslint rule with package scope (i.e. org namespace)

* Adding README

* Bumping up version for release

* Adding repository information to package.json

* Bumping up version for release

* URL-encoding repository link + bumping up version for release

* Using published version
2017-04-19 04:31:00 -07:00
Stacey Gammon
5aea4ff210 Add no default exports custom rule (#10981)
* Introduce a custom kibana estlint rule for no default exports

Turn it on only at the level of /kibana/src/core_plugins/public/ for
now, just to keep the PR sizes manageable.

* Don't call functions directly on the import

* Create a packages dir and move the custom rule in there

* Remove copied package.json portions, use minimal info necessary
2017-04-12 06:59:14 -04:00
spalger
0dfc60ded1 6.0.4
Original commit: elastic/kibana-plugin-helpers@0c0ee17a54
2017-03-29 12:23:58 -07:00
spalger
6611bc4c8f fix build task when yarn is not installed
Original commit: elastic/kibana-plugin-helpers@d48808f8d8
2017-03-29 12:23:51 -07:00
spalger
3a2a636da0 6.0.3
Original commit: elastic/kibana-plugin-helpers@b4da11f899
2017-03-28 10:12:22 -07:00
Joe Fleming
a773536c06 Fix running tasks on Windows (elastic/kibana-plugin-helpers#37)
* create windows cmd wrapper

* use windows cmd wrapper on browser tests

* be explicit about the mocha command location

* use windows cmd wrapper on server tests

* use windows cmd wrapper on build

default to using npm as well

Original commit: elastic/kibana-plugin-helpers@35f80a08ce
2017-03-28 00:01:58 -07:00
Joe Fleming
142d2dff2d change let to var (elastic/kibana-plugin-helpers#35)
allow helpers to run on pre-6.0 node

Original commit: elastic/kibana-plugin-helpers@91de9a84d3
2017-03-27 11:30:19 -07:00
spalger
187a94427b 6.0.2
Original commit: elastic/kibana-plugin-helpers@ff9d402245
2017-02-24 13:32:07 -07:00
spalger
c61d2bd11f [tasks/test/browser] fix --kbnServer.tests_bundle flag
Original commit: elastic/kibana-plugin-helpers@12e7552adb
2017-02-24 13:31:52 -07:00
spalger
0a044bf726 6.0.1
Original commit: elastic/kibana-plugin-helpers@8eae537f9f
2017-02-21 10:42:49 -07:00
Megan Walker
314bda86a6 Update URLs in package.json (elastic/kibana-plugin-helpers#31)
The package.json URLs are still referencing @spalger's version, whilst development and collaboration happens on @elastic's version

Original commit: elastic/kibana-plugin-helpers@1f322c1cb1
2017-02-21 10:41:26 -07:00
Joe Fleming
7adc615c1f 6.0.0
Original commit: elastic/kibana-plugin-helpers@9ee7b62e75
2017-01-11 14:43:19 -07:00
Joe Fleming
85234f979b Use npm/yarn to install build dependencies (elastic/kibana-plugin-helpers#28)
* remove scripts and devDependencies from package

these are only useful in development, and serve no purpose in the build

* refactor the package rewriter

* clean up the buildTarget before building

* run npm install after build creation

* break apart the create_build module

* add create_package modules

call it from within the build_action

* add flag to skip package zip creation

* rename skip-package flag to skip-archive

* rename rewritePackage to rewritePackageJson

* include lock and shrinkwrap files if they exist

* add test for skipping zip creation

* add some tests to build creation

Original commit: elastic/kibana-plugin-helpers@ef6b9c6332
2017-01-11 14:41:05 -07:00
Joe Fleming
569ac1f3d1 5.2.0
Original commit: elastic/kibana-plugin-helpers@8c2a547d9d
2016-12-23 10:50:07 -07:00
Joe Fleming
d258d24b13 Allow custom build target via --build-destination flag (elastic/kibana-plugin-helpers#30)
* pass buildTarget into createBuild

allow override from options

* add cli option to override build destination

--build-destination

* fix tests

* resolve build destination from plugin.root

this allows both relative and absolute paths to be used

* add short option

* update the help

Original commit: elastic/kibana-plugin-helpers@6c9fb3464e
2016-12-23 10:48:06 -07:00
Joe Fleming
efa7302364 return the result of running the action
Original commit: elastic/kibana-plugin-helpers@9b819eeeb3
2016-12-22 15:58:56 -07:00
Joe Fleming
ceb52252be Enable custom builds (elastic/kibana-plugin-helpers#27)
* only modify root package.json file

previously this was modifying every package.json from node_modules as well

* refactor the build task

export the build, define helpers outside of the task

* allow custom kibana and build versions

both can be passed via flags

* allow custom build globs to be specified

* move build into its own module

* add simple option parsing tests

* update readme

* move dependency file appending into the action

* put source and target into variables

* move config file loading into a module

* refactor test_server_action slightly

be more explicit about the files option overwriting the plugin settings

* move default build patterns to plugin config

allows the setting to be overridden via the config file

* fix dirname on relative includes

trim any leading '../' off the path when moving it into the build target

* move node_module dirs into plugin_config module, use existing promises

* rename file_config => config_file

Original commit: elastic/kibana-plugin-helpers@743e4a37c2
2016-12-21 22:37:57 -06:00
Joe Fleming
4cc81e2c89 5.1.1
Original commit: elastic/kibana-plugin-helpers@ad9a8e85b8
2016-12-21 18:22:03 -07:00
Joe Fleming
4456490cc5 fix cli parsing of --dev flag
Original commit: elastic/kibana-plugin-helpers@3aa37c2dfc
2016-12-21 18:21:15 -07:00
Joe Fleming
269bdc45e2 node4 support: const -> var
Original commit: elastic/kibana-plugin-helpers@19b607d954
2016-12-16 18:20:35 -07:00
Joe Fleming
5bc1308422 format the package.json file
Original commit: elastic/kibana-plugin-helpers@c474820bb5
2016-12-16 18:20:35 -07:00
Joe Fleming
a145458138 append build info to package.json
Original commit: elastic/kibana-plugin-helpers@504fd07f3c
2016-12-16 18:20:33 -07:00
Joe Fleming
dd0d91cfd0 update the readme
Original commit: elastic/kibana-plugin-helpers@c650c4527e
2016-12-16 09:41:32 -07:00
Joe Fleming
802d68ecc9 5.1.0
Original commit: elastic/kibana-plugin-helpers@6dd1407e81
2016-12-16 09:39:35 -07:00
Joe Fleming
0d621e778a Separate the task runner and the command line parser (elastic/kibana-plugin-helpers#25)
* remove conditionl require in runner

add tasks module to load all tasks, throw if task does not exist

* change task signatures and action handlers

- tasks get plugin, run, and an options object
- action handler controls what goes into each task
- taskRunner wrapper moves the command object to the first argument

* change test command signature

allow files to be passed in, and pass all options to test:server and test:browser

* simplify the task runner

* fix typo in unknownOptions

* expose the task runner as the module's main

this way tasks can be run programatically without going through a cli parser

* add tests for task runner

* remove file passing for testAll

* add serverTestPaths to the plugin config

useful for overriding the value via a config file

* [config] plugin.serverTestPaths -> plugin.serverTestPatterns

Original commit: elastic/kibana-plugin-helpers@82af4df64e
2016-12-16 01:06:02 -07:00
Joe Fleming
0ee64597fb add not about custom tests executiong to the readme/help
Original commit: elastic/kibana-plugin-helpers@139221e5a6
2016-12-15 15:14:29 -07:00
Joe Fleming
867ed91517 make server test files an argument
Original commit: elastic/kibana-plugin-helpers@b043b423ef
2016-12-15 14:56:47 -07:00
Joe Fleming
01a8fcee35 assign args in argument passing code
minor syntax change

Original commit: elastic/kibana-plugin-helpers@ce77d071d1
2016-12-15 14:24:44 -07:00
Joe Fleming
beb4b33f62 if plugins are specified, use the option value instead of the default
Original commit: elastic/kibana-plugin-helpers@d610c9c9d6
2016-12-15 14:24:44 -07:00
Joe Fleming
47595e7bdd add plugins option to browser tests
used to pass your own testsBundle.pluginIds to the test runner

Original commit: elastic/kibana-plugin-helpers@d370d74bd4
2016-12-15 14:24:44 -07:00
Joe Fleming
8b6ac6469c split and concat and included server test paths
Original commit: elastic/kibana-plugin-helpers@e7dffb6ffe
2016-12-15 14:24:44 -07:00
Joe Fleming
c5b08cc1fa add --include options to test:server
Original commit: elastic/kibana-plugin-helpers@d3b5e24207
2016-12-15 14:24:04 -07:00
Joe Fleming
545a304f0f Move require calls outside of task functions (elastic/kibana-plugin-helpers#23)
* move require calls outside of task functions

* fix default command value

Original commit: elastic/kibana-plugin-helpers@846855e960
2016-12-15 13:15:36 -07:00
Joe Fleming
11bb47cc74 fix default command, no more use of call
Original commit: elastic/kibana-plugin-helpers@fe13b987c9
2016-12-14 17:23:09 -07:00
Joe Fleming
30dc427299 use --dev flag for browser dev mode
Original commit: elastic/kibana-plugin-helpers@a790fdd338
2016-12-14 17:19:18 -07:00
Joe Fleming
f222c6e889 pass run method into tasks
don't reach into lib for it

Original commit: elastic/kibana-plugin-helpers@d92d2e979a
2016-12-14 17:06:13 -07:00
Joe Fleming
b85a68df15 remove use of spread and default assignment
Original commit: elastic/kibana-plugin-helpers@17532f0fdd
2016-12-14 17:06:13 -07:00
Joe Fleming
3486e431ad add test command to execute test/all
Original commit: elastic/kibana-plugin-helpers@e096ac55f3
2016-12-14 17:06:13 -07:00
Joe Fleming
f1a9be1933 add a test/all task
Original commit: elastic/kibana-plugin-helpers@9b7c15cf32
2016-12-14 17:06:13 -07:00
Joe Fleming
df21e54e57 allow browser tests to be runOnce
Original commit: elastic/kibana-plugin-helpers@ede52ece0e
2016-12-14 17:06:13 -07:00