Commit graph

63 commits

Author SHA1 Message Date
Cauê Marcondes
3f05ea0f0e
[8.8] [Profling][Fleet]Add a prerelease query param so who links to an integration can tell where the details must be read from (#160244) (#160511)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Profling][Fleet]Add a prerelease query param so who links to an
integration can tell where the details must be read from
(#160244)](https://github.com/elastic/kibana/pull/160244)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-22T13:00:21Z","message":"[Profling][Fleet]Add
a prerelease query param so who links to an integration can tell where
the details must be read from (#160244)\n\nProblem:\r\nIn the Profiler
Add data page we show instructions on how to set up\r\nUniversal
Profiling. One of the options is from the Profiler\r\nintegration. So we
display a button that links
to\r\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview`.
The\r\nproblem is this link, is that the profiler integration is still
in\r\n`Beta`, and will be until `8.10`, and when I click on that link
the\r\nerror shown in the image below
happens.\r\nBefore:\r\n![Screenshot 2023-06-21 at 9 58
29\r\nPM](4800bdc3-df40-4579-9e57-d4b28e13be19)\r\n\r\nSolution:\r\nI
added an optional query param `prerelase={true|false}` to
the\r\nintegration link. So now I changed the link
to:\r\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview?prerelease=true`,\r\nthis
when true, overrides
the\r\n`settings?.item.prerelease_integrations_enabled` which is false
by\r\ndefault.\r\n\r\nAfter:\r\n<img width=\"1407\" alt=\"Screenshot
2023-06-22 at 11 16 52
AM\"\r\nsrc=\"a0fd4ea5-b54b-45ea-9903-b43a24600e7e\">","sha":"7b5b61a2ad5c08716949b6a6aa5a1562bdea6a5e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v8.9.0"],"number":160244,"url":"https://github.com/elastic/kibana/pull/160244","mergeCommit":{"message":"[Profling][Fleet]Add
a prerelease query param so who links to an integration can tell where
the details must be read from (#160244)\n\nProblem:\r\nIn the Profiler
Add data page we show instructions on how to set up\r\nUniversal
Profiling. One of the options is from the Profiler\r\nintegration. So we
display a button that links
to\r\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview`.
The\r\nproblem is this link, is that the profiler integration is still
in\r\n`Beta`, and will be until `8.10`, and when I click on that link
the\r\nerror shown in the image below
happens.\r\nBefore:\r\n![Screenshot 2023-06-21 at 9 58
29\r\nPM](4800bdc3-df40-4579-9e57-d4b28e13be19)\r\n\r\nSolution:\r\nI
added an optional query param `prerelase={true|false}` to
the\r\nintegration link. So now I changed the link
to:\r\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview?prerelease=true`,\r\nthis
when true, overrides
the\r\n`settings?.item.prerelease_integrations_enabled` which is false
by\r\ndefault.\r\n\r\nAfter:\r\n<img width=\"1407\" alt=\"Screenshot
2023-06-22 at 11 16 52
AM\"\r\nsrc=\"a0fd4ea5-b54b-45ea-9903-b43a24600e7e\">","sha":"7b5b61a2ad5c08716949b6a6aa5a1562bdea6a5e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160244","number":160244,"mergeCommit":{"message":"[Profling][Fleet]Add
a prerelease query param so who links to an integration can tell where
the details must be read from (#160244)\n\nProblem:\r\nIn the Profiler
Add data page we show instructions on how to set up\r\nUniversal
Profiling. One of the options is from the Profiler\r\nintegration. So we
display a button that links
to\r\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview`.
The\r\nproblem is this link, is that the profiler integration is still
in\r\n`Beta`, and will be until `8.10`, and when I click on that link
the\r\nerror shown in the image below
happens.\r\nBefore:\r\n![Screenshot 2023-06-21 at 9 58
29\r\nPM](4800bdc3-df40-4579-9e57-d4b28e13be19)\r\n\r\nSolution:\r\nI
added an optional query param `prerelase={true|false}` to
the\r\nintegration link. So now I changed the link
to:\r\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview?prerelease=true`,\r\nthis
when true, overrides
the\r\n`settings?.item.prerelease_integrations_enabled` which is false
by\r\ndefault.\r\n\r\nAfter:\r\n<img width=\"1407\" alt=\"Screenshot
2023-06-22 at 11 16 52
AM\"\r\nsrc=\"a0fd4ea5-b54b-45ea-9903-b43a24600e7e\">","sha":"7b5b61a2ad5c08716949b6a6aa5a1562bdea6a5e"}},{"url":"https://github.com/elastic/kibana/pull/160388","number":160388,"branch":"8.9","state":"MERGED","mergeCommit":{"sha":"c5b17f6d69869c14dc0e9df836da413d3bb43199","message":"[8.9]
[Profling][Fleet]Add a prerelease query param so who links to an
integration can tell where the details must be read from (#160244)
(#160388)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.9`:\n- [[Profling][Fleet]Add a prerelease query param so
who links to an\nintegration can tell where the details must be read
from\n(#160244)](https://github.com/elastic/kibana/pull/160244)\n\n<!---
Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Cauê\nMarcondes\",\"email\":\"55978943+cauemarcondes@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2023-06-22T13:00:21Z\",\"message\":\"[Profling][Fleet]Add\na
prerelease query param so who links to an integration can tell
where\nthe details must be read from (#160244)\\n\\nProblem:\\r\\nIn the
Profiler\nAdd data page we show instructions on how to set
up\\r\\nUniversal\nProfiling. One of the options is from the
Profiler\\r\\nintegration. So we\ndisplay a button that
links\nto\\r\\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview`.\nThe\\r\\nproblem
is this link, is that the profiler integration is still\nin\\r\\n`Beta`,
and will be until `8.10`, and when I click on that link\nthe\\r\\nerror
shown in the image below\nhappens.\\r\\nBefore:\\r\\n![Screenshot
2023-06-21 at 9
58\n29\\r\\nPM](4800bdc3-df40-4579-9e57-d4b28e13be19)\\r\\n\\r\\nSolution:\\r\\nI\nadded
an optional query param `prerelase={true|false}`
to\nthe\\r\\nintegration link. So now I changed the
link\nto:\\r\\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview?prerelease=true`,\\r\\nthis\nwhen
true,
overrides\nthe\\r\\n`settings?.item.prerelease_integrations_enabled`
which is false\nby\\r\\ndefault.\\r\\n\\r\\nAfter:\\r\\n<img
width=\\\"1407\\\" alt=\\\"Screenshot\n2023-06-22 at 11 16
52\nAM\\\"\\r\\nsrc=\\\"a0fd4ea5-b54b-45ea-9903-b43a24600e7e\\\">\",\"sha\":\"7b5b61a2ad5c08716949b6a6aa5a1562bdea6a5e\",\"branchLabelMapping\":{\"^v8.9.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:skip\",\"Team:Fleet\",\"v8.9.0\"],\"number\":160244,\"url\":\"https://github.com/elastic/kibana/pull/160244\",\"mergeCommit\":{\"message\":\"[Profling][Fleet]Add\na
prerelease query param so who links to an integration can tell
where\nthe details must be read from (#160244)\\n\\nProblem:\\r\\nIn the
Profiler\nAdd data page we show instructions on how to set
up\\r\\nUniversal\nProfiling. One of the options is from the
Profiler\\r\\nintegration. So we\ndisplay a button that
links\nto\\r\\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview`.\nThe\\r\\nproblem
is this link, is that the profiler integration is still\nin\\r\\n`Beta`,
and will be until `8.10`, and when I click on that link\nthe\\r\\nerror
shown in the image below\nhappens.\\r\\nBefore:\\r\\n![Screenshot
2023-06-21 at 9
58\n29\\r\\nPM](4800bdc3-df40-4579-9e57-d4b28e13be19)\\r\\n\\r\\nSolution:\\r\\nI\nadded
an optional query param `prerelase={true|false}`
to\nthe\\r\\nintegration link. So now I changed the
link\nto:\\r\\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview?prerelease=true`,\\r\\nthis\nwhen
true,
overrides\nthe\\r\\n`settings?.item.prerelease_integrations_enabled`
which is false\nby\\r\\ndefault.\\r\\n\\r\\nAfter:\\r\\n<img
width=\\\"1407\\\" alt=\\\"Screenshot\n2023-06-22 at 11 16
52\nAM\\\"\\r\\nsrc=\\\"a0fd4ea5-b54b-45ea-9903-b43a24600e7e\\\">\",\"sha\":\"7b5b61a2ad5c08716949b6a6aa5a1562bdea6a5e\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v8.9.0\",\"labelRegex\":\"^v8.9.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/160244\",\"number\":160244,\"mergeCommit\":{\"message\":\"[Profling][Fleet]Add\na
prerelease query param so who links to an integration can tell
where\nthe details must be read from (#160244)\\n\\nProblem:\\r\\nIn the
Profiler\nAdd data page we show instructions on how to set
up\\r\\nUniversal\nProfiling. One of the options is from the
Profiler\\r\\nintegration. So we\ndisplay a button that
links\nto\\r\\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview`.\nThe\\r\\nproblem
is this link, is that the profiler integration is still\nin\\r\\n`Beta`,
and will be until `8.10`, and when I click on that link\nthe\\r\\nerror
shown in the image below\nhappens.\\r\\nBefore:\\r\\n![Screenshot
2023-06-21 at 9
58\n29\\r\\nPM](4800bdc3-df40-4579-9e57-d4b28e13be19)\\r\\n\\r\\nSolution:\\r\\nI\nadded
an optional query param `prerelase={true|false}`
to\nthe\\r\\nintegration link. So now I changed the
link\nto:\\r\\n`/app/integrations/detail/profiler_agent-8.8.0-preview/overview?prerelease=true`,\\r\\nthis\nwhen
true,
overrides\nthe\\r\\n`settings?.item.prerelease_integrations_enabled`
which is false\nby\\r\\ndefault.\\r\\n\\r\\nAfter:\\r\\n<img
width=\\\"1407\\\" alt=\\\"Screenshot\n2023-06-22 at 11 16
52\nAM\\\"\\r\\nsrc=\\\"a0fd4ea5-b54b-45ea-9903-b43a24600e7e\\\">\",\"sha\":\"7b5b61a2ad5c08716949b6a6aa5a1562bdea6a5e\"}}]}]\nBACKPORT-->"}}]}]
BACKPORT-->
2023-06-26 05:42:37 -07:00
Kibana Machine
9b343b4a78
[8.8] [Profiling]Fixing hardcoded version (#159021) (#159027)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Profiling]Fixing hardcoded version
(#159021)](https://github.com/elastic/kibana/pull/159021)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-05T13:33:46Z","message":"[Profiling]Fixing
hardcoded version
(#159021)","sha":"6638184320e0bc5ea05d41ec629349147b80bb27","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","v8.8.1"],"number":159021,"url":"https://github.com/elastic/kibana/pull/159021","mergeCommit":{"message":"[Profiling]Fixing
hardcoded version
(#159021)","sha":"6638184320e0bc5ea05d41ec629349147b80bb27"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159021","number":159021,"mergeCommit":{"message":"[Profiling]Fixing
hardcoded version
(#159021)","sha":"6638184320e0bc5ea05d41ec629349147b80bb27"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
2023-06-05 07:46:33 -07:00
Kibana Machine
b7064bd537
[8.8] [Profling] Adding Elastic agent instructions (#158936) (#158949)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Profling] Adding Elastic agent instructions
(#158936)](https://github.com/elastic/kibana/pull/158936)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-02T16:13:29Z","message":"[Profling]
Adding Elastic agent instructions (#158936)\n\n<img width=\"1249\"
alt=\"Screenshot 2023-06-02 at 3 51 04
PM\"\r\nsrc=\"46f007ad-def6-42e7-930e-98d453d3a06d\">","sha":"1b3f23829c9a41d2995e279b37b04fc457befa6e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v8.9.0","v8.8.1"],"number":158936,"url":"https://github.com/elastic/kibana/pull/158936","mergeCommit":{"message":"[Profling]
Adding Elastic agent instructions (#158936)\n\n<img width=\"1249\"
alt=\"Screenshot 2023-06-02 at 3 51 04
PM\"\r\nsrc=\"46f007ad-def6-42e7-930e-98d453d3a06d\">","sha":"1b3f23829c9a41d2995e279b37b04fc457befa6e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158936","number":158936,"mergeCommit":{"message":"[Profling]
Adding Elastic agent instructions (#158936)\n\n<img width=\"1249\"
alt=\"Screenshot 2023-06-02 at 3 51 04
PM\"\r\nsrc=\"46f007ad-def6-42e7-930e-98d453d3a06d\">","sha":"1b3f23829c9a41d2995e279b37b04fc457befa6e"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
2023-06-02 11:00:15 -07:00
Kibana Machine
9b269278dd
[8.8] Profiling: improve "Add Symbols" page (#157507) (#157663)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Profiling: improve "Add Symbols" page
(#157507)](https://github.com/elastic/kibana/pull/157507)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Joel
Höner","email":"joel@zyantific.com"},"sourceCommit":{"committedDate":"2023-05-13T17:47:12Z","message":"Profiling:
improve \"Add Symbols\" page (#157507)\n\nThis PR adds a link to the
previously missing ARM64 variant of the\r\n`symbtool` link and applies
some general visual improvements to the `Add\r\nSymbols` tab on
Universal Profiling's \"No Data\"-page. Most notably, it\r\nreplaces the
ugly overlong headlines with text blocks.\r\n\r\nResolves
https://github.com/elastic/prodfiler/issues/3350","sha":"f4c9a33697310849ef94c2d53fddbfc908752e8b","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","backport","release_note:skip","ci:build-cloud-image","ci:cloud-deploy","ci:cloud-redeploy","v8.8.0","v8.9.0"],"number":157507,"url":"https://github.com/elastic/kibana/pull/157507","mergeCommit":{"message":"Profiling:
improve \"Add Symbols\" page (#157507)\n\nThis PR adds a link to the
previously missing ARM64 variant of the\r\n`symbtool` link and applies
some general visual improvements to the `Add\r\nSymbols` tab on
Universal Profiling's \"No Data\"-page. Most notably, it\r\nreplaces the
ugly overlong headlines with text blocks.\r\n\r\nResolves
https://github.com/elastic/prodfiler/issues/3350","sha":"f4c9a33697310849ef94c2d53fddbfc908752e8b"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157507","number":157507,"mergeCommit":{"message":"Profiling:
improve \"Add Symbols\" page (#157507)\n\nThis PR adds a link to the
previously missing ARM64 variant of the\r\n`symbtool` link and applies
some general visual improvements to the `Add\r\nSymbols` tab on
Universal Profiling's \"No Data\"-page. Most notably, it\r\nreplaces the
ugly overlong headlines with text blocks.\r\n\r\nResolves
https://github.com/elastic/prodfiler/issues/3350","sha":"f4c9a33697310849ef94c2d53fddbfc908752e8b"}}]}]
BACKPORT-->

Co-authored-by: Joel Höner <joel@zyantific.com>
2023-05-13 11:55:07 -07:00
Kibana Machine
c77b43b78e
[8.8] Profiling: fix links in Add Data page (#157333) (#157397)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Profiling: fix links in Add Data page
(#157333)](https://github.com/elastic/kibana/pull/157333)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Gualazzi","email":"inge4pres@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-11T14:29:29Z","message":"Profiling:
fix links in Add Data page (#157333)\n\n## Summary\r\n\r\nAdjust
download links for Universal Profiling host-agent in the Add
Data\r\npage.\r\nThe links need to be updated because of a breaking
change in the\r\nprotocol.\r\n\r\nSigned-off-by: inge4pres
<francesco.gualazzi@elastic.co>","sha":"cec3ee91acd6bcbec9bacce5b671d85fb85c2244","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","backport","release_note:skip","ci:build-cloud-image","ci:cloud-deploy","ci:cloud-redeploy","v8.8.0","v8.9.0"],"number":157333,"url":"https://github.com/elastic/kibana/pull/157333","mergeCommit":{"message":"Profiling:
fix links in Add Data page (#157333)\n\n## Summary\r\n\r\nAdjust
download links for Universal Profiling host-agent in the Add
Data\r\npage.\r\nThe links need to be updated because of a breaking
change in the\r\nprotocol.\r\n\r\nSigned-off-by: inge4pres
<francesco.gualazzi@elastic.co>","sha":"cec3ee91acd6bcbec9bacce5b671d85fb85c2244"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157333","number":157333,"mergeCommit":{"message":"Profiling:
fix links in Add Data page (#157333)\n\n## Summary\r\n\r\nAdjust
download links for Universal Profiling host-agent in the Add
Data\r\npage.\r\nThe links need to be updated because of a breaking
change in the\r\nprotocol.\r\n\r\nSigned-off-by: inge4pres
<francesco.gualazzi@elastic.co>","sha":"cec3ee91acd6bcbec9bacce5b671d85fb85c2244"}}]}]
BACKPORT-->

Co-authored-by: Francesco Gualazzi <inge4pres@users.noreply.github.com>
2023-05-11 08:36:12 -07:00
Coen Warmer
88f4f8082a
[Synthetics][Ux][Uptime] Use Observability Page Template from Observability Shared (#154774)
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
2023-04-18 15:00:15 -07:00
Coen Warmer
c75863385d
Use Observability Page Template from Observability Shared in APM and Profiling (#154776)
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-18 11:03:44 +02:00
Cauê Marcondes
2225de0b4b
[Profiling] Adding upload symbols instructions to add data page (#154670)
<img width="1113" alt="Screenshot 2023-04-10 at 1 44 13 PM"
src="https://user-images.githubusercontent.com/55978943/230960393-9f2290d6-40d4-4ad6-a166-663b065e3c77.png">
2023-04-13 14:25:40 -07:00
Cauê Marcondes
a061f1d7b3
[Profiling] adding invalid license page (#154866) 2023-04-13 17:16:12 -04:00
Cauê Marcondes
2f001a2f8d
[Profiling] Space-specific feature privileges (#154734) 2023-04-11 20:35:48 -04:00
Cauê Marcondes
2f46929805
[Profiling] updating empty state page links. (#154678) 2023-04-11 20:35:18 -04:00
Cauê Marcondes
a0f8d910b7
[Profling] Adding symbols callout on frame information window (#154478)
This PR adds a callout on the Frame information window for each symbol
status and Storybook support.

`Symbolized`:
<img width="897" alt="Screenshot 2023-04-05 at 2 46 36 PM"
src="https://user-images.githubusercontent.com/55978943/230176122-ad495e1d-76aa-431c-a6a7-4f2f319625c9.png">

`Native language`:
<img width="901" alt="Screenshot 2023-04-05 at 2 46 24 PM"
src="https://user-images.githubusercontent.com/55978943/230176224-e247d57c-538b-4c35-8a74-dd0176ac0f0c.png">

`Interpreted language`:
<img width="893" alt="Screenshot 2023-04-05 at 2 46 16 PM"
src="https://user-images.githubusercontent.com/55978943/230176264-d2d9b72a-6048-4ba3-93af-b60f9ea04001.png">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-10 10:11:04 -07:00
Cauê Marcondes
5c759a1290
[Profiling] renaming CPU incl and CPU excl (#154560)
<img width="410" alt="Screenshot 2023-04-06 at 9 28 13 AM"
src="https://user-images.githubusercontent.com/55978943/230401728-fcdcb1ec-164e-4375-acae-12d3a4e2caaf.png">
<img width="610" alt="Screenshot 2023-04-06 at 9 28 23 AM"
src="https://user-images.githubusercontent.com/55978943/230401731-84a45fd2-bce2-4de8-8a3a-7f7fffa7f404.png">
<img width="295" alt="Screenshot 2023-04-06 at 9 38 57 AM"
src="https://user-images.githubusercontent.com/55978943/230401732-edb11b8d-c8fb-4401-a021-4a80a17830a4.png">
2023-04-10 11:50:11 -04:00
Cauê Marcondes
c00df762c2
[Profiling] Add Co2 and dollar cost columns and show more information action to functions table (#154097)
This PR adds:
- Annualized Co2 column
- Annualized dollar cost column
- Show more information action that opens the details of the selected
function in a flyout.
<img width="1569" alt="Screenshot 2023-03-30 at 3 33 12 PM"
src="https://user-images.githubusercontent.com/55978943/228944955-c0f3b7a4-6fa2-43fc-b388-35721f0ce256.png">
<img width="1585" alt="Screenshot 2023-03-30 at 3 33 22 PM"
src="https://user-images.githubusercontent.com/55978943/228944959-51cca82e-81f0-413d-a69e-0289bb62523e.png">
2023-03-31 09:09:54 -04:00
Cauê Marcondes
c9dde2fbb3
[Profiling] flamegraph improvements (#153598)
Adds Annualized Co2 and dollar cost in the tooltip
<img width="587" alt="Screenshot 2023-03-24 at 1 10 49 PM"
src="https://user-images.githubusercontent.com/55978943/227594284-65e6b581-31be-42a3-aa61-cd838d926eba.png">

In the Diff flamegraph:
<img width="580" alt="Screenshot 2023-03-24 at 1 10 33 PM"
src="https://user-images.githubusercontent.com/55978943/227594322-e041eed1-1360-47bd-99b6-6ead027497b5.png">

Removed `show more information` toggle and placed it inside the tooltip.
Also displays the details of a frame inside a flyout.


https://user-images.githubusercontent.com/55978943/227952323-38625615-d2fe-40d6-949b-32e3c1cdfce4.mov
2023-03-30 13:48:26 -04:00
Cauê Marcondes
b748721879
[Profiling] Functions improvements (#153873)
Emphasis the `Total sample estimate` using the EuiStat component. 

Replace `-/+` signs by `up/down` arrows

<img width="2595" alt="Screenshot 2023-03-28 at 10 13 33 AM"
src="https://user-images.githubusercontent.com/55978943/228269490-5f50c3bb-65ec-45cd-87af-17db0f1fe72e.png">
<img width="1450" alt="Screenshot 2023-03-28 at 10 21 12 AM"
src="https://user-images.githubusercontent.com/55978943/228269494-af6e43ad-afbc-4939-80d6-0d6bce6c4a95.png">
2023-03-30 09:57:41 -04:00
Cauê Marcondes
ba755f95e0
[Profiling] Click on series in stacked chart opens traces view (#153325)
In the Threads view when the user clicks on one of the stacked bar it
navigates to the Traces view filtering the result based on the category.


https://user-images.githubusercontent.com/55978943/226430014-0fbeaad8-6ecb-4e34-a841-926ee2c8ddb9.mov
2023-03-22 09:21:41 -04:00
Jason Stoltzfus
c339ca8394
Upgraded EUI to v76.0.0 (#152506)
👋 Hi all - the biggest breaking change of this PR is around two icon
type changes/renames.

1. ⚠️ **The  `alert` icon is now named `warning`**
- <img width="103" alt=""
src="https://user-images.githubusercontent.com/549407/223561599-8913e88c-676f-47cd-aaed-81b64783bd81.png"
align="middle">
- This change should have been automatically converted on your behalf by
the EUI team, **but if for some reason** we missed making this
conversion in this PR and your icon(s) are now broken, please ping us or
let us know in this PR (or fix yourself after this PR merges).
- In some cases, teams were using this icon for error messages,
alongside the `danger` color. In those cases, we opinionatedly changed
those icon usages to the new `error` icon instead of using the old
alert/warning icon.

2. 🛑 **The `crossInACircleFilled` icon has been removed, and a new
`error` icon added**
- <img width="84" alt=""
src="https://user-images.githubusercontent.com/549407/223561892-4406bdf6-1a55-49ac-85ad-3a11eb7c090d.png"
align="middle">
- The conversion for this breaking change was not straightforward. This
was the path we used to determine what to change `crossInACircleFilled`
usages to:
- If the icon was associated with errors or error messages, we changed
it to the new `error` icon.
- If a "delete" action was associated with this icon, we changed it to
the `trash` icon instead.
- If a "clear" action was associated with this icon, we changed it to
just the `cross` icon, or in some cases `minusInCircleFilled` (if used
alongside `plusInCircleFilled`).
- Again, if we made a mistake during this conversion or missed your
plugin, please feel free to ping us.

## Summary

`eui@75.1.2`  `eui@76.0.2`

## [`76.0.2`](https://github.com/elastic/eui/tree/v76.0.2)

**Bug fixes**

- Added a legacy `alert` alias for the `warning` `EuiIcon` type
([#6640](https://github.com/elastic/eui/pull/6640))

## [`76.0.1`](https://github.com/elastic/eui/tree/v76.0.1)

**Bug fixes**

- Fixed broken icons on all `isInvalid` form controls
([#6629](https://github.com/elastic/eui/pull/6629))

## [`76.0.0`](https://github.com/elastic/eui/tree/v76.0.0)

- Added `pivot` glyph to `EuiIcon`
([#6605](https://github.com/elastic/eui/pull/6605))
- Added the `displayHeaderCellProps` API to `EuiDataGrid`'s columns,
which allows passing custom props directly to column header cells
([#6609](https://github.com/elastic/eui/pull/6609))
- Added the new `headerCellProps`/`footerCellProps` APIs to
`EuiDataGrid`'s control columns, which allows passing custom props
directly to control column header or footer cells
([#6609](https://github.com/elastic/eui/pull/6609))
- Added a new `footerCellRender` API to `EuiDataGrid`'s control columns,
which allows completely customizing control column rendering (previously
rendered an empty cell)
([#6609](https://github.com/elastic/eui/pull/6609))
- Updated the styling of nested ordered lists in `EuiText` to align with
GitHub's list style, which is a popular format used in Markdown or MDX
formatting ([#6615](https://github.com/elastic/eui/pull/6615))
- Added a margin-bottom property exclusively to the direct child `ul`
and `ol` elements of the `EuiText` component
([#6615](https://github.com/elastic/eui/pull/6615))
- Fix issue with badges appearing within an `EuiBadgeGroup`, where the
CSS rule to override the `margin-inline-start` was not being applied
correctly due to the order of appearance in the CSS rules
([#6618](https://github.com/elastic/eui/pull/6618))

**Bug fixes**

- Fixed `EuiDataGrid` footer control columns rendering with cell
expansion popovers when they should not have been
([#6609](https://github.com/elastic/eui/pull/6609))
- Fixed an `EuiSkipLink` bug where main content loading in
progressively/dynamically after the skip link rendered was not being
correctly focused ([#6613](https://github.com/elastic/eui/pull/6613))

**Breaking changes**

- Renamed `EuiIcon`'s `alert` to `warning`
([#6608](https://github.com/elastic/eui/pull/6608))
- Removed `EuiIcon`'s `crossInACircleFilled` in favor of `error`
([#6608](https://github.com/elastic/eui/pull/6608))

---------

Co-authored-by: Davey Holler <daveyholler@hey.com>
Co-authored-by: Constance Chen <constance.chen@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jon <jon@elastic.co>
2023-03-14 14:27:40 -05:00
Cauê Marcondes
58c918a061
[Profiling][Flamegraps] persistent normalization mode (#153116)
https://user-images.githubusercontent.com/55978943/224367585-a6623d40-951b-418a-8615-2c3de46e4e6e.mov

Saves the normalization option selected and keeps it when changing the
comparison mode.

I also refactored the Flamegraph component extracting some components
away to simplify.
2023-03-10 20:52:57 -05:00
Cauê Marcondes
e37b6f65b0
[Profiling] Adding tabs back (#152918)
The tabs were accidentally removed on this PR
c184ebf83a (diff-2ec64b4bf09370503d267466862b40dce88c2a7b8d69a40d99c879103bcf72d4R56)

Adding it back.
<img width="475" alt="Screenshot 2023-03-08 at 10 00 25 AM"
src="https://user-images.githubusercontent.com/55978943/223748524-1a50e748-81b9-4c5b-b859-4a4966fe1f4f.png">
<img width="656" alt="Screenshot 2023-03-08 at 10 00 30 AM"
src="https://user-images.githubusercontent.com/55978943/223748528-f46a686f-18d0-4847-840e-f1be7dd50c38.png">


One more reason why we must add e2e test ASAP. 
cc: @sboomsma
2023-03-08 13:10:10 -05:00
Cauê Marcondes
8b66119431
[Stacktraces] Syncing color in the main chart and in the subchart (#152832)
closes https://github.com/elastic/prodfiler/issues/3069


https://user-images.githubusercontent.com/55978943/223480200-036f8d2c-5c08-48cc-a205-47ae1eb8e803.mov

I also refactored the components a bit and wrote a unit test.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-03-08 08:54:05 -05:00
Boris Kirov
c184ebf83a
[Profiling] Adding a feedback link in Profiling (#151436)
## Summary

Adding a Feedback link inside the Profiling app to allow users to
provide feedback.


![image](https://user-images.githubusercontent.com/13353203/219363745-e0a817df-917a-48bc-8349-cfa8cdca9b60.png)


![image](https://user-images.githubusercontent.com/13353203/219363809-0dc3cbca-9a2e-4d75-a755-c899307cd590.png)



Related to and closes:
https://github.com/elastic/prodfiler/issues/2959
2023-03-07 09:32:20 +01:00
Cauê Marcondes
0dacbe7570
[Profiling] Blank page when an invalid query string is given and when… (#152493)
closes https://github.com/elastic/prodfiler/issues/3049

404:
<img width="1390" alt="Screenshot 2023-03-01 at 1 24 14 PM"
src="https://user-images.githubusercontent.com/55978943/222230441-d670fe14-d372-456e-a98e-0184fb2f68e7.png">

Error boundary:
<img width="1584" alt="Screenshot 2023-03-01 at 1 24 41 PM"
src="https://user-images.githubusercontent.com/55978943/222230511-97997995-cae2-4c8a-906f-2db9bea191af.png">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-03-02 10:45:37 -05:00
Joseph Crail
ff02c4e124
[Profiling] Normalize samples by time for differential flamegraph (#152158)
This PR appropriately scales the samples in the differential
flamegraph's tooltip when time-normalized mode is selected.

Fixes https://github.com/elastic/prodfiler/issues/3038

### Notes

* Respective values for the normalization menu and differential
flamegraph are now defined in the parent view so that both elements
remain in sync. Previously only the normalization menu had the scaling
factors for time-normalized mode, thus, the tooltip in the differential
flamegraph was not accurate.
* The prior scaling factors for scale-normalized mode are remembered as
long as a user is on the differential flamegraph. Thus, a user can
update the time ranges, the format (Abs vs Rel), and the normalization
mode without losing their previously chosen scale-normalized values.
* The time-normalized scaling factors continue to remain immutable.
* Due to artifacts related to floating-point division, the adjusted
samples may not be whole integers.
2023-02-27 10:29:19 +01:00
Joseph Crail
78ba92613f
[Profiling] Fix missing comparison samples (#152057)
This PR fixes the bug in which the tooltip doesn't show the number of
comparison samples after opening the differential flamegraph.

Fixes https://github.com/elastic/prodfiler/issues/3035
2023-02-24 09:19:38 +01:00
Joseph Crail
44241bc6b3
[Profiling] Fix normalization when using scale factor mode (#151957)
This PR fixes a bug where the flamegraph tooltip shows the unscaled
number of samples when using a scale factor != 1.

Fixes https://github.com/elastic/prodfiler/issues/3013
2023-02-23 10:37:37 +01:00
Francesco Gualazzi
26bd714af8
profiling: update copy in setup button (#151828)
Small update to copy in the Universal Profiling button.

Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
2023-02-22 11:23:39 +01:00
Joseph Crail
0764bd1b7d
[Profiling] Restore show information window (#151538)
## Summary

This PR returns the show information window to the flamegraph view.

We also added a minor UI improvement to keep the flamegraph view
visually synced up with the differential flamegraph view.

Fixes https://github.com/elastic/prodfiler/issues/3009

### Screenshots

The "Show information window" toggle is visible and disabled.

![image](https://user-images.githubusercontent.com/6038/219519101-5e8a9797-faa4-4ffe-ab72-1281df7759dc.png)

The "Show information window" toggle is visible and enabled.

![image](https://user-images.githubusercontent.com/6038/219519115-8b9b5539-82f5-4eb9-b667-4b283e6f39d8.png)
2023-02-21 16:46:00 -08:00
renovate[bot]
3651e5c072
Update dependency @elastic/charts to v53 (main) (#150407) 2023-02-21 18:00:40 +01:00
Boris Kirov
d5674c70af
Update tooltip diff flamegraph (#151625)
## Summary

We recently reviewed the final copy for the `Normalize by` menu in the
Diff Flamegraph with the writing team and we have the final copy that we
will use there. This PR is aiming to update that.

Related to:
https://github.com/elastic/kibana/pull/151437

---------

Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co>
2023-02-21 09:54:00 +01:00
Boris Kirov
ff061ff984
Update tooltip diff flamegraph (#151437)
## Summary

Updated the copy in the tooltip based on our discussion in this ticket:
https://github.com/elastic/prodfiler/issues/3001
2023-02-16 09:08:42 -07:00
Francesco Gualazzi
560c3b96f8
profiling: fix setup page and instructions (#150885)
Resolves https://github.com/elastic/prodfiler/issues/2961.
We update the setup information text instructions to add data for
Universal Profiling Beta.


Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Co-authored-by: boriskirov <boris.kirov@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-02-15 11:50:29 +01:00
Tim Rühsen
1526749ba4
[Profiling] Fix TopN diff functions title text (#151031)
Fixes the title texts in the differential TopN functions view (turning
'flamegraph' into 'functions').

Fixes https://github.com/elastic/prodfiler/issues/3000
2023-02-13 11:15:40 -07:00
Dario Gieselaar
1854c310a3
[Profiling] Improved differential flamegraph controls (#150254)
Co-authored-by: boriskirov <boris.kirov@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Closes https://github.com/elastic/prodfiler/issues/2639
2023-02-07 06:54:17 -07:00
Dario Gieselaar
807b402f0b
[Profling] Single-click setup from Kibana (#148959)
Co-authored-by: inge4pres <francesco.gualazzi@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Tim Rühsen <tim.ruehsen@gmx.de>
Co-authored-by: Francesco Gualazzi <inge4pres@users.noreply.github.com>
Closes https://github.com/elastic/prodfiler/issues/2884
2023-02-07 06:10:30 -07:00
Dario Gieselaar
08d85554b9
[Profiling] Flamegraph legend (#147910)
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Closes https://github.com/elastic/prodfiler/issues/2810
2023-01-16 06:45:54 -07:00
Dario Gieselaar
4e0a0a5d4f
[Profiling] change order of tabs (#147518)
Closes https://github.com/elastic/prodfiler/issues/2811
2022-12-21 12:44:40 +01:00
Dario Gieselaar
d01b5de252
[Profiling] Show values of highlighted sample in TopN chart (#147431)
Closes https://github.com/elastic/prodfiler/issues/2842
2022-12-21 11:38:42 +01:00
Dario Gieselaar
f2fcb1c5af
[Profiling] Remove link to 'Other' bucket (#147523)
Closes https://github.com/elastic/prodfiler/issues/2739
2022-12-14 08:57:32 -07:00
Tim Rühsen
e58e6976fa
[Profiling] Fix ordering of CPU incl. subfunctions in TopN Functions (#145013)
Kibana client fetches all functions from the server.
Kibana client only shows the Top 100 functions, dependent on column sort
order.

Fixes https://github.com/elastic/prodfiler/issues/2723
2022-11-10 16:53:15 -08:00
Tim Rühsen
f7758e0ada
[Profiling] Improve the differential flamegraph tooltip (#144895)
Improve the root tooltip for the differential flamegraph:
- remove the superfluous CPU usages (it's always 100% inclusive and 0%
exclusive)
 - add the change rate of the samples as colored text

**Before**

![Screenshot_20221109_130516](https://user-images.githubusercontent.com/2087964/200828112-045196e2-88cb-4f5c-906a-4e61d73be9c7.png)
**After**

![Screenshot_20221109_125746](https://user-images.githubusercontent.com/2087964/200828152-cb2f0cc7-28cc-4e54-800f-d5c9df0448c4.png)

Improve the non-root tooltips for the differential flamegraph:
 - remove the 'no change' label if there is no change
 - add the change rate of the samples as colored text

**Before**

![Screenshot_20221109_130600](https://user-images.githubusercontent.com/2087964/200828108-c6c78866-4aff-4617-ac0f-e78aeba78a54.png)
**After**

![Screenshot_20221109_125916](https://user-images.githubusercontent.com/2087964/200828149-8caac941-3c58-4389-ac7f-bda2e687faaa.png)

Fixes https://github.com/elastic/prodfiler/issues/2714

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joseph Crail <joseph.crail@elastic.co>
2022-11-09 11:58:35 -08:00
Thomas Dullien
0a5050bd37
[Profiling] Small improvements to the differential function view (#144824)
Improved the visualization of data in profiling by showing more details
and using more nicely formatted numbers.

Fixes https://github.com/elastic/prodfiler/issues/2772

Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co>
2022-11-09 11:27:36 -07:00
Rachel Shen
244ef02ff1
[Shared UX] Fix redirect app links fill vertical space (#141656) 2022-11-08 15:46:05 -07:00
Tim Rühsen
199eb170f9
[Profiling] For diff functions add change of total samples (#144724) 2022-11-08 03:51:18 -07:00
Luca Wintergerst
003bbf7f2d
[Profiling] allow negative numbers in formatter (#143420)
* Update as_number.ts

allow negative numbers in formatter. Currently all negative values get truncated to `~0.00`
closes https://github.com/elastic/prodfiler/issues/2707

* Update as_number.ts

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Update as_number.ts

change negative condition to abs

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co>
2022-10-25 02:56:55 -07:00
Stratoula Kalafateli
411a306216
[Unified search] Cleanups the showQueryBar flag (#143270)
* [Unified search] Cleanups the showQueryBar flag that is not used anymore

* Fix add filter story error
2022-10-18 11:24:17 +03:00
Joseph Crail
39811a3bd5
[Profiling] Fix UI discrepancies in frame information window (#142812)
* Fix UI discrepancies in frame information window

* Fix comment

* Use source line instead

This matches with the value used in the flamegraph labels.
2022-10-06 12:50:21 -07:00
Tim Rühsen
ba306be80d
[Profiling] Avoid line-break of samples (#142322)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-10-06 18:44:45 +02:00
Dario Gieselaar
c05190e516
[Profiling] Auto-abort requests (#142750) 2022-10-06 09:17:14 +02:00
Joseph Crail
c888aca9b4
[Profiling] Move additional flamegraph calculations into UI (#142415)
* Remove total and sampled traces from API

* Remove Samples array from flamegraph API

These values are redundant with CountInclusive so could be removed
without issue.

* Remove totalCount and eventsIndex

These values are no longer needed.

* Remove samples from callee tree

* Refactor columnar view model into separate file

* Add more lazy-loaded flamegraph calculations

* Fix spacing in frame label

* Remove frame information API

* Improve test coverage

* Fix type error

* Replace fnv-plus with custom 64-bit FNV1-a

* Add exceptions for linting errors

* Add workaround for frame type truncation bug

* Replace prior workaround for truncation bug

This fix supercedes the prior workaround and addresses the truncation at
its source.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-10-05 06:10:38 -07:00