Commit graph

63385 commits

Author SHA1 Message Date
Kibana Machine
97610fbc3e
[8.8] FTR: delete .kibana mappings from archives to avoid recreating SO indexes (#159957) (#160435)
# Backport

This will backport the following commits from `main` to `8.8`:
- [FTR: delete .kibana mappings from archives to avoid recreating SO
indexes (#159957)](https://github.com/elastic/kibana/pull/159957)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-06-23T16:04:11Z","message":"FTR:
delete .kibana mappings from archives to avoid recreating SO indexes
(#159957)\n\n## Summary\r\n\r\nRelated to #159582\r\n\r\nTo better
understand the PR, we need to have a look at
`esArchiver.load`\r\nfunction and how it handles `mappings.json`:\r\n-
It processes the file and if it finds saved object index
(e.g.\r\n`.kibana`), it will delete all SO indexes
(.kibana,\r\n.kibana_task_manager, .kibana_alerting_cases, etc.) created
on Kibana\r\nstart. Then esArchiver will re-create all indexes according
to defined\r\nmappings.\r\n\r\nIn order to keep our tests relevant to
the latest code changes, it is\r\ngood to avoid re-creating SO indexes
and use \"official\" ones whenever it\r\nis possible. This PR
removes/cleans `mappings.json` files where it seems\r\nreasonable. I
also deleted few not used archives:\r\n-
es_archiver/saved_objects/ui_counters\r\n-
es_archiver/saved_objects/usage_counters\r\n-
security_solution_cypress/es_archives/empty_kibana","sha":"88871faf60ec5a62c4aea48911883a6d7f937777","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","v8.8.2","v8.10.0"],"number":159957,"url":"https://github.com/elastic/kibana/pull/159957","mergeCommit":{"message":"FTR:
delete .kibana mappings from archives to avoid recreating SO indexes
(#159957)\n\n## Summary\r\n\r\nRelated to #159582\r\n\r\nTo better
understand the PR, we need to have a look at
`esArchiver.load`\r\nfunction and how it handles `mappings.json`:\r\n-
It processes the file and if it finds saved object index
(e.g.\r\n`.kibana`), it will delete all SO indexes
(.kibana,\r\n.kibana_task_manager, .kibana_alerting_cases, etc.) created
on Kibana\r\nstart. Then esArchiver will re-create all indexes according
to defined\r\nmappings.\r\n\r\nIn order to keep our tests relevant to
the latest code changes, it is\r\ngood to avoid re-creating SO indexes
and use \"official\" ones whenever it\r\nis possible. This PR
removes/cleans `mappings.json` files where it seems\r\nreasonable. I
also deleted few not used archives:\r\n-
es_archiver/saved_objects/ui_counters\r\n-
es_archiver/saved_objects/usage_counters\r\n-
security_solution_cypress/es_archives/empty_kibana","sha":"88871faf60ec5a62c4aea48911883a6d7f937777"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.8"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159957","number":159957,"mergeCommit":{"message":"FTR:
delete .kibana mappings from archives to avoid recreating SO indexes
(#159957)\n\n## Summary\r\n\r\nRelated to #159582\r\n\r\nTo better
understand the PR, we need to have a look at
`esArchiver.load`\r\nfunction and how it handles `mappings.json`:\r\n-
It processes the file and if it finds saved object index
(e.g.\r\n`.kibana`), it will delete all SO indexes
(.kibana,\r\n.kibana_task_manager, .kibana_alerting_cases, etc.) created
on Kibana\r\nstart. Then esArchiver will re-create all indexes according
to defined\r\nmappings.\r\n\r\nIn order to keep our tests relevant to
the latest code changes, it is\r\ngood to avoid re-creating SO indexes
and use \"official\" ones whenever it\r\nis possible. This PR
removes/cleans `mappings.json` files where it seems\r\nreasonable. I
also deleted few not used archives:\r\n-
es_archiver/saved_objects/ui_counters\r\n-
es_archiver/saved_objects/usage_counters\r\n-
security_solution_cypress/es_archives/empty_kibana","sha":"88871faf60ec5a62c4aea48911883a6d7f937777"}}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
2023-06-23 10:42:54 -07:00
Hannah Mudge
03eddedbc7
[Dashboard] Re-skip flaky flyout tests (#160427)
Closes https://github.com/elastic/kibana/issues/159933
Closes https://github.com/elastic/kibana/issues/159932
Closes https://github.com/elastic/kibana/issues/159931

## Summary

https://github.com/elastic/kibana/pull/160187 didn't work as a fix, so
re-skipping these tests **just for 8.8** as described
[here](https://github.com/elastic/kibana/issues/159931#issuecomment-1602793541)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2023-06-23 09:23:17 -07:00
James Gowdy
913ea518cc
[ML] [8.8] fix saved object sync check for jobs in different space (#160402)
Manual backport of https://github.com/elastic/kibana/pull/160266
2023-06-23 15:21:30 +01:00
Kibana Machine
4298c3ce94
[8.8] Disable the welcome screen in newsfeed ftr tests (#160210) (#160301)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Disable the welcome screen in newsfeed ftr tests
(#160210)](https://github.com/elastic/kibana/pull/160210)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Christiane (Tina)
Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2023-06-22T16:15:26Z","message":"Disable
the welcome screen in newsfeed ftr tests (#160210)\n\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"73f070447cf088649e6a34f395610d962a21b01c","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","release_note:skip","Feature:Newsfeed","backport:prev-minor","v8.8.0","v8.9.0","v8.10.0"],"number":160210,"url":"https://github.com/elastic/kibana/pull/160210","mergeCommit":{"message":"Disable
the welcome screen in newsfeed ftr tests (#160210)\n\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"73f070447cf088649e6a34f395610d962a21b01c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.9"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160210","number":160210,"mergeCommit":{"message":"Disable
the welcome screen in newsfeed ftr tests (#160210)\n\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"73f070447cf088649e6a34f395610d962a21b01c"}}]}]
BACKPORT-->

Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
2023-06-22 10:27:24 -07:00
Kibana Machine
3a08f5a8fa
[8.8] [ML] Fix not blocking forced downgrades/installation if cannot delete indices (#159814) (#160089)
Co-authored-by: Quynh Nguyen (Quinn) <43350163+qn895@users.noreply.github.com>
fix",":ml","Team:Fleet","v8.9.0","v8.8.2"],"number":159814,"url":"https://github.com/elastic/kibana/pull/159814","mergeCommit":{"message":"[ML]
2023-06-22 09:27:30 -07:00
Jatin Kathuria
5df083d62f
[8.8] [Security Solution] [Fix] [Performance] Alert Page Controls should query only from Alert Index. (#157286) (#160138)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] [Fix] [Performance] Alert Page Controls should
query only from Alert Index.
(#157286)](https://github.com/elastic/kibana/pull/157286)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-06-21T12:21:16Z","message":"[Security
Solution] [Fix] [Performance] Alert Page Controls should query only from
Alert Index. (#157286)\n\n## Summary\r\n\r\nHandles :
#157217\r\n\r\n\r\n|Before|After|\r\n|---|---|\r\n|
<video\r\nsrc=\"aa892faf-8055-46e0-b23b-87061ecef67f\"\r\n/>
|
<video\r\nsrc=\"2f392ea4-cfc5-4759-96c7-94561f60c3f4\"\r\n/>
|","sha":"ac5207cca96db362ed31387e16e5b6849167f565","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting:Investigations","backport:prev-MAJOR","v8.9.0"],"number":157286,"url":"https://github.com/elastic/kibana/pull/157286","mergeCommit":{"message":"[Security
Solution] [Fix] [Performance] Alert Page Controls should query only from
Alert Index. (#157286)\n\n## Summary\r\n\r\nHandles :
#157217\r\n\r\n\r\n|Before|After|\r\n|---|---|\r\n|
<video\r\nsrc=\"aa892faf-8055-46e0-b23b-87061ecef67f\"\r\n/>
|
<video\r\nsrc=\"2f392ea4-cfc5-4759-96c7-94561f60c3f4\"\r\n/>
|","sha":"ac5207cca96db362ed31387e16e5b6849167f565"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157286","number":157286,"mergeCommit":{"message":"[Security
Solution] [Fix] [Performance] Alert Page Controls should query only from
Alert Index. (#157286)\n\n## Summary\r\n\r\nHandles :
#157217\r\n\r\n\r\n|Before|After|\r\n|---|---|\r\n|
<video\r\nsrc=\"aa892faf-8055-46e0-b23b-87061ecef67f\"\r\n/>
|
<video\r\nsrc=\"2f392ea4-cfc5-4759-96c7-94561f60c3f4\"\r\n/>
|","sha":"ac5207cca96db362ed31387e16e5b6849167f565"}}]}] BACKPORT-->
2023-06-22 08:54:53 -07:00
Kibana Machine
3888dc0309
[8.8] [Fleet] Datastreams api do not query warm nodes anymore (#160234) (#160254)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Fleet] Datastreams api do not query warm nodes anymore
(#160234)](https://github.com/elastic/kibana/pull/160234)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cristina
Amico","email":"criamico@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-22T10:38:50Z","message":"[Fleet]
Datastreams api do not query warm nodes anymore (#160234)\n\nFixes
https://github.com/elastic/kibana/issues/159977\r\n\r\n##
Summary\r\n\r\nIn https://github.com/elastic/kibana/pull/159253/files we
removed cold\r\nnodes from datastreams apis because of performance
issues. Now we are\r\nalso removing warm nodes as they were still
causing high
load.","sha":"924da11c89955b6c5e7acf6bbb8c6dcd5f2f499e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.9.0","v8.8.2"],"number":160234,"url":"https://github.com/elastic/kibana/pull/160234","mergeCommit":{"message":"[Fleet]
Datastreams api do not query warm nodes anymore (#160234)\n\nFixes
https://github.com/elastic/kibana/issues/159977\r\n\r\n##
Summary\r\n\r\nIn https://github.com/elastic/kibana/pull/159253/files we
removed cold\r\nnodes from datastreams apis because of performance
issues. Now we are\r\nalso removing warm nodes as they were still
causing high
load.","sha":"924da11c89955b6c5e7acf6bbb8c6dcd5f2f499e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160234","number":160234,"mergeCommit":{"message":"[Fleet]
Datastreams api do not query warm nodes anymore (#160234)\n\nFixes
https://github.com/elastic/kibana/issues/159977\r\n\r\n##
Summary\r\n\r\nIn https://github.com/elastic/kibana/pull/159253/files we
removed cold\r\nnodes from datastreams apis because of performance
issues. Now we are\r\nalso removing warm nodes as they were still
causing high
load.","sha":"924da11c89955b6c5e7acf6bbb8c6dcd5f2f499e"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cristina Amico <criamico@users.noreply.github.com>
2023-06-22 06:55:04 -07:00
Kibana Machine
db8521641e
[8.8] [AO] Fix issue with alert summary widget refresh on the Alerts page (#160159) (#160233)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[AO] Fix issue with alert summary widget refresh on the Alerts page
(#160159)](https://github.com/elastic/kibana/pull/160159)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-06-22T08:36:41Z","message":"[AO]
Fix issue with alert summary widget refresh on the Alerts page
(#160159)\n\nFixes #157245\r\n\r\n## Summary\r\n\r\nThis PR updates the
absolute time range when the refresh button is\r\nclicked.\r\n\r\n## 🧪
How to test\r\n- On the Alerts page, click on refresh and check the time
range of\r\n`_alert_summary` API call, it should be updated with each
refresh\r\n\r\n\r\n![image](0522d770-6cf5-4af7-8c42-bb508e614164)","sha":"7f906bd0c1bddba64e23fdcdfeb61304542fa9c8","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:
Actionable
Observability","backport:prev-minor","v8.9.0"],"number":160159,"url":"https://github.com/elastic/kibana/pull/160159","mergeCommit":{"message":"[AO]
Fix issue with alert summary widget refresh on the Alerts page
(#160159)\n\nFixes #157245\r\n\r\n## Summary\r\n\r\nThis PR updates the
absolute time range when the refresh button is\r\nclicked.\r\n\r\n## 🧪
How to test\r\n- On the Alerts page, click on refresh and check the time
range of\r\n`_alert_summary` API call, it should be updated with each
refresh\r\n\r\n\r\n![image](0522d770-6cf5-4af7-8c42-bb508e614164)","sha":"7f906bd0c1bddba64e23fdcdfeb61304542fa9c8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160159","number":160159,"mergeCommit":{"message":"[AO]
Fix issue with alert summary widget refresh on the Alerts page
(#160159)\n\nFixes #157245\r\n\r\n## Summary\r\n\r\nThis PR updates the
absolute time range when the refresh button is\r\nclicked.\r\n\r\n## 🧪
How to test\r\n- On the Alerts page, click on refresh and check the time
range of\r\n`_alert_summary` API call, it should be updated with each
refresh\r\n\r\n\r\n![image](0522d770-6cf5-4af7-8c42-bb508e614164)","sha":"7f906bd0c1bddba64e23fdcdfeb61304542fa9c8"}}]}]
BACKPORT-->

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
2023-06-22 02:47:06 -07:00
Kibana Machine
d0868c4165
[8.8] Upgrade Node.js to 16.20.1 (#160177) (#160220)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Upgrade Node.js to 16.20.1
(#160177)](https://github.com/elastic/kibana/pull/160177)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2023-06-21T21:57:55Z","message":"Upgrade
Node.js to 16.20.1
(#160177)\n\nhttps://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V16.md#16.20.1","sha":"b8c36e11b1631c2db49b1358da0ac824ed128fc6","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.9.0"],"number":160177,"url":"https://github.com/elastic/kibana/pull/160177","mergeCommit":{"message":"Upgrade
Node.js to 16.20.1
(#160177)\n\nhttps://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V16.md#16.20.1","sha":"b8c36e11b1631c2db49b1358da0ac824ed128fc6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160177","number":160177,"mergeCommit":{"message":"Upgrade
Node.js to 16.20.1
(#160177)\n\nhttps://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V16.md#16.20.1","sha":"b8c36e11b1631c2db49b1358da0ac824ed128fc6"}}]}]
BACKPORT-->

Co-authored-by: Jon <jon@elastic.co>
2023-06-21 16:44:04 -07:00
Hannah Mudge
dd81f57b7a
[Dashboard] Unskip flaky "Add from library" flyout tests (#160187)
Closes https://github.com/elastic/kibana/issues/158529
Closes https://github.com/elastic/kibana/issues/159931
Closes https://github.com/elastic/kibana/issues/159932

## Summary

Now that https://github.com/elastic/kibana/pull/159943 is
[backported](https://github.com/elastic/kibana/pull/160186) to 8.8,
these tests should no longer be flaky on 8.8. Unskipping the tests.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2023-06-21 12:37:48 -06:00
Kibana Machine
58fdf1612e
[8.8] [Flaky Tests] Switch to ensureAllClosed for dashboard add panel (#159943) (#160186)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Flaky Tests] Switch to ensureAllClosed for dashboard add panel
(#159943)](https://github.com/elastic/kibana/pull/159943)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Devon
Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2023-06-21T16:00:10Z","message":"[Flaky
Tests] Switch to ensureAllClosed for dashboard add panel
(#159943)\n\nSimple fix for some flaky
tests.","sha":"25ebbb67c1d3c173214405a5440a27442f4332c0","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","Team:Presentation","loe:hours","release_note:skip","impact:high","backport:prev-minor","v8.9.0"],"number":159943,"url":"https://github.com/elastic/kibana/pull/159943","mergeCommit":{"message":"[Flaky
Tests] Switch to ensureAllClosed for dashboard add panel
(#159943)\n\nSimple fix for some flaky
tests.","sha":"25ebbb67c1d3c173214405a5440a27442f4332c0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159943","number":159943,"mergeCommit":{"message":"[Flaky
Tests] Switch to ensureAllClosed for dashboard add panel
(#159943)\n\nSimple fix for some flaky
tests.","sha":"25ebbb67c1d3c173214405a5440a27442f4332c0"}}]}]
BACKPORT-->

Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
2023-06-21 11:31:15 -07:00
Kibana Machine
144056ef08
[8.8] [Lens] small drag and drop visual fixes (#159651) (#160172)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Lens] small drag and drop visual fixes
(#159651)](https://github.com/elastic/kibana/pull/159651)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-21T16:08:13Z","message":"[Lens]
small drag and drop visual fixes (#159651)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/159572\r\n\r\n1. The dimension
element should be invisible when being moved - fixed
by\r\n`.domDragDrop-isHidden` css below `.domDragDrop--isDragStarted`
that was\r\noverwriting opacity.\r\n\r\nbefore:\r\n<img width=\"508\"
alt=\"Screenshot 2023-06-14 at 09 45
23\"\r\nsrc=\"96dcd98e-3b71-4675-8e0f-1617cfacbd2d\">\r\nafter:\r\n<img
width=\"508\" alt=\"Screenshot 2023-06-14 at 10 01
08\"\r\nsrc=\"f3b9de10-a2e5-4936-9695-245a57a9a8d4\">\r\n\r\n\r\n\r\n2.
When navigating with keyboard, the margin of the element that
was\r\nmoving was slightly off - fixed by changing the
constant\r\n`REORDER_ITEM_MARGIN` value to 16. Not sure if we use this
package\r\nsomewhere else and I should also test
@jughosta?\r\n\r\nbefore:\r\n<img width=\"436\" alt=\"Screenshot
2023-06-14 at 09 45
38\"\r\nsrc=\"b6e3ad6e-fc6f-4c7f-850e-d3a4d8cf4775\">\r\nafter:
\r\n<img width=\"405\" alt=\"Screenshot 2023-06-14 at 10 01
16\"\r\nsrc=\"4b850ca2-64d2-4c2a-a313-a7c10434674a\">\r\n\r\n\r\n\r\n3.
When navigating with keyboard but not reordering, the ghost
element\r\nwas covering completely the element we would drop into. I
fixed it by\r\nchanging the translation values. I think that's not
expected? Or is this\r\nintentional?\r\nbefore:\r\n<img width=\"410\"
alt=\"Screenshot 2023-06-14 at 09 45
47\"\r\nsrc=\"60296878-ca52-4d0c-bb49-5a84503d48ac\">\r\nafter:\r\n<img
width=\"436\" alt=\"Screenshot 2023-06-14 at 10 01
24\"\r\nsrc=\"c050fea1-10b2-4a72-95d3-fbfe920b9c96\">\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"293a70b655f733f73c8b021e88f69bc666f66fc9","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.9.0"],"number":159651,"url":"https://github.com/elastic/kibana/pull/159651","mergeCommit":{"message":"[Lens]
small drag and drop visual fixes (#159651)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/159572\r\n\r\n1. The dimension
element should be invisible when being moved - fixed
by\r\n`.domDragDrop-isHidden` css below `.domDragDrop--isDragStarted`
that was\r\noverwriting opacity.\r\n\r\nbefore:\r\n<img width=\"508\"
alt=\"Screenshot 2023-06-14 at 09 45
23\"\r\nsrc=\"96dcd98e-3b71-4675-8e0f-1617cfacbd2d\">\r\nafter:\r\n<img
width=\"508\" alt=\"Screenshot 2023-06-14 at 10 01
08\"\r\nsrc=\"f3b9de10-a2e5-4936-9695-245a57a9a8d4\">\r\n\r\n\r\n\r\n2.
When navigating with keyboard, the margin of the element that
was\r\nmoving was slightly off - fixed by changing the
constant\r\n`REORDER_ITEM_MARGIN` value to 16. Not sure if we use this
package\r\nsomewhere else and I should also test
@jughosta?\r\n\r\nbefore:\r\n<img width=\"436\" alt=\"Screenshot
2023-06-14 at 09 45
38\"\r\nsrc=\"b6e3ad6e-fc6f-4c7f-850e-d3a4d8cf4775\">\r\nafter:
\r\n<img width=\"405\" alt=\"Screenshot 2023-06-14 at 10 01
16\"\r\nsrc=\"4b850ca2-64d2-4c2a-a313-a7c10434674a\">\r\n\r\n\r\n\r\n3.
When navigating with keyboard but not reordering, the ghost
element\r\nwas covering completely the element we would drop into. I
fixed it by\r\nchanging the translation values. I think that's not
expected? Or is this\r\nintentional?\r\nbefore:\r\n<img width=\"410\"
alt=\"Screenshot 2023-06-14 at 09 45
47\"\r\nsrc=\"60296878-ca52-4d0c-bb49-5a84503d48ac\">\r\nafter:\r\n<img
width=\"436\" alt=\"Screenshot 2023-06-14 at 10 01
24\"\r\nsrc=\"c050fea1-10b2-4a72-95d3-fbfe920b9c96\">\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"293a70b655f733f73c8b021e88f69bc666f66fc9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159651","number":159651,"mergeCommit":{"message":"[Lens]
small drag and drop visual fixes (#159651)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/159572\r\n\r\n1. The dimension
element should be invisible when being moved - fixed
by\r\n`.domDragDrop-isHidden` css below `.domDragDrop--isDragStarted`
that was\r\noverwriting opacity.\r\n\r\nbefore:\r\n<img width=\"508\"
alt=\"Screenshot 2023-06-14 at 09 45
23\"\r\nsrc=\"96dcd98e-3b71-4675-8e0f-1617cfacbd2d\">\r\nafter:\r\n<img
width=\"508\" alt=\"Screenshot 2023-06-14 at 10 01
08\"\r\nsrc=\"f3b9de10-a2e5-4936-9695-245a57a9a8d4\">\r\n\r\n\r\n\r\n2.
When navigating with keyboard, the margin of the element that
was\r\nmoving was slightly off - fixed by changing the
constant\r\n`REORDER_ITEM_MARGIN` value to 16. Not sure if we use this
package\r\nsomewhere else and I should also test
@jughosta?\r\n\r\nbefore:\r\n<img width=\"436\" alt=\"Screenshot
2023-06-14 at 09 45
38\"\r\nsrc=\"b6e3ad6e-fc6f-4c7f-850e-d3a4d8cf4775\">\r\nafter:
\r\n<img width=\"405\" alt=\"Screenshot 2023-06-14 at 10 01
16\"\r\nsrc=\"4b850ca2-64d2-4c2a-a313-a7c10434674a\">\r\n\r\n\r\n\r\n3.
When navigating with keyboard but not reordering, the ghost
element\r\nwas covering completely the element we would drop into. I
fixed it by\r\nchanging the translation values. I think that's not
expected? Or is this\r\nintentional?\r\nbefore:\r\n<img width=\"410\"
alt=\"Screenshot 2023-06-14 at 09 45
47\"\r\nsrc=\"60296878-ca52-4d0c-bb49-5a84503d48ac\">\r\nafter:\r\n<img
width=\"436\" alt=\"Screenshot 2023-06-14 at 10 01
24\"\r\nsrc=\"c050fea1-10b2-4a72-95d3-fbfe920b9c96\">\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
Risk Matrix\r\n\r\nDelete this section if it is not applicable to this
PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other
developers to\r\nidentify risks that should be tested prior to the
change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider
some of the following examples\r\nand how they may potentially impact
the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes
|\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n|
Multiple Spaces&mdash;unexpected behavior in non-default Kibana
Space.\r\n| Low | High | Integration tests will verify that all features
are still\r\nsupported in non-default Kibana Space and when user
switches between\r\nspaces. |\r\n| Multiple nodes&mdash;Elasticsearch
polling might have race conditions\r\nwhen multiple Kibana nodes are
polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so
executing them multiple times will not result\r\nin logical error, but
will degrade performance. To test for this case we\r\nadd plenty of unit
tests around this logic and document manual testing\r\nprocedure. |\r\n|
Code should gracefully handle cases when feature X or plugin Y
are\r\ndisabled. | Medium | High | Unit tests will verify that any
feature flag\r\nor plugin combination still results in our service
operational. |\r\n| [See more potential
risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
|\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for
breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"293a70b655f733f73c8b021e88f69bc666f66fc9"}}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
2023-06-21 10:19:23 -07:00
Dario Gieselaar
f190fd1da9
Revert "[8.8] [APM] Circuit breaker and perf improvements for service… (#160132) 2023-06-21 09:28:09 -07:00
Tiago Costa
258f83fd90
skip flaky suite (#159931, #159932) 2023-06-21 17:09:44 +01:00
Kibana Machine
d861400833
[8.8] [Detection Engine][Exceptions] - Fix exception item update route (#159223) (#159420)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Detection Engine][Exceptions] - Fix exception item update route
(#159223)](https://github.com/elastic/kibana/pull/159223)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yara
Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-09T19:31:03Z","message":"[Detection
Engine][Exceptions] - Fix exception item update route (#159223)\n\n##
Summary\r\n\r\nAddresses issue
159230","sha":"f895c5c2058f3f36c828fe9d8f1dbc0c19a2b381","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:
SecuritySolution","Feature:Rule
Exceptions","v8.7.2","v8.9.0","Team:Detection
Engine","v8.8.2"],"number":159223,"url":"https://github.com/elastic/kibana/pull/159223","mergeCommit":{"message":"[Detection
Engine][Exceptions] - Fix exception item update route (#159223)\n\n##
Summary\r\n\r\nAddresses issue
159230","sha":"f895c5c2058f3f36c828fe9d8f1dbc0c19a2b381"}},"sourceBranch":"main","suggestedTargetBranches":["8.7","8.8"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159223","number":159223,"mergeCommit":{"message":"[Detection
Engine][Exceptions] - Fix exception item update route (#159223)\n\n##
Summary\r\n\r\nAddresses issue
159230","sha":"f895c5c2058f3f36c828fe9d8f1dbc0c19a2b381"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
2023-06-21 16:57:59 +01:00
Tiago Costa
ed6bbd56da
skip flaky suite (#159933) 2023-06-21 16:56:32 +01:00
Kibana Machine
7b648585e0
[8.8] [ML] Hiding pattern analysis button for non-time series data (#160051) (#160133)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[ML] Hiding pattern analysis button for non-time series data
(#160051)](https://github.com/elastic/kibana/pull/160051)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2023-06-21T13:15:59Z","message":"[ML]
Hiding pattern analysis button for non-time series data (#160051)\n\nThe
`Run pattern analysis` button should only be available for
time\r\nseries data.\r\nThis PR adds an additional check using the
dataview's
`isTimeBased`\r\nmethod.","sha":"bdf910ed50e1535ef99578a8a08b639835da3add","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:ML/AIOps","v8.9.0","v8.8.2"],"number":160051,"url":"https://github.com/elastic/kibana/pull/160051","mergeCommit":{"message":"[ML]
Hiding pattern analysis button for non-time series data (#160051)\n\nThe
`Run pattern analysis` button should only be available for
time\r\nseries data.\r\nThis PR adds an additional check using the
dataview's
`isTimeBased`\r\nmethod.","sha":"bdf910ed50e1535ef99578a8a08b639835da3add"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160051","number":160051,"mergeCommit":{"message":"[ML]
Hiding pattern analysis button for non-time series data (#160051)\n\nThe
`Run pattern analysis` button should only be available for
time\r\nseries data.\r\nThis PR adds an additional check using the
dataview's
`isTimeBased`\r\nmethod.","sha":"bdf910ed50e1535ef99578a8a08b639835da3add"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <jgowdy@elastic.co>
2023-06-21 07:22:37 -07:00
Kibana Machine
e2c3c9a301
[8.8] Fixes per-object audit logging for saved object resolve actions (#160014) (#160101)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Fixes per-object audit logging for saved object resolve actions
(#160014)](https://github.com/elastic/kibana/pull/160014)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2023-06-21T08:03:31Z","message":"Fixes
per-object audit logging for saved object resolve actions
(#160014)\n\n## Summary\r\nIt was noticed that audit logs for Saved
Object 'resolve' actions were\r\nnot getting generated. On investigation
we found that this regression\r\nwas introduced in #148165. During work
on migrating saved object\r\nauthorization and auditing logic into the
saved object security\r\nextension, several abstracted functions were
created for reuse. One of\r\nthese is responsible for performing audit
logging (`auditHelper`). In\r\nmigration of the unit tests, inputs to
the `auditHelper`, via\r\n`authorize` and `enforceAuthoriztion`, were
not correctly validated
for\r\n`authorizeAndRedactInternalBulkResolve`.\r\n\r\nThis PR corrects
the regression by passing the saved object information\r\nthrough the
call chain to `auditHelper`, and addresses the error in the\r\nunit
tests by implementing checks to validate the input parameters at\r\neach
level of the call chain.\r\n\r\nThis PR also corrects the unit test for
auditObjectsForSpaceDeletion.\r\n\r\n###
Tests\r\nSee\r\n`x-pack/plugins/security/server/saved_objects/saved_objects_security_extension.test.ts`\r\n'#authorizeAndRedactInternalBulkResolve'\r\n\r\n###
Manual testing:\r\n- Enable audit logging,
example:\r\n\r\n```yaml\r\nxpack.security.audit.enabled:
true\r\nxpack.security.audit.appender:\r\n type: rolling-file\r\n
fileName: ./logs/audit.log\r\n policy:\r\n type: time-interval\r\n
interval: 24h\r\n strategy:\r\n type: numeric\r\n max: 10\r\n
layout:\r\n type: json\r\n```\r\n\r\n- Create several dashboards (or add
all sample data sets)\r\n- Open each dashboard in the Kibana UI\r\n-
Check the audit logs and verify that there is a
\"saved_object_resolve\"\r\nentry to describe each dashboard access
event, and that each log\r\ncontains the dashboard type and id,
example:\r\n\r\n>\r\n{\"event\":{\"action\":\"saved_object_resolve\",\"category\":[\"database\"],\"type\":[\"access\"],\"outcome\":\"success\"},\"kibana\":{\"space_id\":\"default\",\"session_id\":\"HrDKOgZ6EiEV2bf8Io9bc/enfGsS+fTtbQ5g2ap21CU=\",\"saved_object\":{\"type\":\"dashboard\",\"id\":\"7adfa750-4c81-11e8-b3d7-01146121b73d\"}},\"user\":{\"id\":\"u_mGBROF_q5bmFCATbLXAcCwKa0k8JvONAwSruelyKA5E_0\",\"name\":\"elastic\",\"roles\":[\"superuser\"]},\"trace\":{\"id\":\"b11f0414-ca68-4e28-854a-249b19f88c36\"},\"client\":{\"ip\":\"127.0.0.1\"},\"http\":{\"request\":{\"headers\":{\"x-forwarded-for\":\"127.0.0.1\"}}},\"service\":{\"node\":{\"roles\":[\"background_tasks\",\"ui\"]}},\"ecs\":{\"version\":\"8.6.1\"},\"@timestamp\":\"2023-06-20T18:30:20.943+02:00\",\"message\":\"User\r\nhas
resolved
dashboard\r\n[id=7adfa750-4c81-11e8-b3d7-01146121b73d]\",\"log\":{\"level\":\"INFO\",\"logger\":\"plugins.security.audit.ecs\"},\"process\":{\"pid\":15004},\"transaction\":{\"id\":\"4917a352c3f68cd6\"}}\r\n\r\n##
Release Note:\r\nThis PR fixes a regression where the
\"saved_object_resolve\" audit action\r\nwas not being logged per
object.","sha":"2ec067f7474118d089f46c0e2a9e726dc4c6c852","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["blocker","release_note:fix","Feature:Saved
Objects","Feature:Security/Audit","backport:prev-minor","v8.9.0","v8.8.2"],"number":160014,"url":"https://github.com/elastic/kibana/pull/160014","mergeCommit":{"message":"Fixes
per-object audit logging for saved object resolve actions
(#160014)\n\n## Summary\r\nIt was noticed that audit logs for Saved
Object 'resolve' actions were\r\nnot getting generated. On investigation
we found that this regression\r\nwas introduced in #148165. During work
on migrating saved object\r\nauthorization and auditing logic into the
saved object security\r\nextension, several abstracted functions were
created for reuse. One of\r\nthese is responsible for performing audit
logging (`auditHelper`). In\r\nmigration of the unit tests, inputs to
the `auditHelper`, via\r\n`authorize` and `enforceAuthoriztion`, were
not correctly validated
for\r\n`authorizeAndRedactInternalBulkResolve`.\r\n\r\nThis PR corrects
the regression by passing the saved object information\r\nthrough the
call chain to `auditHelper`, and addresses the error in the\r\nunit
tests by implementing checks to validate the input parameters at\r\neach
level of the call chain.\r\n\r\nThis PR also corrects the unit test for
auditObjectsForSpaceDeletion.\r\n\r\n###
Tests\r\nSee\r\n`x-pack/plugins/security/server/saved_objects/saved_objects_security_extension.test.ts`\r\n'#authorizeAndRedactInternalBulkResolve'\r\n\r\n###
Manual testing:\r\n- Enable audit logging,
example:\r\n\r\n```yaml\r\nxpack.security.audit.enabled:
true\r\nxpack.security.audit.appender:\r\n type: rolling-file\r\n
fileName: ./logs/audit.log\r\n policy:\r\n type: time-interval\r\n
interval: 24h\r\n strategy:\r\n type: numeric\r\n max: 10\r\n
layout:\r\n type: json\r\n```\r\n\r\n- Create several dashboards (or add
all sample data sets)\r\n- Open each dashboard in the Kibana UI\r\n-
Check the audit logs and verify that there is a
\"saved_object_resolve\"\r\nentry to describe each dashboard access
event, and that each log\r\ncontains the dashboard type and id,
example:\r\n\r\n>\r\n{\"event\":{\"action\":\"saved_object_resolve\",\"category\":[\"database\"],\"type\":[\"access\"],\"outcome\":\"success\"},\"kibana\":{\"space_id\":\"default\",\"session_id\":\"HrDKOgZ6EiEV2bf8Io9bc/enfGsS+fTtbQ5g2ap21CU=\",\"saved_object\":{\"type\":\"dashboard\",\"id\":\"7adfa750-4c81-11e8-b3d7-01146121b73d\"}},\"user\":{\"id\":\"u_mGBROF_q5bmFCATbLXAcCwKa0k8JvONAwSruelyKA5E_0\",\"name\":\"elastic\",\"roles\":[\"superuser\"]},\"trace\":{\"id\":\"b11f0414-ca68-4e28-854a-249b19f88c36\"},\"client\":{\"ip\":\"127.0.0.1\"},\"http\":{\"request\":{\"headers\":{\"x-forwarded-for\":\"127.0.0.1\"}}},\"service\":{\"node\":{\"roles\":[\"background_tasks\",\"ui\"]}},\"ecs\":{\"version\":\"8.6.1\"},\"@timestamp\":\"2023-06-20T18:30:20.943+02:00\",\"message\":\"User\r\nhas
resolved
dashboard\r\n[id=7adfa750-4c81-11e8-b3d7-01146121b73d]\",\"log\":{\"level\":\"INFO\",\"logger\":\"plugins.security.audit.ecs\"},\"process\":{\"pid\":15004},\"transaction\":{\"id\":\"4917a352c3f68cd6\"}}\r\n\r\n##
Release Note:\r\nThis PR fixes a regression where the
\"saved_object_resolve\" audit action\r\nwas not being logged per
object.","sha":"2ec067f7474118d089f46c0e2a9e726dc4c6c852"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160014","number":160014,"mergeCommit":{"message":"Fixes
per-object audit logging for saved object resolve actions
(#160014)\n\n## Summary\r\nIt was noticed that audit logs for Saved
Object 'resolve' actions were\r\nnot getting generated. On investigation
we found that this regression\r\nwas introduced in #148165. During work
on migrating saved object\r\nauthorization and auditing logic into the
saved object security\r\nextension, several abstracted functions were
created for reuse. One of\r\nthese is responsible for performing audit
logging (`auditHelper`). In\r\nmigration of the unit tests, inputs to
the `auditHelper`, via\r\n`authorize` and `enforceAuthoriztion`, were
not correctly validated
for\r\n`authorizeAndRedactInternalBulkResolve`.\r\n\r\nThis PR corrects
the regression by passing the saved object information\r\nthrough the
call chain to `auditHelper`, and addresses the error in the\r\nunit
tests by implementing checks to validate the input parameters at\r\neach
level of the call chain.\r\n\r\nThis PR also corrects the unit test for
auditObjectsForSpaceDeletion.\r\n\r\n###
Tests\r\nSee\r\n`x-pack/plugins/security/server/saved_objects/saved_objects_security_extension.test.ts`\r\n'#authorizeAndRedactInternalBulkResolve'\r\n\r\n###
Manual testing:\r\n- Enable audit logging,
example:\r\n\r\n```yaml\r\nxpack.security.audit.enabled:
true\r\nxpack.security.audit.appender:\r\n type: rolling-file\r\n
fileName: ./logs/audit.log\r\n policy:\r\n type: time-interval\r\n
interval: 24h\r\n strategy:\r\n type: numeric\r\n max: 10\r\n
layout:\r\n type: json\r\n```\r\n\r\n- Create several dashboards (or add
all sample data sets)\r\n- Open each dashboard in the Kibana UI\r\n-
Check the audit logs and verify that there is a
\"saved_object_resolve\"\r\nentry to describe each dashboard access
event, and that each log\r\ncontains the dashboard type and id,
example:\r\n\r\n>\r\n{\"event\":{\"action\":\"saved_object_resolve\",\"category\":[\"database\"],\"type\":[\"access\"],\"outcome\":\"success\"},\"kibana\":{\"space_id\":\"default\",\"session_id\":\"HrDKOgZ6EiEV2bf8Io9bc/enfGsS+fTtbQ5g2ap21CU=\",\"saved_object\":{\"type\":\"dashboard\",\"id\":\"7adfa750-4c81-11e8-b3d7-01146121b73d\"}},\"user\":{\"id\":\"u_mGBROF_q5bmFCATbLXAcCwKa0k8JvONAwSruelyKA5E_0\",\"name\":\"elastic\",\"roles\":[\"superuser\"]},\"trace\":{\"id\":\"b11f0414-ca68-4e28-854a-249b19f88c36\"},\"client\":{\"ip\":\"127.0.0.1\"},\"http\":{\"request\":{\"headers\":{\"x-forwarded-for\":\"127.0.0.1\"}}},\"service\":{\"node\":{\"roles\":[\"background_tasks\",\"ui\"]}},\"ecs\":{\"version\":\"8.6.1\"},\"@timestamp\":\"2023-06-20T18:30:20.943+02:00\",\"message\":\"User\r\nhas
resolved
dashboard\r\n[id=7adfa750-4c81-11e8-b3d7-01146121b73d]\",\"log\":{\"level\":\"INFO\",\"logger\":\"plugins.security.audit.ecs\"},\"process\":{\"pid\":15004},\"transaction\":{\"id\":\"4917a352c3f68cd6\"}}\r\n\r\n##
Release Note:\r\nThis PR fixes a regression where the
\"saved_object_resolve\" audit action\r\nwas not being logged per
object.","sha":"2ec067f7474118d089f46c0e2a9e726dc4c6c852"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
2023-06-21 02:36:32 -07:00
Hannah Mudge
78d76d8481
[8.8] [Dashboard] Fix styling of top nav bar (#159754) (#160088)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Dashboard] Fix styling of top nav bar
(#159754)](https://github.com/elastic/kibana/pull/159754)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-20T22:23:06Z","message":"[Dashboard]
Fix styling of top nav bar (#159754)\n\nCloses
https://github.com/elastic/kibana/issues/159353\r\nCloses
https://github.com/elastic/kibana/issues/159756\r\n\r\n##
Summary\r\n\r\nThis PR adds styling so that, when the dashboard's chrome
is hidden or\r\nwhen there is a header banner present, the dashboard's
top navigation\r\nbar's `top` position is adjusted as necessary - this
prevents it from\r\neither (a) getting hidden behind the Kibana chrome
or (b) floating in\r\nthe wrong position and overlapping the dashboard
content, regardless of\r\nif the dashboard is in embed mode (i.e.
`embed=true` is present in the\r\nURL) or not (i.e. `embed=false` is
present in the URL **or**, more\r\ncommonly, there is no `embed`
parameter in the URL).\r\n\r\n### Embed Mode\r\n\r\n- ####
Before:\r\n\r\n\r\n76d3c70c-936c-4bcc-985c-4fb433f0cff3\r\n\r\n-
####
After:\r\n\r\n\r\n137bc103-666b-4fdd-ab4e-8994345e21b4\r\n\r\nIt
also resolves a bug where the `isEmbeddedExternally` component
state\r\nwas never actually being set, which meant that
the\r\n`ExitFullScreenButton` was always receiving `toggleChrome=true`.
This\r\nmade it so that entering and exiting fullscreen mode in an
embedded\r\ndashboard would force the chrome to be visible (which should
never\r\nhappen in embed mode).\r\n\r\n#### How to Test\r\nThe easiest
way to test this PR is to simply add `embed=true` to your\r\ndashboard
URL - because this PR also
fixes\r\nhttps://github.com/elastic/kibana/issues/159756, this will
essentially\r\nmimic the embedded experience.\r\n\r\nAlternatively, if
you want to test this in an actual iframe...\r\n\r\n1. Start and login
to Kibana with the default `kibana.yml` settings\r\n2. Create and embed
a dashboard using an iframe in an HTML file and open\r\nthat file in
your browser - the iframe will show a prompt to login, but\r\nyou won't
be able to. Instead...\r\n3. Add the following settings to your
`kibana.yml` file:<br><Br>\r\n ```\r\n xpack.security.secureCookies:
true\r\n xpack.security.sameSiteCookies: 'None'\r\n ```\r\n4. Wait for
Kibana to re-load\r\n5. Refresh the HTML page from step 2\r\n6. The
embedded dashboard should now be available for you to test 👍
\r\n\r\n#### Scenarios Tested\r\n\r\n- **Non-fullscreen mode**\r\n\r\n
<details>\r\n<summary> Without filter pill, without header banner
<i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"f68bbcfb-74d8-497c-a2ae-33e8e0c02660\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> Without filter pill, with
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"7c19711c-61dc-499a-b1d0-01fab639a27e\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, without
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"36e848bd-f0d9-41e3-8a8a-a48571ad5cd2\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, with header
banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"cd7489f6-3f34-439a-a30e-3ef39f3970b5\"/>\r\n
</details>\r\n \r\n <details>\r\n<summary> With filter pill, with
header banner <b>and</b> notification\r\nbanner <i>(click to see
GIF)</i></summary>\r\n<img\r\nsrc=\"bd67b4eb-4f68-4d9b-9e22-4d1b2d2e4d90\"/>\r\n
</details>\r\n\r\n- **Fullscreen mode**\r\n\r\n <details>\r\n<summary>
Without filter pill, without banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"d7d15560-7698-424f-b761-59b5557abe37\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> Without filter pill, with
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"311b6f3d-5152-4d16-ba39-160978c60c96\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, without
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"bff9e040-8169-40c7-a086-13a19e870383\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, with header
banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"3f453811-e65d-4ac4-9524-c396f9efdbdd\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, with header
banner <b>and</b> notification\r\nbanner <i>(click to see
GIF)</i></summary>\r\n<img\r\nsrc=\"f79673e7-03f2-49fa-be56-b67bf7a12976\"/>\r\n
</details>\r\n\r\n### Non-Embed Mode\r\n\r\n- ####
Before:\r\n\r\n\r\n71ffc964-2844-41a6-98d6-353e84d674be\r\n\r\n-
####
After:\r\n\r\n\r\n894aa292-b611-4e5e-a0d7-fe3d256fc3ba\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a4d5209a9f66c798e7e8d7bb4bbdc008aa7676ff","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["blocker","Feature:Dashboard","release_note:fix","Team:Presentation","loe:days","impact:critical","backport:prev-minor","v8.9.0","v8.8.2"],"number":159754,"url":"https://github.com/elastic/kibana/pull/159754","mergeCommit":{"message":"[Dashboard]
Fix styling of top nav bar (#159754)\n\nCloses
https://github.com/elastic/kibana/issues/159353\r\nCloses
https://github.com/elastic/kibana/issues/159756\r\n\r\n##
Summary\r\n\r\nThis PR adds styling so that, when the dashboard's chrome
is hidden or\r\nwhen there is a header banner present, the dashboard's
top navigation\r\nbar's `top` position is adjusted as necessary - this
prevents it from\r\neither (a) getting hidden behind the Kibana chrome
or (b) floating in\r\nthe wrong position and overlapping the dashboard
content, regardless of\r\nif the dashboard is in embed mode (i.e.
`embed=true` is present in the\r\nURL) or not (i.e. `embed=false` is
present in the URL **or**, more\r\ncommonly, there is no `embed`
parameter in the URL).\r\n\r\n### Embed Mode\r\n\r\n- ####
Before:\r\n\r\n\r\n76d3c70c-936c-4bcc-985c-4fb433f0cff3\r\n\r\n-
####
After:\r\n\r\n\r\n137bc103-666b-4fdd-ab4e-8994345e21b4\r\n\r\nIt
also resolves a bug where the `isEmbeddedExternally` component
state\r\nwas never actually being set, which meant that
the\r\n`ExitFullScreenButton` was always receiving `toggleChrome=true`.
This\r\nmade it so that entering and exiting fullscreen mode in an
embedded\r\ndashboard would force the chrome to be visible (which should
never\r\nhappen in embed mode).\r\n\r\n#### How to Test\r\nThe easiest
way to test this PR is to simply add `embed=true` to your\r\ndashboard
URL - because this PR also
fixes\r\nhttps://github.com/elastic/kibana/issues/159756, this will
essentially\r\nmimic the embedded experience.\r\n\r\nAlternatively, if
you want to test this in an actual iframe...\r\n\r\n1. Start and login
to Kibana with the default `kibana.yml` settings\r\n2. Create and embed
a dashboard using an iframe in an HTML file and open\r\nthat file in
your browser - the iframe will show a prompt to login, but\r\nyou won't
be able to. Instead...\r\n3. Add the following settings to your
`kibana.yml` file:<br><Br>\r\n ```\r\n xpack.security.secureCookies:
true\r\n xpack.security.sameSiteCookies: 'None'\r\n ```\r\n4. Wait for
Kibana to re-load\r\n5. Refresh the HTML page from step 2\r\n6. The
embedded dashboard should now be available for you to test 👍
\r\n\r\n#### Scenarios Tested\r\n\r\n- **Non-fullscreen mode**\r\n\r\n
<details>\r\n<summary> Without filter pill, without header banner
<i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"f68bbcfb-74d8-497c-a2ae-33e8e0c02660\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> Without filter pill, with
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"7c19711c-61dc-499a-b1d0-01fab639a27e\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, without
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"36e848bd-f0d9-41e3-8a8a-a48571ad5cd2\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, with header
banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"cd7489f6-3f34-439a-a30e-3ef39f3970b5\"/>\r\n
</details>\r\n \r\n <details>\r\n<summary> With filter pill, with
header banner <b>and</b> notification\r\nbanner <i>(click to see
GIF)</i></summary>\r\n<img\r\nsrc=\"bd67b4eb-4f68-4d9b-9e22-4d1b2d2e4d90\"/>\r\n
</details>\r\n\r\n- **Fullscreen mode**\r\n\r\n <details>\r\n<summary>
Without filter pill, without banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"d7d15560-7698-424f-b761-59b5557abe37\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> Without filter pill, with
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"311b6f3d-5152-4d16-ba39-160978c60c96\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, without
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"bff9e040-8169-40c7-a086-13a19e870383\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, with header
banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"3f453811-e65d-4ac4-9524-c396f9efdbdd\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, with header
banner <b>and</b> notification\r\nbanner <i>(click to see
GIF)</i></summary>\r\n<img\r\nsrc=\"f79673e7-03f2-49fa-be56-b67bf7a12976\"/>\r\n
</details>\r\n\r\n### Non-Embed Mode\r\n\r\n- ####
Before:\r\n\r\n\r\n71ffc964-2844-41a6-98d6-353e84d674be\r\n\r\n-
####
After:\r\n\r\n\r\n894aa292-b611-4e5e-a0d7-fe3d256fc3ba\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a4d5209a9f66c798e7e8d7bb4bbdc008aa7676ff"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159754","number":159754,"mergeCommit":{"message":"[Dashboard]
Fix styling of top nav bar (#159754)\n\nCloses
https://github.com/elastic/kibana/issues/159353\r\nCloses
https://github.com/elastic/kibana/issues/159756\r\n\r\n##
Summary\r\n\r\nThis PR adds styling so that, when the dashboard's chrome
is hidden or\r\nwhen there is a header banner present, the dashboard's
top navigation\r\nbar's `top` position is adjusted as necessary - this
prevents it from\r\neither (a) getting hidden behind the Kibana chrome
or (b) floating in\r\nthe wrong position and overlapping the dashboard
content, regardless of\r\nif the dashboard is in embed mode (i.e.
`embed=true` is present in the\r\nURL) or not (i.e. `embed=false` is
present in the URL **or**, more\r\ncommonly, there is no `embed`
parameter in the URL).\r\n\r\n### Embed Mode\r\n\r\n- ####
Before:\r\n\r\n\r\n76d3c70c-936c-4bcc-985c-4fb433f0cff3\r\n\r\n-
####
After:\r\n\r\n\r\n137bc103-666b-4fdd-ab4e-8994345e21b4\r\n\r\nIt
also resolves a bug where the `isEmbeddedExternally` component
state\r\nwas never actually being set, which meant that
the\r\n`ExitFullScreenButton` was always receiving `toggleChrome=true`.
This\r\nmade it so that entering and exiting fullscreen mode in an
embedded\r\ndashboard would force the chrome to be visible (which should
never\r\nhappen in embed mode).\r\n\r\n#### How to Test\r\nThe easiest
way to test this PR is to simply add `embed=true` to your\r\ndashboard
URL - because this PR also
fixes\r\nhttps://github.com/elastic/kibana/issues/159756, this will
essentially\r\nmimic the embedded experience.\r\n\r\nAlternatively, if
you want to test this in an actual iframe...\r\n\r\n1. Start and login
to Kibana with the default `kibana.yml` settings\r\n2. Create and embed
a dashboard using an iframe in an HTML file and open\r\nthat file in
your browser - the iframe will show a prompt to login, but\r\nyou won't
be able to. Instead...\r\n3. Add the following settings to your
`kibana.yml` file:<br><Br>\r\n ```\r\n xpack.security.secureCookies:
true\r\n xpack.security.sameSiteCookies: 'None'\r\n ```\r\n4. Wait for
Kibana to re-load\r\n5. Refresh the HTML page from step 2\r\n6. The
embedded dashboard should now be available for you to test 👍
\r\n\r\n#### Scenarios Tested\r\n\r\n- **Non-fullscreen mode**\r\n\r\n
<details>\r\n<summary> Without filter pill, without header banner
<i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"f68bbcfb-74d8-497c-a2ae-33e8e0c02660\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> Without filter pill, with
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"7c19711c-61dc-499a-b1d0-01fab639a27e\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, without
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"36e848bd-f0d9-41e3-8a8a-a48571ad5cd2\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, with header
banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"cd7489f6-3f34-439a-a30e-3ef39f3970b5\"/>\r\n
</details>\r\n \r\n <details>\r\n<summary> With filter pill, with
header banner <b>and</b> notification\r\nbanner <i>(click to see
GIF)</i></summary>\r\n<img\r\nsrc=\"bd67b4eb-4f68-4d9b-9e22-4d1b2d2e4d90\"/>\r\n
</details>\r\n\r\n- **Fullscreen mode**\r\n\r\n <details>\r\n<summary>
Without filter pill, without banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"d7d15560-7698-424f-b761-59b5557abe37\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> Without filter pill, with
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"311b6f3d-5152-4d16-ba39-160978c60c96\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, without
header banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"bff9e040-8169-40c7-a086-13a19e870383\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, with header
banner <i>(click to
see\r\nscreenshot)</i></summary>\r\n<img\r\nsrc=\"3f453811-e65d-4ac4-9524-c396f9efdbdd\"/>\r\n
</details>\r\n\r\n <details>\r\n<summary> With filter pill, with header
banner <b>and</b> notification\r\nbanner <i>(click to see
GIF)</i></summary>\r\n<img\r\nsrc=\"f79673e7-03f2-49fa-be56-b67bf7a12976\"/>\r\n
</details>\r\n\r\n### Non-Embed Mode\r\n\r\n- ####
Before:\r\n\r\n\r\n71ffc964-2844-41a6-98d6-353e84d674be\r\n\r\n-
####
After:\r\n\r\n\r\n894aa292-b611-4e5e-a0d7-fe3d256fc3ba\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] This was
checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a4d5209a9f66c798e7e8d7bb4bbdc008aa7676ff"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
2023-06-20 16:40:33 -07:00
Kibana Machine
43ff0befa1 skip failing test suite (#158529) 2023-06-20 16:04:15 -04:00
Kibana Machine
813787cf96 skip failing test suite (#160070) 2023-06-20 16:03:53 -04:00
Kibana Machine
6c82b40965 skip failing test suite (#132865) 2023-06-20 16:03:30 -04:00
Ievgen Sorokopud
c3cb2f713a
[8.8] [Security Solutions] Error pops up on rules creation for uninstalled ML jobs (#159316) (#160043)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solutions] Error pops up on rules creation for uninstalled
ML jobs (#159316)](https://github.com/elastic/kibana/pull/159316)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2023-06-19T11:11:19Z","message":"[Security
Solutions] Error pops up on rules creation for uninstalled ML jobs
(#159316)\n\n## Summary\r\n\r\nOriginal ticket:
https://github.com/elastic/kibana/issues/151168\r\n\r\nThese changes fix
the issue with unexpected error toasts being shown on\r\nselecting
uninstalled ML jobs while creating an ML rule.\r\n\r\nThe issue was that
we used ML API `'/internal/ml/jobs/jobs'` to fetch\r\nthe information
about the job which assumed that requested jobs are\r\ninstalled. When
jobs are not, it throws an
exception.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f0f299f5c1fb649ca71d6aa85d468dd9f5575d50","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:
SecuritySolution","ci:cloud-deploy","8.9
candidate","v8.9.0","Team:Detection
Engine","v8.8.2"],"number":159316,"url":"https://github.com/elastic/kibana/pull/159316","mergeCommit":{"message":"[Security
Solutions] Error pops up on rules creation for uninstalled ML jobs
(#159316)\n\n## Summary\r\n\r\nOriginal ticket:
https://github.com/elastic/kibana/issues/151168\r\n\r\nThese changes fix
the issue with unexpected error toasts being shown on\r\nselecting
uninstalled ML jobs while creating an ML rule.\r\n\r\nThe issue was that
we used ML API `'/internal/ml/jobs/jobs'` to fetch\r\nthe information
about the job which assumed that requested jobs are\r\ninstalled. When
jobs are not, it throws an
exception.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f0f299f5c1fb649ca71d6aa85d468dd9f5575d50"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159316","number":159316,"mergeCommit":{"message":"[Security
Solutions] Error pops up on rules creation for uninstalled ML jobs
(#159316)\n\n## Summary\r\n\r\nOriginal ticket:
https://github.com/elastic/kibana/issues/151168\r\n\r\nThese changes fix
the issue with unexpected error toasts being shown on\r\nselecting
uninstalled ML jobs while creating an ML rule.\r\n\r\nThe issue was that
we used ML API `'/internal/ml/jobs/jobs'` to fetch\r\nthe information
about the job which assumed that requested jobs are\r\ninstalled. When
jobs are not, it throws an
exception.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f0f299f5c1fb649ca71d6aa85d468dd9f5575d50"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-06-20 13:03:15 -07:00
Kibana Machine
61ad0bc1b4 skip failing test suite (#159929) 2023-06-20 14:12:48 -04:00
Kibana Machine
b2688fe4ed
[8.8] [APM] Circuit breaker and perf improvements for service map (#159883) (#160060)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[APM] Circuit breaker and perf improvements for service map
(#159883)](https://github.com/elastic/kibana/pull/159883)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"dario.gieselaar@elastic.co"},"sourceCommit":{"committedDate":"2023-06-20T16:38:23Z","message":"[APM]
Circuit breaker and perf improvements for service map
(#159883)\n\nCloses #101920\r\n\r\nThis PR does three things:\r\n\r\n-
add a `terminate_after` parameter to the search request for
the\r\nscripted metric agg. This is a configurable
setting\r\n(`xpack.apm.serviceMapTerminateAfter`) and defaults to 100k.
This is a\r\nshard-level parameter, so there's still the possibility of
lots of\r\nshards individually returning 100k documents and the
coordinating node\r\nrunning out of memory because it is collecting all
these docs from\r\nindividual shards. However, I suspect that there is
already some\r\nprotection in the reduce phase that will terminate the
request with a\r\nstack_overflow_error without OOMing, I've reached out
to the ES team to\r\nconfirm whether this is the case.\r\n- add
`xpack.apm.serviceMapMaxTraces`: this tells the max traces to\r\ninspect
in total, not just per search request. IE,
if\r\n`xpack.apm.serviceMapMaxTracesPerRequest` is 1, we simply chunk
the\r\ntraces in n chunks, so it doesn't really help with memory
management.\r\n`serviceMapMaxTraces` refers to the total amount of
traces to inspect.\r\n- rewrite `getConnections` to use local mutation
instead of\r\nimmutability. I saw huge CPU usage (with admittedly a
pathological\r\nscenario where there are 100s of services) in the
`getConnections`\r\nfunction, because it uses a deduplication mechanism
that is O(n²), so I\r\nrewrote it to O(n). Here's a before
:\r\n\r\n\r\n![image](6c24a7a2-3b48-4c95-9db2-563160a57aef)\r\n\r\nand
after:\r\n\r\n![image](c00b8428-3026-4610-aa8b-c0046e8f0e08)\r\n\r\nTo
reproduce an OOM, start ES with a much smaller amount of memory:\r\n`$
ES_JAVA_OPTS='-Xms236m -Xmx236m' yarn es snapshot`\r\n\r\nThen run the
synthtrace Service Map OOM scenario:\r\n`$ node scripts/synthtrace.js
service_map_oom --from=now-15m --to=now\r\n--clean`\r\n\r\nFinally,
navigate to `service-100` in the UI, and click on Service Map.\r\nThis
should trigger an
OOM.","sha":"1a9b2412299e98a210b4d902c4df92a710b32b97","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:APM","v8.9.0","v8.8.2"],"number":159883,"url":"https://github.com/elastic/kibana/pull/159883","mergeCommit":{"message":"[APM]
Circuit breaker and perf improvements for service map
(#159883)\n\nCloses #101920\r\n\r\nThis PR does three things:\r\n\r\n-
add a `terminate_after` parameter to the search request for
the\r\nscripted metric agg. This is a configurable
setting\r\n(`xpack.apm.serviceMapTerminateAfter`) and defaults to 100k.
This is a\r\nshard-level parameter, so there's still the possibility of
lots of\r\nshards individually returning 100k documents and the
coordinating node\r\nrunning out of memory because it is collecting all
these docs from\r\nindividual shards. However, I suspect that there is
already some\r\nprotection in the reduce phase that will terminate the
request with a\r\nstack_overflow_error without OOMing, I've reached out
to the ES team to\r\nconfirm whether this is the case.\r\n- add
`xpack.apm.serviceMapMaxTraces`: this tells the max traces to\r\ninspect
in total, not just per search request. IE,
if\r\n`xpack.apm.serviceMapMaxTracesPerRequest` is 1, we simply chunk
the\r\ntraces in n chunks, so it doesn't really help with memory
management.\r\n`serviceMapMaxTraces` refers to the total amount of
traces to inspect.\r\n- rewrite `getConnections` to use local mutation
instead of\r\nimmutability. I saw huge CPU usage (with admittedly a
pathological\r\nscenario where there are 100s of services) in the
`getConnections`\r\nfunction, because it uses a deduplication mechanism
that is O(n²), so I\r\nrewrote it to O(n). Here's a before
:\r\n\r\n\r\n![image](6c24a7a2-3b48-4c95-9db2-563160a57aef)\r\n\r\nand
after:\r\n\r\n![image](c00b8428-3026-4610-aa8b-c0046e8f0e08)\r\n\r\nTo
reproduce an OOM, start ES with a much smaller amount of memory:\r\n`$
ES_JAVA_OPTS='-Xms236m -Xmx236m' yarn es snapshot`\r\n\r\nThen run the
synthtrace Service Map OOM scenario:\r\n`$ node scripts/synthtrace.js
service_map_oom --from=now-15m --to=now\r\n--clean`\r\n\r\nFinally,
navigate to `service-100` in the UI, and click on Service Map.\r\nThis
should trigger an
OOM.","sha":"1a9b2412299e98a210b4d902c4df92a710b32b97"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159883","number":159883,"mergeCommit":{"message":"[APM]
Circuit breaker and perf improvements for service map
(#159883)\n\nCloses #101920\r\n\r\nThis PR does three things:\r\n\r\n-
add a `terminate_after` parameter to the search request for
the\r\nscripted metric agg. This is a configurable
setting\r\n(`xpack.apm.serviceMapTerminateAfter`) and defaults to 100k.
This is a\r\nshard-level parameter, so there's still the possibility of
lots of\r\nshards individually returning 100k documents and the
coordinating node\r\nrunning out of memory because it is collecting all
these docs from\r\nindividual shards. However, I suspect that there is
already some\r\nprotection in the reduce phase that will terminate the
request with a\r\nstack_overflow_error without OOMing, I've reached out
to the ES team to\r\nconfirm whether this is the case.\r\n- add
`xpack.apm.serviceMapMaxTraces`: this tells the max traces to\r\ninspect
in total, not just per search request. IE,
if\r\n`xpack.apm.serviceMapMaxTracesPerRequest` is 1, we simply chunk
the\r\ntraces in n chunks, so it doesn't really help with memory
management.\r\n`serviceMapMaxTraces` refers to the total amount of
traces to inspect.\r\n- rewrite `getConnections` to use local mutation
instead of\r\nimmutability. I saw huge CPU usage (with admittedly a
pathological\r\nscenario where there are 100s of services) in the
`getConnections`\r\nfunction, because it uses a deduplication mechanism
that is O(n²), so I\r\nrewrote it to O(n). Here's a before
:\r\n\r\n\r\n![image](6c24a7a2-3b48-4c95-9db2-563160a57aef)\r\n\r\nand
after:\r\n\r\n![image](c00b8428-3026-4610-aa8b-c0046e8f0e08)\r\n\r\nTo
reproduce an OOM, start ES with a much smaller amount of memory:\r\n`$
ES_JAVA_OPTS='-Xms236m -Xmx236m' yarn es snapshot`\r\n\r\nThen run the
synthtrace Service Map OOM scenario:\r\n`$ node scripts/synthtrace.js
service_map_oom --from=now-15m --to=now\r\n--clean`\r\n\r\nFinally,
navigate to `service-100` in the UI, and click on Service Map.\r\nThis
should trigger an
OOM.","sha":"1a9b2412299e98a210b4d902c4df92a710b32b97"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
2023-06-20 11:12:15 -07:00
Kibana Machine
bc8ecea099
[8.8] [Security Solution] Add support for GET requests to the Detection Engine health API (#159970) (#160023)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Add support for GET requests to the Detection
Engine health API
(#159970)](https://github.com/elastic/kibana/pull/159970)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Georgii
Gorbachev","email":"georgii.gorbachev@elastic.co"},"sourceCommit":{"committedDate":"2023-06-20T14:03:27Z","message":"[Security
Solution] Add support for GET requests to the Detection Engine health
API (#159970)\n\n**Partially addresses:**
https://github.com/elastic/kibana/issues/125642\r\n\r\n##
Summary\r\n\r\nThe PoC of the Detection Engine health API has been
implemented in\r\nhttps://github.com/elastic/kibana/pull/157155. Now, we
need to integrate\r\nit into
the\r\n[support-diagnostics](https://github.com/elastic/support-diagnostics)\r\ntool.
It looks like the tool requires the APIs it calls to be callable\r\nwith
the `GET` verb.\r\n\r\nThis PR makes it possible to call 2 out of 3
health endpoints with\r\n`GET`:\r\n\r\n```txt\r\nGET
/internal/detection_engine/health/_cluster\r\n```\r\n\r\n```txt\r\nGET
/internal/detection_engine/health/_space\r\n```\r\n\r\nThe `GET` routes
don't accept any parameters and use the default\r\nparameters
instead:\r\n\r\n- interval: `last_day`\r\n- granularity: `hour`\r\n-
debug: `false`\r\n\r\n\r\n### Checklist\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7047f24c1743a2a98e22e332403c5260d6062374","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Feature:Rule
Monitoring","Team:Detection Rule
Management","v8.9.0","v8.8.2"],"number":159970,"url":"https://github.com/elastic/kibana/pull/159970","mergeCommit":{"message":"[Security
Solution] Add support for GET requests to the Detection Engine health
API (#159970)\n\n**Partially addresses:**
https://github.com/elastic/kibana/issues/125642\r\n\r\n##
Summary\r\n\r\nThe PoC of the Detection Engine health API has been
implemented in\r\nhttps://github.com/elastic/kibana/pull/157155. Now, we
need to integrate\r\nit into
the\r\n[support-diagnostics](https://github.com/elastic/support-diagnostics)\r\ntool.
It looks like the tool requires the APIs it calls to be callable\r\nwith
the `GET` verb.\r\n\r\nThis PR makes it possible to call 2 out of 3
health endpoints with\r\n`GET`:\r\n\r\n```txt\r\nGET
/internal/detection_engine/health/_cluster\r\n```\r\n\r\n```txt\r\nGET
/internal/detection_engine/health/_space\r\n```\r\n\r\nThe `GET` routes
don't accept any parameters and use the default\r\nparameters
instead:\r\n\r\n- interval: `last_day`\r\n- granularity: `hour`\r\n-
debug: `false`\r\n\r\n\r\n### Checklist\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7047f24c1743a2a98e22e332403c5260d6062374"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159970","number":159970,"mergeCommit":{"message":"[Security
Solution] Add support for GET requests to the Detection Engine health
API (#159970)\n\n**Partially addresses:**
https://github.com/elastic/kibana/issues/125642\r\n\r\n##
Summary\r\n\r\nThe PoC of the Detection Engine health API has been
implemented in\r\nhttps://github.com/elastic/kibana/pull/157155. Now, we
need to integrate\r\nit into
the\r\n[support-diagnostics](https://github.com/elastic/support-diagnostics)\r\ntool.
It looks like the tool requires the APIs it calls to be callable\r\nwith
the `GET` verb.\r\n\r\nThis PR makes it possible to call 2 out of 3
health endpoints with\r\n`GET`:\r\n\r\n```txt\r\nGET
/internal/detection_engine/health/_cluster\r\n```\r\n\r\n```txt\r\nGET
/internal/detection_engine/health/_space\r\n```\r\n\r\nThe `GET` routes
don't accept any parameters and use the default\r\nparameters
instead:\r\n\r\n- interval: `last_day`\r\n- granularity: `hour`\r\n-
debug: `false`\r\n\r\n\r\n### Checklist\r\n\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"7047f24c1743a2a98e22e332403c5260d6062374"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
2023-06-20 09:21:22 -07:00
Kibana Machine
58d19d3ae7
[8.8] [Security Solution][ResponseOps] fixes context.results_link in actions params (#159966) (#160022)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution][ResponseOps] fixes context.results_link in
actions params (#159966)](https://github.com/elastic/kibana/pull/159966)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vitalii
Dmyterko","email":"92328789+vitaliidm@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-20T14:02:53Z","message":"[Security
Solution][ResponseOps] fixes context.results_link in actions params
(#159966)\n\n## Summary\r\n\r\n- fixes
https://github.com/elastic/kibana/issues/159586\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a653a3eca984da1a1c013330f8324dff727d3c48","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections
and Resp","Team:
SecuritySolution","backport:prev-minor","v8.9.0","Team:Detection
Engine","v8.8.2"],"number":159966,"url":"https://github.com/elastic/kibana/pull/159966","mergeCommit":{"message":"[Security
Solution][ResponseOps] fixes context.results_link in actions params
(#159966)\n\n## Summary\r\n\r\n- fixes
https://github.com/elastic/kibana/issues/159586\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a653a3eca984da1a1c013330f8324dff727d3c48"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159966","number":159966,"mergeCommit":{"message":"[Security
Solution][ResponseOps] fixes context.results_link in actions params
(#159966)\n\n## Summary\r\n\r\n- fixes
https://github.com/elastic/kibana/issues/159586\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[ ] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[ ] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[ ] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"a653a3eca984da1a1c013330f8324dff727d3c48"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
2023-06-20 08:50:28 -07:00
Kibana Machine
4fde17f20c
[8.8] [Security Solution] Adds several new fields to allowed Exceptions for Endpoint (#159835) (#159924)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Adds several new fields to allowed Exceptions for
Endpoint (#159835)](https://github.com/elastic/kibana/pull/159835)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Logan","email":"56395104+kevinlog@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-19T12:58:08Z","message":"[Security
Solution] Adds several new fields to allowed Exceptions for Endpoint
(#159835)\n\n## Summary\r\n\r\nAdds the following new fields to allowed
Exceptions for Endpoint after\r\ncustomer and internal
requests.\r\n\r\nWe can backport this to `8.8.2` in addition to shipping
in `8.9.0`\r\n\r\n```\r\n \"process.args\",\r\n
\"process.parent.args\",\r\n \"dns.question.type\",\r\n
\"file.pe.Ext.dotnet\",\r\n \"file.pe.Ext.streams.hash.md5\",\r\n
\"file.pe.Ext.streams.hash.sha256\",\r\n
\"file.pe.Ext.sections.hash.sha256\",\r\n
\"file.pe.Ext.sections.hash.md5\",\r\n \"file.pe.Ext.streams.name\",\r\n
\"Effective_process.entity_id\",\r\n
\"Effective_process.executable\",\r\n \"Effective_process.name\",\r\n
\"Effective_process.pid\"\r\n```\r\n\r\nSee the Endpoint Exception
builder below with the new fields available\r\nfor
use.\r\n\r\n\r\n![image](87e1b214-4a76-459c-800d-eb6877ed3b9a)","sha":"3e61769cdaef20bff5b788c6c365dfa80c1ca8ba","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Defend
Workflows","v8.8.0","v8.9.0"],"number":159835,"url":"https://github.com/elastic/kibana/pull/159835","mergeCommit":{"message":"[Security
Solution] Adds several new fields to allowed Exceptions for Endpoint
(#159835)\n\n## Summary\r\n\r\nAdds the following new fields to allowed
Exceptions for Endpoint after\r\ncustomer and internal
requests.\r\n\r\nWe can backport this to `8.8.2` in addition to shipping
in `8.9.0`\r\n\r\n```\r\n \"process.args\",\r\n
\"process.parent.args\",\r\n \"dns.question.type\",\r\n
\"file.pe.Ext.dotnet\",\r\n \"file.pe.Ext.streams.hash.md5\",\r\n
\"file.pe.Ext.streams.hash.sha256\",\r\n
\"file.pe.Ext.sections.hash.sha256\",\r\n
\"file.pe.Ext.sections.hash.md5\",\r\n \"file.pe.Ext.streams.name\",\r\n
\"Effective_process.entity_id\",\r\n
\"Effective_process.executable\",\r\n \"Effective_process.name\",\r\n
\"Effective_process.pid\"\r\n```\r\n\r\nSee the Endpoint Exception
builder below with the new fields available\r\nfor
use.\r\n\r\n\r\n![image](87e1b214-4a76-459c-800d-eb6877ed3b9a)","sha":"3e61769cdaef20bff5b788c6c365dfa80c1ca8ba"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159835","number":159835,"mergeCommit":{"message":"[Security
Solution] Adds several new fields to allowed Exceptions for Endpoint
(#159835)\n\n## Summary\r\n\r\nAdds the following new fields to allowed
Exceptions for Endpoint after\r\ncustomer and internal
requests.\r\n\r\nWe can backport this to `8.8.2` in addition to shipping
in `8.9.0`\r\n\r\n```\r\n \"process.args\",\r\n
\"process.parent.args\",\r\n \"dns.question.type\",\r\n
\"file.pe.Ext.dotnet\",\r\n \"file.pe.Ext.streams.hash.md5\",\r\n
\"file.pe.Ext.streams.hash.sha256\",\r\n
\"file.pe.Ext.sections.hash.sha256\",\r\n
\"file.pe.Ext.sections.hash.md5\",\r\n \"file.pe.Ext.streams.name\",\r\n
\"Effective_process.entity_id\",\r\n
\"Effective_process.executable\",\r\n \"Effective_process.name\",\r\n
\"Effective_process.pid\"\r\n```\r\n\r\nSee the Endpoint Exception
builder below with the new fields available\r\nfor
use.\r\n\r\n\r\n![image](87e1b214-4a76-459c-800d-eb6877ed3b9a)","sha":"3e61769cdaef20bff5b788c6c365dfa80c1ca8ba"}}]}]
BACKPORT-->

Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com>
2023-06-20 06:20:27 -07:00
Julia Bardi
546f2cd0a6
[8.8] [Fleet] Fix usage of AsyncLocalStorage for audit log (#159983)
Backport https://github.com/elastic/kibana/pull/159807

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-06-20 05:01:20 -07:00
Devon Thomson
d64611451a
[8.8] [Dashboard] Fix Time Range Regression (#159337) (#159946)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Dashboard] Fix Time Range Regression
(#159337)](https://github.com/elastic/kibana/pull/159337)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Devon
Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2023-06-15T20:10:55Z","message":"[Dashboard]
Fix Time Range Regression (#159337)\n\nFixed Dashboard loading with a
saved time range when the URL also contains a time
range.","sha":"f60d43e27b7c28e73f13b122453ac27c8e2e62bd","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","Team:Presentation","loe:hours","impact:critical","backport:prev-minor","v8.9.0","v8.8.2"],"number":159337,"url":"https://github.com/elastic/kibana/pull/159337","mergeCommit":{"message":"[Dashboard]
Fix Time Range Regression (#159337)\n\nFixed Dashboard loading with a
saved time range when the URL also contains a time
range.","sha":"f60d43e27b7c28e73f13b122453ac27c8e2e62bd"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159337","number":159337,"mergeCommit":{"message":"[Dashboard]
Fix Time Range Regression (#159337)\n\nFixed Dashboard loading with a
saved time range when the URL also contains a time
range.","sha":"f60d43e27b7c28e73f13b122453ac27c8e2e62bd"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
2023-06-19 09:39:43 -07:00
Kibana Machine
2faa186224
[8.8] [AO] Handle buildEsQuery error (such as leading wildcard) in status change (#159891) (#159938)
# Backport

This will backport the following commits from `main` to `8.8`:
- [AO] Handle buildEsQuery error (such as leading wildcard) in status
change (#159891) (229e8ca8)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-06-19T14:22:28Z","message":"[AO]
Handle buildEsQuery error (such as leading wildcard) in status change
(#159891)\n\nFixes #159079\r\n\r\n## Summary\r\n\r\nIn the case of
providing a wildcard in the search query, an error might\r\nbe generated
depending on whether the related setting is enabled or not.\r\nThis PR
tries to handle this error on the Alerts page for a better
user\r\nexperience.\r\n\r\n|Before|After|\r\n|---|---|\r\n\r\n|![image](cf74577e-10ab-4543-8135-f498dcc7cabf)|","sha":"229e8ca808b5aca07ad7cead3b64a5d63cd9c650"},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[]}]
BACKPORT-->

Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
2023-06-19 08:31:24 -07:00
Devon Thomson
b2bed7c290
[8.8] [Dashboard] Fix alias redirect & update error handling (#159742) (#159937)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Dashboard] Fix alias redirect & update error handling
(#159742)](https://github.com/elastic/kibana/pull/159742)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Devon
Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2023-06-15T15:57:43Z","message":"[Dashboard]
Fix alias redirect & update error handling (#159742)\n\nMakes dashboard
load errors recoverable. Fixes a regression where Alias redirects
resulted in infinite
loading.","sha":"e7528a2372c846020d565f229da9052ba316284c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","Team:Presentation","loe:days","impact:critical","backport:prev-minor","v8.9.0"],"number":159742,"url":"https://github.com/elastic/kibana/pull/159742","mergeCommit":{"message":"[Dashboard]
Fix alias redirect & update error handling (#159742)\n\nMakes dashboard
load errors recoverable. Fixes a regression where Alias redirects
resulted in infinite
loading.","sha":"e7528a2372c846020d565f229da9052ba316284c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159742","number":159742,"mergeCommit":{"message":"[Dashboard]
Fix alias redirect & update error handling (#159742)\n\nMakes dashboard
load errors recoverable. Fixes a regression where Alias redirects
resulted in infinite
loading.","sha":"e7528a2372c846020d565f229da9052ba316284c"}}]}]
BACKPORT-->
2023-06-19 08:29:41 -07:00
Kibana Machine
8109a55fb2
[8.8] [Telemetry] Permanently hide the telemetry notice on dismissal (#159893) (#159922)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Telemetry] Permanently hide the telemetry notice on dismissal
(#159893)](https://github.com/elastic/kibana/pull/159893)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-06-19T12:43:41Z","message":"[Telemetry]
Permanently hide the telemetry notice on dismissal
(#159893)","sha":"14c5fffb24f25eb19e185582289a00ee71cf33af","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:fix","Feature:Telemetry","backport:prev-minor","v8.9.0"],"number":159893,"url":"https://github.com/elastic/kibana/pull/159893","mergeCommit":{"message":"[Telemetry]
Permanently hide the telemetry notice on dismissal
(#159893)","sha":"14c5fffb24f25eb19e185582289a00ee71cf33af"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159893","number":159893,"mergeCommit":{"message":"[Telemetry]
Permanently hide the telemetry notice on dismissal
(#159893)","sha":"14c5fffb24f25eb19e185582289a00ee71cf33af"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
2023-06-19 07:00:03 -07:00
Kibana Machine
1147d386fb
[8.8] [ML] Reverting use of isPopulatedObject in error utils (#159913) (#159923)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[ML] Reverting use of isPopulatedObject in error utils
(#159913)](https://github.com/elastic/kibana/pull/159913)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2023-06-19T12:52:11Z","message":"[ML]
Reverting use of isPopulatedObject in error utils (#159913)\n\nPR
https://github.com/elastic/kibana/pull/155372 moved our error
utils\r\nto a package and also made a few small code changes, one of
which added\r\n`isPopulatedObject` to the error object type
guards.\r\n`isPopulatedObject` uses `Object.keys` under the hood which
cannot be\r\nused to access the non-enumerable properties of an object,
like
Error's\r\n`message`.\r\n\r\n\r\n![image](6a0269df-ca2a-494a-9364-8f35f2b52388)\r\n\r\nThis
PR reverts all of these functions back to their original
versions\r\nwhich had existed in ML for a while without
issue.\r\n\r\nThis was change had been causing error messages to not
display\r\ncorrectly.\r\n\r\n\r\n![image](243143a5-0c8f-4365-a41d-7c1c09858ad8)","sha":"8ca1789faa899f2e0a7abcf58fac50fa4d552af6","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v8.9.0","v8.8.2"],"number":159913,"url":"https://github.com/elastic/kibana/pull/159913","mergeCommit":{"message":"[ML]
Reverting use of isPopulatedObject in error utils (#159913)\n\nPR
https://github.com/elastic/kibana/pull/155372 moved our error
utils\r\nto a package and also made a few small code changes, one of
which added\r\n`isPopulatedObject` to the error object type
guards.\r\n`isPopulatedObject` uses `Object.keys` under the hood which
cannot be\r\nused to access the non-enumerable properties of an object,
like
Error's\r\n`message`.\r\n\r\n\r\n![image](6a0269df-ca2a-494a-9364-8f35f2b52388)\r\n\r\nThis
PR reverts all of these functions back to their original
versions\r\nwhich had existed in ML for a while without
issue.\r\n\r\nThis was change had been causing error messages to not
display\r\ncorrectly.\r\n\r\n\r\n![image](243143a5-0c8f-4365-a41d-7c1c09858ad8)","sha":"8ca1789faa899f2e0a7abcf58fac50fa4d552af6"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159913","number":159913,"mergeCommit":{"message":"[ML]
Reverting use of isPopulatedObject in error utils (#159913)\n\nPR
https://github.com/elastic/kibana/pull/155372 moved our error
utils\r\nto a package and also made a few small code changes, one of
which added\r\n`isPopulatedObject` to the error object type
guards.\r\n`isPopulatedObject` uses `Object.keys` under the hood which
cannot be\r\nused to access the non-enumerable properties of an object,
like
Error's\r\n`message`.\r\n\r\n\r\n![image](6a0269df-ca2a-494a-9364-8f35f2b52388)\r\n\r\nThis
PR reverts all of these functions back to their original
versions\r\nwhich had existed in ML for a while without
issue.\r\n\r\nThis was change had been causing error messages to not
display\r\ncorrectly.\r\n\r\n\r\n![image](243143a5-0c8f-4365-a41d-7c1c09858ad8)","sha":"8ca1789faa899f2e0a7abcf58fac50fa4d552af6"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <jgowdy@elastic.co>
2023-06-19 06:59:40 -07:00
Kibana Machine
a7a6425553
[8.8] [Synthetics] http monitors - account for custom Content-Type headers (#159737) (#159918)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Synthetics] http monitors - account for custom Content-Type headers
(#159737)](https://github.com/elastic/kibana/pull/159737)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2023-06-19T11:49:55Z","message":"[Synthetics]
http monitors - account for custom Content-Type headers
(#159737)","sha":"fc32999c91760ed399b872d507fd84d308f5829e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:uptime","v8.9.0","v8.8.2"],"number":159737,"url":"https://github.com/elastic/kibana/pull/159737","mergeCommit":{"message":"[Synthetics]
http monitors - account for custom Content-Type headers
(#159737)","sha":"fc32999c91760ed399b872d507fd84d308f5829e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159737","number":159737,"mergeCommit":{"message":"[Synthetics]
http monitors - account for custom Content-Type headers
(#159737)","sha":"fc32999c91760ed399b872d507fd84d308f5829e"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
2023-06-19 06:29:02 -07:00
Kibana Machine
d2683cba7b
[8.8] [esArchiver] Automatically cleanup SO indices when SO documents are found in data.json (#159582) (#159910)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[esArchiver] Automatically cleanup SO indices when SO documents are
found in data.json
(#159582)](https://github.com/elastic/kibana/pull/159582)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-06-19T11:08:03Z","message":"[esArchiver]
Automatically cleanup SO indices when SO documents are found in
data.json (#159582)\n\nThe ultimate goal of this PR is to lay the
groundwork to be able to\r\nremove the \"dynamic\" `mappings.json`,
which probably should have never\r\nexisted.\r\n\r\nWith the PR,
detecting SO documents in the `data.json` will\r\nautomatically trigger
a cleanup of the SO indices.\r\nThis, in turn, will allow not having to
define \"dynamic\" saved objects\r\nindices (i.e. those with the
`$KIBANA_PACKAGE_VERSION` variable in
the\r\n`mappings.json`).\r\n\r\nIIUC the idea behind the dynamic indices
was to have SO indices that are\r\naligned with the current stack
version, avoiding the extra overhead of\r\nhaving to migrate the
inserted documents, and reducing overall
test\r\ntimes.\r\n\r\nNonetheless, what is happening today is:\r\n1. FTR
starts ES and Kibana.\r\n2. Kibana creates current version SO indices at
startup (empty ones).\r\n3. `esArchiver.load()` processes the
`mappings.json`.\r\n3.1. It detects that we are defining SO indices and
**deletes** existing\r\nsaved object indices.\r\n3.2 It then re-creates
these indices according to the definitions on\r\n`mappings.json`.\r\n4.
`esArchiver.load()` processes the `data.json`. Specifically,
it\r\ninserts SO documents present in `data.json`.\r\n5.
`esArchiver.load()` calls the _KibanaMigrator_ to make sure that
the\r\ninserted documents are up-to-date, hoping they are already
aligned with\r\ncurrent stack version (which is not always the case, not
even with\r\n\"dynamic\" mappings).\r\n\r\nTwo interesting things to
note:\r\n- Steps 3 to 5 happen whilst Kibana is already started and
running. If\r\nKibana queries SO indices during `esArchiver.load()`, and
a request to\r\nES is made **right after** 3.2, the result might
be\r\nhttps://github.com/elastic/kibana/issues/158918.\r\n- Having
dynamic SO indices' definitions, deleting the \"official\"\r\nindices
created by Kibana (3.1), and recreating them hoping to be\r\naligned
with current stack version (3.2) is non-sense. We could use
the\r\nexisting SO indices instead, and simply clean them up whenever we
are\r\nabout to insert SO documents.\r\n\r\nPerforming that cleanup is
precisely the goal of this PR.\r\nThen, in subsequent PRs
like\r\nhttps://github.com/elastic/kibana/pull/159397/files, tackling
the flaky\r\ntests, we'll be able to simply remove the \"dynamic\"
`mappings.json`\r\ndefinitions, causing `esArchiver` to rely on SO
indices created by\r\nKibana.\r\n\r\nThanks to this PR, the FTR tests
won't need to explicitly cleanup saved\r\nobject indices in the `before`
hooks.","sha":"bbb5fc4abe7dd530d8248a09a9638cd3438202aa","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Team:Operations","technical
debt","release_note:skip","backport:prev-minor","v8.9.0","FTR","v8.8.2"],"number":159582,"url":"https://github.com/elastic/kibana/pull/159582","mergeCommit":{"message":"[esArchiver]
Automatically cleanup SO indices when SO documents are found in
data.json (#159582)\n\nThe ultimate goal of this PR is to lay the
groundwork to be able to\r\nremove the \"dynamic\" `mappings.json`,
which probably should have never\r\nexisted.\r\n\r\nWith the PR,
detecting SO documents in the `data.json` will\r\nautomatically trigger
a cleanup of the SO indices.\r\nThis, in turn, will allow not having to
define \"dynamic\" saved objects\r\nindices (i.e. those with the
`$KIBANA_PACKAGE_VERSION` variable in
the\r\n`mappings.json`).\r\n\r\nIIUC the idea behind the dynamic indices
was to have SO indices that are\r\naligned with the current stack
version, avoiding the extra overhead of\r\nhaving to migrate the
inserted documents, and reducing overall
test\r\ntimes.\r\n\r\nNonetheless, what is happening today is:\r\n1. FTR
starts ES and Kibana.\r\n2. Kibana creates current version SO indices at
startup (empty ones).\r\n3. `esArchiver.load()` processes the
`mappings.json`.\r\n3.1. It detects that we are defining SO indices and
**deletes** existing\r\nsaved object indices.\r\n3.2 It then re-creates
these indices according to the definitions on\r\n`mappings.json`.\r\n4.
`esArchiver.load()` processes the `data.json`. Specifically,
it\r\ninserts SO documents present in `data.json`.\r\n5.
`esArchiver.load()` calls the _KibanaMigrator_ to make sure that
the\r\ninserted documents are up-to-date, hoping they are already
aligned with\r\ncurrent stack version (which is not always the case, not
even with\r\n\"dynamic\" mappings).\r\n\r\nTwo interesting things to
note:\r\n- Steps 3 to 5 happen whilst Kibana is already started and
running. If\r\nKibana queries SO indices during `esArchiver.load()`, and
a request to\r\nES is made **right after** 3.2, the result might
be\r\nhttps://github.com/elastic/kibana/issues/158918.\r\n- Having
dynamic SO indices' definitions, deleting the \"official\"\r\nindices
created by Kibana (3.1), and recreating them hoping to be\r\naligned
with current stack version (3.2) is non-sense. We could use
the\r\nexisting SO indices instead, and simply clean them up whenever we
are\r\nabout to insert SO documents.\r\n\r\nPerforming that cleanup is
precisely the goal of this PR.\r\nThen, in subsequent PRs
like\r\nhttps://github.com/elastic/kibana/pull/159397/files, tackling
the flaky\r\ntests, we'll be able to simply remove the \"dynamic\"
`mappings.json`\r\ndefinitions, causing `esArchiver` to rely on SO
indices created by\r\nKibana.\r\n\r\nThanks to this PR, the FTR tests
won't need to explicitly cleanup saved\r\nobject indices in the `before`
hooks.","sha":"bbb5fc4abe7dd530d8248a09a9638cd3438202aa"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159582","number":159582,"mergeCommit":{"message":"[esArchiver]
Automatically cleanup SO indices when SO documents are found in
data.json (#159582)\n\nThe ultimate goal of this PR is to lay the
groundwork to be able to\r\nremove the \"dynamic\" `mappings.json`,
which probably should have never\r\nexisted.\r\n\r\nWith the PR,
detecting SO documents in the `data.json` will\r\nautomatically trigger
a cleanup of the SO indices.\r\nThis, in turn, will allow not having to
define \"dynamic\" saved objects\r\nindices (i.e. those with the
`$KIBANA_PACKAGE_VERSION` variable in
the\r\n`mappings.json`).\r\n\r\nIIUC the idea behind the dynamic indices
was to have SO indices that are\r\naligned with the current stack
version, avoiding the extra overhead of\r\nhaving to migrate the
inserted documents, and reducing overall
test\r\ntimes.\r\n\r\nNonetheless, what is happening today is:\r\n1. FTR
starts ES and Kibana.\r\n2. Kibana creates current version SO indices at
startup (empty ones).\r\n3. `esArchiver.load()` processes the
`mappings.json`.\r\n3.1. It detects that we are defining SO indices and
**deletes** existing\r\nsaved object indices.\r\n3.2 It then re-creates
these indices according to the definitions on\r\n`mappings.json`.\r\n4.
`esArchiver.load()` processes the `data.json`. Specifically,
it\r\ninserts SO documents present in `data.json`.\r\n5.
`esArchiver.load()` calls the _KibanaMigrator_ to make sure that
the\r\ninserted documents are up-to-date, hoping they are already
aligned with\r\ncurrent stack version (which is not always the case, not
even with\r\n\"dynamic\" mappings).\r\n\r\nTwo interesting things to
note:\r\n- Steps 3 to 5 happen whilst Kibana is already started and
running. If\r\nKibana queries SO indices during `esArchiver.load()`, and
a request to\r\nES is made **right after** 3.2, the result might
be\r\nhttps://github.com/elastic/kibana/issues/158918.\r\n- Having
dynamic SO indices' definitions, deleting the \"official\"\r\nindices
created by Kibana (3.1), and recreating them hoping to be\r\naligned
with current stack version (3.2) is non-sense. We could use
the\r\nexisting SO indices instead, and simply clean them up whenever we
are\r\nabout to insert SO documents.\r\n\r\nPerforming that cleanup is
precisely the goal of this PR.\r\nThen, in subsequent PRs
like\r\nhttps://github.com/elastic/kibana/pull/159397/files, tackling
the flaky\r\ntests, we'll be able to simply remove the \"dynamic\"
`mappings.json`\r\ndefinitions, causing `esArchiver` to rely on SO
indices created by\r\nKibana.\r\n\r\nThanks to this PR, the FTR tests
won't need to explicitly cleanup saved\r\nobject indices in the `before`
hooks.","sha":"bbb5fc4abe7dd530d8248a09a9638cd3438202aa"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
2023-06-19 05:50:56 -07:00
Devon Thomson
9e48a57755
[8.8] [Dashboard] Fast Navigation Between Dashboards (#157437) (#159827)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Dashboard] Fast Navigation Between Dashboards
(#157437)](https://github.com/elastic/kibana/pull/157437)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Devon
Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2023-05-25T18:40:48Z","message":"[Dashboard]
Fast Navigation Between Dashboards (#157437)\n\n## Summary\r\nMakes all
navigation from one Dashboard to another feel
snappier.","sha":"5342563a22a54223180a727a542a7b6c99caea7f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Dashboard","Team:Presentation","loe:days","impact:medium","backport:skip","v8.8.0","v8.9.0"],"number":157437,"url":"https://github.com/elastic/kibana/pull/157437","mergeCommit":{"message":"[Dashboard]
Fast Navigation Between Dashboards (#157437)\n\n## Summary\r\nMakes all
navigation from one Dashboard to another feel
snappier.","sha":"5342563a22a54223180a727a542a7b6c99caea7f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157437","number":157437,"mergeCommit":{"message":"[Dashboard]
Fast Navigation Between Dashboards (#157437)\n\n## Summary\r\nMakes all
navigation from one Dashboard to another feel
snappier.","sha":"5342563a22a54223180a727a542a7b6c99caea7f"}}]}]
BACKPORT-->

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
2023-06-16 03:22:23 -07:00
Kibana Machine
1bdfebab70
[8.8] [SecuritySolution] Update checkIndicesExists logic (#159806) (#159836)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[SecuritySolution] Update checkIndicesExists logic
(#159806)](https://github.com/elastic/kibana/pull/159806)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-15T19:06:30Z","message":"[SecuritySolution]
Update checkIndicesExists logic (#159806)\n\n## Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/159107\r\n\r\n\r\n\r\n**Steps
to verify:**\r\n\r\n1. Generate some alerts and enable host or user risk
score module.\r\n2. Hard refresh the page, select the alerts data view.
\r\n\r\n<img width=\"639\" alt=\"Screenshot 2023-06-15 at 14 54
54\"\r\nsrc=\"412a2a9c-9125-4972-8c95-24dda90ad529\">\r\n\r\n3.
Visit overview, host, network and users page. All should
`Not`\r\ndisplay the get started
page.\r\n\r\n\r\n\r\n4b942604-f98f-40fe-bbca-9cfd11cdf275\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"24bfa0514efb3eb16b3eb3276679dd53229d01ba","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.9.0","v8.8.2"],"number":159806,"url":"https://github.com/elastic/kibana/pull/159806","mergeCommit":{"message":"[SecuritySolution]
Update checkIndicesExists logic (#159806)\n\n## Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/159107\r\n\r\n\r\n\r\n**Steps
to verify:**\r\n\r\n1. Generate some alerts and enable host or user risk
score module.\r\n2. Hard refresh the page, select the alerts data view.
\r\n\r\n<img width=\"639\" alt=\"Screenshot 2023-06-15 at 14 54
54\"\r\nsrc=\"412a2a9c-9125-4972-8c95-24dda90ad529\">\r\n\r\n3.
Visit overview, host, network and users page. All should
`Not`\r\ndisplay the get started
page.\r\n\r\n\r\n\r\n4b942604-f98f-40fe-bbca-9cfd11cdf275\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"24bfa0514efb3eb16b3eb3276679dd53229d01ba"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159806","number":159806,"mergeCommit":{"message":"[SecuritySolution]
Update checkIndicesExists logic (#159806)\n\n## Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/159107\r\n\r\n\r\n\r\n**Steps
to verify:**\r\n\r\n1. Generate some alerts and enable host or user risk
score module.\r\n2. Hard refresh the page, select the alerts data view.
\r\n\r\n<img width=\"639\" alt=\"Screenshot 2023-06-15 at 14 54
54\"\r\nsrc=\"412a2a9c-9125-4972-8c95-24dda90ad529\">\r\n\r\n3.
Visit overview, host, network and users page. All should
`Not`\r\ndisplay the get started
page.\r\n\r\n\r\n\r\n4b942604-f98f-40fe-bbca-9cfd11cdf275\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"24bfa0514efb3eb16b3eb3276679dd53229d01ba"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
2023-06-15 13:50:20 -07:00
Nathan Reese
8899487bbf
[8.8][maps] fix layer group loading indicator always on when group has non-visible layer (#159517) (#159830)
Backport of https://github.com/elastic/kibana/pull/159517

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-06-15 12:43:16 -06:00
Kibana Machine
608652a0a7
[8.8] [Security Solution] Improve rules exception flyout opening for the indices with huge amount of fields (#159216) (#159801)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Improve rules exception flyout opening for the
indices with huge amount of fields
(#159216)](https://github.com/elastic/kibana/pull/159216)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2023-06-15T12:57:15Z","message":"[Security
Solution] Improve rules exception flyout opening for the indices with
huge amount of fields (#159216)\n\n## Summary\r\n\r\nOriginal
ticket:\r\n[#158751](https://github.com/elastic/kibana/issues/158751)\r\n\r\nThese
changes improve the rule's exceptions flyout opening experience.\r\nWe
had a few complaints that it is very slow to open it and sometimes
it\r\nthrows an exception about the limited response size.\r\n\r\nTo fix
this, we decided to load extended field's data (conflicts
and\r\nunmapped info) only when user selects some field instead of
fetching\r\nthis data for all fields on flyout opening.\r\n\r\n##
NOTES:\r\n\r\nAfter these changes we gonna do next steps related to
fields loading\r\nwhen user creates/edits rule exceptions:\r\n1. We will
call `_fields_for_wildcard` **WITHOUT**\r\n`include_unmapped=true`
parameter to fetch all fields specs on exception\r\nflyout loading\r\n2.
We will call `_fields_for_wildcard` **WITH**
`include_unmapped=true`\r\nfor only one field when user selects it from
the dropdown menu\r\n\r\nWith these changes we will improve slow
exception flyout opening when\r\nuser has lots of fields which are
unmapped in different indices. If for\r\nsome reason user has a lot of
(thousands) conflicting fields around\r\nindices then the loading is
still might be slow as the\r\n`_fields_for_wildcard` call will return
conflicts information even\r\nwithout `include_unmapped=true`
parameter.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"31b34771c5e6f710858a7f617bbca04537cf5c1b","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:
SecuritySolution","ci:cloud-deploy","v8.9.0","Team:Detection
Engine","v8.8.2"],"number":159216,"url":"https://github.com/elastic/kibana/pull/159216","mergeCommit":{"message":"[Security
Solution] Improve rules exception flyout opening for the indices with
huge amount of fields (#159216)\n\n## Summary\r\n\r\nOriginal
ticket:\r\n[#158751](https://github.com/elastic/kibana/issues/158751)\r\n\r\nThese
changes improve the rule's exceptions flyout opening experience.\r\nWe
had a few complaints that it is very slow to open it and sometimes
it\r\nthrows an exception about the limited response size.\r\n\r\nTo fix
this, we decided to load extended field's data (conflicts
and\r\nunmapped info) only when user selects some field instead of
fetching\r\nthis data for all fields on flyout opening.\r\n\r\n##
NOTES:\r\n\r\nAfter these changes we gonna do next steps related to
fields loading\r\nwhen user creates/edits rule exceptions:\r\n1. We will
call `_fields_for_wildcard` **WITHOUT**\r\n`include_unmapped=true`
parameter to fetch all fields specs on exception\r\nflyout loading\r\n2.
We will call `_fields_for_wildcard` **WITH**
`include_unmapped=true`\r\nfor only one field when user selects it from
the dropdown menu\r\n\r\nWith these changes we will improve slow
exception flyout opening when\r\nuser has lots of fields which are
unmapped in different indices. If for\r\nsome reason user has a lot of
(thousands) conflicting fields around\r\nindices then the loading is
still might be slow as the\r\n`_fields_for_wildcard` call will return
conflicts information even\r\nwithout `include_unmapped=true`
parameter.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"31b34771c5e6f710858a7f617bbca04537cf5c1b"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159216","number":159216,"mergeCommit":{"message":"[Security
Solution] Improve rules exception flyout opening for the indices with
huge amount of fields (#159216)\n\n## Summary\r\n\r\nOriginal
ticket:\r\n[#158751](https://github.com/elastic/kibana/issues/158751)\r\n\r\nThese
changes improve the rule's exceptions flyout opening experience.\r\nWe
had a few complaints that it is very slow to open it and sometimes
it\r\nthrows an exception about the limited response size.\r\n\r\nTo fix
this, we decided to load extended field's data (conflicts
and\r\nunmapped info) only when user selects some field instead of
fetching\r\nthis data for all fields on flyout opening.\r\n\r\n##
NOTES:\r\n\r\nAfter these changes we gonna do next steps related to
fields loading\r\nwhen user creates/edits rule exceptions:\r\n1. We will
call `_fields_for_wildcard` **WITHOUT**\r\n`include_unmapped=true`
parameter to fetch all fields specs on exception\r\nflyout loading\r\n2.
We will call `_fields_for_wildcard` **WITH**
`include_unmapped=true`\r\nfor only one field when user selects it from
the dropdown menu\r\n\r\nWith these changes we will improve slow
exception flyout opening when\r\nuser has lots of fields which are
unmapped in different indices. If for\r\nsome reason user has a lot of
(thousands) conflicting fields around\r\nindices then the loading is
still might be slow as the\r\n`_fields_for_wildcard` call will return
conflicts information even\r\nwithout `include_unmapped=true`
parameter.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"31b34771c5e6f710858a7f617bbca04537cf5c1b"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
2023-06-15 09:10:22 -07:00
Lisa Cawley
f3f2d31cc0
[8.8] [DOCS] Fix formatting in alerting settings (#159753) (#159822)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[DOCS] Fix formatting in alerting settings
(#159753)](https://github.com/elastic/kibana/pull/159753)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-06-15T14:24:38Z","message":"[DOCS]
Fix formatting in alerting settings
(#159753)","sha":"64ab4fda321b5076e90f9ef63f4837d6c3424b1a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","docs","backport:prev-minor","v8.9.0"],"number":159753,"url":"https://github.com/elastic/kibana/pull/159753","mergeCommit":{"message":"[DOCS]
Fix formatting in alerting settings
(#159753)","sha":"64ab4fda321b5076e90f9ef63f4837d6c3424b1a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159753","number":159753,"mergeCommit":{"message":"[DOCS]
Fix formatting in alerting settings
(#159753)","sha":"64ab4fda321b5076e90f9ef63f4837d6c3424b1a"}}]}]
BACKPORT-->
2023-06-15 12:07:51 -04:00
Kibana Machine
7caf5c385f
[8.8] [DOCS] Clarify Jira connector compatibility (#159757) (#159812)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[DOCS] Clarify Jira connector compatibility
(#159757)](https://github.com/elastic/kibana/pull/159757)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-06-15T14:22:27Z","message":"[DOCS]
Clarify Jira connector compatibility
(#159757)","sha":"5792c2772ec73df004ac119133f7be28d127061e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","docs","Feature:Actions/ConnectorTypes","backport:prev-minor","v8.9.0"],"number":159757,"url":"https://github.com/elastic/kibana/pull/159757","mergeCommit":{"message":"[DOCS]
Clarify Jira connector compatibility
(#159757)","sha":"5792c2772ec73df004ac119133f7be28d127061e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159757","number":159757,"mergeCommit":{"message":"[DOCS]
Clarify Jira connector compatibility
(#159757)","sha":"5792c2772ec73df004ac119133f7be28d127061e"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2023-06-15 10:45:44 -04:00
Kibana Machine
b832428a05
[8.8] [DOCS] Remove broken links from email connector (#159759) (#159811)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[DOCS] Remove broken links from email connector
(#159759)](https://github.com/elastic/kibana/pull/159759)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-06-15T14:21:02Z","message":"[DOCS]
Remove broken links from email connector
(#159759)","sha":"29bffbece27ee26217a243280f2a9c108340963e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorTypes","backport:prev-minor","v8.9.0"],"number":159759,"url":"https://github.com/elastic/kibana/pull/159759","mergeCommit":{"message":"[DOCS]
Remove broken links from email connector
(#159759)","sha":"29bffbece27ee26217a243280f2a9c108340963e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159759","number":159759,"mergeCommit":{"message":"[DOCS]
Remove broken links from email connector
(#159759)","sha":"29bffbece27ee26217a243280f2a9c108340963e"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2023-06-15 10:41:33 -04:00
Georgii Gorbachev
c65f896563
[8.8] [Security Solution] PoC of the Detection Engine health API (#157155) (#159717)
# Backport

This will backport the following PR from `main` to `8.8`:
 - https://github.com/elastic/kibana/pull/157155

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
2023-06-15 04:39:03 -07:00
Kibana Machine
858100d843
[8.8] [Security Solution] Fix timeline bug receiving dataProvider value as number (#159723) (#159775)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Fix timeline bug receiving dataProvider value as
number (#159723)](https://github.com/elastic/kibana/pull/159723)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2023-06-15T08:39:45Z","message":"[Security
Solution] Fix timeline bug receiving dataProvider value as number
(#159723)\n\n## Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/159720\r\nTimeline save request
fails when the dataProvider value stored is a\r\nNumber
type.\r\n\r\nAdding the dataProvider through timeline page itself does
not cause the\r\nbug. it sets a string value even if the field type is
`number`.\r\n\r\nThe bug only happens when using \"add to timeline\"
CellAction on a field\r\nwith type `number`\r\n\r\n###
Solution\r\n\r\nCast the dataProvider values to a `string` before adding
them to
the\r\ntimeline.","sha":"b9d6beb070ba60a533857616150c453cc7714237","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting","Team:Threat Hunting:Investigations","Team:Threat
Hunting:Explore","v8.9.0","v8.8.2"],"number":159723,"url":"https://github.com/elastic/kibana/pull/159723","mergeCommit":{"message":"[Security
Solution] Fix timeline bug receiving dataProvider value as number
(#159723)\n\n## Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/159720\r\nTimeline save request
fails when the dataProvider value stored is a\r\nNumber
type.\r\n\r\nAdding the dataProvider through timeline page itself does
not cause the\r\nbug. it sets a string value even if the field type is
`number`.\r\n\r\nThe bug only happens when using \"add to timeline\"
CellAction on a field\r\nwith type `number`\r\n\r\n###
Solution\r\n\r\nCast the dataProvider values to a `string` before adding
them to
the\r\ntimeline.","sha":"b9d6beb070ba60a533857616150c453cc7714237"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159723","number":159723,"mergeCommit":{"message":"[Security
Solution] Fix timeline bug receiving dataProvider value as number
(#159723)\n\n## Summary\r\n\r\nissue:
https://github.com/elastic/kibana/issues/159720\r\nTimeline save request
fails when the dataProvider value stored is a\r\nNumber
type.\r\n\r\nAdding the dataProvider through timeline page itself does
not cause the\r\nbug. it sets a string value even if the field type is
`number`.\r\n\r\nThe bug only happens when using \"add to timeline\"
CellAction on a field\r\nwith type `number`\r\n\r\n###
Solution\r\n\r\nCast the dataProvider values to a `string` before adding
them to
the\r\ntimeline.","sha":"b9d6beb070ba60a533857616150c453cc7714237"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
2023-06-15 03:26:17 -07:00
Kibana Machine
fae57b0ea3
[8.8] [docs] remove invalid arg from scripts/generate_plugin example (#159466) (#159673)
Co-authored-by: Thomas Watson <watson@elastic.co>
2023-06-15 06:33:30 +02:00
Kibana Machine
2a02b2aa78
[8.8] fix(NA): build external plugins with correct bazel artifacts output mode (#159630) (#159761)
# Backport

This will backport the following commits from `main` to `8.8`:
- [fix(NA): build external plugins with correct bazel artifacts output
mode (#159630)](https://github.com/elastic/kibana/pull/159630)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tiago
Costa","email":"tiago.costa@elastic.co"},"sourceCommit":{"committedDate":"2023-06-14T23:43:05Z","message":"fix(NA):
build external plugins with correct bazel artifacts output mode
(#159630)\n\nCloses https://github.com/elastic/kibana/issues/159328
,\r\nhttps://github.com/elastic/kibana/issues/154325,\r\nhttps://github.com/elastic/kibana/issues/157440\r\n\r\nThis
PR fixes a problem in the plugin helpers tasks used to build\r\nexternal
plugins. After changes to transpile packages differently in the\r\npast
months a bug was introduced and external plugins were being
built\r\nwith the wrong shared ui deps output mode causing development
form\r\nimports to be bundled and causing problems at page load
time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","auto-backport","v8.7.2","v8.9.0","v8.8.2"],"number":159630,"url":"https://github.com/elastic/kibana/pull/159630","mergeCommit":{"message":"fix(NA):
build external plugins with correct bazel artifacts output mode
(#159630)\n\nCloses https://github.com/elastic/kibana/issues/159328
,\r\nhttps://github.com/elastic/kibana/issues/154325,\r\nhttps://github.com/elastic/kibana/issues/157440\r\n\r\nThis
PR fixes a problem in the plugin helpers tasks used to build\r\nexternal
plugins. After changes to transpile packages differently in the\r\npast
months a bug was introduced and external plugins were being
built\r\nwith the wrong shared ui deps output mode causing development
form\r\nimports to be bundled and causing problems at page load
time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7"}},"sourceBranch":"main","suggestedTargetBranches":["8.7","8.8"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159630","number":159630,"mergeCommit":{"message":"fix(NA):
build external plugins with correct bazel artifacts output mode
(#159630)\n\nCloses https://github.com/elastic/kibana/issues/159328
,\r\nhttps://github.com/elastic/kibana/issues/154325,\r\nhttps://github.com/elastic/kibana/issues/157440\r\n\r\nThis
PR fixes a problem in the plugin helpers tasks used to build\r\nexternal
plugins. After changes to transpile packages differently in the\r\npast
months a bug was introduced and external plugins were being
built\r\nwith the wrong shared ui deps output mode causing development
form\r\nimports to be bundled and causing problems at page load
time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
2023-06-15 03:17:48 +01:00
Kibana Machine
2088c4d425
[8.8] Update chromedriver to 114.0.2 (#159624) (#159736)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Update chromedriver to 114.0.2
(#159624)](https://github.com/elastic/kibana/pull/159624)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2023-06-14T14:21:02Z","message":"Update
chromedriver to 114.0.2
(#159624)","sha":"02fab4dece540c30a67618b9d3c62cc3600c2e0c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.9.0"],"number":159624,"url":"https://github.com/elastic/kibana/pull/159624","mergeCommit":{"message":"Update
chromedriver to 114.0.2
(#159624)","sha":"02fab4dece540c30a67618b9d3c62cc3600c2e0c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159624","number":159624,"mergeCommit":{"message":"Update
chromedriver to 114.0.2
(#159624)","sha":"02fab4dece540c30a67618b9d3c62cc3600c2e0c"}}]}]
BACKPORT-->

Co-authored-by: Jon <jon@elastic.co>
2023-06-14 14:55:13 -05:00
Kibana Machine
e3345b1f17
[8.8] [Cloud Security] [Bug Fix] Fix for status unprivileged issue (#159538) (#159604)
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Cloud Security] [Bug Fix] Fix for status unprivileged issue
(#159538)](https://github.com/elastic/kibana/pull/159538)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rickyanto
Ang","email":"rickyangwyn@gmail.com"},"sourceCommit":{"committedDate":"2023-06-13T16:31:12Z","message":"[Cloud
Security] [Bug Fix] Fix for status unprivileged issue
(#159538)","sha":"935ae789dac57bab241a7aa13d21132ec1c48435","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Cloud
Security","v8.9.0","v8.8.2"],"number":159538,"url":"https://github.com/elastic/kibana/pull/159538","mergeCommit":{"message":"[Cloud
Security] [Bug Fix] Fix for status unprivileged issue
(#159538)","sha":"935ae789dac57bab241a7aa13d21132ec1c48435"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159538","number":159538,"mergeCommit":{"message":"[Cloud
Security] [Bug Fix] Fix for status unprivileged issue
(#159538)","sha":"935ae789dac57bab241a7aa13d21132ec1c48435"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Rickyanto Ang <rickyangwyn@gmail.com>
2023-06-13 10:43:09 -07:00
Kibana Machine
f7e3e35835
[8.8] Update tsvb.asciidoc to correct typo (#159551) (#159567)
# Backport

This will backport the following commits from `main` to `8.8`:
- [Update tsvb.asciidoc to correct typo
(#159551)](https://github.com/elastic/kibana/pull/159551)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carly
Richmond","email":"74931905+carlyrichmond@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-13T12:53:16Z","message":"Update
tsvb.asciidoc to correct typo
(#159551)","sha":"ad2593b7b424b65ef04a83854352412027be9b6c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","v8.9.0","v8.8.1"],"number":159551,"url":"https://github.com/elastic/kibana/pull/159551","mergeCommit":{"message":"Update
tsvb.asciidoc to correct typo
(#159551)","sha":"ad2593b7b424b65ef04a83854352412027be9b6c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159551","number":159551,"mergeCommit":{"message":"Update
tsvb.asciidoc to correct typo
(#159551)","sha":"ad2593b7b424b65ef04a83854352412027be9b6c"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Carly Richmond <74931905+carlyrichmond@users.noreply.github.com>
2023-06-13 09:14:58 -04:00