github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-22 08:49:27 -04:00
Code Issues Projects Releases Packages Wiki Activity
64916 commits 433 branches 496 tags 22 GiB
Commit graph

2671 commits

Author SHA1 Message Date
Kibana Machine
7b337dea96
[8.9] [Flaky #116059] Unskip test (#165125) (#165201) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Flaky #116059] Unskip test
(#165125)](https://github.com/elastic/kibana/pull/165125)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-08-30T09:16:11Z","message":"[Flaky
#116059] Unskip test
(#165125)","sha":"cc728f6f2bcfeabec55b54a6c7bcfd5fee3661f0","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:all-open","v8.11.0"],"number":165125,"url":"https://github.com/elastic/kibana/pull/165125","mergeCommit":{"message":"[Flaky
#116059] Unskip test
(#165125)","sha":"cc728f6f2bcfeabec55b54a6c7bcfd5fee3661f0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165125","number":165125,"mergeCommit":{"message":"[Flaky
#116059] Unskip test
(#165125)","sha":"cc728f6f2bcfeabec55b54a6c7bcfd5fee3661f0"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
 2023-08-30 03:18:31 -07:00
Kibana Machine
89220a48cb
[8.9] [FTR] Implement scrollIntoView util (#165080) (#165097) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[FTR] Implement scrollIntoView util
(#165080)](https://github.com/elastic/kibana/pull/165080)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2023-08-29T13:31:27Z","message":"[FTR]
Implement scrollIntoView util (#165080)\n\n## 📓 Summary\r\n\r\nBased on
the need for
[this\r\ntest](https://github.com/elastic/kibana/pull/164493/files#diff-e0bb824023eef20a7b3742da023e25744a6c20406f59ae8400455c579153faeaR262)\r\nto
scroll into the element independently of its existence in view,
this\r\nPR exposes a new `scrollIntoView` method that replicates the
behaviour\r\nof the native
[Element\r\n.scrollIntoView](https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView)\r\nmethod.\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"56c04d88872bb22d4c941fda6262746e198c5505","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v7.17.13","v8.11.0"],"number":165080,"url":"https://github.com/elastic/kibana/pull/165080","mergeCommit":{"message":"[FTR]
Implement scrollIntoView util (#165080)\n\n## 📓 Summary\r\n\r\nBased on
the need for
[this\r\ntest](https://github.com/elastic/kibana/pull/164493/files#diff-e0bb824023eef20a7b3742da023e25744a6c20406f59ae8400455c579153faeaR262)\r\nto
scroll into the element independently of its existence in view,
this\r\nPR exposes a new `scrollIntoView` method that replicates the
behaviour\r\nof the native
[Element\r\n.scrollIntoView](https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView)\r\nmethod.\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"56c04d88872bb22d4c941fda6262746e198c5505"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"7.17","label":"v7.17.13","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165080","number":165080,"mergeCommit":{"message":"[FTR]
Implement scrollIntoView util (#165080)\n\n## 📓 Summary\r\n\r\nBased on
the need for
[this\r\ntest](https://github.com/elastic/kibana/pull/164493/files#diff-e0bb824023eef20a7b3742da023e25744a6c20406f59ae8400455c579153faeaR262)\r\nto
scroll into the element independently of its existence in view,
this\r\nPR exposes a new `scrollIntoView` method that replicates the
behaviour\r\nof the native
[Element\r\n.scrollIntoView](https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView)\r\nmethod.\r\n\r\n---------\r\n\r\nCo-authored-by:
Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"56c04d88872bb22d4c941fda6262746e198c5505"}}]}]
BACKPORT-->

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
 2023-08-29 07:36:56 -07:00
Kibana Machine
5c5c2daa00
[8.9] [FTR] Implement browser network condition utils (#163633) (#163703) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[FTR] Implement browser network condition utils
(#163633)](https://github.com/elastic/kibana/pull/163633)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2023-08-11T12:24:06Z","message":"[FTR]
Implement browser network condition utils (#163633)\n\n## 📓
Summary\r\n\r\nThe PR implements some utilities into the `browser`
service to allow\r\ncontrolling the network conditions during the
execution of a functional\r\ntest.\r\n\r\n###
`getNetworkConditions`\r\n\r\nReturns the current network simulation
options. If none conditions are\r\npreviously set, it returns
`undefined`\r\n\r\n**N.B.**: _if the testing environment is not a
Chromium browser, it\r\nthrows an error that can be easily caught to
manually skip the test or\r\nhandle a fallback
scenario._\r\n\r\n\r\n```ts\r\nit('should display a loading skeleton
while loading', async function () {\r\n // Skip the test in case network
condition utils are not available\r\n try {\r\n const networkConditions
= await browser.getNetworkConditions(); // undefined\r\n\r\n await
browser.setNetworkConditions('SLOW_3G');\r\n\r\n const networkConditions
= await browser.getNetworkConditions();\r\n // {\r\n // offline:
false,\r\n // latency: 2000,\r\n // download_throughput: 50000,\r\n //
upload_throughput: 50000,\r\n // }\r\n } catch (error) {\r\n
this.skip();\r\n }\r\n});\r\n```\r\n\r\n###
`setNetworkConditions`\r\n\r\nSet the desired network conditions.\r\nIt
supports different presets that match the [network profiles
provided\r\nby
Chrome\r\ndebugger](da276a3fae/front_end/core/sdk/NetworkManager.ts (L363-L393)):\r\n-
`NO_THROTTLING`\r\n- `FAST_3G`\r\n- `SLOW_3G`\r\n- `OFFLINE`\r\n-
`CLOUD_USER` (pre-existing)\r\nIt also accepts ad-hoc options to
configure more specifically the\r\nnetwork conditions.\r\n\r\n**N.B.**:
_if the testing environment is not a Chromium browser, it\r\nthrows an
error that can be easily caught to manually skip the test or\r\nhandle a
fallback scenario._\r\n\r\n```ts\r\nit('should display a loading
skeleton while loading', async function () {\r\n // Skip the test in
case network condition utils are not available\r\n try {\r\n await
browser.setNetworkConditions('NO_THROTTLING');\r\n await
browser.setNetworkConditions('FAST_3G');\r\n await
browser.setNetworkConditions('SLOW_3G');\r\n await
browser.setNetworkConditions('OFFLINE');\r\n await
browser.setNetworkConditions('CLOUD_USER');\r\n await
browser.setNetworkConditions({\r\n offline: false,\r\n latency: 5, //
Additional latency (ms).\r\n download_throughput: 500 * 1024, // Maximal
aggregated download throughput.\r\n upload_throughput: 500 * 1024, //
Maximal aggregated upload throughput.\r\n });\r\n } catch (error) {\r\n
this.skip();\r\n }\r\n});\r\n```\r\n\r\n###
restoreNetworkConditions\r\n\r\nRestore the original network conditions,
setting to `NO_THROTTLING`.\r\nThe native implementation of
`deleteNetworkConditions` exposed by\r\nselenium is unofficial and
didn't consistently work, the recommended\r\napproach by the google dev
tools team is to restore the connection\r\nsetting the no throttling
profile.\r\n\r\n**N.B.**: _if the testing environment is not a Chromium
browser, it\r\nthrows an error that can be easily caught to manually
skip the test or\r\nhandle a fallback
scenario._\r\n\r\n```ts\r\nit('should display a loading skeleton while
loading', async function () {\r\n // Skip the test in case network
condition utils are not available\r\n try {\r\n await
browser.setNetworkConditions('SLOW_3G'); // Slow down network
conditions\r\n \r\n // Do your assertions\r\n\r\n await
browser.restoreNetworkConditions(); // Restore network conditions\r\n }
catch (error) {\r\n this.skip();\r\n
}\r\n});\r\n```\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>\r\nCo-authored-by: Dzmitry Lemechko
<dzmitry.lemechko@elastic.co>","sha":"aa45152a4e787f36014675b864fcc0fce7bd6758","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.10.0","v7.17.13","v8.9.2"],"number":163633,"url":"https://github.com/elastic/kibana/pull/163633","mergeCommit":{"message":"[FTR]
Implement browser network condition utils (#163633)\n\n## 📓
Summary\r\n\r\nThe PR implements some utilities into the `browser`
service to allow\r\ncontrolling the network conditions during the
execution of a functional\r\ntest.\r\n\r\n###
`getNetworkConditions`\r\n\r\nReturns the current network simulation
options. If none conditions are\r\npreviously set, it returns
`undefined`\r\n\r\n**N.B.**: _if the testing environment is not a
Chromium browser, it\r\nthrows an error that can be easily caught to
manually skip the test or\r\nhandle a fallback
scenario._\r\n\r\n\r\n```ts\r\nit('should display a loading skeleton
while loading', async function () {\r\n // Skip the test in case network
condition utils are not available\r\n try {\r\n const networkConditions
= await browser.getNetworkConditions(); // undefined\r\n\r\n await
browser.setNetworkConditions('SLOW_3G');\r\n\r\n const networkConditions
= await browser.getNetworkConditions();\r\n // {\r\n // offline:
false,\r\n // latency: 2000,\r\n // download_throughput: 50000,\r\n //
upload_throughput: 50000,\r\n // }\r\n } catch (error) {\r\n
this.skip();\r\n }\r\n});\r\n```\r\n\r\n###
`setNetworkConditions`\r\n\r\nSet the desired network conditions.\r\nIt
supports different presets that match the [network profiles
provided\r\nby
Chrome\r\ndebugger](da276a3fae/front_end/core/sdk/NetworkManager.ts (L363-L393)):\r\n-
`NO_THROTTLING`\r\n- `FAST_3G`\r\n- `SLOW_3G`\r\n- `OFFLINE`\r\n-
`CLOUD_USER` (pre-existing)\r\nIt also accepts ad-hoc options to
configure more specifically the\r\nnetwork conditions.\r\n\r\n**N.B.**:
_if the testing environment is not a Chromium browser, it\r\nthrows an
error that can be easily caught to manually skip the test or\r\nhandle a
fallback scenario._\r\n\r\n```ts\r\nit('should display a loading
skeleton while loading', async function () {\r\n // Skip the test in
case network condition utils are not available\r\n try {\r\n await
browser.setNetworkConditions('NO_THROTTLING');\r\n await
browser.setNetworkConditions('FAST_3G');\r\n await
browser.setNetworkConditions('SLOW_3G');\r\n await
browser.setNetworkConditions('OFFLINE');\r\n await
browser.setNetworkConditions('CLOUD_USER');\r\n await
browser.setNetworkConditions({\r\n offline: false,\r\n latency: 5, //
Additional latency (ms).\r\n download_throughput: 500 * 1024, // Maximal
aggregated download throughput.\r\n upload_throughput: 500 * 1024, //
Maximal aggregated upload throughput.\r\n });\r\n } catch (error) {\r\n
this.skip();\r\n }\r\n});\r\n```\r\n\r\n###
restoreNetworkConditions\r\n\r\nRestore the original network conditions,
setting to `NO_THROTTLING`.\r\nThe native implementation of
`deleteNetworkConditions` exposed by\r\nselenium is unofficial and
didn't consistently work, the recommended\r\napproach by the google dev
tools team is to restore the connection\r\nsetting the no throttling
profile.\r\n\r\n**N.B.**: _if the testing environment is not a Chromium
browser, it\r\nthrows an error that can be easily caught to manually
skip the test or\r\nhandle a fallback
scenario._\r\n\r\n```ts\r\nit('should display a loading skeleton while
loading', async function () {\r\n // Skip the test in case network
condition utils are not available\r\n try {\r\n await
browser.setNetworkConditions('SLOW_3G'); // Slow down network
conditions\r\n \r\n // Do your assertions\r\n\r\n await
browser.restoreNetworkConditions(); // Restore network conditions\r\n }
catch (error) {\r\n this.skip();\r\n
}\r\n});\r\n```\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>\r\nCo-authored-by: Dzmitry Lemechko
<dzmitry.lemechko@elastic.co>","sha":"aa45152a4e787f36014675b864fcc0fce7bd6758"}},"sourceBranch":"main","suggestedTargetBranches":["7.17","8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163633","number":163633,"mergeCommit":{"message":"[FTR]
Implement browser network condition utils (#163633)\n\n## 📓
Summary\r\n\r\nThe PR implements some utilities into the `browser`
service to allow\r\ncontrolling the network conditions during the
execution of a functional\r\ntest.\r\n\r\n###
`getNetworkConditions`\r\n\r\nReturns the current network simulation
options. If none conditions are\r\npreviously set, it returns
`undefined`\r\n\r\n**N.B.**: _if the testing environment is not a
Chromium browser, it\r\nthrows an error that can be easily caught to
manually skip the test or\r\nhandle a fallback
scenario._\r\n\r\n\r\n```ts\r\nit('should display a loading skeleton
while loading', async function () {\r\n // Skip the test in case network
condition utils are not available\r\n try {\r\n const networkConditions
= await browser.getNetworkConditions(); // undefined\r\n\r\n await
browser.setNetworkConditions('SLOW_3G');\r\n\r\n const networkConditions
= await browser.getNetworkConditions();\r\n // {\r\n // offline:
false,\r\n // latency: 2000,\r\n // download_throughput: 50000,\r\n //
upload_throughput: 50000,\r\n // }\r\n } catch (error) {\r\n
this.skip();\r\n }\r\n});\r\n```\r\n\r\n###
`setNetworkConditions`\r\n\r\nSet the desired network conditions.\r\nIt
supports different presets that match the [network profiles
provided\r\nby
Chrome\r\ndebugger](da276a3fae/front_end/core/sdk/NetworkManager.ts (L363-L393)):\r\n-
`NO_THROTTLING`\r\n- `FAST_3G`\r\n- `SLOW_3G`\r\n- `OFFLINE`\r\n-
`CLOUD_USER` (pre-existing)\r\nIt also accepts ad-hoc options to
configure more specifically the\r\nnetwork conditions.\r\n\r\n**N.B.**:
_if the testing environment is not a Chromium browser, it\r\nthrows an
error that can be easily caught to manually skip the test or\r\nhandle a
fallback scenario._\r\n\r\n```ts\r\nit('should display a loading
skeleton while loading', async function () {\r\n // Skip the test in
case network condition utils are not available\r\n try {\r\n await
browser.setNetworkConditions('NO_THROTTLING');\r\n await
browser.setNetworkConditions('FAST_3G');\r\n await
browser.setNetworkConditions('SLOW_3G');\r\n await
browser.setNetworkConditions('OFFLINE');\r\n await
browser.setNetworkConditions('CLOUD_USER');\r\n await
browser.setNetworkConditions({\r\n offline: false,\r\n latency: 5, //
Additional latency (ms).\r\n download_throughput: 500 * 1024, // Maximal
aggregated download throughput.\r\n upload_throughput: 500 * 1024, //
Maximal aggregated upload throughput.\r\n });\r\n } catch (error) {\r\n
this.skip();\r\n }\r\n});\r\n```\r\n\r\n###
restoreNetworkConditions\r\n\r\nRestore the original network conditions,
setting to `NO_THROTTLING`.\r\nThe native implementation of
`deleteNetworkConditions` exposed by\r\nselenium is unofficial and
didn't consistently work, the recommended\r\napproach by the google dev
tools team is to restore the connection\r\nsetting the no throttling
profile.\r\n\r\n**N.B.**: _if the testing environment is not a Chromium
browser, it\r\nthrows an error that can be easily caught to manually
skip the test or\r\nhandle a fallback
scenario._\r\n\r\n```ts\r\nit('should display a loading skeleton while
loading', async function () {\r\n // Skip the test in case network
condition utils are not available\r\n try {\r\n await
browser.setNetworkConditions('SLOW_3G'); // Slow down network
conditions\r\n \r\n // Do your assertions\r\n\r\n await
browser.restoreNetworkConditions(); // Restore network conditions\r\n }
catch (error) {\r\n this.skip();\r\n
}\r\n});\r\n```\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>\r\nCo-authored-by: Dzmitry Lemechko
<dzmitry.lemechko@elastic.co>","sha":"aa45152a4e787f36014675b864fcc0fce7bd6758"}},{"branch":"7.17","label":"v7.17.13","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
 2023-08-11 06:36:38 -07:00
Kibana Machine
86f579d9e3
[8.9] [FTR] unskip tsvb time series tests for Chrome (#163510) (#163555) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[FTR] unskip tsvb time series tests for Chrome
(#163510)](https://github.com/elastic/kibana/pull/163510)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-08-10T07:17:12Z","message":"[FTR]
unskip tsvb time series tests for Chrome (#163510)\n\n##
Summary\r\n\r\nRelated to #162995\r\n\r\nThis PR unskip TSVB tests for
Chrome browser since it is proved to
be\r\nstable\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836\r\n100x
passed\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835\r\n100x
passed\r\nOn Firefox the flakiness is related to Terms 2nd aggregation
field\r\nsometimes is not selected. I tested it manually in Firefox 116
and was\r\nable to set fields, though I have a feeling that values are
not always\r\nselected on click in the drop-down. But I didn't see any
errors in\r\nconsole.\r\n\r\nI also returned back retry for dropdown
selection I removed in #161202\r\nthough flaky-test-runner proves there
is no need. Let's have just to\r\nkeep logic as before my
PR.","sha":"072ad967fc04e2b79bf75fd9e6618f3bf0e46b9f","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.10.0","v8.9.1"],"number":163510,"url":"https://github.com/elastic/kibana/pull/163510","mergeCommit":{"message":"[FTR]
unskip tsvb time series tests for Chrome (#163510)\n\n##
Summary\r\n\r\nRelated to #162995\r\n\r\nThis PR unskip TSVB tests for
Chrome browser since it is proved to
be\r\nstable\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836\r\n100x
passed\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835\r\n100x
passed\r\nOn Firefox the flakiness is related to Terms 2nd aggregation
field\r\nsometimes is not selected. I tested it manually in Firefox 116
and was\r\nable to set fields, though I have a feeling that values are
not always\r\nselected on click in the drop-down. But I didn't see any
errors in\r\nconsole.\r\n\r\nI also returned back retry for dropdown
selection I removed in #161202\r\nthough flaky-test-runner proves there
is no need. Let's have just to\r\nkeep logic as before my
PR.","sha":"072ad967fc04e2b79bf75fd9e6618f3bf0e46b9f"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163510","number":163510,"mergeCommit":{"message":"[FTR]
unskip tsvb time series tests for Chrome (#163510)\n\n##
Summary\r\n\r\nRelated to #162995\r\n\r\nThis PR unskip TSVB tests for
Chrome browser since it is proved to
be\r\nstable\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2836\r\n100x
passed\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2835\r\n100x
passed\r\nOn Firefox the flakiness is related to Terms 2nd aggregation
field\r\nsometimes is not selected. I tested it manually in Firefox 116
and was\r\nable to set fields, though I have a feeling that values are
not always\r\nselected on click in the drop-down. But I didn't see any
errors in\r\nconsole.\r\n\r\nI also returned back retry for dropdown
selection I removed in #161202\r\nthough flaky-test-runner proves there
is no need. Let's have just to\r\nkeep logic as before my
PR.","sha":"072ad967fc04e2b79bf75fd9e6618f3bf0e46b9f"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
 2023-08-10 01:30:27 -07:00
Stratoula Kalafateli
f343ff6a54
[8.9] [TSVB] Unskip tsdb tests (#163471) (#163553) 
# Backport

Closes https://github.com/elastic/kibana/issues/163454

This will backport the following commits from `main` to `8.9`:
- [[TSVB] Unskip tsdb tests
(#163471)](https://github.com/elastic/kibana/pull/163471)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2023-08-09T11:16:02Z","message":"[TSVB]
Unskip tsdb tests (#163471)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/163454\r\n\r\nNow ES doesnt
error out for average aggregation in counter fields. So we\r\ncan remove
the test for this
scenario","sha":"4fc9906c17206a67426e743984d8d628f7b14321","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","Team:Visualizations","failed-test","release_note:skip","backport:skip","v8.10.0"],"number":163471,"url":"https://github.com/elastic/kibana/pull/163471","mergeCommit":{"message":"[TSVB]
Unskip tsdb tests (#163471)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/163454\r\n\r\nNow ES doesnt
error out for average aggregation in counter fields. So we\r\ncan remove
the test for this
scenario","sha":"4fc9906c17206a67426e743984d8d628f7b14321"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163471","number":163471,"mergeCommit":{"message":"[TSVB]
Unskip tsdb tests (#163471)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/163454\r\n\r\nNow ES doesnt
error out for average aggregation in counter fields. So we\r\ncan remove
the test for this
scenario","sha":"4fc9906c17206a67426e743984d8d628f7b14321"}}]}]
BACKPORT-->
 2023-08-10 09:53:14 +02:00
Tiago Costa
7413e8a21a
skip failing es promotion suite (#163454) 2023-08-09 17:32:44 +01:00
Kibana Machine
fb16a55e78 skip failing test suite (#162995) 2023-08-08 14:29:24 -04:00
Kibana Machine
e1a00f0377
[8.9] [FTR] use xpath locator to find particular element in group by index (#161202) (#163291) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[FTR] use xpath locator to find particular element in group by index
(#161202)](https://github.com/elastic/kibana/pull/161202)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-08-07T11:39:29Z","message":"[FTR]
use xpath locator to find particular element in group by index
(#161202)\n\nRelated to #158972\r\n\r\nI was able to reproduce the
failure locally on the latest main with a\r\nsmall code
change:\r\n\r\n\r\nb3d7b71076/test/functional/page_objects/visual_builder_page.ts (L867-L869)\r\n\r\n```\r\n
| debg comboBox.isOptionSelected, value: machine.os.raw\r\n │ info
Taking screenshot
\"/Users/dmle/github/kibana/test/functional/screenshots/failure/visualize
app visual builder Time Series basics Clicking on the chart should
cre-a71516dab48cdb296c45e2b439ed3965cfd400204827bba7ce3cf4719afb093b.png\"\r\n
│ info Current URL is:
http://localhost:5620/app/visualize#/create?type=metrics&_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-22T18:31:44.000Z%27))&_a=(filters:!(),linked:!f,query:(language:kuery,query:%27%27),uiState:(),vis:(aggs:!(),params:(axis_formatter:number,axis_position:left,axis_scale:normal,drop_last_bucket:1,id:b6ee5181-addb-436f-8190-4f2a178fee7b,index_pattern:(id:%27logstash-*%27),interval:%27%27,isModelInvalid:!f,max_lines_legend:1,series:!((axis_position:right,chart_type:line,color:%2368BC00,fill:0.5,formatter:default,id:%2724f639d7-d16e-44d1-ac0d-f2b590e94e8e%27,line_width:1,metrics:!((id:d4f68ace-b844-4e00-933f-8c3b49e19067,type:count)),override_index_pattern:0,palette:(name:default,type:palette),point_size:1,separate_axis:0,series_drop_last_bucket:0,split_mode:terms,stacked:none,terms_field:!(bytes,machine.os.raw),time_range_mode:entire_time_range)),show_grid:1,show_legend:1,time_field:%27%27,time_range_mode:entire_time_range,tooltip_mode:show_all,truncate_legend:1,type:timeseries,use_kibana_indexes:!t),title:%27%27,type:metrics))\r\n
│ info Saving page source to:
/Users/dmle/github/kibana/test/functional/failure_debug/html/visualize
app visual builder Time Series basics Clicking on the chart should
cre-a71516dab48cdb296c45e2b439ed3965cfd400204827bba7ce3cf4719afb093b.html\r\n
└- ✖ fail: visualize app visual builder Time Series basics Clicking on
the chart should create a filter for series with multiple split by terms
fields one of which has formatting\r\n │ StaleElementReferenceError:
stale element reference: stale element not found\r\n │ (Session info:
chrome=114.0.5735.198)\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
runMicrotasks (<anonymous>)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Task.exec
(prevent_parallel_calls.ts:28:20)\r\n```\r\n\r\n### Do we have any
service to help with StaleElementReferenceError\r\nhandling in
FTR?\r\n\r\nWe do. `WebElementWrapper` object have internal mechanism to
handle it:\r\nwe wrap most of the actions (click, type, getAttribute,
etc.) with\r\n`retryCall` function, which execute command up to
RETRY_MAX_ATTEMPTS\r\ntimes (3 by default) and check for errors. So if
we try to click element\r\nthat is no longer in the DOM, this mechanism
will try to find the\r\nelement in the DOM again, assuming it is still
there but referenceId was\r\nchanged due to page updates. And repeat the
click.\r\n\r\nhttps://github.com/elastic/kibana/blob/main/test/functional/services/lib/web_element_wrapper/web_element_wrapper.ts#L107-L140\r\n\r\nYou
might notice a warning during timePicker dates selection\r\n```\r\n │
debg
Find.findByCssSelector('[data-test-subj=\"superDatePickerAbsoluteTab\"]')
with timeout=10000\r\n │ warn WebElementWrapper.click:
StaleElementReferenceError: stale element reference: stale element not
found\r\n │ (Session info: chrome=114.0.5735.198)\r\n │ debg Searching
again for the element 'By(css selector,
[data-test-subj=\"superDatePickerAbsoluteTab\"])',\r\n | 2 attempts
left\r\n```\r\nIt is helping a lot to minimize the flakiness.\r\n\r\n###
Why does FTR still fails with StaleElementReferenceError in\r\nVisualize
tests?\r\nBecause most methods use the same pattern for searching
elements in the\r\nDOM: get all elements and then pick one by
index.\r\n\r\n```\r\nconst byFields = await
this.testSubjects.findAll('fieldSelectItem');\r\nconst selectedByField =
byFields[byFields.length - 1];\r\nawait
this.comboBox.setElement(selectedByField, field);\r\n```\r\n\r\nThe
problem is that WebElementWrapper retry mechanism relies on
having\r\n`locator` property defined and it is _only_ defined if you
search for a\r\nsingle element, e.g. `testSubjects.find` or
`by.byCssSelector`. This\r\nproperty is set to `null` for each
`WebElementWrapper` object in array\r\nyou get from `await
this.testSubjects.findAll('fieldSelectItem')`;\r\nSo when we pass this
object in `this.comboBox.setElement` and go through\r\na list of
actions, it will fail on the first
StaleElementReferenceError\r\noccurrence.\r\n\r\nThe devil is in the
detail: usually searching for multiple elements and\r\ndoing actions on
some of it is totally fine. But comboBox selection has\r\nquite many
actions with different child elements, that can be updated in\r\nDOM and
lead to the error. Wrapping things with classical `retry`\r\nservice
only hides the issue, but does not actually solve it.\r\n\r\n###
Proposed solution\r\nAfaik CSS locators does not support searching for
elements and picking\r\nup one by index (I looked at `:nth-child()\r\n`,
but it is not what we need).\r\nBut we can use xpath locators for this
purpose. \r\n```\r\nconst selectedByField = await
this.find.byXPath(`(//*[@data-test-subj='fieldSelectItem'])[last()]`);\r\nawait
this.comboBox.setElement(selectedByField, field);\r\n```\r\n\r\nThis way
`selectedByField` has locator property defined and internal\r\nmechanism
will be able to retry actions.\r\n\r\n#### Why don't we store `locator`
for multiple elements search.\r\nWe can, but it means every element in
array has the same locator and\r\nwhile retrying to find it WebDriver
will return the first one in the DOM\r\nignoring the element index.
Using xpath locator is basically the simpler\r\nversion of storing
element index in WebElementWrapper object.\r\n\r\nFlaky test runner: 50x
for
visualize/group1..5/config.ts\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2554\r\n\r\n100x
for
group5\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2596#0189403c-ccd2-4186-a83e-af21fe88018c\r\n\r\n100x
flaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2794","sha":"8e1d66fab6d09ec01946672911e874dc8a9d2050","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test_ui_functional","release_note:skip","v8.10.0","v8.9.1"],"number":161202,"url":"https://github.com/elastic/kibana/pull/161202","mergeCommit":{"message":"[FTR]
use xpath locator to find particular element in group by index
(#161202)\n\nRelated to #158972\r\n\r\nI was able to reproduce the
failure locally on the latest main with a\r\nsmall code
change:\r\n\r\n\r\nb3d7b71076/test/functional/page_objects/visual_builder_page.ts (L867-L869)\r\n\r\n```\r\n
| debg comboBox.isOptionSelected, value: machine.os.raw\r\n │ info
Taking screenshot
\"/Users/dmle/github/kibana/test/functional/screenshots/failure/visualize
app visual builder Time Series basics Clicking on the chart should
cre-a71516dab48cdb296c45e2b439ed3965cfd400204827bba7ce3cf4719afb093b.png\"\r\n
│ info Current URL is:
http://localhost:5620/app/visualize#/create?type=metrics&_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-22T18:31:44.000Z%27))&_a=(filters:!(),linked:!f,query:(language:kuery,query:%27%27),uiState:(),vis:(aggs:!(),params:(axis_formatter:number,axis_position:left,axis_scale:normal,drop_last_bucket:1,id:b6ee5181-addb-436f-8190-4f2a178fee7b,index_pattern:(id:%27logstash-*%27),interval:%27%27,isModelInvalid:!f,max_lines_legend:1,series:!((axis_position:right,chart_type:line,color:%2368BC00,fill:0.5,formatter:default,id:%2724f639d7-d16e-44d1-ac0d-f2b590e94e8e%27,line_width:1,metrics:!((id:d4f68ace-b844-4e00-933f-8c3b49e19067,type:count)),override_index_pattern:0,palette:(name:default,type:palette),point_size:1,separate_axis:0,series_drop_last_bucket:0,split_mode:terms,stacked:none,terms_field:!(bytes,machine.os.raw),time_range_mode:entire_time_range)),show_grid:1,show_legend:1,time_field:%27%27,time_range_mode:entire_time_range,tooltip_mode:show_all,truncate_legend:1,type:timeseries,use_kibana_indexes:!t),title:%27%27,type:metrics))\r\n
│ info Saving page source to:
/Users/dmle/github/kibana/test/functional/failure_debug/html/visualize
app visual builder Time Series basics Clicking on the chart should
cre-a71516dab48cdb296c45e2b439ed3965cfd400204827bba7ce3cf4719afb093b.html\r\n
└- ✖ fail: visualize app visual builder Time Series basics Clicking on
the chart should create a filter for series with multiple split by terms
fields one of which has formatting\r\n │ StaleElementReferenceError:
stale element reference: stale element not found\r\n │ (Session info:
chrome=114.0.5735.198)\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
runMicrotasks (<anonymous>)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Task.exec
(prevent_parallel_calls.ts:28:20)\r\n```\r\n\r\n### Do we have any
service to help with StaleElementReferenceError\r\nhandling in
FTR?\r\n\r\nWe do. `WebElementWrapper` object have internal mechanism to
handle it:\r\nwe wrap most of the actions (click, type, getAttribute,
etc.) with\r\n`retryCall` function, which execute command up to
RETRY_MAX_ATTEMPTS\r\ntimes (3 by default) and check for errors. So if
we try to click element\r\nthat is no longer in the DOM, this mechanism
will try to find the\r\nelement in the DOM again, assuming it is still
there but referenceId was\r\nchanged due to page updates. And repeat the
click.\r\n\r\nhttps://github.com/elastic/kibana/blob/main/test/functional/services/lib/web_element_wrapper/web_element_wrapper.ts#L107-L140\r\n\r\nYou
might notice a warning during timePicker dates selection\r\n```\r\n │
debg
Find.findByCssSelector('[data-test-subj=\"superDatePickerAbsoluteTab\"]')
with timeout=10000\r\n │ warn WebElementWrapper.click:
StaleElementReferenceError: stale element reference: stale element not
found\r\n │ (Session info: chrome=114.0.5735.198)\r\n │ debg Searching
again for the element 'By(css selector,
[data-test-subj=\"superDatePickerAbsoluteTab\"])',\r\n | 2 attempts
left\r\n```\r\nIt is helping a lot to minimize the flakiness.\r\n\r\n###
Why does FTR still fails with StaleElementReferenceError in\r\nVisualize
tests?\r\nBecause most methods use the same pattern for searching
elements in the\r\nDOM: get all elements and then pick one by
index.\r\n\r\n```\r\nconst byFields = await
this.testSubjects.findAll('fieldSelectItem');\r\nconst selectedByField =
byFields[byFields.length - 1];\r\nawait
this.comboBox.setElement(selectedByField, field);\r\n```\r\n\r\nThe
problem is that WebElementWrapper retry mechanism relies on
having\r\n`locator` property defined and it is _only_ defined if you
search for a\r\nsingle element, e.g. `testSubjects.find` or
`by.byCssSelector`. This\r\nproperty is set to `null` for each
`WebElementWrapper` object in array\r\nyou get from `await
this.testSubjects.findAll('fieldSelectItem')`;\r\nSo when we pass this
object in `this.comboBox.setElement` and go through\r\na list of
actions, it will fail on the first
StaleElementReferenceError\r\noccurrence.\r\n\r\nThe devil is in the
detail: usually searching for multiple elements and\r\ndoing actions on
some of it is totally fine. But comboBox selection has\r\nquite many
actions with different child elements, that can be updated in\r\nDOM and
lead to the error. Wrapping things with classical `retry`\r\nservice
only hides the issue, but does not actually solve it.\r\n\r\n###
Proposed solution\r\nAfaik CSS locators does not support searching for
elements and picking\r\nup one by index (I looked at `:nth-child()\r\n`,
but it is not what we need).\r\nBut we can use xpath locators for this
purpose. \r\n```\r\nconst selectedByField = await
this.find.byXPath(`(//*[@data-test-subj='fieldSelectItem'])[last()]`);\r\nawait
this.comboBox.setElement(selectedByField, field);\r\n```\r\n\r\nThis way
`selectedByField` has locator property defined and internal\r\nmechanism
will be able to retry actions.\r\n\r\n#### Why don't we store `locator`
for multiple elements search.\r\nWe can, but it means every element in
array has the same locator and\r\nwhile retrying to find it WebDriver
will return the first one in the DOM\r\nignoring the element index.
Using xpath locator is basically the simpler\r\nversion of storing
element index in WebElementWrapper object.\r\n\r\nFlaky test runner: 50x
for
visualize/group1..5/config.ts\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2554\r\n\r\n100x
for
group5\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2596#0189403c-ccd2-4186-a83e-af21fe88018c\r\n\r\n100x
flaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2794","sha":"8e1d66fab6d09ec01946672911e874dc8a9d2050"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161202","number":161202,"mergeCommit":{"message":"[FTR]
use xpath locator to find particular element in group by index
(#161202)\n\nRelated to #158972\r\n\r\nI was able to reproduce the
failure locally on the latest main with a\r\nsmall code
change:\r\n\r\n\r\nb3d7b71076/test/functional/page_objects/visual_builder_page.ts (L867-L869)\r\n\r\n```\r\n
| debg comboBox.isOptionSelected, value: machine.os.raw\r\n │ info
Taking screenshot
\"/Users/dmle/github/kibana/test/functional/screenshots/failure/visualize
app visual builder Time Series basics Clicking on the chart should
cre-a71516dab48cdb296c45e2b439ed3965cfd400204827bba7ce3cf4719afb093b.png\"\r\n
│ info Current URL is:
http://localhost:5620/app/visualize#/create?type=metrics&_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-22T18:31:44.000Z%27))&_a=(filters:!(),linked:!f,query:(language:kuery,query:%27%27),uiState:(),vis:(aggs:!(),params:(axis_formatter:number,axis_position:left,axis_scale:normal,drop_last_bucket:1,id:b6ee5181-addb-436f-8190-4f2a178fee7b,index_pattern:(id:%27logstash-*%27),interval:%27%27,isModelInvalid:!f,max_lines_legend:1,series:!((axis_position:right,chart_type:line,color:%2368BC00,fill:0.5,formatter:default,id:%2724f639d7-d16e-44d1-ac0d-f2b590e94e8e%27,line_width:1,metrics:!((id:d4f68ace-b844-4e00-933f-8c3b49e19067,type:count)),override_index_pattern:0,palette:(name:default,type:palette),point_size:1,separate_axis:0,series_drop_last_bucket:0,split_mode:terms,stacked:none,terms_field:!(bytes,machine.os.raw),time_range_mode:entire_time_range)),show_grid:1,show_legend:1,time_field:%27%27,time_range_mode:entire_time_range,tooltip_mode:show_all,truncate_legend:1,type:timeseries,use_kibana_indexes:!t),title:%27%27,type:metrics))\r\n
│ info Saving page source to:
/Users/dmle/github/kibana/test/functional/failure_debug/html/visualize
app visual builder Time Series basics Clicking on the chart should
cre-a71516dab48cdb296c45e2b439ed3965cfd400204827bba7ce3cf4719afb093b.html\r\n
└- ✖ fail: visualize app visual builder Time Series basics Clicking on
the chart should create a filter for series with multiple split by terms
fields one of which has formatting\r\n │ StaleElementReferenceError:
stale element reference: stale element not found\r\n │ (Session info:
chrome=114.0.5735.198)\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
runMicrotasks (<anonymous>)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Task.exec
(prevent_parallel_calls.ts:28:20)\r\n```\r\n\r\n### Do we have any
service to help with StaleElementReferenceError\r\nhandling in
FTR?\r\n\r\nWe do. `WebElementWrapper` object have internal mechanism to
handle it:\r\nwe wrap most of the actions (click, type, getAttribute,
etc.) with\r\n`retryCall` function, which execute command up to
RETRY_MAX_ATTEMPTS\r\ntimes (3 by default) and check for errors. So if
we try to click element\r\nthat is no longer in the DOM, this mechanism
will try to find the\r\nelement in the DOM again, assuming it is still
there but referenceId was\r\nchanged due to page updates. And repeat the
click.\r\n\r\nhttps://github.com/elastic/kibana/blob/main/test/functional/services/lib/web_element_wrapper/web_element_wrapper.ts#L107-L140\r\n\r\nYou
might notice a warning during timePicker dates selection\r\n```\r\n │
debg
Find.findByCssSelector('[data-test-subj=\"superDatePickerAbsoluteTab\"]')
with timeout=10000\r\n │ warn WebElementWrapper.click:
StaleElementReferenceError: stale element reference: stale element not
found\r\n │ (Session info: chrome=114.0.5735.198)\r\n │ debg Searching
again for the element 'By(css selector,
[data-test-subj=\"superDatePickerAbsoluteTab\"])',\r\n | 2 attempts
left\r\n```\r\nIt is helping a lot to minimize the flakiness.\r\n\r\n###
Why does FTR still fails with StaleElementReferenceError in\r\nVisualize
tests?\r\nBecause most methods use the same pattern for searching
elements in the\r\nDOM: get all elements and then pick one by
index.\r\n\r\n```\r\nconst byFields = await
this.testSubjects.findAll('fieldSelectItem');\r\nconst selectedByField =
byFields[byFields.length - 1];\r\nawait
this.comboBox.setElement(selectedByField, field);\r\n```\r\n\r\nThe
problem is that WebElementWrapper retry mechanism relies on
having\r\n`locator` property defined and it is _only_ defined if you
search for a\r\nsingle element, e.g. `testSubjects.find` or
`by.byCssSelector`. This\r\nproperty is set to `null` for each
`WebElementWrapper` object in array\r\nyou get from `await
this.testSubjects.findAll('fieldSelectItem')`;\r\nSo when we pass this
object in `this.comboBox.setElement` and go through\r\na list of
actions, it will fail on the first
StaleElementReferenceError\r\noccurrence.\r\n\r\nThe devil is in the
detail: usually searching for multiple elements and\r\ndoing actions on
some of it is totally fine. But comboBox selection has\r\nquite many
actions with different child elements, that can be updated in\r\nDOM and
lead to the error. Wrapping things with classical `retry`\r\nservice
only hides the issue, but does not actually solve it.\r\n\r\n###
Proposed solution\r\nAfaik CSS locators does not support searching for
elements and picking\r\nup one by index (I looked at `:nth-child()\r\n`,
but it is not what we need).\r\nBut we can use xpath locators for this
purpose. \r\n```\r\nconst selectedByField = await
this.find.byXPath(`(//*[@data-test-subj='fieldSelectItem'])[last()]`);\r\nawait
this.comboBox.setElement(selectedByField, field);\r\n```\r\n\r\nThis way
`selectedByField` has locator property defined and internal\r\nmechanism
will be able to retry actions.\r\n\r\n#### Why don't we store `locator`
for multiple elements search.\r\nWe can, but it means every element in
array has the same locator and\r\nwhile retrying to find it WebDriver
will return the first one in the DOM\r\nignoring the element index.
Using xpath locator is basically the simpler\r\nversion of storing
element index in WebElementWrapper object.\r\n\r\nFlaky test runner: 50x
for
visualize/group1..5/config.ts\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2554\r\n\r\n100x
for
group5\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2596#0189403c-ccd2-4186-a83e-af21fe88018c\r\n\r\n100x
flaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2794","sha":"8e1d66fab6d09ec01946672911e874dc8a9d2050"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
 2023-08-07 05:53:47 -07:00
Kibana Machine
1906969726
[8.9] [ftr/WebElementWrapper] workaround for chromedriver incorrect error response (#163231) (#163285) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[ftr/WebElementWrapper] workaround for chromedriver incorrect error
response (#163231)](https://github.com/elastic/kibana/pull/163231)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-08-07T10:32:02Z","message":"[ftr/WebElementWrapper]
workaround for chromedriver incorrect error response
(#163231)\n\nRelated to #156821\r\n\r\nIt seems like Chromedriver 115
has regression again: sometimes it\r\nreturns NoSuchElementError instead
of
StaleElementReferenceError.\r\n[chromedriver/issues#534](https://bugs.chromium.org/p/chromedriver/issues/detail?id=4534)\r\n\r\nThe
fix on our side is by adding error message to retry list. The
list\r\nreferences the errors we would like to retry command on. It only
work\r\nfor single element search where we store locator.\r\nE.g. it
will help with retrying on\r\n\r\n```\r\nawait
testSubjects.click('...');\r\n```\r\n\r\nbut still fail when you
do\r\n\r\n```\r\nconst elements = await
testSubjects.findAll('...');\r\nawait
elements[1].click();\r\n```\r\n\r\nFor viz tests stability I suggest
reviewing
#161202","sha":"585d108db7dc2239c274453964bc04ce2993f7a3","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.10.0","v8.9.1"],"number":163231,"url":"https://github.com/elastic/kibana/pull/163231","mergeCommit":{"message":"[ftr/WebElementWrapper]
workaround for chromedriver incorrect error response
(#163231)\n\nRelated to #156821\r\n\r\nIt seems like Chromedriver 115
has regression again: sometimes it\r\nreturns NoSuchElementError instead
of
StaleElementReferenceError.\r\n[chromedriver/issues#534](https://bugs.chromium.org/p/chromedriver/issues/detail?id=4534)\r\n\r\nThe
fix on our side is by adding error message to retry list. The
list\r\nreferences the errors we would like to retry command on. It only
work\r\nfor single element search where we store locator.\r\nE.g. it
will help with retrying on\r\n\r\n```\r\nawait
testSubjects.click('...');\r\n```\r\n\r\nbut still fail when you
do\r\n\r\n```\r\nconst elements = await
testSubjects.findAll('...');\r\nawait
elements[1].click();\r\n```\r\n\r\nFor viz tests stability I suggest
reviewing
#161202","sha":"585d108db7dc2239c274453964bc04ce2993f7a3"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163231","number":163231,"mergeCommit":{"message":"[ftr/WebElementWrapper]
workaround for chromedriver incorrect error response
(#163231)\n\nRelated to #156821\r\n\r\nIt seems like Chromedriver 115
has regression again: sometimes it\r\nreturns NoSuchElementError instead
of
StaleElementReferenceError.\r\n[chromedriver/issues#534](https://bugs.chromium.org/p/chromedriver/issues/detail?id=4534)\r\n\r\nThe
fix on our side is by adding error message to retry list. The
list\r\nreferences the errors we would like to retry command on. It only
work\r\nfor single element search where we store locator.\r\nE.g. it
will help with retrying on\r\n\r\n```\r\nawait
testSubjects.click('...');\r\n```\r\n\r\nbut still fail when you
do\r\n\r\n```\r\nconst elements = await
testSubjects.findAll('...');\r\nawait
elements[1].click();\r\n```\r\n\r\nFor viz tests stability I suggest
reviewing
#161202","sha":"585d108db7dc2239c274453964bc04ce2993f7a3"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
 2023-08-07 04:35:27 -07:00
Kibana Machine
ad47e5faf8
[8.9] [data views] fix renamed field filters (#162860) (#163047) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[data views] fix renamed field filters
(#162860)](https://github.com/elastic/kibana/pull/162860)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2023-08-03T10:48:40Z","message":"[data
views] fix renamed field filters (#162860)\n\n## Summary\r\n\r\nField
filters (aka source filters) are given a `clientId` when
they're\r\nchanged. Unfortunately this is missing from the schema which
can result\r\nin schema failures.\r\n\r\nThe schema has been fixed and a
functional test has been added that\r\nverifies field filter renaming
functionality.\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/162611\r\n\r\n## Release
Note\r\n\r\nResolves potential errors present in v8.9.0 with data views
that contain\r\nfield filters that have been
edited.","sha":"d9f5223e2de3815da750cbb8ef6db8994fa087c5","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Data
Views","Team:DataDiscovery","backport:prev-minor","v8.10.0"],"number":162860,"url":"https://github.com/elastic/kibana/pull/162860","mergeCommit":{"message":"[data
views] fix renamed field filters (#162860)\n\n## Summary\r\n\r\nField
filters (aka source filters) are given a `clientId` when
they're\r\nchanged. Unfortunately this is missing from the schema which
can result\r\nin schema failures.\r\n\r\nThe schema has been fixed and a
functional test has been added that\r\nverifies field filter renaming
functionality.\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/162611\r\n\r\n## Release
Note\r\n\r\nResolves potential errors present in v8.9.0 with data views
that contain\r\nfield filters that have been
edited.","sha":"d9f5223e2de3815da750cbb8ef6db8994fa087c5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162860","number":162860,"mergeCommit":{"message":"[data
views] fix renamed field filters (#162860)\n\n## Summary\r\n\r\nField
filters (aka source filters) are given a `clientId` when
they're\r\nchanged. Unfortunately this is missing from the schema which
can result\r\nin schema failures.\r\n\r\nThe schema has been fixed and a
functional test has been added that\r\nverifies field filter renaming
functionality.\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/162611\r\n\r\n## Release
Note\r\n\r\nResolves potential errors present in v8.9.0 with data views
that contain\r\nfield filters that have been
edited.","sha":"d9f5223e2de3815da750cbb8ef6db8994fa087c5"}}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <matt@mattki.me>
 2023-08-03 04:59:10 -07:00
Kibana Machine
a5860bf113
[8.9] [Files management] Fix flaky functional test (#162146) (#162305) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Files management] Fix flaky functional test
(#162146)](https://github.com/elastic/kibana/pull/162146)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sébastien
Loix","email":"sebastien.loix@elastic.co"},"sourceCommit":{"committedDate":"2023-07-18T14:40:51Z","message":"[Files
management] Fix flaky functional test
(#162146)","sha":"fde21b15de69831e5b2b9f3df919b9d6d13ccebd","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:SharedUX","backport:prev-minor","v8.10.0"],"number":162146,"url":"https://github.com/elastic/kibana/pull/162146","mergeCommit":{"message":"[Files
management] Fix flaky functional test
(#162146)","sha":"fde21b15de69831e5b2b9f3df919b9d6d13ccebd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162146","number":162146,"mergeCommit":{"message":"[Files
management] Fix flaky functional test
(#162146)","sha":"fde21b15de69831e5b2b9f3df919b9d6d13ccebd"}}]}]
BACKPORT-->

Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
 2023-07-20 02:43:12 -07:00
Kibana Machine
c4a50984b0
[8.9] [TableListView] Fix regression when resetting search (#162034) (#162211) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[TableListView] Fix regression when resetting search
(#162034)](https://github.com/elastic/kibana/pull/162034)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sébastien
Loix","email":"sebastien.loix@elastic.co"},"sourceCommit":{"committedDate":"2023-07-18T11:47:01Z","message":"[TableListView]
Fix regression when resetting search
(#162034)","sha":"c6deb252b2a2830ad1d689c476517f783247206b","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:SharedUX","Feature:Content
Management","backport:prev-minor","Component:TableListView","v8.10.0"],"number":162034,"url":"https://github.com/elastic/kibana/pull/162034","mergeCommit":{"message":"[TableListView]
Fix regression when resetting search
(#162034)","sha":"c6deb252b2a2830ad1d689c476517f783247206b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162034","number":162034,"mergeCommit":{"message":"[TableListView]
Fix regression when resetting search
(#162034)","sha":"c6deb252b2a2830ad1d689c476517f783247206b"}}]}]
BACKPORT-->

Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
 2023-07-19 02:21:22 -07:00
Kibana Machine
2c773db67e
[8.9] convert more tests to use uiSettings for timePicker (#161737) (#162133) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [convert more tests to use uiSettings for timePicker
(#161737)](https://github.com/elastic/kibana/pull/161737)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-07-18T11:27:47Z","message":"convert
more tests to use uiSettings for timePicker (#161737)\n\nWhile searching
in test files, I found few more places to
replace\r\n`PageObjects.timePicker.setAbsoluteRange`
with\r\n`PageObjects.common.setTime`.\r\n\r\nBefore changing I reviewed
tests if it is not important to select\r\ndatePicker via UI component,
but please double check scenarios because I\r\nmight miss the
context.","sha":"72907cfe1eca4019a2ba6565e690d15a7dbab49d","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","FTR","v8.10.0","v8.9.1"],"number":161737,"url":"https://github.com/elastic/kibana/pull/161737","mergeCommit":{"message":"convert
more tests to use uiSettings for timePicker (#161737)\n\nWhile searching
in test files, I found few more places to
replace\r\n`PageObjects.timePicker.setAbsoluteRange`
with\r\n`PageObjects.common.setTime`.\r\n\r\nBefore changing I reviewed
tests if it is not important to select\r\ndatePicker via UI component,
but please double check scenarios because I\r\nmight miss the
context.","sha":"72907cfe1eca4019a2ba6565e690d15a7dbab49d"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161737","number":161737,"mergeCommit":{"message":"convert
more tests to use uiSettings for timePicker (#161737)\n\nWhile searching
in test files, I found few more places to
replace\r\n`PageObjects.timePicker.setAbsoluteRange`
with\r\n`PageObjects.common.setTime`.\r\n\r\nBefore changing I reviewed
tests if it is not important to select\r\ndatePicker via UI component,
but please double check scenarios because I\r\nmight miss the
context.","sha":"72907cfe1eca4019a2ba6565e690d15a7dbab49d"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
 2023-07-18 05:25:38 -07:00
Kibana Machine
12b806f39e
[8.9] [Discover] Fix duplicate request in Discover when adding a filter (#161992) (#162053) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Discover] Fix duplicate request in Discover when adding a filter
(#161992)](https://github.com/elastic/kibana/pull/161992)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Davis
McPhee","email":"davis.mcphee@elastic.co"},"sourceCommit":{"committedDate":"2023-07-17T13:52:51Z","message":"[Discover]
Fix duplicate request in Discover when adding a filter (#161992)\n\nThis
PR fixes a bug in Discover that can cause a duplicate request to
be\r\nsent when adding a filter under certain circumstances. It also
reenables\r\nthe flaky tests that were skipped in #161157 which were
failing due to\r\nthis bug.\r\n\r\nFlaky test runs:\r\n-
x50:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2645\r\n🔴\r\n-
x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2646\r\n🔴\r\n-
x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2647\r\n🟢\r\n\r\nResolves
#161157.","sha":"9191bd9939b95ed48b1bd411d527ce287a96fae5","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","Team:DataDiscovery","v8.9.0","v8.10.0"],"number":161992,"url":"https://github.com/elastic/kibana/pull/161992","mergeCommit":{"message":"[Discover]
Fix duplicate request in Discover when adding a filter (#161992)\n\nThis
PR fixes a bug in Discover that can cause a duplicate request to
be\r\nsent when adding a filter under certain circumstances. It also
reenables\r\nthe flaky tests that were skipped in #161157 which were
failing due to\r\nthis bug.\r\n\r\nFlaky test runs:\r\n-
x50:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2645\r\n🔴\r\n-
x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2646\r\n🔴\r\n-
x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2647\r\n🟢\r\n\r\nResolves
#161157.","sha":"9191bd9939b95ed48b1bd411d527ce287a96fae5"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161992","number":161992,"mergeCommit":{"message":"[Discover]
Fix duplicate request in Discover when adding a filter (#161992)\n\nThis
PR fixes a bug in Discover that can cause a duplicate request to
be\r\nsent when adding a filter under certain circumstances. It also
reenables\r\nthe flaky tests that were skipped in #161157 which were
failing due to\r\nthis bug.\r\n\r\nFlaky test runs:\r\n-
x50:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2645\r\n🔴\r\n-
x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2646\r\n🔴\r\n-
x100:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2647\r\n🟢\r\n\r\nResolves
#161157.","sha":"9191bd9939b95ed48b1bd411d527ce287a96fae5"}}]}]
BACKPORT-->

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
 2023-07-17 08:05:30 -07:00
Kibana Machine
79d6593e23
[8.9] [ftr] migrate time picker GUI selection to uiSettings API call (#161642) (#161725) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[ftr] migrate time picker GUI selection to uiSettings API call
(#161642)](https://github.com/elastic/kibana/pull/161642)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-07-12T07:06:53Z","message":"[ftr]
migrate time picker GUI selection to uiSettings API call
(#161642)\n\ncloses #113998\r\n\r\nIn order to make FTR functional tests
faster and less flaky, we started\r\nmigrating time picker selection
from UI action to Kibana API call:\r\n\r\n```\r\n await
this.kibanaServer.uiSettings.update({\r\n 'timepicker:timeDefaults': `{
\"from\": <startTime>, \"to\": <endTime>}`,\r\n });\r\n```\r\n\r\nIn
this PR I updated most of the tests listed in the meta issue, so
we\r\ncan close it.\r\n\r\nFlaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2606","sha":"85a99c954f386bfa6291b266fe94a1456e312b25","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.10.0","v8.8.3","v8.9.1"],"number":161642,"url":"https://github.com/elastic/kibana/pull/161642","mergeCommit":{"message":"[ftr]
migrate time picker GUI selection to uiSettings API call
(#161642)\n\ncloses #113998\r\n\r\nIn order to make FTR functional tests
faster and less flaky, we started\r\nmigrating time picker selection
from UI action to Kibana API call:\r\n\r\n```\r\n await
this.kibanaServer.uiSettings.update({\r\n 'timepicker:timeDefaults': `{
\"from\": <startTime>, \"to\": <endTime>}`,\r\n });\r\n```\r\n\r\nIn
this PR I updated most of the tests listed in the meta issue, so
we\r\ncan close it.\r\n\r\nFlaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2606","sha":"85a99c954f386bfa6291b266fe94a1456e312b25"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161642","number":161642,"mergeCommit":{"message":"[ftr]
migrate time picker GUI selection to uiSettings API call
(#161642)\n\ncloses #113998\r\n\r\nIn order to make FTR functional tests
faster and less flaky, we started\r\nmigrating time picker selection
from UI action to Kibana API call:\r\n\r\n```\r\n await
this.kibanaServer.uiSettings.update({\r\n 'timepicker:timeDefaults': `{
\"from\": <startTime>, \"to\": <endTime>}`,\r\n });\r\n```\r\n\r\nIn
this PR I updated most of the tests listed in the meta issue, so
we\r\ncan close it.\r\n\r\nFlaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2606","sha":"85a99c954f386bfa6291b266fe94a1456e312b25"}},{"branch":"8.8","label":"v8.8.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
 2023-07-12 01:19:08 -07:00
Kibana Machine
4af53fe273
[8.9] [Discover] Fix shared links flaky test (#161172) (#161212) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Discover] Fix shared links flaky test
(#161172)](https://github.com/elastic/kibana/pull/161172)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-07-04T16:46:47Z","message":"[Discover]
Fix shared links flaky test (#161172)\n\n- Closes
https://github.com/elastic/kibana/issues/158465\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2550","sha":"bfab1b0659269cf67d6a864d6a80ee29632b4b4c","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.10.0"],"number":161172,"url":"https://github.com/elastic/kibana/pull/161172","mergeCommit":{"message":"[Discover]
Fix shared links flaky test (#161172)\n\n- Closes
https://github.com/elastic/kibana/issues/158465\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2550","sha":"bfab1b0659269cf67d6a864d6a80ee29632b4b4c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161172","number":161172,"mergeCommit":{"message":"[Discover]
Fix shared links flaky test (#161172)\n\n- Closes
https://github.com/elastic/kibana/issues/158465\r\n\r\n100x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2550","sha":"bfab1b0659269cf67d6a864d6a80ee29632b4b4c"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
 2023-07-04 10:46:17 -07:00
Kibana Machine
474c1813f3
[8.9] [ftr] Improve FTR error handling for NoSuchSessionError (#161025) (#161207) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[ftr] Improve FTR error handling for NoSuchSessionError
(#161025)](https://github.com/elastic/kibana/pull/161025)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-07-04T16:26:57Z","message":"[ftr]
Improve FTR error handling for NoSuchSessionError (#161025)\n\n##
Summary\r\n\r\nSometimes browser/driver process dies during test run on
CI and FTR\r\nfails with errors cascade, good example
is\r\n[here](https://buildkite.com/elastic/kibana-pull-request/builds/138535#0188fd74-9adf-4011-8168-1bdc6e3d0f17)\r\n\r\n\r\n\r\nCurrent
behaviour on `main`: FTR lifecycle hooks, defined
in\r\n[remote](57aea91fae/test/functional/services/remote/remote.ts)\r\nservice,
has no access to the information about test suite run and\r\nparticular
test failure. These hooks are related to WebDriver (browser)\r\nstate
management and suppose to reset it to default state.\r\nCurrently we
silently fail screenshot taking which means tests execution\r\nis
continued even if `--bail` flag is passed. It ends with cascade
of\r\nfailures with the same error `NoSuchSessionError: invalid session
id`\r\n\r\n<details>\r\n\r\n<summary>FTR output on
failure</summary>\r\n\r\n```\r\n └- ✖ fail: discover/group1 discover
test query should show correct time range string by timepicker\r\n │
Error: expected 'Sep 19, 2015 @ 06:31:44.000' to equal 'Sep 23, 2015 @
18:31:44.000'\r\n │ at Assertion.assert (expect.js💯11)\r\n │ at
Assertion.apply (expect.js:227:8)\r\n │ at Assertion.be
(expect.js:69:22)\r\n │ at Context.<anonymous> (_discover.ts:53:31)\r\n
│ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Object.apply
(wrap_function.js:73:16)\r\n │\r\n │\r\n └-> \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\"\r\n └- ✖ fail:
discover/group1 discover test query \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\"\r\n │
NoSuchSessionError: invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n └->
\"after all\" hook in \"discover test\"\r\n │ debg Cleaning all saved
objects { space: undefined }\r\n │ succ deleted 2 objects\r\n └->
\"after all\" hook: afterTestSuite.trigger in \"discover test\"\r\n └- ✖
fail: discover/group1 discover test \"after all\" hook:
afterTestSuite.trigger in \"discover test\"\r\n │ NoSuchSessionError:
invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n └->
\"after all\" hook: unloadMakelogs in \"discover/group1\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"mappings.json\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.22\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.20\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.21\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"data.json.gz\"\r\n └-> \"after all\" hook:
afterTestSuite.trigger in \"discover/group1\"\r\n └- ✖ fail:
discover/group1 \"after all\" hook: afterTestSuite.trigger in
\"discover/group1\"\r\n │ NoSuchSessionError: invalid session id\r\n │
at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
runMicrotasks (<anonymous>)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Task.exec
(prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n │\r\n │0 passing
(15.7s)\r\n │4 failing\r\n │\r\n │1) discover/group1\r\n │ discover
test\r\n │ query\r\n │ should show correct time range string by
timepicker:\r\n │\r\n │ Error: expected 'Sep 19, 2015 @ 06:31:44.000' to
equal 'Sep 23, 2015 @ 18:31:44.000'\r\n │ at Assertion.assert
(expect.js💯11)\r\n │ at Assertion.apply (expect.js:227:8)\r\n │ at
Assertion.be (expect.js:69:22)\r\n │ at Context.<anonymous>
(_discover.ts:53:31)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Object.apply
(wrap_function.js:73:16)\r\n │\r\n │\r\n │2) discover/group1\r\n │
discover test\r\n │ query\r\n │ \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\":\r\n │\r\n │
NoSuchSessionError: invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n │3)
discover/group1\r\n │ discover test\r\n │ \"after all\" hook:
afterTestSuite.trigger in \"discover test\":\r\n │\r\n │
NoSuchSessionError: invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n │4)
discover/group1\r\n │ \"after all\" hook: afterTestSuite.trigger in
\"discover/group1\":\r\n │\r\n │ NoSuchSessionError: invalid session
id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
runMicrotasks (<anonymous>)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Task.exec
(prevent_parallel_calls.ts:28:20)\r\n```\r\n\r\n</details>\r\n\r\nThis
PR change: I didn't find a good reason why we need to fail
silently\r\non screenshot taking. I added a check WebDriver session
status with\r\n`hasOpenWindow` and take failure artefacts only if is
still valid.\r\nNext change is to fail FTR after hooks related to
WebDriver silently:\r\nthere is no help having cascade of the repeated
stacktrace so I wrap\r\nWebDriver call in hooks with `tryWebDriverCall`
that catches the error\r\nand only prints it for
visibility.\r\n\r\n<details>\r\n\r\n<summary>FTR new output on
failure</summary>\r\n\r\n```\r\n │ERROR WebDriver session is no longer
valid.\r\n │ Probably Chrome process crashed when it tried to use more
memory than what was available.\r\n │ERROR Browser is closed, no
artifacts were captured for the failure\r\n └- ✖ fail: discover/group1
discover test query should show correct time range string by
timepicker\r\n │ Error: expected 'Sep 19, 2015 @ 06:31:44.000' to equal
'Sep 23, 2015 @ 18:31:44.000'\r\n │ at Assertion.assert
(expect.js💯11)\r\n │ at Assertion.apply (expect.js:227:8)\r\n │ at
Assertion.be (expect.js:69:22)\r\n │ at Context.<anonymous>
(_discover.ts:53:31)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Object.apply
(wrap_function.js:73:16)\r\n │\r\n │\r\n └-> \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\"\r\n │ERROR WebDriver
session is no longer valid\r\n └-> \"after all\" hook in \"discover
test\"\r\n │ debg Cleaning all saved objects { space: undefined }\r\n │
warn browser[SEVERE] ERROR FETCHING BROWSR LOGS: This driver instance
does not have a valid session ID (did you call WebDriver.quit()?) and
may no longer be used.\r\n │ succ deleted 2 objects\r\n └-> \"after
all\" hook: afterTestSuite.trigger in \"discover test\"\r\n │ERROR
WebDriver session is no longer valid\r\n └-> \"after all\" hook:
unloadMakelogs in \"discover/group1\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"mappings.json\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.22\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.20\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.21\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"data.json.gz\"\r\n └-> \"after all\" hook:
afterTestSuite.trigger in \"discover/group1\"\r\n │ERROR WebDriver
session is no longer valid\r\n\r\n0 passing (16.2s)\r\n1
failing\r\n\r\n1) discover/group1\r\n discover test\r\n query\r\n should
show correct time range string by timepicker:\r\n\r\n Error: expected
'Sep 19, 2015 @ 06:31:44.000' to equal 'Sep 23, 2015 @ 18:31:44.000'\r\n
at Assertion.assert (expect.js💯11)\r\n at Assertion.apply
(expect.js:227:8)\r\n at Assertion.be (expect.js:69:22)\r\n at
Context.<anonymous> (_discover.ts:53:31)\r\n at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n
at Object.apply
(wrap_function.js:73:16)\r\n```\r\n\r\n</details>\r\n\r\n\r\nFlaky-test-runner
verification: started 100x to hopefully catch invalid\r\nsession on
CI\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2539\r\nNote:
locally I was simulating it by calling `this.driver.close()` to\r\nclose
browser before screenshot
taking","sha":"8a95bf7fabe34c601725313c922f95ee0fa641e5","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","v8.10.0","v8.8.3"],"number":161025,"url":"https://github.com/elastic/kibana/pull/161025","mergeCommit":{"message":"[ftr]
Improve FTR error handling for NoSuchSessionError (#161025)\n\n##
Summary\r\n\r\nSometimes browser/driver process dies during test run on
CI and FTR\r\nfails with errors cascade, good example
is\r\n[here](https://buildkite.com/elastic/kibana-pull-request/builds/138535#0188fd74-9adf-4011-8168-1bdc6e3d0f17)\r\n\r\n\r\n\r\nCurrent
behaviour on `main`: FTR lifecycle hooks, defined
in\r\n[remote](57aea91fae/test/functional/services/remote/remote.ts)\r\nservice,
has no access to the information about test suite run and\r\nparticular
test failure. These hooks are related to WebDriver (browser)\r\nstate
management and suppose to reset it to default state.\r\nCurrently we
silently fail screenshot taking which means tests execution\r\nis
continued even if `--bail` flag is passed. It ends with cascade
of\r\nfailures with the same error `NoSuchSessionError: invalid session
id`\r\n\r\n<details>\r\n\r\n<summary>FTR output on
failure</summary>\r\n\r\n```\r\n └- ✖ fail: discover/group1 discover
test query should show correct time range string by timepicker\r\n │
Error: expected 'Sep 19, 2015 @ 06:31:44.000' to equal 'Sep 23, 2015 @
18:31:44.000'\r\n │ at Assertion.assert (expect.js💯11)\r\n │ at
Assertion.apply (expect.js:227:8)\r\n │ at Assertion.be
(expect.js:69:22)\r\n │ at Context.<anonymous> (_discover.ts:53:31)\r\n
│ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Object.apply
(wrap_function.js:73:16)\r\n │\r\n │\r\n └-> \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\"\r\n └- ✖ fail:
discover/group1 discover test query \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\"\r\n │
NoSuchSessionError: invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n └->
\"after all\" hook in \"discover test\"\r\n │ debg Cleaning all saved
objects { space: undefined }\r\n │ succ deleted 2 objects\r\n └->
\"after all\" hook: afterTestSuite.trigger in \"discover test\"\r\n └- ✖
fail: discover/group1 discover test \"after all\" hook:
afterTestSuite.trigger in \"discover test\"\r\n │ NoSuchSessionError:
invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n └->
\"after all\" hook: unloadMakelogs in \"discover/group1\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"mappings.json\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.22\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.20\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.21\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"data.json.gz\"\r\n └-> \"after all\" hook:
afterTestSuite.trigger in \"discover/group1\"\r\n └- ✖ fail:
discover/group1 \"after all\" hook: afterTestSuite.trigger in
\"discover/group1\"\r\n │ NoSuchSessionError: invalid session id\r\n │
at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
runMicrotasks (<anonymous>)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Task.exec
(prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n │\r\n │0 passing
(15.7s)\r\n │4 failing\r\n │\r\n │1) discover/group1\r\n │ discover
test\r\n │ query\r\n │ should show correct time range string by
timepicker:\r\n │\r\n │ Error: expected 'Sep 19, 2015 @ 06:31:44.000' to
equal 'Sep 23, 2015 @ 18:31:44.000'\r\n │ at Assertion.assert
(expect.js💯11)\r\n │ at Assertion.apply (expect.js:227:8)\r\n │ at
Assertion.be (expect.js:69:22)\r\n │ at Context.<anonymous>
(_discover.ts:53:31)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Object.apply
(wrap_function.js:73:16)\r\n │\r\n │\r\n │2) discover/group1\r\n │
discover test\r\n │ query\r\n │ \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\":\r\n │\r\n │
NoSuchSessionError: invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n │3)
discover/group1\r\n │ discover test\r\n │ \"after all\" hook:
afterTestSuite.trigger in \"discover test\":\r\n │\r\n │
NoSuchSessionError: invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n │4)
discover/group1\r\n │ \"after all\" hook: afterTestSuite.trigger in
\"discover/group1\":\r\n │\r\n │ NoSuchSessionError: invalid session
id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
runMicrotasks (<anonymous>)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Task.exec
(prevent_parallel_calls.ts:28:20)\r\n```\r\n\r\n</details>\r\n\r\nThis
PR change: I didn't find a good reason why we need to fail
silently\r\non screenshot taking. I added a check WebDriver session
status with\r\n`hasOpenWindow` and take failure artefacts only if is
still valid.\r\nNext change is to fail FTR after hooks related to
WebDriver silently:\r\nthere is no help having cascade of the repeated
stacktrace so I wrap\r\nWebDriver call in hooks with `tryWebDriverCall`
that catches the error\r\nand only prints it for
visibility.\r\n\r\n<details>\r\n\r\n<summary>FTR new output on
failure</summary>\r\n\r\n```\r\n │ERROR WebDriver session is no longer
valid.\r\n │ Probably Chrome process crashed when it tried to use more
memory than what was available.\r\n │ERROR Browser is closed, no
artifacts were captured for the failure\r\n └- ✖ fail: discover/group1
discover test query should show correct time range string by
timepicker\r\n │ Error: expected 'Sep 19, 2015 @ 06:31:44.000' to equal
'Sep 23, 2015 @ 18:31:44.000'\r\n │ at Assertion.assert
(expect.js💯11)\r\n │ at Assertion.apply (expect.js:227:8)\r\n │ at
Assertion.be (expect.js:69:22)\r\n │ at Context.<anonymous>
(_discover.ts:53:31)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Object.apply
(wrap_function.js:73:16)\r\n │\r\n │\r\n └-> \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\"\r\n │ERROR WebDriver
session is no longer valid\r\n └-> \"after all\" hook in \"discover
test\"\r\n │ debg Cleaning all saved objects { space: undefined }\r\n │
warn browser[SEVERE] ERROR FETCHING BROWSR LOGS: This driver instance
does not have a valid session ID (did you call WebDriver.quit()?) and
may no longer be used.\r\n │ succ deleted 2 objects\r\n └-> \"after
all\" hook: afterTestSuite.trigger in \"discover test\"\r\n │ERROR
WebDriver session is no longer valid\r\n └-> \"after all\" hook:
unloadMakelogs in \"discover/group1\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"mappings.json\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.22\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.20\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.21\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"data.json.gz\"\r\n └-> \"after all\" hook:
afterTestSuite.trigger in \"discover/group1\"\r\n │ERROR WebDriver
session is no longer valid\r\n\r\n0 passing (16.2s)\r\n1
failing\r\n\r\n1) discover/group1\r\n discover test\r\n query\r\n should
show correct time range string by timepicker:\r\n\r\n Error: expected
'Sep 19, 2015 @ 06:31:44.000' to equal 'Sep 23, 2015 @ 18:31:44.000'\r\n
at Assertion.assert (expect.js💯11)\r\n at Assertion.apply
(expect.js:227:8)\r\n at Assertion.be (expect.js:69:22)\r\n at
Context.<anonymous> (_discover.ts:53:31)\r\n at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n
at Object.apply
(wrap_function.js:73:16)\r\n```\r\n\r\n</details>\r\n\r\n\r\nFlaky-test-runner
verification: started 100x to hopefully catch invalid\r\nsession on
CI\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2539\r\nNote:
locally I was simulating it by calling `this.driver.close()` to\r\nclose
browser before screenshot
taking","sha":"8a95bf7fabe34c601725313c922f95ee0fa641e5"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.8"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161025","number":161025,"mergeCommit":{"message":"[ftr]
Improve FTR error handling for NoSuchSessionError (#161025)\n\n##
Summary\r\n\r\nSometimes browser/driver process dies during test run on
CI and FTR\r\nfails with errors cascade, good example
is\r\n[here](https://buildkite.com/elastic/kibana-pull-request/builds/138535#0188fd74-9adf-4011-8168-1bdc6e3d0f17)\r\n\r\n\r\n\r\nCurrent
behaviour on `main`: FTR lifecycle hooks, defined
in\r\n[remote](57aea91fae/test/functional/services/remote/remote.ts)\r\nservice,
has no access to the information about test suite run and\r\nparticular
test failure. These hooks are related to WebDriver (browser)\r\nstate
management and suppose to reset it to default state.\r\nCurrently we
silently fail screenshot taking which means tests execution\r\nis
continued even if `--bail` flag is passed. It ends with cascade
of\r\nfailures with the same error `NoSuchSessionError: invalid session
id`\r\n\r\n<details>\r\n\r\n<summary>FTR output on
failure</summary>\r\n\r\n```\r\n └- ✖ fail: discover/group1 discover
test query should show correct time range string by timepicker\r\n │
Error: expected 'Sep 19, 2015 @ 06:31:44.000' to equal 'Sep 23, 2015 @
18:31:44.000'\r\n │ at Assertion.assert (expect.js💯11)\r\n │ at
Assertion.apply (expect.js:227:8)\r\n │ at Assertion.be
(expect.js:69:22)\r\n │ at Context.<anonymous> (_discover.ts:53:31)\r\n
│ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Object.apply
(wrap_function.js:73:16)\r\n │\r\n │\r\n └-> \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\"\r\n └- ✖ fail:
discover/group1 discover test query \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\"\r\n │
NoSuchSessionError: invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n └->
\"after all\" hook in \"discover test\"\r\n │ debg Cleaning all saved
objects { space: undefined }\r\n │ succ deleted 2 objects\r\n └->
\"after all\" hook: afterTestSuite.trigger in \"discover test\"\r\n └- ✖
fail: discover/group1 discover test \"after all\" hook:
afterTestSuite.trigger in \"discover test\"\r\n │ NoSuchSessionError:
invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n └->
\"after all\" hook: unloadMakelogs in \"discover/group1\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"mappings.json\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.22\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.20\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.21\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"data.json.gz\"\r\n └-> \"after all\" hook:
afterTestSuite.trigger in \"discover/group1\"\r\n └- ✖ fail:
discover/group1 \"after all\" hook: afterTestSuite.trigger in
\"discover/group1\"\r\n │ NoSuchSessionError: invalid session id\r\n │
at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
runMicrotasks (<anonymous>)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Task.exec
(prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n │\r\n │0 passing
(15.7s)\r\n │4 failing\r\n │\r\n │1) discover/group1\r\n │ discover
test\r\n │ query\r\n │ should show correct time range string by
timepicker:\r\n │\r\n │ Error: expected 'Sep 19, 2015 @ 06:31:44.000' to
equal 'Sep 23, 2015 @ 18:31:44.000'\r\n │ at Assertion.assert
(expect.js💯11)\r\n │ at Assertion.apply (expect.js:227:8)\r\n │ at
Assertion.be (expect.js:69:22)\r\n │ at Context.<anonymous>
(_discover.ts:53:31)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Object.apply
(wrap_function.js:73:16)\r\n │\r\n │\r\n │2) discover/group1\r\n │
discover test\r\n │ query\r\n │ \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\":\r\n │\r\n │
NoSuchSessionError: invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n │3)
discover/group1\r\n │ discover test\r\n │ \"after all\" hook:
afterTestSuite.trigger in \"discover test\":\r\n │\r\n │
NoSuchSessionError: invalid session id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n │
at Task.exec (prevent_parallel_calls.ts:28:20)\r\n │\r\n │\r\n │4)
discover/group1\r\n │ \"after all\" hook: afterTestSuite.trigger in
\"discover/group1\":\r\n │\r\n │ NoSuchSessionError: invalid session
id\r\n │ at Object.throwDecodedError
(node_modules/selenium-webdriver/lib/error.js:524:15)\r\n │ at
parseHttpResponse
(node_modules/selenium-webdriver/lib/http.js:601:13)\r\n │ at
Executor.execute
(node_modules/selenium-webdriver/lib/http.js:529:28)\r\n │ at
runMicrotasks (<anonymous>)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Task.exec
(prevent_parallel_calls.ts:28:20)\r\n```\r\n\r\n</details>\r\n\r\nThis
PR change: I didn't find a good reason why we need to fail
silently\r\non screenshot taking. I added a check WebDriver session
status with\r\n`hasOpenWindow` and take failure artefacts only if is
still valid.\r\nNext change is to fail FTR after hooks related to
WebDriver silently:\r\nthere is no help having cascade of the repeated
stacktrace so I wrap\r\nWebDriver call in hooks with `tryWebDriverCall`
that catches the error\r\nand only prints it for
visibility.\r\n\r\n<details>\r\n\r\n<summary>FTR new output on
failure</summary>\r\n\r\n```\r\n │ERROR WebDriver session is no longer
valid.\r\n │ Probably Chrome process crashed when it tried to use more
memory than what was available.\r\n │ERROR Browser is closed, no
artifacts were captured for the failure\r\n └- ✖ fail: discover/group1
discover test query should show correct time range string by
timepicker\r\n │ Error: expected 'Sep 19, 2015 @ 06:31:44.000' to equal
'Sep 23, 2015 @ 18:31:44.000'\r\n │ at Assertion.assert
(expect.js💯11)\r\n │ at Assertion.apply (expect.js:227:8)\r\n │ at
Assertion.be (expect.js:69:22)\r\n │ at Context.<anonymous>
(_discover.ts:53:31)\r\n │ at processTicksAndRejections
(node:internal/process/task_queues:96:5)\r\n │ at Object.apply
(wrap_function.js:73:16)\r\n │\r\n │\r\n └-> \"after all\" hook:
afterTestSuite.trigger for \"should reload the saved search with
persisted query to show the initial hit count\"\r\n │ERROR WebDriver
session is no longer valid\r\n └-> \"after all\" hook in \"discover
test\"\r\n │ debg Cleaning all saved objects { space: undefined }\r\n │
warn browser[SEVERE] ERROR FETCHING BROWSR LOGS: This driver instance
does not have a valid session ID (did you call WebDriver.quit()?) and
may no longer be used.\r\n │ succ deleted 2 objects\r\n └-> \"after
all\" hook: afterTestSuite.trigger in \"discover test\"\r\n │ERROR
WebDriver session is no longer valid\r\n └-> \"after all\" hook:
unloadMakelogs in \"discover/group1\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"mappings.json\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.22\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.20\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Deleted
existing index \"logstash-2015.09.21\"\r\n │ info
[test/functional/fixtures/es_archiver/logstash_functional] Unloading
indices from \"data.json.gz\"\r\n └-> \"after all\" hook:
afterTestSuite.trigger in \"discover/group1\"\r\n │ERROR WebDriver
session is no longer valid\r\n\r\n0 passing (16.2s)\r\n1
failing\r\n\r\n1) discover/group1\r\n discover test\r\n query\r\n should
show correct time range string by timepicker:\r\n\r\n Error: expected
'Sep 19, 2015 @ 06:31:44.000' to equal 'Sep 23, 2015 @ 18:31:44.000'\r\n
at Assertion.assert (expect.js💯11)\r\n at Assertion.apply
(expect.js:227:8)\r\n at Assertion.be (expect.js:69:22)\r\n at
Context.<anonymous> (_discover.ts:53:31)\r\n at
processTicksAndRejections (node:internal/process/task_queues:96:5)\r\n
at Object.apply
(wrap_function.js:73:16)\r\n```\r\n\r\n</details>\r\n\r\n\r\nFlaky-test-runner
verification: started 100x to hopefully catch invalid\r\nsession on
CI\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2539\r\nNote:
locally I was simulating it by calling `this.driver.close()` to\r\nclose
browser before screenshot
taking","sha":"8a95bf7fabe34c601725313c922f95ee0fa641e5"}},{"branch":"8.8","label":"v8.8.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
 2023-07-04 10:24:20 -07:00
Kibana Machine
b2c20bd458
skip failing test suite (#161157) 2023-07-04 14:54:46 +01:00
Kibana Machine
b9e0b75b3c
[8.9] [Dashboard] Redesign clone experience (#159752) (#161051) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Dashboard] Redesign clone experience
(#159752)](https://github.com/elastic/kibana/pull/159752)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Catherine
Liu","email":"catherine.liu@elastic.co"},"sourceCommit":{"committedDate":"2023-07-01T03:45:39Z","message":"[Dashboard]
Redesign clone experience (#159752)\n\n## Summary\r\n\r\nCloses #154500.
\r\nCloses https://github.com/elastic/kibana/issues/114206.\r\n\r\nThis
updates the UX around cloning dashboards. I removed the clone\r\nconfirm
model, so cloning a dashboard is just a one click action now.\r\nThis
aligns with how other apps like ML handle cloning. I've also made\r\nthe
dashboard title breadcrumb a button in edit mode that opens
the\r\ndashboard settings flyout for better
discoverability.\r\n\r\n\r\n4f5ea117-a5e4-4ec5-9113-8b09fd8c84a1\r\n\r\nI
also changed the pattern for cloned dashboard title from
`Dashboard\r\nTitle Copy` to `Dashboard Title (#)`.\r\n<img
width=\"1226\" alt=\"Screenshot 2023-06-30 at 1 03 35
PM\"\r\nsrc=\"b50ba5c6-dc95-4aab-a320-b1a78b74c1b6\">","sha":"938716e58aa7b4ee37233529510ac0956cfe888c","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Dashboard","Team:Presentation","loe:hours","impact:medium","backport:skip","ui-copy","v8.10.0"],"number":159752,"url":"https://github.com/elastic/kibana/pull/159752","mergeCommit":{"message":"[Dashboard]
Redesign clone experience (#159752)\n\n## Summary\r\n\r\nCloses #154500.
\r\nCloses https://github.com/elastic/kibana/issues/114206.\r\n\r\nThis
updates the UX around cloning dashboards. I removed the clone\r\nconfirm
model, so cloning a dashboard is just a one click action now.\r\nThis
aligns with how other apps like ML handle cloning. I've also made\r\nthe
dashboard title breadcrumb a button in edit mode that opens
the\r\ndashboard settings flyout for better
discoverability.\r\n\r\n\r\n4f5ea117-a5e4-4ec5-9113-8b09fd8c84a1\r\n\r\nI
also changed the pattern for cloned dashboard title from
`Dashboard\r\nTitle Copy` to `Dashboard Title (#)`.\r\n<img
width=\"1226\" alt=\"Screenshot 2023-06-30 at 1 03 35
PM\"\r\nsrc=\"b50ba5c6-dc95-4aab-a320-b1a78b74c1b6\">","sha":"938716e58aa7b4ee37233529510ac0956cfe888c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159752","number":159752,"mergeCommit":{"message":"[Dashboard]
Redesign clone experience (#159752)\n\n## Summary\r\n\r\nCloses #154500.
\r\nCloses https://github.com/elastic/kibana/issues/114206.\r\n\r\nThis
updates the UX around cloning dashboards. I removed the clone\r\nconfirm
model, so cloning a dashboard is just a one click action now.\r\nThis
aligns with how other apps like ML handle cloning. I've also made\r\nthe
dashboard title breadcrumb a button in edit mode that opens
the\r\ndashboard settings flyout for better
discoverability.\r\n\r\n\r\n4f5ea117-a5e4-4ec5-9113-8b09fd8c84a1\r\n\r\nI
also changed the pattern for cloned dashboard title from
`Dashboard\r\nTitle Copy` to `Dashboard Title (#)`.\r\n<img
width=\"1226\" alt=\"Screenshot 2023-06-30 at 1 03 35
PM\"\r\nsrc=\"b50ba5c6-dc95-4aab-a320-b1a78b74c1b6\">","sha":"938716e58aa7b4ee37233529510ac0956cfe888c"}}]}]
BACKPORT-->

Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
 2023-06-30 21:56:53 -07:00
Kibana Machine
9a3dd16bd0
[8.9] [data view editor] Fix data view timestamp validation (#150398) (#160990) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[data view editor] Fix data view timestamp validation
(#150398)](https://github.com/elastic/kibana/pull/150398)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2023-06-30T12:29:44Z","message":"[data
view editor] Fix data view timestamp validation (#150398)\n\n##
Summary\r\n\r\nPreviously - If you changed a data view's index pattern
AND the new\r\npattern didn't contain the timestamp field, you'd see a
blank timestamp\r\nfield and it would let you save. The data view would
have been saved\r\nwith the previous timestamp field which doesn't
exist.\r\n\r\nNow - The timestamp validator checks to make sure the
selected timestamp\r\nfield is in the list of available options. This is
helpful because it\r\nkeeps the previous timestamp value in case you do
select an index\r\npattern that contains it.\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/150219","sha":"646539c45b454b48c9fa985b7ac5cb69a63c70f8","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Data
Views","Feature:Kibana
Management","Team:DataDiscovery","backport:prev-minor","v8.10.0"],"number":150398,"url":"https://github.com/elastic/kibana/pull/150398","mergeCommit":{"message":"[data
view editor] Fix data view timestamp validation (#150398)\n\n##
Summary\r\n\r\nPreviously - If you changed a data view's index pattern
AND the new\r\npattern didn't contain the timestamp field, you'd see a
blank timestamp\r\nfield and it would let you save. The data view would
have been saved\r\nwith the previous timestamp field which doesn't
exist.\r\n\r\nNow - The timestamp validator checks to make sure the
selected timestamp\r\nfield is in the list of available options. This is
helpful because it\r\nkeeps the previous timestamp value in case you do
select an index\r\npattern that contains it.\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/150219","sha":"646539c45b454b48c9fa985b7ac5cb69a63c70f8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150398","number":150398,"mergeCommit":{"message":"[data
view editor] Fix data view timestamp validation (#150398)\n\n##
Summary\r\n\r\nPreviously - If you changed a data view's index pattern
AND the new\r\npattern didn't contain the timestamp field, you'd see a
blank timestamp\r\nfield and it would let you save. The data view would
have been saved\r\nwith the previous timestamp field which doesn't
exist.\r\n\r\nNow - The timestamp validator checks to make sure the
selected timestamp\r\nfield is in the list of available options. This is
helpful because it\r\nkeeps the previous timestamp value in case you do
select an index\r\npattern that contains it.\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/150219","sha":"646539c45b454b48c9fa985b7ac5cb69a63c70f8"}}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <matt@mattki.me>
 2023-06-30 06:36:29 -07:00
Kibana Machine
3018fc9e5f
[8.9] [data views / runtime fields] Fix runtime fields with dots in the name (#160458) (#160954) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[data views / runtime fields] Fix runtime fields with dots in the
name (#160458)](https://github.com/elastic/kibana/pull/160458)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2023-06-30T02:20:05Z","message":"[data
views / runtime fields] Fix runtime fields with dots in the name
(#160458)\n\n## Summary\r\n\r\nComposite runtime fields with dots in the
name were broken, now fixed. \r\n\r\nTo verify - \r\n1. Create runtime
field with dot in the name\r\n2. Make a composite runtime field with
subfields with dot in the name\r\n3. Go back and edit those
fields\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/159648\r\n\r\n### Release
note\r\n\r\nFixes creation and editing of composite runtime fields with
dots in
the\r\nnames.","sha":"b2200e4d33bd50f8072c62101b62464f6bf9ba17","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Data
Views","Feature:Kibana Management","Feature:Runtime
Fields","Team:DataDiscovery","backport:prev-minor","v8.10.0"],"number":160458,"url":"https://github.com/elastic/kibana/pull/160458","mergeCommit":{"message":"[data
views / runtime fields] Fix runtime fields with dots in the name
(#160458)\n\n## Summary\r\n\r\nComposite runtime fields with dots in the
name were broken, now fixed. \r\n\r\nTo verify - \r\n1. Create runtime
field with dot in the name\r\n2. Make a composite runtime field with
subfields with dot in the name\r\n3. Go back and edit those
fields\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/159648\r\n\r\n### Release
note\r\n\r\nFixes creation and editing of composite runtime fields with
dots in
the\r\nnames.","sha":"b2200e4d33bd50f8072c62101b62464f6bf9ba17"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160458","number":160458,"mergeCommit":{"message":"[data
views / runtime fields] Fix runtime fields with dots in the name
(#160458)\n\n## Summary\r\n\r\nComposite runtime fields with dots in the
name were broken, now fixed. \r\n\r\nTo verify - \r\n1. Create runtime
field with dot in the name\r\n2. Make a composite runtime field with
subfields with dot in the name\r\n3. Go back and edit those
fields\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/159648\r\n\r\n### Release
note\r\n\r\nFixes creation and editing of composite runtime fields with
dots in
the\r\nnames.","sha":"b2200e4d33bd50f8072c62101b62464f6bf9ba17"}}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <matt@mattki.me>
 2023-06-29 20:37:21 -07:00
Tiago Costa
bd55245115
skip flaky suite (#160178) 2023-06-29 20:46:48 +01:00
Kibana Machine
53d0fbbb42
[8.9] [Discover] Fix documents request missing pinned filters (#160693) (#160903) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Discover] Fix documents request missing pinned filters
(#160693)](https://github.com/elastic/kibana/pull/160693)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Davis
McPhee","email":"davis.mcphee@elastic.co"},"sourceCommit":{"committedDate":"2023-06-29T14:39:04Z","message":"[Discover]
Fix documents request missing pinned filters (#160693)\n\n##
Summary\r\n\r\nThis PR fixes a bug where pinned filters were not being
applied to the\r\nDiscover documents request.\r\n\r\nFixes
#160579.\r\n\r\n### Checklist\r\n\r\n- [ ] ~Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n-
[
]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials~\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] ~Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n-
[ ] ~Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n-
[ ] ~If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n-
[ ] ~This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d9744464dc4d8d3c0f891b94871eb8f3fe341c4d","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:DataDiscovery","v8.9.0","v8.10.0"],"number":160693,"url":"https://github.com/elastic/kibana/pull/160693","mergeCommit":{"message":"[Discover]
Fix documents request missing pinned filters (#160693)\n\n##
Summary\r\n\r\nThis PR fixes a bug where pinned filters were not being
applied to the\r\nDiscover documents request.\r\n\r\nFixes
#160579.\r\n\r\n### Checklist\r\n\r\n- [ ] ~Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n-
[
]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials~\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] ~Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n-
[ ] ~Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n-
[ ] ~If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n-
[ ] ~This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d9744464dc4d8d3c0f891b94871eb8f3fe341c4d"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160693","number":160693,"mergeCommit":{"message":"[Discover]
Fix documents request missing pinned filters (#160693)\n\n##
Summary\r\n\r\nThis PR fixes a bug where pinned filters were not being
applied to the\r\nDiscover documents request.\r\n\r\nFixes
#160579.\r\n\r\n### Checklist\r\n\r\n- [ ] ~Any text added follows
[EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~\r\n-
[
]\r\n~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials~\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] ~Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard\r\naccessibility](https://webaim.org/techniques/keyboard/))~\r\n-
[ ] ~Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~\r\n-
[ ] ~If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~\r\n-
[ ] ~This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"d9744464dc4d8d3c0f891b94871eb8f3fe341c4d"}}]}]
BACKPORT-->

Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
 2023-06-29 08:56:04 -07:00
Kibana Machine
dc459a5513
[8.9] [Content management] fix table list flashes table interface when empty (#160650) (#160893) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Content management] fix table list flashes table interface when
empty (#160650)](https://github.com/elastic/kibana/pull/160650)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-06-29T13:55:16Z","message":"[Content
management] fix table list flashes table interface when empty
(#160650)\n\nCloses
https://github.com/elastic/kibana/issues/159507\r\nCloses
https://github.com/elastic/kibana/issues/148557\r\n\r\nFlaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2508\r\n\r\n###
Test instructions\r\n* Install sample web logs data set\r\n* Delete
dashboard that ships with sample data set\r\n* switch to another app,
like visualize\r\n* Use debugger tools to throttle network connection to
\"slow 3g\"\r\n* Open dashboard application again\r\n* Verify empty
table view is never displayed and there is no flickering\r\nbetween
views.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"9f73f9479c1ff77fbada8305e618931b57d65796","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","Team:SharedUX","v8.9.0","v8.10.0"],"number":160650,"url":"https://github.com/elastic/kibana/pull/160650","mergeCommit":{"message":"[Content
management] fix table list flashes table interface when empty
(#160650)\n\nCloses
https://github.com/elastic/kibana/issues/159507\r\nCloses
https://github.com/elastic/kibana/issues/148557\r\n\r\nFlaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2508\r\n\r\n###
Test instructions\r\n* Install sample web logs data set\r\n* Delete
dashboard that ships with sample data set\r\n* switch to another app,
like visualize\r\n* Use debugger tools to throttle network connection to
\"slow 3g\"\r\n* Open dashboard application again\r\n* Verify empty
table view is never displayed and there is no flickering\r\nbetween
views.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"9f73f9479c1ff77fbada8305e618931b57d65796"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160650","number":160650,"mergeCommit":{"message":"[Content
management] fix table list flashes table interface when empty
(#160650)\n\nCloses
https://github.com/elastic/kibana/issues/159507\r\nCloses
https://github.com/elastic/kibana/issues/148557\r\n\r\nFlaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2508\r\n\r\n###
Test instructions\r\n* Install sample web logs data set\r\n* Delete
dashboard that ships with sample data set\r\n* switch to another app,
like visualize\r\n* Use debugger tools to throttle network connection to
\"slow 3g\"\r\n* Open dashboard application again\r\n* Verify empty
table view is never displayed and there is no flickering\r\nbetween
views.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"9f73f9479c1ff77fbada8305e618931b57d65796"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
 2023-06-29 08:28:42 -07:00
Stratoula Kalafateli
a914b2be1b
[8.9] Update dependency @elastic/charts to v59 (main) (#160700) (#160883) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [Update dependency @elastic/charts to v59 (main)
(#160700)](https://github.com/elastic/kibana/pull/160700)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2023-06-29 06:55:15 -07:00
Kibana Machine
e82e814392
[8.9] [TSVB] Stabilize the functional test (#160847) (#160878) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[TSVB] Stabilize the functional test
(#160847)](https://github.com/elastic/kibana/pull/160847)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2023-06-29T12:17:27Z","message":"[TSVB]
Stabilize the functional test (#160847)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/158972\r\n\r\nI think this
change is going to stabilize this test once and for all.\r\n\r\nRunner
100times\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2532","sha":"5f5d5525c4dd64d58bcf5fc67c2469bccf7a4f70","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","Team:Visualizations","release_note:skip","backport:prev-minor","v8.9.0","v8.10.0"],"number":160847,"url":"https://github.com/elastic/kibana/pull/160847","mergeCommit":{"message":"[TSVB]
Stabilize the functional test (#160847)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/158972\r\n\r\nI think this
change is going to stabilize this test once and for all.\r\n\r\nRunner
100times\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2532","sha":"5f5d5525c4dd64d58bcf5fc67c2469bccf7a4f70"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160847","number":160847,"mergeCommit":{"message":"[TSVB]
Stabilize the functional test (#160847)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/158972\r\n\r\nI think this
change is going to stabilize this test once and for all.\r\n\r\nRunner
100times\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2532","sha":"5f5d5525c4dd64d58bcf5fc67c2469bccf7a4f70"}}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
 2023-06-29 06:39:48 -07:00
Kibana Machine
52284a3ec3
[8.9] Ftr/speedup dashboard tests (#160722) (#160791) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [Ftr/speedup dashboard tests
(#160722)](https://github.com/elastic/kibana/pull/160722)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-06-28T16:49:32Z","message":"Ftr/speedup
dashboard tests (#160722)\n\n## Summary\r\n\r\nWhile splitting
`test/functional/apps/dashboard/group2/config.ts` in\r\n#160612, I
noticed that some tests (`it` function level) takes 30-45\r\nseconds
though having little actions to do in Kibana.\r\n\r\nAfter closer look I
found that:\r\n- `await PageObjects.dashboard.clickNewDashboard();` call
takes ~13-15\r\nseconds when dashboard is empty\r\n- `await
dashboardAddPanel.closeAddPanel();` call takes ~12 seconds when\r\nthere
are no flyouts displayed\r\n\r\nExpected improvement:\r\n- `await
PageObjects.dashboard.clickNewDashboard()` call takes **2**\r\nseconds,
used **103** times in tests.\r\n- `await
dashboardAddPanel.closeAddPanel()` call takes **3** seconds,\r\nused
**21** times in tests.\r\n\r\nPR FTR configs runtime\r\n<img
width=\"778\"
alt=\"image\"\r\nsrc=\"673fee19-91ef-4bc3-9848-5f844b42774c\">\r\n\r\n`main`
branch last 3 days avg configs runtime\r\n<img width=\"1555\"
alt=\"image\"\r\nsrc=\"6e364cb9-c786-411a-9491-a749351f4c94\">\r\n\r\n\r\n\r\nflaky
test runner 50x for 6 most affected
configs\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2519","sha":"54fddef2dbdf7cbd18c54a4f3b0810e44394eb54","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","v8.8.2","v8.10.0"],"number":160722,"url":"https://github.com/elastic/kibana/pull/160722","mergeCommit":{"message":"Ftr/speedup
dashboard tests (#160722)\n\n## Summary\r\n\r\nWhile splitting
`test/functional/apps/dashboard/group2/config.ts` in\r\n#160612, I
noticed that some tests (`it` function level) takes 30-45\r\nseconds
though having little actions to do in Kibana.\r\n\r\nAfter closer look I
found that:\r\n- `await PageObjects.dashboard.clickNewDashboard();` call
takes ~13-15\r\nseconds when dashboard is empty\r\n- `await
dashboardAddPanel.closeAddPanel();` call takes ~12 seconds when\r\nthere
are no flyouts displayed\r\n\r\nExpected improvement:\r\n- `await
PageObjects.dashboard.clickNewDashboard()` call takes **2**\r\nseconds,
used **103** times in tests.\r\n- `await
dashboardAddPanel.closeAddPanel()` call takes **3** seconds,\r\nused
**21** times in tests.\r\n\r\nPR FTR configs runtime\r\n<img
width=\"778\"
alt=\"image\"\r\nsrc=\"673fee19-91ef-4bc3-9848-5f844b42774c\">\r\n\r\n`main`
branch last 3 days avg configs runtime\r\n<img width=\"1555\"
alt=\"image\"\r\nsrc=\"6e364cb9-c786-411a-9491-a749351f4c94\">\r\n\r\n\r\n\r\nflaky
test runner 50x for 6 most affected
configs\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2519","sha":"54fddef2dbdf7cbd18c54a4f3b0810e44394eb54"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.8"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160722","number":160722,"mergeCommit":{"message":"Ftr/speedup
dashboard tests (#160722)\n\n## Summary\r\n\r\nWhile splitting
`test/functional/apps/dashboard/group2/config.ts` in\r\n#160612, I
noticed that some tests (`it` function level) takes 30-45\r\nseconds
though having little actions to do in Kibana.\r\n\r\nAfter closer look I
found that:\r\n- `await PageObjects.dashboard.clickNewDashboard();` call
takes ~13-15\r\nseconds when dashboard is empty\r\n- `await
dashboardAddPanel.closeAddPanel();` call takes ~12 seconds when\r\nthere
are no flyouts displayed\r\n\r\nExpected improvement:\r\n- `await
PageObjects.dashboard.clickNewDashboard()` call takes **2**\r\nseconds,
used **103** times in tests.\r\n- `await
dashboardAddPanel.closeAddPanel()` call takes **3** seconds,\r\nused
**21** times in tests.\r\n\r\nPR FTR configs runtime\r\n<img
width=\"778\"
alt=\"image\"\r\nsrc=\"673fee19-91ef-4bc3-9848-5f844b42774c\">\r\n\r\n`main`
branch last 3 days avg configs runtime\r\n<img width=\"1555\"
alt=\"image\"\r\nsrc=\"6e364cb9-c786-411a-9491-a749351f4c94\">\r\n\r\n\r\n\r\nflaky
test runner 50x for 6 most affected
configs\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2519","sha":"54fddef2dbdf7cbd18c54a4f3b0810e44394eb54"}}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
 2023-06-28 11:03:32 -07:00
Kibana Machine
f1c113d998
[8.9] [ftr] split dashboard/group2/config into 2 configs (#160612) (#160789) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[ftr] split dashboard/group2/config into 2 configs
(#160612)](https://github.com/elastic/kibana/pull/160612)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-06-28T16:27:24Z","message":"[ftr]
split dashboard/group2/config into 2 configs (#160612)\n\n##
Summary\r\n\r\nSplitting
`test/functional/apps/dashboard/group2/config.ts` as it\r\ngetting close
to 35 minutes and quite often run on its own on CI worker.\r\n\r\n<img
width=\"1713\"
alt=\"image\"\r\nsrc=\"ac7f5dc6-2a12-4057-af98-81ff53bac1c4\">`\r\n\r\nThis
PR splits config into 2 almost run time equal groups:\r\n\r\n-
test/functional/apps/dashboard/group2/config.ts 18m 31s\r\n-
test/functional/apps/dashboard/group6/config.ts 16m
53s\r\n\r\nFlaky-test-runner for both
configs:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2522","sha":"51fb80a226147d04cd4f9394e7e798e39ecf24e8","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","v8.8.2","v8.10.0"],"number":160612,"url":"https://github.com/elastic/kibana/pull/160612","mergeCommit":{"message":"[ftr]
split dashboard/group2/config into 2 configs (#160612)\n\n##
Summary\r\n\r\nSplitting
`test/functional/apps/dashboard/group2/config.ts` as it\r\ngetting close
to 35 minutes and quite often run on its own on CI worker.\r\n\r\n<img
width=\"1713\"
alt=\"image\"\r\nsrc=\"ac7f5dc6-2a12-4057-af98-81ff53bac1c4\">`\r\n\r\nThis
PR splits config into 2 almost run time equal groups:\r\n\r\n-
test/functional/apps/dashboard/group2/config.ts 18m 31s\r\n-
test/functional/apps/dashboard/group6/config.ts 16m
53s\r\n\r\nFlaky-test-runner for both
configs:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2522","sha":"51fb80a226147d04cd4f9394e7e798e39ecf24e8"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.8"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160612","number":160612,"mergeCommit":{"message":"[ftr]
split dashboard/group2/config into 2 configs (#160612)\n\n##
Summary\r\n\r\nSplitting
`test/functional/apps/dashboard/group2/config.ts` as it\r\ngetting close
to 35 minutes and quite often run on its own on CI worker.\r\n\r\n<img
width=\"1713\"
alt=\"image\"\r\nsrc=\"ac7f5dc6-2a12-4057-af98-81ff53bac1c4\">`\r\n\r\nThis
PR splits config into 2 almost run time equal groups:\r\n\r\n-
test/functional/apps/dashboard/group2/config.ts 18m 31s\r\n-
test/functional/apps/dashboard/group6/config.ts 16m
53s\r\n\r\nFlaky-test-runner for both
configs:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2522","sha":"51fb80a226147d04cd4f9394e7e798e39ecf24e8"}}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
 2023-06-28 11:01:11 -07:00
Kibana Machine
0b6f2e89ce
[8.9] fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts - saved objects tagging - functional tests dashboard integration creating allows to select tags (#160782) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [fix Failing test: X-Pack Saved Object Tagging Functional
Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts
- saved objects tagging - functional tests dashboard integration
creating allows to select tags for a new dashboard
(#160687)](https://github.com/elastic/kibana/pull/160687)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-06-28T16:14:50Z","message":"fix
Failing test: X-Pack Saved Object Tagging Functional
Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts
- saved objects tagging - functional tests dashboard integration
creating allows to select tags for a new dashboard (#160687)\n\nCloses
https://github.com/elastic/kibana/issues/160583\r\n\r\nflaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2513\r\n\r\nHarden
`dashboard_page.enterDashboardTitleAndClickSave` for retry loops\r\nso
does not try to open save dialog when its already open from
first\r\nsave attempt failure.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ef7fda2d249f47a86b8e930b577b47990fb334ad","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v8.9.0","v8.10.0"],"number":160687,"url":"https://github.com/elastic/kibana/pull/160687","mergeCommit":{"message":"fix
Failing test: X-Pack Saved Object Tagging Functional
Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts
- saved objects tagging - functional tests dashboard integration
creating allows to select tags for a new dashboard (#160687)\n\nCloses
https://github.com/elastic/kibana/issues/160583\r\n\r\nflaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2513\r\n\r\nHarden
`dashboard_page.enterDashboardTitleAndClickSave` for retry loops\r\nso
does not try to open save dialog when its already open from
first\r\nsave attempt failure.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ef7fda2d249f47a86b8e930b577b47990fb334ad"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160687","number":160687,"mergeCommit":{"message":"fix
Failing test: X-Pack Saved Object Tagging Functional
Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts
- saved objects tagging - functional tests dashboard integration
creating allows to select tags for a new dashboard (#160687)\n\nCloses
https://github.com/elastic/kibana/issues/160583\r\n\r\nflaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2513\r\n\r\nHarden
`dashboard_page.enterDashboardTitleAndClickSave` for retry loops\r\nso
does not try to open save dialog when its already open from
first\r\nsave attempt failure.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"ef7fda2d249f47a86b8e930b577b47990fb334ad"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
 2023-06-28 10:22:54 -07:00
Kibana Machine
8840872584
[8.9] [ftr] split dashboard_elements/config to speedup CI run (#160550) (#160767) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[ftr] split dashboard_elements/config to speedup CI run
(#160550)](https://github.com/elastic/kibana/pull/160550)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-06-28T15:00:34Z","message":"[ftr]
split dashboard_elements/config to speedup CI run (#160550)\n\n##
Summary\r\n\r\nSplitting FTR config as it consistently takes over 37
minutes to run.\r\n\r\nThis PR splits it into 5 smaller
configs:\r\n\r\n-
test/functional/apps/dashboard_elements/controls/common/config.ts
15m\r\n24s\r\n-\r\ntest/functional/apps/dashboard_elements/controls/options_list/config.ts\r\n17m
38s\r\n-
test/functional/apps/dashboard_elements/image_embeddable/config.ts
2m\r\n14s\r\n-
test/functional/apps/dashboard_elements/input_control_vis/config.ts
4m\r\n41s\r\n-
test/functional/apps/dashboard_elements/markdown/config.ts 1m
24s","sha":"599bbacab048359d87f17072a4920d96de8ba087","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","v8.8.2","v8.10.0"],"number":160550,"url":"https://github.com/elastic/kibana/pull/160550","mergeCommit":{"message":"[ftr]
split dashboard_elements/config to speedup CI run (#160550)\n\n##
Summary\r\n\r\nSplitting FTR config as it consistently takes over 37
minutes to run.\r\n\r\nThis PR splits it into 5 smaller
configs:\r\n\r\n-
test/functional/apps/dashboard_elements/controls/common/config.ts
15m\r\n24s\r\n-\r\ntest/functional/apps/dashboard_elements/controls/options_list/config.ts\r\n17m
38s\r\n-
test/functional/apps/dashboard_elements/image_embeddable/config.ts
2m\r\n14s\r\n-
test/functional/apps/dashboard_elements/input_control_vis/config.ts
4m\r\n41s\r\n-
test/functional/apps/dashboard_elements/markdown/config.ts 1m
24s","sha":"599bbacab048359d87f17072a4920d96de8ba087"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.8"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160550","number":160550,"mergeCommit":{"message":"[ftr]
split dashboard_elements/config to speedup CI run (#160550)\n\n##
Summary\r\n\r\nSplitting FTR config as it consistently takes over 37
minutes to run.\r\n\r\nThis PR splits it into 5 smaller
configs:\r\n\r\n-
test/functional/apps/dashboard_elements/controls/common/config.ts
15m\r\n24s\r\n-\r\ntest/functional/apps/dashboard_elements/controls/options_list/config.ts\r\n17m
38s\r\n-
test/functional/apps/dashboard_elements/image_embeddable/config.ts
2m\r\n14s\r\n-
test/functional/apps/dashboard_elements/input_control_vis/config.ts
4m\r\n41s\r\n-
test/functional/apps/dashboard_elements/markdown/config.ts 1m
24s","sha":"599bbacab048359d87f17072a4920d96de8ba087"}}]}] BACKPORT-->

Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
 2023-06-28 09:13:19 -07:00
Kibana Machine
e95d77e45d skip failing test suite (#158972) 2023-06-27 15:38:42 -04:00
Matthias Wilhelm
8246814578
[8.9] [Discover] Fix performance when switching to text based query (#159903) (#160635) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Discover] Fix performance when switching to text based query
(#159903)](https://github.com/elastic/kibana/pull/159903)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthias
Wilhelm","email":"matthias.wilhelm@elastic.co"},"sourceCommit":{"committedDate":"2023-06-23T18:59:03Z","message":"[Discover]
Fix performance when switching to text based query (#159903)\n\nOptimize
switch to text-based queries by reducing unnecessary EuiDataGrid
renderings and addressing performance regression. Introduce a PARTIAL
state emission in the document$ observable for text-based query results.
This state indicates ongoing loading in the UI. The appState to URL
changes hook completes with the COMPLETE state submission to document$,
enabling UI rendering.\r\n\r\nCo-authored-by: Davis McPhee
<davismcphee@hotmail.com>","sha":"43b460c72b9390556a9076120266b852c91b0aaa","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.10.0"],"number":159903,"url":"https://github.com/elastic/kibana/pull/159903","mergeCommit":{"message":"[Discover]
Fix performance when switching to text based query (#159903)\n\nOptimize
switch to text-based queries by reducing unnecessary EuiDataGrid
renderings and addressing performance regression. Introduce a PARTIAL
state emission in the document$ observable for text-based query results.
This state indicates ongoing loading in the UI. The appState to URL
changes hook completes with the COMPLETE state submission to document$,
enabling UI rendering.\r\n\r\nCo-authored-by: Davis McPhee
<davismcphee@hotmail.com>","sha":"43b460c72b9390556a9076120266b852c91b0aaa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159903","number":159903,"mergeCommit":{"message":"[Discover]
Fix performance when switching to text based query (#159903)\n\nOptimize
switch to text-based queries by reducing unnecessary EuiDataGrid
renderings and addressing performance regression. Introduce a PARTIAL
state emission in the document$ observable for text-based query results.
This state indicates ongoing loading in the UI. The appState to URL
changes hook completes with the COMPLETE state submission to document$,
enabling UI rendering.\r\n\r\nCo-authored-by: Davis McPhee
<davismcphee@hotmail.com>","sha":"43b460c72b9390556a9076120266b852c91b0aaa"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
 2023-06-27 08:47:23 -07:00
Kibana Machine
a0c8ee77a0
[8.9] Update dependency @elastic/charts to v58 (main) (#159082) (#160560) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [Update dependency @elastic/charts to v58 (main)
(#159082)](https://github.com/elastic/kibana/pull/159082)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"renovate[bot]","email":"29139614+renovate[bot]@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-26T18:41:49Z","message":"Update
dependency @elastic/charts to v58 (main)
(#159082)\n\n[![Mend\r\nRenovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)\r\n\r\nThis
PR contains the following updates:\r\n\r\n| Package | Change | Age |
Adoption | Passing | Confidence |\r\n|---|---|---|---|---|---|\r\n|
[@elastic/charts](https://togithub.com/elastic/elastic-charts)
|\r\n[`57.0.1`
->\r\n`58.2.0`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/57.0.1/58.2.0)\r\n|\r\n[![age](https://badges.renovateapi.com/packages/npm/@elastic%2fcharts/58.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)\r\n|\r\n[![adoption](https://badges.renovateapi.com/packages/npm/@elastic%2fcharts/58.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)\r\n|\r\n[![passing](https://badges.renovateapi.com/packages/npm/@elastic%2fcharts/58.2.0/compatibility-slim/57.0.1)](https://docs.renovatebot.com/merge-confidence/)\r\n|\r\n[![confidence](https://badges.renovateapi.com/packages/npm/@elastic%2fcharts/58.2.0/confidence-slim/57.0.1)](https://docs.renovatebot.com/merge-confidence/)\r\n|\r\n\r\n---\r\n\r\n###
Release
Notes\r\n\r\n<details>\r\n<summary>elastic/elastic-charts</summary>\r\n\r\n#\r\n[58.2.0](https://github.com/elastic/elastic-charts/compare/v58.1.0...v58.2.0)\r\n(2023-06-23)\r\n\r\n\r\n###
Bug Fixes\r\n\r\n* `Chart` component `children`
type\r\n([#2071](525c782829))\r\n*
**deps:** update dependency @elastic/eui to
v82\r\n([#2074](69a655f0da))\r\n\r\n\r\n###
Features\r\n\r\n* **flame:** expose search field text and search text
change
listener\r\n([#2068](c339947c39))\r\n*
support native chart title and
description\r\n([#2002](341a990c5d))\r\n\r\n#\r\n[58.1.0](https://github.com/elastic/elastic-charts/compare/v58.0.0...v58.1.0)\r\n(2023-06-08)\r\n\r\n\r\n###
Features\r\n\r\n* **flame:** expose search
control\r\n([#2064](011b56b3f5))\r\n\r\n#\r\n[58.0.0](https://github.com/elastic/elastic-charts/compare/v57.0.1...v58.0.0)\r\n(2023-06-06)\r\n\r\n\r\n###
Bug Fixes\r\n\r\n* **axis:** reduce number of y axis ticks on linear
scale\r\n([#2005](0ef828b535))\r\n*
**deps:** update dependency @elastic/eui to
v81\r\n([#2052](4c55e0119e))\r\n\r\n\r\n###
BREAKING CHANGES\r\n\r\n* **axis:** the default number of desired ticks
in the Y-Axis was\r\nchanged from `10` to
`5`\r\n\r\n</details>\r\n\r\n---\r\n\r\n### Configuration\r\n\r\n📅
**Schedule**: Branch creation - At any time (no schedule
defined),\r\nAutomerge - At any time (no schedule defined).\r\n\r\n🚦
**Automerge**: Disabled by config. Please merge this manually once
you\r\nare satisfied.\r\n\r\n♻ **Rebasing**: Whenever PR becomes
conflicted, or you tick the\r\nrebase/retry checkbox.\r\n\r\n🔕
**Ignore**: Close this PR and you won't be reminded about this
update\r\nagain.\r\n\r\n---\r\n\r\n- [ ] <!-- rebase-check -->If you
want to rebase/retry this PR, check\r\nthis box\r\n\r\n---\r\n\r\nThis
PR has been generated by
[Mend\r\nRenovate](https://www.mend.io/free-developer-tools/renovate/).
View\r\nrepository job
log\r\n[here](https://app.renovatebot.com/dashboard#github/elastic/kibana).\r\n\r\n<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->\r\n\r\n---------\r\n\r\nCo-authored-by:
renovate[bot]
<29139614+renovate[bot]@users.noreply.github.com>\r\nCo-authored-by:
nickofthyme <nicholas.partridge@elastic.co>\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Nick Partridge <nick.ryan.partridge@gmail.com>\r\nCo-authored-by: Marco
Vettorello
<marco.vettorello@elastic.co>","sha":"b2c6c71a8db689b5dbf7ee1017071732e09afc18","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","Team:Visualizations","Team:uptime","release_note:skip","auto-backport","apm:cypress-record","v8.9.0"],"number":159082,"url":"https://github.com/elastic/kibana/pull/159082","mergeCommit":{"message":"Update
dependency @elastic/charts to v58 (main)
(#159082)\n\n[![Mend\r\nRenovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)\r\n\r\nThis
PR contains the following updates:\r\n\r\n| Package | Change | Age |
Adoption | Passing | Confidence |\r\n|---|---|---|---|---|---|\r\n|
[@elastic/charts](https://togithub.com/elastic/elastic-charts)
|\r\n[`57.0.1`
->\r\n`58.2.0`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/57.0.1/58.2.0)\r\n|\r\n[![age](https://badges.renovateapi.com/packages/npm/@elastic%2fcharts/58.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)\r\n|\r\n[![adoption](https://badges.renovateapi.com/packages/npm/@elastic%2fcharts/58.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)\r\n|\r\n[![passing](https://badges.renovateapi.com/packages/npm/@elastic%2fcharts/58.2.0/compatibility-slim/57.0.1)](https://docs.renovatebot.com/merge-confidence/)\r\n|\r\n[![confidence](https://badges.renovateapi.com/packages/npm/@elastic%2fcharts/58.2.0/confidence-slim/57.0.1)](https://docs.renovatebot.com/merge-confidence/)\r\n|\r\n\r\n---\r\n\r\n###
Release
Notes\r\n\r\n<details>\r\n<summary>elastic/elastic-charts</summary>\r\n\r\n#\r\n[58.2.0](https://github.com/elastic/elastic-charts/compare/v58.1.0...v58.2.0)\r\n(2023-06-23)\r\n\r\n\r\n###
Bug Fixes\r\n\r\n* `Chart` component `children`
type\r\n([#2071](525c782829))\r\n*
**deps:** update dependency @elastic/eui to
v82\r\n([#2074](69a655f0da))\r\n\r\n\r\n###
Features\r\n\r\n* **flame:** expose search field text and search text
change
listener\r\n([#2068](c339947c39))\r\n*
support native chart title and
description\r\n([#2002](341a990c5d))\r\n\r\n#\r\n[58.1.0](https://github.com/elastic/elastic-charts/compare/v58.0.0...v58.1.0)\r\n(2023-06-08)\r\n\r\n\r\n###
Features\r\n\r\n* **flame:** expose search
control\r\n([#2064](011b56b3f5))\r\n\r\n#\r\n[58.0.0](https://github.com/elastic/elastic-charts/compare/v57.0.1...v58.0.0)\r\n(2023-06-06)\r\n\r\n\r\n###
Bug Fixes\r\n\r\n* **axis:** reduce number of y axis ticks on linear
scale\r\n([#2005](0ef828b535))\r\n*
**deps:** update dependency @elastic/eui to
v81\r\n([#2052](4c55e0119e))\r\n\r\n\r\n###
BREAKING CHANGES\r\n\r\n* **axis:** the default number of desired ticks
in the Y-Axis was\r\nchanged from `10` to
`5`\r\n\r\n</details>\r\n\r\n---\r\n\r\n### Configuration\r\n\r\n📅
**Schedule**: Branch creation - At any time (no schedule
defined),\r\nAutomerge - At any time (no schedule defined).\r\n\r\n🚦
**Automerge**: Disabled by config. Please merge this manually once
you\r\nare satisfied.\r\n\r\n♻ **Rebasing**: Whenever PR becomes
conflicted, or you tick the\r\nrebase/retry checkbox.\r\n\r\n🔕
**Ignore**: Close this PR and you won't be reminded about this
update\r\nagain.\r\n\r\n---\r\n\r\n- [ ] <!-- rebase-check -->If you
want to rebase/retry this PR, check\r\nthis box\r\n\r\n---\r\n\r\nThis
PR has been generated by
[Mend\r\nRenovate](https://www.mend.io/free-developer-tools/renovate/).
View\r\nrepository job
log\r\n[here](https://app.renovatebot.com/dashboard#github/elastic/kibana).\r\n\r\n<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->\r\n\r\n---------\r\n\r\nCo-authored-by:
renovate[bot]
<29139614+renovate[bot]@users.noreply.github.com>\r\nCo-authored-by:
nickofthyme <nicholas.partridge@elastic.co>\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Nick Partridge <nick.ryan.partridge@gmail.com>\r\nCo-authored-by: Marco
Vettorello
<marco.vettorello@elastic.co>","sha":"b2c6c71a8db689b5dbf7ee1017071732e09afc18"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2023-06-26 13:42:31 -07:00
Kibana Machine
db0ef6b280
[8.9] [Visualize] Unskips failed percentiles test (#160228) (#160410) 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Visualize] Unskips failed percentiles test
(#160228)](https://github.com/elastic/kibana/pull/160228)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2023-06-23T13:29:20Z","message":"[Visualize]
Unskips failed percentiles test (#160228)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/160164\r\n\r\nThe ES promotion
failed due to
this\r\nhttps://github.com/elastic/elasticsearch/pull/96904\r\n\r\nWith
the new algorithm there is a deviation in the results, to
stabilize\r\nit I have increased the accuracy by increasing the
compression.\r\n\r\nFlaky
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2455","sha":"56bf0f6c583618deac7b5f6656a1647b56a3ad56","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Visualizations","Team:Visualizations","failed-test","release_note:skip","backport:prev-minor","v8.10.0"],"number":160228,"url":"https://github.com/elastic/kibana/pull/160228","mergeCommit":{"message":"[Visualize]
Unskips failed percentiles test (#160228)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/160164\r\n\r\nThe ES promotion
failed due to
this\r\nhttps://github.com/elastic/elasticsearch/pull/96904\r\n\r\nWith
the new algorithm there is a deviation in the results, to
stabilize\r\nit I have increased the accuracy by increasing the
compression.\r\n\r\nFlaky
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2455","sha":"56bf0f6c583618deac7b5f6656a1647b56a3ad56"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160228","number":160228,"mergeCommit":{"message":"[Visualize]
Unskips failed percentiles test (#160228)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/160164\r\n\r\nThe ES promotion
failed due to
this\r\nhttps://github.com/elastic/elasticsearch/pull/96904\r\n\r\nWith
the new algorithm there is a deviation in the results, to
stabilize\r\nit I have increased the accuracy by increasing the
compression.\r\n\r\nFlaky
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2455","sha":"56bf0f6c583618deac7b5f6656a1647b56a3ad56"}}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
 2023-06-23 07:43:15 -07:00
Devon Thomson
25ebbb67c1
[Flaky Tests] Switch to ensureAllClosed for dashboard add panel (#159943) 
Simple fix for some flaky tests.
 2023-06-21 12:00:10 -04:00
Tiago Costa
b4a4e4a71a
skip failing es promotin suite (#160164) 2023-06-21 16:47:51 +01:00
Hannah Mudge
f1dc1e1869
[Controls] Move "clear selections" to hover action (#159526) 
Closes https://github.com/elastic/kibana/issues/159395
Closes https://github.com/elastic/kibana/issues/153383

## Summary

This PR moves the "clear selections" button for all controls (options
list, range slider, and time slider) from inside their respective
popovers to a general hover action - this not only saves users a click
for this common interaction (which has actually been brought in user
feedback up as a downside of the current controls compared to the legacy
controls), it also allows us to fully move forward with migrating the
range slider control to the `EuiDualRange` component. This will be done
in a follow up PR, which should both (1) clean up our range slider code
significantly and (2) fix the [bug discussed
here](https://github.com/elastic/kibana/pull/159271#pullrequestreview-1477930356).
The related issue can be tracked
[here](https://github.com/elastic/kibana/issues/159724), since we might
not be able to get to it right away.

This "clear selections" action is available in both view and edit mode,
like so:

|  | Edit mode | View mode |
|--------|--------|--------|
| **Range slider** |
![image](83cb1e1a-0b20-43aa-a37b-14484b5f4945)
|
![image](0d28ce03-5242-4f3a-8a05-d447bca50ddb)
|
| **Options list** |
![image](066257f6-c0ce-4e33-a193-5bbc62e341a6)
|
![image](d1ec124c-f5ee-4137-9eb9-33e06d522435)
|
| **Time slider** |
![image](33b8bb80-fa0c-4281-ae81-f1e1b44086f3)
|
![image](bd7c41ae-706c-45f3-8b49-9bd4d259e5cf)
|

You may notice in the above screenshots that the "delete" action is now
represented with a red trash icon rather than a red cross, and the
tooltip text was also changed to use the word "Delete" rather than the
word "Remove" - these changes were both made to be more consistent with
the "Delete panel" action available on dashboards:

| Delete control - Before | Delete control - After | Delete panel |
|--------|--------|--------|
| ![Screenshot 2023-06-13 at 5 32 22
PM](2600b197-653b-43ea-a043-a50be7e6a796)
|
![image](5ef80380-2575-45fc-ba11-c59f3f252ac3)
| <img
src="a7f65777-45cf-44f2-96a7-f1042cb25e02"/>
|

Beyond these changes, I also made a few quick changes to the time slider
control, including:
1. Fixing the appearance so that the background is once again white, as
described
[here](https://github.com/elastic/kibana/pull/159526#discussion_r1229792071)
2. Adding comparison logic so that clearing selections no longer causes
unsaved changes unnecessarily, as described
[here](https://github.com/elastic/kibana/pull/159526#discussion_r1229789753)

### Videos

**Before**


96365c85-748e-4fd7-ae5d-589aa11a23ef


**After**


68352559-e71b-4b5e-8709-587016f0b35a



### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
 2023-06-20 16:53:10 -06:00
Hannah Mudge
a4d5209a9f
[Dashboard] Fix styling of top nav bar (#159754) 
Closes https://github.com/elastic/kibana/issues/159353
Closes https://github.com/elastic/kibana/issues/159756

## Summary

This PR adds styling so that, when the dashboard's chrome is hidden or
when there is a header banner present, the dashboard's top navigation
bar's `top` position is adjusted as necessary - this prevents it from
either (a) getting hidden behind the Kibana chrome or (b) floating in
the wrong position and overlapping the dashboard content, regardless of
if the dashboard is in embed mode (i.e. `embed=true` is present in the
URL) or not (i.e. `embed=false` is present in the URL **or**, more
commonly, there is no `embed` parameter in the URL).

### Embed Mode

- #### Before:


76d3c70c-936c-4bcc-985c-4fb433f0cff3

- #### After:


137bc103-666b-4fdd-ab4e-8994345e21b4

It also resolves a bug where the `isEmbeddedExternally` component state
was never actually being set, which meant that the
`ExitFullScreenButton` was always receiving `toggleChrome=true`. This
made it so that entering and exiting fullscreen mode in an embedded
dashboard would force the chrome to be visible (which should never
happen in embed mode).

#### How to Test
The easiest way to test this PR is to simply add `embed=true` to your
dashboard URL - because this PR also fixes
https://github.com/elastic/kibana/issues/159756, this will essentially
mimic the embedded experience.

Alternatively, if you want to test this in an actual iframe...

1. Start and login to Kibana with the default `kibana.yml` settings
2. Create and embed a dashboard using an iframe in an HTML file and open
that file in your browser - the iframe will show a prompt to login, but
you won't be able to. Instead...
3. Add the following settings to your `kibana.yml` file:<br><Br>
   ```
    xpack.security.secureCookies: true
    xpack.security.sameSiteCookies: 'None'
   ```
4. Wait for Kibana to re-load
5. Refresh the HTML page from step 2
6. The embedded dashboard should now be available for you to test 👍 

#### Scenarios Tested

-  **Non-fullscreen mode**

    <details>
<summary>✅ Without filter pill, without header banner <i>(click to see
screenshot)</i></summary>
<img
src="f68bbcfb-74d8-497c-a2ae-33e8e0c02660"/>
    </details>

    <details>
<summary>✅ Without filter pill, with header banner <i>(click to see
screenshot)</i></summary>
<img
src="7c19711c-61dc-499a-b1d0-01fab639a27e"/>
    </details>

    <details>
<summary>✅ With filter pill, without header banner <i>(click to see
screenshot)</i></summary>
<img
src="36e848bd-f0d9-41e3-8a8a-a48571ad5cd2"/>
    </details>

    <details>
<summary>✅ With filter pill, with header banner <i>(click to see
screenshot)</i></summary>
<img
src="cd7489f6-3f34-439a-a30e-3ef39f3970b5"/>
    </details>
    
    <details>
<summary>✅ With filter pill, with header banner <b>and</b> notification
banner <i>(click to see GIF)</i></summary>
<img
src="bd67b4eb-4f68-4d9b-9e22-4d1b2d2e4d90"/>
    </details>

-  **Fullscreen mode**

    <details>
<summary>✅ Without filter pill, without banner <i>(click to see
screenshot)</i></summary>
<img
src="d7d15560-7698-424f-b761-59b5557abe37"/>
    </details>

    <details>
<summary>✅ Without filter pill, with header banner <i>(click to see
screenshot)</i></summary>
<img
src="311b6f3d-5152-4d16-ba39-160978c60c96"/>
    </details>

    <details>
<summary>✅ With filter pill, without header banner <i>(click to see
screenshot)</i></summary>
<img
src="bff9e040-8169-40c7-a086-13a19e870383"/>
    </details>

    <details>
<summary>✅ With filter pill, with header banner <i>(click to see
screenshot)</i></summary>
<img
src="3f453811-e65d-4ac4-9524-c396f9efdbdd"/>
    </details>

    <details>
<summary>✅ With filter pill, with header banner <b>and</b> notification
banner <i>(click to see GIF)</i></summary>
<img
src="f79673e7-03f2-49fa-be56-b67bf7a12976"/>
    </details>

### Non-Embed Mode

- #### Before:


71ffc964-2844-41a6-98d6-353e84d674be

- #### After:


894aa292-b611-4e5e-a0d7-fe3d256fc3ba


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
 2023-06-20 16:23:06 -06:00
Hannah Mudge
0fcd4e88d3
[Dashboard] Fix flaky landing page test (#160066) 
Closes https://github.com/elastic/kibana/issues/160057

## Summary

It **seems** like the failure was a one-off or, at the very least, very
rare - I [ran the test through the flaky test
runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2423)
without any changes and it passed 100 times. That being said, I was able
to replicate the failure locally by switching to the preset "Slow 3G"
network before running the test - this means, if the CI environment is
running especially slow for any given reason, this test has the
potential to fail again.

So, to be safe, I added an extra `await` for the Kibana **chrome** to
show up after every hard refresh - previously we were only waiting for
the header loading state to go away, which doesn't work when Kibana
itself is taking a little longer than expected to load and the Kibana
chrome (where the header loading state is located) isn't yet visible.

This **also** [passed the flaky test runner 100
times](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2425)
but, as a bonus, the test **passed locally** when throttling the network
using the same "Slow 3G" preset as before - hopefully this means that
the test is less likely to fail even when the CI environment is running
slow 👍

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
 2023-06-20 14:21:29 -06:00
Nick Partridge
eb3e71e768
Fix flaky tsvb functional test (#159856) 2023-06-20 08:40:04 -07:00
Tiago Costa
064c0e7e62
skip flaky suite (#159167) 2023-06-20 14:37:34 +01:00
Devon Thomson
f60d43e27b
[Dashboard] Fix Time Range Regression (#159337) 
Fixed Dashboard loading with a saved time range when the URL also contains a time range.
 2023-06-15 16:10:55 -04:00
Hannah Mudge
9b0f10629b
[Controls] Range slider a11y and performance improvements (#159271) 
Closes https://github.com/elastic/kibana/issues/135466

## Summary

The main goal of this PR is to fix the serious "Buttons must have
discernible text" a11y failure - this is accomplished by switching from
building our own range slider button using `EuiFlexGroup` to instead
using `EuiFormControlLayoutDelimited`, which both resolves these a11y
issues and also fixes a rendering regression:

| Before | After |
|--------|-------|
|
![image](49ea1516-db74-46af-baa5-4ad0a31d5b5a)
|
![image](71bc61f2-f10d-4f8c-8ad2-2681f7faf921)
|

As part of this, I also took some time to clean up some of the range
slider code, which hasn't really been touched in awhile - this
includes...
- moving the debounce on range selections from the embeddable's `input$`
subscription to the component itself, as described
[here](https://github.com/elastic/kibana/pull/159271#discussion_r1226886857).
- fixing a bug where resetting the range slider would unnecessarily
cause unsaved changes, as described
[here](https://github.com/elastic/kibana/pull/159271#discussion_r1226885018).
- improving the `onClick` behaviour (with some notable limitations), as
described
[here](https://github.com/elastic/kibana/pull/159271#discussion_r1226934124).

As a follow up, we need to move the "clear selections" button [to a
hover action](https://github.com/elastic/kibana/issues/159395), which
will enable us to then fully move forward with our transition to the
`EuiDualRange` component.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] ~Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard
accessibility](https://webaim.org/techniques/keyboard/))~
   > **Note**
> Details provided
[here](https://github.com/elastic/kibana/pull/159271#discussion_r1226934124)
on why only partial keyboard support is currently supported
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
 2023-06-15 10:58:11 -06:00
Tiago Costa
2442c16777
skip flaky suite (#151056) 2023-06-15 15:31:41 +01:00
Nathan Reese
31c51e3f84
[lens] tagcloud functional test (#159631) 
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
 2023-06-15 06:35:48 -06:00
Drew Tate
6553ebbdd5
[Lens][Visualizations] library annotation groups listing page (#157988) 2023-06-13 20:09:01 -05:00
Davis McPhee
44bfd0c343
[Discover] Refactor Unified Histogram refetching logic for text based languages (#159438) 
## Summary

This PR refactors and simplifies the Unified Histogram refetching logic
for text based languages in Discover to minimize unnecessary refetches
while ensuring the total hits and Lens visualization stay in sync with
the results. It also introduces a new set of functional tests to track
the number of search requests sent from Discover under various scenarios
to help reduce the chance of regressions in data fetching logic.

Flaky test runner x 100:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2375.

Note: the flaky test runner has a couple of failures, but they all have
the error `expected testSubject(globalLoadingIndicator-hidden) to
exist`, which is also the same error as these three recently skipped
tests related to text based language mode:
- #159083
- #159167
- #159194

This suggests the failures aren't related to this PR, and I don't think
they should prevent us from merging this. But it also means we have a
critical issue related to text based languages that needs to be
addressed asap, possibly this one: #158893.

Fixes #158819.

### Checklist

- [ ] ~Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~
- [ ]
~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] ~Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard
accessibility](https://webaim.org/techniques/keyboard/))~
- [ ] ~Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~
- [ ] ~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
- [ ] ~This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~
- [ ] ~This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
 2023-06-13 20:29:04 -03:00
Julian Gernun
55bc8cf567
[RO] Incorrect Deletion of Webhook Actions in Kibana Rules (#159204) 
## Summary

Fixes #158167

The issue occurred because we were using a number called "index" as the
React key prop. When we removed the first element, the second one took
its place, but React still showed the removed element.

To fix this problem, we found a solution by using the uuid field that
each action item has. We now generate it for each new action we create
in the action form and use that as key

I was told to add @pmuellr as you might know if we are missing something
🙇

### Test: why xpath selector?

I had to use the xpath selector to fix a problem we had. The problem was
between two actions we set up. They look the same, but the body content
is the only different (I've attached a screenshot for more details).

We use a third party component for these actions. This component doesn't
have any "value" attribute and doesn't add anything besides the HTML
text. I tried to find other useful details but couldn't find any.

The problem comes up when we try to delete one of the actions. To fix
it, we needed to check if that component was missing. We already have
tools that can look for missing components, but they don't work with the
xpath selector. So, I added a new function that can do this. Now, we can
use the xpath selector to look for missing components and fix the
problem
 
<details>
<summary>See Screenshot</summary>
<img
src="5447795d-0281-4847-aa85-76d0e5fdec3d"/>
</details>

```[tasklist]
- [x] Make sure that it's ok to generate the uuid
- [x] Test
- [x] Do we need to backport? Versions?
```
 2023-06-12 10:19:20 +02:00
Marco Liberati
e325d4102b
[Lens] Add feature to ignore global filters at layer level (#159248) 
## Summary

Fixes #143493

* Add the switch control in Layer Settings
  * [x] Make sure it does not duplicate on Annotation Layer Settings 
  * [x] Data Layers
  * [x] Reference line layers
  * [x] Extended dataView picker to support multiple icons
    * [x] Added unit tests 
  * [x] Functional tests

<img width="351" alt="Screenshot 2023-06-07 at 15 28 19"
src="00dc5523-0bec-4e9c-b1d0-4d36804b29f9">
<img width="340" alt="Screenshot 2023-06-07 at 15 31 31"
src="d36ca147-5d8c-4123-9be3-2932844cbd15">
<img width="331" alt="Screenshot 2023-06-07 at 15 28 25"
src="c7d4f166-b8ab-4439-a83c-debf82b913ad">
<img width="324" alt="Screenshot 2023-06-07 at 15 27 59"
src="3738a7e0-6e49-4e22-b857-965a953b4b84">
<img width="323" alt="Screenshot 2023-06-07 at 15 27 53"
src="5965bf1c-0e25-4c0e-b54f-fa315157fd44">


*  Create `IgnoreGlobalFilter` shared component folder
   * [x] Layer setting control component
   * [x] Info badge component
   
 * Extends `esaggs_fn` to support the flag
   * [x] Avoid to pass the filter to the handler if set
   * [x] Add unit tests

* Notification badges
* [x] Extends the badge component in Embeddable to support grouped
messages
    * [x] Added unit tests
  
<img width="750" alt="Screenshot 2023-06-07 at 15 31 39"
src="01bf8203-9133-4429-9b79-17ec67613c7e">
<img width="828" alt="Screenshot 2023-06-07 at 15 30 57"
src="9acb78f2-d061-4225-a4af-b3a66e7454fc">
<img width="756" alt="Screenshot 2023-06-07 at 15 27 43"
src="b9f79aed-7c02-4060-9c0f-61f438dc031d">


* Add support for Open in Lens
  * [x] Add unit tests for each converter
  * [x] Functional tests


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
 2023-06-09 17:55:47 +02:00
Matthias Wilhelm
badc116729
[Discover] Remove Options of top navigation (#159087) 
This commit removes Discover's top menu `Options` entry.
 2023-06-07 22:00:36 +02:00