mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 01:38:56 -04:00
3459 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Kibana Machine
|
144056ef08
|
[8.8] [Lens] small drag and drop visual fixes (#159651) (#160172)
# Backport This will backport the following commits from `main` to `8.8`: - [[Lens] small drag and drop visual fixes (#159651)](https://github.com/elastic/kibana/pull/159651) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-21T16:08:13Z","message":"[Lens] small drag and drop visual fixes (#159651)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/159572\r\n\r\n1. The dimension element should be invisible when being moved - fixed by\r\n`.domDragDrop-isHidden` css below `.domDragDrop--isDragStarted` that was\r\noverwriting opacity.\r\n\r\nbefore:\r\n<img width=\"508\" alt=\"Screenshot 2023-06-14 at 09 45 23\"\r\nsrc=\" |
||
Dario Gieselaar
|
f190fd1da9
|
Revert "[8.8] [APM] Circuit breaker and perf improvements for service… (#160132) | ||
|
Kibana Machine
|
b2688fe4ed
|
[8.8] [APM] Circuit breaker and perf improvements for service map (#159883) (#160060)
# Backport This will backport the following commits from `main` to `8.8`: - [[APM] Circuit breaker and perf improvements for service map (#159883)](https://github.com/elastic/kibana/pull/159883) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dario Gieselaar","email":"dario.gieselaar@elastic.co"},"sourceCommit":{"committedDate":"2023-06-20T16:38:23Z","message":"[APM] Circuit breaker and perf improvements for service map (#159883)\n\nCloses #101920\r\n\r\nThis PR does three things:\r\n\r\n- add a `terminate_after` parameter to the search request for the\r\nscripted metric agg. This is a configurable setting\r\n(`xpack.apm.serviceMapTerminateAfter`) and defaults to 100k. This is a\r\nshard-level parameter, so there's still the possibility of lots of\r\nshards individually returning 100k documents and the coordinating node\r\nrunning out of memory because it is collecting all these docs from\r\nindividual shards. However, I suspect that there is already some\r\nprotection in the reduce phase that will terminate the request with a\r\nstack_overflow_error without OOMing, I've reached out to the ES team to\r\nconfirm whether this is the case.\r\n- add `xpack.apm.serviceMapMaxTraces`: this tells the max traces to\r\ninspect in total, not just per search request. IE, if\r\n`xpack.apm.serviceMapMaxTracesPerRequest` is 1, we simply chunk the\r\ntraces in n chunks, so it doesn't really help with memory management.\r\n`serviceMapMaxTraces` refers to the total amount of traces to inspect.\r\n- rewrite `getConnections` to use local mutation instead of\r\nimmutability. I saw huge CPU usage (with admittedly a pathological\r\nscenario where there are 100s of services) in the `getConnections`\r\nfunction, because it uses a deduplication mechanism that is O(n²), so I\r\nrewrote it to O(n). Here's a before :\r\n\r\n\r\n (#159910)
# Backport This will backport the following commits from `main` to `8.8`: - [[esArchiver] Automatically cleanup SO indices when SO documents are found in data.json (#159582)](https://github.com/elastic/kibana/pull/159582) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-06-19T11:08:03Z","message":"[esArchiver] Automatically cleanup SO indices when SO documents are found in data.json (#159582)\n\nThe ultimate goal of this PR is to lay the groundwork to be able to\r\nremove the \"dynamic\" `mappings.json`, which probably should have never\r\nexisted.\r\n\r\nWith the PR, detecting SO documents in the `data.json` will\r\nautomatically trigger a cleanup of the SO indices.\r\nThis, in turn, will allow not having to define \"dynamic\" saved objects\r\nindices (i.e. those with the `$KIBANA_PACKAGE_VERSION` variable in the\r\n`mappings.json`).\r\n\r\nIIUC the idea behind the dynamic indices was to have SO indices that are\r\naligned with the current stack version, avoiding the extra overhead of\r\nhaving to migrate the inserted documents, and reducing overall test\r\ntimes.\r\n\r\nNonetheless, what is happening today is:\r\n1. FTR starts ES and Kibana.\r\n2. Kibana creates current version SO indices at startup (empty ones).\r\n3. `esArchiver.load()` processes the `mappings.json`.\r\n3.1. It detects that we are defining SO indices and **deletes** existing\r\nsaved object indices.\r\n3.2 It then re-creates these indices according to the definitions on\r\n`mappings.json`.\r\n4. `esArchiver.load()` processes the `data.json`. Specifically, it\r\ninserts SO documents present in `data.json`.\r\n5. `esArchiver.load()` calls the _KibanaMigrator_ to make sure that the\r\ninserted documents are up-to-date, hoping they are already aligned with\r\ncurrent stack version (which is not always the case, not even with\r\n\"dynamic\" mappings).\r\n\r\nTwo interesting things to note:\r\n- Steps 3 to 5 happen whilst Kibana is already started and running. If\r\nKibana queries SO indices during `esArchiver.load()`, and a request to\r\nES is made **right after** 3.2, the result might be\r\nhttps://github.com/elastic/kibana/issues/158918.\r\n- Having dynamic SO indices' definitions, deleting the \"official\"\r\nindices created by Kibana (3.1), and recreating them hoping to be\r\naligned with current stack version (3.2) is non-sense. We could use the\r\nexisting SO indices instead, and simply clean them up whenever we are\r\nabout to insert SO documents.\r\n\r\nPerforming that cleanup is precisely the goal of this PR.\r\nThen, in subsequent PRs like\r\nhttps://github.com/elastic/kibana/pull/159397/files, tackling the flaky\r\ntests, we'll be able to simply remove the \"dynamic\" `mappings.json`\r\ndefinitions, causing `esArchiver` to rely on SO indices created by\r\nKibana.\r\n\r\nThanks to this PR, the FTR tests won't need to explicitly cleanup saved\r\nobject indices in the `before` hooks.","sha":"bbb5fc4abe7dd530d8248a09a9638cd3438202aa","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Team:Operations","technical debt","release_note:skip","backport:prev-minor","v8.9.0","FTR","v8.8.2"],"number":159582,"url":"https://github.com/elastic/kibana/pull/159582","mergeCommit":{"message":"[esArchiver] Automatically cleanup SO indices when SO documents are found in data.json (#159582)\n\nThe ultimate goal of this PR is to lay the groundwork to be able to\r\nremove the \"dynamic\" `mappings.json`, which probably should have never\r\nexisted.\r\n\r\nWith the PR, detecting SO documents in the `data.json` will\r\nautomatically trigger a cleanup of the SO indices.\r\nThis, in turn, will allow not having to define \"dynamic\" saved objects\r\nindices (i.e. those with the `$KIBANA_PACKAGE_VERSION` variable in the\r\n`mappings.json`).\r\n\r\nIIUC the idea behind the dynamic indices was to have SO indices that are\r\naligned with the current stack version, avoiding the extra overhead of\r\nhaving to migrate the inserted documents, and reducing overall test\r\ntimes.\r\n\r\nNonetheless, what is happening today is:\r\n1. FTR starts ES and Kibana.\r\n2. Kibana creates current version SO indices at startup (empty ones).\r\n3. `esArchiver.load()` processes the `mappings.json`.\r\n3.1. It detects that we are defining SO indices and **deletes** existing\r\nsaved object indices.\r\n3.2 It then re-creates these indices according to the definitions on\r\n`mappings.json`.\r\n4. `esArchiver.load()` processes the `data.json`. Specifically, it\r\ninserts SO documents present in `data.json`.\r\n5. `esArchiver.load()` calls the _KibanaMigrator_ to make sure that the\r\ninserted documents are up-to-date, hoping they are already aligned with\r\ncurrent stack version (which is not always the case, not even with\r\n\"dynamic\" mappings).\r\n\r\nTwo interesting things to note:\r\n- Steps 3 to 5 happen whilst Kibana is already started and running. If\r\nKibana queries SO indices during `esArchiver.load()`, and a request to\r\nES is made **right after** 3.2, the result might be\r\nhttps://github.com/elastic/kibana/issues/158918.\r\n- Having dynamic SO indices' definitions, deleting the \"official\"\r\nindices created by Kibana (3.1), and recreating them hoping to be\r\naligned with current stack version (3.2) is non-sense. We could use the\r\nexisting SO indices instead, and simply clean them up whenever we are\r\nabout to insert SO documents.\r\n\r\nPerforming that cleanup is precisely the goal of this PR.\r\nThen, in subsequent PRs like\r\nhttps://github.com/elastic/kibana/pull/159397/files, tackling the flaky\r\ntests, we'll be able to simply remove the \"dynamic\" `mappings.json`\r\ndefinitions, causing `esArchiver` to rely on SO indices created by\r\nKibana.\r\n\r\nThanks to this PR, the FTR tests won't need to explicitly cleanup saved\r\nobject indices in the `before` hooks.","sha":"bbb5fc4abe7dd530d8248a09a9638cd3438202aa"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159582","number":159582,"mergeCommit":{"message":"[esArchiver] Automatically cleanup SO indices when SO documents are found in data.json (#159582)\n\nThe ultimate goal of this PR is to lay the groundwork to be able to\r\nremove the \"dynamic\" `mappings.json`, which probably should have never\r\nexisted.\r\n\r\nWith the PR, detecting SO documents in the `data.json` will\r\nautomatically trigger a cleanup of the SO indices.\r\nThis, in turn, will allow not having to define \"dynamic\" saved objects\r\nindices (i.e. those with the `$KIBANA_PACKAGE_VERSION` variable in the\r\n`mappings.json`).\r\n\r\nIIUC the idea behind the dynamic indices was to have SO indices that are\r\naligned with the current stack version, avoiding the extra overhead of\r\nhaving to migrate the inserted documents, and reducing overall test\r\ntimes.\r\n\r\nNonetheless, what is happening today is:\r\n1. FTR starts ES and Kibana.\r\n2. Kibana creates current version SO indices at startup (empty ones).\r\n3. `esArchiver.load()` processes the `mappings.json`.\r\n3.1. It detects that we are defining SO indices and **deletes** existing\r\nsaved object indices.\r\n3.2 It then re-creates these indices according to the definitions on\r\n`mappings.json`.\r\n4. `esArchiver.load()` processes the `data.json`. Specifically, it\r\ninserts SO documents present in `data.json`.\r\n5. `esArchiver.load()` calls the _KibanaMigrator_ to make sure that the\r\ninserted documents are up-to-date, hoping they are already aligned with\r\ncurrent stack version (which is not always the case, not even with\r\n\"dynamic\" mappings).\r\n\r\nTwo interesting things to note:\r\n- Steps 3 to 5 happen whilst Kibana is already started and running. If\r\nKibana queries SO indices during `esArchiver.load()`, and a request to\r\nES is made **right after** 3.2, the result might be\r\nhttps://github.com/elastic/kibana/issues/158918.\r\n- Having dynamic SO indices' definitions, deleting the \"official\"\r\nindices created by Kibana (3.1), and recreating them hoping to be\r\naligned with current stack version (3.2) is non-sense. We could use the\r\nexisting SO indices instead, and simply clean them up whenever we are\r\nabout to insert SO documents.\r\n\r\nPerforming that cleanup is precisely the goal of this PR.\r\nThen, in subsequent PRs like\r\nhttps://github.com/elastic/kibana/pull/159397/files, tackling the flaky\r\ntests, we'll be able to simply remove the \"dynamic\" `mappings.json`\r\ndefinitions, causing `esArchiver` to rely on SO indices created by\r\nKibana.\r\n\r\nThanks to this PR, the FTR tests won't need to explicitly cleanup saved\r\nobject indices in the `before` hooks.","sha":"bbb5fc4abe7dd530d8248a09a9638cd3438202aa"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co> |
||
Georgii Gorbachev
|
c65f896563
|
[8.8] [Security Solution] PoC of the Detection Engine health API (#157155) (#159717)
# Backport This will backport the following PR from `main` to `8.8`: - https://github.com/elastic/kibana/pull/157155 ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) |
||
|
Kibana Machine
|
2a02b2aa78
|
[8.8] fix(NA): build external plugins with correct bazel artifacts output mode (#159630) (#159761)
# Backport This will backport the following commits from `main` to `8.8`: - [fix(NA): build external plugins with correct bazel artifacts output mode (#159630)](https://github.com/elastic/kibana/pull/159630) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"tiago.costa@elastic.co"},"sourceCommit":{"committedDate":"2023-06-14T23:43:05Z","message":"fix(NA): build external plugins with correct bazel artifacts output mode (#159630)\n\nCloses https://github.com/elastic/kibana/issues/159328 ,\r\nhttps://github.com/elastic/kibana/issues/154325,\r\nhttps://github.com/elastic/kibana/issues/157440\r\n\r\nThis PR fixes a problem in the plugin helpers tasks used to build\r\nexternal plugins. After changes to transpile packages differently in the\r\npast months a bug was introduced and external plugins were being built\r\nwith the wrong shared ui deps output mode causing development form\r\nimports to be bundled and causing problems at page load time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","auto-backport","v8.7.2","v8.9.0","v8.8.2"],"number":159630,"url":"https://github.com/elastic/kibana/pull/159630","mergeCommit":{"message":"fix(NA): build external plugins with correct bazel artifacts output mode (#159630)\n\nCloses https://github.com/elastic/kibana/issues/159328 ,\r\nhttps://github.com/elastic/kibana/issues/154325,\r\nhttps://github.com/elastic/kibana/issues/157440\r\n\r\nThis PR fixes a problem in the plugin helpers tasks used to build\r\nexternal plugins. After changes to transpile packages differently in the\r\npast months a bug was introduced and external plugins were being built\r\nwith the wrong shared ui deps output mode causing development form\r\nimports to be bundled and causing problems at page load time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7"}},"sourceBranch":"main","suggestedTargetBranches":["8.7","8.8"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159630","number":159630,"mergeCommit":{"message":"fix(NA): build external plugins with correct bazel artifacts output mode (#159630)\n\nCloses https://github.com/elastic/kibana/issues/159328 ,\r\nhttps://github.com/elastic/kibana/issues/154325,\r\nhttps://github.com/elastic/kibana/issues/157440\r\n\r\nThis PR fixes a problem in the plugin helpers tasks used to build\r\nexternal plugins. After changes to transpile packages differently in the\r\npast months a bug was introduced and external plugins were being built\r\nwith the wrong shared ui deps output mode causing development form\r\nimports to be bundled and causing problems at page load time.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"7e067ec47866007051be6afad2a46ab9f8438cb7"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tiago Costa <tiago.costa@elastic.co> |
||
|
Kibana Machine
|
57149aab96
|
[8.8] [ResponseOps] optimize building ecsFieldMap (#159251) (#159313)
# Backport This will backport the following commits from `main` to `8.8`: - [[ResponseOps] optimize building ecsFieldMap (#159251)](https://github.com/elastic/kibana/pull/159251) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Patrick Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2023-06-08T14:06:01Z","message":"[ResponseOps] optimize building ecsFieldMap (#159251)\n\nresolves https://github.com/elastic/kibana/issues/157772\r\n\r\nPreviously on my M1 Macbook, the `ecsFieldMap` constant takes about 170\r\nms to be created. It appears this is another case of `array::reduce()`\r\nand object spread causing performance issues.\r\n\r\nConverting to (essentially) a filter and map got the time down to 4 ms.\r\n\r\nSlightly critical even though this is only ever run once - because it's\r\nrun at startup time, and blocking everything else from running.\r\n\r\nSee:\r\n\r\n-\r\nhttps://www.richsnapp.com/article/2019/06-09-reduce-spread-anti-pattern\r\n-\r\nhttps://prateeksurana.me/blog/why-using-object-spread-with-reduce-bad-idea/","sha":"6e81ae83bc17b020684e3d206dbb696c225e9d1c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","v8.9.0","v8.8.2"],"number":159251,"url":"https://github.com/elastic/kibana/pull/159251","mergeCommit":{"message":"[ResponseOps] optimize building ecsFieldMap (#159251)\n\nresolves https://github.com/elastic/kibana/issues/157772\r\n\r\nPreviously on my M1 Macbook, the `ecsFieldMap` constant takes about 170\r\nms to be created. It appears this is another case of `array::reduce()`\r\nand object spread causing performance issues.\r\n\r\nConverting to (essentially) a filter and map got the time down to 4 ms.\r\n\r\nSlightly critical even though this is only ever run once - because it's\r\nrun at startup time, and blocking everything else from running.\r\n\r\nSee:\r\n\r\n-\r\nhttps://www.richsnapp.com/article/2019/06-09-reduce-spread-anti-pattern\r\n-\r\nhttps://prateeksurana.me/blog/why-using-object-spread-with-reduce-bad-idea/","sha":"6e81ae83bc17b020684e3d206dbb696c225e9d1c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159251","number":159251,"mergeCommit":{"message":"[ResponseOps] optimize building ecsFieldMap (#159251)\n\nresolves https://github.com/elastic/kibana/issues/157772\r\n\r\nPreviously on my M1 Macbook, the `ecsFieldMap` constant takes about 170\r\nms to be created. It appears this is another case of `array::reduce()`\r\nand object spread causing performance issues.\r\n\r\nConverting to (essentially) a filter and map got the time down to 4 ms.\r\n\r\nSlightly critical even though this is only ever run once - because it's\r\nrun at startup time, and blocking everything else from running.\r\n\r\nSee:\r\n\r\n-\r\nhttps://www.richsnapp.com/article/2019/06-09-reduce-spread-anti-pattern\r\n-\r\nhttps://prateeksurana.me/blog/why-using-object-spread-with-reduce-bad-idea/","sha":"6e81ae83bc17b020684e3d206dbb696c225e9d1c"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Patrick Mueller <patrick.mueller@elastic.co> |
||
|
Kibana Machine
|
1b018afbe1
|
[8.8] [APM] Don't use service tx metrics on transaction detail page (#159085) (#159281)
# Backport This will backport the following commits from `main` to `8.8`: - [[APM] Don't use service tx metrics on transaction detail page (#159085)](https://github.com/elastic/kibana/pull/159085) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dario Gieselaar","email":"dario.gieselaar@elastic.co"},"sourceCommit":{"committedDate":"2023-06-08T07:20:13Z","message":"[APM] Don't use service tx metrics on transaction detail page (#159085)","sha":"74102e592f5193e9566b16d921931c2dc2a67a86","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:APM","v8.9.0","v8.8.2"],"number":159085,"url":"https://github.com/elastic/kibana/pull/159085","mergeCommit":{"message":"[APM] Don't use service tx metrics on transaction detail page (#159085)","sha":"74102e592f5193e9566b16d921931c2dc2a67a86"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159085","number":159085,"mergeCommit":{"message":"[APM] Don't use service tx metrics on transaction detail page (#159085)","sha":"74102e592f5193e9566b16d921931c2dc2a67a86"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> |
||
|
Kibana Machine
|
64b1138d19
|
[8.8] [maps] fix Map orphans sources on layer deletion (#159067) (#159160)
# Backport This will backport the following commits from `main` to `8.8`: - [[maps] fix Map orphans sources on layer deletion (#159067)](https://github.com/elastic/kibana/pull/159067) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-06-06T20:34:40Z","message":"[maps] fix Map orphans sources on layer deletion (#159067)\n\nFixes https://github.com/elastic/kibana/issues/158133\r\n\r\nSources where not getting removed because `return` was used instead of\r\n`continue` in `for...in` loop. This caused the function to return\r\ninstead of processing remaining sources.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"fcd195050f14f38c9427a9b9819baef442baf854","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Feature:Maps","v8.9.0","v8.8.2"],"number":159067,"url":"https://github.com/elastic/kibana/pull/159067","mergeCommit":{"message":"[maps] fix Map orphans sources on layer deletion (#159067)\n\nFixes https://github.com/elastic/kibana/issues/158133\r\n\r\nSources where not getting removed because `return` was used instead of\r\n`continue` in `for...in` loop. This caused the function to return\r\ninstead of processing remaining sources.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"fcd195050f14f38c9427a9b9819baef442baf854"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159067","number":159067,"mergeCommit":{"message":"[maps] fix Map orphans sources on layer deletion (#159067)\n\nFixes https://github.com/elastic/kibana/issues/158133\r\n\r\nSources where not getting removed because `return` was used instead of\r\n`continue` in `for...in` loop. This caused the function to return\r\ninstead of processing remaining sources.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"fcd195050f14f38c9427a9b9819baef442baf854"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co> |
||
|
Kibana Machine
|
ec659b1dcf
|
[8.8] [Security Solution] Add support for multiple values in cell actions (#158060) (#158104)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Add support for multiple values in cell actions (#158060)](https://github.com/elastic/kibana/pull/158060) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2023-05-18T18:49:47Z","message":"[Security Solution] Add support for multiple values in cell actions (#158060)\n\n## Summary\r\n\r\nfixes: https://github.com/elastic/kibana/issues/157237\r\ncloses: https://github.com/elastic/kibana/issues/157887 \r\n\r\nEnables cell actions package to support multi-valuated cells. Actions\r\naffected:\r\n- Filter In\r\n- Filter Out\r\n- Add To Timeline\r\n- Copy To Clipboard\r\n\r\n### Recording\r\n\r\n\r\n |
||
|
Kibana Machine
|
419cd20b4e
|
[8.8] Fix config stacking order (#158827) (#159025)
# Backport This will backport the following commits from `main` to `8.8`: - [Fix config stacking order (#158827)](https://github.com/elastic/kibana/pull/158827) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2023-06-05T13:15:07Z","message":"Fix config stacking order (#158827)\n\n## Summary\r\nFixes: #155154 (introduced in #149878), builds on #155436 .\r\n\r\n- Adds tests to ensure the configuration merging order, check those for\r\nreference.\r\n- Updates the README to explain the intention\r\n \r\nFor the tests, I needed to output something to the logs. I hope it's not\r\na big issue to log it. If needed, I might hide that behind a verbose- or\r\nfeature flag.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"c57589ec57e5e8265a66cd9c8c2102005736f6d8","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:fix","backport:prev-minor","v8.9.0"],"number":158827,"url":"https://github.com/elastic/kibana/pull/158827","mergeCommit":{"message":"Fix config stacking order (#158827)\n\n## Summary\r\nFixes: #155154 (introduced in #149878), builds on #155436 .\r\n\r\n- Adds tests to ensure the configuration merging order, check those for\r\nreference.\r\n- Updates the README to explain the intention\r\n \r\nFor the tests, I needed to output something to the logs. I hope it's not\r\na big issue to log it. If needed, I might hide that behind a verbose- or\r\nfeature flag.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"c57589ec57e5e8265a66cd9c8c2102005736f6d8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158827","number":158827,"mergeCommit":{"message":"Fix config stacking order (#158827)\n\n## Summary\r\nFixes: #155154 (introduced in #149878), builds on #155436 .\r\n\r\n- Adds tests to ensure the configuration merging order, check those for\r\nreference.\r\n- Updates the README to explain the intention\r\n \r\nFor the tests, I needed to output something to the logs. I hope it's not\r\na big issue to log it. If needed, I might hide that behind a verbose- or\r\nfeature flag.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"c57589ec57e5e8265a66cd9c8c2102005736f6d8"}}]}] BACKPORT--> --------- Co-authored-by: Alex Szabo <alex.szabo@elastic.co> |
||
Gerard Soldevila
|
16f8c566ef
|
[8.8] [Migrations] Update all aliases with a single updateAliases() when relocating SO documents #158940 (#158992)
# Backport This will backport the following commits from `main` to `8.8`: - [[Migrations] Update all aliases with a single updateAliases() when relocating SO documents (#158940)](https://github.com/elastic/kibana/pull/158940) <!--- Backport version: Manual! --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) |
||
|
Kibana Machine
|
46217b9129
|
[8.8] Migrations: Don't auto-create temp index (#158182) (#158996)
# Backport This will backport the following commits from `main` to `8.8`: - [Migrations: Don't auto-create temp index (#158182)](https://github.com/elastic/kibana/pull/158182) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rudolf Meijering","email":"skaapgif@gmail.com"},"sourceCommit":{"committedDate":"2023-06-04T22:34:08Z","message":"Migrations: Don't auto-create temp index (#158182)\n\n## Summary\r\n\r\nTry to fix\r\nhttps://github.com/elastic/kibana/issues/156117#issuecomment-1557029863\r\n\r\n## Release notes\r\nFixes a race condition that could cause intermittent upgrade migration\r\nfailures when Kibana connects to a single node Elasticsearch cluster.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8e7e2632bbb5f2dfffe8ab6c2563e176c5d7cf6b","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","release_note:fix","Feature:Migrations","backport:prev-minor","v8.9.0"],"number":158182,"url":"https://github.com/elastic/kibana/pull/158182","mergeCommit":{"message":"Migrations: Don't auto-create temp index (#158182)\n\n## Summary\r\n\r\nTry to fix\r\nhttps://github.com/elastic/kibana/issues/156117#issuecomment-1557029863\r\n\r\n## Release notes\r\nFixes a race condition that could cause intermittent upgrade migration\r\nfailures when Kibana connects to a single node Elasticsearch cluster.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8e7e2632bbb5f2dfffe8ab6c2563e176c5d7cf6b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158182","number":158182,"mergeCommit":{"message":"Migrations: Don't auto-create temp index (#158182)\n\n## Summary\r\n\r\nTry to fix\r\nhttps://github.com/elastic/kibana/issues/156117#issuecomment-1557029863\r\n\r\n## Release notes\r\nFixes a race condition that could cause intermittent upgrade migration\r\nfailures when Kibana connects to a single node Elasticsearch cluster.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risk Matrix\r\n\r\nDelete this section if it is not applicable to this PR.\r\n\r\nBefore closing this PR, invite QA, stakeholders, and other developers to\r\nidentify risks that should be tested prior to the change/feature\r\nrelease.\r\n\r\nWhen forming the risk matrix, consider some of the following examples\r\nand how they may potentially impact the change:\r\n\r\n| Risk | Probability | Severity | Mitigation/Notes |\r\n\r\n|---------------------------|-------------|----------|-------------------------|\r\n| Multiple Spaces—unexpected behavior in non-default Kibana Space.\r\n| Low | High | Integration tests will verify that all features are still\r\nsupported in non-default Kibana Space and when user switches between\r\nspaces. |\r\n| Multiple nodes—Elasticsearch polling might have race conditions\r\nwhen multiple Kibana nodes are polling for the same tasks. | High | Low\r\n| Tasks are idempotent, so executing them multiple times will not result\r\nin logical error, but will degrade performance. To test for this case we\r\nadd plenty of unit tests around this logic and document manual testing\r\nprocedure. |\r\n| Code should gracefully handle cases when feature X or plugin Y are\r\ndisabled. | Medium | High | Unit tests will verify that any feature flag\r\nor plugin combination still results in our service operational. |\r\n| [See more potential risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"8e7e2632bbb5f2dfffe8ab6c2563e176c5d7cf6b"}}]}] BACKPORT--> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> |
||
|
Gerard Soldevila
|
a82751c745
|
[8.8] Refactor KibanaMigrator, improve readability, maintainability and UT (#155693) (#158953)
# Backport This will backport the following commits from `main` to `8.8`: - [Refactor KibanaMigrator, improve readability, maintainability and UT (#155693)](https://github.com/elastic/kibana/pull/155693) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T12:47:40Z","message":"Refactor KibanaMigrator, improve readability, maintainability and UT (#155693)\n\nAddresses the following feedback:\r\nhttps://github.com/elastic/kibana/pull/154151#discussion_r1158470566\r\n\r\nSimilar to what has been done for ZDT, the goal of this PR is to extract\r\nthe logic of the `runV2Migration()` from the `KibanaMigrator` into a\r\nseparate file.\r\n\r\nThe PR also fixes some incomplete / incorrect UTs and adds a few missing\r\nones.","sha":"06c337f903a5b310f8a21a66065b186bbbc9642e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","enhancement","technical debt","release_note:skip","backport:skip","Feature:Migrations","Epic:KBNA-7838","v8.9.0"],"number":155693,"url":"https://github.com/elastic/kibana/pull/155693","mergeCommit":{"message":"Refactor KibanaMigrator, improve readability, maintainability and UT (#155693)\n\nAddresses the following feedback:\r\nhttps://github.com/elastic/kibana/pull/154151#discussion_r1158470566\r\n\r\nSimilar to what has been done for ZDT, the goal of this PR is to extract\r\nthe logic of the `runV2Migration()` from the `KibanaMigrator` into a\r\nseparate file.\r\n\r\nThe PR also fixes some incomplete / incorrect UTs and adds a few missing\r\nones.","sha":"06c337f903a5b310f8a21a66065b186bbbc9642e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155693","number":155693,"mergeCommit":{"message":"Refactor KibanaMigrator, improve readability, maintainability and UT (#155693)\n\nAddresses the following feedback:\r\nhttps://github.com/elastic/kibana/pull/154151#discussion_r1158470566\r\n\r\nSimilar to what has been done for ZDT, the goal of this PR is to extract\r\nthe logic of the `runV2Migration()` from the `KibanaMigrator` into a\r\nseparate file.\r\n\r\nThe PR also fixes some incomplete / incorrect UTs and adds a few missing\r\nones.","sha":"06c337f903a5b310f8a21a66065b186bbbc9642e"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
Garrett Spong
|
0773c44958
|
[8.8] [Security Solution] Elastic Security Assistant (#156933) (#158974)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Elastic Security Assistant (#156933)](https://github.com/elastic/kibana/pull/156933) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Garrett Spong","email":"spong@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-06-02T21:19:10Z","message":"[Security Solution] Elastic Security Assistant (#156933)\n\n## [Security Solution] Elastic Security Assistant\r\n\r\nThe _Elastic Security Assistant_ has entered the chat, integrating generative AI and large language models (LLMs) into the workflows of Elastic Security users.\r\n\r\nBring your alerts, events, rules, and data quality checks into the conversation.\r\n\r\n< |
||
|
Kibana Machine
|
7224b92a05
|
[8.8] [Telemetry] Log opt-in status at the INFO level (#158830) (#158971)
# Backport This will backport the following commits from `main` to `8.8`: - [[Telemetry] Log opt-in status at the INFO level (#158830)](https://github.com/elastic/kibana/pull/158830) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-06-02T20:59:04Z","message":"[Telemetry] Log opt-in status at the INFO level (#158830)","sha":"18e145ccb608b2cdd4f21fc766ebb3e19ff0e38d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Core","Feature:Telemetry","release_note:skip","backport:prev-minor","v8.9.0"],"number":158830,"url":"https://github.com/elastic/kibana/pull/158830","mergeCommit":{"message":"[Telemetry] Log opt-in status at the INFO level (#158830)","sha":"18e145ccb608b2cdd4f21fc766ebb3e19ff0e38d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158830","number":158830,"mergeCommit":{"message":"[Telemetry] Log opt-in status at the INFO level (#158830)","sha":"18e145ccb608b2cdd4f21fc766ebb3e19ff0e38d"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> |
||
|
Kibana Machine
|
045c4bcb10
|
[8.8] [Telemetry] Update notice message (#158669) (#158842)
# Backport This will backport the following commits from `main` to `8.8`: - [[Telemetry] Update notice message (#158669)](https://github.com/elastic/kibana/pull/158669) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T15:53:02Z","message":"[Telemetry] Update notice message (#158669)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>","sha":"312ba3a758a05cea2d490a5174838cd84ac2cc8d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Core","Feature:Telemetry","release_note:skip","backport:prev-minor","v8.9.0"],"number":158669,"url":"https://github.com/elastic/kibana/pull/158669","mergeCommit":{"message":"[Telemetry] Update notice message (#158669)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>","sha":"312ba3a758a05cea2d490a5174838cd84ac2cc8d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158669","number":158669,"mergeCommit":{"message":"[Telemetry] Update notice message (#158669)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>","sha":"312ba3a758a05cea2d490a5174838cd84ac2cc8d"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> |
||
Kevin Qualters
|
cc69e5ba15
|
[8.8] [Security Solution] getDataViewStateFromIndexFields was using wrong type as part of a cast (#158594) (#158784)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] getDataViewStateFromIndexFields was using wrong type as part of a cast (#158594)](https://github.com/elastic/kibana/pull/158594) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Qualters","email":"56408403+kqualters-elastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-31T21:13:36Z","message":"[Security Solution] getDataViewStateFromIndexFields was using wrong type as part of a cast (#158594)\n\n## Summary\r\n\r\nFixes an issue with the field browser where all types currently display\r\nas unkown, this was because in a code path where a type cast happens, we\r\nwere using the wrong type. To see this, remove the as unknown from the\r\ncast, and the typescript compiler will show the problem:\r\n```\r\n'BrowserField' is deprecated.ts(6385)\r\nindex.ts(70, 4): The declaration was marked as deprecated here.\r\nConversion of type 'DataViewField' to type 'BrowserField' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.\r\n Type 'DataViewField' is missing the following properties from type 'BrowserField': category, description, example, fields, and 2 more.ts(2352)\r\n```\r\nDataViewField actually only has spec and kbnFieldType properties, spec\r\nis of type FieldSpec which is basically the same type as BrowserField,\r\nand has sufficient overlap for the (still unsafe, but more safe than as\r\nunknown) cast to occur.\r\n\r\nBefore:\r\n<img width=\"338\" alt=\"image\"\r\nsrc=\" |
||
|
Kibana Machine
|
f006d49dd1
|
[8.8] Prevent rollback for failed upgrades from write_blocking SO indices (#158725) (#158738)
# Backport This will backport the following commits from `main` to `8.8`: - [Prevent rollback for failed upgrades from write_blocking SO indices (#158725)](https://github.com/elastic/kibana/pull/158725) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-05-31T15:09:47Z","message":"Prevent rollback for failed upgrades from write_blocking SO indices (#158725)\n\nTackles https://github.com/elastic/kibana/issues/155136\r\n\r\nWhen an upgrade fails, a cluster might be on a partially migrated state\r\n(with some indices already updated to the newer version). When rolling\r\nback to the previous version, in ESS, this can cause these indices to be\r\n`write_blocked`.\r\n\r\nThis PR aims at detecting this situation and failing early, effectively\r\npreventing to `write_block` any indices.","sha":"1c5b09dd066d364b82e5d0580045b25b8f11dce9","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","release_note:skip","Feature:Migrations","backport:prev-minor","v8.9.0","v8.8.1"],"number":158725,"url":"https://github.com/elastic/kibana/pull/158725","mergeCommit":{"message":"Prevent rollback for failed upgrades from write_blocking SO indices (#158725)\n\nTackles https://github.com/elastic/kibana/issues/155136\r\n\r\nWhen an upgrade fails, a cluster might be on a partially migrated state\r\n(with some indices already updated to the newer version). When rolling\r\nback to the previous version, in ESS, this can cause these indices to be\r\n`write_blocked`.\r\n\r\nThis PR aims at detecting this situation and failing early, effectively\r\npreventing to `write_block` any indices.","sha":"1c5b09dd066d364b82e5d0580045b25b8f11dce9"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158725","number":158725,"mergeCommit":{"message":"Prevent rollback for failed upgrades from write_blocking SO indices (#158725)\n\nTackles https://github.com/elastic/kibana/issues/155136\r\n\r\nWhen an upgrade fails, a cluster might be on a partially migrated state\r\n(with some indices already updated to the newer version). When rolling\r\nback to the previous version, in ESS, this can cause these indices to be\r\n`write_blocked`.\r\n\r\nThis PR aims at detecting this situation and failing early, effectively\r\npreventing to `write_block` any indices.","sha":"1c5b09dd066d364b82e5d0580045b25b8f11dce9"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co> |
||
|
Gerard Soldevila
|
c26fcf79cd
|
[8.8] Migrations: dynamically adjust batchSize when reading (#157494) (#158660)
# Backport This will backport the following commits from `main` to `8.8`: - [Migrations: dynamically adjust batchSize when reading (#157494)](https://github.com/elastic/kibana/pull/157494) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rudolf Meijering","email":"skaapgif@gmail.com"},"sourceCommit":{"committedDate":"2023-05-30T13:25:07Z","message":"Migrations: dynamically adjust batchSize when reading (#157494)\n\n## Summary\r\n\r\nMigrations read 1000 documents by default which works well for most\r\ndeployments. But if any batch happens to be > ~512MB we hit NodeJS' max\r\nstring length limit and cannot process that batch. This forces users to\r\nreduce the batch size to a smaller number which could severely slow down\r\nmigrations.\r\n\r\nThis PR reduces the impact of large batches by catching\r\nelasticsearch-js' `RequestAbortedError` and reducing the batch size in\r\nhalf. When subsequent batches are successful the batchSize increases by\r\n20%. This means we'll have a sequence like:\r\n\r\n1. Read 1000 docs ✅ (small batch)\r\n2. Read 1000 docs 🔴 (too large batch)\r\n3. Read 500 docs ✅ \r\n4. Read 600 docs ✅ \r\n5. Read 720 docs ✅\r\n6. Read 864 docs ✅\r\n7. Read 1000 docs ✅ (small batch)\r\n\r\nThis assumes that most clusters just have a few large batches exceeding\r\nthe limit. If all batches exceed the limit we'd have 1 failure for every\r\n4 successful reads so we pay a 20% throughput penalty. In such a case it\r\nwould be better to configure a lower `migrations.batchSize`.\r\n\r\nTested this manually:\r\n1. Start ES with more heap than the default, otherwise reading large\r\nbatches will cause it to run out of memory\r\n`ES_JAVA_OPTS=' -Xms6g -Xmx6g' yarn es snapshot\r\n--data-archive=/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/archives/8.4.0_with_sample_data_logs.zip`\r\n2. Ingest lots of large documents of ~5mb\r\n ```\r\ncurl -XPUT\r\n\"elastic:changeme@localhost:9200/_security/role/grant_kibana_system_indices\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n { \r\n \"indices\": [ \r\n {\r\n \"names\": [\r\n \".kibana*\"\r\n ],\r\n \"privileges\": [\r\n \"all\"\r\n ],\r\n \"allow_restricted_indices\": true\r\n }\r\n ]\r\n }'\r\n\r\ncurl -XPOST \"elastic:changeme@localhost:9200/_security/user/superuser\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"password\" : \"changeme\", \r\n \"roles\" : [ \"superuser\", \"grant_kibana_system_indices\" ]\r\n }'\r\n\r\ncurl -XPUT\r\n\"superuser:changeme@localhost:9200/.kibana_8.4.0_001/_mappings\" -H\r\n\"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n\"dynamic\": false,\r\n \"properties\": {\r\n\r\n }\r\n\r\n }'\r\n\r\n set -B # enable brace expansion\r\n for i in {1..400}; do\r\ncurl -k --data-binary\r\n\"@/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/group3/body.json\"\r\n-X PUT\r\n\"http://superuser:changeme@localhost:9200/.kibana_8.4.0_001/_doc/cases-comments:\"{$i}\"?&pretty=true\"\r\n-H \"Content-Type: application/json\"\r\n done\r\n ```\r\n3. Start Kibana with a modest batchSize otherwise we could OOM ES `node\r\nscripts/kibana --dev --migrations.batchSize=120`\r\n\r\n\r\n\r\n<details><summary>Example logs. Note the \"Processed x documents\" only\r\nlogs when the next batch is successfull read, so the order seems wrong.\r\nTo improve it we'd need to log progress after a batch is successfully\r\nwritten instead 🤷 </summary>\r\n```\r\n[.kibana] Processed 120 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3667ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1740ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1376ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1402ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1311ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 900ms.\r\n[.kibana] Read a batch that exceeded the NodeJS maximum string length, retrying by reducing the batch size in half to 60.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_READ. took: 1538ms.\r\n[.kibana] Processed 240 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2054ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1042ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1130ms.\r\n[.kibana] Processed 300 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2610ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1262ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1299ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1363ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1341ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 572ms.\r\n[.kibana] Processed 372 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3330ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1488ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1349ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1312ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1380ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 139ms.\r\n[.kibana] Processed 458 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3278ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1460ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1370ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1303ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1384ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1298ms.\r\n[.kibana] Processed 542 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 4ms.\r\n```\r\n</details>\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risks\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>","sha":"094b62a6d6afd30914584e03bb6616e7c2eaec4a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","release_note:fix","Feature:Migrations","backport:prev-minor","v8.9.0","v8.8.1"],"number":157494,"url":"https://github.com/elastic/kibana/pull/157494","mergeCommit":{"message":"Migrations: dynamically adjust batchSize when reading (#157494)\n\n## Summary\r\n\r\nMigrations read 1000 documents by default which works well for most\r\ndeployments. But if any batch happens to be > ~512MB we hit NodeJS' max\r\nstring length limit and cannot process that batch. This forces users to\r\nreduce the batch size to a smaller number which could severely slow down\r\nmigrations.\r\n\r\nThis PR reduces the impact of large batches by catching\r\nelasticsearch-js' `RequestAbortedError` and reducing the batch size in\r\nhalf. When subsequent batches are successful the batchSize increases by\r\n20%. This means we'll have a sequence like:\r\n\r\n1. Read 1000 docs ✅ (small batch)\r\n2. Read 1000 docs 🔴 (too large batch)\r\n3. Read 500 docs ✅ \r\n4. Read 600 docs ✅ \r\n5. Read 720 docs ✅\r\n6. Read 864 docs ✅\r\n7. Read 1000 docs ✅ (small batch)\r\n\r\nThis assumes that most clusters just have a few large batches exceeding\r\nthe limit. If all batches exceed the limit we'd have 1 failure for every\r\n4 successful reads so we pay a 20% throughput penalty. In such a case it\r\nwould be better to configure a lower `migrations.batchSize`.\r\n\r\nTested this manually:\r\n1. Start ES with more heap than the default, otherwise reading large\r\nbatches will cause it to run out of memory\r\n`ES_JAVA_OPTS=' -Xms6g -Xmx6g' yarn es snapshot\r\n--data-archive=/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/archives/8.4.0_with_sample_data_logs.zip`\r\n2. Ingest lots of large documents of ~5mb\r\n ```\r\ncurl -XPUT\r\n\"elastic:changeme@localhost:9200/_security/role/grant_kibana_system_indices\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n { \r\n \"indices\": [ \r\n {\r\n \"names\": [\r\n \".kibana*\"\r\n ],\r\n \"privileges\": [\r\n \"all\"\r\n ],\r\n \"allow_restricted_indices\": true\r\n }\r\n ]\r\n }'\r\n\r\ncurl -XPOST \"elastic:changeme@localhost:9200/_security/user/superuser\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"password\" : \"changeme\", \r\n \"roles\" : [ \"superuser\", \"grant_kibana_system_indices\" ]\r\n }'\r\n\r\ncurl -XPUT\r\n\"superuser:changeme@localhost:9200/.kibana_8.4.0_001/_mappings\" -H\r\n\"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n\"dynamic\": false,\r\n \"properties\": {\r\n\r\n }\r\n\r\n }'\r\n\r\n set -B # enable brace expansion\r\n for i in {1..400}; do\r\ncurl -k --data-binary\r\n\"@/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/group3/body.json\"\r\n-X PUT\r\n\"http://superuser:changeme@localhost:9200/.kibana_8.4.0_001/_doc/cases-comments:\"{$i}\"?&pretty=true\"\r\n-H \"Content-Type: application/json\"\r\n done\r\n ```\r\n3. Start Kibana with a modest batchSize otherwise we could OOM ES `node\r\nscripts/kibana --dev --migrations.batchSize=120`\r\n\r\n\r\n\r\n<details><summary>Example logs. Note the \"Processed x documents\" only\r\nlogs when the next batch is successfull read, so the order seems wrong.\r\nTo improve it we'd need to log progress after a batch is successfully\r\nwritten instead 🤷 </summary>\r\n```\r\n[.kibana] Processed 120 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3667ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1740ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1376ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1402ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1311ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 900ms.\r\n[.kibana] Read a batch that exceeded the NodeJS maximum string length, retrying by reducing the batch size in half to 60.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_READ. took: 1538ms.\r\n[.kibana] Processed 240 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2054ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1042ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1130ms.\r\n[.kibana] Processed 300 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2610ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1262ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1299ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1363ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1341ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 572ms.\r\n[.kibana] Processed 372 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3330ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1488ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1349ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1312ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1380ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 139ms.\r\n[.kibana] Processed 458 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3278ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1460ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1370ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1303ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1384ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1298ms.\r\n[.kibana] Processed 542 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 4ms.\r\n```\r\n</details>\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risks\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>","sha":"094b62a6d6afd30914584e03bb6616e7c2eaec4a"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157494","number":157494,"mergeCommit":{"message":"Migrations: dynamically adjust batchSize when reading (#157494)\n\n## Summary\r\n\r\nMigrations read 1000 documents by default which works well for most\r\ndeployments. But if any batch happens to be > ~512MB we hit NodeJS' max\r\nstring length limit and cannot process that batch. This forces users to\r\nreduce the batch size to a smaller number which could severely slow down\r\nmigrations.\r\n\r\nThis PR reduces the impact of large batches by catching\r\nelasticsearch-js' `RequestAbortedError` and reducing the batch size in\r\nhalf. When subsequent batches are successful the batchSize increases by\r\n20%. This means we'll have a sequence like:\r\n\r\n1. Read 1000 docs ✅ (small batch)\r\n2. Read 1000 docs 🔴 (too large batch)\r\n3. Read 500 docs ✅ \r\n4. Read 600 docs ✅ \r\n5. Read 720 docs ✅\r\n6. Read 864 docs ✅\r\n7. Read 1000 docs ✅ (small batch)\r\n\r\nThis assumes that most clusters just have a few large batches exceeding\r\nthe limit. If all batches exceed the limit we'd have 1 failure for every\r\n4 successful reads so we pay a 20% throughput penalty. In such a case it\r\nwould be better to configure a lower `migrations.batchSize`.\r\n\r\nTested this manually:\r\n1. Start ES with more heap than the default, otherwise reading large\r\nbatches will cause it to run out of memory\r\n`ES_JAVA_OPTS=' -Xms6g -Xmx6g' yarn es snapshot\r\n--data-archive=/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/archives/8.4.0_with_sample_data_logs.zip`\r\n2. Ingest lots of large documents of ~5mb\r\n ```\r\ncurl -XPUT\r\n\"elastic:changeme@localhost:9200/_security/role/grant_kibana_system_indices\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n { \r\n \"indices\": [ \r\n {\r\n \"names\": [\r\n \".kibana*\"\r\n ],\r\n \"privileges\": [\r\n \"all\"\r\n ],\r\n \"allow_restricted_indices\": true\r\n }\r\n ]\r\n }'\r\n\r\ncurl -XPOST \"elastic:changeme@localhost:9200/_security/user/superuser\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"password\" : \"changeme\", \r\n \"roles\" : [ \"superuser\", \"grant_kibana_system_indices\" ]\r\n }'\r\n\r\ncurl -XPUT\r\n\"superuser:changeme@localhost:9200/.kibana_8.4.0_001/_mappings\" -H\r\n\"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n\"dynamic\": false,\r\n \"properties\": {\r\n\r\n }\r\n\r\n }'\r\n\r\n set -B # enable brace expansion\r\n for i in {1..400}; do\r\ncurl -k --data-binary\r\n\"@/Users/rudolf/dev/kibana/src/core/server/integration_tests/saved_objects/migrations/group3/body.json\"\r\n-X PUT\r\n\"http://superuser:changeme@localhost:9200/.kibana_8.4.0_001/_doc/cases-comments:\"{$i}\"?&pretty=true\"\r\n-H \"Content-Type: application/json\"\r\n done\r\n ```\r\n3. Start Kibana with a modest batchSize otherwise we could OOM ES `node\r\nscripts/kibana --dev --migrations.batchSize=120`\r\n\r\n\r\n\r\n<details><summary>Example logs. Note the \"Processed x documents\" only\r\nlogs when the next batch is successfull read, so the order seems wrong.\r\nTo improve it we'd need to log progress after a batch is successfully\r\nwritten instead 🤷 </summary>\r\n```\r\n[.kibana] Processed 120 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3667ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1740ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1376ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1402ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1311ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 900ms.\r\n[.kibana] Read a batch that exceeded the NodeJS maximum string length, retrying by reducing the batch size in half to 60.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_READ. took: 1538ms.\r\n[.kibana] Processed 240 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2054ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1042ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1388ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1130ms.\r\n[.kibana] Processed 300 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 2610ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1262ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1299ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1363ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1341ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 572ms.\r\n[.kibana] Processed 372 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3330ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1488ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1349ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1312ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1380ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1310ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 139ms.\r\n[.kibana] Processed 458 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 3278ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1460ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1370ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1303ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 1384ms.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 1298ms.\r\n[.kibana] Processed 542 documents out of 542.\r\n[.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 4ms.\r\n```\r\n</details>\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### Risks\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>","sha":"094b62a6d6afd30914584e03bb6616e7c2eaec4a"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> |
||
Rudolf Meijering
|
45c322aa65
|
[8.8] Make updateAndPickupMappings batch size configurable (#153185) (#158235)
# Backport This will backport the following commits from `main` to `8.8`: - [Make updateAndPickupMappings batch size configurable (#153185)](https://github.com/elastic/kibana/pull/153185) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rudolf Meijering","email":"skaapgif@gmail.com"},"sourceCommit":{"committedDate":"2023-05-22T12:08:02Z","message":"Make updateAndPickupMappings batch size configurable (#153185)\n\n## Summary\r\n\r\nUse migrations.batchSize config for the scroll_size in update_by_query /\r\nupdateAndPickupMappings. The default scroll_size=1000 can sometimes\r\ncause Elasticsearch to fail with `RecyclerBytesStreamOutput cannot hold\r\nmore than 2GB of data`\r\n\r\nOn CI our Elasticsearch cluster does not have enough memory to reproduce\r\n`RecyclerBytesStreamOutput` error it OOMs before it's able to load 2GB.\r\n\r\nHowever it's possible to test manually:\r\n1. Start Elasticsearch with 8GB heap `ES_JAVA_OPTS=' -Xms8g -Xmx8g' yarn\r\nes snapshot`\r\n2. Ingest > 2GB of saved objects distributed over batchSize documents (<\r\n1000)\r\n ```\r\ncurl -XPOST \"elastic:changeme@localhost:9200/_security/user/superuser\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"password\" : \"changeme\", \r\n \"roles\" : [ \"superuser\", \"grant_kibana_system_indices\" ]\r\n }'\r\n\r\ncurl -XPUT\r\n\"superuser:changeme@localhost:9200/.kibana_8.4.0_001/_mappings\" -H\r\n\"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n\"dynamic\": false,\r\n \"properties\": {\r\n\r\n }\r\n\r\n }'\r\n\r\n set -B # enable brace expansion\r\n for i in {1..500}; do\r\ncurl -k --data-binary \"@/Users/rudolf/dev/kibana/body.json\" -X PUT\r\n\"http://superuser:changeme@localhost:9200/.kibana_8.4.0_001/_doc/cases-comments:\"{$i}\"?&pretty=true\"\r\n-H \"Content-Type: application/json\"\r\n done\r\n\r\ncurl -XPOST \"superuser:changeme@localhost:9200/_aliases\" -H \"kbn-xsrf:\r\nreporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"actions\": [\r\n {\r\n \"add\": {\r\n \"index\": \".kibana_8.4.0_001\",\r\n \"alias\": \".kibana_8.4.0\"\r\n }\r\n },\r\n {\r\n \"add\": {\r\n \"index\": \".kibana_8.4.0_001\",\r\n \"alias\": \".kibana\"\r\n }\r\n }\r\n ]\r\n }'\r\n ```\r\n body.json\r\n ```\r\n {\r\n \"cases-comments\": {\r\n \"comment\": \"...put lots of data here...\",\r\n \"type\": \"user\",\r\n \"owner\": \"cases\",\r\n \"created_at\": \"2023-05-09T08:07:50.121Z\",\r\n \"created_by\": {\r\n \"email\": null,\r\n \"full_name\": null,\r\n \"username\": \"elastic\"\r\n },\r\n \"pushed_at\": null,\r\n \"pushed_by\": null,\r\n \"updated_at\": null,\r\n \"updated_by\": null\r\n },\r\n \"type\": \"cases-comments\",\r\n \"references\": [\r\n {\r\n \"type\": \"cases\",\r\n \"name\": \"associated-cases\",\r\n \"id\": \"9563b290-ee40-11ed-8fcc-e975e7d47f63\"\r\n }\r\n ],\r\n \"namespaces\": [\r\n \"default\"\r\n ],\r\n \"migrationVersion\": {\r\n \"cases-comments\": \"8.6.0\"\r\n },\r\n \"coreMigrationVersion\": \"8.7.2\",\r\n \"updated_at\": \"2023-05-09T08:07:50.168Z\",\r\n \"created_at\": \"2023-05-09T08:07:50.168Z\"\r\n }\r\n ```\r\n3. Run Kibana with default and smaller migrations.batchSize\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"c79c09c3d0edeb31e2b1a9b8b6181fcb7bf9c587","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:skip","Feature:Migrations","backport:prev-minor","Epic:KBNA-7838","v8.9.0"],"number":153185,"url":"https://github.com/elastic/kibana/pull/153185","mergeCommit":{"message":"Make updateAndPickupMappings batch size configurable (#153185)\n\n## Summary\r\n\r\nUse migrations.batchSize config for the scroll_size in update_by_query /\r\nupdateAndPickupMappings. The default scroll_size=1000 can sometimes\r\ncause Elasticsearch to fail with `RecyclerBytesStreamOutput cannot hold\r\nmore than 2GB of data`\r\n\r\nOn CI our Elasticsearch cluster does not have enough memory to reproduce\r\n`RecyclerBytesStreamOutput` error it OOMs before it's able to load 2GB.\r\n\r\nHowever it's possible to test manually:\r\n1. Start Elasticsearch with 8GB heap `ES_JAVA_OPTS=' -Xms8g -Xmx8g' yarn\r\nes snapshot`\r\n2. Ingest > 2GB of saved objects distributed over batchSize documents (<\r\n1000)\r\n ```\r\ncurl -XPOST \"elastic:changeme@localhost:9200/_security/user/superuser\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"password\" : \"changeme\", \r\n \"roles\" : [ \"superuser\", \"grant_kibana_system_indices\" ]\r\n }'\r\n\r\ncurl -XPUT\r\n\"superuser:changeme@localhost:9200/.kibana_8.4.0_001/_mappings\" -H\r\n\"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n\"dynamic\": false,\r\n \"properties\": {\r\n\r\n }\r\n\r\n }'\r\n\r\n set -B # enable brace expansion\r\n for i in {1..500}; do\r\ncurl -k --data-binary \"@/Users/rudolf/dev/kibana/body.json\" -X PUT\r\n\"http://superuser:changeme@localhost:9200/.kibana_8.4.0_001/_doc/cases-comments:\"{$i}\"?&pretty=true\"\r\n-H \"Content-Type: application/json\"\r\n done\r\n\r\ncurl -XPOST \"superuser:changeme@localhost:9200/_aliases\" -H \"kbn-xsrf:\r\nreporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"actions\": [\r\n {\r\n \"add\": {\r\n \"index\": \".kibana_8.4.0_001\",\r\n \"alias\": \".kibana_8.4.0\"\r\n }\r\n },\r\n {\r\n \"add\": {\r\n \"index\": \".kibana_8.4.0_001\",\r\n \"alias\": \".kibana\"\r\n }\r\n }\r\n ]\r\n }'\r\n ```\r\n body.json\r\n ```\r\n {\r\n \"cases-comments\": {\r\n \"comment\": \"...put lots of data here...\",\r\n \"type\": \"user\",\r\n \"owner\": \"cases\",\r\n \"created_at\": \"2023-05-09T08:07:50.121Z\",\r\n \"created_by\": {\r\n \"email\": null,\r\n \"full_name\": null,\r\n \"username\": \"elastic\"\r\n },\r\n \"pushed_at\": null,\r\n \"pushed_by\": null,\r\n \"updated_at\": null,\r\n \"updated_by\": null\r\n },\r\n \"type\": \"cases-comments\",\r\n \"references\": [\r\n {\r\n \"type\": \"cases\",\r\n \"name\": \"associated-cases\",\r\n \"id\": \"9563b290-ee40-11ed-8fcc-e975e7d47f63\"\r\n }\r\n ],\r\n \"namespaces\": [\r\n \"default\"\r\n ],\r\n \"migrationVersion\": {\r\n \"cases-comments\": \"8.6.0\"\r\n },\r\n \"coreMigrationVersion\": \"8.7.2\",\r\n \"updated_at\": \"2023-05-09T08:07:50.168Z\",\r\n \"created_at\": \"2023-05-09T08:07:50.168Z\"\r\n }\r\n ```\r\n3. Run Kibana with default and smaller migrations.batchSize\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"c79c09c3d0edeb31e2b1a9b8b6181fcb7bf9c587"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/153185","number":153185,"mergeCommit":{"message":"Make updateAndPickupMappings batch size configurable (#153185)\n\n## Summary\r\n\r\nUse migrations.batchSize config for the scroll_size in update_by_query /\r\nupdateAndPickupMappings. The default scroll_size=1000 can sometimes\r\ncause Elasticsearch to fail with `RecyclerBytesStreamOutput cannot hold\r\nmore than 2GB of data`\r\n\r\nOn CI our Elasticsearch cluster does not have enough memory to reproduce\r\n`RecyclerBytesStreamOutput` error it OOMs before it's able to load 2GB.\r\n\r\nHowever it's possible to test manually:\r\n1. Start Elasticsearch with 8GB heap `ES_JAVA_OPTS=' -Xms8g -Xmx8g' yarn\r\nes snapshot`\r\n2. Ingest > 2GB of saved objects distributed over batchSize documents (<\r\n1000)\r\n ```\r\ncurl -XPOST \"elastic:changeme@localhost:9200/_security/user/superuser\"\r\n-H \"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"password\" : \"changeme\", \r\n \"roles\" : [ \"superuser\", \"grant_kibana_system_indices\" ]\r\n }'\r\n\r\ncurl -XPUT\r\n\"superuser:changeme@localhost:9200/.kibana_8.4.0_001/_mappings\" -H\r\n\"kbn-xsrf: reporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n\"dynamic\": false,\r\n \"properties\": {\r\n\r\n }\r\n\r\n }'\r\n\r\n set -B # enable brace expansion\r\n for i in {1..500}; do\r\ncurl -k --data-binary \"@/Users/rudolf/dev/kibana/body.json\" -X PUT\r\n\"http://superuser:changeme@localhost:9200/.kibana_8.4.0_001/_doc/cases-comments:\"{$i}\"?&pretty=true\"\r\n-H \"Content-Type: application/json\"\r\n done\r\n\r\ncurl -XPOST \"superuser:changeme@localhost:9200/_aliases\" -H \"kbn-xsrf:\r\nreporting\" -H \"Content-Type: application/json\" -d'\r\n {\r\n \"actions\": [\r\n {\r\n \"add\": {\r\n \"index\": \".kibana_8.4.0_001\",\r\n \"alias\": \".kibana_8.4.0\"\r\n }\r\n },\r\n {\r\n \"add\": {\r\n \"index\": \".kibana_8.4.0_001\",\r\n \"alias\": \".kibana\"\r\n }\r\n }\r\n ]\r\n }'\r\n ```\r\n body.json\r\n ```\r\n {\r\n \"cases-comments\": {\r\n \"comment\": \"...put lots of data here...\",\r\n \"type\": \"user\",\r\n \"owner\": \"cases\",\r\n \"created_at\": \"2023-05-09T08:07:50.121Z\",\r\n \"created_by\": {\r\n \"email\": null,\r\n \"full_name\": null,\r\n \"username\": \"elastic\"\r\n },\r\n \"pushed_at\": null,\r\n \"pushed_by\": null,\r\n \"updated_at\": null,\r\n \"updated_by\": null\r\n },\r\n \"type\": \"cases-comments\",\r\n \"references\": [\r\n {\r\n \"type\": \"cases\",\r\n \"name\": \"associated-cases\",\r\n \"id\": \"9563b290-ee40-11ed-8fcc-e975e7d47f63\"\r\n }\r\n ],\r\n \"namespaces\": [\r\n \"default\"\r\n ],\r\n \"migrationVersion\": {\r\n \"cases-comments\": \"8.6.0\"\r\n },\r\n \"coreMigrationVersion\": \"8.7.2\",\r\n \"updated_at\": \"2023-05-09T08:07:50.168Z\",\r\n \"created_at\": \"2023-05-09T08:07:50.168Z\"\r\n }\r\n ```\r\n3. Run Kibana with default and smaller migrations.batchSize\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"c79c09c3d0edeb31e2b1a9b8b6181fcb7bf9c587"}}]}] BACKPORT--> |
||
|
Gerard Soldevila
|
97b27d818c
|
[8.8] Add multi-instance tests for the .kibana split (#156756) (#158199)
# Backport This will backport the following commits from `main` to `8.8`: - [Add multi-instance tests for the .kibana split (#156756)](https://github.com/elastic/kibana/pull/156756) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-05-12T14:47:21Z","message":"Add multi-instance tests for the .kibana split (#156756)\n\nImprove _dot kibana split_ integration tests, take into account\nhttps://github.com/elastic/kibana/pull/157356 fix.","sha":"612064aa8baa4aa321cc3f08405e95c789c02016","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Team:Fleet","Feature:Migrations","backport:prev-minor","v8.8.0","v8.9.0","v8.8.1"],"number":156756,"url":"https://github.com/elastic/kibana/pull/156756","mergeCommit":{"message":"Add multi-instance tests for the .kibana split (#156756)\n\nImprove _dot kibana split_ integration tests, take into account\nhttps://github.com/elastic/kibana/pull/157356 fix.","sha":"612064aa8baa4aa321cc3f08405e95c789c02016"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156756","number":156756,"mergeCommit":{"message":"Add multi-instance tests for the .kibana split (#156756)\n\nImprove _dot kibana split_ integration tests, take into account\nhttps://github.com/elastic/kibana/pull/157356 fix.","sha":"612064aa8baa4aa321cc3f08405e95c789c02016"}}]}] BACKPORT--> |
||
|
Kibana Machine
|
670772197d
|
[8.8] Fixing User Profiles/Kibana.yml config light mode precedence logic (#158177) (#158210)
# Backport This will backport the following commits from `main` to `8.8`: - [Fixing User Profiles/Kibana.yml config light mode precedence logic (#158177)](https://github.com/elastic/kibana/pull/158177) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kurt","email":"kc13greiner@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-22T17:48:22Z","message":"Fixing User Profiles/Kibana.yml config light mode precedence logic (#158177)\n\n## Summary\r\n\r\nAfter changing the UserSettingService to calculate darkmode and return\r\n`boolean | undefined` , the Rendering service `darkMode` logic needed to\r\nbe updated to work when a User chooses 'Light' which provides a 'false'\r\nvalue to the Rendering service.\r\n\r\n## Testing\r\n\r\nFor Space Setting:\r\n\r\n1. Set Space Adv. Setting to darkMode: true\r\n2. Set User Profile Setting to 'Light'\r\n3. Observe that Light mode takes precedence\r\n\r\nFor Config setting:\r\n\r\n1. Set User Profile Setting to 'Dark'\r\n2. In `kibana.yml` set `uiSettings.overrides.theme:darkMode: false`\r\n3. Observe that Light mode takes precedence","sha":"613b2d5034fc703e1fb3c596e4ca2a648566b4c6","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Security","v8.9.0","v8.8.1"],"number":158177,"url":"https://github.com/elastic/kibana/pull/158177","mergeCommit":{"message":"Fixing User Profiles/Kibana.yml config light mode precedence logic (#158177)\n\n## Summary\r\n\r\nAfter changing the UserSettingService to calculate darkmode and return\r\n`boolean | undefined` , the Rendering service `darkMode` logic needed to\r\nbe updated to work when a User chooses 'Light' which provides a 'false'\r\nvalue to the Rendering service.\r\n\r\n## Testing\r\n\r\nFor Space Setting:\r\n\r\n1. Set Space Adv. Setting to darkMode: true\r\n2. Set User Profile Setting to 'Light'\r\n3. Observe that Light mode takes precedence\r\n\r\nFor Config setting:\r\n\r\n1. Set User Profile Setting to 'Dark'\r\n2. In `kibana.yml` set `uiSettings.overrides.theme:darkMode: false`\r\n3. Observe that Light mode takes precedence","sha":"613b2d5034fc703e1fb3c596e4ca2a648566b4c6"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158177","number":158177,"mergeCommit":{"message":"Fixing User Profiles/Kibana.yml config light mode precedence logic (#158177)\n\n## Summary\r\n\r\nAfter changing the UserSettingService to calculate darkmode and return\r\n`boolean | undefined` , the Rendering service `darkMode` logic needed to\r\nbe updated to work when a User chooses 'Light' which provides a 'false'\r\nvalue to the Rendering service.\r\n\r\n## Testing\r\n\r\nFor Space Setting:\r\n\r\n1. Set Space Adv. Setting to darkMode: true\r\n2. Set User Profile Setting to 'Light'\r\n3. Observe that Light mode takes precedence\r\n\r\nFor Config setting:\r\n\r\n1. Set User Profile Setting to 'Dark'\r\n2. In `kibana.yml` set `uiSettings.overrides.theme:darkMode: false`\r\n3. Observe that Light mode takes precedence","sha":"613b2d5034fc703e1fb3c596e4ca2a648566b4c6"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kurt <kc13greiner@users.noreply.github.com> |
||
|
Kibana Machine
|
acba2cd62c
|
[8.8] Hide error outputs from checking for git root (#157851) (#158161)
# Backport This will backport the following commits from `main` to `8.8`: - [Hide error outputs from checking for git root (#157851)](https://github.com/elastic/kibana/pull/157851) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2023-05-22T07:45:45Z","message":"Hide error outputs from checking for git root (#157851)\n\n## Summary\r\nAddresses #157341 \r\n\r\nThe error comes because STDERR by default is piped to the parent\r\nprocess's stderr.\r\n- Quench error output of git rev-parse\r\n\r\n### Checklist\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"8a081dc30857cc778646f541119bceee0c23064b","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v8.8.0","v8.9.0"],"number":157851,"url":"https://github.com/elastic/kibana/pull/157851","mergeCommit":{"message":"Hide error outputs from checking for git root (#157851)\n\n## Summary\r\nAddresses #157341 \r\n\r\nThe error comes because STDERR by default is piped to the parent\r\nprocess's stderr.\r\n- Quench error output of git rev-parse\r\n\r\n### Checklist\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"8a081dc30857cc778646f541119bceee0c23064b"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157851","number":157851,"mergeCommit":{"message":"Hide error outputs from checking for git root (#157851)\n\n## Summary\r\nAddresses #157341 \r\n\r\nThe error comes because STDERR by default is piped to the parent\r\nprocess's stderr.\r\n- Quench error output of git rev-parse\r\n\r\n### Checklist\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"8a081dc30857cc778646f541119bceee0c23064b"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <alex.szabo@elastic.co> |
||
|
Kibana Machine
|
a4c256b39f
|
[8.8] [DOCS] Maintenance windows (#157806) (#158019)
# Backport This will backport the following commits from `main` to `8.8`: - [[DOCS] Maintenance windows (#157806)](https://github.com/elastic/kibana/pull/157806) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-05-17T18:01:40Z","message":"[DOCS] Maintenance windows (#157806)","sha":"93b15b14e519c42877ce03472409ce7cc017e0b1","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","docs","backport:prev-minor","v8.8.0","v8.9.0"],"number":157806,"url":"https://github.com/elastic/kibana/pull/157806","mergeCommit":{"message":"[DOCS] Maintenance windows (#157806)","sha":"93b15b14e519c42877ce03472409ce7cc017e0b1"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157806","number":157806,"mergeCommit":{"message":"[DOCS] Maintenance windows (#157806)","sha":"93b15b14e519c42877ce03472409ce7cc017e0b1"}}]}] BACKPORT--> Co-authored-by: Lisa Cawley <lcawley@elastic.co> |
||
|
Kibana Machine
|
f8b1a48f22
|
[8.8] [Migrations] Systematically wait for newly created indices to turn green (#157973) (#157993)
# Backport This will backport the following commits from `main` to `8.8`: - [[Migrations] Systematically wait for newly created indices to turn green (#157973)](https://github.com/elastic/kibana/pull/157973) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-05-17T13:34:51Z","message":"[Migrations] Systematically wait for newly created indices to turn green (#157973)\n\nTackles https://github.com/elastic/kibana/issues/157968\r\n\r\nWhen creating new indices during SO migrations, we used to rely on the\r\n`res.acknowledged && res.shardsAcknowledged` of the\r\n`esClient.indices.create(...)` to determine that the indices are ready\r\nto use.\r\n\r\nHowever, we believe that due to certain race conditions, this can cause\r\nKibana migrations to fail (refer to the [related\r\nissue](https://github.com/elastic/kibana/issues/157968)).\r\n\r\nThis PR aims at fixing recent CI failures by adding a systematic\r\n`waitForIndexStatus` after creating an index.","sha":"71125b192e86ddc3d6747c5b14b92e669eba360f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Core","release_note:skip","Feature:Migrations","backport:prev-minor","v8.8.0","v8.9.0","v8.8.1"],"number":157973,"url":"https://github.com/elastic/kibana/pull/157973","mergeCommit":{"message":"[Migrations] Systematically wait for newly created indices to turn green (#157973)\n\nTackles https://github.com/elastic/kibana/issues/157968\r\n\r\nWhen creating new indices during SO migrations, we used to rely on the\r\n`res.acknowledged && res.shardsAcknowledged` of the\r\n`esClient.indices.create(...)` to determine that the indices are ready\r\nto use.\r\n\r\nHowever, we believe that due to certain race conditions, this can cause\r\nKibana migrations to fail (refer to the [related\r\nissue](https://github.com/elastic/kibana/issues/157968)).\r\n\r\nThis PR aims at fixing recent CI failures by adding a systematic\r\n`waitForIndexStatus` after creating an index.","sha":"71125b192e86ddc3d6747c5b14b92e669eba360f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157973","number":157973,"mergeCommit":{"message":"[Migrations] Systematically wait for newly created indices to turn green (#157973)\n\nTackles https://github.com/elastic/kibana/issues/157968\r\n\r\nWhen creating new indices during SO migrations, we used to rely on the\r\n`res.acknowledged && res.shardsAcknowledged` of the\r\n`esClient.indices.create(...)` to determine that the indices are ready\r\nto use.\r\n\r\nHowever, we believe that due to certain race conditions, this can cause\r\nKibana migrations to fail (refer to the [related\r\nissue](https://github.com/elastic/kibana/issues/157968)).\r\n\r\nThis PR aims at fixing recent CI failures by adding a systematic\r\n`waitForIndexStatus` after creating an index.","sha":"71125b192e86ddc3d6747c5b14b92e669eba360f"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co> |
||
|
Kibana Machine
|
ba9b182a34
|
[8.8] [Security Solution] Fix grouping rows per page bug (#157807) (#157884)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Fix grouping rows per page bug (#157807)](https://github.com/elastic/kibana/pull/157807) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2023-05-16T14:15:23Z","message":"[Security Solution] Fix grouping rows per page bug (#157807)","sha":"8181597cc9f422b38341761b308db6b3176614bf","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","v8.8.0","v8.9.0"],"number":157807,"url":"https://github.com/elastic/kibana/pull/157807","mergeCommit":{"message":"[Security Solution] Fix grouping rows per page bug (#157807)","sha":"8181597cc9f422b38341761b308db6b3176614bf"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157807","number":157807,"mergeCommit":{"message":"[Security Solution] Fix grouping rows per page bug (#157807)","sha":"8181597cc9f422b38341761b308db6b3176614bf"}}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> |
||
Steph Milovic
|
263945cdc0
|
[8.8] [Security solution] Fix grouping query, be ready for arrays! (#157330) (#157754)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security solution] Fix grouping query, be ready for arrays! (#157330)](https://github.com/elastic/kibana/pull/157330) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2023-05-11T23:03:16Z","message":"[Security solution] Fix grouping query, be ready for arrays! (#157330)","sha":"4371c157b0bd7a084836d5c9928bf1752f2c9d52","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","v8.8.0","Feature:Alerts Grouping","v8.9.0"],"number":157330,"url":"https://github.com/elastic/kibana/pull/157330","mergeCommit":{"message":"[Security solution] Fix grouping query, be ready for arrays! (#157330)","sha":"4371c157b0bd7a084836d5c9928bf1752f2c9d52"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157330","number":157330,"mergeCommit":{"message":"[Security solution] Fix grouping query, be ready for arrays! (#157330)","sha":"4371c157b0bd7a084836d5c9928bf1752f2c9d52"}}]}] BACKPORT--> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> |
||
|
Kibana Machine
|
4c2b4a091f
|
[8.8] feat(slo): simplify calendar aligned time window (#157759) (#157789)
# Backport This will backport the following commits from `main` to `8.8`: - [feat(slo): simplify calendar aligned time window (#157759)](https://github.com/elastic/kibana/pull/157759) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2023-05-15T18:59:36Z","message":"feat(slo): simplify calendar aligned time window (#157759)","sha":"e5f4dca5557a9d25acfd2ec2632aa3f35cd3732e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: Actionable Observability","backport:prev-minor","v8.9.0"],"number":157759,"url":"https://github.com/elastic/kibana/pull/157759","mergeCommit":{"message":"feat(slo): simplify calendar aligned time window (#157759)","sha":"e5f4dca5557a9d25acfd2ec2632aa3f35cd3732e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157759","number":157759,"mergeCommit":{"message":"feat(slo): simplify calendar aligned time window (#157759)","sha":"e5f4dca5557a9d25acfd2ec2632aa3f35cd3732e"}}]}] BACKPORT--> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co> |
||
|
Kibana Machine
|
7a623a822f
|
[8.8] fix console errors in inspector (#156894) (#157748)
# Backport This will backport the following commits from `main` to `8.8`: - [fix console errors in inspector (#156894)](https://github.com/elastic/kibana/pull/156894) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-05-15T15:02:27Z","message":"fix console errors in inspector (#156894)\n\nSteps to view problem\r\n* install sample data set\r\n* Open lens visualization\r\n* Open inspector. Notice console errors\r\n<img width=\"300\" alt=\"Screen Shot 2023-05-05 at 11 03 25 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/236521366-d8fb9302-e93b-4047-a0bf-d7c09dcc3ffb.png\">\r\n\r\nhttps://github.com/elastic/eui/pull/6566 removed `closeButtonAriaLabel`\r\nprop from [EuiFlyout](https://elastic.github.io/eui/#/layout/flyout) EUI\r\n75.0.0 (Effecting 8.8 and 8.9). FlyoutService spreads options into\r\n`EuiFlyout`, resulting in `closeButtonAriaLabel` getting added to dom\r\nand causing error.\r\n\r\n`OverlayFlyoutOpenOptions` type added by\r\nhttps://github.com/elastic/kibana/issues/37894. I replaced\r\n`OverlayFlyoutOpenOptions` with `EuiFlyoutProps` to make it more clear\r\nwhat props are accepted and provide stronger typing that stays in sync\r\nwith EUI typings\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b803ba9d7b69250d8bfb0567919128f954c1e935","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Inspector","Team:Presentation","release_note:skip","v8.8.0","v8.9.0"],"number":156894,"url":"https://github.com/elastic/kibana/pull/156894","mergeCommit":{"message":"fix console errors in inspector (#156894)\n\nSteps to view problem\r\n* install sample data set\r\n* Open lens visualization\r\n* Open inspector. Notice console errors\r\n<img width=\"300\" alt=\"Screen Shot 2023-05-05 at 11 03 25 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/236521366-d8fb9302-e93b-4047-a0bf-d7c09dcc3ffb.png\">\r\n\r\nhttps://github.com/elastic/eui/pull/6566 removed `closeButtonAriaLabel`\r\nprop from [EuiFlyout](https://elastic.github.io/eui/#/layout/flyout) EUI\r\n75.0.0 (Effecting 8.8 and 8.9). FlyoutService spreads options into\r\n`EuiFlyout`, resulting in `closeButtonAriaLabel` getting added to dom\r\nand causing error.\r\n\r\n`OverlayFlyoutOpenOptions` type added by\r\nhttps://github.com/elastic/kibana/issues/37894. I replaced\r\n`OverlayFlyoutOpenOptions` with `EuiFlyoutProps` to make it more clear\r\nwhat props are accepted and provide stronger typing that stays in sync\r\nwith EUI typings\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b803ba9d7b69250d8bfb0567919128f954c1e935"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156894","number":156894,"mergeCommit":{"message":"fix console errors in inspector (#156894)\n\nSteps to view problem\r\n* install sample data set\r\n* Open lens visualization\r\n* Open inspector. Notice console errors\r\n<img width=\"300\" alt=\"Screen Shot 2023-05-05 at 11 03 25 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/236521366-d8fb9302-e93b-4047-a0bf-d7c09dcc3ffb.png\">\r\n\r\nhttps://github.com/elastic/eui/pull/6566 removed `closeButtonAriaLabel`\r\nprop from [EuiFlyout](https://elastic.github.io/eui/#/layout/flyout) EUI\r\n75.0.0 (Effecting 8.8 and 8.9). FlyoutService spreads options into\r\n`EuiFlyout`, resulting in `closeButtonAriaLabel` getting added to dom\r\nand causing error.\r\n\r\n`OverlayFlyoutOpenOptions` type added by\r\nhttps://github.com/elastic/kibana/issues/37894. I replaced\r\n`OverlayFlyoutOpenOptions` with `EuiFlyoutProps` to make it more clear\r\nwhat props are accepted and provide stronger typing that stays in sync\r\nwith EUI typings\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"b803ba9d7b69250d8bfb0567919128f954c1e935"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co> |
||
Efe Gürkan YALAMAN
|
ecb9826cee
|
[8.8] [Enterprise Search] Text context improvements for the new index pages (#157290) (#157709)
# Backport This will backport the following commits from `main` to `8.8`: - [[Enterprise Search] Text context improvements for the new index pages (#157290)](https://github.com/elastic/kibana/pull/157290) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Efe Gürkan YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2023-05-12T15:33:54Z","message":"[Enterprise Search] Text context improvements for the new index pages (#157290)\n\n## Summary\r\n\r\nChange text to increase the context exposure on new index pages and also\r\nreflect beta/native connector changes.\r\n\r\n\r\nAdds a callout to Beta connectors, both on index configuration and index\r\noverview.\r\nChanged PostgreSQL label to match their branding.\r\nAdds a native badge which is visible only when native connectors\r\navailable.\r\n\r\n\r\n\r\n |
||
|
Kibana Machine
|
e33c36266b
|
[8.8] [Security solution] Grouping, Remove beta label (#157015) (#157067)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security solution] Grouping, Remove beta label (#157015)](https://github.com/elastic/kibana/pull/157015) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T20:24:44Z","message":"[Security solution] Grouping, Remove beta label (#157015)","sha":"524a64b642a26de29aed12cf0444194b23db9d85","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","ci:cloud-deploy","v8.8.0","v8.9.0"],"number":157015,"url":"https://github.com/elastic/kibana/pull/157015","mergeCommit":{"message":"[Security solution] Grouping, Remove beta label (#157015)","sha":"524a64b642a26de29aed12cf0444194b23db9d85"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157015","number":157015,"mergeCommit":{"message":"[Security solution] Grouping, Remove beta label (#157015)","sha":"524a64b642a26de29aed12cf0444194b23db9d85"}}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> |
||
|
Kibana Machine
|
661dee06eb
|
[8.8] Removed unused method searchForOutdatedDocuments (#157470) (#157708)
# Backport This will backport the following commits from `main` to `8.8`: - [Removed unused method searchForOutdatedDocuments (#157470)](https://github.com/elastic/kibana/pull/157470) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-05-15T12:14:32Z","message":"Removed unused method searchForOutdatedDocuments (#157470)\n\nThis method is no longer used (replaced by `readWithPit`).\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4951e29973b4125d1b8d6ecb0b1afd9e9095c048","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","technical debt","release_note:skip","Feature:Migrations","backport:prev-minor","v8.8.0","v8.9.0","v8.8.1"],"number":157470,"url":"https://github.com/elastic/kibana/pull/157470","mergeCommit":{"message":"Removed unused method searchForOutdatedDocuments (#157470)\n\nThis method is no longer used (replaced by `readWithPit`).\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4951e29973b4125d1b8d6ecb0b1afd9e9095c048"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157470","number":157470,"mergeCommit":{"message":"Removed unused method searchForOutdatedDocuments (#157470)\n\nThis method is no longer used (replaced by `readWithPit`).\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"4951e29973b4125d1b8d6ecb0b1afd9e9095c048"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co> |
||
|
Kibana Machine
|
e5132c79d4
|
[8.8] fix(slo): remove good status codes from apm availability (#157497) (#157504)
# Backport This will backport the following commits from `main` to `8.8`: - [fix(slo): remove good status codes from apm availability (#157497)](https://github.com/elastic/kibana/pull/157497) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2023-05-12T15:11:39Z","message":"fix(slo): remove good status codes from apm availability (#157497)","sha":"65a6f7435b13caf730721e61b12c4b735c11d7bd","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: Actionable Observability","backport:prev-minor","v8.9.0"],"number":157497,"url":"https://github.com/elastic/kibana/pull/157497","mergeCommit":{"message":"fix(slo): remove good status codes from apm availability (#157497)","sha":"65a6f7435b13caf730721e61b12c4b735c11d7bd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157497","number":157497,"mergeCommit":{"message":"fix(slo): remove good status codes from apm availability (#157497)","sha":"65a6f7435b13caf730721e61b12c4b735c11d7bd"}}]}] BACKPORT--> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co> |
||
|
Kibana Machine
|
f6ac3f4ca3
|
[8.8] Fix the charts and group by section on the Log Threshold alert detail page (#155327) (#157410)
# Backport This will backport the following commits from `main` to `8.8`: - [Fix the charts and group by section on the Log Threshold alert detail page (#155327)](https://github.com/elastic/kibana/pull/155327) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Chris Cowan","email":"chris@elastic.co"},"sourceCommit":{"committedDate":"2023-05-11T15:54:35Z","message":"Fix the charts and group by section on the Log Threshold alert detail page (#155327)\n\n## Summary\r\n\r\nThis PR fixes #155083 with the following changes:\r\n\r\n- Create a new field to store the action context for an alert under\r\n`ALERT_CONTEXT` (`kibana.alert.context`) for Log Threshold Rule.\r\n- Change the alert detail page to reference the `groupByKeys` under\r\n`ALERT_CONTEXT` for the group by section\r\n- Change the history chart to only display `12h` buckets\r\n\r\nI plan to do a follow up PR to add the ALERT_CONTEXT to the other\r\nObservability Rules which we will also need for our alert details pages.\r\n\r\n### How to test\r\n\r\n1. Index data using:\r\nhttps://github.com/elastic/high-cardinality-cluster/tree/main/high_cardinality_indexer\r\nby running the following command:\r\n```\r\nDATASET=\"fake_stack\" EVENTS_PER_CYCLE=1 INDEX_INTERVAL=60000 ELASTICSEARCH_HOSTS=http://localhost:9200 node src/run.js\r\n```\r\n2. Create a DataView for named \"Admin Console\" with the index pattern of\r\n`high-cardinality-data-fake_stack.admin-console-*` and the timestamp\r\nfield set to `@timestamp`\r\n3. Go to the Log Stream in Observability and change the index pattern to\r\n\"Admin Console\"\r\n4. Create a rule that looks like:\r\n\r\n<img width=\"600\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/41702/232578891-e65a3f1a-457c-459a-8d7f-cadc85e7067c.png\">\r\n\r\n5. Create a rule WITHOUT a group by that will trigger and check the\r\nalert detail page\r\n6. Create a rule with a ratio WITHOUT a group by that will trigger and\r\ncheck the alert detail page\r\n7. Create a rule with a ratio WITH a group by that will trigger and\r\ncheck the alert detail page\r\n\r\n---------\r\n\r\nCo-authored-by: Kevin Delemme <kdelemme@gmail.com>\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"78671f113cc68f5e1696bbe4aed2320978c97e11","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: Actionable Observability","v8.8.0","v8.9.0"],"number":155327,"url":"https://github.com/elastic/kibana/pull/155327","mergeCommit":{"message":"Fix the charts and group by section on the Log Threshold alert detail page (#155327)\n\n## Summary\r\n\r\nThis PR fixes #155083 with the following changes:\r\n\r\n- Create a new field to store the action context for an alert under\r\n`ALERT_CONTEXT` (`kibana.alert.context`) for Log Threshold Rule.\r\n- Change the alert detail page to reference the `groupByKeys` under\r\n`ALERT_CONTEXT` for the group by section\r\n- Change the history chart to only display `12h` buckets\r\n\r\nI plan to do a follow up PR to add the ALERT_CONTEXT to the other\r\nObservability Rules which we will also need for our alert details pages.\r\n\r\n### How to test\r\n\r\n1. Index data using:\r\nhttps://github.com/elastic/high-cardinality-cluster/tree/main/high_cardinality_indexer\r\nby running the following command:\r\n```\r\nDATASET=\"fake_stack\" EVENTS_PER_CYCLE=1 INDEX_INTERVAL=60000 ELASTICSEARCH_HOSTS=http://localhost:9200 node src/run.js\r\n```\r\n2. Create a DataView for named \"Admin Console\" with the index pattern of\r\n`high-cardinality-data-fake_stack.admin-console-*` and the timestamp\r\nfield set to `@timestamp`\r\n3. Go to the Log Stream in Observability and change the index pattern to\r\n\"Admin Console\"\r\n4. Create a rule that looks like:\r\n\r\n<img width=\"600\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/41702/232578891-e65a3f1a-457c-459a-8d7f-cadc85e7067c.png\">\r\n\r\n5. Create a rule WITHOUT a group by that will trigger and check the\r\nalert detail page\r\n6. Create a rule with a ratio WITHOUT a group by that will trigger and\r\ncheck the alert detail page\r\n7. Create a rule with a ratio WITH a group by that will trigger and\r\ncheck the alert detail page\r\n\r\n---------\r\n\r\nCo-authored-by: Kevin Delemme <kdelemme@gmail.com>\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"78671f113cc68f5e1696bbe4aed2320978c97e11"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155327","number":155327,"mergeCommit":{"message":"Fix the charts and group by section on the Log Threshold alert detail page (#155327)\n\n## Summary\r\n\r\nThis PR fixes #155083 with the following changes:\r\n\r\n- Create a new field to store the action context for an alert under\r\n`ALERT_CONTEXT` (`kibana.alert.context`) for Log Threshold Rule.\r\n- Change the alert detail page to reference the `groupByKeys` under\r\n`ALERT_CONTEXT` for the group by section\r\n- Change the history chart to only display `12h` buckets\r\n\r\nI plan to do a follow up PR to add the ALERT_CONTEXT to the other\r\nObservability Rules which we will also need for our alert details pages.\r\n\r\n### How to test\r\n\r\n1. Index data using:\r\nhttps://github.com/elastic/high-cardinality-cluster/tree/main/high_cardinality_indexer\r\nby running the following command:\r\n```\r\nDATASET=\"fake_stack\" EVENTS_PER_CYCLE=1 INDEX_INTERVAL=60000 ELASTICSEARCH_HOSTS=http://localhost:9200 node src/run.js\r\n```\r\n2. Create a DataView for named \"Admin Console\" with the index pattern of\r\n`high-cardinality-data-fake_stack.admin-console-*` and the timestamp\r\nfield set to `@timestamp`\r\n3. Go to the Log Stream in Observability and change the index pattern to\r\n\"Admin Console\"\r\n4. Create a rule that looks like:\r\n\r\n<img width=\"600\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/41702/232578891-e65a3f1a-457c-459a-8d7f-cadc85e7067c.png\">\r\n\r\n5. Create a rule WITHOUT a group by that will trigger and check the\r\nalert detail page\r\n6. Create a rule with a ratio WITHOUT a group by that will trigger and\r\ncheck the alert detail page\r\n7. Create a rule with a ratio WITH a group by that will trigger and\r\ncheck the alert detail page\r\n\r\n---------\r\n\r\nCo-authored-by: Kevin Delemme <kdelemme@gmail.com>\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"78671f113cc68f5e1696bbe4aed2320978c97e11"}}]}] BACKPORT--> Co-authored-by: Chris Cowan <chris@elastic.co> |
||
|
Kibana Machine
|
cc73a0c026
|
[8.8] [Enterprise Search][Behavioral Analytics] Add cors link to behavioral analytics (#157267) (#157379)
# Backport This will backport the following commits from `main` to `8.8`: - [[Enterprise Search][Behavioral Analytics] Add cors link to behavioral analytics (#157267)](https://github.com/elastic/kibana/pull/157267) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yan Savitski","email":"yan.savitski@elastic.co"},"sourceCommit":{"committedDate":"2023-05-11T12:02:11Z","message":"[Enterprise Search][Behavioral Analytics] Add cors link to behavioral analytics (#157267)\n\nUpdated the link to point to the following page:\r\n\r\nhttps://www.elastic.co/guide/en/enterprise-search/master/analytics-cors-proxy.html\r\n\r\n<img width=\"1637\" alt=\"image\"\r\nsrc=\" |
||
|
Kibana Machine
|
95ec5915d8
|
[8.8] [Enterprise Search] Add Jira, Confluence, Sharepoint connectors (#157167) (#157259)
# Backport This will backport the following commits from `main` to `8.8`: - [[Enterprise Search] Add Jira, Confluence, Sharepoint connectors (#157167)](https://github.com/elastic/kibana/pull/157167) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"94373878+sphilipse@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-10T12:07:43Z","message":"[Enterprise Search] Add Jira, Confluence, Sharepoint connectors (#157167)\n\n## Summary\r\n\r\nThis adds Jira, Confluence and Sharepoint connectors to Enterprise\r\nSearch.","sha":"e6fdc8ba45dc8a7204bf28d64b97917535e1dd1f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":157167,"url":"https://github.com/elastic/kibana/pull/157167","mergeCommit":{"message":"[Enterprise Search] Add Jira, Confluence, Sharepoint connectors (#157167)\n\n## Summary\r\n\r\nThis adds Jira, Confluence and Sharepoint connectors to Enterprise\r\nSearch.","sha":"e6fdc8ba45dc8a7204bf28d64b97917535e1dd1f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157167","number":157167,"mergeCommit":{"message":"[Enterprise Search] Add Jira, Confluence, Sharepoint connectors (#157167)\n\n## Summary\r\n\r\nThis adds Jira, Confluence and Sharepoint connectors to Enterprise\r\nSearch.","sha":"e6fdc8ba45dc8a7204bf28d64b97917535e1dd1f"}}]}] BACKPORT--> Co-authored-by: Sander Philipse <94373878+sphilipse@users.noreply.github.com> |
||
|
Kibana Machine
|
951802a7a9
|
[8.8] [Security Solution][Alerts] resolves alerts suppression review feedback (#155839) (#157192)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution][Alerts] resolves alerts suppression review feedback (#155839)](https://github.com/elastic/kibana/pull/155839) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Vitalii Dmyterko","email":"92328789+vitaliidm@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-09T16:12:20Z","message":"[Security Solution][Alerts] resolves alerts suppression review feedback (#155839)\n\n## Summary\r\n\r\n- addresses review feedback on\r\nhttps://github.com/elastic/kibana/pull/155055\r\n- addresses UI changes from\r\nhttps://github.com/elastic/kibana/issues/150101\r\n - removes accordion in favour of intended suppression components\r\n - adds popover with a link to documentation\r\n - changes wording\r\n- addresses https://github.com/elastic/kibana/issues/156247\r\n\r\n### Before\r\n<img width=\"1017\" alt=\"Screenshot 2023-04-24 at 19 44 33\"\r\nsrc=\"https://user-images.githubusercontent.com/92328789/234824612-b0ed2870-8aa0-44af-a37d-c061358c54a3.png\">\r\n\r\n### After\r\n\r\n#### Intended Fields\r\n<img width=\"1016\" alt=\"Screenshot 2023-05-05 at 10 42 46\"\r\nsrc=\"https://user-images.githubusercontent.com/92328789/236426053-279d2f5b-46ea-434b-9cfa-696c71321661.png\">\r\n\r\n#### Tooltip\r\n<img width=\"1016\" alt=\"Screenshot 2023-05-05 at 10 43 41\"\r\nsrc=\"https://user-images.githubusercontent.com/92328789/236426061-1c39a5c2-63ca-4a36-b15e-2a1c1943481d.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Garrett Spong <spong@users.noreply.github.com>","sha":"31b6062148b55f712015fc9061172eca54c0acd4","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","Team:Detection Alerts","backport:prev-minor","v8.8.0","v8.9.0"],"number":155839,"url":"https://github.com/elastic/kibana/pull/155839","mergeCommit":{"message":"[Security Solution][Alerts] resolves alerts suppression review feedback (#155839)\n\n## Summary\r\n\r\n- addresses review feedback on\r\nhttps://github.com/elastic/kibana/pull/155055\r\n- addresses UI changes from\r\nhttps://github.com/elastic/kibana/issues/150101\r\n - removes accordion in favour of intended suppression components\r\n - adds popover with a link to documentation\r\n - changes wording\r\n- addresses https://github.com/elastic/kibana/issues/156247\r\n\r\n### Before\r\n<img width=\"1017\" alt=\"Screenshot 2023-04-24 at 19 44 33\"\r\nsrc=\"https://user-images.githubusercontent.com/92328789/234824612-b0ed2870-8aa0-44af-a37d-c061358c54a3.png\">\r\n\r\n### After\r\n\r\n#### Intended Fields\r\n<img width=\"1016\" alt=\"Screenshot 2023-05-05 at 10 42 46\"\r\nsrc=\"https://user-images.githubusercontent.com/92328789/236426053-279d2f5b-46ea-434b-9cfa-696c71321661.png\">\r\n\r\n#### Tooltip\r\n<img width=\"1016\" alt=\"Screenshot 2023-05-05 at 10 43 41\"\r\nsrc=\"https://user-images.githubusercontent.com/92328789/236426061-1c39a5c2-63ca-4a36-b15e-2a1c1943481d.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Garrett Spong <spong@users.noreply.github.com>","sha":"31b6062148b55f712015fc9061172eca54c0acd4"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155839","number":155839,"mergeCommit":{"message":"[Security Solution][Alerts] resolves alerts suppression review feedback (#155839)\n\n## Summary\r\n\r\n- addresses review feedback on\r\nhttps://github.com/elastic/kibana/pull/155055\r\n- addresses UI changes from\r\nhttps://github.com/elastic/kibana/issues/150101\r\n - removes accordion in favour of intended suppression components\r\n - adds popover with a link to documentation\r\n - changes wording\r\n- addresses https://github.com/elastic/kibana/issues/156247\r\n\r\n### Before\r\n<img width=\"1017\" alt=\"Screenshot 2023-04-24 at 19 44 33\"\r\nsrc=\"https://user-images.githubusercontent.com/92328789/234824612-b0ed2870-8aa0-44af-a37d-c061358c54a3.png\">\r\n\r\n### After\r\n\r\n#### Intended Fields\r\n<img width=\"1016\" alt=\"Screenshot 2023-05-05 at 10 42 46\"\r\nsrc=\"https://user-images.githubusercontent.com/92328789/236426053-279d2f5b-46ea-434b-9cfa-696c71321661.png\">\r\n\r\n#### Tooltip\r\n<img width=\"1016\" alt=\"Screenshot 2023-05-05 at 10 43 41\"\r\nsrc=\"https://user-images.githubusercontent.com/92328789/236426061-1c39a5c2-63ca-4a36-b15e-2a1c1943481d.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Garrett Spong <spong@users.noreply.github.com>","sha":"31b6062148b55f712015fc9061172eca54c0acd4"}}]}] BACKPORT--> Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com> Co-authored-by: Pedro Jaramillo <pedro.jaramillo@elastic.co> |
||
|
Kibana Machine
|
d2e646db5a
|
[8.8] [Search Application] Fix documentation links (#157145) (#157202)
# Backport This will backport the following commits from `main` to `8.8`: - [[Search Application] Fix documentation links (#157145)](https://github.com/elastic/kibana/pull/157145) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yan Savitski","email":"yan.savitski@elastic.co"},"sourceCommit":{"committedDate":"2023-05-09T17:34:01Z","message":"[Search Application] Fix documentation links (#157145)\n\nUpdate links to documentation\r\n- ✔️ Search Application(s) documentation links from main page\r\n- ✔️ Search Preview page \"Improve your results\"","sha":"8e0fe1c608d5bfc53481f2a7fe1f4e9e21cfe5b5","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":157145,"url":"https://github.com/elastic/kibana/pull/157145","mergeCommit":{"message":"[Search Application] Fix documentation links (#157145)\n\nUpdate links to documentation\r\n- ✔️ Search Application(s) documentation links from main page\r\n- ✔️ Search Preview page \"Improve your results\"","sha":"8e0fe1c608d5bfc53481f2a7fe1f4e9e21cfe5b5"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157145","number":157145,"mergeCommit":{"message":"[Search Application] Fix documentation links (#157145)\n\nUpdate links to documentation\r\n- ✔️ Search Application(s) documentation links from main page\r\n- ✔️ Search Preview page \"Improve your results\"","sha":"8e0fe1c608d5bfc53481f2a7fe1f4e9e21cfe5b5"}}]}] BACKPORT--> Co-authored-by: Yan Savitski <yan.savitski@elastic.co> |
||
|
Kibana Machine
|
1401b1a2b8
|
[8.8] [RAM] Add link and add validations (#157028) (#157134)
# Backport This will backport the following commits from `main` to `8.8`: - [[RAM] Add link and add validations (#157028)](https://github.com/elastic/kibana/pull/157028) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia","email":"iuliia.guskova@elastic.co"},"sourceCommit":{"committedDate":"2023-05-09T07:07:36Z","message":"[RAM] Add link and add validations (#157028)\n\nIn this PR:\r\n1. I add a link to Slack Web API docs in UI\r\n2. Add some limitations to parameters schema for Slack Web API\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Lisa Cawley <lcawley@elastic.co>","sha":"12162a0b3f85f5594e8f54ca9c14d014e926720d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport:prev-minor","v8.9.0"],"number":157028,"url":"https://github.com/elastic/kibana/pull/157028","mergeCommit":{"message":"[RAM] Add link and add validations (#157028)\n\nIn this PR:\r\n1. I add a link to Slack Web API docs in UI\r\n2. Add some limitations to parameters schema for Slack Web API\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Lisa Cawley <lcawley@elastic.co>","sha":"12162a0b3f85f5594e8f54ca9c14d014e926720d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157028","number":157028,"mergeCommit":{"message":"[RAM] Add link and add validations (#157028)\n\nIn this PR:\r\n1. I add a link to Slack Web API docs in UI\r\n2. Add some limitations to parameters schema for Slack Web API\r\nconnector.\r\n\r\n---------\r\n\r\nCo-authored-by: Lisa Cawley <lcawley@elastic.co>","sha":"12162a0b3f85f5594e8f54ca9c14d014e926720d"}}]}] BACKPORT--> Co-authored-by: Julia <iuliia.guskova@elastic.co> |
||
|
Kibana Machine
|
b014e8155a
|
[8.8] [performance] enable journey run against cloud deployments (#156720) (#157123)
# Backport This will backport the following commits from `main` to `8.8`: - [[performance] enable journey run against cloud deployments (#156720)](https://github.com/elastic/kibana/pull/156720) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-05-09T03:35:43Z","message":"[performance] enable journey run against cloud deployments (#156720)\n\n## Summary\r\n\r\nThis PR adds changes and instructions how to run existing performance\r\njourneys against ESS instances.\r\n\r\nAs previously discussed with @pheyos , there are few manual steps to be\r\ndone before running the actual journey:\r\n1. Create cloud deployment and re-configure it the way APM traces are\r\nreported the monitoring cluster\r\n2. Check out the branch matching deployment version (main ->\r\n8.9.0-SNAPSHOT), create user with `superuser` role (we don't test\r\nfunctional features, only performance metrics)\r\n\r\nThen you can run the journey like a regular cloud test suite:\r\n```\r\nexport TEST_KIBANA_URL=https://<username>:<password>@<kibana_url>\r\nexport TEST_ES_URL=https://<username>:<password>@j<elasticsearch_url>:<port>\r\nexport TEST_CLOUD=1\r\nnode scripts/functional_test_runner.js --config x-pack/performance/journeys/$YOUR_JOURNEY_NAME.ts\r\n```\r\n\r\n<img width=\"1357\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/236499836-2738fecb-a5a9-4e58-a10b-915b962af037.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: Jon <jon@budzenski.me>","sha":"e55a92eab0ae28799b51238fb76efa6026673e6e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","wg:performance","v8.7.2","v8.9.0","v8.8.1"],"number":156720,"url":"https://github.com/elastic/kibana/pull/156720","mergeCommit":{"message":"[performance] enable journey run against cloud deployments (#156720)\n\n## Summary\r\n\r\nThis PR adds changes and instructions how to run existing performance\r\njourneys against ESS instances.\r\n\r\nAs previously discussed with @pheyos , there are few manual steps to be\r\ndone before running the actual journey:\r\n1. Create cloud deployment and re-configure it the way APM traces are\r\nreported the monitoring cluster\r\n2. Check out the branch matching deployment version (main ->\r\n8.9.0-SNAPSHOT), create user with `superuser` role (we don't test\r\nfunctional features, only performance metrics)\r\n\r\nThen you can run the journey like a regular cloud test suite:\r\n```\r\nexport TEST_KIBANA_URL=https://<username>:<password>@<kibana_url>\r\nexport TEST_ES_URL=https://<username>:<password>@j<elasticsearch_url>:<port>\r\nexport TEST_CLOUD=1\r\nnode scripts/functional_test_runner.js --config x-pack/performance/journeys/$YOUR_JOURNEY_NAME.ts\r\n```\r\n\r\n<img width=\"1357\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/236499836-2738fecb-a5a9-4e58-a10b-915b962af037.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: Jon <jon@budzenski.me>","sha":"e55a92eab0ae28799b51238fb76efa6026673e6e"}},"sourceBranch":"main","suggestedTargetBranches":["8.7","8.8"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156720","number":156720,"mergeCommit":{"message":"[performance] enable journey run against cloud deployments (#156720)\n\n## Summary\r\n\r\nThis PR adds changes and instructions how to run existing performance\r\njourneys against ESS instances.\r\n\r\nAs previously discussed with @pheyos , there are few manual steps to be\r\ndone before running the actual journey:\r\n1. Create cloud deployment and re-configure it the way APM traces are\r\nreported the monitoring cluster\r\n2. Check out the branch matching deployment version (main ->\r\n8.9.0-SNAPSHOT), create user with `superuser` role (we don't test\r\nfunctional features, only performance metrics)\r\n\r\nThen you can run the journey like a regular cloud test suite:\r\n```\r\nexport TEST_KIBANA_URL=https://<username>:<password>@<kibana_url>\r\nexport TEST_ES_URL=https://<username>:<password>@j<elasticsearch_url>:<port>\r\nexport TEST_CLOUD=1\r\nnode scripts/functional_test_runner.js --config x-pack/performance/journeys/$YOUR_JOURNEY_NAME.ts\r\n```\r\n\r\n<img width=\"1357\" alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/10977896/236499836-2738fecb-a5a9-4e58-a10b-915b962af037.png\">\r\n\r\n---------\r\n\r\nCo-authored-by: Jon <jon@budzenski.me>","sha":"e55a92eab0ae28799b51238fb76efa6026673e6e"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co> |
||
|
Kibana Machine
|
3c53e3e42c
|
[8.8] [Synthetics] Show data retention privileges prompt (#156681) (#157052)
# Backport This will backport the following commits from `main` to `8.8`: - [[Synthetics] Show data retention privileges prompt (#156681)](https://github.com/elastic/kibana/pull/156681) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2023-05-08T19:11:11Z","message":"[Synthetics] Show data retention privileges prompt (#156681)","sha":"14b86951e5a950e20d068efafbd1ee4a43197258","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.8.0","v8.9.0"],"number":156681,"url":"https://github.com/elastic/kibana/pull/156681","mergeCommit":{"message":"[Synthetics] Show data retention privileges prompt (#156681)","sha":"14b86951e5a950e20d068efafbd1ee4a43197258"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156681","number":156681,"mergeCommit":{"message":"[Synthetics] Show data retention privileges prompt (#156681)","sha":"14b86951e5a950e20d068efafbd1ee4a43197258"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com> |
||
|
Kibana Machine
|
7584884a8f
|
[8.8] [Security Solution] [Fix] View all open alerts in Detection Response dashboard (#156893) (#157006)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] [Fix] View all open alerts in Detection Response dashboard (#156893)](https://github.com/elastic/kibana/pull/156893) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T14:42:25Z","message":"[Security Solution] [Fix] View all open alerts in Detection Response dashboard (#156893)\n\n## Summary\r\n\r\nThis PR handles : https://github.com/elastic/kibana/issues/149096\r\n- Fixes the redirection of `View all open alerts` button\r\n- Adds cypress tests for Detection and Response dashboard\r\n\r\n|Before|After|\r\n|---|---|\r\n|<video\r\nsrc=\" |
||
|
Kibana Machine
|
1612cedcea
|
[8.8] Fix build a connector document link (#156967) (#157002)
# Backport This will backport the following commits from `main` to `8.8`: - [Fix build a connector document link (#156967)](https://github.com/elastic/kibana/pull/156967) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Efe Gürkan YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T14:15:15Z","message":"Fix build a connector document link (#156967)\n\n## Summary\r\n\r\nFixes the docLink for \"build-connector\". This was going to a 404 due to\r\na small typo.","sha":"9b356f994be58de43f101bde0f051d783c34f449","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156967,"url":"https://github.com/elastic/kibana/pull/156967","mergeCommit":{"message":"Fix build a connector document link (#156967)\n\n## Summary\r\n\r\nFixes the docLink for \"build-connector\". This was going to a 404 due to\r\na small typo.","sha":"9b356f994be58de43f101bde0f051d783c34f449"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156967","number":156967,"mergeCommit":{"message":"Fix build a connector document link (#156967)\n\n## Summary\r\n\r\nFixes the docLink for \"build-connector\". This was going to a 404 due to\r\na small typo.","sha":"9b356f994be58de43f101bde0f051d783c34f449"}}]}] BACKPORT--> Co-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co> |
||
|
Kibana Machine
|
8da9d0f2be
|
[8.8] [SOR] validation schema: use previous version (#156665) (#156958)
# Backport This will backport the following commits from `main` to `8.8`: - [[SOR] validation schema: use previous version (#156665)](https://github.com/elastic/kibana/pull/156665) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pierre Gayvallet","email":"pierre.gayvallet@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T07:48:09Z","message":"[SOR] validation schema: use previous version (#156665)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/156423\r\n\r\nWe were only using the schema for validation if its version was an\r\n*exact* match with the current stack version, meaning that any previous\r\nschema was ignored (and even introducing a minor was causing the schema\r\nto be ignored).\r\n\r\nThis PR addresses it, by always using the closest previous schema\r\navailable.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"0a0d82216f46e905bdbf96ba9f790d0ba95adee7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:Saved Objects","release_note:skip","backport:prev-minor","v8.8.0","v8.9.0"],"number":156665,"url":"https://github.com/elastic/kibana/pull/156665","mergeCommit":{"message":"[SOR] validation schema: use previous version (#156665)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/156423\r\n\r\nWe were only using the schema for validation if its version was an\r\n*exact* match with the current stack version, meaning that any previous\r\nschema was ignored (and even introducing a minor was causing the schema\r\nto be ignored).\r\n\r\nThis PR addresses it, by always using the closest previous schema\r\navailable.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"0a0d82216f46e905bdbf96ba9f790d0ba95adee7"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156665","number":156665,"mergeCommit":{"message":"[SOR] validation schema: use previous version (#156665)\n\n## Summary\r\n\r\nFix https://github.com/elastic/kibana/issues/156423\r\n\r\nWe were only using the schema for validation if its version was an\r\n*exact* match with the current stack version, meaning that any previous\r\nschema was ignored (and even introducing a minor was causing the schema\r\nto be ignored).\r\n\r\nThis PR addresses it, by always using the closest previous schema\r\navailable.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"0a0d82216f46e905bdbf96ba9f790d0ba95adee7"}}]}] BACKPORT--> Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co> |
||
|
Kibana Machine
|
ebd30c181e
|
[8.8] [Security Solution] Fix rule snooze description on the rule editing page (#155850) (#156888)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Fix rule snooze description on the rule editing page (#155850)](https://github.com/elastic/kibana/pull/155850) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2023-05-05T16:14:41Z","message":"[Security Solution] Fix rule snooze description on the rule editing page (#155850)\n\n**Addresses:** https://github.com/elastic/kibana/issues/147737\r\n**Relates to:** https://github.com/elastic/kibana/pull/155612\r\n\r\n## Summary\r\n\r\nAfter merging https://github.com/elastic/kibana/pull/155612 back there is one issue is left unresolved described in this [comment](https://github.com/elastic/kibana/pull/155612#discussion_r1175545697):\r\n\r\n> Looks like we show the `Actions will not be preformed until it is unsnoozed` message unconditionally, i.e. regardless of whether the rule is snoozed or not. Since it's in bold it feels like a warning in the case where it doesn't really matter:\r\n\r\n> Can we hide it when the rule is not snoozed? If it's not trivial, can we make it look less dangerous by making the font regular and playing with the copy a little bit? E.g. `If snoozed actions will not be triggered`.\r\n\r\nThis PR resolves rule snooze description text issue. As snooze settings are resolved outside the security solution plugin having any logic to conditionally display a message will increase the complexity. This way the message was changes to avoid any text to appear conditionally.\r\n\r\n*Before:*\r\n\r\n<img width=\"703\" alt=\"Screenshot 2023-04-24 at 18 36 31\" src=\" |
||
|
Kibana Machine
|
012b92b67c
|
[8.8] [Telemetry] Change Privacy Statement Link (#156845) (#156883)
# Backport This will backport the following commits from `main` to `8.8`: - [[Telemetry] Change Privacy Statement Link (#156845)](https://github.com/elastic/kibana/pull/156845) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-05-05T15:54:08Z","message":"[Telemetry] Change Privacy Statement Link (#156845)","sha":"069af32d4b3ec59fc240ea6f27ac598a80a78563","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:Telemetry","release_note:skip","docs","backport:all-open","v8.9.0"],"number":156845,"url":"https://github.com/elastic/kibana/pull/156845","mergeCommit":{"message":"[Telemetry] Change Privacy Statement Link (#156845)","sha":"069af32d4b3ec59fc240ea6f27ac598a80a78563"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156845","number":156845,"mergeCommit":{"message":"[Telemetry] Change Privacy Statement Link (#156845)","sha":"069af32d4b3ec59fc240ea6f27ac598a80a78563"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> |
||
|
Kibana Machine
|
15863ca642
|
[8.8] [Security solution] Grouping bug fixes from BC1 (#156619) (#156717)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security solution] Grouping bug fixes from BC1 (#156619)](https://github.com/elastic/kibana/pull/156619) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2023-05-04T17:01:51Z","message":"[Security solution] Grouping bug fixes from BC1 (#156619)","sha":"0f2ee85d8b492c654f7e613e8b40a8f2a91ae634","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","v8.8.0","v8.9.0"],"number":156619,"url":"https://github.com/elastic/kibana/pull/156619","mergeCommit":{"message":"[Security solution] Grouping bug fixes from BC1 (#156619)","sha":"0f2ee85d8b492c654f7e613e8b40a8f2a91ae634"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156619","number":156619,"mergeCommit":{"message":"[Security solution] Grouping bug fixes from BC1 (#156619)","sha":"0f2ee85d8b492c654f7e613e8b40a8f2a91ae634"}}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co> |
||
|
Kibana Machine
|
b64f2f2d0b
|
[8.8] [APM] Check if metric fields exist (#145348) (#156006)
# Backport This will backport the following commits from `main` to `8.8`: - [[APM] Check if metric fields exist (#145348)](https://github.com/elastic/kibana/pull/145348) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Katerina Patticha","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2023-04-27T12:55:14Z","message":"[APM] Check if metric fields exist (#145348)\n\nFixes the error \r\n```\r\n\"script_stack\": [\r\n \"org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues.throwIfEmpty(ScriptDocValues.java:92)\",\r\n \"org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues$Longs.get(ScriptDocValues.java:110)\",\r\n \"org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues$Longs.getValue(ScriptDocValues.java:105)\",\r\n \"\"\"total = useCgroupLimit ? doc[limitKey].value : doc['system.memory.total'].value;\r\n\r\n double \"\"\",\r\n \" ^---- HERE\"\r\n\r\n\r\n```\r\n\r\nconnected https://github.com/elastic/sdh-apm/issues/765 (internal)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>","sha":"98165d26846367b98a259f76b664545a43d2434b","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:APM","backport:prev-minor","v8.8.0","v8.7.1","v8.9.0"],"number":145348,"url":"https://github.com/elastic/kibana/pull/145348","mergeCommit":{"message":"[APM] Check if metric fields exist (#145348)\n\nFixes the error \r\n```\r\n\"script_stack\": [\r\n \"org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues.throwIfEmpty(ScriptDocValues.java:92)\",\r\n \"org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues$Longs.get(ScriptDocValues.java:110)\",\r\n \"org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues$Longs.getValue(ScriptDocValues.java:105)\",\r\n \"\"\"total = useCgroupLimit ? doc[limitKey].value : doc['system.memory.total'].value;\r\n\r\n double \"\"\",\r\n \" ^---- HERE\"\r\n\r\n\r\n```\r\n\r\nconnected https://github.com/elastic/sdh-apm/issues/765 (internal)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>","sha":"98165d26846367b98a259f76b664545a43d2434b"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145348","number":145348,"mergeCommit":{"message":"[APM] Check if metric fields exist (#145348)\n\nFixes the error \r\n```\r\n\"script_stack\": [\r\n \"org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues.throwIfEmpty(ScriptDocValues.java:92)\",\r\n \"org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues$Longs.get(ScriptDocValues.java:110)\",\r\n \"org.elasticsearch.server@8.5.0-SNAPSHOT/org.elasticsearch.index.fielddata.ScriptDocValues$Longs.getValue(ScriptDocValues.java:105)\",\r\n \"\"\"total = useCgroupLimit ? doc[limitKey].value : doc['system.memory.total'].value;\r\n\r\n double \"\"\",\r\n \" ^---- HERE\"\r\n\r\n\r\n```\r\n\r\nconnected https://github.com/elastic/sdh-apm/issues/765 (internal)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>","sha":"98165d26846367b98a259f76b664545a43d2434b"}}]}] BACKPORT--> Co-authored-by: Katerina Patticha <aikaterini.patticha@elastic.co> |
||
|
Kibana Machine
|
7cc4100409
|
[8.8] [Security Solution] [Fix] Alert Table re-render + column width reset + TopN Not rendering (#155478) (#156411)
# Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] [Fix] Alert Table re-render + column width reset + TopN Not rendering (#155478)](https://github.com/elastic/kibana/pull/155478) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2023-05-02T15:22:26Z","message":"[Security Solution] [Fix] Alert Table re-render + column width reset + TopN Not rendering (#155478)\n\n## Summary\r\n\r\nThis PR handles : \r\n- Column width is reset when alert table re-renders #154796 \r\n- [Response Ops] Triggers Actions Alert table un-mounts / remounts\r\ncomplete row when clicking on checkbox. #155229\r\n- [Security Solution] TopN does not work on Alert Table in Event\r\nRendered View #155152\r\n\r\n\r\n|Before | After |\r\n|---|---|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov\"\r\n/> | <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov\"\r\n/>\r\n\r\n |","sha":"eba1001c64f1084293f6c18d8aa6e7aaff1c568d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Team:Threat Hunting:Investigations","v8.8.0","v8.9.0"],"number":155478,"url":"https://github.com/elastic/kibana/pull/155478","mergeCommit":{"message":"[Security Solution] [Fix] Alert Table re-render + column width reset + TopN Not rendering (#155478)\n\n## Summary\r\n\r\nThis PR handles : \r\n- Column width is reset when alert table re-renders #154796 \r\n- [Response Ops] Triggers Actions Alert table un-mounts / remounts\r\ncomplete row when clicking on checkbox. #155229\r\n- [Security Solution] TopN does not work on Alert Table in Event\r\nRendered View #155152\r\n\r\n\r\n|Before | After |\r\n|---|---|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov\"\r\n/> | <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov\"\r\n/>\r\n\r\n |","sha":"eba1001c64f1084293f6c18d8aa6e7aaff1c568d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155478","number":155478,"mergeCommit":{"message":"[Security Solution] [Fix] Alert Table re-render + column width reset + TopN Not rendering (#155478)\n\n## Summary\r\n\r\nThis PR handles : \r\n- Column width is reset when alert table re-renders #154796 \r\n- [Response Ops] Triggers Actions Alert table un-mounts / remounts\r\ncomplete row when clicking on checkbox. #155229\r\n- [Security Solution] TopN does not work on Alert Table in Event\r\nRendered View #155152\r\n\r\n\r\n|Before | After |\r\n|---|---|\r\n| <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/233974827-548c7e61-0737-436c-8384-0faa923ab5d7.mov\"\r\n/> | <video\r\nsrc=\"https://user-images.githubusercontent.com/7485038/234316670-4cd318bd-8fde-45ed-999d-a6a78bbf0432.mov\"\r\n/>\r\n\r\n |","sha":"eba1001c64f1084293f6c18d8aa6e7aaff1c568d"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co> |
![236254424](https://user-images.githubusercontent.com/7359339/234060523-fe9161a1-0e83-4d39-a193-81c946d95106.png\">\r\n\r\n*After:*\r\n\r\n