## Summary
Closes#146546
This PR replaces bash script with node-based runner script.
Script can take relative path to directory with scalability journey
files or relative path to individual journey json file.
`node scripts/run_scalability.js --journey-config-path
scalability_traces/server`
`node scripts/run_scalability.js --journey-config-path
scalability_traces/server/api.core.capabilities.json`
### Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
### Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.
When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Removes all the noise from poorly written React tests and includes a
warning to explain the situation to folks
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
Rewrite the performance journey runner using TypeScript, to avoid
dangling ES\node processes during test execution.
Results are stable with this runner, as verified on CI
Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
This is a refactor:
* Move `FilesContext`, `FilePicker` and `UploadFile` components to
`packages/shared-ux/file` as packages
* Renamed `UploadFile` to `FileUpload` for more consistency
* Also created `packages/shared-ux/file/types` and added
`useBehaviourSubject` to `packages/shared-ux/file/util` (we can consider
moving this elsewhere since that function is not necessarily tied to the
files domain).
* Removed the storybook config from `files` public plugin since there
are no more components there
## How to test
👉🏻 `yarn storybook shared_ux` to see the components in a lab environment
OR
👉🏻 `yarn start --run-examples` then "Developer examples" > "Files
example" to see the components being used in Kibana
Look out for any regressions: for example, in the `FileImage` component
importing `import bh from 'blurhash'` caused a regression because
blurhash does not expose a default export. This was fixed by doing:
`import * as bh from 'blurhash`.
## Notes
* With this change, we needed to move `FilesClient` interface to
packages since it is used by the components. However, we also wanted to
keep `FilesClient` interface as it is currently exported from `files`
plugin because it exposes methods that only the server of `files` plugin
should know about (e.g., the metrics endpoint). I created the
`BaseFilesClient` in the packages directory that is extended in the
`files` plugin as needed. This is a snapshot of the types as they are
provided from the server implementation and will need to be
updated/maintained by hand from here on out.
* With `BaseFilesClient` in `packages`, we lost the type check between
`files` server endpoints and the client methods. To re-establish this
link the `CreateRouteDefinition` type helper got a parameter where the
client method can be passed in to do checks that the server inputs
(query, param and body) as well as outputs (the responses) match what
the client expects using the `X extends Y ? X : unknown` capability of
TS. See this in action in, for example
`src/plugins/files/server/routes/find.ts`. DX will be: if these ever get
out of sync, the server values for `query`, `param` or `body` will map
to `unknown` causing a type issue when trying to use these values. This
can only be fixed by bringing the `FilesClient` types in sync with the
server types.
* Server endpoints that should match expected `FilesClient`
inputs/outputs should use the `CreateRouteDefinition` type helper, but
if the endpoint does not need to map to a client method we can always
skip using `CreateRouteDefinition`.
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Adds support for a label `ci:cloud-persist-deployment`, that will
prevent deployments from shutting down until the label is removed.
This also fixes a bug in the conditional checking for whether the cloud
deployment label was removed. If `ci:cloud-deploy` is removed from a PR,
the deployment should now shutdown in the next hour instead of after
48h.
It's easiest to test this after merging. I can alternatively modify the
pipeline to run on a branch, but either way I'll end up pushing commits
and this is fairly straight forward and it breaking is low risk. Either
way works for me.
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Tyler Smalley <tylersmalley@gmail.com>
As requested by the QA team, these PRs should be labeled with "docs" to
help filter them out when reviewing PRs that are going into a specific
version.
## Summary
Last week, our team has dicovered that e2e tests are not executed on CI,
this PR is an attempt to fix that.
Threat intel pipeline should be run whenever the `threat_intelligence`
plugin source or related tests config has changed.
This passes the beats manifest used to download metricbeat and filebeat
for our cloud image to the release-manager CLI. This will be used to
validate that the bundled versions we use match the released versions.
* [artifacts] Reuse Cloud image for tests
In https://github.com/elastic/kibana/pull/141657 we turned on Cloud
image builds in Kibana CI. This updates the Cloud deployment test suite
to reuse the same image build.
* update comment
* Record e2e tests to Cypress dashboard and enable screenshots and videos
* Delete videos that have no failures or retries
* Set browser witdh and height for tests
* Fix flaky test for storage explorer
* Remove cypress plugin file
* Fix typo in spec name
* Enable test retries
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Adding event log check to CI check.
* Adding event log check to CI check.
* Can I check out ECS
* Checking out specific ECS branch
* Checking out specific ECS branch
* Custom error message
* Reverting event log mapping test changes
* Pinning to 1.8
* Update .buildkite/scripts/steps/checks/event_log.sh
Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
* Implement new alert summary widget design and remove chart
* Fix padding issue
* Remove unused translation
* Fix type and test errors
* Fix types and remove extra aggs logic
* Add triggers_actions_ui to storybook list
* Fix small alignment issue by removing extra EuiFlexGroup
* Fix UI issue for small mobile
* Update spacing
Co-authored-by: Kevin Delemme <kdelemme@gmail.com>
Co-authored-by: Kevin Delemme <kdelemme@gmail.com>
Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
* [ftr] add first-class support for playwrite journeys
* [CI] Auto-commit changed files from 'node scripts/generate codeowners'
* fix jest test
* remove ability to customize kibana server args, if we need it we can add it back
* remove dev dir that doesn't exist
* fix typo
* prevent duplicated array converstion logic by sharing flag reader
* remove destructuring of option
* fix scalability config and config_path import
* fix start_servers args and tests
* include simple readme
* fix jest tests and support build re-use when changes are just to jest tests
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
* [cft] Remove deployment when a PR is outdated
This changes the stale deployment ttl from 7 days to 2 days
to match the PR outdated check. The longer a deployment is active, the
more likely it is that we'll see a snapshot related break somewhere in
the stack. These are typically template or migration related script
changes.
Longer running deployments can also run out of disk space and start
alerting on health checks.
* day in seconds
* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
* [cft] Stabilize deployments
- Switches from general purpose to high memory deployments
- Enables autoscaling
- Allows a warm node to be turned on for longer running deployments with
more data
* fix ml
* revert autoscaling
* fix
* [packages] add kibana.jsonc files
* auto-migrate to kibana.jsonc
* support interactive pkg id selection too
* remove old codeowners entry
* skip codeowners generation when .github/CODEOWNERS doesn't exist
* fall back to format validation if user is offline
* update question style
* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
* add scalability pipeline to run scenarios from APM traces
* update runner description
* remove retry-all-errors curl flag
* add flag for curl to ignore connection refused
* override ES_HOST for gatling runner
* exclude config from regular CI, remove bail flag
* fix uploaded scalability traces
* fix text and remove space
* add validation in config
* use functions instead of scripts
* renaming var in loop
* add step timeout
* define functions before call
* use trap for stopping ES
* fix path for artifacts extraction
* update serverArgs
* add pre-build step
* add pre-build step
* use default pre-build step
* delete step
* print BUILDKITE_PIPELINE_SLUG
* disable telemetry
* remove log
* enable telemetry
* add step to upload test results
* move trap after pid
* upload test reports to gcs
* fix script
* Revert "fix script"
This reverts commit 1c6bc3f45c.
* Revert "upload test reports to gcs"
This reverts commit c957a31c32.
* added storybook config
* first pass of the image component
* use storybook "action" instead of console.log
* fix up some comments and fix if-else statement
* address type exports
* added viewport observer tests
* added files plugin to storybook CI and correct JSON formatting
* ensure that subscription only happens once
* intersectionobserver should always be available
* only run useeffect once
* use React.forwardRef API rather than props
* factor out the viewport observer to a hook
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [cft] Update comment when deployment is available
Currently cloud deployment are linked to after the entire CI run. Cloud
deployments typically finish early, so this provides a notification as
soon as the deployment is available.
* newline
* fix id
* [perf-tests/scalability] improve logging when uploading traces
* restore including kibana artifacts in scalability dataset
* create parent dirs too
* support skipping builds too
