mirror of
https://github.com/elastic/kibana.git
synced 2025-06-27 10:40:07 -04:00
6 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Elena Shostak
|
7a41906d88
|
[Authz] Mandatory Security Config (#215180)
## Summary
This PR makes `security` a required field for route registration. To
incorporate the new required filed, changes has been made:
1. **Test file updates**. A lot of the updates made in this PR were made
in tests.
2. **Versioned route security configuration**. For the versioned route
`security` config has been lifted up to the top-level definition:
Before
```ts
router.versioned
.get({
path: '/api/path',
options: { ... },
...
}, handler)
.addVersion({
version: 1,
validate: false,
security: {
authz: {
requiredPrivileges: ['privilege'],
},
},
});
```
After
```ts
router.versioned
.get({
path: '/api/path',
options: { ... },
security: {
authz: {
requiredPrivileges: ['privilege'],
},
},
...
}, handler)
.addVersion({
version: 1,
validate: false,
});
```
3. **Type adjustments for route wrappers**. Type changes has been made
in:
-
`x-pack/solutions/observability/plugins/infra/server/lib/adapters/framework/adapter_types.ts`
-
`x-pack/solutions/observability/plugins/metrics_data_access/server/lib/adapters/framework/adapter_types.ts`
-
`x-pack/solutions/observability/plugins/synthetics/server/routes/types.ts`
-
`x-pack/solutions/observability/plugins/uptime/server/legacy_uptime/routes/types.ts`
Security was made an optional field for the wrappers defined in those
files, since the default security is provided in the wrapper itself and
then passed down to the core router.
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
__Closes: https://github.com/elastic/kibana/issues/215331__
---------
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
|
||
Gerard Soldevila
|
4a00449bdc
|
SKA: Relocate core mock and test-helper modules (#208538)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 55 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/core-analytics-browser-mocks` | `src/core/packages/analytics/browser-mocks` | | `@kbn/core-analytics-server-mocks` | `src/core/packages/analytics/server-mocks` | | `@kbn/core-application-browser-mocks` | `src/core/packages/application/browser-mocks` | | `@kbn/core-apps-browser-mocks` | `src/core/packages/apps/browser-mocks` | | `@kbn/core-base-browser-mocks` | `src/core/packages/base/browser-mocks` | | `@kbn/core-base-server-mocks` | `src/core/packages/base/server-mocks` | | `@kbn/core-capabilities-browser-mocks` | `src/core/packages/capabilities/browser-mocks` | | `@kbn/core-capabilities-server-mocks` | `src/core/packages/capabilities/server-mocks` | | `@kbn/core-chrome-browser-mocks` | `src/core/packages/chrome/browser-mocks` | | `@kbn/core-deprecations-browser-mocks` | `src/core/packages/deprecations/browser-mocks` | | `@kbn/core-deprecations-server-mocks` | `src/core/packages/deprecations/server-mocks` | | `@kbn/core-doc-links-browser-mocks` | `src/core/packages/doc-links/browser-mocks` | | `@kbn/core-doc-links-server-mocks` | `src/core/packages/doc-links/server-mocks` | | `@kbn/core-elasticsearch-client-server-mocks` | `src/core/packages/elasticsearch/client-server-mocks` | | `@kbn/core-elasticsearch-server-mocks` | `src/core/packages/elasticsearch/server-mocks` | | `@kbn/core-environment-server-mocks` | `src/core/packages/environment/server-mocks` | | `@kbn/core-execution-context-browser-mocks` | `src/core/packages/execution-context/browser-mocks` | | `@kbn/core-execution-context-server-mocks` | `src/core/packages/execution-context/server-mocks` | | `@kbn/core-fatal-errors-browser-mocks` | `src/core/packages/fatal-errors/browser-mocks` | | `@kbn/core-http-browser-mocks` | `src/core/packages/http/browser-mocks` | | `@kbn/core-http-context-server-mocks` | `src/core/packages/http/context-server-mocks` | | `@kbn/core-http-resources-server-mocks` | `src/core/packages/http/resources-server-mocks` | | `@kbn/core-http-router-server-mocks` | `src/core/packages/http/router-server-mocks` | | `@kbn/core-http-server-mocks` | `src/core/packages/http/server-mocks` | | `@kbn/core-i18n-browser-mocks` | `src/core/packages/i18n/browser-mocks` | | `@kbn/core-i18n-server-mocks` | `src/core/packages/i18n/server-mocks` | | `@kbn/core-injected-metadata-browser-mocks` | `src/core/packages/injected-metadata/browser-mocks` | | `@kbn/core-integrations-browser-mocks` | `src/core/packages/integrations/browser-mocks` | | `@kbn/core-lifecycle-browser-mocks` | `src/core/packages/lifecycle/browser-mocks` | | `@kbn/core-lifecycle-server-mocks` | `src/core/packages/lifecycle/server-mocks` | | `@kbn/core-logging-browser-mocks` | `src/core/packages/logging/browser-mocks` | | `@kbn/core-logging-server-mocks` | `src/core/packages/logging/server-mocks` | | `@kbn/core-metrics-collectors-server-mocks` | `src/core/packages/metrics/collectors-server-mocks` | | `@kbn/core-metrics-server-mocks` | `src/core/packages/metrics/server-mocks` | | `@kbn/core-node-server-mocks` | `src/core/packages/node/server-mocks` | | `@kbn/core-notifications-browser-mocks` | `src/core/packages/notifications/browser-mocks` | | `@kbn/core-overlays-browser-mocks` | `src/core/packages/overlays/browser-mocks` | | `@kbn/core-plugins-browser-mocks` | `src/core/packages/plugins/browser-mocks` | | `@kbn/core-plugins-server-mocks` | `src/core/packages/plugins/server-mocks` | | `@kbn/core-preboot-server-mocks` | `src/core/packages/preboot/server-mocks` | | `@kbn/core-rendering-browser-mocks` | `src/core/packages/rendering/browser-mocks` | | `@kbn/core-rendering-server-mocks` | `src/core/packages/rendering/server-mocks` | | `@kbn/core-saved-objects-api-server-mocks` | `src/core/packages/saved-objects/api-server-mocks` | | `@kbn/core-saved-objects-base-server-mocks` | `src/core/packages/saved-objects/base-server-mocks` | | `@kbn/core-saved-objects-browser-mocks` | `src/core/packages/saved-objects/browser-mocks` | | `@kbn/core-saved-objects-import-export-server-mocks` | `src/core/packages/saved-objects/import-export-server-mocks` | | `@kbn/core-saved-objects-migration-server-mocks` | `src/core/packages/saved-objects/migration-server-mocks` | | `@kbn/core-saved-objects-server-mocks` | `src/core/packages/saved-objects/server-mocks` | | `@kbn/core-status-server-mocks` | `src/core/packages/status/server-mocks` | | `@kbn/core-test-helpers-kbn-server` | `src/dev/packages/core-test-helpers-kbn-server` | | `@kbn/core-test-helpers-model-versions` | `src/dev/packages/core-test-helpers-model-versions` | | `@kbn/core-theme-browser-mocks` | `src/core/packages/theme/browser-mocks` | | `@kbn/core-ui-settings-browser-mocks` | `src/core/packages/ui-settings/browser-mocks` | | `@kbn/core-ui-settings-server-mocks` | `src/core/packages/ui-settings/server-mocks` | | `@kbn/core-usage-data-server-mocks` | `src/core/packages/usage-data/server-mocks` | <details > <summary>Updated references</summary> ``` ./.github/codeql/codeql-config.yml ./package.json ./packages/kbn-ts-projects/config-paths.json ./src/core/packages/analytics/browser-mocks/jest.config.js ./src/core/packages/analytics/server-mocks/jest.config.js ./src/core/packages/application/browser-mocks/jest.config.js ./src/core/packages/apps/browser-mocks/jest.config.js ./src/core/packages/base/browser-mocks/jest.config.js ./src/core/packages/base/server-mocks/jest.config.js ./src/core/packages/capabilities/browser-mocks/jest.config.js ./src/core/packages/capabilities/server-mocks/jest.config.js ./src/core/packages/chrome/browser-mocks/jest.config.js ./src/core/packages/deprecations/browser-mocks/jest.config.js ./src/core/packages/deprecations/server-mocks/jest.config.js ./src/core/packages/doc-links/browser-mocks/jest.config.js ./src/core/packages/doc-links/server-mocks/jest.config.js ./src/core/packages/elasticsearch/client-server-mocks/jest.config.js ./src/core/packages/elasticsearch/server-mocks/jest.config.js ./src/core/packages/environment/server-mocks/jest.config.js ./src/core/packages/execution-context/browser-mocks/jest.config.js ./src/core/packages/execution-context/server-mocks/jest.config.js ./src/core/packages/fatal-errors/browser-mocks/jest.config.js ./src/core/packages/http/browser-mocks/jest.config.js ./src/core/packages/http/context-server-mocks/jest.config.js ./src/core/packages/http/resources-server-mocks/jest.config.js ./src/core/packages/http/router-server-mocks/jest.config.js ./src/core/packages/http/server-mocks/jest.config.js ./src/core/packages/i18n/browser-mocks/jest.config.js ./src/core/packages/i18n/server-mocks/jest.config.js ./src/core/packages/injected-metadata/browser-mocks/jest.config.js ./src/core/packages/integrations/browser-mocks/jest.config.js ./src/core/packages/lifecycle/browser-mocks/jest.config.js ./src/core/packages/lifecycle/server-mocks/jest.config.js ./src/core/packages/logging/browser-mocks/jest.config.js ./src/core/packages/logging/server-mocks/jest.config.js ./src/core/packages/metrics/collectors-server-mocks/jest.config.js ./src/core/packages/metrics/server-mocks/jest.config.js ./src/core/packages/node/server-mocks/jest.config.js ./src/core/packages/notifications/browser-mocks/jest.config.js ./src/core/packages/overlays/browser-mocks/jest.config.js ./src/core/packages/plugins/browser-mocks/jest.config.js ./src/core/packages/plugins/server-mocks/jest.config.js ./src/core/packages/preboot/server-mocks/jest.config.js ./src/core/packages/rendering/browser-mocks/jest.config.js ./src/core/packages/rendering/server-mocks/jest.config.js ./src/core/packages/saved-objects/api-server-mocks/jest.config.js ./src/core/packages/saved-objects/base-server-mocks/jest.config.js ./src/core/packages/saved-objects/browser-mocks/jest.config.js ./src/core/packages/saved-objects/import-export-server-mocks/jest.config.js ./src/core/packages/saved-objects/migration-server-mocks/jest.config.js ./src/core/packages/saved-objects/server-mocks/jest.config.js ./src/core/packages/status/server-mocks/jest.config.js ./src/core/packages/theme/browser-mocks/jest.config.js ./src/core/packages/ui-settings/browser-mocks/jest.config.js ./src/core/packages/ui-settings/server-mocks/jest.config.js ./src/core/packages/usage-data/server-mocks/jest.config.js ./src/core/system/tsconfig.type_check.json ./src/dev/packages/core-test-helpers-kbn-server/jest.config.js ./src/dev/packages/core-test-helpers-model-versions/jest.config.js ./src/dev/tsconfig.type_check.json ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/plugins/private/interactive_setup/tsconfig.type_check.json ./src/platform/plugins/shared/console/tsconfig.type_check.json ./src/plugins/kibana_usage_collection/tsconfig.type_check.json ./src/plugins/saved_objects_management/tsconfig.type_check.json ./src/plugins/telemetry/tsconfig.type_check.json ./src/plugins/usage_collection/tsconfig.type_check.json ./tsconfig.base.json ./tsconfig.base.type_check.json ./tsconfig.refs.json ./x-pack/platform/plugins/private/index_lifecycle_management/tsconfig.type_check.json ./x-pack/platform/plugins/private/remote_clusters/tsconfig.type_check.json ./x-pack/platform/plugins/private/snapshot_restore/tsconfig.type_check.json ./x-pack/platform/plugins/private/watcher/tsconfig.type_check.json ./x-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.type_check.json ./x-pack/platform/plugins/shared/fleet/tsconfig.type_check.json ./x-pack/platform/plugins/shared/security/tsconfig.type_check.json ./x-pack/platform/plugins/shared/spaces/tsconfig.type_check.json ./x-pack/plugins/actions/tsconfig.type_check.json ./x-pack/plugins/aiops/tsconfig.type_check.json ./x-pack/plugins/alerting/tsconfig.type_check.json ./x-pack/plugins/cases/tsconfig.type_check.json ./x-pack/plugins/enterprise_search/tsconfig.type_check.json ./x-pack/plugins/integration_assistant/tsconfig.type_check.json ./x-pack/plugins/ml/tsconfig.type_check.json ./x-pack/plugins/observability_solution/apm/tsconfig.type_check.json ./x-pack/plugins/observability_solution/apm_data_access/tsconfig.type_check.json ./x-pack/plugins/observability_solution/entity_manager/tsconfig.type_check.json ./x-pack/plugins/observability_solution/exploratory_view/tsconfig.type_check.json ./x-pack/plugins/observability_solution/observability/tsconfig.type_check.json ./x-pack/plugins/observability_solution/slo/tsconfig.type_check.json ./x-pack/plugins/observability_solution/synthetics/tsconfig.type_check.json ./x-pack/plugins/observability_solution/uptime/tsconfig.type_check.json ./x-pack/plugins/rule_registry/tsconfig.type_check.json ./x-pack/plugins/search_playground/tsconfig.type_check.json ./x-pack/plugins/serverless_search/tsconfig.type_check.json ./x-pack/plugins/stack_alerts/tsconfig.type_check.json ./x-pack/plugins/stack_connectors/tsconfig.type_check.json ./x-pack/plugins/task_manager/tsconfig.type_check.json ./x-pack/plugins/transform/tsconfig.type_check.json ./x-pack/solutions/observability/plugins/dataset_quality/tsconfig.type_check.json ./x-pack/solutions/security/packages/security-solution/ecs_data_quality_dashboard/tsconfig.type_check.json ./x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.type_check.json ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/core/packages/analytics/browser-mocks/jest.config.js:12 src/core/packages/analytics/browser-mocks/tsconfig.json:2 src/core/packages/analytics/server-mocks/jest.config.js:12 src/core/packages/analytics/server-mocks/tsconfig.json:2 src/core/packages/application/browser-mocks/jest.config.js:12 src/core/packages/application/browser-mocks/tsconfig.json:2 src/core/packages/apps/browser-mocks/jest.config.js:12 src/core/packages/apps/browser-mocks/tsconfig.json:2 src/core/packages/base/browser-mocks/jest.config.js:12 src/core/packages/base/browser-mocks/tsconfig.json:2 src/core/packages/base/server-mocks/jest.config.js:12 src/core/packages/base/server-mocks/tsconfig.json:2 src/core/packages/capabilities/browser-mocks/jest.config.js:12 src/core/packages/capabilities/browser-mocks/tsconfig.json:2 src/core/packages/capabilities/server-mocks/jest.config.js:12 src/core/packages/capabilities/server-mocks/tsconfig.json:2 src/core/packages/chrome/browser-mocks/jest.config.js:12 src/core/packages/chrome/browser-mocks/tsconfig.json:2 src/core/packages/deprecations/browser-mocks/jest.config.js:12 src/core/packages/deprecations/browser-mocks/tsconfig.json:2 src/core/packages/deprecations/server-mocks/jest.config.js:12 src/core/packages/deprecations/server-mocks/tsconfig.json:2 src/core/packages/doc-links/browser-mocks/jest.config.js:12 src/core/packages/doc-links/browser-mocks/tsconfig.json:2 src/core/packages/doc-links/server-mocks/jest.config.js:12 src/core/packages/doc-links/server-mocks/tsconfig.json:2 src/core/packages/elasticsearch/client-server-mocks/jest.config.js:12 src/core/packages/elasticsearch/client-server-mocks/tsconfig.json:2 src/core/packages/elasticsearch/server-mocks/jest.config.js:12 src/core/packages/elasticsearch/server-mocks/tsconfig.json:2 src/core/packages/environment/server-mocks/jest.config.js:12 src/core/packages/environment/server-mocks/tsconfig.json:2 src/core/packages/execution-context/browser-mocks/jest.config.js:12 src/core/packages/execution-context/browser-mocks/tsconfig.json:2 src/core/packages/execution-context/server-mocks/jest.config.js:12 src/core/packages/execution-context/server-mocks/tsconfig.json:2 src/core/packages/fatal-errors/browser-mocks/jest.config.js:12 src/core/packages/fatal-errors/browser-mocks/tsconfig.json:2 src/core/packages/http/browser-mocks/jest.config.js:12 src/core/packages/http/browser-mocks/tsconfig.json:2 src/core/packages/http/context-server-mocks/jest.config.js:12 src/core/packages/http/context-server-mocks/tsconfig.json:2 src/core/packages/http/resources-server-mocks/jest.config.js:12 src/core/packages/http/resources-server-mocks/tsconfig.json:2 src/core/packages/http/router-server-mocks/jest.config.js:12 src/core/packages/http/router-server-mocks/tsconfig.json:2 src/core/packages/http/server-mocks/jest.config.js:12 src/core/packages/http/server-mocks/tsconfig.json:2 src/core/packages/i18n/browser-mocks/jest.config.js:12 src/core/packages/i18n/browser-mocks/tsconfig.json:2 src/core/packages/i18n/server-mocks/jest.config.js:12 src/core/packages/i18n/server-mocks/tsconfig.json:2 src/core/packages/injected-metadata/browser-mocks/jest.config.js:12 src/core/packages/injected-metadata/browser-mocks/tsconfig.json:2 src/core/packages/integrations/browser-mocks/jest.config.js:12 src/core/packages/integrations/browser-mocks/tsconfig.json:2 src/core/packages/lifecycle/browser-mocks/jest.config.js:12 src/core/packages/lifecycle/browser-mocks/tsconfig.json:2 src/core/packages/lifecycle/server-mocks/jest.config.js:12 src/core/packages/lifecycle/server-mocks/tsconfig.json:2 src/core/packages/logging/browser-mocks/jest.config.js:12 src/core/packages/logging/browser-mocks/tsconfig.json:2 src/core/packages/logging/server-mocks/jest.config.js:12 src/core/packages/logging/server-mocks/tsconfig.json:2 src/core/packages/metrics/collectors-server-mocks/jest.config.js:12 src/core/packages/metrics/collectors-server-mocks/tsconfig.json:2 src/core/packages/metrics/server-mocks/jest.config.js:12 src/core/packages/metrics/server-mocks/tsconfig.json:2 src/core/packages/node/server-mocks/jest.config.js:12 src/core/packages/node/server-mocks/tsconfig.json:2 src/core/packages/notifications/browser-mocks/jest.config.js:12 src/core/packages/notifications/browser-mocks/tsconfig.json:2 src/core/packages/overlays/browser-mocks/jest.config.js:12 src/core/packages/overlays/browser-mocks/tsconfig.json:2 src/core/packages/plugins/browser-mocks/jest.config.js:12 src/core/packages/plugins/browser-mocks/tsconfig.json:2 src/core/packages/plugins/server-mocks/jest.config.js:12 src/core/packages/plugins/server-mocks/tsconfig.json:2 src/core/packages/preboot/server-mocks/jest.config.js:12 src/core/packages/preboot/server-mocks/tsconfig.json:2 src/core/packages/rendering/browser-mocks/jest.config.js:12 src/core/packages/rendering/browser-mocks/tsconfig.json:2 src/core/packages/rendering/server-mocks/jest.config.js:12 src/core/packages/rendering/server-mocks/tsconfig.json:2 src/core/packages/saved-objects/api-server-mocks/jest.config.js:12 src/core/packages/saved-objects/api-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/base-server-mocks/jest.config.js:12 src/core/packages/saved-objects/base-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/browser-mocks/jest.config.js:12 src/core/packages/saved-objects/browser-mocks/tsconfig.json:2 src/core/packages/saved-objects/import-export-server-mocks/jest.config.js:12 src/core/packages/saved-objects/import-export-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/migration-server-mocks/jest.config.js:12 src/core/packages/saved-objects/migration-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/server-mocks/jest.config.js:12 src/core/packages/saved-objects/server-mocks/tsconfig.json:2 src/core/packages/status/server-mocks/jest.config.js:12 src/core/packages/status/server-mocks/tsconfig.json:2 src/core/packages/theme/browser-mocks/jest.config.js:12 src/core/packages/theme/browser-mocks/tsconfig.json:2 src/core/packages/ui-settings/browser-mocks/jest.config.js:12 src/core/packages/ui-settings/browser-mocks/tsconfig.json:2 src/core/packages/ui-settings/server-mocks/jest.config.js:12 src/core/packages/ui-settings/server-mocks/tsconfig.json:2 src/core/packages/usage-data/server-mocks/jest.config.js:12 src/core/packages/usage-data/server-mocks/tsconfig.json:2 src/dev/packages/core-test-helpers-kbn-server/jest.config.js:12 src/dev/packages/core-test-helpers-kbn-server/tsconfig.json:2 src/dev/packages/core-test-helpers-model-versions/jest.config.js:12 src/dev/packages/core-test-helpers-model-versions/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com> |
||
Alejandro Fernández Haro
|
f0262080c8
|
[Feature Flags Example Plugin] Change ctx provider (#201097) | ||
|
Alejandro Fernández Haro
|
93d7044919
|
[Feature Flags] Add APM transaction + better example code (#199671)
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
Alejandro Fernández Haro
|
f25b3be194
|
[Feature flags example] Apply FF naming conventions (#196535) | ||
|
Alejandro Fernández Haro
|
02ce1b9101
|
[Feature Flags Service] Hello world 👋 (#188562)
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> |