Commit graph

12 commits

Author SHA1 Message Date
Rachel Shen
405be1af73
[ConnectionDetails] add aria-labels (#184243)
## Summary

Closes https://github.com/elastic/kibana-team/issues/741

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
2024-05-29 07:13:20 -06:00
Tim Sullivan
66182b451b
[EuiProvider] Fix Kibana-Core code (#183873)
Fixes needed for https://github.com/elastic/kibana/pull/180819
2024-05-23 13:19:40 -07:00
Vadim Kibana
012d62fe09
[Connection Details] Adds telemetry for user actions (#183265)
## Summary

Closes https://github.com/elastic/kibana/issues/180869

Add tracking for the following user actions:

- [x] "Learn more" click
- [x] Tab switches
- [x] Copy endpoint
- [x] Show cloud ID
- [x] Copy cloud ID
- [x] Create API key
- [x] "Manage API keys" click
- [x] Key encoding change
- [x] API key copy

The emitted telemetry events are as follows:

- `connection_details_learn_more_clicked`
- `connection_details_tab_switched`
  - Has `tab` paramter
- `connection_details_copy_endpoint_url_clicked`
- `connection_details_show_cloud_id_toggled`
- `connection_details_copy_cloud_id_clicked`
- `connection_details_new_api_key_created`
- `connection_details_manage_api_keys_clicked`
- `connection_details_key_encoding_changed`
  - Has `format` paramter
- `connection_details_copy_api_key_clicked`
  - Has `format` paramter

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2024-05-17 03:33:06 -07:00
Vadim Kibana
b0f8ee7f5e
[Connection Details] Show "Manage api keys" link when no permissions (#183599)
## Summary

This change show the "Manage API keys" link on the Connection Details
flyout "API key" tab when user does not have permissions to edit their
API keys:


![image](89f5e1a4-737e-401c-ba9e-314ded050bd2)


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2024-05-17 11:14:49 +02:00
Vadim Kibana
ece10c6139
[Connection Details] Cloud ID info "?" icon with popup (#183388)
## Summary

Cloud ID copy input now has a information "?" icon with a popup and a
link.


![image](36b07f12-bda5-41fd-baac-5cd4791042c0)


![image](3ddb2f81-e69b-47d7-8a32-2c726c114ec1)


![cloud-id-popover](52eed8c4-bf25-4f7b-b631-adc47de3432f)



### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)


### Release note

Cloud ID copy input now has a information "?" icon with a popup and a
link.


![cloud-id-popover](52eed8c4-bf25-4f7b-b631-adc47de3432f)
2024-05-16 10:23:01 +02:00
Vadim Kibana
668f0966fe
[Connection Details] Move tabs into the header (#183484)
## Summary

Closes https://github.com/elastic/kibana/issues/182966

*Connection Details* flyout tabs are now in the header of the flyout.
See the before/after below:

<img width="762" alt="image"
src="640378ad-3d96-4fd5-8353-883a1609b55c">

This saves screen real-estate for more content in the flyout body.



### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2024-05-16 10:21:25 +02:00
Patryk Kopyciński
0780c19322
Add explicit children types (#181257)
## Summary

Prep work for React@18 bump

tl;dr In React@18 `React.FC` doesn't contain `children` anymore, so in
order to make the bump easier I have decided to split the effort in
multiple faces and hopefully this will make it easier for everyone

This PR focuses only on adding explicit `children` declaration either by
using `React.PropsWithChildren` type or by adding `children:
React.ReactNode` to the existing props types

https://github.com/DefinitelyTyped/DefinitelyTyped/issues/46691

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>
Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
Co-authored-by: James Gowdy <jgowdy@elastic.co>
2024-04-29 16:56:41 +01:00
Vadim Kibana
bd16667056
Connection Details Flyout (#180912)
## Summary

Implements the new *Connection Details* flyout, which allows to copy ES
connection details and provides a simplified interface to create an API
key.


![connection-details](2223db63-748c-4620-9686-1b79c40037a7)


![image](6c3f9661-12bf-4868-b432-483e88dbaab5)


![image](50016456-c880-4738-af24-cb7bebafd01a)


![image](d92f20a5-75bf-4563-abc9-afa5c3256bbd)


### Old UIs

Old connection details modal:


![image](661a9988-6c3b-493f-beca-96e7d2457ad4)

Could be open from help menu:


![image](717bac4c-b041-4163-b4b9-1b7e5ef0a791)

Or, could be open from a setup guide card:


![image](c1d5a657-183f-4af6-90c3-c1d393379785)

## How to test

Add these Cloud settings to your `config/kibana.dev.yml` as a mock data:

```
elasticsearch.hosts: ["http://localhost:9200"]
xpack.cloud.id: my-cluster-id:dXMtZWFzdC0xLmF3cy5zdGFnaW5nLmZvdW5kaXQubm8kZjY3ZDZiZjFhM2NmNDA4ODhlODg2M2Y2Y2IyY2RjNGMkOWViYzEzYjRkOTU0NDI2NDljMzcwZTNlZjMyZWYzOGI=
```

To make Kibana think your local user is a "cloud user", hard-code
`elastic_cloud_user` to `true`:

<img width="764" alt="image"
src="918ed4e6-6cdc-4632-a5a9-0f0be46947d8">



### Checklist

Delete any items that are not applicable to this PR.

- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)


## Release note

The new *Connection details* overlay features a cleaner UI for
Elasticsearch endpoint URL and Cloud ID token retrieval. As well as the
new *"API key"* tab, which is a simplified interface for creating an API
key with all the default settings, except the expiration time is set to
90 days. If user wants a more granular API keys, there is a link which
navigates to the right section in Stack Management.


![connection-details](2223db63-748c-4620-9686-1b79c40037a7)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2024-04-23 16:35:04 +02:00
Sébastien Loix
192519d01f
[Cloud] Rename "Endpoints" to "Connection details" (#171982) 2023-11-27 15:58:42 +00:00
Sébastien Loix
3c58d392c0
[Cloud] Endpoint modal - fix label height (#169249) 2023-10-18 10:11:53 -07:00
Sébastien Loix
42742241f7
[Cloud] Fix endpoint label & add tooltip for Cloud ID (#169090) 2023-10-17 13:57:51 +01:00
Sébastien Loix
92a92fff67
[Cloud] ES endpoint discovery (#167122) 2023-09-28 04:20:53 -07:00