Fixes https://github.com/elastic/kibana/issues/149344
This PR migrates all plugins to packages automatically. It does this
using `node scripts/lint_packages` to automatically migrate
`kibana.json` files to `kibana.jsonc` files. By doing this automatically
we can simplify many build and testing procedures to only support
packages, and not both "packages" and "synthetic packages" (basically
pointers to plugins).
The majority of changes are in operations related code, so we'll be
having operations review this before marking it ready for review. The
vast majority of the code owners are simply pinged because we deleted
all `kibana.json` files and replaced them with `kibana.jsonc` files, so
we plan on leaving the PR ready-for-review for about 24 hours before
merging (after feature freeze), assuming we don't have any blockers
(especially from @elastic/kibana-core since there are a few core
specific changes, though the majority were handled in #149370).
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
The purpose of this PR is to make the spaces plugin an optional
dependency so that it can be disabled in future offerings.
In order to achieve this we are reintroducing the following config
option to disable spaces:
```yaml
xpack.spaces.enabled: false
```
This config option is only available in development mode while we
coordinate updating the rest of our plugins.
## Scope
In order to keep the scope manageable, only the following plugins have
been updated as part of this PR:
- `x-pack/plugins/alerting`
- `x-pack/plugins/security`
- `x-pack/plugins/spaces`
The following plugins will need to be updated separately, by working
with the corresponding teams:
- `x-pack/plugins/cases`
- `x-pack/plugins/enterprise_search`
- `x-pack/plugins/fleet`
- `x-pack/plugins/infra`
- `x-pack/plugins/lens`
- `x-pack/plugins/ml`
- `x-pack/plugins/observability`
- `x-pack/plugins/osquery`
- `x-pack/plugins/synthetics`
## Screenshots
### Kibana chrome without spaces selector
<img width="1073" alt="212935199-dd3bb035-b2f5-4fb6-96e9-5d2093c7992c"
src="https://user-images.githubusercontent.com/190132/213432556-18e1c159-1fb1-4808-ad12-47814de575ed.png">
### Simplified role management screen
<img width="1136" alt="Screenshot 2023-01-19 at 11 21 03"
src="https://user-images.githubusercontent.com/190132/213432595-0ae33abb-85e7-4044-82a2-6cc44304af0e.png">
## Dearest Reviewers 👋
I've been working on this branch with @mistic and @tylersmalley and
we're really confident in these changes. Additionally, this changes code
in nearly every package in the repo so we don't plan to wait for reviews
to get in before merging this. If you'd like to have a concern
addressed, please feel free to leave a review, but assuming that nobody
raises a blocker in the next 24 hours we plan to merge this EOD pacific
tomorrow, 12/22.
We'll be paying close attention to any issues this causes after merging
and work on getting those fixed ASAP. 🚀
---
The operations team is not confident that we'll have the time to achieve
what we originally set out to accomplish by moving to Bazel with the
time and resources we have available. We have also bought ourselves some
headroom with improvements to babel-register, optimizer caching, and
typescript project structure.
In order to make sure we deliver packages as quickly as possible (many
teams really want them), with a usable and familiar developer
experience, this PR removes Bazel for building packages in favor of
using the same JIT transpilation we use for plugins.
Additionally, packages now use `kbn_references` (again, just copying the
dx from plugins to packages).
Because of the complex relationships between packages/plugins and in
order to prepare ourselves for automatic dependency detection tools we
plan to use in the future, this PR also introduces a "TS Project Linter"
which will validate that every tsconfig.json file meets a few
requirements:
1. the chain of base config files extended by each config includes
`tsconfig.base.json` and not `tsconfig.json`
1. the `include` config is used, and not `files`
2. the `exclude` config includes `target/**/*`
3. the `outDir` compiler option is specified as `target/types`
1. none of these compiler options are specified: `declaration`,
`declarationMap`, `emitDeclarationOnly`, `skipLibCheck`, `target`,
`paths`
4. all references to other packages/plugins use their pkg id, ie:
```js
// valid
{
"kbn_references": ["@kbn/core"]
}
// not valid
{
"kbn_references": [{ "path": "../../../src/core/tsconfig.json" }]
}
```
5. only packages/plugins which are imported somewhere in the ts code are
listed in `kbn_references`
This linter is not only validating all of the tsconfig.json files, but
it also will fix these config files to deal with just about any
violation that can be produced. Just run `node scripts/ts_project_linter
--fix` locally to apply these fixes, or let CI take care of
automatically fixing things and pushing the changes to your PR.
> **Example:** [`64e93e5`
(#146212)](64e93e5806)
When I merged main into my PR it included a change which removed the
`@kbn/core-injected-metadata-browser` package. After resolving the
conflicts I missed a few tsconfig files which included references to the
now removed package. The TS Project Linter identified that these
references were removed from the code and pushed a change to the PR to
remove them from the tsconfig.json files.
## No bazel? Does that mean no packages??
Nope! We're still doing packages but we're pretty sure now that we won't
be using Bazel to accomplish the 'distributed caching' and 'change-based
tasks' portions of the packages project.
This PR actually makes packages much easier to work with and will be
followed up with the bundling benefits described by the original
packages RFC. Then we'll work on documentation and advocacy for using
packages for any and all new code.
We're pretty confident that implementing distributed caching and
change-based tasks will be necessary in the future, but because of
recent improvements in the repo we think we can live without them for
**at least** a year.
## Wait, there are still BUILD.bazel files in the repo
Yes, there are still three webpack bundles which are built by Bazel: the
`@kbn/ui-shared-deps-npm` DLL, `@kbn/ui-shared-deps-src` externals, and
the `@kbn/monaco` workers. These three webpack bundles are still created
during bootstrap and remotely cached using bazel. The next phase of this
project is to figure out how to get the package bundling features
described in the RFC with the current optimizer, and we expect these
bundles to go away then. Until then any package that is used in those
three bundles still needs to have a BUILD.bazel file so that they can be
referenced by the remaining webpack builds.
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
* [Archive Migration] x-pack-banners/multispace
I've the before() fn loading the new kbn archive
containing one config, for the default space.
Then, the fn creates a new space and changes the ui settings of this new space,
w/o using an archive.
* Move to enabled per:
https://github.com/elastic/kibana/pull/135783#issuecomment-1237228021
* Just run my stuff this go-round.
* Fixup.
* Drop new archive,
re-enable all tests,
skip the last test,
and add the filed bugs.
* Whoops
* Drop redundant test.
* Not sure what's what yet,
but I think perhaps an override is occuring.
* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'
* Change value in test and config.
* Drop double quotes,
seems to have caused parsing issue.
* One more try before asking in kibana-core
* try snake case
* back to space case but
without quotes in the config
* Just to see what happens I guess.
* Merge fixups.
* Change refs of "global_banner_text" to
"global banner text"
* Stop the shell expansion
* Drop duplicate.
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
* Fix banner not being displayed on login page
* fix and re-enable banner FTR tests
* revert commit to config file
* add unit test
* don't use whitespace for cli config value
Co-authored-by: Tre <wayne.seymour@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [build_ts_refs] improve caches, allow building a subset of projects
* cleanup project def script and update refs in type check script
* rename browser_bazel config to avoid kebab-case
* remove execInProjects() helper
* list references for tsconfig.types.json for api-extractor workload
* disable composite features of tsconfig.types.json for api-extractor
* set declaration: true to avoid weird debug error
* fix jest tests
Co-authored-by: spalger <spalger@users.noreply.github.com>
* refactor config deprecations to avoid config mutations
* remove dynamic access keys in core deprecations.
* refactor custom config deprecations to match the new signature
* improve config deprecations fixtures for nested keys
* add a test for xpack.banner config deprecations
* key --> path, add a test for invalid command
* Reducing wrapping divs from RenderingService
* Applying more styles to .kbnAppWrapper
Some being temporary and will need a better solution when introducing the page layout component
* Almost fixing tests for rendering service
Can’t figure out how to have a optional Observable
`Received: "kbnAppWrapper class-name”`
* Adding some comments
* [Dashboard] Using the APP_WRAPPER_CLASS
* fix test & ts types
* Fixin a few more tests that were using `.app-wrapper`
* Creating docs for new var and cleaning up some selectors
* Fixing reporting
* Fixing banner position and truncation
* Fixed CSS error in loading screen and jump in animation
* Fixing selectors in Canvas
* Remove unused var
* Added `APP_WRAPPER_CLASS` export from `server` and updated reporting to use it
* Fix monitoring icon clicks
* move APP_WRAPPER_CLASS definition to src/core/common
* Fixing Monitoring snapshots and wrapper class
* Moved `APP_WRAPPER_CLASS` utils but exported from `public` and `server`
* Remove old folder
* Fix dashboard test by only showing HR in edit mode
Co-authored-by: pgayvallet
Co-authored-by: tsullivan
* add base config for all the TS projects
* all the project use new tsconfig.project.json
* compile test files in the high-level tsconfig.json
* fix TS error in maps plugin
* fix TS error in infra plugin
* exclude mote test and test until folders
* uptime. do not import test code within prod code
* expressions. do not import test code within prod code
* data: export mocks from high level folder
* task_manager: comply with es client typings
* infra: remove unused enzyme_helpers
* check_ts_project requires "include" key
* ts_check should handle parent configs
* all ts configs should extend base one
* exclude test folders from plugins
* update patterns to fix ts_check errors
* Apply suggestions from code review
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* uptime: MountWithReduxProvider to test helpers
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* first draft
* update plugin list
* fix tsproject
* update bundle limits file
* remove unused start dep
* adapt imports
* POC of footer banner
* update styles, mostly
* plug banner to uiSettings
* adding some unit tests
* add tests on sort_fields
* cleanup sums in sass mixins
* some self review stuff
* update generated doc
* add tests for color field
* update chrome header test snapshots
* retrieve license info from the server
* switch from uiSettings to plugin config
* update plugin list description
* update default colors
* NIT
* add markdown support
* fix banner overlap in fullscreen mode
* change banner height to 32px
* change banner's font size to 14
* delete unused uiSettings
