mirror of
https://github.com/elastic/kibana.git
synced 2025-04-22 08:49:27 -04:00
1671 commits
Author | SHA1 | Message | Date | |
---|---|---|---|---|
|
c7cef4c95b
|
github-action: Add AsciiDoc freeze warning (#208534)
## Details ⚠️ This PR was created by an automated tool. Please review the changes carefully. ⚠️ Add a workflow that will comment on PRs with AsciiDoc changes. ## Why During the migration to Elastic Docs v3, the Docs team will focus exclusively on migrating content. To maintain consistency, prevent conflicts, and ensure a smoother transition we will freeze all AsciiDoc changes. This means you will get a warning when you create AsciiDoc changes in your PRs. See https://github.com/elastic/docs-builder/issues/281 for details If there are any questions, please reach out to the @elastic/docs-engineering --------- Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> |
||
|
b0a72e2b90
|
[Security AI] Move security-ai-prompt to package (#208787)
|
||
|
ce1904533d
|
[Scout] add maps test (#204607)
## Summary Add MapsPage to the scout core to be re-used by others. Add rudimentary docs to show how to run these tests. Added a `waitForRender` method. Add test id. --------- Co-authored-by: Robert Oskamp <traeluki@gmail.com> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co> Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co> |
||
|
8ffb2ff628
|
[Discover] In-table search (#206454)
- Closes https://github.com/elastic/kibana/issues/192360 ## Summary The default browser Find-in-page does not work great with the grid virtualization and our pagination and it can only find matches in rows which are currently displayed. This PR adds in-table search support to the grid so users can find matches in all grid rows (up to `500` sample docs/rows by default) and jump between them with "Previous"/"Next" buttons.  The implementation is extracted in a new package `@kbn/data-grid-in-table-search`. This would allow to use in-table search with `EuiDataGrid` on other pages of Kibana too. `Cmd+F` shortcut is overridden when one of grid elements is in focus otherwise we keep the browser default behaviour. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> |
||
|
70cd3cee7c
|
[ML] Adds simple flyout based file upload to Search (#206864)
A minimal version of the file upload tool which can be triggered via a uiAction. The trigger takes a callback to enable subsequent actions after the upload. This callback receives information about the upload, the index and data view created and information about the files: ``` { "index": "test9", "dataView": { "id": "a870ef68-a624-4df1-9d5d-fa62b75dd297", "title": "" }, "files": [ { "fileName": "farequote-tiny.csv", "docCount": 20, "fileFormat": "delimited" }, { "fileName": "farequote.csv", "docCount": 86275, "fileFormat": "delimited" } ] } ``` If `autoAddInference` is set with the name of an inference endpoint (`autoAddInference: '.elser-2-elasticsearch'`) the tool with automatically add a `semantic_text` to the mappings for tika files (pdf, txt docx) Currently embedded in the search app's home page and playground. In playgroubnd, after upload is complete and the flyout closed, the newly created index will be selected. https://github.com/user-attachments/assets/0589fa02-fb0e-400b-8e74-1eb9a993c6ba Multiple files can be uploaded at once. They must be of the same file format and the mappings cannot clash.   If more than once file has the same field but they are of different types, the files are considered incompatible. <img width="612" alt="image" src="https://github.com/user-attachments/assets/67307fd0-7d10-4eab-9e72-df133ebddcfe" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
4a00449bdc
|
SKA: Relocate core mock and test-helper modules (#208538)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 55 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/core-analytics-browser-mocks` | `src/core/packages/analytics/browser-mocks` | | `@kbn/core-analytics-server-mocks` | `src/core/packages/analytics/server-mocks` | | `@kbn/core-application-browser-mocks` | `src/core/packages/application/browser-mocks` | | `@kbn/core-apps-browser-mocks` | `src/core/packages/apps/browser-mocks` | | `@kbn/core-base-browser-mocks` | `src/core/packages/base/browser-mocks` | | `@kbn/core-base-server-mocks` | `src/core/packages/base/server-mocks` | | `@kbn/core-capabilities-browser-mocks` | `src/core/packages/capabilities/browser-mocks` | | `@kbn/core-capabilities-server-mocks` | `src/core/packages/capabilities/server-mocks` | | `@kbn/core-chrome-browser-mocks` | `src/core/packages/chrome/browser-mocks` | | `@kbn/core-deprecations-browser-mocks` | `src/core/packages/deprecations/browser-mocks` | | `@kbn/core-deprecations-server-mocks` | `src/core/packages/deprecations/server-mocks` | | `@kbn/core-doc-links-browser-mocks` | `src/core/packages/doc-links/browser-mocks` | | `@kbn/core-doc-links-server-mocks` | `src/core/packages/doc-links/server-mocks` | | `@kbn/core-elasticsearch-client-server-mocks` | `src/core/packages/elasticsearch/client-server-mocks` | | `@kbn/core-elasticsearch-server-mocks` | `src/core/packages/elasticsearch/server-mocks` | | `@kbn/core-environment-server-mocks` | `src/core/packages/environment/server-mocks` | | `@kbn/core-execution-context-browser-mocks` | `src/core/packages/execution-context/browser-mocks` | | `@kbn/core-execution-context-server-mocks` | `src/core/packages/execution-context/server-mocks` | | `@kbn/core-fatal-errors-browser-mocks` | `src/core/packages/fatal-errors/browser-mocks` | | `@kbn/core-http-browser-mocks` | `src/core/packages/http/browser-mocks` | | `@kbn/core-http-context-server-mocks` | `src/core/packages/http/context-server-mocks` | | `@kbn/core-http-resources-server-mocks` | `src/core/packages/http/resources-server-mocks` | | `@kbn/core-http-router-server-mocks` | `src/core/packages/http/router-server-mocks` | | `@kbn/core-http-server-mocks` | `src/core/packages/http/server-mocks` | | `@kbn/core-i18n-browser-mocks` | `src/core/packages/i18n/browser-mocks` | | `@kbn/core-i18n-server-mocks` | `src/core/packages/i18n/server-mocks` | | `@kbn/core-injected-metadata-browser-mocks` | `src/core/packages/injected-metadata/browser-mocks` | | `@kbn/core-integrations-browser-mocks` | `src/core/packages/integrations/browser-mocks` | | `@kbn/core-lifecycle-browser-mocks` | `src/core/packages/lifecycle/browser-mocks` | | `@kbn/core-lifecycle-server-mocks` | `src/core/packages/lifecycle/server-mocks` | | `@kbn/core-logging-browser-mocks` | `src/core/packages/logging/browser-mocks` | | `@kbn/core-logging-server-mocks` | `src/core/packages/logging/server-mocks` | | `@kbn/core-metrics-collectors-server-mocks` | `src/core/packages/metrics/collectors-server-mocks` | | `@kbn/core-metrics-server-mocks` | `src/core/packages/metrics/server-mocks` | | `@kbn/core-node-server-mocks` | `src/core/packages/node/server-mocks` | | `@kbn/core-notifications-browser-mocks` | `src/core/packages/notifications/browser-mocks` | | `@kbn/core-overlays-browser-mocks` | `src/core/packages/overlays/browser-mocks` | | `@kbn/core-plugins-browser-mocks` | `src/core/packages/plugins/browser-mocks` | | `@kbn/core-plugins-server-mocks` | `src/core/packages/plugins/server-mocks` | | `@kbn/core-preboot-server-mocks` | `src/core/packages/preboot/server-mocks` | | `@kbn/core-rendering-browser-mocks` | `src/core/packages/rendering/browser-mocks` | | `@kbn/core-rendering-server-mocks` | `src/core/packages/rendering/server-mocks` | | `@kbn/core-saved-objects-api-server-mocks` | `src/core/packages/saved-objects/api-server-mocks` | | `@kbn/core-saved-objects-base-server-mocks` | `src/core/packages/saved-objects/base-server-mocks` | | `@kbn/core-saved-objects-browser-mocks` | `src/core/packages/saved-objects/browser-mocks` | | `@kbn/core-saved-objects-import-export-server-mocks` | `src/core/packages/saved-objects/import-export-server-mocks` | | `@kbn/core-saved-objects-migration-server-mocks` | `src/core/packages/saved-objects/migration-server-mocks` | | `@kbn/core-saved-objects-server-mocks` | `src/core/packages/saved-objects/server-mocks` | | `@kbn/core-status-server-mocks` | `src/core/packages/status/server-mocks` | | `@kbn/core-test-helpers-kbn-server` | `src/dev/packages/core-test-helpers-kbn-server` | | `@kbn/core-test-helpers-model-versions` | `src/dev/packages/core-test-helpers-model-versions` | | `@kbn/core-theme-browser-mocks` | `src/core/packages/theme/browser-mocks` | | `@kbn/core-ui-settings-browser-mocks` | `src/core/packages/ui-settings/browser-mocks` | | `@kbn/core-ui-settings-server-mocks` | `src/core/packages/ui-settings/server-mocks` | | `@kbn/core-usage-data-server-mocks` | `src/core/packages/usage-data/server-mocks` | <details > <summary>Updated references</summary> ``` ./.github/codeql/codeql-config.yml ./package.json ./packages/kbn-ts-projects/config-paths.json ./src/core/packages/analytics/browser-mocks/jest.config.js ./src/core/packages/analytics/server-mocks/jest.config.js ./src/core/packages/application/browser-mocks/jest.config.js ./src/core/packages/apps/browser-mocks/jest.config.js ./src/core/packages/base/browser-mocks/jest.config.js ./src/core/packages/base/server-mocks/jest.config.js ./src/core/packages/capabilities/browser-mocks/jest.config.js ./src/core/packages/capabilities/server-mocks/jest.config.js ./src/core/packages/chrome/browser-mocks/jest.config.js ./src/core/packages/deprecations/browser-mocks/jest.config.js ./src/core/packages/deprecations/server-mocks/jest.config.js ./src/core/packages/doc-links/browser-mocks/jest.config.js ./src/core/packages/doc-links/server-mocks/jest.config.js ./src/core/packages/elasticsearch/client-server-mocks/jest.config.js ./src/core/packages/elasticsearch/server-mocks/jest.config.js ./src/core/packages/environment/server-mocks/jest.config.js ./src/core/packages/execution-context/browser-mocks/jest.config.js ./src/core/packages/execution-context/server-mocks/jest.config.js ./src/core/packages/fatal-errors/browser-mocks/jest.config.js ./src/core/packages/http/browser-mocks/jest.config.js ./src/core/packages/http/context-server-mocks/jest.config.js ./src/core/packages/http/resources-server-mocks/jest.config.js ./src/core/packages/http/router-server-mocks/jest.config.js ./src/core/packages/http/server-mocks/jest.config.js ./src/core/packages/i18n/browser-mocks/jest.config.js ./src/core/packages/i18n/server-mocks/jest.config.js ./src/core/packages/injected-metadata/browser-mocks/jest.config.js ./src/core/packages/integrations/browser-mocks/jest.config.js ./src/core/packages/lifecycle/browser-mocks/jest.config.js ./src/core/packages/lifecycle/server-mocks/jest.config.js ./src/core/packages/logging/browser-mocks/jest.config.js ./src/core/packages/logging/server-mocks/jest.config.js ./src/core/packages/metrics/collectors-server-mocks/jest.config.js ./src/core/packages/metrics/server-mocks/jest.config.js ./src/core/packages/node/server-mocks/jest.config.js ./src/core/packages/notifications/browser-mocks/jest.config.js ./src/core/packages/overlays/browser-mocks/jest.config.js ./src/core/packages/plugins/browser-mocks/jest.config.js ./src/core/packages/plugins/server-mocks/jest.config.js ./src/core/packages/preboot/server-mocks/jest.config.js ./src/core/packages/rendering/browser-mocks/jest.config.js ./src/core/packages/rendering/server-mocks/jest.config.js ./src/core/packages/saved-objects/api-server-mocks/jest.config.js ./src/core/packages/saved-objects/base-server-mocks/jest.config.js ./src/core/packages/saved-objects/browser-mocks/jest.config.js ./src/core/packages/saved-objects/import-export-server-mocks/jest.config.js ./src/core/packages/saved-objects/migration-server-mocks/jest.config.js ./src/core/packages/saved-objects/server-mocks/jest.config.js ./src/core/packages/status/server-mocks/jest.config.js ./src/core/packages/theme/browser-mocks/jest.config.js ./src/core/packages/ui-settings/browser-mocks/jest.config.js ./src/core/packages/ui-settings/server-mocks/jest.config.js ./src/core/packages/usage-data/server-mocks/jest.config.js ./src/core/system/tsconfig.type_check.json ./src/dev/packages/core-test-helpers-kbn-server/jest.config.js ./src/dev/packages/core-test-helpers-model-versions/jest.config.js ./src/dev/tsconfig.type_check.json ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/plugins/private/interactive_setup/tsconfig.type_check.json ./src/platform/plugins/shared/console/tsconfig.type_check.json ./src/plugins/kibana_usage_collection/tsconfig.type_check.json ./src/plugins/saved_objects_management/tsconfig.type_check.json ./src/plugins/telemetry/tsconfig.type_check.json ./src/plugins/usage_collection/tsconfig.type_check.json ./tsconfig.base.json ./tsconfig.base.type_check.json ./tsconfig.refs.json ./x-pack/platform/plugins/private/index_lifecycle_management/tsconfig.type_check.json ./x-pack/platform/plugins/private/remote_clusters/tsconfig.type_check.json ./x-pack/platform/plugins/private/snapshot_restore/tsconfig.type_check.json ./x-pack/platform/plugins/private/watcher/tsconfig.type_check.json ./x-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.type_check.json ./x-pack/platform/plugins/shared/fleet/tsconfig.type_check.json ./x-pack/platform/plugins/shared/security/tsconfig.type_check.json ./x-pack/platform/plugins/shared/spaces/tsconfig.type_check.json ./x-pack/plugins/actions/tsconfig.type_check.json ./x-pack/plugins/aiops/tsconfig.type_check.json ./x-pack/plugins/alerting/tsconfig.type_check.json ./x-pack/plugins/cases/tsconfig.type_check.json ./x-pack/plugins/enterprise_search/tsconfig.type_check.json ./x-pack/plugins/integration_assistant/tsconfig.type_check.json ./x-pack/plugins/ml/tsconfig.type_check.json ./x-pack/plugins/observability_solution/apm/tsconfig.type_check.json ./x-pack/plugins/observability_solution/apm_data_access/tsconfig.type_check.json ./x-pack/plugins/observability_solution/entity_manager/tsconfig.type_check.json ./x-pack/plugins/observability_solution/exploratory_view/tsconfig.type_check.json ./x-pack/plugins/observability_solution/observability/tsconfig.type_check.json ./x-pack/plugins/observability_solution/slo/tsconfig.type_check.json ./x-pack/plugins/observability_solution/synthetics/tsconfig.type_check.json ./x-pack/plugins/observability_solution/uptime/tsconfig.type_check.json ./x-pack/plugins/rule_registry/tsconfig.type_check.json ./x-pack/plugins/search_playground/tsconfig.type_check.json ./x-pack/plugins/serverless_search/tsconfig.type_check.json ./x-pack/plugins/stack_alerts/tsconfig.type_check.json ./x-pack/plugins/stack_connectors/tsconfig.type_check.json ./x-pack/plugins/task_manager/tsconfig.type_check.json ./x-pack/plugins/transform/tsconfig.type_check.json ./x-pack/solutions/observability/plugins/dataset_quality/tsconfig.type_check.json ./x-pack/solutions/security/packages/security-solution/ecs_data_quality_dashboard/tsconfig.type_check.json ./x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.type_check.json ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/core/packages/analytics/browser-mocks/jest.config.js:12 src/core/packages/analytics/browser-mocks/tsconfig.json:2 src/core/packages/analytics/server-mocks/jest.config.js:12 src/core/packages/analytics/server-mocks/tsconfig.json:2 src/core/packages/application/browser-mocks/jest.config.js:12 src/core/packages/application/browser-mocks/tsconfig.json:2 src/core/packages/apps/browser-mocks/jest.config.js:12 src/core/packages/apps/browser-mocks/tsconfig.json:2 src/core/packages/base/browser-mocks/jest.config.js:12 src/core/packages/base/browser-mocks/tsconfig.json:2 src/core/packages/base/server-mocks/jest.config.js:12 src/core/packages/base/server-mocks/tsconfig.json:2 src/core/packages/capabilities/browser-mocks/jest.config.js:12 src/core/packages/capabilities/browser-mocks/tsconfig.json:2 src/core/packages/capabilities/server-mocks/jest.config.js:12 src/core/packages/capabilities/server-mocks/tsconfig.json:2 src/core/packages/chrome/browser-mocks/jest.config.js:12 src/core/packages/chrome/browser-mocks/tsconfig.json:2 src/core/packages/deprecations/browser-mocks/jest.config.js:12 src/core/packages/deprecations/browser-mocks/tsconfig.json:2 src/core/packages/deprecations/server-mocks/jest.config.js:12 src/core/packages/deprecations/server-mocks/tsconfig.json:2 src/core/packages/doc-links/browser-mocks/jest.config.js:12 src/core/packages/doc-links/browser-mocks/tsconfig.json:2 src/core/packages/doc-links/server-mocks/jest.config.js:12 src/core/packages/doc-links/server-mocks/tsconfig.json:2 src/core/packages/elasticsearch/client-server-mocks/jest.config.js:12 src/core/packages/elasticsearch/client-server-mocks/tsconfig.json:2 src/core/packages/elasticsearch/server-mocks/jest.config.js:12 src/core/packages/elasticsearch/server-mocks/tsconfig.json:2 src/core/packages/environment/server-mocks/jest.config.js:12 src/core/packages/environment/server-mocks/tsconfig.json:2 src/core/packages/execution-context/browser-mocks/jest.config.js:12 src/core/packages/execution-context/browser-mocks/tsconfig.json:2 src/core/packages/execution-context/server-mocks/jest.config.js:12 src/core/packages/execution-context/server-mocks/tsconfig.json:2 src/core/packages/fatal-errors/browser-mocks/jest.config.js:12 src/core/packages/fatal-errors/browser-mocks/tsconfig.json:2 src/core/packages/http/browser-mocks/jest.config.js:12 src/core/packages/http/browser-mocks/tsconfig.json:2 src/core/packages/http/context-server-mocks/jest.config.js:12 src/core/packages/http/context-server-mocks/tsconfig.json:2 src/core/packages/http/resources-server-mocks/jest.config.js:12 src/core/packages/http/resources-server-mocks/tsconfig.json:2 src/core/packages/http/router-server-mocks/jest.config.js:12 src/core/packages/http/router-server-mocks/tsconfig.json:2 src/core/packages/http/server-mocks/jest.config.js:12 src/core/packages/http/server-mocks/tsconfig.json:2 src/core/packages/i18n/browser-mocks/jest.config.js:12 src/core/packages/i18n/browser-mocks/tsconfig.json:2 src/core/packages/i18n/server-mocks/jest.config.js:12 src/core/packages/i18n/server-mocks/tsconfig.json:2 src/core/packages/injected-metadata/browser-mocks/jest.config.js:12 src/core/packages/injected-metadata/browser-mocks/tsconfig.json:2 src/core/packages/integrations/browser-mocks/jest.config.js:12 src/core/packages/integrations/browser-mocks/tsconfig.json:2 src/core/packages/lifecycle/browser-mocks/jest.config.js:12 src/core/packages/lifecycle/browser-mocks/tsconfig.json:2 src/core/packages/lifecycle/server-mocks/jest.config.js:12 src/core/packages/lifecycle/server-mocks/tsconfig.json:2 src/core/packages/logging/browser-mocks/jest.config.js:12 src/core/packages/logging/browser-mocks/tsconfig.json:2 src/core/packages/logging/server-mocks/jest.config.js:12 src/core/packages/logging/server-mocks/tsconfig.json:2 src/core/packages/metrics/collectors-server-mocks/jest.config.js:12 src/core/packages/metrics/collectors-server-mocks/tsconfig.json:2 src/core/packages/metrics/server-mocks/jest.config.js:12 src/core/packages/metrics/server-mocks/tsconfig.json:2 src/core/packages/node/server-mocks/jest.config.js:12 src/core/packages/node/server-mocks/tsconfig.json:2 src/core/packages/notifications/browser-mocks/jest.config.js:12 src/core/packages/notifications/browser-mocks/tsconfig.json:2 src/core/packages/overlays/browser-mocks/jest.config.js:12 src/core/packages/overlays/browser-mocks/tsconfig.json:2 src/core/packages/plugins/browser-mocks/jest.config.js:12 src/core/packages/plugins/browser-mocks/tsconfig.json:2 src/core/packages/plugins/server-mocks/jest.config.js:12 src/core/packages/plugins/server-mocks/tsconfig.json:2 src/core/packages/preboot/server-mocks/jest.config.js:12 src/core/packages/preboot/server-mocks/tsconfig.json:2 src/core/packages/rendering/browser-mocks/jest.config.js:12 src/core/packages/rendering/browser-mocks/tsconfig.json:2 src/core/packages/rendering/server-mocks/jest.config.js:12 src/core/packages/rendering/server-mocks/tsconfig.json:2 src/core/packages/saved-objects/api-server-mocks/jest.config.js:12 src/core/packages/saved-objects/api-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/base-server-mocks/jest.config.js:12 src/core/packages/saved-objects/base-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/browser-mocks/jest.config.js:12 src/core/packages/saved-objects/browser-mocks/tsconfig.json:2 src/core/packages/saved-objects/import-export-server-mocks/jest.config.js:12 src/core/packages/saved-objects/import-export-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/migration-server-mocks/jest.config.js:12 src/core/packages/saved-objects/migration-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/server-mocks/jest.config.js:12 src/core/packages/saved-objects/server-mocks/tsconfig.json:2 src/core/packages/status/server-mocks/jest.config.js:12 src/core/packages/status/server-mocks/tsconfig.json:2 src/core/packages/theme/browser-mocks/jest.config.js:12 src/core/packages/theme/browser-mocks/tsconfig.json:2 src/core/packages/ui-settings/browser-mocks/jest.config.js:12 src/core/packages/ui-settings/browser-mocks/tsconfig.json:2 src/core/packages/ui-settings/server-mocks/jest.config.js:12 src/core/packages/ui-settings/server-mocks/tsconfig.json:2 src/core/packages/usage-data/server-mocks/jest.config.js:12 src/core/packages/usage-data/server-mocks/tsconfig.json:2 src/dev/packages/core-test-helpers-kbn-server/jest.config.js:12 src/dev/packages/core-test-helpers-kbn-server/tsconfig.json:2 src/dev/packages/core-test-helpers-model-versions/jest.config.js:12 src/dev/packages/core-test-helpers-model-versions/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com> |
||
|
9ce2dd8df9
|
Additional prototype pollution protections (#206073)
## Summary 1. Extends the server-side prototype pollution protections introduced in https://github.com/elastic/kibana/pull/190716 to include `Array.prototype`. 2. Applies the same prototype pollution protections to the client-side. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] Sealing prototypes on the client can lead to failures in third-party dependencies. I'm relying on sufficient functional test coverage to detect issues here. As a result, these protections are disabled by default for now, and can be controlled via setting `server.prototypeHardening: true/false` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
|
06d16614a9
|
[Automatic Import] rename plugin to automatic import (#207325)
## Summary Rename `integration-assistant` plugin to `automatic-import`. |
||
|
c8bd387668
|
Add a warning callout when deleting managed assets (#207329) | ||
|
c03313a57c
|
[Asset inventory] Add initial cypress test (#207647)
## Summary This PR introduces initial cypress test and also a basic test was configured to test for the presence of the Asset Inventory page when the Feature Flag `assetInventoryUXEnabled` is set. |
||
|
52b7bc6f06
|
[HTTP] Add a circuit breaker for the HTTP server (#190684)
This PR resolves #194605 and closes #170132 and brings the following changes: - changed ELU metrics evaluation used for autoscaling; - a rate limiter to throttle incoming requests when under a high load; - a configuration option to exclude some routes from the rate limiter. |
||
|
d5764b3ee8
|
SKA: Follow-up relocation (#207041)
## Summary * @kbn/observability-ai-assistant-plugin: Simplify location ``` x-pack/platform/plugins/shared/observability_solution/observability_ai_assistant # becomes x-pack/platform/plugins/shared/observability_ai_assistant ``` * @kbn/search-shared-ui: Simplify location ``` x-pack/solutions/search/packages/search/shared_ui # becomes x-pack/solutions/search/packages/shared_ui ``` <details > <summary>Updated references</summary> ``` ./.github/paths-labeller.yml ./docs/developer/plugin-list.asciidoc ./package.json ./packages/kbn-relocate/utils/transforms.ts ./packages/kbn-ts-projects/config-paths.json ./src/dev/storybook/aliases.ts ./src/platform/packages/private/kbn-repo-packages/package-map.json ./tsconfig.base.json ./x-pack/.i18nrc.json ./x-pack/platform/plugins/shared/observability_ai_assistant/jest.config.js ./x-pack/solutions/search/packages/shared_ui/jest.config.js ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` x-pack/platform/plugins/shared/observability_ai_assistant/jest.config.js:10 x-pack/platform/plugins/shared/observability_ai_assistant/tsconfig.json:2 x-pack/platform/plugins/shared/observability_ai_assistant/tsconfig.json:7 x-pack/solutions/search/packages/shared_ui/jest.config.js:16 x-pack/solutions/search/packages/shared_ui/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
ed0579469c
|
Move unified search ownership to Presentation Team (#208381)
## Summary This PR moves the ownership of Unified Search files code to the Presentation team |
||
|
a2d36067e9
|
[Cloud Security] Deleting K8S Dashboard (#207127)
## Summary As K8S Dashboard is currently hidden on main , the code serves no purpose other than potentially causing Tech debts whenever a refactor or a migration happens. As such its better to remove it completely. In case we want to bring it back later we will just pull it from git history > [!CAUTION] > **This should only affect Serverless and Main, 8.x.x should still be able to see and access K8S Dashboard** ## Related Tickets - https://github.com/elastic/security-team/issues/11418 - https://github.com/elastic/security-team/issues/10735 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Paulo Silva <paulo.henrique@elastic.co> Co-authored-by: Maxim Kholod <maxim.kholod@elastic.co> |
||
|
b84c65c095
|
[ES|QL] Dashboard variables (#202875)
## Summary Closes https://github.com/elastic/kibana/issues/203967 Supports dashboard variables in ES|QL charts. This PR introduces the first phase of ES|QL controls. In this phase: - the flow starts from Lens ES|QL editor (and no vice-versa, this will happen on a later phase after we discuss some technical details with ES) - it is only available for dashboards (we want to include them in other apps as Discover but this is the next phase driven by the presentation team) - it supports variables for intervals, fields and values. I haven't added support for functions. I am going to do it after this PR being merged (there are some business questions I want to answer first) For more info check this [deck](https://docs.google.com/presentation/d/1qSbWLSoC5SseXuLix763vpp8sa7ikp3pQTbHImEHBoc)  ### Implementation details - There is a new service, the ESQLVariables service that is responsible for ES|QL variables. I isolated this to a new plugin owned by the ES|QL team for cleaner code and for avoiding circular dependencies - A new ESQL_CONTROL type got created. It follows the exact same logic as the rest controls. No changes in the architecture here. - The creation of the controls (the control forms) have been added in the esql plugin. - Lens has small changes: - The support of variables in the textBased datasource - Two callbacks needed to be called after the creation / cancellation of an ES|QL control ### Types of ES|QL variables We have 2 types: - Static Values (the user gives a list of values with his own responsibility). As the flow starts from the editor we can identify what they most possibly want to do and we give the user some options but they have the freedom to do as they want. A basic validation has been added too. - Values from an ES|QL query (the user gives an ES|QL query that generates the values). As the flow starts from the editor we can suggest a query for the users but they can always change it as they wish. <img width="1168" alt="image" src="https://github.com/user-attachments/assets/cc28beb8-111c-43ad-9f26-865bc62ae512" /> ### Example of a control creation from the editor  ### Release note ES|QL charts now allow the creation of controls in dashboards. You can control a part of the query such as a field, an interval or a value. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com> Co-authored-by: Devon Thomson <devon.thomson@elastic.co> |
||
|
86666bf790
|
[Security Solution] Connector selector onboarding (#203742)
## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. https://github.com/user-attachments/assets/6d7527d1-dc8d-4f3a-9b03-cfd0022701d2 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
2dea4e6a19
|
[Chore] Fix codeowners from SecuritySolution -> Security (#207969)
We have some functional/API tests that were attributed to the wrong team. This was [called out](https://github.com/elastic/kibana/pull/194819/files#r1792639304) in the inciting PR, but was never addressed. There are probably some other misattributions here, and likely more due to the Security/Security Solution confusion, but these are the ones I know about right now. |
||
|
7f98b6bf5d
|
[Inference AI Connector] Added elastic provider for EIS and enhancements (#205672)
## Summary Current PR creates a new platform shared plugin named `inference_endpoint` to expose in Kibana the new internal API `_inference/_services`, which returns the list of inference providers with the configuration settings. Changed `@kbn/inference_endpoint_ui_common` package to fetch dynamically the list of providers by using the route introduced in `inference_endpoint` plugin. Added fields settings filter based on the selected task in the `supported_task_types`. Cleaned up the types consolidating all in the package `@kbn/inference_endpoint_ui_common`. Changed .inference connector to use `unified_completion` subAction for selected `chat_completion` task type. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co> |
||
|
368475e8e5
|
[One Discover] Display stacktrace in the logs overview tab (#204521)
## 📓 Summary Adds a new section to the overview tab in the log details flyout in Discover to display stacktrace information for logs and exceptions. In a follow-up, the stacktrace could be moved to a new tab in the log details flyout and actions can be added to the stacktrace (and quality) icons in the document table to open the relevant sections in the flyout. Closes https://github.com/elastic/kibana/issues/190460 ### APM - Log stacktrace (library frames) <img width="1470" alt="image" src="https://github.com/user-attachments/assets/8991f882-d329-4bc5-aa37-424576bcee72" /> ### APM - Exception (with cause) <img width="1476" alt="image" src="https://github.com/user-attachments/assets/cfbf24a7-6f82-48f1-b275-5aac977411ac" /> ### APM - Exception (simple stacktrace) <img width="1474" alt="image" src="https://github.com/user-attachments/assets/fc0306c4-5fcd-4b74-bb0d-c1784a48d677" /> ### Apache Tomcat Integration (Catalina) - Stacktrace <img width="1472" alt="image" src="https://github.com/user-attachments/assets/281f1822-faea-4e2d-9515-c11a9ee12f50" /> ## 📝 Notes for reviewers - The `@kbn/apm-types` package was marked as platform / shared as it's being used by the [unified_doc_viewer](https://github.com/elastic/kibana/blob/main/src/plugins/unified_doc_viewer/kibana.jsonc) - The code used to render stacktraces in APM was moved into a new `@kbn/event-stacktrace` package as it is reused in the `unified_doc_viewer` - The code used to render metadata table in APM was moved into a new `@kbn/key-value-metadata-table` package ## 🧪 Testing instructions The deployed environments have sample logs that can be used (time range: Jan 1, 2025 - now). For a local setup, please follow the instructions below: 1. Ingest sample logs with stacktraces ([gist](https://gist.github.com/gbamparop/0da21ca7f65b24c4a9c071ce9e9b97b0)). Please note that these are test data and some fields that are not used by stacktraces might not be consistent 2. View relevant logs in Discover (Query: `service.name: "synth-node-0" OR apache_tomcat :*`, Time range: Jan 1, 2025 - now) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
3498d509ef
|
[Profiling] Migrate Profiling Cypress tests to on_merge from on_merge_unsupported_ftrs (#206727)
## Summary Closes https://github.com/elastic/kibana/issues/206664 This PR moves Profiling Cypress tests to be run on the main pipeline instead of the unsupported one. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
30bb71a516
|
[Security Solution] Handle negative lookback in rule upgrade flyout (#204317)
**Fixes: https://github.com/elastic/kibana/issues/202715** **Fixes: https://github.com/elastic/kibana/issues/204714** ## Summary This PR makes inconsistent/wrong rule's look-back duration prominent for a user. It falls back to a default 1 minute value in rule upgrade workflow. ## Details ### Negative/wrong `lookback` problem There is a difference between rule schedule value in a saved object and value represented to users - Saved object (and rule management API) has `interval`, `from` and `to` fields representing rule schedule. `interval` shows how often a rule runs in task runner. `from` and `to` stored in date math format like `now-10m` represent a date time range used to fetch source events. Task manager strives to run rules exactly every `interval` but it's not always possible due to multiple reasons like system load and various delays. To avoid any gaps to appear `from` point in time usually stands earlier than current time minus `interval`, for example `interval` is `10 minutes` and `from` is `now-12m` meaning rule will analyze events starting from 12 minutes old. `to` represents the latest point in time source events will be analyzed. - Diffable rule and UI represent rule schedule as `interval` and `lookback`. Where `interval` is the same as above and `lookback` and a time duration before current time minus `interval`. For example `interval` is `10 minutes` and lookback is `2 minutes` it means a rule will analyzing events starting with 12 minutes old until the current moment in time. Literally `interval`, `from` and `to` mean a rule runs every `interval` and analyzes events starting from `from` until `to`. Technically `from` and `to` may not have any correlation with `interval`, for example a rule may analyze one year old events. While it's reasonable for manual rule runs and gap remediation the same approach doesn't work well for usual rule schedule. Transformation between `interval`/`from`/`to` and `interval`/`lookback` works only when `to` is equal the current moment in time i.e. `now`. Rule management APIs allow to set any `from` and `to` values resulting in inconsistent rule schedule. Transformed `interval`/`lookback` value won't represent real time interval used to fetch source events for analysis. On top of that negative `lookback` value may puzzle users on the meaning of the negative sign. ### Prebuilt rules with `interval`/`from`/`to` resulting in negative `lookback` Some prebuilt rules have such `interval`, `from` and `to` field values thatnegative `lookback` is expected, for example `Multiple Okta Sessions Detected for a Single User`. It runs every `60 minutes` but has `from` field set to `now-30m` and `to` equals `now`. In the end we have `lookback` equals `to` - `from` - `interval` = `30 minutes` - `60 minutes` = `-30 minutes`. Our UI doesn't handle negative `lookback` values. It simply discards a negative sign and substitutes the rest for editing. In the case above `30 minutes` will be suggested for editing. Saving the form will result in changing `from` to `now-90m` <img width="1712" alt="image" src="https://github.com/user-attachments/assets/05519743-9562-4874-8a73-5596eeccacf2" /> ### Changes in this PR This PR mitigates rule schedule inconsistencies caused by `to` fields not using the current point in time i.e. `now`. The following was done - `DiffableRule`'s `rule_schedule` was changed to have `interval`, `from` and `to` fields instead of `interval` and `lookback` - `_perform` rule upgrade API endpoint was adapted to the new `DIffableRule`'s `rule_schedule` - Rule upgrade flyout calculates and shows `interval` and `lookback` in Diff View, readonly view and field form when `lookback` is non-negative and `to` equals `now` - Rule upgrade flyout shows `interval`, `from` and `to` in Diff View, readonly view and field form when `to` isn't equal `now` or calculated `lookback` is negative - Rule upgrade flyout shows a warning when `to` isn't equal `now` or calculated `lookback` is negative - Rule upgrade flyout's JSON Diff shows `interval` and `lookback` when `lookback` is non-negative and `to` equals `now` and shows `interval`, `from` and `to` in any other case - Rule details page shows `interval`, `from` and `to` in Diff View, readonly view and field form when `to` isn't equal `now` or calculated `lookback` is negative - `maxValue` was added to `ScheduleItemField` to have an ability to restrict input at reasonable values ## Screenshots - Rule upgrade workflow (negative look-back) <img width="2558" alt="Screenshot 2025-01-02 at 13 16 59" src="https://github.com/user-attachments/assets/b8bf727f-11ca-424f-892b-b024ba7f847a" /> <img width="2553" alt="Screenshot 2025-01-02 at 13 17 20" src="https://github.com/user-attachments/assets/9f751ea4-0ce0-4a23-a3b7-0a16494d957e" /> <img width="2558" alt="Screenshot 2025-01-02 at 13 18 24" src="https://github.com/user-attachments/assets/6908ab02-4011-4a6e-85ce-e60d5eac7993" /> - Rule upgrade workflow (positive look-back) <img width="2555" alt="Screenshot 2025-01-02 at 13 19 12" src="https://github.com/user-attachments/assets/06208210-c6cd-4842-8aef-6ade5d13bd36" /> <img width="2558" alt="Screenshot 2025-01-02 at 13 25 31" src="https://github.com/user-attachments/assets/aed38bb0-ccfb-479a-bb3b-e5442c518e63" /> - JSON view <img width="2559" alt="Screenshot 2025-01-02 at 13 31 37" src="https://github.com/user-attachments/assets/07575a81-676f-418e-8b98-48eefe11ab00" /> - Rule details page <img width="2555" alt="Screenshot 2025-01-02 at 13 13 16" src="https://github.com/user-attachments/assets/e977b752-9d50-4049-917a-af2e8e3f0dfe" /> <img width="2558" alt="Screenshot 2025-01-02 at 13 14 10" src="https://github.com/user-attachments/assets/06d6f477-5730-48ca-a240-b5e7592bf173" /> ## How to test? - Ensure the `prebuiltRulesCustomizationEnabled` feature flag is enabled - Allow internal APIs via adding `server.restrictInternalApis: false` to `kibana.dev.yaml` - Clear Elasticsearch data - Run Elasticsearch and Kibana locally (do not open Kibana in a web browser) - Install an outdated version of the `security_detection_engine` Fleet package ```bash curl -X POST --user elastic:changeme -H 'Content-Type: application/json' -H 'kbn-xsrf: 123' -H "elastic-api-version: 2023-10-31" -d '{"force":true}' http://localhost:5601/kbn/api/fleet/epm/packages/security_detection_engine/8.14.1 ``` - Install prebuilt rules ```bash curl -X POST --user elastic:changeme -H 'Content-Type: application/json' -H 'kbn-xsrf: 123' -H "elastic-api-version: 1" -d '{"mode":"ALL_RULES"}' http://localhost:5601/kbn/internal/detection_engine/prebuilt_rules/installation/_perform ``` - Set "inconsistent" rule schedule for `Suspicious File Creation via Kworker` rule by running a query below ```bash curl -X PATCH --user elastic:changeme -H "Content-Type: application/json" -H "elastic-api-version: 2023-10-31" -H "kbn-xsrf: 123" -d '{"rule_id":"ae343298-97bc-47bc-9ea2-5f2ad831c16e","interval":"10m","from":"now-5m","to":"now-2m"}' http://localhost:5601/kbn/api/detection_engine/rules ``` - Open rule upgrade flyout for `Suspicious File Creation via Kworker` rule --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
|
11d5c96b44
|
🌊 Streams: Make tests platform agnostic (#206979)
Fixes https://github.com/elastic/streams-program/issues/29 This PR makes the streams API tests platform agnostic. Some changes besides basic moving over were required, documented in code |
||
|
175cfb8b62
|
Add keyword builder pipeline | ||
|
64f872e617
|
[Rules migration] Threat Hunting team as a codeowner for SIEM Migrations integration tests (#207067)
## Summary [Internal link](https://github.com/elastic/security-team/issues/10820) to the feature details Set @elastic/security-threat-hunting as codewoners of the SIEM Migrations integration tests folder. > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. |
||
|
ba92d08a58
|
[APM] Migrate APM Cypress tests to on_merge from on_merge_unsupported_ftrs (#203991)
## Summary Closes https://github.com/elastic/kibana/issues/203837 [Internal] Closes https://github.com/elastic/observability-dev/issues/4126?reload=1?reload=1 This PR moves APM Cypress tests to be run on the main pipeline instead of the unsupported one. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
b21a70dabb
|
SKA: Relocate @kbn/grid-layout (#206821)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 1 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/grid-layout` | `src/platform/packages/private/kbn-grid-layout` | <details > <summary>Updated references</summary> ``` ./.i18nrc.json ./examples/grid_example/tsconfig.type_check.json ./package.json ./packages/kbn-ts-projects/config-paths.json ./src/platform/packages/private/kbn-grid-layout/jest.config.js ./src/platform/packages/private/kbn-repo-packages/package-map.json ./tsconfig.base.json ./tsconfig.base.type_check.json ./tsconfig.refs.json ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-grid-layout/jest.config.js:12 src/platform/packages/private/kbn-grid-layout/tsconfig.json:2 src/platform/packages/private/kbn-grid-layout/tsconfig.type_check.json:2 ``` </details> |
||
|
7cf4ee8121
|
SKA: Cleanup and follow-up tasks (1 of many) (#206420)
## Summary * Cleanup duplicate CODEOWNERS entries (introduced in https://github.com/elastic/kibana/pull/203682). * Update `node scripts/generate package` to support sustainable folders. * Rescue orphan `.mdx` files belonging to shared-ux * Update broken link |
||
|
ac584159e0
|
[UX Plugin] Audit new EUI Borealis theme (#205195)
## Summary It fixes #205051 --------- |
||
|
ee6c5bde34
|
Observability AI Assistant Tests Deployment Agnostic (#205194)
Closes #192718 ## Summary This PR add a deployment-agnostic testing environment for Observability AI Assistant tests by unifying the duplicated tests for stateful and serverless environments. It create the ObservabilityAIAssistantApiClient to work seamlessly in both environments, enabling a single test to run across stateful, CI, and MKI. Initial efforts focus on deduplicating the `conversations.spec.ts` and `connectors.spec.ts` files, as these already run in all environments. Move / dedup the tests that exist in stateful and serverless. They run in serverless CI but not MKI and add the skipMki tag. `chat.spec.ts` `complete.spec.ts` `elasticsearch.spec.ts` `public_complete.spec.ts` `alerts.spec.ts` `knowledge_base_setup.spec.ts` `knowledge_base_status.spec.ts` `knowledge_base.spec.ts` `summarize.ts` `knowledge_base_user_instructions.spec.ts` |
||
|
683a768941
|
SKA: Relocate remaining modules (#206103)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 2 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/entities-data-access-plugin` | `x-pack/solutions/observability/plugins/entities_data_access` | | `@kbn/entityManager-app-plugin` | `x-pack/solutions/observability/plugins/entity_manager_app` | #### 10 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/core-user-settings-server` | `src/core/packages/user-settings/server` | | `@kbn/core-user-settings-server-internal` | `src/core/packages/user-settings/server-internal` | | `@kbn/core-user-settings-server-mocks` | `src/core/packages/user-settings/server-mocks` | | `@kbn/calculate-auto` | `src/platform/packages/shared/kbn-calculate-auto` | | `@kbn/charts-theme` | `src/platform/packages/shared/kbn-charts-theme` | | `@kbn/palettes` | `src/platform/packages/shared/kbn-palettes` | | `@kbn/saved-search-component` | `src/platform/packages/shared/kbn-saved-search-component` | | `@kbn/use-tracked-promise` | `src/platform/packages/shared/kbn-use-tracked-promise` | | `@kbn/response-ops-rule-form` | `src/platform/packages/shared/response-ops/rule_form` | | `@kbn/streams-schema` | `x-pack/solutions/observability/packages/kbn-streams-schema` | <details > <summary>Updated references</summary> ``` ./.i18nrc.json ./docs/developer/plugin-list.asciidoc ./package.json ./packages/kbn-ts-projects/config-paths.json ./src/core/packages/user-settings/server-internal/jest.config.js ./src/core/packages/user-settings/server-mocks/jest.config.js ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/shared/kbn-calculate-auto/jest.config.js ./src/platform/packages/shared/kbn-charts-theme/jest.config.js ./src/platform/packages/shared/kbn-palettes/jest.config.js ./src/platform/packages/shared/kbn-saved-search-component/jest.config.js ./src/platform/packages/shared/kbn-use-tracked-promise/jest.config.js ./src/platform/packages/shared/response-ops/rule_form/jest.config.js ./tsconfig.base.json ./x-pack/solutions/observability/packages/kbn-streams-schema/jest.config.js ./x-pack/solutions/observability/plugins/entities_data_access/jest.config.js ./x-pack/solutions/observability/plugins/entity_manager_app/jest.config.js ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/core/packages/user-settings/server-internal/jest.config.js:12 src/core/packages/user-settings/server-internal/tsconfig.json:2 src/core/packages/user-settings/server-mocks/jest.config.js:12 src/core/packages/user-settings/server-mocks/tsconfig.json:2 src/core/packages/user-settings/server/tsconfig.json:2 src/platform/packages/shared/kbn-calculate-auto/jest.config.js:12 src/platform/packages/shared/kbn-calculate-auto/tsconfig.json:2 src/platform/packages/shared/kbn-charts-theme/jest.config.js:12 src/platform/packages/shared/kbn-charts-theme/tsconfig.json:2 src/platform/packages/shared/kbn-palettes/jest.config.js:12 src/platform/packages/shared/kbn-palettes/tsconfig.json:2 src/platform/packages/shared/kbn-saved-search-component/jest.config.js:12 src/platform/packages/shared/kbn-saved-search-component/tsconfig.json:2 src/platform/packages/shared/kbn-use-tracked-promise/jest.config.js:12 src/platform/packages/shared/kbn-use-tracked-promise/tsconfig.json:2 src/platform/packages/shared/response-ops/rule_form/jest.config.js:12 src/platform/packages/shared/response-ops/rule_form/tsconfig.json:2 x-pack/solutions/observability/packages/kbn-streams-schema/jest.config.js:10 x-pack/solutions/observability/packages/kbn-streams-schema/tsconfig.json:2 x-pack/solutions/observability/plugins/entities_data_access/jest.config.js:12 x-pack/solutions/observability/plugins/entities_data_access/tsconfig.json:2 x-pack/solutions/observability/plugins/entity_manager_app/jest.config.js:12 x-pack/solutions/observability/plugins/entity_manager_app/tsconfig.json:2 x-pack/solutions/observability/plugins/entity_manager_app/tsconfig.json:7 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
5e3d98c337
|
Update LaunchDarkly (main) (#205152) | ||
|
a3f07db7b6
|
Remove log stream and settings (#204115)
Removes the code used to render the log stream and settings pages. The following areas have been checked: - Log stream embeddable (dashboard of the `cisco_meraki` integration) - Log stream shared component - Log categories - Log anomalies https://github.com/user-attachments/assets/2bc0763d-3def-4c4b-b50a-21c17976a596 Closes https://github.com/elastic/kibana/issues/204005 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
64b6a1a5e7
|
Sustainable Kibana Architecture: Move the rest of shared-ux modules (#205924)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 1 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/url-drilldown-plugin` | `x-pack/platform/plugins/private/drilldowns/url_drilldown` | #### 21 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/core-chrome-browser` | `src/core/packages/chrome/browser` | | `@kbn/deeplinks-shared` | `src/platform/packages/shared/deeplinks/shared` | | `@kbn/home-sample-data-card` | `src/platform/packages/shared/home/sample_data_card` | | `@kbn/home-sample-data-tab` | `src/platform/packages/shared/home/sample_data_tab` | | `@kbn/home-sample-data-types` | `src/platform/packages/shared/home/sample_data_types` | | `@kbn/guided-onboarding` | `src/platform/packages/shared/kbn-guided-onboarding` | | `@kbn/item-buffer` | `src/platform/packages/private/kbn-item-buffer` | | `@kbn/management-settings-section-registry` | `src/platform/packages/shared/kbn-management/settings/section_registry` | | `@kbn/management-settings-ids` | `src/platform/packages/shared/kbn-management/settings/setting_ids` | | `@kbn/react-mute-legacy-root-warning` | `src/platform/packages/private/kbn-react-mute-legacy-root-warning` | | `@kbn/saved-objects-settings` | `src/platform/packages/private/kbn-saved-objects-settings` | | `@kbn/react-kibana-context-common` | `src/platform/packages/shared/react/kibana_context/common` | | `@kbn/react-kibana-context-render` | `src/platform/packages/shared/react/kibana_context/render` | | `@kbn/react-kibana-context-root` | `src/platform/packages/shared/react/kibana_context/root` | | `@kbn/react-kibana-context-styled` | `src/platform/packages/shared/react/kibana_context/styled` | | `@kbn/react-kibana-context-theme` | `src/platform/packages/shared/react/kibana_context/theme` | | `@kbn/react-kibana-mount` | `src/platform/packages/shared/react/kibana_mount` | | `@kbn/serverless-project-switcher` | `src/platform/packages/private/serverless/project_switcher` | | `@kbn/serverless-common-settings` | `src/platform/packages/private/serverless/settings/common` | | `@kbn/serverless-observability-settings` | `src/platform/packages/shared/serverless/settings/observability_project` | | `@kbn/serverless-types` | `src/platform/packages/private/serverless/types` | <details > <summary>Updated relative paths</summary> ``` src/core/packages/chrome/browser/jest.config.js:12 src/core/packages/chrome/browser/tsconfig.json:2 src/core/packages/chrome/browser/tsconfig.type_check.json:2 src/core/packages/chrome/browser/tsconfig.type_check.json:21 src/core/packages/chrome/browser/tsconfig.type_check.json:24 src/core/packages/chrome/browser/tsconfig.type_check.json:27 src/core/packages/chrome/browser/tsconfig.type_check.json:30 src/core/packages/chrome/browser/tsconfig.type_check.json:33 src/core/packages/chrome/browser/tsconfig.type_check.json:36 src/core/packages/chrome/browser/tsconfig.type_check.json:39 src/core/packages/chrome/browser/tsconfig.type_check.json:42 src/core/packages/chrome/browser/tsconfig.type_check.json:45 src/core/packages/chrome/browser/tsconfig.type_check.json:48 src/core/packages/chrome/browser/tsconfig.type_check.json:51 src/core/packages/chrome/browser/tsconfig.type_check.json:54 src/platform/packages/private/kbn-item-buffer/jest.config.js:12 src/platform/packages/private/kbn-item-buffer/tsconfig.json:2 src/platform/packages/private/kbn-react-mute-legacy-root-warning/jest.config.js:12 src/platform/packages/private/kbn-react-mute-legacy-root-warning/tsconfig.json:2 src/platform/packages/private/kbn-saved-objects-settings/jest.config.js:12 src/platform/packages/private/kbn-saved-objects-settings/tsconfig.json:2 src/platform/packages/private/kbn-saved-objects-settings/tsconfig.type_check.json:2 src/platform/packages/private/serverless/project_switcher/jest.config.js:12 src/platform/packages/private/serverless/project_switcher/tsconfig.json:2 src/platform/packages/private/serverless/project_switcher/tsconfig.type_check.json:2 src/platform/packages/private/serverless/project_switcher/tsconfig.type_check.json:23 src/platform/packages/private/serverless/settings/common/tsconfig.json:2 src/platform/packages/private/serverless/settings/common/tsconfig.type_check.json:2 src/platform/packages/private/serverless/settings/common/tsconfig.type_check.json:20 src/platform/packages/private/serverless/types/tsconfig.json:2 src/platform/packages/private/serverless/types/tsconfig.type_check.json:2 src/platform/packages/shared/deeplinks/shared/jest.config.js:12 src/platform/packages/shared/deeplinks/shared/tsconfig.json:2 src/platform/packages/shared/deeplinks/shared/tsconfig.type_check.json:2 src/platform/packages/shared/home/sample_data_card/jest.config.js:12 src/platform/packages/shared/home/sample_data_card/tsconfig.json:2 src/platform/packages/shared/home/sample_data_card/tsconfig.type_check.json:2 src/platform/packages/shared/home/sample_data_card/tsconfig.type_check.json:23 src/platform/packages/shared/home/sample_data_card/tsconfig.type_check.json:29 src/platform/packages/shared/home/sample_data_tab/jest.config.js:12 src/platform/packages/shared/home/sample_data_tab/tsconfig.json:2 src/platform/packages/shared/home/sample_data_tab/tsconfig.type_check.json:2 src/platform/packages/shared/home/sample_data_tab/tsconfig.type_check.json:23 src/platform/packages/shared/home/sample_data_types/jest.config.js:12 src/platform/packages/shared/home/sample_data_types/tsconfig.json:2 src/platform/packages/shared/home/sample_data_types/tsconfig.type_check.json:2 src/platform/packages/shared/kbn-guided-onboarding/jest.config.js:12 src/platform/packages/shared/kbn-guided-onboarding/tsconfig.json:2 src/platform/packages/shared/kbn-guided-onboarding/tsconfig.type_check.json:2 src/platform/packages/shared/kbn-management/settings/section_registry/tsconfig.json:2 src/platform/packages/shared/kbn-management/settings/section_registry/tsconfig.type_check.json:2 src/platform/packages/shared/kbn-management/settings/section_registry/tsconfig.type_check.json:22 src/platform/packages/shared/kbn-management/settings/section_registry/tsconfig.type_check.json:25 src/platform/packages/shared/kbn-management/settings/setting_ids/tsconfig.json:2 src/platform/packages/shared/kbn-management/settings/setting_ids/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/common/jest.config.js:12 src/platform/packages/shared/react/kibana_context/common/tsconfig.json:2 src/platform/packages/shared/react/kibana_context/common/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/render/jest.config.js:12 src/platform/packages/shared/react/kibana_context/render/tsconfig.json:2 src/platform/packages/shared/react/kibana_context/render/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/render/tsconfig.type_check.json:25 src/platform/packages/shared/react/kibana_context/root/jest.config.js:12 src/platform/packages/shared/react/kibana_context/root/tsconfig.json:2 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:22 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:28 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:31 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:34 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:37 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:40 src/platform/packages/shared/react/kibana_context/styled/jest.config.js:12 src/platform/packages/shared/react/kibana_context/styled/tsconfig.json:2 src/platform/packages/shared/react/kibana_context/styled/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/styled/tsconfig.type_check.json:22 src/platform/packages/shared/react/kibana_context/theme/jest.config.js:12 src/platform/packages/shared/react/kibana_context/theme/tsconfig.json:2 src/platform/packages/shared/react/kibana_context/theme/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/theme/tsconfig.type_check.json:22 src/platform/packages/shared/react/kibana_mount/jest.config.js:12 src/platform/packages/shared/react/kibana_mount/tsconfig.json:2 src/platform/packages/shared/react/kibana_mount/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_mount/tsconfig.type_check.json:22 src/platform/packages/shared/react/kibana_mount/tsconfig.type_check.json:25 src/platform/packages/shared/react/kibana_mount/tsconfig.type_check.json:28 src/platform/packages/shared/react/kibana_mount/tsconfig.type_check.json:34 src/platform/packages/shared/serverless/settings/observability_project/tsconfig.json:2 src/platform/packages/shared/serverless/settings/observability_project/tsconfig.type_check.json:2 src/platform/packages/shared/serverless/settings/observability_project/tsconfig.type_check.json:20 x-pack/platform/plugins/private/drilldowns/url_drilldown/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
|
abf00ee777
|
[Streams 🌊] Stream enrichment processors management (#204793)
## 📓 Summary Part of #https://github.com/elastic/streams-program/issues/32 This work implements a UI for basic stream enrichment, supporting grok and dissect processor + detected fields mapping. The main features implemented in this PR consist of: - **Sortable processors list** - **Add new processor - Grok, Dissect** - Ad-hoc forms for each processor - Simulated document outcome with extracted fields - Filter matching documents with parsed fields - Mapping detected fields (only available for wired streams) - **Edit processor** - Change configuration only - Delete processor CTA As a side quest, I added a small package for object utils as @simianhacker suggested. `@kbn/object-utils` exposes `calculateObjectDiff` and `flattenObject` to detect the changed fields in a simulation. ## 🔜 Follow-up work I'll work on minor updates on top of this MVP to make this available for further testing from the team. The next steps will be: - **Tests** for features that consolidate on the functional pov. - Better field mapping detection and UI feedback (infer the type of the detected field, currently always unmapped) - Add better form validation and feedback for processor configuration. As discussed offline, state management is purely based on the built-in react APIs + react-hook-form. It could be improved with different approaches, including a more solid state management library to make it easier to maintain and bulletproof to race conditions. No state syncs with the URL currently. ## 🎥 Demo https://github.com/user-attachments/assets/a48fade9-f5aa-4270-bb19-d91d1eed822b --------- Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
6ed214a69f
|
Migrate onboarding Cypress tests to Scout (#205482)
This change converts Cypress tests for the custom logs flow into Playwright using [the Scout wrapper](https://github.com/elastic/kibana/tree/main/packages/kbn-scout). > [!NOTE] > As Scout package is still being developed, the PR pipeline configured to runs Playwright tests only when code in certain plugins have been changed and not on every PR. ### How to run tests locally Start the Scout server ```bash node scripts/scout.js start-server --stateful ``` In a separate terminal run the tests ```bash npx playwright test --config x-pack/solutions/observability/plugins/observability_onboarding/ui_tests/playwright.config.ts ``` Playwright runs browsers in a headless mode by default, user `--headed` option if needed |
||
|
41a42555f9
|
[Cloud Experiments] Flag as private (#206121) | ||
|
1e9606de9c
|
Turn AssetInventory sub-plugin into a Security solution page (#205363)
## Summary Turn AssetInventory plugin into a simple Security solution page based on this conversation: - https://github.com/elastic/security-team/issues/10346 Follow-up of this work, where we initially developed the Asset Inventory bare-bones as a plugin: - https://github.com/elastic/kibana/issues/201704 Part of this work stream though not originally planned: - https://github.com/elastic/security-team/issues/11247?reload=1 ### Motivation Reasoning behind is enabling fast development changes without any major refactors in other packages/components that need to be reused, which seems impossible as of now with the current codebase. ### Checklist - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks In the future, we'll probably have to turn AssetInventory into a sub-plugin again. Doing so doesn't bring any risk in the present, and should only involve the re-generation of the deleted files in this PR. --------- Co-authored-by: Paulo Henrique <paulo.henrique@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
8eec8065bd
|
[inference] handle toolCall indices not starting at 0 (#205954)
## Summary Turns out, claude can in some situations (when returning both text and toolcall in a single message) starts their toolcall index at `1` instead of `0`, which introducing null values in the concatenated messages. This fixes it, by removing null values from the tool calls when merging the chunks. Also remove the SKA codeowner override for the inference plugin to get back the shared ownership |
||
|
2be928c489
|
SKA: Categorise remaining packages (#205875)
## Summary * Delete unused package `@kbn/formatters` * Delete unused package `@kbn/response-ops-feature-flag-service` * Flag `@kbn/generate-console-definitions` as `devOnly: true` * Flag `@kbn/plugin-check` as `devOnly: true` * Flag `@kbn/set-map` as `devOnly: true` * Flag `@kbn/synthetics-private-location` as `devOnly: true` * Categorise `@kbn/calculate-auto` as `platform/shared` * Categorise `@kbn/charts-theme` as `platform/shared` * Categorise `@kbn/saved-search-component` as `platform/shared` * Categorise `@kbn/use-tracked-promise` as `platform/shared` * Categorise `@kbn/charts-theme` as `platform/shared` * Categorise `@kbn/response-ops-rule-form` as `platform/shared` |
||
|
3b2ab7b413
|
Sustainable Kibana Architecture: Move CodeEditor related packages #205587 (#205738)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 3 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/code-editor` | `src/platform/packages/shared/shared-ux/code_editor/impl` | | `@kbn/code-editor-mock` | `src/platform/packages/shared/shared-ux/code_editor/mocks` | | `@kbn/monaco` | `src/platform/packages/shared/kbn-monaco` | <details > <summary>Updated relative paths</summary> ``` src/platform/packages/shared/kbn-monaco/jest.config.js:12 src/platform/packages/shared/kbn-monaco/tsconfig.json:2 src/platform/packages/shared/kbn-monaco/tsconfig.type_check.json:2 src/platform/packages/shared/shared-ux/code_editor/impl/jest.config.js:12 src/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.json:16 src/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.json:2 src/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:18 src/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:2 src/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:25 src/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:28 src/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:31 src/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:34 src/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:37 src/platform/packages/shared/shared-ux/code_editor/impl/tsconfig.type_check.json:40 src/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.json:16 src/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.json:2 src/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:18 src/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:2 src/platform/packages/shared/shared-ux/code_editor/mocks/tsconfig.type_check.json:25 ``` </details> |
||
|
a382d35dd2
|
Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-visualizations (#202754)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 29 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/charts-plugin` | `src/platform/plugins/shared/charts` | | `@kbn/data-plugin` | `src/platform/plugins/shared/data` | | `@kbn/event-annotation-listing-plugin` | `src/platform/plugins/private/event_annotation_listing` | | `@kbn/event-annotation-plugin` | `src/platform/plugins/private/event_annotation` | | `@kbn/expression-gauge-plugin` | `src/platform/plugins/shared/chart_expressions/expression_gauge` | | `@kbn/expression-heatmap-plugin` | `src/platform/plugins/shared/chart_expressions/expression_heatmap` | | `@kbn/expression-legacy-metric-vis-plugin` | `src/platform/plugins/shared/chart_expressions/expression_legacy_metric` | | `@kbn/expression-metric-vis-plugin` | `src/platform/plugins/shared/chart_expressions/expression_metric` | | `@kbn/expression-partition-vis-plugin` | `src/platform/plugins/shared/chart_expressions/expression_partition_vis` | | `@kbn/expression-tagcloud-plugin` | `src/platform/plugins/shared/chart_expressions/expression_tagcloud` | | `@kbn/expression-xy-plugin` | `src/platform/plugins/shared/chart_expressions/expression_xy` | | `@kbn/expressions-plugin` | `src/platform/plugins/shared/expressions` | | `@kbn/graph-plugin` | `x-pack/platform/plugins/private/graph` | | `@kbn/lens-plugin` | `x-pack/platform/plugins/shared/lens` | | `@kbn/unified-search-plugin` | `src/platform/plugins/shared/unified_search` | | `@kbn/url-forwarding-plugin` | `src/platform/plugins/private/url_forwarding` | | `@kbn/vis-default-editor-plugin` | `src/platform/plugins/private/vis_default_editor` | | `@kbn/vis-type-gauge-plugin` | `src/platform/plugins/private/vis_types/gauge` | | `@kbn/vis-type-heatmap-plugin` | `src/platform/plugins/private/vis_types/heatmap` | | `@kbn/vis-type-metric-plugin` | `src/platform/plugins/private/vis_types/metric` | | `@kbn/vis-type-pie-plugin` | `src/platform/plugins/private/vis_types/pie` | | `@kbn/vis-type-table-plugin` | `src/platform/plugins/private/vis_types/table` | | `@kbn/vis-type-tagcloud-plugin` | `src/platform/plugins/private/vis_types/tagcloud` | | `@kbn/vis-type-timelion-plugin` | `src/platform/plugins/private/vis_types/timelion` | | `@kbn/vis-type-timeseries-plugin` | `src/platform/plugins/shared/vis_types/timeseries` | | `@kbn/vis-type-vega-plugin` | `src/platform/plugins/private/vis_types/vega` | | `@kbn/vis-type-vislib-plugin` | `src/platform/plugins/private/vis_types/vislib` | | `@kbn/vis-type-xy-plugin` | `src/platform/plugins/private/vis_types/xy` | | `@kbn/visualizations-plugin` | `src/platform/plugins/shared/visualizations` | #### 18 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/calculate-width-from-char-count` | `src/platform/packages/shared/kbn-calculate-width-from-char-count` | | `@kbn/chart-expressions-common` | `src/platform/packages/shared/chart-expressions-common` | | `@kbn/chart-icons` | `src/platform/packages/shared/kbn-chart-icons` | | `@kbn/coloring` | `src/platform/packages/shared/kbn-coloring` | | `@kbn/data-service` | `src/platform/packages/shared/kbn-data-service` | | `@kbn/dom-drag-drop` | `src/platform/packages/shared/kbn-dom-drag-drop` | | `@kbn/event-annotation-common` | `src/platform/packages/shared/kbn-event-annotation-common` | | `@kbn/event-annotation-components` | `src/platform/packages/shared/kbn-event-annotation-components` | | `@kbn/interpreter` | `src/platform/packages/shared/kbn-interpreter` | | `@kbn/lens-formula-docs` | `src/platform/packages/private/kbn-lens-formula-docs` | | `@kbn/managed-content-badge` | `src/platform/packages/private/kbn-managed-content-badge` | | `@kbn/random-sampling` | `x-pack/platform/packages/private/kbn-random-sampling` | | `@kbn/sort-predicates` | `src/platform/packages/shared/kbn-sort-predicates` | | `@kbn/timelion-grammar` | `src/platform/packages/private/kbn-timelion-grammar` | | `@kbn/tinymath` | `src/platform/packages/private/kbn-tinymath` | | `@kbn/transpose-utils` | `src/platform/packages/private/kbn-transpose-utils` | | `@kbn/visualization-ui-components` | `src/platform/packages/shared/kbn-visualization-ui-components` | | `@kbn/visualization-utils` | `src/platform/packages/shared/kbn-visualization-utils` | <details > <summary>Updated references</summary> ``` ./.eslintignore ./.eslintrc.js ./.github/paths-labeller.yml ./.i18nrc.json ./docs/developer/architecture/core/elasticsearch-service.asciidoc ./docs/developer/architecture/development-visualize-index.asciidoc ./docs/developer/best-practices/index.asciidoc ./docs/developer/plugin-list.asciidoc ./examples/search_examples/public/plugin.ts ./package.json ./packages/kbn-docs-utils/src/build_api_declarations/extract_import_refs.test.ts ./packages/kbn-docs-utils/src/utils.ts ./packages/kbn-eslint-plugin-i18n/helpers/get_i18n_identifier_from_file_path.test.ts ./packages/kbn-repo-source-classifier/src/repo_source_classifier.ts ./packages/kbn-ts-projects/config-paths.json ./src/dev/build/tasks/package_json/find_used_dependencies.ts ./src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js ./src/dev/code_coverage/ingest_coverage/__tests__/mocks/team_assign_mock.txt ./src/dev/code_coverage/ingest_coverage/__tests__/transforms.test.js ./src/dev/code_coverage/ingest_coverage/integration_tests/mocks/jest-combined/bulk-data.json ./src/dev/storybook/aliases.ts ./src/platform/packages/private/kbn-lens-formula-docs/jest.config.js ./src/platform/packages/private/kbn-managed-content-badge/jest.config.js ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/private/kbn-tinymath/README.md ./src/platform/packages/private/kbn-tinymath/jest.config.js ./src/platform/packages/private/kbn-transpose-utils/jest.config.js ./src/platform/packages/shared/chart-expressions-common/jest.config.js ./src/platform/packages/shared/kbn-calculate-width-from-char-count/jest.config.js ./src/platform/packages/shared/kbn-chart-icons/jest.config.js ./src/platform/packages/shared/kbn-coloring/jest.config.js ./src/platform/packages/shared/kbn-data-service/jest.config.js ./src/platform/packages/shared/kbn-dom-drag-drop/jest.config.js ./src/platform/packages/shared/kbn-event-annotation-common/jest.config.js ./src/platform/packages/shared/kbn-event-annotation-components/jest.config.js ./src/platform/packages/shared/kbn-interpreter/jest.config.js ./src/platform/packages/shared/kbn-sort-predicates/jest.config.js ./src/platform/packages/shared/kbn-visualization-ui-components/jest.config.js ./src/platform/packages/shared/kbn-visualization-utils/jest.config.js ./src/platform/plugins/private/event_annotation/jest.config.js ./src/platform/plugins/private/event_annotation_listing/jest.config.js ./src/platform/plugins/private/url_forwarding/jest.config.js ./src/platform/plugins/private/vis_default_editor/jest.config.js ./src/platform/plugins/private/vis_types/gauge/jest.config.js ./src/platform/plugins/private/vis_types/heatmap/jest.config.js ./src/platform/plugins/private/vis_types/metric/jest.config.js ./src/platform/plugins/private/vis_types/pie/jest.config.js ./src/platform/plugins/private/vis_types/table/jest.config.js ./src/platform/plugins/private/vis_types/tagcloud/jest.config.js ./src/platform/plugins/private/vis_types/timelion/jest.config.js ./src/platform/plugins/private/vis_types/vega/jest.config.js ./src/platform/plugins/private/vis_types/vislib/jest.config.js ./src/platform/plugins/private/vis_types/xy/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_gauge/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_heatmap/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_legacy_metric/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_metric/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_partition_vis/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_tagcloud/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_xy/jest.config.js ./src/platform/plugins/shared/charts/jest.config.js ./src/platform/plugins/shared/custom_integrations/jest.config.js ./src/platform/plugins/shared/data/jest.config.js ./src/platform/plugins/shared/expressions/README.asciidoc ./src/platform/plugins/shared/expressions/jest.config.js ./src/platform/plugins/shared/unified_search/jest.config.js ./src/platform/plugins/shared/vis_types/timeseries/jest.config.js ./src/platform/plugins/shared/visualizations/jest.config.js ./src/plugins/vis_types/timeseries/public/application/components/aggs/math.js ./tsconfig.base.json ./tsconfig.base.type_check.json ./tsconfig.refs.json ./x-pack/.i18nrc.json ./x-pack/platform/packages/private/kbn-random-sampling/jest.config.js ./x-pack/platform/packages/private/ml/date_utils/src/date_utils.ts ./x-pack/platform/plugins/private/graph/README.md ./x-pack/platform/plugins/private/graph/jest.config.js ./x-pack/platform/plugins/private/graph/public/components/venn_diagram/vennjs/index.ts ./x-pack/platform/plugins/private/watcher/public/legacy/time_buckets.js ./x-pack/platform/plugins/shared/cases/public/components/markdown_editor/use_plugins.ts ./x-pack/platform/plugins/shared/lens/jest.config.js ./x-pack/platform/plugins/shared/lens/readme.md ./x-pack/platform/plugins/shared/lens/server/embeddable/make_lens_embeddable_factory.ts ./x-pack/platform/plugins/shared/lens/server/migrations/saved_object_migrations.ts ./x-pack/platform/plugins/shared/lens/tsconfig.type_check.json ./x-pack/platform/plugins/shared/ml/public/application/explorer/explorer_charts/explorer_charts_container.js ./x-pack/platform/plugins/shared/ml/public/application/services/field_format_service.ts ./x-pack/platform/plugins/shared/ml/public/application/util/chart_utils.js ./x-pack/solutions/observability/plugins/observability/common/utils/get_inspect_response.ts ./x-pack/solutions/observability/plugins/observability_shared/common/utils/get_inspect_response.ts ./x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/autocomplete/index.mock.ts ./x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/fields/index.mock.ts ./x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/filter_field_to_list/index.ts ./x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/hooks/use_field_value_autocomplete/index.test.ts ./x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/hooks/use_field_value_autocomplete/index.ts ./x-pack/solutions/security/packages/kbn-securitysolution-list-utils/src/helpers/index.ts ./x-pack/solutions/security/plugins/security_solution/public/common/hooks/use_app_toasts.ts ./x-pack/solutions/security/plugins/security_solution/server/lib/timeline/constants.ts ./x-pack/solutions/security/plugins/timelines/public/hooks/use_app_toasts.ts ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-lens-formula-docs/jest.config.js:12 src/platform/packages/private/kbn-lens-formula-docs/tsconfig.json:2 src/platform/packages/private/kbn-managed-content-badge/jest.config.js:12 src/platform/packages/private/kbn-managed-content-badge/tsconfig.json:2 src/platform/packages/private/kbn-timelion-grammar/tsconfig.json:2 src/platform/packages/private/kbn-tinymath/jest.config.js:12 src/platform/packages/private/kbn-tinymath/tsconfig.json:2 src/platform/packages/private/kbn-transpose-utils/jest.config.js:12 src/platform/packages/private/kbn-transpose-utils/tsconfig.json:2 src/platform/packages/shared/chart-expressions-common/jest.config.js:12 src/platform/packages/shared/chart-expressions-common/tsconfig.json:2 src/platform/packages/shared/kbn-calculate-width-from-char-count/jest.config.js:12 src/platform/packages/shared/kbn-calculate-width-from-char-count/tsconfig.json:2 src/platform/packages/shared/kbn-chart-icons/jest.config.js:12 src/platform/packages/shared/kbn-chart-icons/tsconfig.json:2 src/platform/packages/shared/kbn-coloring/jest.config.js:12 src/platform/packages/shared/kbn-coloring/tsconfig.json:2 src/platform/packages/shared/kbn-data-service/jest.config.js:12 src/platform/packages/shared/kbn-data-service/tsconfig.json:2 src/platform/packages/shared/kbn-dom-drag-drop/jest.config.js:12 src/platform/packages/shared/kbn-dom-drag-drop/tsconfig.json:2 src/platform/packages/shared/kbn-event-annotation-common/jest.config.js:12 src/platform/packages/shared/kbn-event-annotation-common/tsconfig.json:2 src/platform/packages/shared/kbn-event-annotation-components/jest.config.js:12 src/platform/packages/shared/kbn-event-annotation-components/tsconfig.json:2 src/platform/packages/shared/kbn-interpreter/jest.config.js:12 src/platform/packages/shared/kbn-interpreter/tsconfig.json:2 src/platform/packages/shared/kbn-sort-predicates/jest.config.js:12 src/platform/packages/shared/kbn-sort-predicates/tsconfig.json:2 src/platform/packages/shared/kbn-visualization-ui-components/jest.config.js:12 src/platform/packages/shared/kbn-visualization-ui-components/tsconfig.json:2 src/platform/packages/shared/kbn-visualization-utils/jest.config.js:12 src/platform/packages/shared/kbn-visualization-utils/tsconfig.json:2 src/platform/plugins/private/event_annotation/jest.config.js:12 src/platform/plugins/private/event_annotation/tsconfig.json:2 src/platform/plugins/private/event_annotation_listing/jest.config.js:12 src/platform/plugins/private/event_annotation_listing/tsconfig.json:2 src/platform/plugins/private/url_forwarding/jest.config.js:12 src/platform/plugins/private/url_forwarding/tsconfig.json:2 src/platform/plugins/private/vis_default_editor/README.md:8 src/platform/plugins/private/vis_default_editor/jest.config.js:12 src/platform/plugins/private/vis_default_editor/tsconfig.json:2 src/platform/plugins/private/vis_types/gauge/jest.config.js:12 src/platform/plugins/private/vis_types/gauge/tsconfig.json:2 src/platform/plugins/private/vis_types/heatmap/jest.config.js:12 src/platform/plugins/private/vis_types/heatmap/tsconfig.json:2 src/platform/plugins/private/vis_types/metric/jest.config.js:12 src/platform/plugins/private/vis_types/metric/tsconfig.json:2 src/platform/plugins/private/vis_types/pie/jest.config.js:12 src/platform/plugins/private/vis_types/pie/tsconfig.json:2 src/platform/plugins/private/vis_types/table/jest.config.js:12 src/platform/plugins/private/vis_types/table/tsconfig.json:2 src/platform/plugins/private/vis_types/tagcloud/jest.config.js:12 src/platform/plugins/private/vis_types/tagcloud/tsconfig.json:2 src/platform/plugins/private/vis_types/timelion/jest.config.js:12 src/platform/plugins/private/vis_types/timelion/tsconfig.json:2 src/platform/plugins/private/vis_types/vega/jest.config.js:12 src/platform/plugins/private/vis_types/vega/tsconfig.json:2 src/platform/plugins/private/vis_types/vislib/jest.config.js:12 src/platform/plugins/private/vis_types/vislib/tsconfig.json:2 src/platform/plugins/private/vis_types/xy/jest.config.js:12 src/platform/plugins/private/vis_types/xy/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_gauge/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_gauge/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_heatmap/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_heatmap/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_legacy_metric/.storybook/main.js:17 src/platform/plugins/shared/chart_expressions/expression_legacy_metric/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_legacy_metric/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_metric/.storybook/main.js:17 src/platform/plugins/shared/chart_expressions/expression_metric/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_metric/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_partition_vis/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_partition_vis/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_tagcloud/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_tagcloud/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_xy/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_xy/tsconfig.json:2 src/platform/plugins/shared/charts/jest.config.js:12 src/platform/plugins/shared/charts/tsconfig.json:2 src/platform/plugins/shared/data/jest.config.js:12 src/platform/plugins/shared/data/tsconfig.json:13 src/platform/plugins/shared/data/tsconfig.json:2 src/platform/plugins/shared/expressions/jest.config.js:12 src/platform/plugins/shared/expressions/tsconfig.json:2 src/platform/plugins/shared/unified_search/jest.config.js:12 src/platform/plugins/shared/unified_search/tsconfig.json:2 src/platform/plugins/shared/vis_types/timeseries/jest.config.js:12 src/platform/plugins/shared/vis_types/timeseries/tsconfig.json:11 src/platform/plugins/shared/vis_types/timeseries/tsconfig.json:2 src/platform/plugins/shared/visualizations/jest.config.js:12 src/platform/plugins/shared/visualizations/tsconfig.json:2 src/platform/plugins/shared/visualizations/tsconfig.json:6 x-pack/platform/packages/private/kbn-random-sampling/jest.config.js:10 x-pack/platform/packages/private/kbn-random-sampling/tsconfig.json:2 x-pack/platform/plugins/private/graph/jest.config.js:10 x-pack/platform/plugins/private/graph/tsconfig.json:13 x-pack/platform/plugins/private/graph/tsconfig.json:3 x-pack/platform/plugins/shared/lens/jest.config.js:10 x-pack/platform/plugins/shared/lens/tsconfig.json:2 x-pack/platform/plugins/shared/lens/tsconfig.json:6 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
72d3f7b89c
|
Sustainable Kibana Architecture: Move content management related packages (#205593) | ||
|
28414ce988
|
[Streams] Dashboard linking (#204309)
Links dashboard to Streams. Changes: - Introduces `IndexStorageAdapter` to manage ES indices - see https://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md for motivation - Introduces `AssetClient` and `AssetService` to manage asset links with `IndexStorageAdapter` - `RepositorySupertestClient` to make it easier to use `@kbn/server-route-repository` with FTR tests - refactors related to above changes --------- Co-authored-by: Chris Cowan <chris@elastic.co> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
|
d5c804bc58
|
[Docs] Update "Alert and action settings" docs to be generated from YAML source (#191787)
This PR: - Updates the Kibana [Alert and action settings](https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html) page to be based off of a YAML source file (`/docs/settings-gen/source/kibana-alert-action-settings.yml`) that is manually converted to Asciidoc format (`kibana-alert-action-settings.asciidoc`) by means of a Perl script (`docs/settings-gen/parse-settings.pl`). A preview of the new, generated page is [here](https://kibana_bk_191787.docs-preview.app.elstc.co/guide/en/kibana/master/alert-action-settings-kb.html). - Adds the `docs/settings-gen/parse-settings.pl` script which does the YAML → Asciidoc conversion. All new files are added to the `/docs/source-gen` folder. This is a trial run updating only one page of settings in the docs. Later, in separate PRs, we plan to convert other pages. After all Kibana settings pages have been converted, we would ask that the Perl script be run automatically as part of the CI whenever the YAML files in `/docs/source-gen` are added or updated. **Notes:** - The Docs team is happy to own and maintain the Perl script (sorry to use Perl - it's the only scripting language that I know). - In time we also plan to convert all of these files from Asciidoc to Markdown. - When we eventually/hopefully get the rest of the Kibana settings files converted, we will announce the settings doc process to the Kibana team by email and/or in the Kibana newsletter. Big thanks to the amazing @lukeelmers and @KOTungseth for guiding this! --- Why are we doing this? We aim to: - Create a more consistent appearance for settings across all of the docs. - Make it easier for people to contribute, since all Asciidoc/Markdown formatting is handled by a script. - Make it more apparent which settings may be missing info, such as the default values, available options, etc. --- P.S. I haven't worked in the Kibana repo very much and would appreciate any help navigating the CI checks. Rel: https://github.com/elastic/docs-projects/issues/239 |
||
|
a8579bb41f
|
Make saved_objects_tagging plugin shared (#205695)
## Summary So that it can be used from `streams_app` (o11y). See https://github.com/elastic/kibana/pull/204309 Steps to relocate: 1. Fetch latest `main` 2. Update the `group` and/or `visibility` in the module's manifest. 3. Run `node scripts/relocate --moveOnly @kbn/saved-objects-tagging-plugin` |
||
|
e8502c9fd7
|
[ML] Replace useIsDarkTheme() with EUI's colorMode . (#205079)
## Summary This PR replaces the `useIsDarkTheme()` hook with EUI's `colorMode`. Since this was the last hook in `@kbn/ml-kibana-theme` left this removes the whole package too. Note that the hook subscribed to an observable and was able to update the theme in place. EUI's `colorMode` will only be updated after a page refresh. Since updating the Kibana advanced setting to enable dark mode requires a full page refresh too, I guess it's fair to remove this behavior in favor of this simplification. In the long run we should aim for getting rid of these checks altogether and rely on dark-mode-aware EUI tokens. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. |
||
|
b1957ae209
|
[Stack Connectors][Microsoft Defender] Adds new connector for Microsoft Defender for Endpoint (#203183)
## Summary - New connector for Microsoft Defender for Endpoint. To be used in support of Security Solution Bi-Directional response actions. |
||
|
3bb50f7048
|
SKA: Move SharedUX packages under packages/core (#205608)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 13 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/core-chrome-browser-internal` | `src/core/packages/chrome/browser-internal` | | `@kbn/core-custom-branding-browser` | `src/core/packages/custom-branding/browser` | | `@kbn/core-custom-branding-browser-internal` | `src/core/packages/custom-branding/browser-internal` | | `@kbn/core-custom-branding-browser-mocks` | `src/core/packages/custom-branding/browser-mocks` | | `@kbn/core-custom-branding-common` | `src/core/packages/custom-branding/common` | | `@kbn/core-custom-branding-server` | `src/core/packages/custom-branding/server` | | `@kbn/core-custom-branding-server-internal` | `src/core/packages/custom-branding/server-internal` | | `@kbn/core-custom-branding-server-mocks` | `src/core/packages/custom-branding/server-mocks` | | `@kbn/core-ui-settings-browser` | `src/core/packages/ui-settings/browser` | | `@kbn/core-ui-settings-browser-internal` | `src/core/packages/ui-settings/browser-internal` | | `@kbn/core-ui-settings-common` | `src/core/packages/ui-settings/common` | | `@kbn/core-ui-settings-server` | `src/core/packages/ui-settings/server` | | `@kbn/core-ui-settings-server-internal` | `src/core/packages/ui-settings/server-internal` | <details > <summary>Updated references</summary> ``` ./docs/developer/architecture/core/patterns-scoped-services.asciidoc ./docs/developer/architecture/core/uisettings-service.asciidoc ./package.json ./packages/core/custom-branding/core-custom-branding-common/index.ts ./packages/kbn-ts-projects/config-paths.json ./src/core/packages/chrome/browser-internal/jest.config.js ./src/core/packages/custom-branding/browser-internal/jest.config.js ./src/core/packages/custom-branding/browser-mocks/jest.config.js ./src/core/packages/custom-branding/server-internal/jest.config.js ./src/core/packages/custom-branding/server-mocks/jest.config.js ./src/core/packages/ui-settings/browser-internal/jest.config.js ./src/core/packages/ui-settings/browser/jest.config.js ./src/core/packages/ui-settings/common/jest.config.js ./src/core/packages/ui-settings/server-internal/jest.config.js ./src/core/packages/ui-settings/server/jest.config.js ./src/platform/packages/private/kbn-repo-packages/package-map.json ./tsconfig.base.json ./x-pack/platform/plugins/private/transform/public/app/common/time_zone_utils.ts ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/core/packages/chrome/browser-internal/jest.config.js:12 src/core/packages/chrome/browser-internal/tsconfig.json:2 src/core/packages/custom-branding/browser-internal/jest.config.js:12 src/core/packages/custom-branding/browser-internal/tsconfig.json:2 src/core/packages/custom-branding/browser-mocks/jest.config.js:12 src/core/packages/custom-branding/browser-mocks/tsconfig.json:2 src/core/packages/custom-branding/browser/tsconfig.json:2 src/core/packages/custom-branding/common/tsconfig.json:2 src/core/packages/custom-branding/server-internal/jest.config.js:12 src/core/packages/custom-branding/server-internal/tsconfig.json:2 src/core/packages/custom-branding/server-mocks/jest.config.js:12 src/core/packages/custom-branding/server-mocks/tsconfig.json:2 src/core/packages/custom-branding/server/tsconfig.json:2 src/core/packages/ui-settings/browser-internal/jest.config.js:12 src/core/packages/ui-settings/browser-internal/tsconfig.json:2 src/core/packages/ui-settings/browser/jest.config.js:12 src/core/packages/ui-settings/browser/tsconfig.json:2 src/core/packages/ui-settings/common/jest.config.js:12 src/core/packages/ui-settings/common/tsconfig.json:2 src/core/packages/ui-settings/server-internal/jest.config.js:12 src/core/packages/ui-settings/server-internal/tsconfig.json:2 src/core/packages/ui-settings/server/jest.config.js:12 src/core/packages/ui-settings/server/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
|
9e1ff1f95d
|
Sustainable Kibana Architecture: Move reporting related packages (#205587)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 13 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/generate-csv` | `src/platform/packages/private/kbn-generate-csv` | | `@kbn/reporting-common` | `src/platform/packages/private/kbn-reporting/common` | | `@kbn/reporting-csv-share-panel` | `src/platform/packages/private/kbn-reporting/get_csv_panel_actions` | | `@kbn/reporting-export-types-csv` | `src/platform/packages/private/kbn-reporting/export_types/csv` | | `@kbn/reporting-export-types-csv-common` | `src/platform/packages/private/kbn-reporting/export_types/csv_common` | | `@kbn/reporting-export-types-pdf` | `src/platform/packages/private/kbn-reporting/export_types/pdf` | | `@kbn/reporting-export-types-pdf-common` | `src/platform/packages/private/kbn-reporting/export_types/pdf_common` | | `@kbn/reporting-export-types-png` | `src/platform/packages/private/kbn-reporting/export_types/png` | | `@kbn/reporting-export-types-png-common` | `src/platform/packages/private/kbn-reporting/export_types/png_common` | | `@kbn/reporting-mocks-server` | `src/platform/packages/private/kbn-reporting/mocks_server` | | `@kbn/reporting-public` | `src/platform/packages/private/kbn-reporting/public` | | `@kbn/reporting-server` | `src/platform/packages/private/kbn-reporting/server` | | `@kbn/screenshotting-server` | `src/platform/packages/private/kbn-screenshotting-server` | <details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-generate-csv/jest.config.js:12 src/platform/packages/private/kbn-generate-csv/tsconfig.json:2 src/platform/packages/private/kbn-generate-csv/tsconfig.type_check.json:2 src/platform/packages/private/kbn-generate-csv/tsconfig.type_check.json:23 src/platform/packages/private/kbn-generate-csv/tsconfig.type_check.json:26 src/platform/packages/private/kbn-generate-csv/tsconfig.type_check.json:29 src/platform/packages/private/kbn-generate-csv/tsconfig.type_check.json:32 src/platform/packages/private/kbn-generate-csv/tsconfig.type_check.json:56 src/platform/packages/private/kbn-reporting/common/jest.config.js:12 src/platform/packages/private/kbn-reporting/common/tsconfig.json:2 src/platform/packages/private/kbn-reporting/common/tsconfig.type_check.json:2 src/platform/packages/private/kbn-reporting/common/tsconfig.type_check.json:21 src/platform/packages/private/kbn-reporting/common/tsconfig.type_check.json:24 src/platform/packages/private/kbn-reporting/common/tsconfig.type_check.json:27 src/platform/packages/private/kbn-reporting/common/tsconfig.type_check.json:30 src/platform/packages/private/kbn-reporting/common/tsconfig.type_check.json:33 src/platform/packages/private/kbn-reporting/export_types/csv/jest.config.js:12 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.json:2 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:2 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:22 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:25 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:28 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:31 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:34 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:37 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:40 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:46 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:49 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:52 src/platform/packages/private/kbn-reporting/export_types/csv/tsconfig.type_check.json:55 src/platform/packages/private/kbn-reporting/export_types/csv_common/jest.config.js:12 src/platform/packages/private/kbn-reporting/export_types/csv_common/tsconfig.json:2 src/platform/packages/private/kbn-reporting/export_types/csv_common/tsconfig.type_check.json:2 src/platform/packages/private/kbn-reporting/export_types/csv_common/tsconfig.type_check.json:20 src/platform/packages/private/kbn-reporting/export_types/csv_common/tsconfig.type_check.json:23 src/platform/packages/private/kbn-reporting/export_types/csv_common/tsconfig.type_check.json:26 src/platform/packages/private/kbn-reporting/export_types/pdf/jest.config.js:12 src/platform/packages/private/kbn-reporting/export_types/pdf/tsconfig.json:2 src/platform/packages/private/kbn-reporting/export_types/pdf/tsconfig.type_check.json:2 src/platform/packages/private/kbn-reporting/export_types/pdf/tsconfig.type_check.json:21 src/platform/packages/private/kbn-reporting/export_types/pdf/tsconfig.type_check.json:24 src/platform/packages/private/kbn-reporting/export_types/pdf/tsconfig.type_check.json:27 src/platform/packages/private/kbn-reporting/export_types/pdf/tsconfig.type_check.json:30 src/platform/packages/private/kbn-reporting/export_types/pdf/tsconfig.type_check.json:36 src/platform/packages/private/kbn-reporting/export_types/pdf/tsconfig.type_check.json:39 src/platform/packages/private/kbn-reporting/export_types/pdf_common/tsconfig.json:2 src/platform/packages/private/kbn-reporting/export_types/pdf_common/tsconfig.type_check.json:2 src/platform/packages/private/kbn-reporting/export_types/pdf_common/tsconfig.type_check.json:20 src/platform/packages/private/kbn-reporting/export_types/pdf_common/tsconfig.type_check.json:23 src/platform/packages/private/kbn-reporting/export_types/png/jest.config.js:12 src/platform/packages/private/kbn-reporting/export_types/png/tsconfig.json:2 src/platform/packages/private/kbn-reporting/export_types/png/tsconfig.type_check.json:2 src/platform/packages/private/kbn-reporting/export_types/png/tsconfig.type_check.json:22 src/platform/packages/private/kbn-reporting/export_types/png/tsconfig.type_check.json:25 src/platform/packages/private/kbn-reporting/export_types/png/tsconfig.type_check.json:28 src/platform/packages/private/kbn-reporting/export_types/png/tsconfig.type_check.json:31 src/platform/packages/private/kbn-reporting/export_types/png/tsconfig.type_check.json:37 src/platform/packages/private/kbn-reporting/export_types/png/tsconfig.type_check.json:40 src/platform/packages/private/kbn-reporting/export_types/png_common/tsconfig.json:2 src/platform/packages/private/kbn-reporting/export_types/png_common/tsconfig.type_check.json:2 src/platform/packages/private/kbn-reporting/export_types/png_common/tsconfig.type_check.json:20 src/platform/packages/private/kbn-reporting/export_types/png_common/tsconfig.type_check.json:23 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/jest.config.js:12 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.json:2 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:2 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:21 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:24 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:27 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:33 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:36 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:39 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:42 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:45 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:48 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:51 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:54 src/platform/packages/private/kbn-reporting/get_csv_panel_actions/tsconfig.type_check.json:60 src/platform/packages/private/kbn-reporting/mocks_server/jest.config.js:12 src/platform/packages/private/kbn-reporting/mocks_server/tsconfig.json:2 src/platform/packages/private/kbn-reporting/mocks_server/tsconfig.type_check.json:2 src/platform/packages/private/kbn-reporting/public/jest.config.js:12 src/platform/packages/private/kbn-reporting/public/tsconfig.json:2 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:2 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:24 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:27 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:30 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:33 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:36 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:39 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:42 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:45 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:57 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:60 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:63 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:66 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:69 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:72 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:75 src/platform/packages/private/kbn-reporting/public/tsconfig.type_check.json:78 src/platform/packages/private/kbn-reporting/server/jest.config.js:12 src/platform/packages/private/kbn-reporting/server/tsconfig.json:2 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:2 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:21 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:24 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:27 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:30 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:33 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:36 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:42 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:45 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:48 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:51 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:54 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:57 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:60 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:63 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:66 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:69 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:72 src/platform/packages/private/kbn-reporting/server/tsconfig.type_check.json:75 src/platform/packages/private/kbn-screenshotting-server/jest.config.js:12 src/platform/packages/private/kbn-screenshotting-server/src/paths.ts:106 src/platform/packages/private/kbn-screenshotting-server/tsconfig.json:2 src/platform/packages/private/kbn-screenshotting-server/tsconfig.type_check.json:2 src/platform/packages/private/kbn-screenshotting-server/tsconfig.type_check.json:20 ``` </details> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
|
175916ef23
|
Sustainable Kibana Architecture: Move packages under packages/shared-ux/ (#205602)
|