mirror of
https://github.com/elastic/kibana.git
synced 2025-04-22 17:04:01 -04:00
4847 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Davis McPhee
|
b53d3990a2
|
[Saved Queries] Rework saved query privileges (#202863)
## Summary This PR reworks saved query privileges to rely solely on a single global `savedQueryManagement` privilege, and eliminates app-specific overrides. This change simplifies the security model for users, fixes bugginess in the saved query management UI, and reduces code complexity associated with maintaining two separate security mechanisms (app-specific overrides and global saved query management privileges). ### Background Saved queries allow users to store a combination of KQL or Lucene queries, filters, and time filters to use across various applications in Kibana. Access to saved query saved objects are currently granted by the following feature privileges: ```json [ "feature_discover.all", "feature_dashboard.all", "feature_savedQueryManagement.all", "feature_maps.all", "feature_savedObjectsManagement.all", "feature_visualize.all" ] ``` There is also a saved query management UI within the Unified Search bar shared by applications across Kibana: <img src="https://github.com/user-attachments/assets/e4a7539b-3dd4-4d47-9ff8-205281ef50e3" width="500" /> The way access to this UI is managed in Kibana is currently confusing and buggy: - If a user has `feature_discover.all` and `feature_dashboard.all` they will be able to load and save queries in Discover and Dashboard. - If a user has `feature_discover.all` and `feature_dashboard.read` they will be able to load queries in both Discover and Dashboard, but only save queries in Discover (even though they have write access to the SO, and API access). Instead they have to navigate to Discover to save a query before navigating back to Dashboard to load it, making for a confusing and frustrating UX. - Access to the UI is even more confusing in apps not listed in the above feature privileges (e.g. alerting, SLOs). Some of them chose to check one of the above feature privileges, meaning users who otherwise should have saved query access won't see the management UI if they don't also have the exact feature privilege being checked. Other apps just always show the management UI, leading to bugs and failures when users without one of the above feature privileges attempt to save queries. ### Existing improvements In v8.11.0, we introduced a new ["Saved Query Management"](https://github.com/elastic/kibana/pull/166937) privilege, allowing users to access saved queries across all of Kibana with a single global privilege: <img src="https://github.com/user-attachments/assets/ccbe79a4-bd0b-4ed6-89c9-117cc1f99ee2" width="600" /> When this privilege is added to a role, it solves the `feature_discover.all` and `feature_dashboard.read` issue mentioned above. However, it does not fix any of the mentioned issues for roles without the new privilege. We have so far postponed further improvements to avoid a breaking change. ### Approach To fully resolve these issues and migrate to a single global privilege, these changes have been made: - Remove saved query SO access from all application feature privileges and instead only allow access through the global saved query management privilege. - Stop relying on application feature privileges for toggling the saved query management UI, and instead rely on the global privilege. To implement this with minimal breaking changes, we've used the Kibana privilege migration framework. This allows us to seamlessly migrate existing roles containing feature privileges that currently provide access to saved queries, ensuring they are assigned the global saved query management privilege on upgrade. As a result, we had to deprecate the following feature privileges, replacing them with V2 privileges without saved query SO access: ```json [ "feature_discover.all", "feature_dashboard.all", "feature_maps.all", "feature_visualize.all" ] ``` Each area of code that currently relies on any of these feature privileges had to be updated to instead access `feature_X_V2` instead (as well as future code). This PR still introduces a minor breaking change, since users who have `feature_discover.all` and `feature_dashboard.read` are now able to save queries in Dashboard after upgrade, but we believe this is a better UX (and likely the expected one) and worth a small breaking change. ### Testing - All existing privileges should continue to work as they do now, including deprecated V1 feature privileges and customized serverless privileges. There should be no changes for existing user roles apart from the minor breaking change outlined above. - Check that code changes in your area don't introduce breaking changes to existing behaviour. Many of the changes are just updating client UI capabilities code from `feature.privilege` to `feature_v2.privilege`, which is backward compatible. - The `savedQueryManagement` feature should now globally control access to saved query management in Unified Search for all new user roles. Regardless of privileges for Discover, Dashboard, Maps, or Visualize, new user roles should follow this behaviour: - If `savedQueryManagement` is `none`, the user cannot see or access the saved query management UI or APIs. - If `savedQueryManagement` is `read`, the user can load queries from the UI and access read APIs, but cannot save queries from the UI or make changes to queries through APIs. - If `savedQueryManagement` is `all`, the user can both load and save queries from the UI and through APIs. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks This PR risks introducing unintended breaking changes to user privileges related to saved queries if the deprecated features have not been properly migrated, and users could gain or lose access to saved query management on upgrade. This would be bad if it happened, but not overly severe since it wouldn't grant them access to any ES data they couldn't previously access (only query saved objects). We have automated testing in place to help ensure features have been migrated correctly, but the scope of these changes are broad and touch many places in the codebase. Additionally, the UI capabilities types are not very strict, and are referenced with string paths in many places, which makes changing them riskier than changing strictly typed code. A combination of regex searches and temporarily modifying the `Capabilities` type to cause type errors for deprecated privileges was used to identify references in code. Reviewers should consider if there are any other ways that UI capabilities can be referenced which were not addressed in this PR. Our automated tests already help mitigate the risk, but it's important that code owners thoroughly review the changes in their area and consider if they could have unintended consequences. The Platform Security team should also review this PR thoroughly, especially since some changes were made to platform code around privilege handling. The Data Discovery team will also manually test the behaviour when upgrading existing user roles with deprecated feature privileges as part of 9.0 upgrade testing. --------- Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co> Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: “jeramysoucy” <jeramy.soucy@elastic.co> |
||
Xavier Merlin
|
199e75e51f
|
Update Dev Tool limitation about high availability. (#172507)
Updating limitation of dev tool which is not sending request with round
robin
## Summary
We believe Console always tries to connect to the 1st host in
elasticsearch.hosts but if it's unavailable then it will try the next
one, the code for this can be found
[here](
|
||
Gerard Soldevila
|
4a00449bdc
|
SKA: Relocate core mock and test-helper modules (#208538)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 55 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/core-analytics-browser-mocks` | `src/core/packages/analytics/browser-mocks` | | `@kbn/core-analytics-server-mocks` | `src/core/packages/analytics/server-mocks` | | `@kbn/core-application-browser-mocks` | `src/core/packages/application/browser-mocks` | | `@kbn/core-apps-browser-mocks` | `src/core/packages/apps/browser-mocks` | | `@kbn/core-base-browser-mocks` | `src/core/packages/base/browser-mocks` | | `@kbn/core-base-server-mocks` | `src/core/packages/base/server-mocks` | | `@kbn/core-capabilities-browser-mocks` | `src/core/packages/capabilities/browser-mocks` | | `@kbn/core-capabilities-server-mocks` | `src/core/packages/capabilities/server-mocks` | | `@kbn/core-chrome-browser-mocks` | `src/core/packages/chrome/browser-mocks` | | `@kbn/core-deprecations-browser-mocks` | `src/core/packages/deprecations/browser-mocks` | | `@kbn/core-deprecations-server-mocks` | `src/core/packages/deprecations/server-mocks` | | `@kbn/core-doc-links-browser-mocks` | `src/core/packages/doc-links/browser-mocks` | | `@kbn/core-doc-links-server-mocks` | `src/core/packages/doc-links/server-mocks` | | `@kbn/core-elasticsearch-client-server-mocks` | `src/core/packages/elasticsearch/client-server-mocks` | | `@kbn/core-elasticsearch-server-mocks` | `src/core/packages/elasticsearch/server-mocks` | | `@kbn/core-environment-server-mocks` | `src/core/packages/environment/server-mocks` | | `@kbn/core-execution-context-browser-mocks` | `src/core/packages/execution-context/browser-mocks` | | `@kbn/core-execution-context-server-mocks` | `src/core/packages/execution-context/server-mocks` | | `@kbn/core-fatal-errors-browser-mocks` | `src/core/packages/fatal-errors/browser-mocks` | | `@kbn/core-http-browser-mocks` | `src/core/packages/http/browser-mocks` | | `@kbn/core-http-context-server-mocks` | `src/core/packages/http/context-server-mocks` | | `@kbn/core-http-resources-server-mocks` | `src/core/packages/http/resources-server-mocks` | | `@kbn/core-http-router-server-mocks` | `src/core/packages/http/router-server-mocks` | | `@kbn/core-http-server-mocks` | `src/core/packages/http/server-mocks` | | `@kbn/core-i18n-browser-mocks` | `src/core/packages/i18n/browser-mocks` | | `@kbn/core-i18n-server-mocks` | `src/core/packages/i18n/server-mocks` | | `@kbn/core-injected-metadata-browser-mocks` | `src/core/packages/injected-metadata/browser-mocks` | | `@kbn/core-integrations-browser-mocks` | `src/core/packages/integrations/browser-mocks` | | `@kbn/core-lifecycle-browser-mocks` | `src/core/packages/lifecycle/browser-mocks` | | `@kbn/core-lifecycle-server-mocks` | `src/core/packages/lifecycle/server-mocks` | | `@kbn/core-logging-browser-mocks` | `src/core/packages/logging/browser-mocks` | | `@kbn/core-logging-server-mocks` | `src/core/packages/logging/server-mocks` | | `@kbn/core-metrics-collectors-server-mocks` | `src/core/packages/metrics/collectors-server-mocks` | | `@kbn/core-metrics-server-mocks` | `src/core/packages/metrics/server-mocks` | | `@kbn/core-node-server-mocks` | `src/core/packages/node/server-mocks` | | `@kbn/core-notifications-browser-mocks` | `src/core/packages/notifications/browser-mocks` | | `@kbn/core-overlays-browser-mocks` | `src/core/packages/overlays/browser-mocks` | | `@kbn/core-plugins-browser-mocks` | `src/core/packages/plugins/browser-mocks` | | `@kbn/core-plugins-server-mocks` | `src/core/packages/plugins/server-mocks` | | `@kbn/core-preboot-server-mocks` | `src/core/packages/preboot/server-mocks` | | `@kbn/core-rendering-browser-mocks` | `src/core/packages/rendering/browser-mocks` | | `@kbn/core-rendering-server-mocks` | `src/core/packages/rendering/server-mocks` | | `@kbn/core-saved-objects-api-server-mocks` | `src/core/packages/saved-objects/api-server-mocks` | | `@kbn/core-saved-objects-base-server-mocks` | `src/core/packages/saved-objects/base-server-mocks` | | `@kbn/core-saved-objects-browser-mocks` | `src/core/packages/saved-objects/browser-mocks` | | `@kbn/core-saved-objects-import-export-server-mocks` | `src/core/packages/saved-objects/import-export-server-mocks` | | `@kbn/core-saved-objects-migration-server-mocks` | `src/core/packages/saved-objects/migration-server-mocks` | | `@kbn/core-saved-objects-server-mocks` | `src/core/packages/saved-objects/server-mocks` | | `@kbn/core-status-server-mocks` | `src/core/packages/status/server-mocks` | | `@kbn/core-test-helpers-kbn-server` | `src/dev/packages/core-test-helpers-kbn-server` | | `@kbn/core-test-helpers-model-versions` | `src/dev/packages/core-test-helpers-model-versions` | | `@kbn/core-theme-browser-mocks` | `src/core/packages/theme/browser-mocks` | | `@kbn/core-ui-settings-browser-mocks` | `src/core/packages/ui-settings/browser-mocks` | | `@kbn/core-ui-settings-server-mocks` | `src/core/packages/ui-settings/server-mocks` | | `@kbn/core-usage-data-server-mocks` | `src/core/packages/usage-data/server-mocks` | <details > <summary>Updated references</summary> ``` ./.github/codeql/codeql-config.yml ./package.json ./packages/kbn-ts-projects/config-paths.json ./src/core/packages/analytics/browser-mocks/jest.config.js ./src/core/packages/analytics/server-mocks/jest.config.js ./src/core/packages/application/browser-mocks/jest.config.js ./src/core/packages/apps/browser-mocks/jest.config.js ./src/core/packages/base/browser-mocks/jest.config.js ./src/core/packages/base/server-mocks/jest.config.js ./src/core/packages/capabilities/browser-mocks/jest.config.js ./src/core/packages/capabilities/server-mocks/jest.config.js ./src/core/packages/chrome/browser-mocks/jest.config.js ./src/core/packages/deprecations/browser-mocks/jest.config.js ./src/core/packages/deprecations/server-mocks/jest.config.js ./src/core/packages/doc-links/browser-mocks/jest.config.js ./src/core/packages/doc-links/server-mocks/jest.config.js ./src/core/packages/elasticsearch/client-server-mocks/jest.config.js ./src/core/packages/elasticsearch/server-mocks/jest.config.js ./src/core/packages/environment/server-mocks/jest.config.js ./src/core/packages/execution-context/browser-mocks/jest.config.js ./src/core/packages/execution-context/server-mocks/jest.config.js ./src/core/packages/fatal-errors/browser-mocks/jest.config.js ./src/core/packages/http/browser-mocks/jest.config.js ./src/core/packages/http/context-server-mocks/jest.config.js ./src/core/packages/http/resources-server-mocks/jest.config.js ./src/core/packages/http/router-server-mocks/jest.config.js ./src/core/packages/http/server-mocks/jest.config.js ./src/core/packages/i18n/browser-mocks/jest.config.js ./src/core/packages/i18n/server-mocks/jest.config.js ./src/core/packages/injected-metadata/browser-mocks/jest.config.js ./src/core/packages/integrations/browser-mocks/jest.config.js ./src/core/packages/lifecycle/browser-mocks/jest.config.js ./src/core/packages/lifecycle/server-mocks/jest.config.js ./src/core/packages/logging/browser-mocks/jest.config.js ./src/core/packages/logging/server-mocks/jest.config.js ./src/core/packages/metrics/collectors-server-mocks/jest.config.js ./src/core/packages/metrics/server-mocks/jest.config.js ./src/core/packages/node/server-mocks/jest.config.js ./src/core/packages/notifications/browser-mocks/jest.config.js ./src/core/packages/overlays/browser-mocks/jest.config.js ./src/core/packages/plugins/browser-mocks/jest.config.js ./src/core/packages/plugins/server-mocks/jest.config.js ./src/core/packages/preboot/server-mocks/jest.config.js ./src/core/packages/rendering/browser-mocks/jest.config.js ./src/core/packages/rendering/server-mocks/jest.config.js ./src/core/packages/saved-objects/api-server-mocks/jest.config.js ./src/core/packages/saved-objects/base-server-mocks/jest.config.js ./src/core/packages/saved-objects/browser-mocks/jest.config.js ./src/core/packages/saved-objects/import-export-server-mocks/jest.config.js ./src/core/packages/saved-objects/migration-server-mocks/jest.config.js ./src/core/packages/saved-objects/server-mocks/jest.config.js ./src/core/packages/status/server-mocks/jest.config.js ./src/core/packages/theme/browser-mocks/jest.config.js ./src/core/packages/ui-settings/browser-mocks/jest.config.js ./src/core/packages/ui-settings/server-mocks/jest.config.js ./src/core/packages/usage-data/server-mocks/jest.config.js ./src/core/system/tsconfig.type_check.json ./src/dev/packages/core-test-helpers-kbn-server/jest.config.js ./src/dev/packages/core-test-helpers-model-versions/jest.config.js ./src/dev/tsconfig.type_check.json ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/plugins/private/interactive_setup/tsconfig.type_check.json ./src/platform/plugins/shared/console/tsconfig.type_check.json ./src/plugins/kibana_usage_collection/tsconfig.type_check.json ./src/plugins/saved_objects_management/tsconfig.type_check.json ./src/plugins/telemetry/tsconfig.type_check.json ./src/plugins/usage_collection/tsconfig.type_check.json ./tsconfig.base.json ./tsconfig.base.type_check.json ./tsconfig.refs.json ./x-pack/platform/plugins/private/index_lifecycle_management/tsconfig.type_check.json ./x-pack/platform/plugins/private/remote_clusters/tsconfig.type_check.json ./x-pack/platform/plugins/private/snapshot_restore/tsconfig.type_check.json ./x-pack/platform/plugins/private/watcher/tsconfig.type_check.json ./x-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.type_check.json ./x-pack/platform/plugins/shared/fleet/tsconfig.type_check.json ./x-pack/platform/plugins/shared/security/tsconfig.type_check.json ./x-pack/platform/plugins/shared/spaces/tsconfig.type_check.json ./x-pack/plugins/actions/tsconfig.type_check.json ./x-pack/plugins/aiops/tsconfig.type_check.json ./x-pack/plugins/alerting/tsconfig.type_check.json ./x-pack/plugins/cases/tsconfig.type_check.json ./x-pack/plugins/enterprise_search/tsconfig.type_check.json ./x-pack/plugins/integration_assistant/tsconfig.type_check.json ./x-pack/plugins/ml/tsconfig.type_check.json ./x-pack/plugins/observability_solution/apm/tsconfig.type_check.json ./x-pack/plugins/observability_solution/apm_data_access/tsconfig.type_check.json ./x-pack/plugins/observability_solution/entity_manager/tsconfig.type_check.json ./x-pack/plugins/observability_solution/exploratory_view/tsconfig.type_check.json ./x-pack/plugins/observability_solution/observability/tsconfig.type_check.json ./x-pack/plugins/observability_solution/slo/tsconfig.type_check.json ./x-pack/plugins/observability_solution/synthetics/tsconfig.type_check.json ./x-pack/plugins/observability_solution/uptime/tsconfig.type_check.json ./x-pack/plugins/rule_registry/tsconfig.type_check.json ./x-pack/plugins/search_playground/tsconfig.type_check.json ./x-pack/plugins/serverless_search/tsconfig.type_check.json ./x-pack/plugins/stack_alerts/tsconfig.type_check.json ./x-pack/plugins/stack_connectors/tsconfig.type_check.json ./x-pack/plugins/task_manager/tsconfig.type_check.json ./x-pack/plugins/transform/tsconfig.type_check.json ./x-pack/solutions/observability/plugins/dataset_quality/tsconfig.type_check.json ./x-pack/solutions/security/packages/security-solution/ecs_data_quality_dashboard/tsconfig.type_check.json ./x-pack/solutions/security/plugins/ecs_data_quality_dashboard/tsconfig.type_check.json ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/core/packages/analytics/browser-mocks/jest.config.js:12 src/core/packages/analytics/browser-mocks/tsconfig.json:2 src/core/packages/analytics/server-mocks/jest.config.js:12 src/core/packages/analytics/server-mocks/tsconfig.json:2 src/core/packages/application/browser-mocks/jest.config.js:12 src/core/packages/application/browser-mocks/tsconfig.json:2 src/core/packages/apps/browser-mocks/jest.config.js:12 src/core/packages/apps/browser-mocks/tsconfig.json:2 src/core/packages/base/browser-mocks/jest.config.js:12 src/core/packages/base/browser-mocks/tsconfig.json:2 src/core/packages/base/server-mocks/jest.config.js:12 src/core/packages/base/server-mocks/tsconfig.json:2 src/core/packages/capabilities/browser-mocks/jest.config.js:12 src/core/packages/capabilities/browser-mocks/tsconfig.json:2 src/core/packages/capabilities/server-mocks/jest.config.js:12 src/core/packages/capabilities/server-mocks/tsconfig.json:2 src/core/packages/chrome/browser-mocks/jest.config.js:12 src/core/packages/chrome/browser-mocks/tsconfig.json:2 src/core/packages/deprecations/browser-mocks/jest.config.js:12 src/core/packages/deprecations/browser-mocks/tsconfig.json:2 src/core/packages/deprecations/server-mocks/jest.config.js:12 src/core/packages/deprecations/server-mocks/tsconfig.json:2 src/core/packages/doc-links/browser-mocks/jest.config.js:12 src/core/packages/doc-links/browser-mocks/tsconfig.json:2 src/core/packages/doc-links/server-mocks/jest.config.js:12 src/core/packages/doc-links/server-mocks/tsconfig.json:2 src/core/packages/elasticsearch/client-server-mocks/jest.config.js:12 src/core/packages/elasticsearch/client-server-mocks/tsconfig.json:2 src/core/packages/elasticsearch/server-mocks/jest.config.js:12 src/core/packages/elasticsearch/server-mocks/tsconfig.json:2 src/core/packages/environment/server-mocks/jest.config.js:12 src/core/packages/environment/server-mocks/tsconfig.json:2 src/core/packages/execution-context/browser-mocks/jest.config.js:12 src/core/packages/execution-context/browser-mocks/tsconfig.json:2 src/core/packages/execution-context/server-mocks/jest.config.js:12 src/core/packages/execution-context/server-mocks/tsconfig.json:2 src/core/packages/fatal-errors/browser-mocks/jest.config.js:12 src/core/packages/fatal-errors/browser-mocks/tsconfig.json:2 src/core/packages/http/browser-mocks/jest.config.js:12 src/core/packages/http/browser-mocks/tsconfig.json:2 src/core/packages/http/context-server-mocks/jest.config.js:12 src/core/packages/http/context-server-mocks/tsconfig.json:2 src/core/packages/http/resources-server-mocks/jest.config.js:12 src/core/packages/http/resources-server-mocks/tsconfig.json:2 src/core/packages/http/router-server-mocks/jest.config.js:12 src/core/packages/http/router-server-mocks/tsconfig.json:2 src/core/packages/http/server-mocks/jest.config.js:12 src/core/packages/http/server-mocks/tsconfig.json:2 src/core/packages/i18n/browser-mocks/jest.config.js:12 src/core/packages/i18n/browser-mocks/tsconfig.json:2 src/core/packages/i18n/server-mocks/jest.config.js:12 src/core/packages/i18n/server-mocks/tsconfig.json:2 src/core/packages/injected-metadata/browser-mocks/jest.config.js:12 src/core/packages/injected-metadata/browser-mocks/tsconfig.json:2 src/core/packages/integrations/browser-mocks/jest.config.js:12 src/core/packages/integrations/browser-mocks/tsconfig.json:2 src/core/packages/lifecycle/browser-mocks/jest.config.js:12 src/core/packages/lifecycle/browser-mocks/tsconfig.json:2 src/core/packages/lifecycle/server-mocks/jest.config.js:12 src/core/packages/lifecycle/server-mocks/tsconfig.json:2 src/core/packages/logging/browser-mocks/jest.config.js:12 src/core/packages/logging/browser-mocks/tsconfig.json:2 src/core/packages/logging/server-mocks/jest.config.js:12 src/core/packages/logging/server-mocks/tsconfig.json:2 src/core/packages/metrics/collectors-server-mocks/jest.config.js:12 src/core/packages/metrics/collectors-server-mocks/tsconfig.json:2 src/core/packages/metrics/server-mocks/jest.config.js:12 src/core/packages/metrics/server-mocks/tsconfig.json:2 src/core/packages/node/server-mocks/jest.config.js:12 src/core/packages/node/server-mocks/tsconfig.json:2 src/core/packages/notifications/browser-mocks/jest.config.js:12 src/core/packages/notifications/browser-mocks/tsconfig.json:2 src/core/packages/overlays/browser-mocks/jest.config.js:12 src/core/packages/overlays/browser-mocks/tsconfig.json:2 src/core/packages/plugins/browser-mocks/jest.config.js:12 src/core/packages/plugins/browser-mocks/tsconfig.json:2 src/core/packages/plugins/server-mocks/jest.config.js:12 src/core/packages/plugins/server-mocks/tsconfig.json:2 src/core/packages/preboot/server-mocks/jest.config.js:12 src/core/packages/preboot/server-mocks/tsconfig.json:2 src/core/packages/rendering/browser-mocks/jest.config.js:12 src/core/packages/rendering/browser-mocks/tsconfig.json:2 src/core/packages/rendering/server-mocks/jest.config.js:12 src/core/packages/rendering/server-mocks/tsconfig.json:2 src/core/packages/saved-objects/api-server-mocks/jest.config.js:12 src/core/packages/saved-objects/api-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/base-server-mocks/jest.config.js:12 src/core/packages/saved-objects/base-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/browser-mocks/jest.config.js:12 src/core/packages/saved-objects/browser-mocks/tsconfig.json:2 src/core/packages/saved-objects/import-export-server-mocks/jest.config.js:12 src/core/packages/saved-objects/import-export-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/migration-server-mocks/jest.config.js:12 src/core/packages/saved-objects/migration-server-mocks/tsconfig.json:2 src/core/packages/saved-objects/server-mocks/jest.config.js:12 src/core/packages/saved-objects/server-mocks/tsconfig.json:2 src/core/packages/status/server-mocks/jest.config.js:12 src/core/packages/status/server-mocks/tsconfig.json:2 src/core/packages/theme/browser-mocks/jest.config.js:12 src/core/packages/theme/browser-mocks/tsconfig.json:2 src/core/packages/ui-settings/browser-mocks/jest.config.js:12 src/core/packages/ui-settings/browser-mocks/tsconfig.json:2 src/core/packages/ui-settings/server-mocks/jest.config.js:12 src/core/packages/ui-settings/server-mocks/tsconfig.json:2 src/core/packages/usage-data/server-mocks/jest.config.js:12 src/core/packages/usage-data/server-mocks/tsconfig.json:2 src/dev/packages/core-test-helpers-kbn-server/jest.config.js:12 src/dev/packages/core-test-helpers-kbn-server/tsconfig.json:2 src/dev/packages/core-test-helpers-model-versions/jest.config.js:12 src/dev/packages/core-test-helpers-model-versions/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com> |
||
Liam Thompson
|
6a42ec9b23
|
[DOCS] Give finding apps and objects section an ID (#199352)
That way we can internally link to this beautiful section using `<<angle-brackets-and-stuff>>` --------- Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> |
||
Tim Sullivan
|
5f59395f18
|
Update Reporting documentation: ES configuration, avoiding Token expiration (#208257)
## Summary Closes https://github.com/elastic/kibana/issues/201281 Closes https://github.com/elastic/kibana/issues/200653 --------- Co-authored-by: wajihaparvez <wajiha.parvez@elastic.co> |
||
Joseph AFARI
|
66c49cdd5c
|
Update elasticsearch-details.asciidoc (#184412)
## Summary Adding a note that for logs, in case the name of the filebeat index was changed, it's needed to adjust `monitoring.ui.logs.index` so that the logs stats can be retrieved as well |
||
Jure Tratnjek
|
4cf60d60cf
|
Update manage-cases.asciidoc (#193135)
In step 2 I added where exactly notifications.connectors.default is set in configuration. It did not explicitly say that it should be set in kibana.yml, also added configuration example. A reminder to set default connector should probably need to be added to this page as well: https://www.elastic.co/guide/en/kibana/current/pre-configured-connectors.html ## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> |
||
Lukas Olson
|
b998946003
|
Add warnings to upgrade assistant for search sessions (#206998)
## Summary Part of https://github.com/elastic/kibana/issues/203925. Resolves https://github.com/elastic/kibana/issues/205813. Adds warning messages to the upgrade assistant if a cluster has unexpired search sessions, since the feature is being disabled by default and will have to be explicitly re-enabled to manage the sessions. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com> |
||
Hanna Tamoudi
|
06d16614a9
|
[Automatic Import] rename plugin to automatic import (#207325)
## Summary Rename `integration-assistant` plugin to `automatic-import`. |
||
Jesus Wahrman
|
23b7f0fb33
|
[HTTP] Log deprecated api usages (#207904)
## Summary Resolves https://github.com/elastic/kibana/issues/199616 Added a debug logger when calling deprecated APIs. This logger is disabled by default, to enable it you have to set `deprecation.enable_http_debug_logs: true`. To test this you can play with the config value and do a request like this to a deprecated endpoint: ```shell #!/bin/bash API_KEY="" curl -X GET "http://localhost:5601/api/cases/status" -i \ -H "Content-Type: application/json" \ -H "Authorization: ApiKey $API_KEY" ``` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> |
||
|
Gerard Soldevila
|
fb26c1c683
|
SKA: Update broken references and URLs (#206836)
## Summary Updates a number of broken file references and broken links. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com> |
||
Lisa Cawley
|
5624fc2106
|
[DOCS] Clarify alerting API key management (#208292) | ||
Michael Dokolin
|
52b7bc6f06
|
[HTTP] Add a circuit breaker for the HTTP server (#190684)
This PR resolves #194605 and closes #170132 and brings the following changes: - changed ELU metrics evaluation used for autoscaling; - a rate limiter to throttle incoming requests when under a high load; - a configuration option to exclude some routes from the rate limiter. |
||
Christiane (Tina) Heiligers
|
45634ed2da
|
[UA] Allows upgrades on cloud for minor versions (#208309)
fix https://github.com/elastic/kibana/issues/206468 ## Summary Upgrade Assistant treats upgrading to a minor or patch in the same way as for a major and blocks the upgrade when there are critical deprecations. Critical deprecations only have to be resolved before upgrading to the next major version and should not prevent upgrading to a minor or patch. This PR refactors the blocking behavior and allows non-major upgrades for healthy clusters. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] Cloud UI does not adapt the API to handle a query. Without query support, calls to the API may not work as intended, or fail. Reverting this PR will block upgrades to non major versions (next minor, next patch) if there are critical deprecations that have not been resolved. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
|
Gerard Soldevila
|
d5764b3ee8
|
SKA: Follow-up relocation (#207041)
## Summary * @kbn/observability-ai-assistant-plugin: Simplify location ``` x-pack/platform/plugins/shared/observability_solution/observability_ai_assistant # becomes x-pack/platform/plugins/shared/observability_ai_assistant ``` * @kbn/search-shared-ui: Simplify location ``` x-pack/solutions/search/packages/search/shared_ui # becomes x-pack/solutions/search/packages/shared_ui ``` <details > <summary>Updated references</summary> ``` ./.github/paths-labeller.yml ./docs/developer/plugin-list.asciidoc ./package.json ./packages/kbn-relocate/utils/transforms.ts ./packages/kbn-ts-projects/config-paths.json ./src/dev/storybook/aliases.ts ./src/platform/packages/private/kbn-repo-packages/package-map.json ./tsconfig.base.json ./x-pack/.i18nrc.json ./x-pack/platform/plugins/shared/observability_ai_assistant/jest.config.js ./x-pack/solutions/search/packages/shared_ui/jest.config.js ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` x-pack/platform/plugins/shared/observability_ai_assistant/jest.config.js:10 x-pack/platform/plugins/shared/observability_ai_assistant/tsconfig.json:2 x-pack/platform/plugins/shared/observability_ai_assistant/tsconfig.json:7 x-pack/solutions/search/packages/shared_ui/jest.config.js:16 x-pack/solutions/search/packages/shared_ui/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
Shahzad
|
e51b2bda27
|
[Synthetics] Space aware private locations !! (#202634)
## Summary Fixes https://github.com/elastic/kibana/issues/199976 User can choose which space the location will be visible in while creating a location !! ### Testing - [ ] Create location in all spaces and make sure it's visible everywhere. - [ ] Creation location in a specific space and make sure it's only visible in specified space <img width="1728" alt="image" src="https://github.com/user-attachments/assets/6aa5cac9-500a-447a-8ef5-bf53e91a16dd" /> |
||
|
Davis McPhee
|
665cfe06a6
|
[Discover] Clean up leftover "saved search" references (#208295)
## Summary I noticed a few remaining user facing references to "saved search" after the renaming in #202217. This PR cleans up all of them that I could find. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) |
||
Jorge Sanz
|
052ec56d5c
|
[Maps][Vega] Update default basemaps to adapt to the Borealis theme refresh (#208114)
Fixes #201269 ## Summary * Extracts the usage of the EMS styles identifiers to always refer to the constants at `ems_defaults.ts` * Adds logic in the Vega and Maps plugins to resolve different styles depending on the theme, bringing the new `road_map_desaturated_v9` and `dar_kmap_v9` styles when Borealis theme is enabled. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - Screenshots will be updated as a larger effort afterwards. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - Changes were small enough for this to not require new tests. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. ## Release note Elastic Maps Service basemaps shown in the Custom Visualization component (Vega) and in the Maps application and components alighn with the new dark and light theme. --------- Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com> |
||
Brandon Morelli
|
4f3a1c94f8
|
Remove complex tables (#207911)
### Summary For migration purposes, we need to remove complex tables in the docs. If we ultimately decide that we need complex tables to support certain documentation use-cases, we can add that functionality to docs-builder later. For https://github.com/elastic/docs-builder/issues/112#issuecomment-2599284112. Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> |
||
Rickyanto Ang
|
a2d36067e9
|
[Cloud Security] Deleting K8S Dashboard (#207127)
## Summary As K8S Dashboard is currently hidden on main , the code serves no purpose other than potentially causing Tech debts whenever a refactor or a migration happens. As such its better to remove it completely. In case we want to bring it back later we will just pull it from git history > [!CAUTION] > **This should only affect Serverless and Main, 8.x.x should still be able to see and access K8S Dashboard** ## Related Tickets - https://github.com/elastic/security-team/issues/11418 - https://github.com/elastic/security-team/issues/10735 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Paulo Silva <paulo.henrique@elastic.co> Co-authored-by: Maxim Kholod <maxim.kholod@elastic.co> |
||
Yuliia Naumenko
|
7f98b6bf5d
|
[Inference AI Connector] Added elastic provider for EIS and enhancements (#205672)
## Summary Current PR creates a new platform shared plugin named `inference_endpoint` to expose in Kibana the new internal API `_inference/_services`, which returns the list of inference providers with the configuration settings. Changed `@kbn/inference_endpoint_ui_common` package to fetch dynamically the list of providers by using the route introduced in `inference_endpoint` plugin. Added fields settings filter based on the selected task in the `supported_task_types`. Cleaned up the types consolidating all in the package `@kbn/inference_endpoint_ui_common`. Changed .inference connector to use `unified_completion` subAction for selected `chat_completion` task type. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co> |
||
|
Yuliia Naumenko
|
c15674f6d1
|
[Connectors] Allow pre-configured connectors to opt-in to exposing their config by setting exposeConfig (#207654)
Resolves #206433 Added optional `exposeConfig` field to the `preconfiguredActionSchema` to allow return the configuration for the pre-configured connectors, which set this value as `true`. This change is completely backward compatible, because this field is optional and all the connectors, which don't have the value will remain to work the same way as before the change (won't return the config). Changed get and getAll methods of the ActionsClient to reflect opt-in config based on the set `exposeConfig` value. |
||
|
Tim Sullivan
|
9f86582d05
|
[Reporting] upgrade notes for Reporting feature privilege breaking changes (#207897)
## Summary Breaking change proposal: https://github.com/elastic/dev/issues/2556 This PR updates the upgrade note documentation to explain the 9.0.0 changes around Reporting access control |
||
Nikita Indik
|
33145379e5
|
[Security Solution] Show deprecated bulk endpoints in Upgrade Assistant (#207091)
**Partially addresses: https://github.com/elastic/kibana/issues/193184** ## Summary We are going to remove our deprecated [bulk action endpoints](https://github.com/elastic/kibana/issues/193184) in v9.0.0. They are already unavailable in `main`. This PR makes deprecated bulk endpoints visible in Upgrade Assistant. Also, it adds an upgrade guide to the documentation to help users transition to supported endpoints. ⚠️ This PR temporarily adds the deprecated endpoints back to `register_routes.ts`. This is needed to make merging changes easier. I'll open up a follow up PR for `main` that will delete these endpoints from `9.0`. Will do it once this PR is merged. ## Screenshots **Deprecated endpoints visible in Upgrade Assistant table** <img width="1276" alt="Schermafbeelding 2025-01-21 om 11 27 53" src="https://github.com/user-attachments/assets/909c7a20-31d9-46bb-89ec-b409550074e4" /> **Clicking on a table item opens a flyout with more info** <table> <tr> <td> <img width="1270" alt="patch_update" src="https://github.com/user-attachments/assets/8e99459d-1ea1-40c4-936c-23074c02cd6f" /> </td> <td> <img width="1270" alt="post_create" src="https://github.com/user-attachments/assets/6e734e97-4cf4-4d96-9f8d-51efeb3977ad" /> </td> </tr> <tr> <td> <img width="1270" alt="put_update" src="https://github.com/user-attachments/assets/d5b08e16-bf49-475d-81a9-fe5654483e1d" /> </td> <td> <img width="1271" alt="post_delete" src="https://github.com/user-attachments/assets/ccb74552-50a4-4bdb-b04e-06857caa8f38" /> </td> </tr> </table> **Clicking on "Learn more" in the flyout takes you to the [upgrade guide](https://kibana_bk_207091.docs-preview.app.elstc.co/guide/en/kibana/master/breaking-changes-summary.html#breaking-207091)** <img width="731" alt="upgrade_notes" src="https://github.com/user-attachments/assets/b8b471ea-98c7-4b07-91db-b1630c382554" /> ## Testing Once you send a request to one of the deprecated endpoints it should show up in Upgrade Assistant at `<basePath>/app/management/stack/upgrade_assistant/kibana_deprecations`. Please refer to [this ticket](https://github.com/elastic/kibana/issues/193184) for the list of deprecated endpoints. Work started on: 16-Jan-2025 |
||
David Sánchez
|
adb6cded6a
|
[Security Solution] [EDR Workflows] Adds upgrade notes for management deprecated apis (#206903)
## Summary It adds upgrade notes and create docs link for Endpoint management deprecated apis in 9.0. This pr is for main (9.0) and 8.x (8.18) and will follow up with this one on 8.x branch: https://github.com/elastic/kibana/pull/206904 in order to add these notes to the Upgrade Assistant for these deprecated api's The Api routes were already removed in this pr (only in main): https://github.com/elastic/kibana/pull/199598 --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
|
Lisa Cawley
|
9d4f54a7ce
|
[DOCS] Granular connector RBAC (#207136) | ||
|
Tim Sullivan
|
a514c26d38
|
[Reporting Docs for inspecting the query used for CSV export (#207001)
Closes https://github.com/elastic/kibana/issues/191768 --------- Co-authored-by: wajihaparvez <wajiha.parvez@elastic.co> |
||
florent-leborgne
|
ae701c969e
|
[Docs] Add missing telemetry setting (#206403)
This PR is a re-do of @charlesbp87's https://github.com/elastic/kibana/pull/202458 so that the change can be propagated to all required versions. @charlesbp87 thanks for raising this. Let me know if we should propagate the change to more versions. --------- Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com> |
||
Mark Hopkin
|
4304e21933
|
[Entity Analytics] Add legacy risk engine breaking change to upgrade notes (#206413)
## Summary This deprecation was added to the 8.x branch in https://github.com/elastic/kibana/pull/202775 but I think we also need a record of this breaking chain on `main` --------- Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com> |
||
|
Lisa Cawley
|
0d7f29c838
|
[DOCS] Clarify ServiceNow connector RSA key examples (#206517) | ||
Janeen Mikell Roberts
|
c2e90222cc
|
Removes tech preview label from cases connectors doc (#206351)
The [cases and connection action feature](https://www.elastic.co/guide/en/kibana/8.17/cases-action-type.html) was GA'd in `8.17`. This PR removes the tech preview label (once backported to `8.17`). |
||
Kurt
|
8bc22a1297
|
Remove experimental tag from docs for FIPS (#206453)
## Summary Remove the Tech Preview tag from the docs for 8.17+ <img width="882" alt="Screenshot 2025-01-13 at 9 47 39 AM" src="https://github.com/user-attachments/assets/571718e2-5e80-4bc9-941e-25164d05a911" /> |
||
Michael Bischoff
|
2d4c40a093
|
Update fleet-settings.asciidoc (#203194)
adding missing fleet_server_host_id
|
||
|
Gerard Soldevila
|
683a768941
|
SKA: Relocate remaining modules (#206103)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 2 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/entities-data-access-plugin` | `x-pack/solutions/observability/plugins/entities_data_access` | | `@kbn/entityManager-app-plugin` | `x-pack/solutions/observability/plugins/entity_manager_app` | #### 10 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/core-user-settings-server` | `src/core/packages/user-settings/server` | | `@kbn/core-user-settings-server-internal` | `src/core/packages/user-settings/server-internal` | | `@kbn/core-user-settings-server-mocks` | `src/core/packages/user-settings/server-mocks` | | `@kbn/calculate-auto` | `src/platform/packages/shared/kbn-calculate-auto` | | `@kbn/charts-theme` | `src/platform/packages/shared/kbn-charts-theme` | | `@kbn/palettes` | `src/platform/packages/shared/kbn-palettes` | | `@kbn/saved-search-component` | `src/platform/packages/shared/kbn-saved-search-component` | | `@kbn/use-tracked-promise` | `src/platform/packages/shared/kbn-use-tracked-promise` | | `@kbn/response-ops-rule-form` | `src/platform/packages/shared/response-ops/rule_form` | | `@kbn/streams-schema` | `x-pack/solutions/observability/packages/kbn-streams-schema` | <details > <summary>Updated references</summary> ``` ./.i18nrc.json ./docs/developer/plugin-list.asciidoc ./package.json ./packages/kbn-ts-projects/config-paths.json ./src/core/packages/user-settings/server-internal/jest.config.js ./src/core/packages/user-settings/server-mocks/jest.config.js ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/shared/kbn-calculate-auto/jest.config.js ./src/platform/packages/shared/kbn-charts-theme/jest.config.js ./src/platform/packages/shared/kbn-palettes/jest.config.js ./src/platform/packages/shared/kbn-saved-search-component/jest.config.js ./src/platform/packages/shared/kbn-use-tracked-promise/jest.config.js ./src/platform/packages/shared/response-ops/rule_form/jest.config.js ./tsconfig.base.json ./x-pack/solutions/observability/packages/kbn-streams-schema/jest.config.js ./x-pack/solutions/observability/plugins/entities_data_access/jest.config.js ./x-pack/solutions/observability/plugins/entity_manager_app/jest.config.js ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/core/packages/user-settings/server-internal/jest.config.js:12 src/core/packages/user-settings/server-internal/tsconfig.json:2 src/core/packages/user-settings/server-mocks/jest.config.js:12 src/core/packages/user-settings/server-mocks/tsconfig.json:2 src/core/packages/user-settings/server/tsconfig.json:2 src/platform/packages/shared/kbn-calculate-auto/jest.config.js:12 src/platform/packages/shared/kbn-calculate-auto/tsconfig.json:2 src/platform/packages/shared/kbn-charts-theme/jest.config.js:12 src/platform/packages/shared/kbn-charts-theme/tsconfig.json:2 src/platform/packages/shared/kbn-palettes/jest.config.js:12 src/platform/packages/shared/kbn-palettes/tsconfig.json:2 src/platform/packages/shared/kbn-saved-search-component/jest.config.js:12 src/platform/packages/shared/kbn-saved-search-component/tsconfig.json:2 src/platform/packages/shared/kbn-use-tracked-promise/jest.config.js:12 src/platform/packages/shared/kbn-use-tracked-promise/tsconfig.json:2 src/platform/packages/shared/response-ops/rule_form/jest.config.js:12 src/platform/packages/shared/response-ops/rule_form/tsconfig.json:2 x-pack/solutions/observability/packages/kbn-streams-schema/jest.config.js:10 x-pack/solutions/observability/packages/kbn-streams-schema/tsconfig.json:2 x-pack/solutions/observability/plugins/entities_data_access/jest.config.js:12 x-pack/solutions/observability/plugins/entities_data_access/tsconfig.json:2 x-pack/solutions/observability/plugins/entity_manager_app/jest.config.js:12 x-pack/solutions/observability/plugins/entity_manager_app/tsconfig.json:2 x-pack/solutions/observability/plugins/entity_manager_app/tsconfig.json:7 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
Anton Dosov
|
64b6a1a5e7
|
Sustainable Kibana Architecture: Move the rest of shared-ux modules (#205924)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 1 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/url-drilldown-plugin` | `x-pack/platform/plugins/private/drilldowns/url_drilldown` | #### 21 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/core-chrome-browser` | `src/core/packages/chrome/browser` | | `@kbn/deeplinks-shared` | `src/platform/packages/shared/deeplinks/shared` | | `@kbn/home-sample-data-card` | `src/platform/packages/shared/home/sample_data_card` | | `@kbn/home-sample-data-tab` | `src/platform/packages/shared/home/sample_data_tab` | | `@kbn/home-sample-data-types` | `src/platform/packages/shared/home/sample_data_types` | | `@kbn/guided-onboarding` | `src/platform/packages/shared/kbn-guided-onboarding` | | `@kbn/item-buffer` | `src/platform/packages/private/kbn-item-buffer` | | `@kbn/management-settings-section-registry` | `src/platform/packages/shared/kbn-management/settings/section_registry` | | `@kbn/management-settings-ids` | `src/platform/packages/shared/kbn-management/settings/setting_ids` | | `@kbn/react-mute-legacy-root-warning` | `src/platform/packages/private/kbn-react-mute-legacy-root-warning` | | `@kbn/saved-objects-settings` | `src/platform/packages/private/kbn-saved-objects-settings` | | `@kbn/react-kibana-context-common` | `src/platform/packages/shared/react/kibana_context/common` | | `@kbn/react-kibana-context-render` | `src/platform/packages/shared/react/kibana_context/render` | | `@kbn/react-kibana-context-root` | `src/platform/packages/shared/react/kibana_context/root` | | `@kbn/react-kibana-context-styled` | `src/platform/packages/shared/react/kibana_context/styled` | | `@kbn/react-kibana-context-theme` | `src/platform/packages/shared/react/kibana_context/theme` | | `@kbn/react-kibana-mount` | `src/platform/packages/shared/react/kibana_mount` | | `@kbn/serverless-project-switcher` | `src/platform/packages/private/serverless/project_switcher` | | `@kbn/serverless-common-settings` | `src/platform/packages/private/serverless/settings/common` | | `@kbn/serverless-observability-settings` | `src/platform/packages/shared/serverless/settings/observability_project` | | `@kbn/serverless-types` | `src/platform/packages/private/serverless/types` | <details > <summary>Updated relative paths</summary> ``` src/core/packages/chrome/browser/jest.config.js:12 src/core/packages/chrome/browser/tsconfig.json:2 src/core/packages/chrome/browser/tsconfig.type_check.json:2 src/core/packages/chrome/browser/tsconfig.type_check.json:21 src/core/packages/chrome/browser/tsconfig.type_check.json:24 src/core/packages/chrome/browser/tsconfig.type_check.json:27 src/core/packages/chrome/browser/tsconfig.type_check.json:30 src/core/packages/chrome/browser/tsconfig.type_check.json:33 src/core/packages/chrome/browser/tsconfig.type_check.json:36 src/core/packages/chrome/browser/tsconfig.type_check.json:39 src/core/packages/chrome/browser/tsconfig.type_check.json:42 src/core/packages/chrome/browser/tsconfig.type_check.json:45 src/core/packages/chrome/browser/tsconfig.type_check.json:48 src/core/packages/chrome/browser/tsconfig.type_check.json:51 src/core/packages/chrome/browser/tsconfig.type_check.json:54 src/platform/packages/private/kbn-item-buffer/jest.config.js:12 src/platform/packages/private/kbn-item-buffer/tsconfig.json:2 src/platform/packages/private/kbn-react-mute-legacy-root-warning/jest.config.js:12 src/platform/packages/private/kbn-react-mute-legacy-root-warning/tsconfig.json:2 src/platform/packages/private/kbn-saved-objects-settings/jest.config.js:12 src/platform/packages/private/kbn-saved-objects-settings/tsconfig.json:2 src/platform/packages/private/kbn-saved-objects-settings/tsconfig.type_check.json:2 src/platform/packages/private/serverless/project_switcher/jest.config.js:12 src/platform/packages/private/serverless/project_switcher/tsconfig.json:2 src/platform/packages/private/serverless/project_switcher/tsconfig.type_check.json:2 src/platform/packages/private/serverless/project_switcher/tsconfig.type_check.json:23 src/platform/packages/private/serverless/settings/common/tsconfig.json:2 src/platform/packages/private/serverless/settings/common/tsconfig.type_check.json:2 src/platform/packages/private/serverless/settings/common/tsconfig.type_check.json:20 src/platform/packages/private/serverless/types/tsconfig.json:2 src/platform/packages/private/serverless/types/tsconfig.type_check.json:2 src/platform/packages/shared/deeplinks/shared/jest.config.js:12 src/platform/packages/shared/deeplinks/shared/tsconfig.json:2 src/platform/packages/shared/deeplinks/shared/tsconfig.type_check.json:2 src/platform/packages/shared/home/sample_data_card/jest.config.js:12 src/platform/packages/shared/home/sample_data_card/tsconfig.json:2 src/platform/packages/shared/home/sample_data_card/tsconfig.type_check.json:2 src/platform/packages/shared/home/sample_data_card/tsconfig.type_check.json:23 src/platform/packages/shared/home/sample_data_card/tsconfig.type_check.json:29 src/platform/packages/shared/home/sample_data_tab/jest.config.js:12 src/platform/packages/shared/home/sample_data_tab/tsconfig.json:2 src/platform/packages/shared/home/sample_data_tab/tsconfig.type_check.json:2 src/platform/packages/shared/home/sample_data_tab/tsconfig.type_check.json:23 src/platform/packages/shared/home/sample_data_types/jest.config.js:12 src/platform/packages/shared/home/sample_data_types/tsconfig.json:2 src/platform/packages/shared/home/sample_data_types/tsconfig.type_check.json:2 src/platform/packages/shared/kbn-guided-onboarding/jest.config.js:12 src/platform/packages/shared/kbn-guided-onboarding/tsconfig.json:2 src/platform/packages/shared/kbn-guided-onboarding/tsconfig.type_check.json:2 src/platform/packages/shared/kbn-management/settings/section_registry/tsconfig.json:2 src/platform/packages/shared/kbn-management/settings/section_registry/tsconfig.type_check.json:2 src/platform/packages/shared/kbn-management/settings/section_registry/tsconfig.type_check.json:22 src/platform/packages/shared/kbn-management/settings/section_registry/tsconfig.type_check.json:25 src/platform/packages/shared/kbn-management/settings/setting_ids/tsconfig.json:2 src/platform/packages/shared/kbn-management/settings/setting_ids/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/common/jest.config.js:12 src/platform/packages/shared/react/kibana_context/common/tsconfig.json:2 src/platform/packages/shared/react/kibana_context/common/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/render/jest.config.js:12 src/platform/packages/shared/react/kibana_context/render/tsconfig.json:2 src/platform/packages/shared/react/kibana_context/render/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/render/tsconfig.type_check.json:25 src/platform/packages/shared/react/kibana_context/root/jest.config.js:12 src/platform/packages/shared/react/kibana_context/root/tsconfig.json:2 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:22 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:28 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:31 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:34 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:37 src/platform/packages/shared/react/kibana_context/root/tsconfig.type_check.json:40 src/platform/packages/shared/react/kibana_context/styled/jest.config.js:12 src/platform/packages/shared/react/kibana_context/styled/tsconfig.json:2 src/platform/packages/shared/react/kibana_context/styled/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/styled/tsconfig.type_check.json:22 src/platform/packages/shared/react/kibana_context/theme/jest.config.js:12 src/platform/packages/shared/react/kibana_context/theme/tsconfig.json:2 src/platform/packages/shared/react/kibana_context/theme/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_context/theme/tsconfig.type_check.json:22 src/platform/packages/shared/react/kibana_mount/jest.config.js:12 src/platform/packages/shared/react/kibana_mount/tsconfig.json:2 src/platform/packages/shared/react/kibana_mount/tsconfig.type_check.json:2 src/platform/packages/shared/react/kibana_mount/tsconfig.type_check.json:22 src/platform/packages/shared/react/kibana_mount/tsconfig.type_check.json:25 src/platform/packages/shared/react/kibana_mount/tsconfig.type_check.json:28 src/platform/packages/shared/react/kibana_mount/tsconfig.type_check.json:34 src/platform/packages/shared/serverless/settings/observability_project/tsconfig.json:2 src/platform/packages/shared/serverless/settings/observability_project/tsconfig.type_check.json:2 src/platform/packages/shared/serverless/settings/observability_project/tsconfig.type_check.json:20 x-pack/platform/plugins/private/drilldowns/url_drilldown/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
Alejandro Fernández Haro
|
41a42555f9
|
[Cloud Experiments] Flag as private (#206121) | ||
wajihaparvez
|
fea598ea13
|
[Docs] Add wolfi image info (#205022)
## Summary Adds information about using Wolfi container images to the Install with Docker page. Closes: [#594](https://github.com/elastic/platform-docs-team/issues/594) |
||
Alberto Blázquez
|
1e9606de9c
|
Turn AssetInventory sub-plugin into a Security solution page (#205363)
## Summary Turn AssetInventory plugin into a simple Security solution page based on this conversation: - https://github.com/elastic/security-team/issues/10346 Follow-up of this work, where we initially developed the Asset Inventory bare-bones as a plugin: - https://github.com/elastic/kibana/issues/201704 Part of this work stream though not originally planned: - https://github.com/elastic/security-team/issues/11247?reload=1 ### Motivation Reasoning behind is enabling fast development changes without any major refactors in other packages/components that need to be reused, which seems impossible as of now with the current codebase. ### Checklist - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks In the future, we'll probably have to turn AssetInventory into a sub-plugin again. Doing so doesn't bring any risk in the present, and should only involve the re-generation of the deleted files in this PR. --------- Co-authored-by: Paulo Henrique <paulo.henrique@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
Liam Thompson
|
9078287e8b
|
[main] Max allowed file size while Uploading image via Kibana dashboard Image … (#205140) (#205324)
backport Co-authored-by: akashsingh <55509676+aakash742@users.noreply.github.com> |
||
|
Gerard Soldevila
|
a382d35dd2
|
Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-visualizations (#202754)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 29 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/charts-plugin` | `src/platform/plugins/shared/charts` | | `@kbn/data-plugin` | `src/platform/plugins/shared/data` | | `@kbn/event-annotation-listing-plugin` | `src/platform/plugins/private/event_annotation_listing` | | `@kbn/event-annotation-plugin` | `src/platform/plugins/private/event_annotation` | | `@kbn/expression-gauge-plugin` | `src/platform/plugins/shared/chart_expressions/expression_gauge` | | `@kbn/expression-heatmap-plugin` | `src/platform/plugins/shared/chart_expressions/expression_heatmap` | | `@kbn/expression-legacy-metric-vis-plugin` | `src/platform/plugins/shared/chart_expressions/expression_legacy_metric` | | `@kbn/expression-metric-vis-plugin` | `src/platform/plugins/shared/chart_expressions/expression_metric` | | `@kbn/expression-partition-vis-plugin` | `src/platform/plugins/shared/chart_expressions/expression_partition_vis` | | `@kbn/expression-tagcloud-plugin` | `src/platform/plugins/shared/chart_expressions/expression_tagcloud` | | `@kbn/expression-xy-plugin` | `src/platform/plugins/shared/chart_expressions/expression_xy` | | `@kbn/expressions-plugin` | `src/platform/plugins/shared/expressions` | | `@kbn/graph-plugin` | `x-pack/platform/plugins/private/graph` | | `@kbn/lens-plugin` | `x-pack/platform/plugins/shared/lens` | | `@kbn/unified-search-plugin` | `src/platform/plugins/shared/unified_search` | | `@kbn/url-forwarding-plugin` | `src/platform/plugins/private/url_forwarding` | | `@kbn/vis-default-editor-plugin` | `src/platform/plugins/private/vis_default_editor` | | `@kbn/vis-type-gauge-plugin` | `src/platform/plugins/private/vis_types/gauge` | | `@kbn/vis-type-heatmap-plugin` | `src/platform/plugins/private/vis_types/heatmap` | | `@kbn/vis-type-metric-plugin` | `src/platform/plugins/private/vis_types/metric` | | `@kbn/vis-type-pie-plugin` | `src/platform/plugins/private/vis_types/pie` | | `@kbn/vis-type-table-plugin` | `src/platform/plugins/private/vis_types/table` | | `@kbn/vis-type-tagcloud-plugin` | `src/platform/plugins/private/vis_types/tagcloud` | | `@kbn/vis-type-timelion-plugin` | `src/platform/plugins/private/vis_types/timelion` | | `@kbn/vis-type-timeseries-plugin` | `src/platform/plugins/shared/vis_types/timeseries` | | `@kbn/vis-type-vega-plugin` | `src/platform/plugins/private/vis_types/vega` | | `@kbn/vis-type-vislib-plugin` | `src/platform/plugins/private/vis_types/vislib` | | `@kbn/vis-type-xy-plugin` | `src/platform/plugins/private/vis_types/xy` | | `@kbn/visualizations-plugin` | `src/platform/plugins/shared/visualizations` | #### 18 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/calculate-width-from-char-count` | `src/platform/packages/shared/kbn-calculate-width-from-char-count` | | `@kbn/chart-expressions-common` | `src/platform/packages/shared/chart-expressions-common` | | `@kbn/chart-icons` | `src/platform/packages/shared/kbn-chart-icons` | | `@kbn/coloring` | `src/platform/packages/shared/kbn-coloring` | | `@kbn/data-service` | `src/platform/packages/shared/kbn-data-service` | | `@kbn/dom-drag-drop` | `src/platform/packages/shared/kbn-dom-drag-drop` | | `@kbn/event-annotation-common` | `src/platform/packages/shared/kbn-event-annotation-common` | | `@kbn/event-annotation-components` | `src/platform/packages/shared/kbn-event-annotation-components` | | `@kbn/interpreter` | `src/platform/packages/shared/kbn-interpreter` | | `@kbn/lens-formula-docs` | `src/platform/packages/private/kbn-lens-formula-docs` | | `@kbn/managed-content-badge` | `src/platform/packages/private/kbn-managed-content-badge` | | `@kbn/random-sampling` | `x-pack/platform/packages/private/kbn-random-sampling` | | `@kbn/sort-predicates` | `src/platform/packages/shared/kbn-sort-predicates` | | `@kbn/timelion-grammar` | `src/platform/packages/private/kbn-timelion-grammar` | | `@kbn/tinymath` | `src/platform/packages/private/kbn-tinymath` | | `@kbn/transpose-utils` | `src/platform/packages/private/kbn-transpose-utils` | | `@kbn/visualization-ui-components` | `src/platform/packages/shared/kbn-visualization-ui-components` | | `@kbn/visualization-utils` | `src/platform/packages/shared/kbn-visualization-utils` | <details > <summary>Updated references</summary> ``` ./.eslintignore ./.eslintrc.js ./.github/paths-labeller.yml ./.i18nrc.json ./docs/developer/architecture/core/elasticsearch-service.asciidoc ./docs/developer/architecture/development-visualize-index.asciidoc ./docs/developer/best-practices/index.asciidoc ./docs/developer/plugin-list.asciidoc ./examples/search_examples/public/plugin.ts ./package.json ./packages/kbn-docs-utils/src/build_api_declarations/extract_import_refs.test.ts ./packages/kbn-docs-utils/src/utils.ts ./packages/kbn-eslint-plugin-i18n/helpers/get_i18n_identifier_from_file_path.test.ts ./packages/kbn-repo-source-classifier/src/repo_source_classifier.ts ./packages/kbn-ts-projects/config-paths.json ./src/dev/build/tasks/package_json/find_used_dependencies.ts ./src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js ./src/dev/code_coverage/ingest_coverage/__tests__/mocks/team_assign_mock.txt ./src/dev/code_coverage/ingest_coverage/__tests__/transforms.test.js ./src/dev/code_coverage/ingest_coverage/integration_tests/mocks/jest-combined/bulk-data.json ./src/dev/storybook/aliases.ts ./src/platform/packages/private/kbn-lens-formula-docs/jest.config.js ./src/platform/packages/private/kbn-managed-content-badge/jest.config.js ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/private/kbn-tinymath/README.md ./src/platform/packages/private/kbn-tinymath/jest.config.js ./src/platform/packages/private/kbn-transpose-utils/jest.config.js ./src/platform/packages/shared/chart-expressions-common/jest.config.js ./src/platform/packages/shared/kbn-calculate-width-from-char-count/jest.config.js ./src/platform/packages/shared/kbn-chart-icons/jest.config.js ./src/platform/packages/shared/kbn-coloring/jest.config.js ./src/platform/packages/shared/kbn-data-service/jest.config.js ./src/platform/packages/shared/kbn-dom-drag-drop/jest.config.js ./src/platform/packages/shared/kbn-event-annotation-common/jest.config.js ./src/platform/packages/shared/kbn-event-annotation-components/jest.config.js ./src/platform/packages/shared/kbn-interpreter/jest.config.js ./src/platform/packages/shared/kbn-sort-predicates/jest.config.js ./src/platform/packages/shared/kbn-visualization-ui-components/jest.config.js ./src/platform/packages/shared/kbn-visualization-utils/jest.config.js ./src/platform/plugins/private/event_annotation/jest.config.js ./src/platform/plugins/private/event_annotation_listing/jest.config.js ./src/platform/plugins/private/url_forwarding/jest.config.js ./src/platform/plugins/private/vis_default_editor/jest.config.js ./src/platform/plugins/private/vis_types/gauge/jest.config.js ./src/platform/plugins/private/vis_types/heatmap/jest.config.js ./src/platform/plugins/private/vis_types/metric/jest.config.js ./src/platform/plugins/private/vis_types/pie/jest.config.js ./src/platform/plugins/private/vis_types/table/jest.config.js ./src/platform/plugins/private/vis_types/tagcloud/jest.config.js ./src/platform/plugins/private/vis_types/timelion/jest.config.js ./src/platform/plugins/private/vis_types/vega/jest.config.js ./src/platform/plugins/private/vis_types/vislib/jest.config.js ./src/platform/plugins/private/vis_types/xy/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_gauge/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_heatmap/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_legacy_metric/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_metric/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_partition_vis/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_tagcloud/jest.config.js ./src/platform/plugins/shared/chart_expressions/expression_xy/jest.config.js ./src/platform/plugins/shared/charts/jest.config.js ./src/platform/plugins/shared/custom_integrations/jest.config.js ./src/platform/plugins/shared/data/jest.config.js ./src/platform/plugins/shared/expressions/README.asciidoc ./src/platform/plugins/shared/expressions/jest.config.js ./src/platform/plugins/shared/unified_search/jest.config.js ./src/platform/plugins/shared/vis_types/timeseries/jest.config.js ./src/platform/plugins/shared/visualizations/jest.config.js ./src/plugins/vis_types/timeseries/public/application/components/aggs/math.js ./tsconfig.base.json ./tsconfig.base.type_check.json ./tsconfig.refs.json ./x-pack/.i18nrc.json ./x-pack/platform/packages/private/kbn-random-sampling/jest.config.js ./x-pack/platform/packages/private/ml/date_utils/src/date_utils.ts ./x-pack/platform/plugins/private/graph/README.md ./x-pack/platform/plugins/private/graph/jest.config.js ./x-pack/platform/plugins/private/graph/public/components/venn_diagram/vennjs/index.ts ./x-pack/platform/plugins/private/watcher/public/legacy/time_buckets.js ./x-pack/platform/plugins/shared/cases/public/components/markdown_editor/use_plugins.ts ./x-pack/platform/plugins/shared/lens/jest.config.js ./x-pack/platform/plugins/shared/lens/readme.md ./x-pack/platform/plugins/shared/lens/server/embeddable/make_lens_embeddable_factory.ts ./x-pack/platform/plugins/shared/lens/server/migrations/saved_object_migrations.ts ./x-pack/platform/plugins/shared/lens/tsconfig.type_check.json ./x-pack/platform/plugins/shared/ml/public/application/explorer/explorer_charts/explorer_charts_container.js ./x-pack/platform/plugins/shared/ml/public/application/services/field_format_service.ts ./x-pack/platform/plugins/shared/ml/public/application/util/chart_utils.js ./x-pack/solutions/observability/plugins/observability/common/utils/get_inspect_response.ts ./x-pack/solutions/observability/plugins/observability_shared/common/utils/get_inspect_response.ts ./x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/autocomplete/index.mock.ts ./x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/fields/index.mock.ts ./x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/filter_field_to_list/index.ts ./x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/hooks/use_field_value_autocomplete/index.test.ts ./x-pack/solutions/security/packages/kbn-securitysolution-autocomplete/src/hooks/use_field_value_autocomplete/index.ts ./x-pack/solutions/security/packages/kbn-securitysolution-list-utils/src/helpers/index.ts ./x-pack/solutions/security/plugins/security_solution/public/common/hooks/use_app_toasts.ts ./x-pack/solutions/security/plugins/security_solution/server/lib/timeline/constants.ts ./x-pack/solutions/security/plugins/timelines/public/hooks/use_app_toasts.ts ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-lens-formula-docs/jest.config.js:12 src/platform/packages/private/kbn-lens-formula-docs/tsconfig.json:2 src/platform/packages/private/kbn-managed-content-badge/jest.config.js:12 src/platform/packages/private/kbn-managed-content-badge/tsconfig.json:2 src/platform/packages/private/kbn-timelion-grammar/tsconfig.json:2 src/platform/packages/private/kbn-tinymath/jest.config.js:12 src/platform/packages/private/kbn-tinymath/tsconfig.json:2 src/platform/packages/private/kbn-transpose-utils/jest.config.js:12 src/platform/packages/private/kbn-transpose-utils/tsconfig.json:2 src/platform/packages/shared/chart-expressions-common/jest.config.js:12 src/platform/packages/shared/chart-expressions-common/tsconfig.json:2 src/platform/packages/shared/kbn-calculate-width-from-char-count/jest.config.js:12 src/platform/packages/shared/kbn-calculate-width-from-char-count/tsconfig.json:2 src/platform/packages/shared/kbn-chart-icons/jest.config.js:12 src/platform/packages/shared/kbn-chart-icons/tsconfig.json:2 src/platform/packages/shared/kbn-coloring/jest.config.js:12 src/platform/packages/shared/kbn-coloring/tsconfig.json:2 src/platform/packages/shared/kbn-data-service/jest.config.js:12 src/platform/packages/shared/kbn-data-service/tsconfig.json:2 src/platform/packages/shared/kbn-dom-drag-drop/jest.config.js:12 src/platform/packages/shared/kbn-dom-drag-drop/tsconfig.json:2 src/platform/packages/shared/kbn-event-annotation-common/jest.config.js:12 src/platform/packages/shared/kbn-event-annotation-common/tsconfig.json:2 src/platform/packages/shared/kbn-event-annotation-components/jest.config.js:12 src/platform/packages/shared/kbn-event-annotation-components/tsconfig.json:2 src/platform/packages/shared/kbn-interpreter/jest.config.js:12 src/platform/packages/shared/kbn-interpreter/tsconfig.json:2 src/platform/packages/shared/kbn-sort-predicates/jest.config.js:12 src/platform/packages/shared/kbn-sort-predicates/tsconfig.json:2 src/platform/packages/shared/kbn-visualization-ui-components/jest.config.js:12 src/platform/packages/shared/kbn-visualization-ui-components/tsconfig.json:2 src/platform/packages/shared/kbn-visualization-utils/jest.config.js:12 src/platform/packages/shared/kbn-visualization-utils/tsconfig.json:2 src/platform/plugins/private/event_annotation/jest.config.js:12 src/platform/plugins/private/event_annotation/tsconfig.json:2 src/platform/plugins/private/event_annotation_listing/jest.config.js:12 src/platform/plugins/private/event_annotation_listing/tsconfig.json:2 src/platform/plugins/private/url_forwarding/jest.config.js:12 src/platform/plugins/private/url_forwarding/tsconfig.json:2 src/platform/plugins/private/vis_default_editor/README.md:8 src/platform/plugins/private/vis_default_editor/jest.config.js:12 src/platform/plugins/private/vis_default_editor/tsconfig.json:2 src/platform/plugins/private/vis_types/gauge/jest.config.js:12 src/platform/plugins/private/vis_types/gauge/tsconfig.json:2 src/platform/plugins/private/vis_types/heatmap/jest.config.js:12 src/platform/plugins/private/vis_types/heatmap/tsconfig.json:2 src/platform/plugins/private/vis_types/metric/jest.config.js:12 src/platform/plugins/private/vis_types/metric/tsconfig.json:2 src/platform/plugins/private/vis_types/pie/jest.config.js:12 src/platform/plugins/private/vis_types/pie/tsconfig.json:2 src/platform/plugins/private/vis_types/table/jest.config.js:12 src/platform/plugins/private/vis_types/table/tsconfig.json:2 src/platform/plugins/private/vis_types/tagcloud/jest.config.js:12 src/platform/plugins/private/vis_types/tagcloud/tsconfig.json:2 src/platform/plugins/private/vis_types/timelion/jest.config.js:12 src/platform/plugins/private/vis_types/timelion/tsconfig.json:2 src/platform/plugins/private/vis_types/vega/jest.config.js:12 src/platform/plugins/private/vis_types/vega/tsconfig.json:2 src/platform/plugins/private/vis_types/vislib/jest.config.js:12 src/platform/plugins/private/vis_types/vislib/tsconfig.json:2 src/platform/plugins/private/vis_types/xy/jest.config.js:12 src/platform/plugins/private/vis_types/xy/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_gauge/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_gauge/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_heatmap/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_heatmap/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_legacy_metric/.storybook/main.js:17 src/platform/plugins/shared/chart_expressions/expression_legacy_metric/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_legacy_metric/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_metric/.storybook/main.js:17 src/platform/plugins/shared/chart_expressions/expression_metric/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_metric/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_partition_vis/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_partition_vis/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_tagcloud/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_tagcloud/tsconfig.json:2 src/platform/plugins/shared/chart_expressions/expression_xy/jest.config.js:12 src/platform/plugins/shared/chart_expressions/expression_xy/tsconfig.json:2 src/platform/plugins/shared/charts/jest.config.js:12 src/platform/plugins/shared/charts/tsconfig.json:2 src/platform/plugins/shared/data/jest.config.js:12 src/platform/plugins/shared/data/tsconfig.json:13 src/platform/plugins/shared/data/tsconfig.json:2 src/platform/plugins/shared/expressions/jest.config.js:12 src/platform/plugins/shared/expressions/tsconfig.json:2 src/platform/plugins/shared/unified_search/jest.config.js:12 src/platform/plugins/shared/unified_search/tsconfig.json:2 src/platform/plugins/shared/vis_types/timeseries/jest.config.js:12 src/platform/plugins/shared/vis_types/timeseries/tsconfig.json:11 src/platform/plugins/shared/vis_types/timeseries/tsconfig.json:2 src/platform/plugins/shared/visualizations/jest.config.js:12 src/platform/plugins/shared/visualizations/tsconfig.json:2 src/platform/plugins/shared/visualizations/tsconfig.json:6 x-pack/platform/packages/private/kbn-random-sampling/jest.config.js:10 x-pack/platform/packages/private/kbn-random-sampling/tsconfig.json:2 x-pack/platform/plugins/private/graph/jest.config.js:10 x-pack/platform/plugins/private/graph/tsconfig.json:13 x-pack/platform/plugins/private/graph/tsconfig.json:3 x-pack/platform/plugins/shared/lens/jest.config.js:10 x-pack/platform/plugins/shared/lens/tsconfig.json:2 x-pack/platform/plugins/shared/lens/tsconfig.json:6 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
David Kilfoyle
|
d5c804bc58
|
[Docs] Update "Alert and action settings" docs to be generated from YAML source (#191787)
This PR: - Updates the Kibana [Alert and action settings](https://www.elastic.co/guide/en/kibana/current/alert-action-settings-kb.html) page to be based off of a YAML source file (`/docs/settings-gen/source/kibana-alert-action-settings.yml`) that is manually converted to Asciidoc format (`kibana-alert-action-settings.asciidoc`) by means of a Perl script (`docs/settings-gen/parse-settings.pl`). A preview of the new, generated page is [here](https://kibana_bk_191787.docs-preview.app.elstc.co/guide/en/kibana/master/alert-action-settings-kb.html). - Adds the `docs/settings-gen/parse-settings.pl` script which does the YAML → Asciidoc conversion. All new files are added to the `/docs/source-gen` folder. This is a trial run updating only one page of settings in the docs. Later, in separate PRs, we plan to convert other pages. After all Kibana settings pages have been converted, we would ask that the Perl script be run automatically as part of the CI whenever the YAML files in `/docs/source-gen` are added or updated. **Notes:** - The Docs team is happy to own and maintain the Perl script (sorry to use Perl - it's the only scripting language that I know). - In time we also plan to convert all of these files from Asciidoc to Markdown. - When we eventually/hopefully get the rest of the Kibana settings files converted, we will announce the settings doc process to the Kibana team by email and/or in the Kibana newsletter. Big thanks to the amazing @lukeelmers and @KOTungseth for guiding this! --- Why are we doing this? We aim to: - Create a more consistent appearance for settings across all of the docs. - Make it easier for people to contribute, since all Asciidoc/Markdown formatting is handled by a script. - Make it more apparent which settings may be missing info, such as the default values, available options, etc. --- P.S. I haven't worked in the Kibana repo very much and would appreciate any help navigating the CI checks. Rel: https://github.com/elastic/docs-projects/issues/239 |
||
|
Gerard Soldevila
|
a8579bb41f
|
Make saved_objects_tagging plugin shared (#205695)
## Summary So that it can be used from `streams_app` (o11y). See https://github.com/elastic/kibana/pull/204309 Steps to relocate: 1. Fetch latest `main` 2. Update the `group` and/or `visibility` in the module's manifest. 3. Run `node scripts/relocate --moveOnly @kbn/saved-objects-tagging-plugin` |
||
|
Tim Sullivan
|
c3c6bfba08
|
[Reporting/CSV/Docs] Specify maximum value for scroll.duration setting (#205765)
## Summary Updates Reporting CSV export documentation to specify there is a maximum value for `xpack.reporting.csv.scroll.size`, which is 10000. |
||
Eyo O. Eyo
|
3bb50f7048
|
SKA: Move SharedUX packages under packages/core (#205608)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 13 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/core-chrome-browser-internal` | `src/core/packages/chrome/browser-internal` | | `@kbn/core-custom-branding-browser` | `src/core/packages/custom-branding/browser` | | `@kbn/core-custom-branding-browser-internal` | `src/core/packages/custom-branding/browser-internal` | | `@kbn/core-custom-branding-browser-mocks` | `src/core/packages/custom-branding/browser-mocks` | | `@kbn/core-custom-branding-common` | `src/core/packages/custom-branding/common` | | `@kbn/core-custom-branding-server` | `src/core/packages/custom-branding/server` | | `@kbn/core-custom-branding-server-internal` | `src/core/packages/custom-branding/server-internal` | | `@kbn/core-custom-branding-server-mocks` | `src/core/packages/custom-branding/server-mocks` | | `@kbn/core-ui-settings-browser` | `src/core/packages/ui-settings/browser` | | `@kbn/core-ui-settings-browser-internal` | `src/core/packages/ui-settings/browser-internal` | | `@kbn/core-ui-settings-common` | `src/core/packages/ui-settings/common` | | `@kbn/core-ui-settings-server` | `src/core/packages/ui-settings/server` | | `@kbn/core-ui-settings-server-internal` | `src/core/packages/ui-settings/server-internal` | <details > <summary>Updated references</summary> ``` ./docs/developer/architecture/core/patterns-scoped-services.asciidoc ./docs/developer/architecture/core/uisettings-service.asciidoc ./package.json ./packages/core/custom-branding/core-custom-branding-common/index.ts ./packages/kbn-ts-projects/config-paths.json ./src/core/packages/chrome/browser-internal/jest.config.js ./src/core/packages/custom-branding/browser-internal/jest.config.js ./src/core/packages/custom-branding/browser-mocks/jest.config.js ./src/core/packages/custom-branding/server-internal/jest.config.js ./src/core/packages/custom-branding/server-mocks/jest.config.js ./src/core/packages/ui-settings/browser-internal/jest.config.js ./src/core/packages/ui-settings/browser/jest.config.js ./src/core/packages/ui-settings/common/jest.config.js ./src/core/packages/ui-settings/server-internal/jest.config.js ./src/core/packages/ui-settings/server/jest.config.js ./src/platform/packages/private/kbn-repo-packages/package-map.json ./tsconfig.base.json ./x-pack/platform/plugins/private/transform/public/app/common/time_zone_utils.ts ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/core/packages/chrome/browser-internal/jest.config.js:12 src/core/packages/chrome/browser-internal/tsconfig.json:2 src/core/packages/custom-branding/browser-internal/jest.config.js:12 src/core/packages/custom-branding/browser-internal/tsconfig.json:2 src/core/packages/custom-branding/browser-mocks/jest.config.js:12 src/core/packages/custom-branding/browser-mocks/tsconfig.json:2 src/core/packages/custom-branding/browser/tsconfig.json:2 src/core/packages/custom-branding/common/tsconfig.json:2 src/core/packages/custom-branding/server-internal/jest.config.js:12 src/core/packages/custom-branding/server-internal/tsconfig.json:2 src/core/packages/custom-branding/server-mocks/jest.config.js:12 src/core/packages/custom-branding/server-mocks/tsconfig.json:2 src/core/packages/custom-branding/server/tsconfig.json:2 src/core/packages/ui-settings/browser-internal/jest.config.js:12 src/core/packages/ui-settings/browser-internal/tsconfig.json:2 src/core/packages/ui-settings/browser/jest.config.js:12 src/core/packages/ui-settings/browser/tsconfig.json:2 src/core/packages/ui-settings/common/jest.config.js:12 src/core/packages/ui-settings/common/tsconfig.json:2 src/core/packages/ui-settings/server-internal/jest.config.js:12 src/core/packages/ui-settings/server-internal/tsconfig.json:2 src/core/packages/ui-settings/server/jest.config.js:12 src/core/packages/ui-settings/server/tsconfig.json:2 ``` </details> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> |
||
|
Anton Dosov
|
175916ef23
|
Sustainable Kibana Architecture: Move packages under packages/shared-ux/ (#205602)
|
||
Efe Gürkan YALAMAN
|
e542fd2370
|
[Synonyms UI] Synonyms UI base plugin (#203284)
## Summary
Creates a plugin for Synonyms UI implementation. It is hidden under the
UI flag and config option which is off by default.
```
POST kbn:/internal/kibana/settings/searchSynonyms:synonymsEnabled
{"value": true}
```
Serverless Search:
<img width="379" alt="Screenshot 2024-12-17 at 13 18 02"
src="https://github.com/user-attachments/assets/8c2cb6f0-ce2a-4be6-8605-4f994adeefd7"
/>
Stack Search
<img width="293" alt="Screenshot 2024-12-17 at 13 21 43"
src="https://github.com/user-attachments/assets/0d61de0e-2cd3-46a6-990f-1f1a70843324"
/>
### Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
---------
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
|
||
|
Gerard Soldevila
|
ca5a08db00
|
Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-security (#202748)
## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 4 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/encrypted-saved-objects-plugin` | `x-pack/platform/plugins/shared/encrypted_saved_objects` | | `@kbn/interactive-setup-plugin` | `src/platform/plugins/private/interactive_setup` | | `@kbn/security-plugin` | `x-pack/platform/plugins/shared/security` | | `@kbn/spaces-plugin` | `x-pack/platform/plugins/shared/spaces` | #### 14 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/crypto` | `src/platform/packages/shared/kbn-crypto` | | `@kbn/handlebars` | `src/platform/packages/private/kbn-handlebars` | | `@kbn/safer-lodash-set` | `src/platform/packages/shared/kbn-safer-lodash-set` | | `@kbn/security-api-key-management` | `x-pack/platform/packages/shared/security/api_key_management` | | `@kbn/security-authorization-core` | `x-pack/platform/packages/private/security/authorization_core` | | `@kbn/security-authorization-core-common` | `x-pack/platform/packages/private/security/authorization_core_common` | | `@kbn/security-form-components` | `x-pack/platform/packages/shared/security/form_components` | | `@kbn/security-hardening` | `src/platform/packages/shared/kbn-security-hardening` | | `@kbn/security-plugin-types-common` | `x-pack/platform/packages/shared/security/plugin_types_common` | | `@kbn/security-plugin-types-public` | `x-pack/platform/packages/shared/security/plugin_types_public` | | `@kbn/security-plugin-types-server` | `x-pack/platform/packages/shared/security/plugin_types_server` | | `@kbn/security-role-management-model` | `x-pack/platform/packages/private/security/role_management_model` | | `@kbn/security-ui-components` | `x-pack/platform/packages/private/security/ui_components` | | `@kbn/user-profile-components` | `src/platform/packages/shared/kbn-user-profile-components` | <details open> <summary>Script errors</summary> ``` Cannot replace multiple occurrences of "../.." in the same line, please fix manually: /Users/dokmic/work/elastic/kibana/src/platform/packages/shared/kbn-safer-lodash-set/package.json:6 ``` </details><details > <summary>Updated references</summary> ``` ./.buildkite/scripts/steps/test/kbn_handlebars.sh ./.eslintrc.js ./.i18nrc.json ./docs/developer/advanced/sharing-saved-objects.asciidoc ./docs/developer/plugin-list.asciidoc ./legacy_rfcs/text/0007_lifecycle_unblocked.md ./legacy_rfcs/text/0016_ols_phase_1.md ./package.json ./packages/kbn-dependency-usage/src/dependency_graph/providers/cruiser.test.ts ./packages/kbn-ts-projects/config-paths.json ./packages/kbn-user-profile-components/src/user_profile.ts ./src/core/packages/saved-objects/common/src/types.ts ./src/core/packages/security/server/src/audit_logging/audit_logger.ts ./src/core/packages/user-profile/common/src/user_profile.ts ./src/dev/precommit_hook/casing_check_config.js ./src/platform/packages/private/kbn-handlebars/README.md ./src/platform/packages/private/kbn-handlebars/index.test.ts ./src/platform/packages/private/kbn-handlebars/index.ts ./src/platform/packages/private/kbn-handlebars/jest.config.js ./src/platform/packages/private/kbn-handlebars/scripts/check_for_upstream_updates.sh ./src/platform/packages/private/kbn-handlebars/scripts/print_ast.js ./src/platform/packages/private/kbn-handlebars/scripts/update_upstream_git_hash.sh ./src/platform/packages/private/kbn-handlebars/src/__jest__/test_bench.ts ./src/platform/packages/private/kbn-handlebars/src/handlebars.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.basic.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.blocks.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.builtins.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.compiler.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.data.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.helpers.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.partials.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.security.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.strict.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.subexpressions.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.utils.test.ts ./src/platform/packages/private/kbn-handlebars/src/spec/index.whitespace_control.test.ts ./src/platform/packages/private/kbn-handlebars/src/symbols.ts ./src/platform/packages/private/kbn-handlebars/src/types.ts ./src/platform/packages/private/kbn-handlebars/src/utils.ts ./src/platform/packages/private/kbn-handlebars/src/visitor.ts ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel ./src/platform/packages/shared/kbn-crypto/jest.config.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assoc.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/assocPath.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/index.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/fp/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/index.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/index.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/_baseSet.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/lodash/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/package.json ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/_get_lodash.sh ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/license-header.txt ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/save_state.sh ./src/platform/packages/shared/kbn-safer-lodash-set/scripts/update.sh ./src/platform/packages/shared/kbn-safer-lodash-set/set.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/set.js ./src/platform/packages/shared/kbn-safer-lodash-set/setWith.d.ts ./src/platform/packages/shared/kbn-safer-lodash-set/setWith.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assoc.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_assocPath.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_patch_test.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_set.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/fp_setWith.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/index.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/patch_test.js ./src/platform/packages/shared/kbn-safer-lodash-set/test/set.ts ./src/platform/packages/shared/kbn-safer-lodash-set/test/setWith.ts ./src/platform/packages/shared/kbn-user-profile-components/jest.config.js ./src/platform/plugins/private/interactive_setup/jest.config.js ./tsconfig.base.json ./x-pack/.i18nrc.json ./x-pack/platform/packages/private/security/authorization_core/jest.config.js ./x-pack/platform/packages/private/security/authorization_core_common/jest.config.js ./x-pack/platform/packages/private/security/role_management_model/jest.config.js ./x-pack/platform/packages/private/security/ui_components/jest.config.js ./x-pack/platform/packages/shared/security/api_key_management/jest.config.js ./x-pack/platform/packages/shared/security/form_components/jest.config.js ./x-pack/platform/plugins/shared/cases/server/authorization/index.ts ./x-pack/platform/plugins/shared/cases/server/authorization/types.ts ./x-pack/platform/plugins/shared/cases/server/connectors/cases/utils.ts ./x-pack/platform/plugins/shared/cases/server/routes/api/utils.ts ./x-pack/platform/plugins/shared/encrypted_saved_objects/README.md ./x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js ./x-pack/platform/plugins/shared/fleet/common/http_authorization_header.ts ./x-pack/platform/plugins/shared/rule_registry/server/lib/get_is_kibana_request.ts ./x-pack/platform/plugins/shared/security/jest.config.js ./x-pack/platform/plugins/shared/spaces/jest.config.js ./x-pack/solutions/security/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-handlebars/jest.config.js:8 src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:276 src/platform/packages/private/kbn-handlebars/src/spec/index.regressions.test.ts:277 src/platform/packages/private/kbn-handlebars/tsconfig.json:2 src/platform/packages/shared/kbn-crypto/jest.config.js:12 src/platform/packages/shared/kbn-crypto/tsconfig.json:2 src/platform/packages/shared/kbn-safer-lodash-set/package.json:6 src/platform/packages/shared/kbn-safer-lodash-set/package.json:7 src/platform/packages/shared/kbn-safer-lodash-set/package.json:8 src/platform/packages/shared/kbn-safer-lodash-set/tsconfig.json:2 src/platform/packages/shared/kbn-security-hardening/tsconfig.json:2 src/platform/packages/shared/kbn-user-profile-components/jest.config.js:12 src/platform/packages/shared/kbn-user-profile-components/tsconfig.json:2 src/platform/plugins/private/interactive_setup/jest.config.js:12 src/platform/plugins/private/interactive_setup/tsconfig.json:2 x-pack/platform/packages/private/security/authorization_core/jest.config.js:13 x-pack/platform/packages/private/security/authorization_core/tsconfig.json:2 x-pack/platform/packages/private/security/authorization_core_common/jest.config.js:15 x-pack/platform/packages/private/security/authorization_core_common/tsconfig.json:2 x-pack/platform/packages/private/security/role_management_model/jest.config.js:14 x-pack/platform/packages/private/security/role_management_model/tsconfig.json:2 x-pack/platform/packages/private/security/ui_components/jest.config.js:13 x-pack/platform/packages/private/security/ui_components/tsconfig.json:2 x-pack/platform/packages/shared/security/api_key_management/jest.config.js:14 x-pack/platform/packages/shared/security/api_key_management/tsconfig.json:2 x-pack/platform/packages/shared/security/form_components/jest.config.js:14 x-pack/platform/packages/shared/security/form_components/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_common/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_public/tsconfig.json:2 x-pack/platform/packages/shared/security/plugin_types_server/tsconfig.json:2 x-pack/platform/plugins/shared/encrypted_saved_objects/README.md:8 x-pack/platform/plugins/shared/encrypted_saved_objects/jest.config.js:10 x-pack/platform/plugins/shared/encrypted_saved_objects/tsconfig.json:2 x-pack/platform/plugins/shared/security/jest.config.js:10 x-pack/platform/plugins/shared/security/tsconfig.json:2 x-pack/platform/plugins/shared/spaces/jest.config.js:10 x-pack/platform/plugins/shared/spaces/tsconfig.json:2 ``` </details> --------- Co-authored-by: Michael Dokolin <mikhail.dokolin@elastic.co> Co-authored-by: “jeramysoucy” <jeramy.soucy@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
Gerard Soldevila
|
6049493e4a
|
Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-core (#201653)
## Summary Start relocating Kibana modules (packages and plugins) to the new folder structure, according to the _Kibana Sustainable Architecture_ initiative. #### 16 plugin(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/cloud-chat-plugin` | `x-pack/platform/plugins/private/cloud_integrations/cloud_chat` | | `@kbn/cloud-experiments-plugin` | `x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments` | | `@kbn/cloud-full-story-plugin` | `x-pack/platform/plugins/private/cloud_integrations/cloud_full_story` | | `@kbn/cloud-links-plugin` | `x-pack/platform/plugins/private/cloud_integrations/cloud_links` | | `@kbn/cloud-plugin` | `x-pack/platform/plugins/shared/cloud` | | `@kbn/features-plugin` | `x-pack/platform/plugins/shared/features` | | `@kbn/ftr-apis-plugin` | `src/platform/plugins/private/ftr_apis` | | `@kbn/kibana-usage-collection-plugin` | `src/platform/plugins/private/kibana_usage_collection` | | `@kbn/licensing-plugin` | `x-pack/platform/plugins/shared/licensing` | | `@kbn/newsfeed-plugin` | `src/platform/plugins/shared/newsfeed` | | `@kbn/saved-objects-management-plugin` | `src/platform/plugins/shared/saved_objects_management` | | `@kbn/telemetry-collection-manager-plugin` | `src/platform/plugins/shared/telemetry_collection_manager` | | `@kbn/telemetry-collection-xpack-plugin` | `x-pack/platform/plugins/private/telemetry_collection_xpack` | | `@kbn/telemetry-management-section-plugin` | `src/platform/plugins/shared/telemetry_management_section` | | `@kbn/telemetry-plugin` | `src/platform/plugins/shared/telemetry` | | `@kbn/usage-collection-plugin` | `src/platform/plugins/shared/usage_collection` | #### 22 package(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/analytics` | `src/platform/packages/shared/kbn-analytics` | | `@kbn/analytics-collection-utils` | `src/platform/packages/private/analytics/utils/analytics_collection_utils` | | `@kbn/apm-config-loader` | `src/platform/packages/private/kbn-apm-config-loader` | | `@kbn/cloud` | `src/platform/packages/shared/cloud` | | `@kbn/config` | `src/platform/packages/shared/kbn-config` | | `@kbn/config-mocks` | `src/platform/packages/private/kbn-config-mocks` | | `@kbn/config-schema` | `src/platform/packages/shared/kbn-config-schema` | | `@kbn/crypto-browser` | `src/platform/packages/shared/kbn-crypto-browser` | | `@kbn/ebt-tools` | `src/platform/packages/shared/kbn-ebt-tools` | | `@kbn/es-errors` | `src/platform/packages/shared/kbn-es-errors` | | `@kbn/es-types` | `src/platform/packages/shared/kbn-es-types` | | `@kbn/hapi-mocks` | `src/platform/packages/private/kbn-hapi-mocks` | | `@kbn/health-gateway-server` | `src/platform/packages/private/kbn-health-gateway-server` | | `@kbn/i18n` | `src/platform/packages/shared/kbn-i18n` | | `@kbn/i18n-react` | `src/platform/packages/shared/kbn-i18n-react` | | `@kbn/logging` | `src/platform/packages/shared/kbn-logging` | | `@kbn/logging-mocks` | `src/platform/packages/shared/kbn-logging-mocks` | | `@kbn/router-to-openapispec` | `src/platform/packages/shared/kbn-router-to-openapispec` | | `@kbn/server-http-tools` | `src/platform/packages/shared/kbn-server-http-tools` | | `@kbn/std` | `src/platform/packages/shared/kbn-std` | | `@kbn/utility-types` | `src/platform/packages/shared/kbn-utility-types` | | `@kbn/zod` | `src/platform/packages/shared/kbn-zod` | --------- Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> |
||
|
Anton Dosov
|
9215df9200
|
Sustainable Kibana Architecture: Move plugins owned by @elastic/appex-sharedux (#204959)
## Summary Part of https://github.com/elastic/kibana/pull/203163 Relocating only shared-ux-owned plugins for now |
||
|
Jesus Wahrman
|
1b1d64b0a5
|
Set HTTP2 as default is SSL is enabled and add deprecation log if SSL is not enabled or protocol is set to HTTP1 (#204384)
## Summary resolves https://github.com/elastic/kibana/issues/194067 Set HTTP2 as default if ssl is enabled. resolves https://github.com/elastic/kibana/issues/194065 Add deprecation log if ssl is not enabled or if protocol is set to http1 <img width="1665" alt="Screenshot 2024-12-17 at 17 06 50" src="https://github.com/user-attachments/assets/3bc7ff57-1079-4a27-90d2-88f3e09093d6" /> <img width="1727" alt="Screenshot 2024-12-17 at 17 06 22" src="https://github.com/user-attachments/assets/d5489705-6cd6-4e09-8327-fdd0f54292ea" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> |