Commit graph

32354 commits

Author SHA1 Message Date
Carlos Crespo
b1a3bc559f
[Infra UI][Stack Monitoring] Migrate EuiPage*_Depracated usage (#161870)
closes [#161404](https://github.com/elastic/kibana/issues/161404)

## Summary

This PR replaces the usage of `EuiPage*_Depracated` with their
equivalent components

Some usages of `EuiPageContent_Deprecated` have been replaced with
`EuiPanel` because they were displayed as panels, and the recommended
`EuiPageSection` component did not render in the same manner. e.g:

<img width="1690" alt="image"
src="b86db831-e79e-4be0-918f-f3b25803e990">

code:
https://github.com/elastic/kibana/pull/161870/files#diff-72520cac696197524aff32e2b92a0acabe1898067c6985786fa5ac250a40ac1cR122


### How to test

- Start a local Kibana with metricbeat monitoring Beats, Kibana,
Elasticsearch and Logstash
- Navigate to Stack Monitoring and click through the links 
- Compare the UI (loading and error states included) with what's
currently in https://edge-oblt.kb.us-west2.gcp.elastic-cloud.com/
- Navigate to Infra UI and go to node details
- Compare the UI (loading and error states included) with what's
currently in https://edge-oblt.kb.us-west2.gcp.elastic-cloud.com/

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-07-20 04:48:26 -07:00
Maxim Kholod
b2ca51d66c
[Cloud Security] rename 'Cloud Security Posture rule template' to 'Benchmark rules' (#162251)
## Summary

Renaming "Cloud Security Posture rule template" into "Benchmark rules"

A part of Quick Wins 8.10.0
https://github.com/elastic/security-team/issues/7167

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

### Screenshot
<img width="1725" alt="Screenshot 2023-07-19 at 15 38 51"
src="8b663b7a-14e8-48cf-8dda-5f886ba70403">
2023-07-20 13:41:10 +02:00
Maxim Kholod
1e5e642a05
[Cloud Security] Remove beta badge from CNVM dashboard page, menu and landing (#162235)
## Summary
fixes:
- https://github.com/elastic/kibana/issues/162050 

**screenshots**

<img width="1403" alt="Screenshot 2023-07-19 at 13 44 36"
src="a361a4ba-c62a-4f3b-904f-ae47c98530ae">

<img width="1408" alt="Screenshot 2023-07-19 at 13 46 07"
src="006015e7-a796-4a96-bb1d-29ffe4991f91">
2023-07-20 13:40:17 +02:00
Patryk Kopyciński
ebcc894e8a
[security_solution] Refactor Cypress es_archiver task (#162228)
## Summary

Use `EsArchiver` directly as Cypress task, instead of spawning
additional node process
2023-07-20 13:04:54 +02:00
Justin Kambic
c892067f75
[Synthetics] Separate Attributes type from Encrypted Monitor types (#160308)
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
2023-07-20 12:46:21 +02:00
Christos Nasikas
2943fc9e06
[Actions] System actions authorization (#161341)
## Summary

This PR adds the ability for system actions to be able to define their
own Kibana privileges that need to be authorized before execution.

Depends on: https://github.com/elastic/kibana/pull/160983

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-07-20 03:41:56 -07:00
Giorgos Bamparopoulos
c1fc644fbf
[APM] Hide components when there is no support from agents (#161970)
### Changes
- Hide the top five erroneous transactions table in the errors details
page for OTel agents and Elastic RUM agent
- Hide the top five errors table in the transaction details page for
OTel agents and Elastic RUM agent
- Hide the transactions breakdown chart in the service overview,
transactions, and transaction detail pages for OTel agents

### Elastic APM agent

dc2a5051-094b-466c-821d-67da1611be6c

### OTel agent

05eba515-98da-4afd-85c3-c7f58704ea6b

### Elastic RUM agent

a283c657-a703-43a7-a02d-c4d326205c6a

Closes https://github.com/elastic/kibana/issues/161963
2023-07-20 11:40:59 +01:00
James Gowdy
3524da75a3
[ML] Using model supplied mask token (#162168)
Fixes https://github.com/elastic/kibana/issues/159577

Using the `mask_token` property from the model config for testing the
model.
This is shown in the input placeholder text, in the input validation and
for displaying the results.

<img width="433" alt="image"
src="bc63f9e6-a3d5-402c-a451-8d80b758acbc">
2023-07-20 11:34:21 +01:00
Achyut Jhunjhunwala
fabb7109a4
[APM] Fix link to onboarding page in the Observability Onboarding plugin (#161847)
Closes https://github.com/elastic/kibana/issues/159675

## Summary

We have in lot of places, Tutorial link hardcoded to
`'/app/home#/tutorial/apm'`

This must change based on deployment type to be Serverless or Non
Serverless.

For Serverless the URL is - `'/app/apm/onboarding'`
For Non Serverless, the URL - `'/app/home#/tutorial/apm'`

Hence to avoid adding logic to read Serverless/Non Serverless mode in
all plugins and packages, i have implemented a redirect URL
`/app/apm/tutorial` inside the APM plugin which will read the Serverless
config and accordingly do the redirect.
2023-07-20 03:33:42 -07:00
Pierre Gayvallet
ab486aff05
[Env] Add buildFlavor to package info (#161930)
## Summary

Add a `buildFavor` property to `Env` (accessible from the plugin's
initializer context), Mimicking the idea of ES's `version.buildFlavor`
field.

Note: this is not supposed to be a replacement for feature flags, but
can be useful when wanting to toggle features based on actual
capabilities of our serverless product. Also, we already expose this
value through the configuration via the `serverless` context value, so
it now adds another way to access the information.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-07-20 03:33:28 -07:00
Jordan
e79f244fa9
[Cloud Security] Change vuln dashboard counters order (#162275) 2023-07-20 12:58:14 +03:00
Jordan
fef88453e8
[Cloud Security] Flip mini compliance bar elements (#162274) 2023-07-20 12:57:57 +03:00
Ievgen Sorokopud
2cdcc18acc
Failing ES Promotion: FTR Configs #22 / detection engine api security and spaces enabled - rule execution logic Non ECS fields in alert document source should fail creating alert when ECS field mapping is geo_point (#162247)
## Summary

Failing tests ticket: https://github.com/elastic/kibana/issues/154277

This PR fixes the non ECS fields in alert document source failing tests.

There are two failing tests:
1. `should remove source array of keywords field from alert if ECS field
mapping is nested` was filing due to wrong key path format passed to
jest's `toHaveProperty`. When the field name has dot notation we should
be using array format as a key path. See discussion
[here](https://github.com/jestjs/jest/issues/5653) and usage examples
[here](https://github.com/jestjs/jest/blob/main/docs/ExpectAPI.md#tohavepropertykeypath-value).
2. `should fail creating alert when ECS field mapping is geo_point` was
failing due to changed error message format.
2023-07-20 11:22:42 +02:00
Ievgen Sorokopud
4fa42f7211
[Security Solution] Test rule_details_ui/pages/rule_details/index.test.tsx logs a warning about wrong props passed to EuiSwitch (#162229)
## Summary

Related ticket: https://github.com/elastic/kibana/issues/147065

This PR fixes the warning within the
`rule_details_ui/pages/rule_details/index.test.tsx` test which happens
because instead of using required `EuiSwitch`'s `label` field we pass
`undefined`.

Since, we do not intend to show the label we make it explicitly with
`showLabel={false}` and set `label` to an empty string.

For more details see [the overview of the
EuiSwitch](https://elastic.github.io/eui/#/forms/selection-controls)
component.
2023-07-20 11:21:45 +02:00
Marco Liberati
d064bfe62a
[Graph] Replace Fontawesome with EUI + Maki icons (#162048)
## Summary

Fixes #160232

This PR removes completely FontAwesome from the Graph plugin and replace
its usage with mostly EUI + few Maki icons.
As for the Google icon, @MichaelMarcialis do you think we should just
have a custom SVG icon within the Graph app?

Here's a list of the replaced icons, but if I forgot anything let me
know:

* [x] Created generic `IconRenderer` component to abstract away the
package type from the rendering
  * [x] Add logic for color switch based on background color
* Replace icons in graph visualization
  * [x] Replace with EUI icons
  * [x] Replace with Maki icons
  * [x] Add `prevName` to recover old saved graph SO
  * [x] Fix selection preview icon
* For the `at` and `key` icons it needs to wait for a new EUI release
with https://github.com/elastic/eui/pull/6934
* Replace drill down icons 
  * [x] Replace with EUI icons
  * [x] Replace with Maki icons
  * [x] Find a substitute for Google icon
  * [x] Add `prevName` to recover old saved graph SO
* App toolbars
  * [x] Replace app toolbar icons with EUI icons
    * [x] Changed blocked list icon from `ban` to `filterIgnore`
  * [x] Replace styling icon + color swatches
    * The EUI `dot` icon was too small, so switches to rect icons 
  * [x] Replace merge icons on link selection
  * [x] Replace group/ungroup icons with `fold/unfold`
  * [x] Custom drilldowns
* [x] Removed `LegacyIcon`
  * Replaced usage in various places

New icons within field configuration + graph visualization

<img width="1061" alt="Screenshot 2023-07-17 at 11 00 35"
src="59f981e7-64b7-4ce5-b3ae-2582d46fc373">

<img width="302" alt="Screenshot 2023-07-17 at 15 13 04"
src="fb8d0e63-e982-406f-bd8d-036d71d37442">

New toolbar with blocked icon changed

<img width="202" alt="Screenshot 2023-07-17 at 15 13 40"
src="241206c4-7d3b-4296-bd6b-c2df3f3eabe5">

<img width="220" alt="Screenshot 2023-07-17 at 15 13 35"
src="5a648932-2f79-4c0e-a8d0-3ab165f68036">

<img width="272" alt="Screenshot 2023-07-17 at 12 41 12"
src="e3778d20-3000-496e-881b-61e5f086ae52">

New group/ungroup icons

<img width="168" alt="Screenshot 2023-07-17 at 12 41 25"
src="ffc963e6-4fea-4cb5-b0ef-cf8a71a71d6a">
<img width="252" alt="Screenshot 2023-07-17 at 15 15 27"
src="98b8b025-32fd-465e-9a66-40f4f866eb6e">

Selection with icons preview

<img width="260" alt="Screenshot 2023-07-17 at 15 07 17"
src="08dbda17-0c12-4fa4-8c92-77bbe90d7e14">
<img width="268" alt="Screenshot 2023-07-17 at 15 07 35"
src="78987838-42d5-46bf-9e46-b12cc603fa4e">

Panel with color styling open

<img width="266" alt="Screenshot 2023-07-17 at 15 07 44"
src="f5866e29-cf22-4e62-a2ff-3ef901c0d564">

Custom drilldowns (note Google icon has been replaced with a magnifier
icon)

<img width="331" alt="Screenshot 2023-07-18 at 17 49 07"
src="42e307d1-69b6-4e79-9e19-64c5efb7ee46">
<img width="381" alt="Screenshot 2023-07-18 at 17 51 44"
src="bc70c506-4390-45c1-aff5-8e22a68d7130">
<img width="271" alt="Screenshot 2023-07-17 at 15 08 31"
src="59fea7e4-a775-4006-805d-0610d7861890">
<img width="269" alt="Screenshot 2023-07-17 at 15 08 38"
src="f6c247a0-921d-4d9c-881a-796e02488df5">

Link selection

<img width="295" alt="Screenshot 2023-07-17 at 15 09 06"
src="d6a73013-130e-45a8-bdfc-48ac20e66a85">



### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
2023-07-20 09:24:47 +02:00
Marco Antonio Ghiani
446157f6d0
[Logs+] Restore Dataset selection from page URL (#161144)
## 📓  Summary

Closes #160425 

After the [first implementation of the log-explorer
profile](https://github.com/elastic/kibana/pull/159907), we wanted to
restore the selection of the dataset for a user when landing on the
Discover log-explorer profile.

Since we create an ad-hoc data view for Discover starting from the
dataset details, we needed to develop a system for intercepting the
`index` query parameter (which is used by Discover as the source of
truth for restoring a data view), create our ad-hoc data view and store
in the URL an encoded ID with the required details to restore the
selection.

The following video shows the user journey for:
- Landing on the log-explorer profile with no index param, nothing to
restore and fallback to All log datasets.
- Landing on the log-explorer profile invalid index param, notify about
failure and fallback to All log datasets.
- Select a different dataset, applies the new data view and update the
URL. When the URL is accessed directly, restore and initialize the data
view for the selection.
- Navigate back and forth in the browser history, restoring the
selection and data view on `index` param changes.


37a212ee-08e4-4e54-8e42-1d739c38f164

## 💡 Reviewer hints

To have better control over the page selection and the restore process,
we prepared the DatasetSelector component for [being controlled by the
parent component](https://github.com/elastic/kibana/pull/160971).
Having that ready, we now implemented a new top-level state machine with
the following responsibilities:
- Re-initialize (decompress/decode) the dataset selection from the
`index` query params.
- Derive and set into Discover state a new ad-hoc data view.
- Keep track of new dataset selection changes and update the URL state
and the current data view.

<img width="1224" alt="log-explorer-machine"
src="67e3ff17-dc3f-4dcf-b6c0-f40dbbea2d44">

We found a race condition between the Discover URL initialization + data
view initialization against the log-explorer profile customizations
being applied.
To guarantee we correctly initialize the state machine and restore the
selection before Discover goes through its initialization steps, we need
to wait for the customization service to exist in Discover so that also
the customization callbacks are successfully invoked.

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-07-20 09:21:08 +02:00
Marco Liberati
a3e1aab363
[Lens] Improve message for unsupported aggregation when using a TSDB counter field (#161481)
## Summary

This PR improves the message for the case where a visualization where a
counter field was used, but it wasn't yet in time series mode, then it
gets upgraded to timeseries and ES will restrict its agg support.
Added also few new documentation links to TSDS documentation pages.

Within a dashboard the error would be a reshape of the ES one:

<img width="774" alt="Screenshot 2023-07-17 at 17 58 17"
src="766c60e3-166c-4038-bf04-bbb1d5c08cb2">

Unfortunately it is only possible to show simple text (no link) within a
dashboard panel in view mode as it relies on native `Embeddable` types
which only allow native JS errors.

If user has edit permissions then it would be possible to click the
`Edit in Lens` to open the editor and see more information about the
error, i.e. the doc link:

<img width="513" alt="Screenshot 2023-07-17 at 17 50 39"
src="54c19c9f-7385-405e-8c4c-9061185ac52b">

To test just use the latest ES snapshot with this PR:
https://github.com/elastic/elasticsearch/pull/93545

~~Waiting for a link to some documentation from the ES team to be
included here as well.~~
Added link to https://github.com/elastic/elasticsearch/pull/97618
improved documentation.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2023-07-20 09:11:22 +02:00
Tiago Costa
b149926019
skip flaky suite (#159123, #159124) 2023-07-20 02:53:33 +01:00
Chris Cowan
8303ea9536
[Alerts] Fixing skipped unit tests for metric threshold rule (#162189)
## Summary

This PR fixes #155534 by ensuring result for the group by is set before
adding it to the evaluation results. I also applied the fix to the new
Observability Threshold Rule since we are using it as a starting point
for the new combined rule.
2023-07-19 13:54:53 -07:00
Cauê Marcondes
8ba4477933
[Profiling] Telemetry (#161702)
- Adding telemetry when the `show more information` is clicked in the
Flamegraph page
   key: `flamegraph_node_details_click`

- Adding telemetry when the `show more information` is clicked in the
TopN functions page
   key: `topN_function_details_click`

- Adding telemetry success/error on the initialization API
   Counter name: `POST /internal/profiling/setup/es_resources`
   Counter type: `success` or `error`

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-07-19 16:16:17 -03:00
Paul Tavares
4b38775515
[Security Solution][Endpoint] Unit tests for Policy settings form (#161814)
## Summary

- Adds unit tests for all components of the Policy settings form


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2023-07-19 14:17:42 -04:00
Lisa Cawley
a811538ee8
[OAS] Add Elasticsearch query rule parameters (#162001) 2023-07-19 10:46:39 -07:00
Carlos Crespo
c2249aa0b7
[Infra UI] Fix theme passed in to charts (#162114)
closes [#110217](https://github.com/elastic/kibana/issues/110217)
## Summary

This PR addresses an issue with how the infra sets the theme in charts.
It replaces the previous implementation with the use of
`useChartsBaseTheme` and `useChartsTheme` provided by the charts
service, ensuring consistent behavior for both light and dark modes.
From a UI perspective, this change doesn't introduce any alterations,
but it solves the problem related to dark mode.

### Screenshots

#### Node Details
<img width="899" alt="image"
src="7ec8b9e9-c440-44d1-86ac-45dbab76a8a9">

<img width="899" alt="image"
src="c6aac4a6-8982-47cc-b08e-ee5d8af0391f">


#### Infra
##### Timeline
<img width="720" alt="image"
src="cd4a1a3c-b5a4-47d5-bbde-5bf54dfac262">

<img width="720" alt="image"
src="839ccaf0-02a5-401e-957a-137d0ef25605">


##### Metrics
<img width="541" alt="image"
src="69138a89-21ff-4f17-bcbd-64ac609dd9e7">

<img width="541" alt="image"
src="63b02a7a-397e-451e-b4d7-7b37fdc4f6a9">


##### Processes
<img width="541" alt="image"
src="01e7d050-0103-4de6-8215-e93b9f80751b">

<img width="541" alt="image"
src="bd1ce95a-1944-411f-abc4-8f2a998f7643">


### Metrics Explorer
<img width="720" alt="image"
src="60d2857a-3b97-4fd6-8cc7-8b7ab757b3d5">

<img width="720" alt="image"
src="98bba0ea-27db-48a2-ae20-ff4162212c6e">


### Alert
#### Inventory rule
<img width="450" alt="image"
src="8b787e53-cb47-4254-ab69-69ab22ff0388">

<img width="450" alt="image"
src="a952bf6b-e22f-4753-8db6-f2deb213b22a">


#### Metric Threshold rule
<img width="450" alt="image"
src="db3d1448-5faa-4e20-bda8-7351d9b52144">

<img width="450" alt="image"
src="a11bc2de-f042-4d4f-9adc-d376205bc23f">


#### Logs rule
<img width="450" alt="image"
src="b703e972-2d47-485e-a2f5-4cfca0c982cd">

<img width="450" alt="image"
src="a98d3827-d930-4ef2-90f9-f336583f15da">




### How to tests
- Set up a local Kibana instance.
- Navigate to the pages mentioned above.
  - Change the user settings to both dark and light mode.
- In light mode, ensure that there are no differences in the charts when
compared to the edge cluster.
- In dark mode, confirm that the issue described in the ticket is
resolved (no horizontal line in white).

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-07-19 19:09:05 +02:00
Juan Pablo Djeredjian
887b3bde05
[Security Solution] Extend Prebuilt rules install and update workflow test coverage (#161687)
## Summary

- Implement test plan as described in
`x-pack/plugins/security_solution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md`

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-07-19 17:53:15 +02:00
Gerard Soldevila
2e15549b58
[FTR - esArchiver] Update the remaining "dynamic" archives, removing mappings.json (#162029)
## Summary

Part of https://github.com/elastic/kibana/issues/161882

- Updates the remaining "dynamic" es archives (aka those using the
`$KIBANA_PACKAGE_VERSION` variable), deleting mappings.json.
- It also removes the piece of logic in `esArchiver` that replaces that
variable.
2023-07-19 17:43:00 +02:00
Tiago Costa
0f967055de
fix(NA): i18n_check 2023-07-19 16:27:45 +01:00
Giorgos Bamparopoulos
a8f9f73e19
[APM] Fix transaction action menu for trace explorer and dependency operations (#162213)
### Before

3fcceac7-6cf6-4060-972e-86fc4c799115

### After

0eccce82-4ffc-4c9e-8f8f-baf89cfbccec


Closes https://github.com/elastic/kibana/issues/162175

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-07-19 16:25:08 +01:00
Marco Antonio Ghiani
917e3f219b
[Logs Explorer]: Update integration icons type (#162219)
## 📓 Summary

The integrations returned from the API have an `icons` property which is
an array of icon object descriptors.

The runtime validation on the clientside was not aligned with the type
of these icons, which are retrieved from the package manifest and have
some optional attributes, while the current implementation assumed all
the properties were mandatory.

This PR aligns the runtime type with the
[PackageSpecIcon](https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/common/types/models/package_spec.ts#L114)
type.

<img width="314" alt="Screenshot 2023-07-19 at 11 08 01"
src="ff51bad6-89dd-44f3-a959-24d6717db235">
<img width="315" alt="Screenshot 2023-07-19 at 11 08 18"
src="10cb05bc-c138-4c03-9d8b-74f5a4b7aab0">

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
2023-07-19 17:15:12 +02:00
Drew Tate
092e988df2
[Lens][Event annotations] Move logic into packages (#161500) 2023-07-19 09:46:57 -05:00
Walter Rafelsberger
11cc1e1be6
[ML] AIOps: Rename Explain Log Rate Spikes to Log Rate Analysis. (#161764)
## Summary

Part of #161832.

This PR renames the Explain Log Rate Spikes feature to **Log Rate
Analysis**.

- [x] Renamed references in `docs/developer/*`
- [x] Updated docs screenshots
- [x] Redirect in docs
- [x] Redirect urls from `explain_log_rate_spikes` to `log_rate_analysis`
- [x] API versioning
- [x] Renamed navigation links
- [x] Renamed variable names
- [x] Renamed file names
- [x] Renamed i18n ids
- [x] Renamed breadcrumbs 
- [x] Removed hard coded `AIOPS_ENABLED` feature flag
2023-07-19 16:46:31 +02:00
Yngrid Coello
06cfd36787
[Logs onboarding] UI changes in custom logs onboarding flow (#162148)
Relates to https://github.com/elastic/kibana/issues/159655.

### Changes

This PR include the following changes:

#### ConfigureLogs step

- [x]  Change page title into “Stream log files to Elastic”
- [x] Remove stepper
- [x] Remove ’Stream log files to Elastic’ title inside the white box
- [x] Add tooltip to Dataset name with the text “Provide a dataset name
to help identify the source of your logs in future uses. Defaults to the
name of the log file.”
- [x] Add Dataset name input placeholder with “Give your logs a name”
- [x] Change helper text on Dataset name input to “All lowercase, max
100 chars, special characters will be replaced with ‘_’.”
- [x] Add tooltip to Service name with the text “Provide a service name
to allow for distributed services running on multiple hosts to correlate
the related instances.”
- [x] Add Service name input placeholder with “Give your service a name”
- [x] Add tooltip to Namespace (under advanced settings) with the text
“Provide a namespace to customize the grouping of your logs. Defaults to
the default namespace."

##### Before
<img width="1691" alt="image"
src="1b047624-1160-40eb-85ee-199d0874c805">

##### After
<img width="1690" alt="image"
src="572d7615-1363-4892-9b78-994f393a3ebe">


#### InstallShipper step

- [x] Change page title into “Install shipper to collect logs”
- [x] Remove stepper
- [x] Remove ’Install shipper to collect data’ title inside the white
box
- [x] Change first paragraph with “To collect the data from your system
and stream it to Elastic, you first need to install a shipping tool on
the machine generating the logs. In this case, the shipper is an Agent
developed by Elastic.”
- [x] Change text in first step (Install the Elastic agent) with “Select
your platform, and run the install command in your terminal to enroll
and start the Elastic Agent. Do this for each host. Review host
requirements and other installation options before installing.”
- [x] “Host requirements…” should open a link in a new tab to:
[https://www.elastic.co/guide/en/fleet/8.7/elastic-agent-installation.html](https://www.elastic.co/guide/en/fleet/8.7/install-standalone-elastic-agent.html)
- [x] Move up automatic config download switch before the agent download
code block
- [x] Change switch text to “Automatically download the agent’s config”
and add tooltip: “Turn on to add a string to the following code block
that downloads the agent's standard configuration to your host during
installation. Turn off to manually configure the agent in the next
step.”
- [x] When the users turn on the switch, we need to show a callout with
the following text: “Automatically downloading the agent config will
overwrite any existing agent config on your host.”
- [x] During the completion of the first step ‘Install the Elastic
agent’ provide users with callouts that appear as things happen: first
Elastic agent download, then Elastic agent extracted… and so on
- [x] If the user has the switch on (to automatically download the
config), they should also receive the callout confirmation that the
config was written to the yml file
- [x] Change paragraph text of ‘Configure the Elastic agent’ step to
“Add the following configuration to the elastic-agent.yml on the host
where you installed the Elastic agent.”
- [x] Change step 3 titles to “Ship logs to Elastic Observability”
(default state), “Waiting for Logs to be shipped...” (Loading state) and
“Logs are being shipped!” (Success state)
- [x] Change the style of ‘back’ button to Empty + add arrowLeft icon
with primary color
- ~~[ ] Change ‘Inspect’ button with default style, primary color. The
button should become active only when the full installation flow is
finished~~
- ~~[ ] Open the inspect of the installation in a flyout to avoid
interrupting the user flow~~

##### Before
<img width="1674" alt="image"
src="9c0539a3-6cde-4029-a6d3-2978f91b40de">

##### After
<img width="1671" alt="image"
src="84775312-fb5b-4646-90de-6268dec69246">

### Video


e8ae7067-604f-48fd-9b3d-7e7c0791df38
2023-07-19 16:16:24 +02:00
Yngrid Coello
0fd8a1196e
[Logs onboarding] Error handling in configureLogs step (#162241)
Closes https://github.com/elastic/kibana/issues/156529.

`Dataset name` is a field that is auto populated based on the `Log file
path`, if the user deletes the autogenerated value they cannot continue
with the next step but before this changes there were no indicative of
why they cannot continue.

### Changes
- Added validation function to datasetName field.
- Added i18n error.

#### Before
<img width="2199" alt="image"
src="24cc166e-c143-4b35-9372-0fcdb4e78f4a">

#### After
<img width="2200" alt="image"
src="72302aa6-1597-439b-8d80-88e7debf1010">
2023-07-19 16:05:34 +02:00
Tiago Costa
9c0503c523
skip flaky suite (#152206) 2023-07-19 14:37:08 +01:00
Shahzad
73695efac3
[Synthetics] Simplify journey API query (#162188) 2023-07-19 06:10:23 -07:00
Pete Harverson
46403f1c1b
[ML] Adds a11y tests for categorization and recognizer job wizards (#162126)
## Summary

Adds accessibility tests for the categorization and data recognizer
anomaly detection job wizards.

As part of this PR I have split out the tests for the anomaly detection
pages into a separate file as the original `ml.ts` file was getting very
large.

Part of https://github.com/elastic/kibana/issues/160712
Part of #88496

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2023-07-19 14:03:40 +01:00
Kibana Machine
8fd0577a72 skip failing test suite (#162220) 2023-07-19 09:02:41 -04:00
GitStart
39807919f0
[Fleet] Use theme service to display in Dark Mode when set on User Profile (#161819)
Closes https://github.com/elastic/kibana/issues/161135

## What does this PR do?
* Fixes the darkMode theme in fleet page.

## Issue References
* https://github.com/elastic/kibana/issues/161135

## Video/Screenshot Demo 
##### Before

![250689182-c9c4fe55-c007-424a-aedc-b863f1fd0c88-2](71dd9889-3e2d-4b5b-8825-5f7f18206903)

![250689299-34149e80-40b8-493d-a8fc-3079c8cb199c](fdd1b8af-6a5f-4e6c-892e-73baf58d1aab)

###### FIX:

![250690628-2774dc86-487e-489e-b0a2-a1c06539172d](4525bbfa-7771-4611-a099-751c7be54ec6)

![250691578-74d860fa-1db5-47c4-a3b7-425e86720e06](0b03267a-dfb7-48dd-adc3-e9fc3ad5013b)

---
This code was written and reviewed by GitStart Community. Growing future
engineers, one PR at a time.

---------

Co-authored-by: KlingerMatheus <klinger.matheus@gitstart.dev>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
Co-authored-by: Klinger Matheus <50892465+KlingerMatheus@users.noreply.github.com>
Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-07-19 14:56:35 +02:00
Christos Nasikas
4540b38380
[Cases] Version connectors domain and apis (#162059)
## Summary

This PR versions the `connector` domain object and its corresponding
APIs

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-07-19 05:34:05 -07:00
Konrad Szwarc
f961e8b557
[Fleet] Kafka integration UI (#160112)
This PR addresses the UI aspect of
https://github.com/elastic/kibana/issues/143324

Happy path


d1664e68-1fb6-42b8-8585-d7132c47d76f

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-07-19 08:22:52 -04:00
Alexi Doak
622d994584
[ResponseOps][Alerting] Add missing rule.params descriptions for Stack rules (#161807)
Resolves https://github.com/elastic/kibana/issues/161710

## Summary

Related to this issue: https://github.com/elastic/kibana/issues/161126

Added missing descriptions for the index threshold rule params.


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: lcawl <lcawley@elastic.co>
Co-authored-by: Ying Mao <ying.mao@elastic.co>
2023-07-19 08:15:17 -04:00
James Gowdy
219426dc7a
[ML] Creating category validation package (#161261)
Moves the server and client side code which performs analysis on data to
see whether it is suitable for categorization.
This is currently only used by the categorization job wizard to display
this callout:

![image](08db5321-0c38-474d-9bfe-90b8a9ad984a)

However this analysis will be useful for the Log Pattern Analysis
feature and so moving the code to a package allows easier sharing
between ML and AIOPs plugins.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-07-19 12:34:29 +01:00
Kibana Machine
85c85e90f9 skip failing test suite (#162221) 2023-07-19 07:06:31 -04:00
Shahzad
734c1e1528
[Synthetics] Remove usage of deprecated EuiPageTemplate (#162186)
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-07-19 12:49:04 +02:00
jennypavlova
8f2d23ffa7
[Infra UI] Asset Details Flyout: Add tooltip with documentation link in metadata summary (#162132)
## Summary

This PR adds a tooltip with a documentation link in the metadata summary
inside the asset details overview section. It should appear only if we
have defined documentation link so currently only for the `host.ip`
field

<img width="1918" alt="Screenshot 2023-07-18 at 13 13 25"
src="e5ef2067-3a3b-48fd-a395-b763a6832bd1">

## Storybook

<img width="1917" alt="image"
src="dfbd0118-b0ff-475b-a545-9e7278815098">


## Testing
- Go to host view and open the asset details flyout for any host
- Go to the overview tab
- A question mark icon should appear next to the host ip title inside
the metadata section
- Click on the icon and check the tooltip
- the `host.ip` link should open the documentation page for the field in
a new tab



c83dcefd-34b1-4f61-aa96-b9fd0e6ef07b
2023-07-19 11:55:07 +02:00
jennypavlova
e98abd0fb5
[Infra UI] Hosts view test: fix apm services link (#162147)
Closes https://github.com/elastic/kibana/issues/162051
Closes #159368
## Summary

This PR aims to make the APM services link test more stable. For some
reason, some of the query parameters are not present in the URL the
moment we navigate but we can see in the screenshot that the correct
dates are applied (it could be that the moment we load APM the URL is
not updated - when checking locally those parameters exist in the URL)
<img width="1612" alt="image"
src="2363108a-329e-4f28-a0d8-9f177d01d4ef">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-07-19 10:30:43 +02:00
Sander Philipse
0a6b5e92b8
[Serverless Search] Remove unwanted alterting rule and connector types (#162105)
## Summary

This moves alerting in Serverless Search to the Stack Management
alerting page, and removes

To remove these rule types, I had to disable the observability,
securitySolution, uptime, monitoring and infra plugins and make sure
that their server plugins (not just the frontend plugins) respected the
`enabled: false` flag.
2023-07-19 16:21:02 +08:00
Tomasz Ciecierski
9c7dda0b90
[Defend workflows] Stop spreading whole request to ES dsl (#162116) 2023-07-19 09:58:45 +02:00
Lukas Olson
13372c91ce
[data] Use versioned router for remaining routes (#161919)
## Summary

Uses the versioned router for the remaining routes in the data plugin:
KQL telemetry (opt-in stats), and scripting languages list.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
2023-07-18 14:40:11 -07:00
Steph Milovic
e96dd5cac4
[Security solution] Bump GenAI connector license to Enterprise (#162184) 2023-07-18 14:54:55 -06:00
Ahmad Bamieh
384e2eda83
[i18n] Integrate 8.9.0 Translations (#162153) 2023-07-18 23:21:07 +03:00