kibana

18711 commits 437 branches 496 tags 23 GiB

Author	SHA1	Message	Date
Joe Fleming	0999ebf273	Fix: socket setup (#24550 ) PR fixes issues with the socket connection. - handle socket failures - previously would either leave Canvas in an infinite loading state, or load the app even when it wouldn't function - upgrade socket.io - add headers to socket connection and modify auth connection	2018-11-02 10:39:36 -07:00
Joe Fleming	fe7c9ec9e7	Fix: Canvas socket auth (#24094 ) ## Summary Closes https://github.com/elastic/kibana/issues/23303 ~(@cqliu1 can you confirm this too?)~ confirmed Fixes the way we capture the request info when configuring the socket and providing it to plugins via `callWithRequest`. Instead of exposing a route that returns the info, simply use the request object that comes back from `server.inject`. Also adds a check in the `elasticsearchClient` handler exposed to plugins to ensure the session is still valid because using `callWithRequest`. ![screenshot 2018-10-16 10 37 56](https://user-images.githubusercontent.com/404731/47036828-32768c00-d132-11e8-81a0-122b5e83c7ef.png) Note: the actual error message is a bit different, but this is how the failure is exposed to the user	2018-10-23 17:20:11 -07:00

Author

SHA1

Message

Date

Joe Fleming

0999ebf273

Fix: socket setup (#24550 )

PR fixes issues with the socket connection.

- handle socket failures 
  - previously would either leave Canvas in an infinite loading state, or load the app even when it wouldn't function
- upgrade socket.io
- add headers to socket connection and modify auth connection

2018-11-02 10:39:36 -07:00

Joe Fleming

fe7c9ec9e7

Fix: Canvas socket auth (#24094 )

## Summary

Closes https://github.com/elastic/kibana/issues/23303 ~(@cqliu1 can you confirm this too?)~ confirmed

Fixes the way we capture the request info when configuring the socket and providing it to plugins via `callWithRequest`. Instead of exposing a route that returns the info, simply use the request object that comes back from `server.inject`.

Also adds a check in the `elasticsearchClient` handler exposed to plugins to ensure the session is still valid because using `callWithRequest`.

![screenshot 2018-10-16 10 37 56](https://user-images.githubusercontent.com/404731/47036828-32768c00-d132-11e8-81a0-122b5e83c7ef.png)
*Note:* the actual error message is a bit different, but this is how the failure is exposed to the user

2018-10-23 17:20:11 -07:00

Renamed from x-pack/plugins/canvas/server/routes/get_auth/insecure_auth_route.js (Browse further)

2 commits