Liza Katz
204efae5bf
[Data cleanup] unify serializable state ( #107745 )
...
* Use Serializable from package
* Rename to align with core
* fix
* more replacements
* docssss
* fix
* Move it to @kbn/utility-types and remove core export
* buildy build
* tests
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-10 13:03:48 +02:00
Mikhail Shustov
5480c4d0f4
[Execution context] Add nested context support ( #107523 )
...
* Add nested context support
* remove execution context service on the client side
ExecutionContextContaier is not compatible with SerializableState, so I had to fall back to passing context as POJO. With this change, using a service looks like overhead.
* update docs
* fix test
* address comments from Josh
* put export back
* update docs
* remove outdated export
* use input.title for unsaved vis
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-08-10 08:53:40 +02:00
Peter Pisljar
5aa8a0a818
persistable state migrations ( #103680 )
2021-07-07 22:42:16 +02:00
Anton Dosov
7d51ee00c5
[Search Session] Fix dangling search sessions ( #102927 )
2021-07-05 11:30:40 +02:00
Marco Liberati
dfc70bdfd1
[Lens] Enable actions on Lens Embeddable ( #102038 )
...
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-25 14:59:36 +02:00
Alexey Antonov
78b803be2b
Add telemetry for editor clicks events ( #100664 )
...
* Track editor clicks events
Closes : #98949
* add create and open telemetries
* add telemetry for dashboard
* remove hardcoded originatingApp for lens
* DashboardConstants.DASHBOARDS_ID -> DashboardConstants.DASHBOARD_ID
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 16:16:56 +03:00
Devon Thomson
413e2ddf20
[Dashboard] Embeddable Migrations for By Value Panels ( #99715 )
...
* Implemented embeddable by value migrations
2021-05-19 16:19:15 -04:00
Vadim Dalecky
77fe59d58f
Drilldown cloning ( #91959 )
...
* refactor: 💡 remove switch statement
* feat: 🎸 improve <ListManageDrilldowns> stories
* refactor: 💡 remove <FlyoutListManageDrilldowns> component
* refactor: 💡 simplify <FlyoutDrilldownWizard> component
* feat: 🎸 introduce React context for drilldowns flyout
* refactor: 💡 rename drilldown manager component
* refactor: 💡 rename drilldown manager in example plugin
* refactor: 💡 rename folder to "containers"
* feat: 🎸 use drilldown context to store UI state
* chore: 🤖 fix linter errors
* refactor: 💡 move Drilldown Manager into its own folder
* feat: 🎸 add drilldown state management
* feat: 🎸 add <PresentablePicker> component
* chore: 🤖 clean up component props
* feat: 🎸 add <ActionFactoryPicker> component
* feat: 🎸 connect action factory picker component
* chore: 🤖 cleanup
* feat: 🎸 start work on <DrilldownForm>
* feat: 🎸 add <TriggerPicker> component
* test: 💍 add <TriggerPicker> stories
* feat: 🎸 add <DrilldownForm> component
* refactor: 💡 remove ActionFactory from <DrilldownForm>
* feat: 🎸 connect <DrilldownForm> component
* feat: 🎸 improve new drilldown connected form
* fix: 🐛 correct TypeScript types
* feat: 🎸 show trigger intersection in the UI
* feat: 🎸 add <ActionFactory> component
* feat: 🎸 show connected <ActionFactoryView> component
* feat: 🎸 use a single action factory control
* fix: 🐛 remove unused props
* refactor: 💡 improve create drilldown form
* fix: 🐛 correct hello bar close callback
* feat: 🎸 connect welcome message state to local storage
* fix: 🐛 correct TypeScript errors
* fix: 🐛 hide correctly hello bar
* feat: 🎸 add drilldown creation logic
* feat: 🎸 connect event list state
* fix: 🐛 correct story props
* fix: 🐛 correct typescript errors
* feat: 🎸 navigate to list view when drilldown is created
* feat: 🎸 add EUI tabs
* feat: 🎸 connect route state to tabs
* refactor: 💡 move flyout content into a separate component
* refactor: 💡 move manager tabs into a separate component
* chore: 🤖 delete unused variables
* feat: 🎸 make drilldowns title dynamic
* docs: ✏️ update README
* feat: 🎸 add <DrilldownManagerTitle> component
* feat: 🎸 make flyout footer dynamic
* refactor: 💡 make action factory state depend on the route
* feat: 🎸 create standalone new drilldown form
* fix: 🐛 support i18n in new drilldown form
* feat: 🎸 add space between action factory picker
* refactor: 💡 simplify <DrilldownManagerContent>
* feat: 🎸 add back chevron button to drilldown flyout
* chore: 🤖 remove unused translations
* chore: 🤖 delete unused translation file
* feat: 🎸 add <DrilldownManagerFooter> and improve title comp
* feat: 🎸 improve <CreateDrilldownForm>
* refactor: 💡 improve variable name
* feat: 🎸 add isValid() to drilldown state
* refactor: 💡 move drilldown hello bar into a seprate component
* feat: 🎸 show drilldown list on "Manage" tab
* refactor: 💡 improve drilldown list component
* feat: 🎸 connect drill list comp to delete and edit functional
* feat: 🎸 support form disabling when drill creation in progress
* feat: 🎸 connect drilldown edit form
* feat: 🎸 use /manage route for editing drilldowns
* fix: 🐛 render constant action factory in edit mode
* refactor: 💡 move drilldown footer submit button in a sep comp
* feat: 🎸 connect editing to drilldown edit form
* feat: 🎸 disable edit buttons when list has selection
* chore: 🤖 remove unused code
* feat: 🎸 show error if delete fails
* chore: 🤖 remove legacy code
* feat: 🎸 improve drilldown table component
* fix: 🐛 fix "Trigger" translation
* fix: 🐛 import correct drilldown table item
* feat: 🎸 handle empty name errors
* feat: 🎸 track config error in drilldown state
* feat: 🎸 track drilldown state trigger errors
* fix: 🐛 pre-select trigger if only one trigger is available
* feat: 🎸 add drilldown template interface
* feat: 🎸 progress on drilldown cloning list
* feat: 🎸 use table view to display drilldown cloning templates
* feat: 🎸 generate drilldown templates from embeddable siblings
* feat: 🎸 improve drilldown template generation logic
* feat: 🎸 improve drilldown template preview
* feat: 🎸 improve start from template table view
* feat: 🎸 show number of items to be cloned
* feat: 🎸 add ID to drilldown templates
* feat: 🎸 implement basic cloning functionality
* feat: 🎸 add ability to create drilldown from existing one
* feat: 🎸 improve cloning behaviour
* feat: 🎸 improve icon of templates
* feat: 🎸 remove "Start from template" accordion
* feat: 🎸 improve cloning table view
* feat: 🎸 add "Triggers" column
* feat: 🎸 enable drilldown actions in "edit" mode
* fix: 🐛 reset drilldown state cache by factory on new creation
* refactor: 💡 use in-memory table for drilldown template list
* feat: 🎸 add search box to drilldown template in-memory table
* feat: 🎸 show back chevron on no steps back, to close flyout
* feat: 🎸 show notification when drilldown was just cloned
* feat: 🎸 add i18n to cloning notification, and move to sep comp
* feat: 🎸 add support for plural and singular in translation
* feat: 🎸 make new drilldown names unique with (copy x) at end
* feat: 🎸 rename cloning to copying
* feat: 🎸 show incompatible trigger warning in template list
* refactor: 💡 craete text with icon component
* feat: 🎸 show trigger warning in manage view
* refactor: 💡 use <TextWithIcon> in drilldown table view
* feat: 🎸 add <TriggerLineItem> component
* feat: 🎸 show tooltip on incompatible icon hover
* feat: 🎸 unify tooltips in <TextWithIcon> component
* feat: 🎸 enable sorting in drilldown tables
* fix: 🐛 correct ui actions x-pack typescript errors
* fix: 🐛 correct ui actions example plugin errors
* docs: ✏️ update autogenerated docs
* chore: 🤖 remove unused translations
* test: 💍 remove implementation from todo placeholders
* test: 💍 fix dashboard drilldown functional test
* chore: 🤖 remove unused constants
* test: 💍 fix url drilldown functional test
* test: 💍 add drilldown manager state tests
* feat: 🎸 dont show back button when no more steps back
* feat: 🎸 pre-fill in drilldown name
* feat: 🎸 add copy suffix when creating new drilldown
* feat: 🎸 close flyout if opened in create mode
* feat: 🎸 dont close flyout if user navigated to "manage" tab
* feat: 🎸 show smaller notification message on cloning
* feat: 🎸 add "(copy X)" text when cloning/copying drilldowns
* feat: 🎸 make copy prefixes start from "(copy)"
* feat: 🎸 add link to dismiss notification
* feat: 🎸 rename "Clone (x)" button to "Copy (x)"
* feat: 🎸 rename tempalte table last column copy button
* feat: 🎸 use "copied" terminology in notification
* feat: 🎸 add "Copy existing drilldown" label to template picker
* feat: 🎸 use "auto" layout on drilldown template picker table
* test: 💍 add drilldown manager tests
* feat: 🎸 swap label for title
2021-04-19 19:26:05 +02:00
Catherine Liu
3b31d81196
[Dashboard] Makes lens default editor for creating new panels ( #96181 )
...
* Makes lens default editor in dashboard
Added all editors menu to dashboard panel toolbar
Fixed toggle on editor menu
Removed unnecessary comments
Added data test subjects to editor menu buttons
Populated editor menu with vis types
Removed unused imports
Fixed imports
Adds showCreateNewMenu prop to AddPanelFlyout
Rearranged order of editor menu options
Fixed ts errors
Added groupnig to embeddable factory
Use embeddable state transfer service to redirect to editors
Added showGroups to TypeSelectionState
Fixed add panel flyout test
Fixed data test subjects
Fixed factory groupings
Removed unused import
Fixed page object
Added telemtry to dashboard toolbar
Added telemtry to editor menu
Fix ml embeddable functional tests
Fix lens dashboard test
Fix empty dashboard test
Fixed ts errors
Fixed time to visualize security test
Fixed empty dashboard test
Fixed clickAddNewEmbeddableLink in dashboardAddPanel service
Fixed agg based vis functional tests
Revert test changes
Fixed typo
Fix tests
Fix more tests
Fix ts errors
Fixed more tests
Fixed toolbar sizes and margins to align with lens
Fix tests
Fixed callbacks
Fixed button prop type
New vis modal copy updates
Added savedObjectMetaData to log stream embeddable factory
Addressed feedback
Fixed ts error
Fix more tests
Fixed ts errors
Updated dashboard empty prompt copy
Adds tooltip to log stream embeddable factory saved object meta data
Made icons monochrome in toolbar
Fixed icon colors in dark mode
Cleaned up css
Fixed ts errors
Updated snapshot
Fixed map icon color
* Added tooltips for ML embeddables
* Restored test
* Added empty dashboard panel test
* Fixed i18n id
* Fix dashboard_embedding test
* Removed unused service
* Fixed i18n error
* Added icon and description properties to embeddable factory definition
* Fixed ts errors
* Fixed expected value
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-17 22:29:27 -07:00
Shahzad
cbf24cd640
[Lens] Open lens in new tab via state transfer ( #96723 )
2021-04-15 14:49:55 +02:00
Corey Robertson
b645fec8b8
[Dashboard] Move all dashboard extract/inject into persistable state ( #96095 )
...
* Move all dashboard inject/extract to be part of embeddable persistable state
* Fixes typescript errors
* Remove comments
* Fixes test
* API Doc changes
* Fix integration tests
* Fix functional testS
* Fix unit tests
* Update Dashboard plugin API to get dashboard embeddable renderer
* Fix Types
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-12 12:25:03 -04:00
Uladzislau Lasitsa
e3f31ea9ad
[Visualize] Allows editing broken visualizations caused by runtime fields changes ( #94798 )
...
* Add possibility to open visualization when saved field doesn't exists anymore
* Fix tests
* Fix some remarks
* Remove unneeded code
* Fix tests
* Fix tests
* Fix some remarks
* Fixed problem with double error popover in visualizations
* Fix CI
* Fix type
* Fix API docs
* Don't show error popup for error related to runtime fields
* Fix some remarks
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-08 17:29:57 +03:00
Devon Thomson
7994e87cd7
[Time to Visualize] Clear All Editor State when Visualize Listing Page Loads ( #91005 )
...
* Changed the embeddable state transfer service so that it is possible to clear all editor state at once. Used that method in the visualize listing page
2021-02-11 23:23:14 -05:00
Devon Thomson
31a3ec5934
[Time To Visualize] Make State Transfer App Specific ( #89804 )
...
* made state transfer app specific
2021-02-08 15:31:09 -05:00
Josh Dover
0af81310b6
Remove dynamic mapped types from UiActions ( #87075 )
...
* Remove dynamic mapped types from UiActions
* Remove import between data <-> embeddables
* remove outdated comments, export action types from discover_enhanced
* fix notice.txt
Co-authored-by: restrry <restrry@gmail.com>
2021-01-05 10:11:05 +01:00
Devon Thomson
1d856c39b5
Fix Add From Library Flyout Staying Open ( #86698 )
...
* Fixed add from library flyout staying open after save or cancel
2020-12-22 11:41:35 -05:00
Joe Reuter
57a72a78f7
[Lens] Configurable color syncing ( #86180 )
2020-12-22 17:35:27 +01:00
Luke Elmers
9a3e2910a3
App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. ( #82791 )
...
* Move applyFilter, selectRange, valueClick triggers to data/embeddables.
* Update imports.
* Remove embeddable references to non-existent data plugin dependency.
* remove data mocks from embeddable
* Remove query, filters, timeRange from EmbeddableInput and move to apps.
* Remove data plugin imports from embeddable test samples.
* Remove circular dependencies caused by expressions renderer handlers.
* Update circular deps allowList.
* Remove data dependency on embeddable.
* Revert accidental data plugin change.
* Fix new circular deps issues.
* Update generated docs.
* Fix type errors in vis_type_xy
* Fix inspector data table.
2020-12-18 18:34:07 -07:00
Devon Thomson
8ce9b474d6
[Time to Visualize] Fix Dashboard OnAppLeave ( #86193 )
...
Added isTransferInProgress to embeddable_state_transfer for apps to determine whether or not to show onAppLeave confirm
2020-12-18 15:07:36 -05:00
Peter Pisljar
b93034b72c
inspector table adapter cleanup ( #84232 )
2020-12-17 12:14:07 +01:00
Devon Thomson
ee37f6dd91
[Time to Visualize] Transition Embeddable State Transfer to Session Storage ( #85688 )
...
* Transitioned embeddable state transfer service to use sessionStorage
2020-12-15 13:18:36 -05:00
Vadim Dalecky
b01a327076
Row trigger 2 ( #83167 )
...
* feat: 🎸 add ROW_CLICK_TRIGGER
* feat: 🎸 wire row click event to UI Actions trigger in Lens
* feat: 🎸 add row click trigger to url drilldown
* feat: 🎸 add datatable to row click context
* feat: 🎸 pass in row index in row click trigger context
* feat: 🎸 add columns to row click trigger context
* feat: 🎸 fill values and keys event scope array
* feat: 🎸 generate correct row scope variables
* fix: 🐛 report triggers from lens embeddable
* feat: 🎸 add sample preview for row click trigger
* feat: 🎸 remove url drilldown preview box
* chore: 🤖 remove mock variable generation functions
* feat: 🎸 generate context and global variable lists
* feat: 🎸 preview event variable list
* feat: 🎸 show empty url error on blur
* feat: 🎸 add ability to always show popup for executed actions
* refactor: 💡 rename multiple action execution method
* fix: 🐛 don't add separator befor group on no main items
* feat: 🎸 wire in uiActions service into datatable renderer
* feat: 🎸 check each row if it has compatible row click actions
* feat: 🎸 allow passing data to expression renderer
* feat: 🎸 add isEmbeddable helper
* feat: 🎸 pass embeddable to lens table renderer
* feat: 🎸 hide lens table row actions which are empty
* feat: 🎸 re-render lens embeddable when dynamic actions chagne
* feat: 🎸 hide actions column if there are no row actions
* feat: 🎸 re-render lens embeddable on view mode chagne
* fix: 🐛 fix TypeScript errors
* chore: 🤖 fix TypeScript errors
* docs: ✏️ update auto-generated docs
* feat: 🎸 add hasCompatibleActions to expression layer
* feat: 🎸 remove "data" from expression renderer handlers
* fix: 🐛 fix TypeScript errors
* test: 💍 fix Jest tests
* docs: ✏️ update autogenerated docs
* fix: 🐛 wrap event payload into data
* test: 💍 add "alwaysShowPopup" test
* chore: 🤖 add comment requested in review
https://github.com/elastic/kibana/pull/83167#discussion_r537340216
* test: 💍 add hasCompatibleActions test
* test: 💍 add datatable renderer test
* test: 💍 add Lens embeddable input change tests
* test: 💍 add embeddable row click test
* fix: 🐛 add url validation
* test: 💍 add url drilldown tests
* docs: ✏️ remove url drilldown preview from docs
* docs: ✏️ remove preview from url templating
* docs: ✏️ add row click description
* chore: 🤖 move 36.5 KB bundle balance to url_drilldown
* test: 💍 simplify test case
* style: 💄 change types places
* refactor: 💡 clean up panel variable generation
* test: 💍 add getPanelVariables() tests
* fix: 🐛 generate runtime variables correctly
* fix: 🐛 improve getVariableList() and add tests for it
* feat: 🎸 add translation, improve types
2020-12-14 13:28:23 +01:00
Pierre Gayvallet
a4caffae2f
Improve and cleanup chrome helpMenu links ( #82300 )
...
* Improve and cleanup chrome helpMenu links
* update doc due to merge
* remove dev dependencies from test plugin
* update generated doc after merge
* update generated doc
* generated doc
* generated doc
2020-12-11 11:38:25 +01:00
Anton Dosov
cb29438b0d
[Search] Fix dashboard embeddables don't refetch on searchSessionId change ( #84261 )
2020-12-10 14:21:35 +01:00
Luke Elmers
62e06aee9b
[esaggs][inspector]: Refactor to prep for esaggs move to server. ( #83199 )
2020-11-18 09:11:05 -07:00
Anton Dosov
eaa65535ed
Use saved object references for dashboard drilldowns ( #82602 )
2020-11-12 15:54:55 +01:00
Devon Thomson
7c66880a11
[Time to Visualize] Embeddable Error Handling Without ReplacePanel ( #82201 )
...
Fixed embeddable error handling so that fatal errors are caught and displayed with an errorEmbeddable no matter when they occur.
2020-11-05 11:11:29 -05:00
Peter Pisljar
7f70fc8478
Embeddables/migrations ( #82296 )
2020-11-05 07:03:23 +01:00
Vadim Dalecky
aaadbe88c5
Context menu trigger for URL Drilldown ( #81158 )
...
* feat: 🎸 add context menu trigger to URL drilldown
* fix: 🐛 translate "Drilldowns" grouping title
* feat: 🎸 add dynamic action grouping to dynamic actions
* fix: 🐛 add translations to trigger texts
* feat: 🎸 enambe ctx menu trigger in both flyouts, move to end
* fix: 🐛 show context menu event scope variable sfor ctx menu
* test: 💍 add tests
* fix: 🐛 use correct namespace for translation keys
* docs: ✏️ update autogenerated docs
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-30 13:04:48 +01:00
Anton Dosov
6deafd06b8
[Search] Use session service on a dashboard ( #81297 )
2020-10-29 16:43:22 +01:00
Peter Pisljar
c90dabaeba
removing kibana_datatable in favor of datatable ( #80548 )
2020-10-16 18:46:51 +02:00
spalger
6eeab00944
Revert "removing kibana_datatable in favor of datatable` ( #75184 )"
...
This reverts commit 255b865be8
2020-10-13 08:53:14 -07:00
Peter Pisljar
255b865be8
removing kibana_datatable in favor of datatable` ( #75184 )
2020-10-13 17:00:38 +02:00
Maja Grubic
13059bdd8f
[Refactor] Move AttributeService from Dashboard to Embeddable plugin ( #79830 )
...
* [Refactor] Move AttributeService from Dashboard to Embeddable plugin
* Fix wrong import
* Fixing typescript errors
* Make Dashboard a required dependency
* Fixing circular dependency
* Fix label namespace
* Updating docs
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-12 14:51:39 +01:00
Peter Pisljar
90a6d2924e
Embeddables: basic documentation ( #78900 )
2020-09-30 21:19:06 +02:00
