Commit graph

9 commits

Author SHA1 Message Date
Tim Roes
5307703782
Fix link in embed visualize docs (#22557) (#22571) 2018-08-31 10:24:52 +02:00
Tim Roes
f9b33021eb
Update destroy documentation of vis loader (#21649) (#21678) 2018-08-06 14:07:47 +02:00
Peter Pisljar
5753442209
update visualize development docs (#20507) (#20594) 2018-07-10 07:07:53 +02:00
CJ Cenizal
c6be289f21
Fix misspellings (#19981) (#20284) 2018-06-27 20:50:06 -07:00
Tim Roes
b24ac9c814
Refactor and improve Visualize Loader (#15157) (#15362)
* Simplify promise setup logic

* Import template from own file

* Use angular.element instead of jquery

* Add documentation for loader methods

* Add params.append

* Remove params.editorMode

* Clarify when returned promise resolves

* Add element to handler

* Allow setting CSS class via loader

* Use render-counter on visualize

* Use Angular run method to get access to Private service

* Allow adding data-attributes to the vis element

* Refactor loader to return an EmbeddedVisualizeHandler instance

* Use this.destroy for previous API

* Remove fallback then method, due to bugs

* Reject promise from withId when id not found

* Add tests

* Change developer documentation

* Revert "Use Angular run method to get access to Private service"

This reverts commit 160e47d7709484c0478415436b3c2e8a8fc8aed3.

* Rename parameter for more clarity

* Add more documentation about appState

* Fix broken test utils

* Use chrome to get access to Angular

* Move loader to its own folder

* Use a method instead of getter for element

* Add listeners for renderComplete events

* Use typedef to document params

* Fix documentation
2017-12-05 12:56:19 +01:00
Court Ewing
fa3c2d5e83 Revert "Refactor and improve Visualize Loader (#15157) (#15359)"
This reverts commit bead35811f.

This backport was botched, so a bunch of inline diffs were committed.
2017-12-02 14:13:41 -05:00
Tim Roes
bead35811f
Refactor and improve Visualize Loader (#15157) (#15359)
* Simplify promise setup logic

* Import template from own file

* Use angular.element instead of jquery

* Add documentation for loader methods

* Add params.append

* Remove params.editorMode

* Clarify when returned promise resolves

* Add element to handler

* Allow setting CSS class via loader

* Use render-counter on visualize

* Use Angular run method to get access to Private service

* Allow adding data-attributes to the vis element

* Refactor loader to return an EmbeddedVisualizeHandler instance

* Use this.destroy for previous API

* Remove fallback then method, due to bugs

* Reject promise from withId when id not found

* Add tests

* Change developer documentation

* Revert "Use Angular run method to get access to Private service"

This reverts commit 160e47d7709484c0478415436b3c2e8a8fc8aed3.

* Rename parameter for more clarity

* Add more documentation about appState

* Fix broken test utils

* Use chrome to get access to Angular

* Move loader to its own folder

* Use a method instead of getter for element

* Add listeners for renderComplete events

* Use typedef to document params

* Fix documentation
2017-12-02 11:36:01 +01:00
Peter Pisljar
9c1f955a35 extending and updating documentation for visualize (#14441)
* extending and updating documentation for visualize

* updating based on review
2017-11-21 20:57:27 +01:00
Peter Pisljar
39b14bed02 adding documentation for visualization development (#14252)
* adding documentation for  visualization development
2017-11-21 20:54:54 +01:00