* Add comments support to the expressions grammar
* Add typings to the interpreter parser
* Add expressions comments highlighting
* Update canvas to preserve original expression formatting
* Update documentation to cover comments
* [WIP] Combine visualizations and visualize plugins
* Revert some changes and do some refactoring
* Refactor some code
* Fix some tests
* Fix functional tests and some jest test cases
* Update telemetry
* Fix get_visualization_instance.test and plugin-list.asciidoc
* Refactor some code
* fix CI
* Add visualizations to vis_default_editor tsconfig
* Revert changes related to telemetry and permissions
* Add dashboard to timeseries tsconfig.json
* Update limits file
* Update translation keys
* Add capabilitiesProvider back to server and replace visEditorsRegistry getter and setter with service
* Update mocks.ts
* Revert changes related to visEditorsRegistry
* Get rid of visEditorsRegistry getter and setter
* Remove dashboard from timeseries/tsconfig.json
* Return back dashboard dependency to timeseries/tsconfig.json, rename applicaion folder to visualize_app and APP_NAME to VISUALIZE_APP_NAME, revert types.ts
* Remove comma in .i18nrc.json
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
* gauge_expression
* fix
* CI fix
* make plugin required to use its methods
* move non-types from types
* share icon
* bundle, plugin
* load gaugeComponent async
* fix types
* async heatmap
* don't use d3
* optimizations
* feedback
* types
* adjusting the tests to the new max
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [WIP][Heatmap] Creates implementation with elastic-charts
* Fix types and connection with vislib
* Add coloring options
* Brush, click events, coloring etc
* Cleaning up the expression function
* Add legend picker, fix sorting and other fixes
* Further fixes
* Use the shared expression to Lens and cleanup
* PrepareLogTables for new expression function
* Use common renderer and expression function with lens
* Fix i18n
* Small tweaks
* Add unit tests
* Adds a unit test to the heatmap component
* update plugin list
* Fix types
* Fix types
* update limits
* Change to the expression function
* Cleanup translations
* Refactor to use vis
* Fix types
* further cleanup of the translations
* register new setting
* Fix sorting for histogram
* Adds functional tests for the new nisualize heatmap
* Cleanup
* Fix
* Apply PR comments
* Address PR comments
* Fix i18n
* Fix i18n
* Makes the <Heatmap /> id dynamic
* reverse
* fix translation file
* Apply design PR comments
* Fix package
* More fixes
* Fix brush problem
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Fix link to Cloud deployment URL in upgrade step. (#109528)
* [Upgrade Assistant] Refactor CITs
* Rename UA steps to fix_issues_step and fix_logs_step. (#109526)
* Rename tests accordingly.
* [Upgrade Assistant] Cleanup scss (#109524)
* [Upgrade Assistant] Update readme (#109502)
* Add "Back up data" step to UA (#109543)
* Add backup step with static content and link to Snapshot and Restore.
* Add snapshot_restore locator.
* Remove unnecessary describe block from Upgrade Step tests.
* Remove unused render_app.tsx.
* Change copy references of 'deprecation issues' to 'deprecation warnings'. (#109963)
* [Upgrade Assistant] Address design feedback for ES deprecations page (#109726)
* [Upgrade Assistant] Add checkpoint feature to Overview page (#109449)
* Add on-Cloud state to Upgrade Assistant 'Back up data' step (#109956)
* [Upgrade Assistant] Refactor external links to use locators (#110435)
* [Upgrade Assistant] Use AppContext for services instead of KibanaContext (#109801)
* Remove kibana context dependency in favour of app context
* Add missing type to ContextValue
* Fix mock type
* Refactor app mount flow and types
* Refactor to use useServices hook
* Fix linter issues
* Keep mount_management_section and initialize breadcrumbs and api there
* Remove useServices and usePlugins in favour of just useAppContext
* Remove unnecessary mocks
* [Upgrade Assistant] Enable functional and a11y tests (#109909)
* [Upgrade Assistant] Remove version from UA nav title (#110739)
* [Upgrade Assistant] New Kibana deprecations page (#110101)
* Use injected lib.handleEsError instead of importing it in Upgrade Assistant API route handlers. (#111067)
* Add tests for UA back up data step on Cloud (#111066)
* Update UA to consume snapshotsUrl as provided by the Cloud plugin. (#111239)
* Skip flaky UA Backup step polling test.
* [Upgrade Assistant] Refactor kibana deprecation service mocks (#111168)
* [Upgrade Assistant] Remove unnecessary EuiScreenReaderOnly from stat panels (#111518)
* Remove EuiScreenReaderOnly implementations
* Remove unused translations
* Remove extra string after merge conflict
* Use consistent 'issues' and 'critical' vs. 'warning' terminology in UA. (#111221)
* Refactor UA Overview to support step-completion (#111243)
* Refactor UA Overview to store step-completion state at the root and delegate step-completion logic to each step component.
* Add completion status to logs and issues steps
* [Upgrade Assistant] External links with checkpoint time-range applied (#111252)
* Bound query around last checkpoint date
* Fix tests
* Also test discover url contains search params
* Small refactor
* Keep state about lastCheckpoint in parent component
* Remove space
* Address CR changes
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Upgrade Assistant] Tests for updating step state accordingly if API poll receives count followed by error (#111701)
* Add test for logs count polling
* Test when count api fails
* [Upgrade Assistant] Add a11y tests for es deprecation flyouts (#110843)
* [Upgrade Assistant] Set fix_logs step as incomplete if log collection is not enabled (#111827)
* set step as incomplete if toggle is disabled
* Fix test names
* Remove unnecessary mocks
* [Upgrade Assistant] Update copy to use "issues" instead of "warnings" (#111817)
* Create common deprecation issues panel component in UA (#111231)
* Refine success state behavior and add tests.
* Refactor components into a components directory.
* Refactor SCSS to colocate styles with their components.
* Refactor tests to reduce boilerplate and clarify conditions under test.
* [Upgrade Assistant] Fix Kibana deprecations warning message
* [Upgrade Assistant] Add support for API keys when reindexing (#111451)
* [Upgrade Assistant] Update readme (#112154)
* [Upgrade Assistant] Make infra plugin optional (#111960)
* Make infra plugin optional
* Fix CR requests
* [Upgrade Assistant] Improve flyout information architecture (#111713)
* Make sure longstrings inside flyout body are text-wrap
* Show resolved badge for reindex flyout and row
* Finish off rest of ES deprecation flyouts
* Refactor deprecation badge into its own component
* Add tests for kibana deprecations
* Add tests for es deprecations
* Also check that we have status=error before rendering error callout
* Check for non-complete states instead of just error
* Small refactor
* Default deprecation is not resolvable
* Add a bit more spacing between title and badge
* Address CR changes
* Use EuiSpacer instead of flexitems
* [Upgrade Assistant] Update readme (#112195)
* [Upgrade Assistant] Add integration tests for Overview page (#111370)
* Add a11y tests for when overview page has toggle enabled
* Add functional and accessibility tests for overview page
* Load test files
* Fix linter error
* Navigate before asserting
* Steps have now completion state
* Remove duped word
* Run setup only once, not per test
* Address CR changes
* No need to renavigate to the page
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Upgrade Assistant] Add note about compatibility headers (#110469)
* Improve error states for Upgrade Assistant deprecation issues (#112457)
* Simplify error state for deprecation issues panels. Remove <EsStatsError />.
* Rename components from stats -> panel.
* Create common error-reporting component for use in both Kibana and ES deprecations pages.
* Align order of loading, error, and success states between these pages.
* Change references to 'deprecations' -> 'deprecation issues'.
* Fix tests for panels.
* Add API integration test for handling auth error.
* Fix TS errors.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Change count poll time to 15s (#112669)
* [Upgrade Assistant] Add permissions check to logs step (#112420)
* [Upgrade Assistant] Refactor telemetry (#112177)
* [Upgrade Assistant] Check for ML upgrade mode before enabling flyout actions (#112555)
* Add missing error handlers for deprecation logging route (#113109)
* [Upgrade Assistant] Batch reindex docs (#112960)
* [UA] Added batch reindexing docs link to the ES deprecations page. Added a link from "batch reindexing" docs page to "start or resume reindex" docs page and from there to ES reindexing docs page. Also renamed "reindexing operation" to "reindexing task" for consistency.
* [Upgrade Assistant] Added docs build files
* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
* Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
* [Upgrade Assistant] Added review suggestions and fixed eslint issues
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Upgrade Assistant] Improve error messages for GET /api/upgrade_assistant/reindex/<index> (#112961)
* Add support for single manual steps to Upgrade Assistant. (#113344)
* Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665)
This reverts commit 991d24bad2.
* [Upgrade Assistant] Use skipFetchFields when creating the indexPattern in order to avoid errors if index doesn't exist (#113821)
* Use skipFetchFields when creating the indexPatter in order to avoid errors when index doesnt exist
* Address CR feedback
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Upgrade Assistant] Hide system indices from es deprecations list (#113627)
* Refactor reindex routes into separate single and batch reindex files. Apply version precheck to batch routes. (#113822)
* [Upgrade Assistant] Remove ML/Watcher logic (#113224)
* Add show upgrade flag to url (#114243)
* [Upgrade Assistant] Delete deprecation log cache (#114113)
* [Upgrade Assistant] Add upgrade system indices section (#110593)
* [Upgrade Assistant] Reindexing progress (#114275)
* [Upgrade Assistant] Added reindexing progress in % to the reindex flyout and es deprecations table
* [Upgrade Assistant] Renamed first argument in `getReindexProgressLabel` to `reindexTaskPercComplete` for consistency
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Upgrade Assistant] Remove Fix manually heading when there are no manual steps
* Add rolling upgrade interstitials to UA (#112907)
* Refactor FixLogsStep to be explicit in which props are passed to DeprecationLoggingToggle.
* Centralize error-handling logic in the api service, instead of handling it within each individual API request. Covers:
- Cloud backup status
- ES deprecations
- Deprecation logging
- Remove index settings
- ML
- Reindexing
Also:
- Handle 426 error state and surface in UI.
- Move ResponseError type into common/types.
* Add note about intended use case of status API route.
* Add endpoint dedicated to surfacing the cluster upgrade state, and a client-side poll.
* Merge App and AppWithRouter components.
* [Upgrade Assistant] Added "accept changes" header to the warnings list in the reindex flyout (#114798)
* Refactor kibana deprecation tests (#114763)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Fix linter issues
* Remove unused translation
* Prefer master changes over 7.x for ml docs
* Prefer master changes over 7.x
* Skip tests
* Move everything to a single describe
* Fix types
* Add missing prop to mock
* [Upgrade Assistant] Removed "closed index" warning from reindex flyout (#114861)
* [Upgrade Assistant] Removed "closed index" warning that reindexing might take longer than usual, which is not the case
* [Upgrade Assistant] Also deleted i18n strings that are not needed anymore
* Add LevelIconTips to be more explicit about the difference between critical and warning issues. (#115121)
* Extract common DeprecationFlyoutLearnMoreLink component and change wording to 'Learn more'. (#115117)
* [Upgrade Assistant] Reindexing cancellation (#114636)
* [Upgrade Assistant] Updated the reindexing cancellation to look less like an error
* [Upgrade Assistant] Fixed an i18n issue and updated a jest snapshot
* [Upgrade Assistant] Updated cancelled reindexing state with a unified label and cross icon
* [Upgrade Assistant] Fixed snapshot test
* [Upgrade Assistant] Updated spacing to the reindex cancel button
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Fix test errors (#115183)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Upgrade Assistant] Overview page UI clean up (#115258)
- Scaling down deprecation issue panel title size to flow with typographic hierarchy.
- Removing panel around deprecation logging switch to reduce visual elements.
- Using success instead of green color for migration complete message.
* Revert "Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665)" (#114804)
This reverts commit c385d49887.
* Add migration to remove obsolete attributes from telemetry saved object.
* Refactor UA telemetry constants by extracting it from common/types.
* [Upgrade Assistant] Rename upgrade_status to migration_status (#114755)
* [Upgrade Assistant] Swapped reindexing flyouts order (#115046)
* [Upgrade Assistant] Changed reindexing steps order, replaced a warning callout with a text element
* [Upgrade Assistant] Fixed reindex flyout test and changed warning callout from danger color to warning color
* [Upgrade Assistant] Fixed the correct status to show warnings
* [Upgrade Assistant] Fixed i18n strings
* [Upgrade Assistant] Moved reindex with warnings logic into a function
* [Upgrade Assistant] Updated reindex flyout copy
* [Upgrade Assistant] Also added a trailing period to the reindex step 3
* [Upgrade Assistant] Fixed i18n strings and step 3 wording
* [Upgrade Assistant] Added docs changes
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Upgrade Assistant] Hide features that don't need to be migrated from flyout (#115535)
* Filter out system indices that dont require migration on server side
* Rename to attrs to migration
* Update flyout snapshot.
* Refine Upgrade Assistant copy. (#115472)
* Remove unused file
* Fix kibanaVersion dep
* Updated config.ts to fix UA test
UA functional API integration test to check cloud backup status creates a snapshot repo, which fails to be created with my changes to config.ts `'path.repo=/tmp/repo,/tmp/repo_1,/tmp/repo_2,'`. Adding `/tmp/cloud-snapshots/'` to the config fixes the test.
* Address CR changes
* Add missing error handler for system indices migration (#116088)
* Fix broken tests
* Fix test
* Skip tests
* Fix linter errors and import
* [Upgrade Assistant] Fix typo in retrieval of cluster settings (#116335)
* Fix typos
* Fix typo also in server tests
* Make sure log collection remains enabled throughout the test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Fix type errors
* Fix integration test types
* Fix accessibility test type errors
* Fix linter errors in shared_imports
* Fix functional test types
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Alison Goryachev <alison.goryachev@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: Dmitry Borodyansky <dborodyansky@gmail.com>
* [APM] Removes the apm_oss plugin and deprecates related configs (#108160)
* removes commented lines
* fixes typescript errors
* performs start up migration on the saved objects mapping for apm-indices
* removes all references to the deprecated apm_oss.* config paths in APM
* fixes missing bundle error
* fixes type error
* fixes eslint error with disabled rules
* fixes saved object mappings for es_archvices for tests
* fixes eslint error
* Updates default index values to include the more general apm-*. Fixes broken tests.
* removing unused configs from the config path migration: apm_oss.indexPattern and apm_oss.fleetMode
* - replaces full index configuration paths with references in the `xpack.apm.indices` namespace
- removes mergeConfig function and test
* fixes proxy mock object in unit test
* fixes linting issues
* PR feedback and failed test
* changes the configs at `xpack.apm.indices.*` from plural to singular to match `processor.event` values
While Elasticsearch ingest pipelines require a node with the `ingest`
role, we don't need to include `ingest node` in the feature name.
There are no official plans, but the Elasticsearch team has discussed removing
the `ingest` role in the future. This also better aligns the Kibana UI with the
Elasticsearch docs.
The PR also makes some related changes to the Kibana docs.
Relates to https://github.com/elastic/elasticsearch/pull/70253.
* initial pass at moving data views into own plugin
* require expressions plugin, fix META_FIELDS reference
* bundle limits and localization
* fix integration test
* update plugin list and jest config
* type fixes
* search fixes
* fix localization
* fix mocks
* fix mocks
* fix stub
* type fixes
* fix import on test file
* path fixes
* remove shorted dotted from data plugin
* more todo removal
* eslint fixes
* eslint fix
* simplify data views server plugin
* simplify data views server plugin
* simplify data views server plugin
* fix imports on api routes
* fix imports on api routes
* update plugin list
* ts fixes
* ts fixes
* add deprecation notice
* fix circular dependency and api integration test
* fix circular dependency and api integration test
* rename types for better clarity
* path fixes
* jest.config and tsconfig cleanup
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Add a new plugin `custom_integrations`. This plugin allows for the registration of data-integrations tutorials. The Fleet-integrations app will display these alongside the existing Elastic Agent integrations.
* Remove timelion app and stuff which related to it
* Fix CI
* Fix lint
* Fix tests
* Fix tests
* Fis tests
* Fix some comments
* Clean up
* fix CI
* fix some comments
* Fix deprecation examples
* Return `enabled` property in config for timelion vis
* Remove unused angular lib
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
* Move legacy dashboards API to core and adds usage data
* More legacy_export plugin removal
* Log a warning for deprecated dashboard import/export API
* Review comments
* Move to vis_types folder part 2
* fix jest tests
* do some tests
* revert
* Test Tiago's fix
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Destructure index API request bodies consistently.
* Remove unnecessary calls to encodeURIComponent on the server.
* Migrate routes to handleEsError. Delete wrapEsError helpers. Remove unused isEsError and parseEsError dependencies. Remove isEsError from es_ui_shared.
* Update tests and migrate API integration tests.
* Clarify test details in CCR README. Update Index Management README with steps for testing Cloud-managed index templates and steps for testing indices and data streams that contain special characters.
* expression_reveal_image skeleton.
* expression_functions added.
* expression_renderers added.
* Backup of daily work.
* Fixed errors.
* Added legacy support. Added button for legacy.
* Added storybook.
* Removed revealImage from canvas.
* Types fixed.
* Fixed test suite error.
* Fixed eslint error.
* Moved UI and elements, related to expressionRevealImage from canvas.
* Fixed unused translations errors.
* Moved type of element to types.
* Fixed types and added service for representing elements, ui and supported renderers to canvas.
* Added expression registration to canvas.
* Fixed
* Fixed mutiple call of the function.
* Removed support of a legacy lib for revealImage chart.
* Removed legacy presentation_utils plugin import.
* Removed useless translations and tried to fix error.
* One more fix.
* Small imports fix.
* Fixed translations.
* Made fixes based on nits.
* Removed useless params.
* fix.
* Fixed errors, related to jest and __mocks__.
* Removed useless type definition.
* Replaced RendererHandlers with IInterpreterRendererHandlers.
* fixed supported_shareable.
* Moved elements back to canvas.
* Moved views to canvas, removed expression service and imported renderer to canvas.
* Fixed translations.
* Moved libs to presentation utils.
* Fixed types and removed function_wrapper.ts
* Fixed types of test helpers.
* Fixed imports.
* One more fix.
* Fixed public API.
* Moved css to component.
* Fixed spaces at element.
* Removed unused plugin.
* Basic setup of error plugin.
* Removed not used `function` files at `error` expression.
* Moved related components from canvas.
* Changed imports of components.
* Removed useless translations and fixed .i18nrc.json
* More fixes of i18nrc.
* Fixed async functions.
Written current code, based on https://github.com/storybookjs/storybook/issues/7745
* Fixed one test with Expression input.
After changing the way of rendering in stories, all elements are mounting and componentDidMount is involved. The previous snapshot was without
mounted `monaco` editor.
* generated plugin and copied code from expression_reveal_image
* fixed double import after merge.
* Changed all names from reveal_image to shape.
* moved shape to plugin and added all necessary configs
* Fixed translations, fixed all imports and debug of svg.
* `function` moved to `server`.
* One shape is rewritten to `React` and rendering is written with passing necessary props.
* changed default width and heigth.
* Added `ShapeHOC`.
* Shapes changed.
* small refactor.
* Removed useless import.
* one more refactor.
* Refactor + fix errors + updated limits.
* Changed ShapePreview from pure js to react and removed `dangerouslySetInnerHTML`
* Fixed types of viewbox.
* Changed types source for Shape components.
* small refactor.
* Fixed imports.
* Removed `shape` from `canvas`
* Updated docs.
* Basic setup of error plugin.
* Removed not used `function` files at `error` expression.
* Changed imports of components.
* Fixed errors, related to shape and autosuggestions.
* Fixed i18n for shape.
* Moved function from public to common and registered at server.
* Fixed types error.
* Fixed snapshots and shape mocks.
* Moved some libs from `presentations_util` to `expression_shape`
* Shape refactored.
* Shape picker fixed.
* Moved `Popover` back to `canvas`
* Removed `Popover` export from presentation_utils components.
* Moved error_component and debug_component from presentation_util to expression_error.
* Removed `.i18nrc.json`.
* Removed `.i18nrc.json`.
* Removed useless scss.
* Fixed color of `error`.
* added fixes of rebase.
* More fixes of rebase error .
* Removed useless .i18nrc.json file.
* More fixes.
* More fixes of rebase.
* One more fix.
* More fixes.
* Fixed limits and translations.
* Added.
* Fixed i18nrc.
* Fixed error..
* Moved shapes to async chunks.
* One more fix.
* Some fixes.
* Trying to fix the typecheck error.
* Added temp of drawer.
* Moved shapes to the async chunk in a less complex way.
* Made `ShapeDrawer` reusable among different `expressions`.
* Changed type of `shapes` from `any` and `Shape` to `string`.
* Made changes, based on nits.
* Removed not necessary changes.
* Moved all reusable libs to `expression_shapes`.
* Reduced the size of the bundle.
* Hope, fixed type check errors.
* Removed getDefaultShapeData.
* Removed `getViewBox` from bundle.