Commit graph

227 commits

Author SHA1 Message Date
Peter Pisljar
7503fd256a
support serializing nested searchsource (#91525) 2021-02-18 15:12:41 +01:00
Liza Katz
98bd8e0211
Report telemetry for autocomplete (#91428)
* Report telemetry about autocomplete
* error cound
* position of selected suggestion
* length of query used to generate the suggestions

Also added a couple if handly telemetry events:
* query language switch
* filter bar bulk actions

* Fix ts

* Report the value suggestions funnel

* docs

* docs

* fix jest

* test

* code review

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-17 14:41:15 +02:00
Matthew Kime
5f500a3c69
Improved painless error toasts (#91346)
* better painless error modal
2021-02-16 10:47:30 -06:00
Lukas Olson
f06e722a99
[Search Sessions] Search session UI telemetry (#89950)
Co-authored-by: Liza K <liza.katz@elastic.co>
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
2021-02-16 11:28:13 +01:00
Devon Thomson
7994e87cd7
[Time to Visualize] Clear All Editor State when Visualize Listing Page Loads (#91005)
* Changed the embeddable state transfer service so that it is possible to clear all editor state at once. Used that method in the visualize listing page
2021-02-11 23:23:14 -05:00
Anton Dosov
9ab5bcb141
[Search Session] Control "Kibana / Search Sessions" management section by privileges (#90818) 2021-02-11 04:33:32 -05:00
Devon Thomson
31a3ec5934
[Time To Visualize] Make State Transfer App Specific (#89804)
* made state transfer app specific
2021-02-08 15:31:09 -05:00
Steph Milovic
fc516bacbd
[index patterns] Add pattern validation method to index patterns fetcher (#90170) 2021-02-05 14:13:51 -07:00
Anton Dosov
84a67a44d1
fix adding Visualize visualization to dashboard from modal directs user to dashboard listing page (#90090) 2021-02-03 17:48:07 +01:00
Lukas Olson
a9273ca001
[data.search] Add search session methods to search service contract (#87966)
* [data.search] Add search session methods to search service contract

* Fix types

* Fix tests and switch to cancel

* Update docs

* Fix types/tests

* Fix tests

* Update status of SO before cancelling search requests

* Add API integration test

* Fix types

* Update expiration route to use config defaultExpiration

* Fix test

* Update docs

* New logic for extend

* Remove declare module

* Review feedback

* fix ts

* Remove test that is no longer valid

* Fix undefined bug

* Use DataRequestHandlerContext in maps

* ts

Co-authored-by: Liza K <liza.katz@elastic.co>
2021-02-03 08:08:54 -07:00
Peter Pisljar
8f70c52180
cleaning up tabify to return Datatable (#89857) 2021-02-03 11:47:24 +01:00
Tim Sullivan
ad67ee551e
[SearchSource] Combine sort and parent fields when serializing (#89808)
* [SearchSource] Combine sort and parent fields when serializing

* fix docs

* add link to issue
;

* fix destructive recursion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-02 10:15:13 -07:00
Lukas Olson
29e3886bcd
[data.search] Allow search response to follow new hits format (#88115)
* [data.search] Allow search response to follow new hits format

* Update docs

* Fix types

* Fix types

* Doc updates

* Remove declare module

* Remove declare module

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 17:06:32 -07:00
Liza Katz
841ab704b8
[Search Sessions] Improve search session errors (#88613)
* Detect ESError correctly
Fix bfetch error (was recognized as unknown error)
Make sure handleSearchError always returns an error object.

* fix tests and improve types

* type

* normalize search error response format for search and bsearch

* type

* Added es search exception examples

* Normalize and validate errors thrown from oss es_search_strategy
Validate abort

* Added tests for search service error handling

* Update msearch tests to test for errors

* Moved bsearch route to routes folder
Adjusted bsearch response format
Added verification of error's root cause

* Align painless error object

* eslint

* Add to seach interceptor tests

* add json to tsconfig

* docs

* updated xpack search strategy tests

* oops

* license header

* Add test for xpack painless error format

* doc

* Fix bsearch test potential flakiness

* code review

* fix

* code review 2

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-31 12:16:46 +02:00
Lukas Olson
d7b1cbbed5
[data.search.searchSource] Add fetch$ observable for partial results (#89211)
* [data.search.searchSource] Add fetch$ observable for partial results

* Fix mocks & add tests

* Update docs

* Update docs

* Review feedback
2021-01-29 10:01:35 -07:00
Anton Dosov
07b210e42d
[Search Sessions] Improve session restoration back button (#87635) 2021-01-28 09:54:26 +01:00
Anton Dosov
b8947e3e15
[Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (#88699) 2021-01-27 11:52:13 +01:00
Tiago Costa
8250b078b4
chore(NA): improve ts build refs performance on kbn bootstrap (#89333)
* chore(NA): improve ts build refs performance on kbn bootstrap

* chore(NA): use skipLibCheck=false by default on typechecking

* docs(NA): commit core docs changes

* fix(NA): eui typings
2021-01-27 00:59:24 +00:00
Peter Pisljar
d81ab83c16
[examples] expressions explorer (#88344) 2021-01-22 19:52:47 +01:00
Matthew Kime
ae0bd2fbba
Add runtime fields to index patterns and searchsource (#88542)
* Add runtime fields to index patterns and searchsource
2021-01-21 14:10:19 -06:00
Mikhail Shustov
b3a9754394
[Core] Explicit typings for request handler context (#88718)
* move context to server part. couple with RequestHandlerContext

Context implementation will be simplified in follow-up.

* adopt core code

* adopt bfetch code

* adopt data code

* adopt search examples

* adopt vis_type_timelion

* adopt vis_type_timeseries

* adopt plugin functional tests

* adopt actions

* adopt alerting plugin

* adopt APM plugin

* adopt beats_management

* adopt case plugin

* adopt cross_cluster_replication

* adopt data_enhanced

* adopt event_log

* adopt global_search

* adopt index_management

* adopt infra

* adopt licensing

* adopt lists

* adopt logstash

* adopt reporting

* adopt observability

* adopt monitoring

* adopt rollup

* adopt so tagging

* adopt security

* adopt security_solutions

* adopt watcher

* adopt uptime

* adopt spaces

* adopt snapshot_restore

* adopt features changes

* mute error when null used to extend context

* update docs

* small cleanup

* add type safety for return type

* refactor registerRouteHandlerContext type

* update docs

* update license header

* update docs

* fix type error. fetch body does not accept array of strings

* fix telemetry test

* remove unnecessary ts-ignore

* address comments

* update docs
2021-01-21 15:20:22 +01:00
Joe Portner
25f16db4d9
Sharing saved objects, phase 2 (#80945) 2021-01-20 17:39:21 -05:00
Matthew Kime
1edc799894
[index patterns] improve developer docs (#86416)
* add index pattern docs
2021-01-20 14:21:38 -06:00
Marco Liberati
86789dabb5
[Lens] Add more in-editor Advanced documentation (#86821)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
2021-01-20 17:49:21 +01:00
Mikhail Shustov
6e4c70848d
[Core] Remove public context (#88448)
* remove client side context

* update docs

* fix tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-18 21:47:53 +01:00
Stratoula Kalafateli
633495ef43
[XY axis] Implement new palette service (#86876)
* [XY Axis] New Palette service

* Calculate all Series to map the colors correctly

* remove commented out code

* syncColors on XY plugin

* Reset to false when no embeddable

* Add unit test for getAllSeries function

* Measure the usage of the selected palette

* Minor adjustments

* Update documentation for isSyncColorsEnabled method

* Fix bug on changing palette on charts with no split series

* Fix coloring for multiple y axis visualizations

* Call getPalettes function from the renderer

* Fullwidth palette picker

* Fetch palette registry on the component and not on the renderer

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-13 15:56:28 +02:00
Anton Dosov
d3303f28bb
[Search] Search Sessions with relative time range (#84405) 2021-01-12 14:51:04 +01:00
Liza Katz
91aed6f961
[Search][Sessions] Rename Background Sessions to Search Sessions (#87500)
* Rename Background Sessions to Search Sessions (with a send to background action)

* doc

* doc

* jest fun

* rename rfc

* translations

* update so name in features

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-07 17:28:27 +02:00
Pierre Gayvallet
f59711945d
Expose SO import/export APIs from the service's contract instead of exporting static functions (#86264)
* Add user doc for SO tagging

* add link to new page

* handle review feedbacks

* second pass

* create SO exporter class

* adapt spaces code

* typo fix

* adapt tests

* some doc

* update generated doc

* fix spaces tests

* move ALL the import things

* adapt / move types

* create context, adapt core code

* adapt integration tests

* rename for consistency

* adapt spaces usages

* adapt spaces routes usages

* remove unused getImportExportObjectLimit

* fix tsdoc

* update generated doc

* doc nits

* review comments

* add test for fetchByObjects failure

* add custom errors for exporter

* remove `getImportExportObjectLimit` API

* fix IT

* update generated doc

* adapt UT

* forgot one Boom usage

* rename import error to failure

* remove Boom usages from importer

* update generated doc

* fix spaces types
2021-01-07 11:23:28 +01:00
Lukas Olson
a2b4517b9e
[data.search.session] Add extend functionality to server-side search service (#86195)
* [data.search.session] Store search strategy in saved object

* [data.search.session] Add extend functionality

* Update docs

* Update unit test to check strategy

* Throw kbnServerError instead of error

* Fix test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 08:26:06 -07:00
Josh Dover
0af81310b6
Remove dynamic mapped types from UiActions (#87075)
* Remove dynamic mapped types from UiActions

* Remove import between data <-> embeddables

* remove outdated comments, export action types from discover_enhanced

* fix notice.txt

Co-authored-by: restrry <restrry@gmail.com>
2021-01-05 10:11:05 +01:00
Devon Thomson
1d856c39b5
Fix Add From Library Flyout Staying Open (#86698)
* Fixed add from library flyout staying open after save or cancel
2020-12-22 11:41:35 -05:00
Joe Reuter
57a72a78f7
[Lens] Configurable color syncing (#86180) 2020-12-22 17:35:27 +01:00
Matthew Kime
c129f93083
[index patterns] Fleep app - Keep saved object field list until field caps provides fields (#85370) 2020-12-19 21:56:06 -06:00
Luke Elmers
9a3e2910a3
App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (#82791)
* Move applyFilter, selectRange, valueClick triggers to data/embeddables.

* Update imports.

* Remove embeddable references to non-existent data plugin dependency.

* remove data mocks from embeddable

* Remove query, filters, timeRange from EmbeddableInput and move to apps.

* Remove data plugin imports from embeddable test samples.

* Remove circular dependencies caused by expressions renderer handlers.

* Update circular deps allowList.

* Remove data dependency on embeddable.

* Revert accidental data plugin change.

* Fix new circular deps issues.

* Update generated docs.

* Fix type errors in vis_type_xy

* Fix inspector data table.
2020-12-18 18:34:07 -07:00
Devon Thomson
8ce9b474d6
[Time to Visualize] Fix Dashboard OnAppLeave (#86193)
Added isTransferInProgress to embeddable_state_transfer for apps to determine whether or not to show onAppLeave confirm
2020-12-18 15:07:36 -05:00
Peter Pisljar
b93034b72c
inspector table adapter cleanup (#84232) 2020-12-17 12:14:07 +01:00
Devon Thomson
ee37f6dd91
[Time to Visualize] Transition Embeddable State Transfer to Session Storage (#85688)
* Transitioned embeddable state transfer service to use sessionStorage
2020-12-15 13:18:36 -05:00
Daniil
845f716271
[Data table] Reactify & EUIficate the visualization (#70801)
* Use data grid for table vis

* Create basic table template

* Add table_vis_split component

* Apply cell filtering

* Add aria-label attributes

* Use field formatters for values

* Add no results component

* Remove legacy dependencies

* Add usePagination

* Create usePagination util

* Use percentage column and total row

* Use csv export button

* Update labels

* Fix merge conflicts

* Use split table

* Fix functional tests

* Fix dashboard tests

* Update data table functional tests

* Fix missed test

* Introduce showToolbar option

* Remove useless package

* Fix merge conflicts

* Return back kibanaUtils required bundle

* Revert "Remove useless package"

This reverts commit 144a7cd77c.

* Use feature flag for legacy vis

* Add footer row

* Remove lock files

* Revert "Remove lock files"

This reverts commit 5c5acd79f4.

* Minor fixes

* Use common no result message

* Fix broken tests

* Use ui state sorting

* Fix error

* Fix merge conflicts

* Add legacy functional tests

* Pull pagination footer up to keep with table

and fix column split growing continuously in dashboard

* Comments fixes

* Use cell actions for filtering

* Fix translations

* Fix comments

* Reduce legacy tests amount

* Update sorting

* Update split column layout

* Add telemetry for legacy vis

* Apply latest changes for split table

* Fix eslint errors

* Use aria labels with values

* Use aria label for export btn

* Fix functional test

* Update translations

* Cleanup

* Truncate cells content

* Enhance types in table_vis_response_handler.ts

* Persist columns width on change

* Fix sorting history

* Add a migration script for toolbar

* Export sorted table

* Use reportUiCounter instead of reportUiStats

* Fix integration tests

* Fix typos

* Adjust FieldFormat type

* Hide the density selector

* Update docs

* Fix pagination

* Restrict hiding the toolbar

* Fix column index on filter

* Add closePopover action

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 14:44:20 +03:00
Vadim Dalecky
b01a327076
Row trigger 2 (#83167)
* feat: 🎸 add ROW_CLICK_TRIGGER

* feat: 🎸 wire row click event to UI Actions trigger in Lens

* feat: 🎸 add row click trigger to url drilldown

* feat: 🎸 add datatable to row click context

* feat: 🎸 pass in row index in row click trigger context

* feat: 🎸 add columns to row click trigger context

* feat: 🎸 fill values and keys event scope array

* feat: 🎸 generate correct row scope variables

* fix: 🐛 report triggers from lens embeddable

* feat: 🎸 add sample preview for row click trigger

* feat: 🎸 remove url drilldown preview box

* chore: 🤖 remove mock variable generation functions

* feat: 🎸 generate context and global variable lists

* feat: 🎸 preview event variable list

* feat: 🎸 show empty url error on blur

* feat: 🎸 add ability to always show popup for executed actions

* refactor: 💡 rename multiple action execution method

* fix: 🐛 don't add separator befor group on no main items

* feat: 🎸 wire in uiActions service into datatable renderer

* feat: 🎸 check each row if it has compatible row click actions

* feat: 🎸 allow passing data to expression renderer

* feat: 🎸 add isEmbeddable helper

* feat: 🎸 pass embeddable to lens table renderer

* feat: 🎸 hide lens table row actions which are empty

* feat: 🎸 re-render lens embeddable when dynamic actions chagne

* feat: 🎸 hide actions column if there are no row actions

* feat: 🎸 re-render lens embeddable on view mode chagne

* fix: 🐛 fix TypeScript errors

* chore: 🤖 fix TypeScript errors

* docs: ✏️ update auto-generated docs

* feat: 🎸 add hasCompatibleActions to expression layer

* feat: 🎸 remove "data" from expression renderer handlers

* fix: 🐛 fix TypeScript errors

* test: 💍 fix Jest tests

* docs: ✏️ update autogenerated docs

* fix: 🐛 wrap event payload into data

* test: 💍 add "alwaysShowPopup" test

* chore: 🤖 add comment requested in review

https://github.com/elastic/kibana/pull/83167#discussion_r537340216

* test: 💍 add hasCompatibleActions test

* test: 💍 add datatable renderer test

* test: 💍 add Lens embeddable input change tests

* test: 💍 add embeddable row click test

* fix: 🐛 add url validation

* test: 💍 add url drilldown tests

* docs: ✏️ remove url drilldown preview from docs

* docs: ✏️ remove preview from url templating

* docs: ✏️ add row click description

* chore: 🤖 move 36.5 KB bundle balance to url_drilldown

* test: 💍 simplify test case

* style: 💄 change types places

* refactor: 💡 clean up panel variable generation

* test: 💍 add getPanelVariables() tests

* fix: 🐛 generate runtime variables correctly

* fix: 🐛 improve getVariableList() and add tests for it

* feat: 🎸 add translation, improve types
2020-12-14 13:28:23 +01:00
Pierre Gayvallet
a4caffae2f
Improve and cleanup chrome helpMenu links (#82300)
* Improve and cleanup chrome helpMenu links

* update doc due to merge

* remove dev dependencies from test plugin

* update generated doc after merge

* update generated doc

* generated doc

* generated doc
2020-12-11 11:38:25 +01:00
Luke Elmers
3b5ed46c9d
[data.search] Clean up arguments to esaggs. (#84973) 2020-12-10 07:40:50 -07:00
Anton Dosov
cb29438b0d
[Search] Fix dashboard embeddables don't refetch on searchSessionId change (#84261) 2020-12-10 14:21:35 +01:00
Vadim Dalecky
9bef95a6fb
HTTP CRUD+ API for Index Patterns (#83576)
* refactor: 💡 extract out createIndexPatternsService() method

* feat: 🎸 add create index pattern route

* feat: 🎸 add index patterns http context

* feat: 🎸 add schema for index pattern create method

* refactor: 💡 compose schema out of variables

* feat: 🎸 allow to not make the new index pattern a default one

* feat: 🎸 implement index pattern create endpoint

* docs: ✏️ add index pattern create endpoint docs

* fix: 🐛 add error handling wrapper

* feat: 🎸 add index pattern GET route

* docs: ✏️ add index pattern GET mention to docs

* feat: 🎸 add higher order route handler to check for context

* feat: 🎸 add index pattern deletion endpoint

* docs: ✏️ add delete endpoint docs entry

* feat: 🎸 add index pattern update route

* feat: 🎸 add ability to update timeFieldName

* feat: 🎸 add ability to edit intervalName, sourceFilters, fields

* feat: 🎸 allow updating index pattern type and typeMeta

* feat: 🎸 add ability to update index_pattern fields

* docs: ✏️ add index pattern update endpoint docs

* docs: ✏️ fix typo

* feat: 🎸 disable XSRF and add Content-Type

* fix: 🐛 enable xsrf

* feat: 🎸 send 404 status code when index pattern is not found

* fix: 🐛 correctly report empty change set error

* feat: 🎸 fields API add route for adding field to IP

* docs: ✏️ add index pattern field create route

* fix: 🐛 throw on creating an existing index pattern field

* feat: 🎸 add field upsert route

* feat: 🎸 add field get api endpoint

* feat: 🎸 add field delete endpoint

* refactor: 💡 improve 404 error handling

* refactor: 💡 improve index pattern 404 error class

* feat: 🎸 add field update api endpoint

* docs: ✏️ typo

* refactor: 💡 rename ski_field_refresh to refresh_fields in creat

* refactor: 💡 rename to refresh_fields param in update call

* refactor: 💡 rename parameter to refresh_fields in fields api

* feat: 🎸 allow creating and deleting only scripted fields

* style: 💄 fix TypeScript/Prettier error

* test: 💍 add index pattern creation negative tests

* test: 💍 add index pattern create method tests

* feat: 🎸 remove make_default flag

* docs: ✏️ update docs

* test: 💍 add index patter api get tests

* test: 💍 add delete index pattern tests

* fix: 🐛 fix TypeScript error after refactor

* docs: ✏️ update autogenerated docs

* docs: ✏️ update autogenerated docs

* refactor: 💡 change Fields API to Scripted Fields API

* feat: 🎸 allow only scripted fields in Scripted Fields API

* test: 💍 add index patter api update tests

* test: 💍 add scripted field create api tests

* test: 💍 add scripted field delete api tests

* test: 💍 add scripted fields fetch api tests

* test: 💍 add scripted field field put api tests

* test: 💍 add scripted field update api test

* feat: 🎸 add index pattern field update endpoint

* feat: 🎸 improve index patterns fields api

* test: 💍 fix test

* docs: ✏️ update docs README

* test: 💍 add field metadata deletion teests

* docs: ✏️ improve index pattern api readme

* fix: 🐛 fix TypeScript errors

* test: 💍 update jest tests

* docs: ✏️ update auto-generated docs

* feat: 🎸 remove intervalName from index pattern create API

* test: 💍 fix integration tests

* fix: 🐛 make refresh_fields default to false

* chore: 🤖 remove searchable and aggregatable from public API

* chore: 🤖 remove various field properties

* chore: 🤖 remove "index" attribute from public field schema

* docs: ✏️ update docs to match API

* chore: 🤖 fix TypeScript errors

* test: 💍 try fixing functional tests

* docs: ✏️ update auto-generated docs

* chore: 🤖 check if this fixes security tests

* fix: 🐛 create index patterns context only if user is authc

* fix: 🐛 assert on index patterns service

* test: 💍 try fixing integration tests

* fix: 🐛 try fixing integration tests

* chore: 🤖 update auto-generated docs

* refactor: 💡 directly inject index pattern provider into create

* refactor: 💡 create index pattern service directly in each route

* refactor: 💡 remove index pattern route context provider

* chore: 🤖 remove unused code

* chore: 🤖 remove refresh_fields from scripted fields

* style: 💄 change template param names

* refactor: 💡 make field.count always be an integer

* docs: ✏️ update auto-generated docs

* refactor: 💡 inject index patterns using getStartServices

* docs: ✏️ update autogenerated docs

* docs: ✏️ update docs
2020-12-08 10:33:18 +01:00
Lukas Olson
e48e7446c0
[data.search] Move background session service to data enhanced plugin (#84837)
* [data.search] Move search method inside session service and add tests

* Move background session service to data_enhanced plugin

* Fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-07 08:51:19 -07:00
Matthew Kime
2c7a85dd38
Query string input - load index patterns instead of saved objects (#84457)
* load index patterns instead of saved objects
* remove getFromSavedObject
* add test
2020-12-06 11:24:11 -06:00
Luke Elmers
d2fc976b09
[data.search][data.indexPatterns] Expose esaggs + indexPatternLoad on the server. (#84590) 2020-12-03 08:28:50 -07:00
Luke Elmers
7393c230a4
[data.search.searchSource] Update SearchSource to use Fields API. (#82383) 2020-12-03 08:09:23 -07:00
Marco Liberati
17d986e499
[Embeddable] Export CSV action for Lens embeddables in dashboard (#83654)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-03 10:46:51 +01:00
Anton Dosov
4cb44d9e33
[Search] Integrate "Send to background" UI with session service (#83073) 2020-12-01 14:01:46 +01:00