Commit graph

30 commits

Author SHA1 Message Date
Oliver Gupte
f9b629fc9c
[APM] Fix anomalies not showing up on transaction charts (#76930) (#79253)
* [APM] Fix anomalies not showing up on transaction charts

* Added API tests to check transaction groups charts for anomaly data

* Improve test names and assertions from PR feedback

* Updated the transaction groups chart API to make `environment` a
required param while making `uiFilters` optional

* updates the basic API tests for transaction_groups/charts with the
required `environment` param

* makes uiFIltersES default to [] on core setup and removes SetupUIFilters type

* fixes vertical shade

* - replaces uiFiltersES with esFilter & uiFilters and cleans up related code around these
- deduplicates the required environment in the transaction_groups/charts API

* updates basic apm_api_integration tests

* pr feedback

* updates api test snapshots with correct anomaly data

* removed environment query param from useTransactionCharts and ensures
it's included in uiFilters returned from useUrlParams

Co-authored-by: Oliver Gupte <olivergupte@gmail.com>
# Conflicts:
#	x-pack/plugins/apm/public/utils/testHelpers.tsx
#	x-pack/plugins/apm/server/lib/rum_client/get_long_task_metrics.ts

Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
2020-10-02 15:54:37 -07:00
Dario Gieselaar
d8a0688e52
[7.x] [APM] Service inventory redesign (#76744) (#77353)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-15 10:32:46 +02:00
James Gowdy
18e40c024a
[ML] Switching to new es client (#74965) (#76501)
* [ML] Switching to new es client

* further conversions

* fixing tests

* updating responses

* test commit

* refactoring shared services to removed context parameter

* removing last scoped clients

* removing ml js client

* udating file data viz errors

* fixing jest tests

* fixing types after merge with master

* error response changes

* adding default sizes to some requests

* adding custom error types for license checks

* tidying up shared function checks

* removing test data

* removing need for DummyKibanaRequest

* updating comment

* fixing functional api tests

* removing comments

* fixing types after master merge

* throw error rather than return it

* removing placeholder error

* changes based on review comments

* fixing types after merge with master

* fixing missing return

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-02 16:36:06 +01:00
Oliver Gupte
5a08b86087
[7.x] [APM] Transaction duration anomaly alerting integration (#75719) (#76224)
* [APM] Transaction duration anomaly alerting integration (#75719)

* Closes #72636. Adds alerting integration for APM transaction duration anomalies.

* Code review feedback

* Display alert summary with the selected anomaly severity label instead of the anomaly score.

* - refactored ALL_OPTION and NOT_DEFINED_OPTION to be shared from common/environment_filter_values
- utilize getEnvironmentLabel in the alerting trigger components and added support for the 'All' label

* refactor get_all_environments to minimize exports and be more consistent and clean

* - Reorg the alerts menu for different alert types (threshold/anomaly)
- default environment alert settings to the selected filter

* - Filters default transaction type to only those supported in the APM anomaly detection jobs
- Removes Service name and transaction type from the set of expressions in the alerting setup

* - remove bell icon from alerts menu

* Adds target service back into the anomaly alert setup as a ready-only expression

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Fixes prettier linting

* Fixes prettier linting again

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-28 14:43:15 -07:00
Kibana Machine
be46a29471
[APM] Use apmEventClient for querying APM event indices (#73449) (#73931)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-31 17:02:47 +02:00
James Gowdy
50ca27f306
[ML] Changing all calls to ML endpoints to use internal user (#70487) (#71667)
* [ML] Changing all calls to ML endpoints to use internal user

* updating alerting

* updating documentation

* [ML] Changing all calls to ML endpoints to use internal user

* updating alerting

* updating documentation

* fixing missed types

* adding authorization headers to endpoint calls

* correcting has privileges call

* updating security tests

* odd eslint error

* adding auth header to module setup

* fixing missing auth argument

* fixing delete DFA job permission checks

* removing debug test tag

* removing additional ml privilege checks

* adding authorization header to _evaluate

* updating alerting cluster client name

* code clean up

* changing authorizationHeader name

* updating alterting documentation

* fixing secondary credentials

* adding management links

* updating SIEM telemetry

* fixing merge conflicts

* granting access to index patterns

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-14 17:49:54 +01:00
Søren Louv-Jansen
607ee02f9a
[APM] Adds 'Anomaly detection' settings page to create ML jobs per environment (#70560) (#70945) 2020-07-07 19:56:28 +02:00
Dario Gieselaar
accfd2f0bb
[7.x] [APM] Don't fetch index pattern in setupRequest (#70308) (#70591)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-02 20:52:40 +02:00
James Gowdy
4acd7001fa
[ML] Adding capabilities checks to shared functions (#70069) (#70479)
* [ML] Adding capabilities checks to shared functions

* small refactor

* disabling capabilities checks for functions called by SIEM alerting

* testing git

* removing comment

* using constant for ml app id

* tiny type clean up

* removing check in ml_capabilities

* fixing types

* removing capabilities checks from ml_capabilities endpoint

* updating types

* better error handling

* improving capabilities check

* adding custom errors

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-01 22:04:58 +01:00
Oliver Gupte
8d212eafe6
[APM] Service maps - Fix missing ML status for services with jobs but no anomalies (#68486) (#68734)
* Closes #68485 by:
  - use the ML plugin to query for all APM jobs
  - inspect the ml job groups to find all jobs related to a particular service
  - use the mlAnomalySearch client to get ml job buckets with the max anomaly score
  - query for the model_plot buckets to obtain actual/median values for the ML description
  - return the relevant ML job with the max anomaly score for a service
  - indicate to the user that no anomalies were found for a service with an ml job

* - Use the anomalyDetectorsProvider jobs API rather than the search endpoint directly
- Defines a specific return type for the ml jobs api
- Update the empty anomaly data message

* Code and types cleanup

* Return to using record result type on anomaly queries. These are the
same values used in the anomaly explorer and it includes actual &
typical values which greatly improve performance of the previous query.

* - If anomaly data is missing show a gray border around node

* - moved AnomalyDetection out of service map Contents into own component

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-09 23:22:10 -07:00
restrry
2fefd60e90 update code style 2020-05-22 10:35:02 +02:00
Dario Gieselaar
99f4ce5b81
[7.x] [APM] Optimize service map query (#60412) (#60599)
* [APM] Optimize service map query

Closes #60411.

- Chunk trace lookup
- Remove pagination, move dedupe logic to server

* Fix imports

* Fix imports again

Co-authored-by: Nathan L Smith <smith@nlsmith.com>

Co-authored-by: Nathan L Smith <smith@nlsmith.com>
2020-03-19 20:29:28 +01:00
Oliver Gupte
10386fe94f
[APM] NP Migration - Moves plugin server files out of legacy (#57532) (#58074)
* Closes @56832 Migrates uses of the saved objects client to the internal
and context scoped clients exposed in the new platform core setup

* moves apm server, common, and typings dirs to the new plugin directory

* fixes path imports and type errors

* fixes some lint errors

* fixes CI failure. Use internal saved objects client like before.

* uses the context-scoped saved objects client for saving runtime APM indices,
and uses the internal saved objects client when creating apm index
pattern, so that any user who navigates to apm can trigger it

* fixes the type check error by updating import paths

* renamed files and directories to snake_case to pass scripts/check_file_casing

* rebase fixes and commit filename case changes

* moves get_indices_privileges.ts out of legacy path
2020-02-19 21:40:45 -08:00
Court Ewing
dbb0534c21 Move x-pack plugins/server/common to x-pack/legacy 2019-06-20 13:35:00 -04:00
Søren Louv-Jansen
37d21cfb50
[APM] Refactor ESClient to allow other operations than search (#37334) (#37502) 2019-05-31 01:12:26 +02:00
Oliver Gupte
70dc222620
[APM] Add global service environment filter (#35778) (#36826)
* [APM] Adds global service environment filter to all applicable pages and APIs via uiFilters pattern.

* [APM] addressed some PR feedback:
- removed useUiFilters custom hook, derives memoized uiFilters from urlParams with useMemo and use the obj ref in dependency array
- modified the layout of environments filter to use EuiFlex components
- added 'Select environment' label to seperator, changed capitalization to 'Not defined' option
- set services table set column widths to 40%,20% for first 2 cols, and added space to comma separated list of environments
- added tests for generating environment es filters

* [APM] rename getUiFilters -> useUiFilters since it's based on useMemo
2019-05-21 18:50:03 -04:00
Tiago Costa
f062c97302
chore(NA): merge and solve conflicts with 7.x (#34645) 2019-04-05 19:14:26 +01:00
Søren Louv-Jansen
c10b793afa
[APM] Replace omitLegacyData with includeLegacyData (#34426) (#34446) 2019-04-03 17:08:35 +02:00
Tyler Smalley
c4bd17ff05
[linting] Enforce relative paths for X-Pack modules (#34349) (#34370)
* Add module-migration support for toRelative

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2019-04-02 11:23:44 -07:00
Søren Louv-Jansen
cbf9034f6a
[APM] Fix missing ML data, and NaN issue (#34333) (#34351) 2019-04-02 17:28:54 +02:00
Søren Louv-Jansen
decb5ee0c1
[APM] Show warning about unmigrated legacy data (#34164) (#34319) 2019-04-02 08:54:46 +02:00
Søren Louv-Jansen
a6f73579f1
[APM] Filter out 6.x data (#30828) (#30867) (#34317) 2019-04-01 23:22:39 +02:00
Jason Rhodes
674a6aa2ef
Fix branch frozen indices (#29970)
* Adds frozen index param to ES queries

* Added include frozen setting to debug output

* Updates tests with new request method
2019-02-04 17:02:13 -05:00
Jason Rhodes
e8f7d9e8b7
APM Metrics, UI Baseline (#26608)
* Service detail page refactor with TS conversions

* Adds error group list back to the service details page tabs

* Fixes after rebasing upstream master

* Adds integrations menu and flyouts, with no-transaction ML job creation and lookup

* WIP adds memory usage chart with fake data

* Adds error group distribution chart to metrics tab

* Metrics "memory" chart data flow from server to chart

* Server side query and transform set up for cpu charts

* CPU charts created

* Review feedback and watcher flyout

* Server tests added, broken tests fixed

* Review feedback

* Fixes up type problems

* Converts metric key paths to constants

* Fixes error group type issue after rebasing from master

* Makes transaction type filterable on transactions list tab

* Review feedback

* Chart formatting tweaks and fixes

* Fixes y-axis ticks for GB chart

* Restores machine learning annotations with some test fixes

* Continued styling and other review based changes

* More review fixes and cleanup

* Updated chartGroupProps -> hoverXHandlers

* Removes "type" column from transaction list table

* Re-centers around using urlParams

* Fixes panel item references in service integrations menu

* Serves default transaction type from /transactions route

* Reverts tooltip series ordering change

* Adds a clarification note about route config

* Makes it possible to request transaction chart data without specifying type

* Fixes empty series problem for memory chart

* Fixes tests

* Review feedback

* Fixes after rebase

* Replaces boolean casted array#find with array#some
2018-12-19 13:27:21 -05:00
Josh Dover
08fd427125
Establish pattern for typing legacy plugins (#26045)
* Add legacy types and export them for plugins
* Add support for core_plugins to import from 'kibana'
2018-12-17 12:52:21 -06:00
Søren Louv-Jansen
d3330a6ea9
[APM] Add rest_total_hits_as_int to all ES requests (#26462) 2018-12-06 12:49:09 +01:00
Søren Louv-Jansen
76122665b9
[APM] Get rid of pre middleware (#26256)
Rename apmIndexPattern to apmIndexPatternTitle and narrow down search query

Fix tests

Remove unused aggregation

Revert "Rename apmIndexPattern to apmIndexPatternTitle and narrow down search query"

This reverts commit 5aa86744a0b360ceb75a59ebc8a0a084b24fbe50.
2018-11-28 10:10:41 +01:00
Søren Louv-Jansen
acff23e810
[APM] Migrate to Typescript and refactor backend apis (#25848) 2018-11-22 10:30:25 +01:00
Josh Dover
27e5406d7a
Upgrade Hapi in legacy platform to v17 (#21707)
* Disable even-better monitoring

* Upgrade to Hapi v15

* Upgrade to Hapi v16

* Handle optional req params correctly

* Update http and kbnServer

* Get mocha tests passing

* Convert `reply` usages [wip]

* Fix Joi and Plugin incompatibilities

* Get server up and running

* Get basic logging working

* Fix optimizer

* Fix recent route handlers

* Various fixes

* Fix recent routes

* Upgrade wreck for async/await

* Fix mocha tests

* Fix joi issues

* Fix xpack jest tests

* Fix recent routes

* Fix tests

* Fix index setup

* Decouple monitoring stats collection from good plugin

* Update reload logging test to work

* Reimplement logging with updated good plugin

* Fix unit tests

* Fix getConnections back

* Make LegacyLoggingServer compatible with Hapi v17

* Update joi types

* Fix x-pack unit tests

* Remove stray debugger

* Remove hapi-compat

* Fix API integrations

* Upgrade boom

* Fix security plugin

* Misc fixes

* bump

* Fix licensePreRoutingFactory

* Fix failing integration tests

* Remove unnecessary test change

* Remove hapi-latest package

* fx

* Various cleanup

* Fix race condition in oppsy events

* Use elastic/good fork

* Fix boom.wrap and hapi-latest changes

* Simplify LegacyLoggingServer updates

* package.json cleanup + test fix

* yarn.lock cleanup

* Change good tag

* Fixes

* Change return err -> throw err in routes

* Fix await returns

* Fix new load_data test

* Make cookie security flags consistent

* tmp doc

* Fix types

* Fix tests

* Upgrade canvas plugin

* Move good package to published @elastic/good one

* Fix SO test

* Fix logging reloading

* Update APM apis

* Fix error logging

* Fix logging test

* Convert spaces plugin

* Add validation error shim

* Remove 7.0 release notes

* Await renderApp

* Fix ccr routes

* Prevent header popovers from scrolling with page content (#23850)

* Fix spaces test

* new yarn.lock-s

* Fix spaces tests

* Remove h2o2-latest

* Fix @types/hapi

* Upgrade InfraOps plugin

* Fix package.json

* Add back isSameSite: false

* Upgrade beats_management plugin

* Update snapshot

* Fix InfraOps

* Upgrade kql_telemetry

* Merge upstream/master

* Upgrade apm and ml

* Put snapshot test back

* Fx beats

* Upgrade rollups

* Update boom usages in new plugins
2018-10-25 16:01:12 -05:00
Søren Louv-Jansen
3151da280b [APM] Distributed Tracing (#24062)
* Adds traces overview with mock data (#22628)
* Updates service overview snapshots
* Adds tests for ManagedTable and ImpactBar
* Refactored transaction overview to use new managed table component
* Removed jsconfig file in apm
* [APM] Distributed tracing - Trace details (waterfall) (#22763)
* [APM] Add typescript to waterfall (#23635)
* [APM] Migrate get_trace and constants to Typescript (#23634)
* [APM] Add types for setup_request (#23762)
* [APM] Adds trace overview queries and some refactoring (#23605)
* ImpactBar component to align EuiProgress usage for impact bars
* Sharing some logic between transaction and trace queries
* Typescript support
* Quick fix ‘banana’
* [APM] Ensure backwards compatibility for v1 and v2 (#23636)
* Make interfaces versioned
* Rename eventType to docType
* Fixes trace links on traces overview (#24089)
* [APM] use react-redux-request (#24117)
* Updated yarn lockfile for new yarn version
* Updated dependency issues for react-router-dom types
* [APM] Display transaction info on span flyout (#24189)
* [APM] Display transaction info on span flyout
* Brings in real location and url param data for transaction flyout
* Converts flyout to TS
* Adds query param state for flyouts with ts support
* Updates styles and uses EuiTabs for transaction flyout
* [APM] Transaction flyout
* [APM] Minor docs cleanup (#24325)
* [APM] Minor docs cleanup
* [APM] Fix issues with v1 spans (#24332)
* [APM] Add agent marks (#24361)
* [APM] Typescript migration for the transaction endpoints (#24397)
* [APM] DT transaction sample header (#24294)

Transaction sample header completed
* Fixes link target for traces overview to include trans/trace ids as query params
* Converts Transaction index file to TS
* Adds trace link to sample section
* Refactors the trace link and applies it to two usages
* Implements transaction sample action context menu
* Calculates and implements duration percentage
* Re-typed how transaction groups work
* Fixes transaction flyout links and context menu
* Removes unnecessary ms multiplication
* Removes unused commented code
* Finalizes infra links
* Fixes some type shenanigans
2018-10-23 16:34:23 -04:00