kibana

mirror of https://github.com/elastic/kibana.git synced 2025-04-21 08:19:33 -04:00

History

Frank Hassanabad 3a289aa77e [Security Solutions] Removes tech debt of exporting all from linter rule for security_solution plugin (#120188 ) (#120270 ) ## Summary See: https://github.com/elastic/kibana/issues/110903 This removes the top level API `export ` spots from: `security_solution` plugin by removing _all_ the exports from `security_solution/common/index.ts` since non of those were shared outside this plugin. Look at the metrics from the build below and you will see _huge_ drops off numbers across the board for required API documentation to the page load size. In the file `security_solution/common/index.ts` I now put the advice of: ``` // Careful of exporting anything from this file as any file(s) you export here will cause your page bundle size to increase. // If you're using functions/types/etc... internally it's best to import directly from their paths than expose the functions/types/etc... here. // You should _only_ expose functions/types/etc... that need to be shared with other plugins here. ``` But really I doubt we will have to share anything from `security_solutions` plugin to another plugin or expose it for anyone else. So I think this is 👍 the way forward to not expose anything directly from `security_solution/common/index.ts` anymore.	2021-12-02 13:48:13 -07:00
..
services	[Security Solutions] Removes tech debt of exporting all from linter rule for security_solution plugin (#120188 ) (#120270 )	2021-12-02 13:48:13 -07:00
ftr_provider_context.ts	[kbn/test] move types/ftr into src (#99555 )	2021-05-17 09:51:53 -07:00

Frank Hassanabad 3a289aa77e

[Security Solutions] Removes tech debt of exporting all from linter rule for security_solution plugin (#120188 ) (#120270 )

## Summary

See: https://github.com/elastic/kibana/issues/110903

This removes the top level API `export *` spots from:
* `security_solution` plugin

by removing _all_ the exports from `security_solution/common/index.ts` since non of those were shared outside this plugin. Look at the metrics from the build below and you will see _huge_ drops off numbers across the board for required API documentation to the page load size.

In the file `security_solution/common/index.ts` I now put the advice of:

 ```
// Careful of exporting anything from this file as any file(s) you export here will cause your page bundle size to increase.
// If you're using functions/types/etc... internally it's best to import directly from their paths than expose the functions/types/etc... here.
// You should _only_ expose functions/types/etc... that need to be shared with other plugins here.
```

But really I doubt we will have to share anything from `security_solutions` plugin to another plugin or expose it for anyone else. So I think this is 👍 the way forward to not expose anything directly from `security_solution/common/index.ts` anymore.

2021-12-02 13:48:13 -07:00

services

[Security Solutions] Removes tech debt of exporting all from linter rule for security_solution plugin (#120188 ) (#120270 )

2021-12-02 13:48:13 -07:00

ftr_provider_context.ts

[kbn/test] move types/ftr into src (#99555 )

2021-05-17 09:51:53 -07:00