mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 09:48:58 -04:00
304cb256cf
## Summary
close https://github.com/elastic/kibana/issues/161545
close https://github.com/elastic/kibana/issues/153257
This PR makes `SavedObjectFinder` component backward compatible. It is
achieved by going through content- management layer, more technical
details
[here](https://docs.google.com/document/d/1ssYmqSEUPrsuCR4iz8DohkEWekoYrm2yL4QR_fVxXLg/edit)
### Testing
`SavedObjectFinder` is this component that allows to pick a saved object
(supports: `search` `index-pattern` `map` `visualization` `lens`
`event-annotation-group`:
It is used in the following places:
- Dashboard
- Add panel
- Replace panel
- Discover - Open Search
- Visualization - Select search as a source for new viz
- Graph - select source
- Cases - markdown editor add lens
- ML (3 places)
- Canvas - select embeddable panel
- Transform
- Lens > select event annotation
### Risks / Follow up
The `SavedObjectFinder` should stay mostly the same, the only notable
functional change is that now `SavedObjectFinder` doesn't support
`includeFields` which allowed partial saved object returns, this was
done to make the call backward-compatible without making the system even
more complicated as otherwise we'll need a way to abstract
`includeFields` from so attributes and allow to run migrations on it
before making a search. follow up issue to bring it back
https://github.com/elastic/kibana/issues/163043
The risk with that is that some client that have a lot of large objects
might run into performance issues when using `SavedObjectFinder`. This
can be mitigated by changing listing limit in advanced setting from
default 1000 to something lower
52 lines
1 KiB
JSON
52 lines
1 KiB
JSON
{
|
|
"type": "plugin",
|
|
"id": "@kbn/canvas-plugin",
|
|
"owner": "@elastic/kibana-presentation",
|
|
"description": "Adds Canvas application to Kibana",
|
|
"plugin": {
|
|
"id": "canvas",
|
|
"server": true,
|
|
"browser": true,
|
|
"configPath": [
|
|
"xpack",
|
|
"canvas"
|
|
],
|
|
"requiredPlugins": [
|
|
"bfetch",
|
|
"charts",
|
|
"data",
|
|
"dataViews",
|
|
"embeddable",
|
|
"expressionError",
|
|
"expressionImage",
|
|
"expressionMetric",
|
|
"expressionRepeatImage",
|
|
"expressionRevealImage",
|
|
"expressionShape",
|
|
"expressions",
|
|
"features",
|
|
"inspector",
|
|
"presentationUtil",
|
|
"visualizations",
|
|
"uiActions",
|
|
"share",
|
|
"contentManagement",
|
|
"savedObjectsFinder"
|
|
],
|
|
"optionalPlugins": [
|
|
"home",
|
|
"reporting",
|
|
"spaces",
|
|
"usageCollection",
|
|
"savedObjects",
|
|
],
|
|
"requiredBundles": [
|
|
"kibanaReact",
|
|
"kibanaUtils",
|
|
"lens",
|
|
"maps",
|
|
"visualizations",
|
|
"fieldFormats"
|
|
],
|
|
}
|
|
}
|