kibana/x-pack/plugins/lists
Kibana Machine 0be4e96091
[8.12] [Exceptions][Value Lists] Add file type and size constraints to value list uploads (#8507) (#176074) (#176375)
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Exceptions][Value Lists] Add file type and size constraints to value
list uploads (#8507)
(#176074)](https://github.com/elastic/kibana/pull/176074)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2024-02-07T09:22:19Z","message":"[Exceptions][Value
Lists] Add file type and size constraints to value list uploads (#8507)
(#176074)\n\n## Summary\r\n\r\nAddresses
https://github.com/elastic/security-team/issues/8507\r\n\r\nWith these
changes we address the issue where users can upload any file\r\nto be
imported as a value list.\r\n\r\nThe restrictions are:\r\n* Users should
be limited to uploading .txt or .csv. All other file\r\ntypes should
return a 415.\r\n* Users should be limited to uploading files of 9K
bytes size. Files\r\nlarger than that should return a 413.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ESS
97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5019)\r\n-
[Serverless
97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5020)","sha":"c38410affe0bccd61884b58a41b7bda48c78d86f","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:
SecuritySolution","Team:Detection Engine","8.13
candidate","v8.13.0","v8.12.2","v7.17.19"],"title":"[Exceptions][Value
Lists] Add file type and size constraints to value list uploads
(#8507)","number":176074,"url":"https://github.com/elastic/kibana/pull/176074","mergeCommit":{"message":"[Exceptions][Value
Lists] Add file type and size constraints to value list uploads (#8507)
(#176074)\n\n## Summary\r\n\r\nAddresses
https://github.com/elastic/security-team/issues/8507\r\n\r\nWith these
changes we address the issue where users can upload any file\r\nto be
imported as a value list.\r\n\r\nThe restrictions are:\r\n* Users should
be limited to uploading .txt or .csv. All other file\r\ntypes should
return a 415.\r\n* Users should be limited to uploading files of 9K
bytes size. Files\r\nlarger than that should return a 413.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ESS
97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5019)\r\n-
[Serverless
97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5020)","sha":"c38410affe0bccd61884b58a41b7bda48c78d86f"}},"sourceBranch":"main","suggestedTargetBranches":["8.12","7.17"],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176074","number":176074,"mergeCommit":{"message":"[Exceptions][Value
Lists] Add file type and size constraints to value list uploads (#8507)
(#176074)\n\n## Summary\r\n\r\nAddresses
https://github.com/elastic/security-team/issues/8507\r\n\r\nWith these
changes we address the issue where users can upload any file\r\nto be
imported as a value list.\r\n\r\nThe restrictions are:\r\n* Users should
be limited to uploading .txt or .csv. All other file\r\ntypes should
return a 415.\r\n* Users should be limited to uploading files of 9K
bytes size. Files\r\nlarger than that should return a 413.\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ESS
97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5019)\r\n-
[Serverless
97\r\ntimes](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5020)","sha":"c38410affe0bccd61884b58a41b7bda48c78d86f"}},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.19","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
2024-02-07 03:48:18 -07:00
..
.storybook [Lists][Exceptions] - Adding basic linting, i18n and storybook support (#94772) 2021-03-16 21:46:20 -04:00
common [Security Solution][API testing] Move and restructures Lists APIS (#171992) 2023-11-28 16:40:09 +01:00
public [EDR Workflows] Add matches capabilities to Endpoint Exception creation (#166002) 2023-12-05 01:59:45 -07:00
scripts chore(NA): eslint rule for disallowing naked eslint-disable (#136408) 2022-07-19 17:11:04 +01:00
server [8.12] [Exceptions][Value Lists] Add file type and size constraints to value list uploads (#8507) (#176074) (#176375) 2024-02-07 03:48:18 -07:00
jest.config.js [jest] update config files to get coverage per plugin (#111299) 2021-09-09 08:14:56 +02:00
kibana.jsonc [Security Solution] Clean up CODEOWNERS and other files for the Detection Engine team (#159729) 2023-06-14 10:39:50 -07:00
README.md
tsconfig.json Split the .kibana saved objects index into multiple indices (#154888) 2023-04-25 09:43:42 +02:00

README.md for developers working on the backend lists on how to get started using the CURL scripts in the scripts folder.

The scripts rely on CURL and jq:

Install curl and jq (mac instructions)

brew update
brew install curl
brew install jq

Open $HOME/.zshrc or ${HOME}.bashrc depending on your SHELL output from echo $SHELL and add these environment variables:

export ELASTICSEARCH_USERNAME=${user}
export ELASTICSEARCH_PASSWORD=${password}
export ELASTICSEARCH_URL=https://${ip}:9200
export KIBANA_URL=http://localhost:5601
export TASK_MANAGER_INDEX=.kibana-task-manager-${your user id}
export KIBANA_INDEX=.kibana-${your user id}

source $HOME/.zshrc or ${HOME}.bashrc to ensure variables are set:

source ~/.zshrc

Open your kibana.dev.yml file and add these lines with your name:

xpack.lists.listIndex: '.lists-your-name'
xpack.lists.listItemIndex: '.items-your-name'

Restart Kibana and ensure that you are using --no-base-path as changing the base path is a feature but will get in the way of the CURL scripts written as is.

Go to the scripts folder cd kibana/x-pack/plugins/lists/server/scripts and run:

./hard_reset.sh
./post_list.sh

which will:

  • Delete any existing lists you have
  • Delete any existing list items you have
  • Delete any existing exception lists you have
  • Delete any existing exception list items you have
  • Delete any existing mapping, policies, and templates, you might have previously had.
  • Add the latest list and list item index and its mappings using your settings from kibana.dev.yml environment variable of xpack.lists.listIndex and xpack.lists.listItemIndex.
  • Posts the sample list from ./lists/new/ip_list.json

Now you can run

./post_list.sh

You should see the new list created like so:

{
  "id": "ip_list",
  "created_at": "2020-05-28T19:15:22.344Z",
  "created_by": "yo",
  "description": "This list describes bad internet ip",
  "name": "Simple list with an ip",
  "tie_breaker_id": "c57efbc4-4977-4a32-995f-cfd296bed521",
  "type": "ip",
  "updated_at": "2020-05-28T19:15:22.344Z",
  "updated_by": "yo"
}

You can add a list item like so:

 ./post_list_item.sh

You should see the new list item created and attached to the above list like so:

{
  "id": "hand_inserted_item_id",
  "type": "ip",
  "value": "127.0.0.1",
  "created_at": "2020-05-28T19:15:49.790Z",
  "created_by": "yo",
  "list_id": "ip_list",
  "tie_breaker_id": "a881bf2e-1e17-4592-bba8-d567cb07d234",
  "updated_at": "2020-05-28T19:15:49.790Z",
  "updated_by": "yo"
}

If you want to post an exception list it would be like so:

./post_exception_list.sh

You should see the new exception list created like so:

{
  "created_at": "2020-05-28T19:16:31.052Z",
  "created_by": "yo",
  "description": "This is a sample endpoint type exception",
  "id": "bcb94680-a117-11ea-ad9d-c71f4820e65b",
  "list_id": "endpoint_list",
  "name": "Sample Endpoint Exception List",
  "namespace_type": "single",
  "tags": [
    "user added string for a tag",
    "malware"
  ],
  "tie_breaker_id": "86e08c8c-c970-4b08-a6e2-cdba7bb4e023",
  "type": "endpoint",
  "updated_at": "2020-05-28T19:16:31.080Z",
  "updated_by": "yo"
}

And you can attach exception list items like so:

{
  "comments": [],
  "created_at": "2020-05-28T19:17:21.099Z",
  "created_by": "yo",
  "description": "This is a sample endpoint type exception",
  "entries": [
    {
      "field": "actingProcess.file.signer",
      "operator": "included",
      "type": "match",
      "value": "Elastic, N.V."
    },
    {
      "field": "event.category",
      "operator": "included",
      "type": "match_any",
      "value": [
        "process",
        "malware"
      ]
    }
  ],
  "id": "da8d3b30-a117-11ea-ad9d-c71f4820e65b",
  "item_id": "endpoint_list_item",
  "list_id": "endpoint_list",
  "name": "Sample Endpoint Exception List",
  "namespace_type": "single",
  "os_types": ["linux"],
  "tags": [
    "user added string for a tag",
    "malware"
  ],
  "tie_breaker_id": "21f84703-9476-4af8-a212-aad31e18dcb9",
  "type": "simple",
  "updated_at": "2020-05-28T19:17:21.123Z",
  "updated_by": "yo"
}

You can then do find for each one like so:

./find_lists.sh
{
  "cursor": "WzIwLFsiYzU3ZWZiYzQtNDk3Ny00YTMyLTk5NWYtY2ZkMjk2YmVkNTIxIl1d",
  "data": [
    {
      "id": "ip_list",
      "created_at": "2020-05-28T19:15:22.344Z",
      "created_by": "yo",
      "description": "This list describes bad internet ip",
      "name": "Simple list with an ip",
      "tie_breaker_id": "c57efbc4-4977-4a32-995f-cfd296bed521",
      "type": "ip",
      "updated_at": "2020-05-28T19:15:22.344Z",
      "updated_by": "yo"
    }
  ],
  "page": 1,
  "per_page": 20,
  "total": 1
}

or for finding exception lists:

./find_exception_lists.sh
{
  "data": [
    {
      "created_at": "2020-05-28T19:16:31.052Z",
      "created_by": "yo",
      "description": "This is a sample endpoint type exception",
      "id": "bcb94680-a117-11ea-ad9d-c71f4820e65b",
      "list_id": "endpoint_list",
      "name": "Sample Endpoint Exception List",
      "namespace_type": "single",
      "os_types": ["linux"],
      "tags": [
        "user added string for a tag",
        "malware"
      ],
      "tie_breaker_id": "86e08c8c-c970-4b08-a6e2-cdba7bb4e023",
      "type": "endpoint",
      "updated_at": "2020-05-28T19:16:31.080Z",
      "updated_by": "yo"
    }
  ],
  "page": 1,
  "per_page": 20,
  "total": 1
}

See the full scripts folder for all the capabilities.